[11:49] <jelmer> allenap: :-)
[12:26] <jelmer> allenap: When you're done reviewing your lunch options, any chance I can add two more branches to your queue?
[13:40] <bac> hi sinzui
[13:40] <sinzui> hi bac
[13:40] <bac> sinzui: could you have a look at the diff i just pasted to https://code.edge.launchpad.net/~bac/launchpad/bugjam-579502/+merge/44302
[13:40] <bac> i'd like to send this off to ec2 soon
[13:46] <sinzui> bac: I see you changed  _known_viewers() to ensure that owner have access
[13:46] <bac> sinzui: yes, i wanted your feedback specifically on that approach.
[13:46] <sinzui> bac: I see it always returns a set, but the doc string says dict
[13:46] <bac> it seemed the least intrusive
[13:47] <sinzui> I think we should fix the doc string
[13:47] <bac> good catch!
[13:47] <sinzui> bac: will that be the same spot to add drivers, and bug supervisors?
[13:48] <bac> sinzui: with some careful review I think it might.
[13:49] <sinzui> I think I will look at that method in january
[13:50] <sinzui> bac; you are aware that the owner can only assign teams he is a member of to the bug supervisor role?
[13:51] <bac> sinzui: i am but i don't see how that relates.  what am i missing?
[13:52] <sinzui> Every believes the owner can private bugs. But that is not true since he can leave the team, he could change the team, but that new team will not be subscribed to the bugs...
[13:52] <sinzui> Your change makes Lp work as users expect...even Canonical employees
[13:56] <bac> ah, a subtly i missed
[13:56] <bac> er subtlety
[13:58] <bac> sinzui: so, landable?
[13:58] <sinzui> yes please
[14:08] <allenap> jelmer: Certainly :)
[15:13] <leonardr> allenap, jcsackett, i have an launchpadlib branch coming up that's oversize, but mostly due to method renames
[15:14] <allenap> leonardr: Okay, I can take a look at that.
[15:15] <leonardr> will let you know once i write mp
[15:53] <jcsackett> bac: can you follow up on https://code.launchpad.net/~jelmer/launchpad/693757-py2.7-compat/+merge/44566 for me?
[15:53] <bac> jcsackett: sure
[15:53] <jcsackett> thanks.
[16:17] <leonardr> allenap: https://code.launchpad.net/~leonardr/launchpadlib/separate-login-for-cronjob/+merge/44592
[16:19] <allenap> leonardr: It says there's a conflict in src/launchpadlib/tests/test_launchpad.py
[16:24] <henninge> jcsackett: Hi! I have to leave now but it would be great if you could look at my MP. It's fairly straight forward UI stuff.
[16:24] <jcsackett> henninge: i can look at the code portion, but i'm not a ui reviewer.
[16:24] <henninge> jcsackett: that's fine
[16:25] <henninge> https://code.launchpad.net/~henninge/launchpad/devel-bugjamming-2/+merge/44590
[16:25] <henninge> thank you!
[16:25] <jcsackett> henninge: no problem.
[16:42] <leonardr> allenap: hmmm, i just updated, let me check
[16:42] <leonardr> ah, i updated but didn't merge
[16:56] <allenap> leonardr: Cheers.
[16:56] <leonardr> allenap: should be fixed now
[17:35] <jcsackett> bac: can you follow up on https://code.launchpad.net/~henninge/launchpad/devel-bugjamming-2/+merge/44590 for me, when you get a chance?
[17:35] <bac> jcsackett: ok
[17:35] <jcsackett> thanks.
[17:48] <bac> jcsackett: done
[17:52] <jcsackett> bac, thanks. :-)
[17:52] <jcsackett> although, on the MP, i see that sinzui is still doing reviews, so perhaps i can stop bothering you and pester him.
[19:18] <jcsackett> sidnei: it works better to get reviewers attention if you leave a message in the room with the MPs and put your name in the queue than just throwing the MPS in the queue in the channel info.
[19:22] <jcsackett> i've got to run out to lunch, i'll be back here for reviews in a bit.
[19:48] <sidnei> jcsackett, i  couldn't remember which way it was, thanks!
[21:19] <jcsackett> bac: i've done sidnei's first MP: https://code.launchpad.net/~sidnei/lazr-js/static-resource-prefix/+merge/44271. can you follow up?