=== bac` is now known as bac
=== matsubara is now known as matsubara-lunch
=== matsubara-lunch is now known as matsubara
=== salgado is now known as salgado-lunch
=== salgado-lunch is now known as salgado
=== benji is now known as benji-lunch
=== gary_poster is now known as gary-lunch
=== benji-lunch is now known as benji
=== gary-lunch is now known as gary_poster
=== salgado is now known as salgado-afk
=== bac changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: []  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:30] <bac> jcsackett: i know this isn't your OCR day but care to do a review?
[21:30] <jcsackett> bac: sure.
=== matsubara is now known as matsubara-afk
[21:33] <bac> jcsackett: thanks.  https://code.launchpad.net/~bac/launchpad/bug-693357/+merge/45075
[21:39] <jcsackett> bac: any chance you could also take a look at one for me?
[21:39] <bac> jcsackett: sure
[21:39] <jcsackett> cool. https://code.launchpad.net/~jcsackett/launchpad/mergeproposal-status-icon-589584/+merge/44531
[21:40] <jcsackett> thanks, bac.
[21:41] <jcsackett> bac, are there any tests for get PPAOwnedByPerson?
[21:41] <bac> jcsackett: just those in the doc test
[21:42] <jcsackett> bac: okay. soyuz is nasty enough i'm not going to suggest trying to build new tests for it--they makesourcepackage stuff is fairly slow and cumbersome.
[21:43] <bac> jcsackett: your branch looks more interesting
[21:43] <jcsackett> bac: it is and it isn't. :-P
[21:43] <jcsackett> it's only interesting because the template bit has irritating  bits. :-P
[21:48] <jcsackett> bac: i see at the bottom of your diff the default for has_packages in the method is None; given that it's a boolean switch, shouldn't the default be False, just for readability?
[21:49] <bac> jcsackett: yeah, probably.  i originally thought about None, True, False but abandoned that idea.  i'll make the change
[21:50] <jcsackett> bac: cool. thanks.
[21:52] <jcsackett> bac: r=me. i have requested follow up from sinzui.
[21:52] <bac> jcsackett: thanks
[21:52] <jcsackett> one day, i hope, i will not have to append that last sentence when ending reviews. :-)
[22:19] <sinzui> bac: I approved your branch
[22:19] <bac> sinzui: i saw that and have sent it off to ec2.  thank you.
[22:21] <bac> jcsackett: i approved your branch.  you may want to give gavin a chance to look it over, though, out of courtesy.  unless you're super itchy to land it.
[22:26] <jcsackett> bac: i'm not super itchy, just wanted to get a stamp on it in case gavin is out for a while. if he's back tomorrow i'm going to poke him.
[22:27] <bac> jcsackett: perfect
[22:27] <jcsackett> thanks for the review.
=== rockstar is now known as rockstar`
=== rockstar` is now known as rockstar