| wgrant | StevenK: I can has review? | 05:24 |
|---|---|---|
| StevenK | wgrant: Suppose | 05:25 |
| StevenK | wgrant: Can haz link? | 05:25 |
| wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/bug-694004-log-parser-glob/+merge/45201 | 05:26 |
| StevenK | thumper: https://code.launchpad.net/~wgrant/launchpad/bug-694004-log-parser-glob/+merge/45201 when you can | 05:28 |
| thumper | done | 06:04 |
| StevenK | thumper: Ta | 06:05 |
| StevenK | wgrant: ^ | 06:05 |
| wgrant | thumper, StevenK: Thanks. | 06:05 |
| wgrant | Julian may unkill me tonight. | 06:05 |
| StevenK | If it lands and gets QA'd? :-) | 06:06 |
| mrevell | Hello | 08:58 |
| === matsubara-afk is now known as matsubara | ||
| === leonardr is now known as leonardr-afk | ||
| === mrevell is now known as mrevell-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| flacoste | me | 15:05 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin, benji || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === matsubara-lunch is now known as matsubara | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado is now known as salgado-lunch | ||
| === leonardr-afk is now known as leonardr | ||
| abentley | Edwin, benji: Could you please review https://code.launchpad.net/~abentley/launchpad/bzr-2.2.2-lp-1/+merge/45258 ? | 16:35 |
| benji | abentley: sure, on it now | 16:35 |
| abentley | benji, thanks. | 16:35 |
| === abentley changed the topic of #launchpad-reviews to: On call: Edwin, benji || reviewing: -, abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| benji | abentley: do you want a review of the changes to bzr or just the version bump? | 16:40 |
| abentley | benji, just the version bump. The changes in lp:bzr/2.2 were reviewed by the Bazaar team. | 16:41 |
| benji | abentley: ok, in that case: the change looks fine, other than running the tests myself (which I assume you'll do so via ec2 land or have already done) I don't see anything more I can do there; also, if I understand https://dev.launchpad.net/PolicyAndProcess/OptionalReviews correctly, you could have self-reviewed the change | 16:45 |
| abentley | benji, I don't believe in optional reviews. In this case, you could have balked and insisted I write up a test plan, for example. | 16:46 |
| === salgado-lunch is now known as salgado | ||
| abentley | benji, or you could have asked me to include only the fixes I mentioned, rather than using the tip of lp:bzr/2.2 | 16:47 |
| benji | perhaps I should have reviewed the bzr change, but as-is I'm assuming that the bzr guys' review would have cought anything that I would; other than that I can't see any reason not to approve | 16:48 |
| === deryck[lunch] is now known as deryck | ||
| benji | if the tests pass, I'd rather track 2.2 than diverge further from it because I have reason to believe that the bzr guys do a reasonable job in choosing what changes to make there; I assume we don't have a policy regarding that so I feel free following my personal guidelines in that respect | 16:51 |
| benji | I'll try to distill this conversation a little and put that in an approval message; shortly after that Edwin-afk can be summoned from the beyond to review my review | 16:52 |
| benji | Edwin-afk: when you have a chance, I need a review of my review of https://code.launchpad.net/~abentley/launchpad/bzr-2.2.2-lp-1/+merge/45258 | 17:05 |
| EdwinGrubbs | benji: I'm on it | 17:05 |
| benji | thanks | 17:06 |
| === benji is now known as benji-lunch | ||
| EdwinGrubbs | abentley: is the NotBranchError.__repr__() a temporary hack? Will its superclass' __repr__() be simplified also? I'm worried that there isn't a comment to prevent warn someone to not remove the __repr__() that looks redundant. | 17:56 |
| === gary_poster is now known as gary-lunch | ||
| === benji-lunch is now known as benji | ||
| abentley | EdwinGrubbs, I didn't write this, but it was intended to be a minimal fix because 2.2 is a stable branch. In fact, they were not expecting any further changes to it. | 18:34 |
| abentley | EdwinGrubbs, mbp's comment in https://code.launchpad.net/~spiv/bzr/just-add-repr-687653-2.2/+merge/43319/ is that there are better fixes, like deleting the code (that does the fancy formatting). | 18:35 |
| EdwinGrubbs | abentley: ok, that should be fine. I approved it already. It's fine that a better fix is down the road. | 18:36 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: On call: Edwin, benji || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gary-lunch is now known as gary_poster | ||
| === henninge_ is now known as henninge | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| benji | leonardr: I made two tiny changes to the MP you approved yesterday (https://code.edge.launchpad.net/~benji/launchpad/bug-669701/+merge/45171) and would like to at least give you a chance to object; the incremental diff is at http://pastebin.ubuntu.com/550813/ | 21:20 |
| benji | leonardr: I want to make a couple more small changes, but I'm going to get them reviewed by Edwin so you're off the hook | 21:53 |
| leonardr | benji: ok, cool | 21:53 |
| leonardr | i can take a look at the small changes if you want | 21:53 |
| benji | EdwinGrubbs: I have a couple of small changes to a branch that was reviewed yesterday (see my last comment on https://code.edge.launchpad.net/~benji/launchpad/bug-669701/+merge/45171), do you have time to take a look? The change is pretty small (http://pastebin.ubuntu.com/550823/) but lets us fix two additional bugs with the one branch. | 21:56 |
| EdwinGrubbs | benji: I'll look at it in a few minutes. | 21:58 |
| benji | great, thanks | 21:58 |
| EdwinGrubbs | benji: why is the name of the logger shown in the browser when submitting changes? | 22:36 |
| benji | EdwinGrubbs: Martin requested it here: https://bugs.launchpad.net/launchpad/+bug/670019/comments/4 | 22:37 |
| _mup_ | Bug #670019: audit facility for feature flags <feature-flags> <lp-foundations> <Launchpad itself:Triaged by benji> < https://launchpad.net/bugs/670019 > | 22:37 |
| EdwinGrubbs | benji: review sent. Just one minor comment. | 22:44 |
| benji | thanks | 22:45 |
| === benji changed the topic of #launchpad-reviews to: On call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | ||
| === gary_poster is now known as gary-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!