=== matsubara-afk is now known as matsubara === allenap changed the topic of #launchpad-reviews to: On call: Edwin, allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [11:48] jcsackett: Do you fancy a review? 400 lines, nothing very controversial. https://code.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823-3/+merge/45349 [12:20] allenap: sure, i can take a look at that. is it time sensitive? still eating breakfast. :-) [12:23] allenap: looks like all your activereviews already have comments--safe bet someone has already gotten to the one you needed? [12:24] nm; i see those are both screenshots from you. which MP did you need? [12:51] jcsackett: No rush, https://code.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823-3/+merge/45349 [12:51] Thank you! [13:12] allenap: I have a small JS branch for you if you're initerested. [13:12] Or indeed interested. [13:12] gmb: I'm doing one of your js branches already. === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: gmb || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [13:13] allenap: Ah, cool. Since I've only got one in the queue, it's likely to be the same one. :) === allenap changed the topic of #launchpad-reviews to: On call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [13:13] gmb: And I just finished it :) [13:14] Hurrah for small units of work. [13:19] allenap: Ta for the review. I've made the necessary changes. [13:19] gmb: Cool. [13:55] allenap, I have a branch to fix the recent buildbot failures [13:55] https://code.launchpad.net/~leonardr/launchpadlib/correct-test-failure/+merge/45370 [13:55] failure; https://lpbuildbot.canonical.com/builders/lucid_lp/builds/496/steps/shell_6/logs/summary === jcsackett changed the topic of #launchpad-reviews to: On call: allenap, jcsackett || reviewing: -,- || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === gary-afk is now known as gary_poster [14:01] jcsackett: -^ [14:06] leonardr: i've looked over it and it looks good. i'm requesting follow up from sinzui, since i'm being mentored. [14:06] ok [14:07] jcsackett: there's also going to be a launchpad branch which just bumps up the launchpadlib used from 1.9.0 to 1.9.1 [14:08] i'll be happy to look at that whenever, since that will be an easy one. it may be a candidate for self review, however (not sure if we formally started doing that). [14:08] leonardr ^ [14:08] leonardr: I need the testsuite fix I landed today used by Launchpad soon. [14:08] (launchpadlib testsuite that is) [14:09] stub: ok, did you already do this work? [14:09] leonardr: Yes, landed today. One line change to a doctest. [14:09] ah, that is a different one line change to a doctest [14:10] well, it'll go in to 1.9.1 as well [14:10] Cool. Once launchpadlib tests stop assuming the Librarian is running on port 58000 the sooner I can land this Librarian branch. === matsubara is now known as matsubara-lunch [14:20] jcsackett: here's the launchpad branch: https://code.launchpad.net/~leonardr/launchpadlib/launchpad-integration/+merge/45381 [14:22] leonardr: r=me. request for sinzui to follow up already made. [14:22] thanks [14:22] np. i like those one line reviews. :-P [14:28] sinzui: ping. I'm trying to speed up leonardr's testfix review, so I'd like your permission to approve jcsackett's reviews [14:30] go ahead [14:32] thank you [14:32] approved === jcsackett changed the topic of #launchpad-reviews to: On call: allenap, jcsackett || reviewing: -,allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews === jcsackett changed the topic of #launchpad-reviews to: On call: allenap, jcsackett || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [14:57] allenap: some questions and comments on your MP. [14:57] jcsackett: Cheers, thanks. === salgado is now known as salgado-lunch === matsubara-lunch is now known as matsubara [16:02] hi allenap, could you do a bugs review for me? [16:02] bac: Sure. [16:02] https://code.launchpad.net/~bac/launchpad/bug-5927/+merge/45403 [16:02] thanks allenap === allenap changed the topic of #launchpad-reviews to: On call: allenap, jcsackett || reviewing: bac, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:06] salgado, do you want to do a UI review of https://code.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823-3/+merge/45349 === salgado-lunch is now known as salgado [16:22] sinzui, sure! [16:45] thanks allenap [16:45] bac: Welcome :) === allenap changed the topic of #launchpad-reviews to: On call: allenap, jcsackett || reviewing: -, - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [16:47] abentley: Can you have a look at https://code.launchpad.net/~leonardr/launchpad/publish-tokens-2/+merge/34123. I don't know if it's still relevant, but it might warrant an updated vote from you. [16:48] abentley, allenap: that code is landed, though possibly not in that branch [16:49] leonardr: Awesome, okay. [16:49] leonardr, ACK. [16:50] abentley, allena: actually, what happened was we decided to take an alternate approach [16:50] leonardr, please mark the proposal rejected, then. [16:50] i'll mark the branch as abandoned [16:53] allenap, I'm reviewing the UI of your subscription filter branch and am wondering what they're for... [16:54] salgado: Hehe :) [16:54] salgado: They are a new feature, so you can subscribe to a subset of bug mail. [16:54] salgado: So you could subscribe to only mail for a particular tag, or set of statuses. [16:56] allenap, ok, and when you want to subscribe to everything then there are no filters -- just the usual structural subscription? [16:56] salgado: Yes, exactly like that. [16:56] allenap, but as soon as you add a filter, you only get what matches that filter? [16:58] salgado: Yes, and if there are multiple filters for a subscription they are ORed together. [16:59] salgado: So you could have a filter for Fix Committed bugjam2010 bugs, another for open Critical bugs, and you'd get mail for both. [16:59] right [17:05] allenap, I'm wondering if it'd make sense to add a sentence to each subscription with filters stating that the user will only get email for bugs matching at least one of the filters? that was not clear to me at first [17:05] salgado: Okay, that makes sense. I can move the repeating "Bug mail filter" bit up and add an explanation. [17:07] allenap, or maybe it could be at the top of the page so that we don't repeat it when there are multiple subscriptions with filters? [17:08] salgado: Okay, that's cool too. Do you know of an example I can crib? [17:10] allenap, you mean just the text? I'll think of something [17:10] salgado: Yeah, thanks. [17:14] allenap, are structural subscriptions used for anything other than bug mail? [17:14] salgado: Blueprints, in theory. [17:20] allenap, hmm, then I think it'd be weird to talk about bugmail at the top when the subscriptions are not just for bugs. /me thinks of something else [17:21] salgado: I have an idea... I'll get a screen-grab for you. [17:21] allenap, great! [17:22] salgado: http://people.canonical.com/~gavin/ui/sub-search-ui-bug-656823-3/+structural-subscriptions,%20v2.png === benji is now known as benji-lunch [17:26] I like that [17:26] salgado: \o/ Cool. [17:27] allenap, do you think it's worth to mention before the filters that messages that match any of them will go through? [17:28] to make it clear that it's not just messages that match all of them that go through [17:30] salgado: Mmm. I'm on the fence about that. I'll scratch my head for a few minutes. Maybe there's a clearer way to denote that. [17:32] I'm not very fond of that either, but I don't think it's 100% clear that the filters are ORed together [17:40] salgado: I have to go now, but I'll try to come up with something later. [17:40] Thank you :) === allenap changed the topic of #launchpad-reviews to: On call: jcsackett || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [17:40] allenap, np. I'll suggest something on the MP and maybe sinzui will have other ideas as well === henninge changed the topic of #launchpad-reviews to: On call: jcsackett || reviewing: - || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:08] jcsackett: Hi! ;) [18:08] henninge, hello! [18:09] i'm going to guess i know what you need reviewed. :-) [18:09] No need to guess ... [18:09] https://code.launchpad.net/~henninge/launchpad/db-devel-697845-import-failure/+merge/45422 [18:09] :) === benji-lunch is now known as benji [18:09] henninge, it's sort of frightening when an MP begins "Boy, how do I explain this..." :-P [18:10] jcsackett: well, with message sharing and upstream-ubuntu sharing, translations is acquiring soyuz qualities when it comes to domain knowledge. [18:11] Some will argue it has always been that way ... [18:11] lol. [18:17] henninge: so if i understand your notes, the new approach here aims to be more inclusive, rather than the very restrictive approach before? [18:17] exactly [18:19] jcsackett: old, basic message sharing shared translations between all series within a distribution source package or between all series in a proudct. [18:19] jcsackett: the new approach links those two sides using the packaging links. [18:19] henninge: okay. [18:20] jcsackett: "new" is "recife" [18:20] henninge: right. [18:21] jcsackett: but it must retain the old notion of "all series within a distribution are sharing translations" [18:21] and same for product [18:22] jcsackett: but the first implementation of this did not do that but would exclude a distroseries if its sourcepackage was linked to a different product than the others series [18:23] but we have those situations in our database [18:23] * jcsackett nods. [18:23] i can follow that. [18:24] jcsackett: so, as you stated correctly, this approach now looks at all series of distribution source package and the products that the packaging links point to. [18:24] looking from the other side its "all series of a product and the source packages they are linked to". [18:25] this is the old sharing behavior *plus* templates from the "other side", not a completely new behavior. [18:25] jcsackett: EOT ;) [18:25] :-) [18:27] jcsackett, Could I interest you in reviewing https://code.launchpad.net/~abentley/launchpad/stale-targets/+merge/45418 ? [18:27] abentley, i would be happy to, right after i finish henninge's. === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || reviewing: henninge || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:27] jcsackett, tx [18:29] henninge, i gather the somewhat frightening subquery in _queryBySourcePackageName is the searching via packaging links? [18:29] yes ;) [18:29] cool. as big as that is, it's still not terrible to understand. [18:31] it's the same in _queryByProduct, only that the subquery has to return a tuple. [18:31] distribution source pacakges are represented by the tuple (distribution, sourcepackagename) [18:31] "all packages with that name in any series of this distribution" [18:36] henninge: i'm verifying all tests pass, but as far as read through of the code, this looks good. as soon as tests pass i will mark approved and get sinzui to follow up. [18:37] thanks very much. [18:37] jcsackett: Great, thank! ;) I have to leave now but will come back later to land it. [18:37] s [18:37] sounds good. :-) [18:46] good bye! === jcsackett changed the topic of #launchpad-reviews to: On call: jcsackett || reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews [18:52] abentley: is there anything test wise to make certain the widget is showing the things it should not just showing the things it shouldn't? [18:53] i could see someone breaking the widget so it shows nothing and the test still passing, because its only affirming that something isn't there. [18:53] jcsackett, Yes, there are pagetests that cover the existing functionality. [18:53] abentley: ah, okay. [19:18] abentley: r=me. i have requested follow up from sinzui. [19:18] jcsackett, cool, thanks. === matsubara is now known as matsubara-afk === salgado is now known as salgado-afk [21:50] is there anyone who could review something for me? https://code.launchpad.net/~jcsackett/launchpad/merge-ppas-697685/+merge/45450 === gary_poster is now known as gary-afk [23:56] hi lifeless, does this look about right (re: bug 5927) ? http://pastebin.ubuntu.com/551305/ [23:56] <_mup_> Bug #5927: assignee cannot see private bug

< https://launchpad.net/bugs/5927 >