[00:34] <wgrant> Could someone please review https://code.launchpad.net/~wgrant/launchpad/bug-698349-cStringIO-unicode-funsies/+merge/45470?
[00:34] <wgrant> It is breaking the production upload processor frequently.
[00:46] <wgrant> mwhudson: Is there a right fix?
[00:46] <mwhudson> wgrant: i don't know
[00:46] <mwhudson> wgrant: "not using cStringIO" ?
[00:47] <wgrant> mwhudson: Possibly. But then you end up writing a unicode to a file, which is not broken, but still wrong.
[00:47] <mwhudson> oh right
[00:47] <mwhudson> maybe it is the right fix then :-)
[00:49] <wgrant> Now to coerce somebody into cowboying it...
[01:47] <thumper> https://code.launchpad.net/~thumper/launchpad/fix-recipe-build-oops/+merge/45319 anyone?
[01:51] <StevenK> lifeless: Would you mind mentoring my review of thumper's branch?
[01:52] <thumper> https://code.launchpad.net/~thumper/launchpad/fix-recipe-build-title/+merge/45474 is dependent of the first
[01:59] <thumper> StevenK: I suppose it would be bad for me to mentor your review of my change :)
[01:59] <thumper> StevenK: mumble?
[02:00] <StevenK> thumper: Sure, give me a few minutes?
[02:00] <thumper> StevenK: sure
[02:05] <StevenK> thumper: Ready when you are
[02:06] <thumper> StevenK: ack, let me just chat with kids briefly
[02:49] <StevenK> win 40
[02:49] <StevenK> Oops
[03:07] <thumper> mwhudson: feel like mentoring StevenK's reviews?  I would but they are for my work
[03:08] <mwhudson> thumper: link me up
[03:15] <thumper> mwhudson: https://code.launchpad.net/~thumper/launchpad/fix-recipe-build-oops/+merge/45319
[03:16] <thumper> mwhudson: https://code.launchpad.net/~thumper/launchpad/fix-recipe-build-title/+merge/45474
[03:16] <thumper> mwhudson: and thanks
[03:32] <mwhudson> dammit my brain isn't working
[03:32]  * mwhudson attempts to get it going
[03:32] <mwhudson> too damn humid
[03:36] <StevenK> It's 25degC and threatning to rain here ...
[03:43] <mwhudson> well yeah, but you're in sydney
[03:43] <mwhudson> apparently it's 19.4 here and 77% humidity
[03:43] <mwhudson> feels like both are higher though
[03:44] <mwhudson> thumper: erm
[03:44] <mwhudson> thumper: doesn't https://code.launchpad.net/~thumper/launchpad/fix-recipe-build-oops/+merge/45319 mean changing the url of every build ever?
[03:44] <thumper> yep
[03:45] <thumper> mwhudson: since the opaque id is still opaque, just different, it seems fine
[03:45] <mwhudson> is that not going to cause some grief?
[03:45] <thumper> it shouldn't
[03:45] <mwhudson> e.g. mail archives
[03:45] <thumper> wgrant seems ok with it :)
[03:45] <thumper> ah...
[03:45] <mwhudson> i guess people don't bookmark builds
[03:45] <thumper> maybe...
[03:45] <thumper> historical builds aren't that interesting
[03:47] <mwhudson> thumper: i also don't understand why lib/lp/code/browser/tests/test_sourcepackagerecipe.py has changed, but that's probably just me being thick
[03:47] <wgrant> It shouldn't be too much of a problem. Old builds aren't too relevant for long.
[03:47] <wgrant> It would be nice to avoid breaking everything, though I don't see how that's possible.
[03:48] <thumper> mwhudson: the breadcrumbs changed
[03:48] <thumper> mwhudson: as the build is now under the archive
[03:48] <mwhudson> well, i guess you could have the new urls all be $archive/+newtoken/+newid
[03:48] <mwhudson> thumper: ah ok
[03:48] <mwhudson> but +build is by far the sanest value for +newtoken
[03:49] <thumper> mwhudson: I wanted the builds to be similar
[03:49] <thumper> that's why I piggy backed on the binary package build url
[03:50] <mwhudson> yeah, i can see that
[03:50] <mwhudson> i think it's probably fine
[03:50] <wgrant> We should probably clear it with bigjools first. But it's unlikely that many old URLs are going to be used much.
[03:50] <thumper> wgrant: ok
[03:52] <thumper> mwhudson: feel free to punt to bigjools
[03:52] <thumper> mwhudson: and go have a beer
[03:53] <thumper> it is almost time :)
[03:53] <mwhudson> yeah indeed
[03:53] <mwhudson> i want to make a branch to land the twisted fix that just landed though
[03:53] <thumper> which fix is that?
[04:04] <mwhudson> thumper: http://twistedmatrix.com/trac/ticket/4395 and so https://bugs.launchpad.net/bzr/+bug/556132
[04:04] <_mup_> Bug #556132: bzr: ERROR: paramiko.SSHException:  Key-exchange timed out; consistent after sending 1GB data <lp-code> <paramiko> <Bazaar:Confirmed> <Launchpad itself:Triaged> <Twisted:New> < https://launchpad.net/bugs/556132 >
[04:10] <thumper> w00t
[04:13] <mwhudson> grr
[04:34] <mwhudson> https://code.launchpad.net/~mwhudson/launchpad/include-twisted-4395-fix/+merge/45483 <- review anyone?
[04:34] <mwhudson> thumper: still by the keyboard?
[04:34] <mwhudson> oh i guess i could self review it if i liked
[07:13] <lifeless> StevenK: still need a hand?
[07:14] <StevenK> lifeless: Nope, mwhudson stood in, thanks
[13:57] <bac> hi adeuring
[13:57] <adeuring> hi bac
[13:57] <bac> busy day?
[13:58] <adeuring> bac:  just a heads-up: I'm currently looking into sutb's/sinzui's MP
[13:58] <bac> ok
[13:59] <bac> adeuring: you should push that 'claim' button!  :)
[13:59] <adeuring> bac: yeah, I'll do it ;)
[14:55] <allenap> salgado: Hi, do you have time today to have a look at the updates I've made to https://code.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823-3/+merge/45349?
[14:56] <salgado> allenap, wow, that looks really nice
[14:56] <allenap> Oh brilliant :)
[14:57] <salgado> allenap, is the +structural-subscriptions page protected or is it zope.Public?
[14:58] <allenap> salgado: launchpad.View, but anyone can view.
[14:58] <allenap> iirc
[15:00] <salgado> allenap, ok. I asked because if it was restricted to the user himself, we'd be able to avoid repeating the user's name in the sentence about filters
[15:01] <allenap> salgado: Yeah, originally I wrote "you" in several places before I realised that anyone could view it.
[15:22] <allenap> sinzui: You've already reviewed the code for https://code.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823-3/+merge/45349, so would you also have time to mentor salgado's UI review?
[15:33] <sinzui> okay
[15:34] <allenap> Thank you.
[15:34] <sinzui> allenap: you are going to hate me
[15:35] <allenap> sinzui: You *hate* it?
[15:35] <sinzui> allenap: There is a growing movement, once certainly in design/UX that italic is should not be used in interfaces
[15:35] <sinzui> they prefer bold, which you are already uses
[15:36] <sinzui> allenap: I broken this rule with the registrant line in the header
[15:36]  * sinzui is bad
[15:37] <allenap> sinzui: If that's all then I most certainly don't mind at all :) I'll replace the italics with bold.
[15:38]  * allenap suspects that's not all.
[15:38] <sinzui> allenap: I think this is good to land. I believe we will revisit all uses of italics in Lps CSS this year
[15:38] <sinzui> oh
[15:39] <allenap> sinzui: Cool. So I should leave the italics?
[15:39] <sinzui> allenap: why are the rules in side bar portlets
[15:39] <sinzui> what other pages uses them in the main content
[15:39] <allenap> sinzui: I don't know what you're talking about :)
[15:40] <sinzui> eg, shaded boxes with round corners. We just removed a few in December because they were odd
[15:41] <allenap> sinzui: Ah, they're not side-bar portlets, I just added did a diff with rounded corners to group the text with the product link, which is a bit small as a delimiter on its own.
[15:42] <sinzui> I think we should use hr or just portlet class to create a top border
[15:42] <allenap> s/diff/div/
[15:43] <allenap> sinzui: ISTR that hr has been neutered with CSS, so portlet class instead I guess, but that seems a bit semantically wrong.
[15:43] <sinzui> allenap: I think we are discovering a common problem here
[15:43] <allenap> Yeah.
[15:43] <sinzui> https://launchpad.net/prohttps://launchpad.net/projects/+index?text=gedit
[15:44] <sinzui> In our picker, we use lines between rows and shade. That is certainly the approves way, but I do not think we every uses that outside of the picker
[15:45] <sinzui> allenap: I think we should treat this as something separate from your branch. This change is only for users participating in the beta?
[15:46] <allenap> sinzui: The page is not restricted at all, by flags or otherwise, but it is not navigable other than by manipulating the URL by hand.
[15:46] <sinzui> fab
[15:47] <sinzui> You ca try portlet for now, but I will report a bug that describes the general problem with some hope that we will fix several pages when we know what is right.
[15:47] <sinzui> I approve your branch with the use of bold and the removal of the background shading
[15:48] <allenap> sinzui: Okay, thanks!
[15:50] <allenap> sinzui: Would you accept it with a #ddd border (like bug comments), with or without rounded corners?
[15:50] <sinzui> yes
[15:51] <allenap> sinzui: Fwiw, like http://people.canonical.com/~gavin/ui/sub-search-ui-bug-656823-3/+structural-subscriptions,%20v5.png
[15:52] <sinzui> the rounded corners look od
[15:52] <sinzui> interesting style though
[15:53] <allenap> sinzui: I'm fond of them but I don't mind dropping them.
[15:53] <sinzui> Do we use that style else where?
[15:53] <allenap> sinzui: I can't think that we do.
[15:54] <sinzui> allenap: They are reminiscent to Ubuntu/Canonical designs
[15:55] <allenap> sinzui: Ah, yes.
[15:57] <sinzui> I do not want to add exceptions. I think I want all comments to look like that though
[16:00] <allenap> sinzui: I'll land without rounded corners, and we can address all of these group-boxes with a class later on.
[16:00] <sinzui> I agree
[16:00] <allenap> sinzui: Cool, thank you.
[16:11] <allenap> sinzui: Interesting. Your code vote was changed into a ui vote, rather than registering both.
[16:11] <sinzui> that sucks
[18:03] <leonardr> bac: super tiny branch: https://code.launchpad.net/~leonardr/launchpadlib/fix-for-martin/+merge/45540
[18:03] <bac> ok
[18:06] <bac> leonardr: done
[18:10] <leonardr> thanks
[20:24] <abentley> bac, could you please review https://code.launchpad.net/~abentley/launchpad/no-queue-rescore/+merge/45560 ?
[20:24] <bac> abentley: sure
[20:25] <abentley> bac, also, who's our UI review manatee?
[20:25] <bac> abentley: salgado and mrevell
[20:26] <abentley> bac, thanks.
[20:33] <salgado> abentley, I may not be able to review that as I'm EOD and will be at the platform rally next week
[20:34] <abentley> salgado, Ah.  Monday would have been good enough, but if you're away, I'll ask mrevell.
[20:34] <salgado> if he can't do it on Monday, I'll try to find some time for it during the sprint
[20:36] <abentley> salgado, cool, thanks.
[20:43] <bac> hi abentley, the meat of your fix looks really good.
[20:43] <bac> abentley: stylistically, i'm a little concerned by you putting a comment before a method's docstring.
[20:43] <abentley> bac, you mean you'd rather it went after the docstring?  Before causes lint errors.
[20:43] <bac> abentley: i always thought docstrings were the first thing...have we done that elsewhere?
[20:44] <bac> abentley: it just looks funny so i thought i'd see what you thought
[20:44] <abentley> bac, I'm fine with moving it after the docstring.
[20:44] <bac> without spending too much time pondering it.
[20:44] <bac> ok.  thanks for cleaning up the lint
[20:44] <bac> i know it is a pain
[20:44] <bac> r=bac
[20:46] <abentley> bac, thanks.
[20:46] <abentley> bac, do you know whether we've handled similar error scenarios before?
[20:47] <bac> abentley: you mean to handle stale views?
[20:48] <bac> er, stale URLs i guess i should say
[20:48] <abentley> bac, yeah, situations where you shouldn't be at that view at all, whether viewing or submitting.
[20:48] <bac> i can't recall seeing it anywhere
[20:49] <abentley> bac, Cool.