=== henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: - || queue: []  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[11:19] <adeuring> moin henninge, fancy a review? https://code.edge.launchpad.net/~adeuring/launchpad/bug-607958/+merge/45675
[11:20] <henninge> adeuring: moin kollege! ;)
[11:20] <henninge> adeuring: let me see how big it is ...
[11:20] <adeuring> henninge: < 200 lines
[11:20] <henninge> 153 ...
[11:25] <henninge> adeuring: I don't understand "(Note that the timeouts mentioned in the bug report already disappeared when we switched to PostgesQL 8.3)"
[11:25] <henninge> adeuring: the bug mentions 8.4 ...
[11:26] <adeuring> henninge: that means that the query is quite fast under 8.4, compared to 8.3
[11:27] <henninge> but the bug suggests that the timeouts only started to appear on 8.4
[11:27] <henninge> "Since 8.4 - boom."
[11:28] <adeuring> henninge: well, ask lifeless for what he really meant ;) (I htink it was him who added the text "since 8.4 - boom")
[11:28] <henninge> I see ;)
[11:28] <henninge> adeuring: but you are saying that it is not currently timing out - but your fix still makes it faster?
[11:28] <adeuring> henninge: right
[11:29] <henninge> ok
[11:29] <adeuring> about twice as fast for ubuntu; for products the gain is probably bigger, though i did not test it
[12:02] <henninge> adeuring: done
[12:02] <henninge> r=me
[12:02] <adeuring> henninge: thanks!
[13:42] <StevenK> henninge: Hai! Would you have time to review https://code.launchpad.net/~stevenk/launchpad/bpb-currentcomponent-assertion-part-2/+merge/45693 ? I'm sorry it's so large :-(
=== matsubara is now known as matsubara-lunch
=== henninge_ is now known as henninge
[14:08] <leonardr> henninge: i need a really tiny launchpad branch reviewed. tiny enough that i could self-review it. but i don't know the process. can you point me to it?
[14:08] <benji> leonardr: https://dev.launchpad.net/PolicyAndProcess/OptionalReviews
[14:09] <leonardr> thanks
[14:09] <henninge> leonardr: but i can also have a look at it ...
[14:09] <henninge> ;-)
[14:12] <leonardr> henninge: https://code.launchpad.net/~leonardr/launchpad/launchpadlib-integration-2/+merge/45698
[14:20] <henninge> leonardr: r=me
[14:21] <henninge> leonardr: fwiw, you do self-approval by using [rs=leonardr], at least that's what I do.
[14:22] <leonardr> henning: cool
[14:22] <henninge> leonardr: the wiki page suggests, though, that lp-land and "ec2 land" do it automagically if you approve your own mp but I have not yet tried that.
[14:27] <henninge> StevenK: I'll put it on the queue for a little later, if that's ok
=== henninge changed the topic of #launchpad-reviews to: On call: henninge || reviewing: - || queue: [StevenK]  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== matsubara-lunch is now known as matsubara
[15:05] <StevenK> henninge: At some point today is perfectly fine. :-)
[15:48] <abentley> mrevell, could you do a UI review of https://code.launchpad.net/~abentley/launchpad/no-queue-rescore/+merge/45560 please?
[15:51] <bac> hi allenap, would you have time to do a re-review of my branch from last week?  https://code.edge.launchpad.net/~bac/launchpad/bug-5927/+merge/45403
[15:51] <allenap> bac: Sure.
[15:51] <bac> thanks
[15:59] <mrevell> abentley, With pleasure. I'll take a look.
[15:59] <abentley> mrevell, thanks.
[16:25] <benji> henninge: I have a launchpadlib branch ready for reivew: https://code.edge.launchpad.net/~benji/launchpadlib/delayed-keyring-import/+merge/45711
=== benji changed the topic of #launchpad-reviews to: On call: henninge || reviewing: - || queue: [StevenK, benji]  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== deryck is now known as deryck[lunch]
=== benji is now known as benji-lunch
[17:14] <bac> thanks for the review allenap
[17:14] <allenap> bac: You're welcome.
=== henninge changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [StevenK]  || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[17:42] <henninge> StevenK: I didn't manage to do yours, sorry. I have to go now.
[17:43] <StevenK> henninge: Rargh!
[17:43] <StevenK> henninge: Wait until next week :-P
[17:44] <henninge> StevenK: Well, it *is* oversized ... :-P
[17:44] <StevenK> henninge: :-(
[17:44] <henninge> Sorry
[17:44] <StevenK> henninge: Don't make me print out the diff and hit you with it :-)
[17:45] <henninge> Oh no! that'd be a very heavy bat!
[17:45] <henninge> ;)
=== deryck[lunch] is now known as deryck
=== gary_poster is now known as gary-lunch
=== gary-lunch is now known as gary_poster
=== matsubara is now known as matsubara-afk