| === Ursinha-afk is now known as Ursinha | ||
| bac | #startmeeting | 15:01 |
|---|---|---|
| MootBot | Meeting started at 09:01. The chair is bac. | 15:01 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:01 |
| jtv | me | 15:01 |
| EdwinGrubbs | me | 15:01 |
| jcsackett | me | 15:01 |
| mrevell | me | 15:01 |
| sinzui | me | 15:01 |
| adeuring | me | 15:01 |
| mars | me! | 15:01 |
| jelmer | me | 15:01 |
| leonardr | me | 15:01 |
| henninge | me | 15:02 |
| benji | me | 15:02 |
| gary_poster | me? does it matter to wait for the rollcall? | 15:02 |
| * gary_poster assumes not | 15:02 | |
| bac | nah | 15:02 |
| gary_poster | cool | 15:02 |
| gmb | me | 15:02 |
| bigjools | me then | 15:02 |
| deryck | me | 15:02 |
| flacoste | me | 15:02 |
| deryck | me can't resist me | 15:02 |
| gary_poster | heh | 15:02 |
| bac | gmb: welcome, i think | 15:02 |
| mars | ? | 15:03 |
| gmb | bac: ? | 15:03 |
| bac | mars: i was about to announce gmb's regrets but i see, do to travel mess up, he's here anyway | 15:03 |
| bac | sorry for being cryptic | 15:03 |
| gary_poster | heh | 15:03 |
| gary_poster | gmb, happy you're around, I think ;-) | 15:04 |
| gmb | bac: Ah, yes, forgot to update the wiki page. | 15:04 |
| gmb | gary_poster: Thanks, I think ;) | 15:04 |
| gary_poster | :-) | 15:04 |
| bac | let's do this informal and hopefully speedy today | 15:04 |
| bac | there are no new agenda items | 15:04 |
| bac | jelmer: a couple of meetings back you volunteered to update the wiki regarding style guide for api_ naming. did you get to that? | 15:05 |
| jelmer | bac: No, I wasn't aware that was one of my action items. I'll do it after the meeting. | 15:07 |
| bac | jelmer: there was some confusion. if you don't mind that would be great. | 15:07 |
| bac | [topic] * Mentat update. | 15:07 |
| MootBot | New Topic: * Mentat update. | 15:07 |
| bac | * Salgado (ui) | 15:07 |
| bac | * StevenK (code) | 15:07 |
| bac | * Benji (code) | 15:07 |
| bac | * JCSackett (code) | 15:07 |
| bac | * MRevell (ui) | 15:07 |
| bac | any comments from the mentats or mentors? mrevell i saw you got some UI reviews recently | 15:08 |
| sinzui | We have had some UI review requests. It could not find mrevell or salgado yesterday to do one | 15:08 |
| StevenK | I've not done OCR this week, due to timezones. | 15:09 |
| bac | salgado is probably unavailable this week | 15:09 |
| mrevell | bac, I'd like a chat about the review I did. sinzui Sorry, I was on calls. | 15:09 |
| bac | StevenK: have you been gettin any reviews in general? | 15:09 |
| sinzui | I wonder if mentats are missing from the UI review team | 15:09 |
| * sinzui looks | 15:09 | |
| bac | "gettin'" -- i'm practicing for next week | 15:09 |
| StevenK | bac: Er, some. :-) | 15:10 |
| jcsackett | i've noticed that reviews have definitely picked back up on my OCR shift. | 15:10 |
| gary_poster | EdwinGrubbs is leaving soon, so we should figure out what that means for benji's mentat process | 15:10 |
| bac | good point gary_poster | 15:10 |
| bac | benji i'd be happy to take over if you'd like | 15:11 |
| sinzui | rock needs to add mrevell and salgado to https://launchpad.net/~launchpad-ui-reviewers | 15:11 |
| benji | sounds good | 15:11 |
| bac | sinzui: i'll ask him to do that. thanks for the heads up. | 15:11 |
| sinzui | We need more admins on that team to ensure we can control who gets the requests for reviews | 15:11 |
| bac | sinzui: you, perhaps? | 15:12 |
| sinzui | 4 members need to be removed too | 15:12 |
| bac | [topic] thunderdome reviewer throw down | 15:12 |
| MootBot | New Topic: thunderdome reviewer throw down | 15:12 |
| sinzui | Yes me. I fear rockstar will not com back from U1. I suspect there will only ever be 2 UI reviewers at a time | 15:12 |
| bac | reminder, we're going to have a couple of sessions next week about the state of reviews. if you have comments you'd like to make to me please do so soonish. i welcome all input | 15:13 |
| flacoste | sinzui: rockstart will come back, it's a rotation, not a move :-) | 15:13 |
| sinzui | barry | 15:13 |
| bac | [topic] other stuff? open floor. | 15:14 |
| MootBot | New Topic: other stuff? open floor. | 15:14 |
| mars | sinzui, we also have Huw with us now | 15:14 |
| flacoste | bac: do we have a wiki page with the list of requested topics | 15:14 |
| flacoste | for the thunderdome | 15:14 |
| flacoste | i've put two sessions on the schedule to discuss review topics | 15:14 |
| bac | flacoste: no, but that's a fine idea. i'll do it this morning | 15:14 |
| flacoste | would be good to have a wiki page so that people can prepare for these | 15:14 |
| flacoste | sinzui: barry was the first, and an exception | 15:15 |
| StevenK | What do you mean by Thunderdome Reviewer Throw down? | 15:15 |
| flacoste | all reviewers gets in, and one gets out :-) | 15:15 |
| bigjools | you need to wear body armour | 15:15 |
| bac | StevenK: just we've got two 1 hour session scheduled to talk about our review process and how to improve it | 15:15 |
| StevenK | Crap | 15:15 |
| mars | StevenK, is that an objective opinion? :) | 15:15 |
| mrevell | :) | 15:15 |
| StevenK | I'll let you know 30 minutes into the first thrown down session | 15:16 |
| bac | any other topics? | 15:16 |
| henninge | Does anybody disagree if I update the "Python Test Cases" section a bit? | 15:16 |
| bigjools | thumper will win | 15:16 |
| henninge | https://dev.launchpad.net/TestsStyleGuide#Python Test Cases | 15:16 |
| bac | henninge: i guess it depends on what you write. :) | 15:16 |
| jtv | whoo didn't see _that_ answer coming! | 15:17 |
| henninge | It still sounds like they are a nice alternative to doctests. | 15:17 |
| henninge | whereas nowadays we strongly prefer them. | 15:17 |
| gary_poster | bac, we'll figure out what to do about EdwinGrubbs / benji later? | 15:17 |
| gary_poster | oh duh | 15:18 |
| gary_poster | you said you'd do it | 15:18 |
| gary_poster | sorry | 15:18 |
| gary_poster | awesome thanks | 15:18 |
| bac | np | 15:18 |
| henninge | Also, the recommended use of comments in asserts does not match our common practice. | 15:18 |
| henninge | We usually don't add comments. | 15:18 |
| henninge | Things like that. | 15:18 |
| bac | henninge: i think we aspire to have comments in asserts... | 15:18 |
| henninge | we do? | 15:19 |
| gmb | henninge: You do if I'm reviewing it. | 15:19 |
| jtv | I have a suspicion that that note migrated from "assert" to TestCase.assert* | 15:19 |
| * gmb removes grumpy trousers, goes back to sitting in the corner. | 15:19 | |
| gmb | ... that sounded better in my head. | 15:19 |
| flacoste | bac: i think we don't do comments much nowadays because of testtools awesomeness | 15:19 |
| StevenK | Bwahaa | 15:19 |
| flacoste | many assetions method build a decent comment automatically | 15:19 |
| henninge | flacoste: that's what I thought | 15:19 |
| jtv | AIUI we always required a failure string for "assert" in regular code. As flacoste says, TestCase.assert* is usually better at composing messages for tests. | 15:20 |
| henninge | In fact, I was once asked by reviewer (in my early days) to remove the comments because of that and never has anybody asked me to add them. | 15:20 |
| bac | flacoste: good point | 15:20 |
| henninge | ok, I'll update that. | 15:20 |
| bac | henninge: thank you. | 15:20 |
| bac | any other topics? | 15:21 |
| StevenK | Bring on the epic! | 15:21 |
| jtv | "Long-winded, old story characterized by the absence of character development"? | 15:21 |
| bac | ok, see you next week. bring a sweater. | 15:21 |
| bac | #endmeeting | 15:21 |
| MootBot | Meeting finished at 09:21. | 15:21 |
| jelmer | :-) thanks bac | 15:21 |
| StevenK | A? I think bring 2 or 3 | 15:21 |
| bigjools | s/epic/thunderdome/ | 15:22 |
| jtv | I volunteer to be the sweater—I can go right back to the tropics. ☺ | 15:22 |
| === Ursinha is now known as Ursinha-afk | ||
| === gary_poster is now known as gary-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === gary-afk is now known as gary_poster | ||
| === benji is now known as benji-lunch | ||
| === Ursinha is now known as Ursinha-lunch | ||
| === benji-lunch is now known as benji | ||
| === gary_poster is now known as gary-lunch | ||
| === EdwinGrubbs is now known as Edwin-afk2 | ||
| === gary-lunch is now known as gary_lunch | ||
| === gary_lunch is now known as gary_poster | ||
| === Edwin-afk2 is now known as EdwinGrubbs | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!