=== Ursinha-afk is now known as Ursinha [15:01] #startmeeting [15:01] Meeting started at 09:01. The chair is bac. [15:01] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me! [15:01] me [15:01] me [15:02] me [15:02] me [15:02] me? does it matter to wait for the rollcall? [15:02] * gary_poster assumes not [15:02] nah [15:02] cool [15:02] me [15:02] me then [15:02] me [15:02] me [15:02] me can't resist me [15:02] heh [15:02] gmb: welcome, i think [15:03] ? [15:03] bac: ? [15:03] mars: i was about to announce gmb's regrets but i see, do to travel mess up, he's here anyway [15:03] sorry for being cryptic [15:03] heh [15:04] gmb, happy you're around, I think ;-) [15:04] bac: Ah, yes, forgot to update the wiki page. [15:04] gary_poster: Thanks, I think ;) [15:04] :-) [15:04] let's do this informal and hopefully speedy today [15:04] there are no new agenda items [15:05] jelmer: a couple of meetings back you volunteered to update the wiki regarding style guide for api_ naming. did you get to that? [15:07] bac: No, I wasn't aware that was one of my action items. I'll do it after the meeting. [15:07] jelmer: there was some confusion. if you don't mind that would be great. [15:07] [topic] * Mentat update. [15:07] New Topic: * Mentat update. [15:07] * Salgado (ui) [15:07] * StevenK (code) [15:07] * Benji (code) [15:07] * JCSackett (code) [15:07] * MRevell (ui) [15:08] any comments from the mentats or mentors? mrevell i saw you got some UI reviews recently [15:08] We have had some UI review requests. It could not find mrevell or salgado yesterday to do one [15:09] I've not done OCR this week, due to timezones. [15:09] salgado is probably unavailable this week [15:09] bac, I'd like a chat about the review I did. sinzui Sorry, I was on calls. [15:09] StevenK: have you been gettin any reviews in general? [15:09] I wonder if mentats are missing from the UI review team [15:09] * sinzui looks [15:09] "gettin'" -- i'm practicing for next week [15:10] bac: Er, some. :-) [15:10] i've noticed that reviews have definitely picked back up on my OCR shift. [15:10] EdwinGrubbs is leaving soon, so we should figure out what that means for benji's mentat process [15:10] good point gary_poster [15:11] benji i'd be happy to take over if you'd like [15:11] rock needs to add mrevell and salgado to https://launchpad.net/~launchpad-ui-reviewers [15:11] sounds good [15:11] sinzui: i'll ask him to do that. thanks for the heads up. [15:11] We need more admins on that team to ensure we can control who gets the requests for reviews [15:12] sinzui: you, perhaps? [15:12] 4 members need to be removed too [15:12] [topic] thunderdome reviewer throw down [15:12] New Topic: thunderdome reviewer throw down [15:12] Yes me. I fear rockstar will not com back from U1. I suspect there will only ever be 2 UI reviewers at a time [15:13] reminder, we're going to have a couple of sessions next week about the state of reviews. if you have comments you'd like to make to me please do so soonish. i welcome all input [15:13] sinzui: rockstart will come back, it's a rotation, not a move :-) [15:13] barry [15:14] [topic] other stuff? open floor. [15:14] New Topic: other stuff? open floor. [15:14] sinzui, we also have Huw with us now [15:14] bac: do we have a wiki page with the list of requested topics [15:14] for the thunderdome [15:14] i've put two sessions on the schedule to discuss review topics [15:14] flacoste: no, but that's a fine idea. i'll do it this morning [15:14] would be good to have a wiki page so that people can prepare for these [15:15] sinzui: barry was the first, and an exception [15:15] What do you mean by Thunderdome Reviewer Throw down? [15:15] all reviewers gets in, and one gets out :-) [15:15] you need to wear body armour [15:15] StevenK: just we've got two 1 hour session scheduled to talk about our review process and how to improve it [15:15] Crap [15:15] StevenK, is that an objective opinion? :) [15:15] :) [15:16] I'll let you know 30 minutes into the first thrown down session [15:16] any other topics? [15:16] Does anybody disagree if I update the "Python Test Cases" section a bit? [15:16] thumper will win [15:16] https://dev.launchpad.net/TestsStyleGuide#Python Test Cases [15:16] henninge: i guess it depends on what you write. :) [15:17] whoo didn't see _that_ answer coming! [15:17] It still sounds like they are a nice alternative to doctests. [15:17] whereas nowadays we strongly prefer them. [15:17] bac, we'll figure out what to do about EdwinGrubbs / benji later? [15:18] oh duh [15:18] you said you'd do it [15:18] sorry [15:18] awesome thanks [15:18] np [15:18] Also, the recommended use of comments in asserts does not match our common practice. [15:18] We usually don't add comments. [15:18] Things like that. [15:18] henninge: i think we aspire to have comments in asserts... [15:19] we do? [15:19] henninge: You do if I'm reviewing it. [15:19] I have a suspicion that that note migrated from "assert" to TestCase.assert* [15:19] * gmb removes grumpy trousers, goes back to sitting in the corner. [15:19] ... that sounded better in my head. [15:19] bac: i think we don't do comments much nowadays because of testtools awesomeness [15:19] Bwahaa [15:19] many assetions method build a decent comment automatically [15:19] flacoste: that's what I thought [15:20] AIUI we always required a failure string for "assert" in regular code. As flacoste says, TestCase.assert* is usually better at composing messages for tests. [15:20] In fact, I was once asked by reviewer (in my early days) to remove the comments because of that and never has anybody asked me to add them. [15:20] flacoste: good point [15:20] ok, I'll update that. [15:20] henninge: thank you. [15:21] any other topics? [15:21] Bring on the epic! [15:21] "Long-winded, old story characterized by the absence of character development"? [15:21] ok, see you next week. bring a sweater. [15:21] #endmeeting [15:21] Meeting finished at 09:21. [15:21] :-) thanks bac [15:21] A? I think bring 2 or 3 [15:22] s/epic/thunderdome/ [15:22] I volunteer to be the sweater—I can go right back to the tropics. ☺ === Ursinha is now known as Ursinha-afk === gary_poster is now known as gary-afk === Ursinha-afk is now known as Ursinha === gary-afk is now known as gary_poster === benji is now known as benji-lunch === Ursinha is now known as Ursinha-lunch === benji-lunch is now known as benji === gary_poster is now known as gary-lunch === EdwinGrubbs is now known as Edwin-afk2 === gary-lunch is now known as gary_lunch === gary_lunch is now known as gary_poster === Edwin-afk2 is now known as EdwinGrubbs === Ursinha is now known as Ursinha-afk