[00:02] <huwshimi> sinzui: Could it have something to do with me checking in those font changes after you approving it?
[02:03] <sinzui> huwshimi: sorry. I was summed to make dinner for my family. I approved the MP and I see you pushed your revision, so I expect ec2 land your branch
[02:11] <huwshimi> sinzui: No problems. The issue is when I run ec2 land it complains that the branch isn't approved. Any ideas?
[02:11] <sinzui> looks approved to me
[02:11] <huwshimi> sinzui: yeah, me too!
[02:11] <sinzui> maybe it thinks it needs a code review too
[02:11] <sinzui> I will add that
[02:12] <huwshimi> Ah right that might be it
[02:13] <sinzui> I changed my review to code and ui
[02:13] <sinzui> note that I cannot have two separate reviews. That oddness leads to confusion
[02:14] <huwshimi> Great, it's working now. Thanks for that
[02:21] <lifeless> there is a bug on that
[09:07] <allenap> Good morning adeuring :) Mind if I enqueue myself for a review?
[09:07] <adeuring> allenap: sure, go ahead. Give a few minutes to read mails ;)
[09:08] <allenap> adeuring: Cheers.
=== allenap changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [allenap] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[09:57] <adeuring> allenap: r=me
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:10] <allenap> adeuring: Thanks!
[10:20] <wgrant> adeuring: Hi.
[10:20] <adeuring> wgrant: hi; already looking at your LFA branch :)
[10:21] <wgrant> adeuring: Thanks!
[10:21] <wgrant> adeuring: If you end up getting to the others, note that bug-629835-copier-architectures depends on bug-701383-ppa-component-override.
[10:21] <adeuring> ok
[10:38] <allenap> adeuring: I've got another one for you, short though. https://code.launchpad.net/~allenap/launchpad/sub-search-ui-bug-656823-6/+merge/46246
[10:39] <adeuring> allenap: I'm currently looking at a branch from StevenK; when I've finished that one, I'll look at yours
[10:40] <allenap> adeuring: Thank you :)
=== allenap changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [allenap] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[10:56] <adeuring> allenap: r=me
[10:56] <allenap> adeuring: Thank you!
=== matsubara-afk is now known as matsubara
=== adeuring changed the topic of #launchpad-reviews to: On call: adeuring || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== adeuring changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== mrevell is now known as mrevell-lunch
[12:51] <gmb> allenap, deryck: Could one of you good fellows review my 200-line JS refactoring in https://code.edge.launchpad.net/~gmb/launchpad/prepare-for-alpha-features-bug-699719/+merge/46254?
[12:52] <gmb> It's incremental towards fixing bug 699719
[12:52] <_mup_> Bug #699719: Update the subscription JS to use the new subscription widget <story-better-bug-notification> <Launchpad itself:In Progress by gmb> < https://launchpad.net/bugs/699719 >
[13:00] <deryck> gmb: I can take it.
[13:01] <gmb> deryck: Thanks.
[13:01] <deryck> np
[13:35] <deryck> gmb: so this is a pure code move?  Just moving all the event stuff into a wrapping function?
[13:36] <gmb> deryck: Yep. It turned out to be the simplest way of doing what I wanted to do. Now I can set a boolean flag before callign setup_bugtask_index and the advanced subscriptions stuff will be enabled.
[13:36] <gmb> Implementationally speaking it's a hack, but it's not the ugliest hack in the world.
[13:36] <deryck> gmb: yeah, it's not bad.  it's cleaner code anyway.  at least this part.  r=me.
[13:39] <gmb> deryck: Thanks.
[13:39] <deryck> gmb: np
=== mrevell-lunch is now known as mrevell
[14:17] <jtv> Any reviewers about?
[14:17] <jtv> https://code.launchpad.net/~jtv/launchpad/bug-702832/+merge/46261
[14:31] <StevenK> Rargh, Abel disappeared without reviewing my branch
[14:37] <gmb> StevenK: He's travelling to Dallas. How big's your branch?
[14:37] <StevenK> gmb: 737 lines (+188/-455) 3 files modified
[14:38] <StevenK> gmb: It is ongoing work to kill a 1,600 line doctest, does that sweeten the deal?
[14:38] <gmb> StevenK: I'll take a look at it within the next half hour.
[14:38] <gmb> And yes, that helps :)
[14:38] <gmb> StevenK: Send me a link and I'll claim the review
[14:38] <StevenK> gmb: https://code.launchpad.net/~stevenk/launchpad/bpb-currentcomponent-assertion-part-3/+merge/46209
[14:39] <gmb> Righto. I'll ping you when I'm done
=== matsubara is now known as matsubara-lunch
=== jtv changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== EdwinGrubbs changed the topic of #launchpad-reviews to: On call: - || reviewing: - || queue: [jtv,Edwin] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[15:31] <gmb> StevenK: r=me; There are a few instances of "# Test that ..." that need to be turned into a statement of expected behaviour, but I know you'll take care of those.
[15:32] <gmb> StevenK: Is it worth getting someone with more domain knowledge than I to check that we haven't lost anything in the transition?
[15:33] <StevenK> gmb: You can if you wish -- do you feel we need to?
[15:35] <gmb> StevenK: I don't know. I don't know nuffink about Soyuz. That's why I asked you :)
[15:35] <gmb> StevenK: If you're confident, I'm happy to trust your judgement.
[15:35] <StevenK> gmb: I'll get bigjools to have a quick glance.
[15:35] <StevenK> bigjools: *hint*
[15:35] <bigjools> meh
[15:37] <StevenK> bigjools: If you don't care, then we'll go with gmb's r=
[15:38] <bigjools> StevenK: url?
[15:38] <StevenK> It's only test fixes, what could possibly go wrong
[15:38] <StevenK> https://code.launchpad.net/~stevenk/launchpad/bpb-currentcomponent-assertion-part-3/+merge/46209
[15:38] <bigjools> my eyes
[15:39] <gmb> Woah, hang on...
[15:39] <gmb> Have I managed to miss a big chunk in the middle here?
[15:40] <bigjools> those tests are insanely hard to follow
[15:40] <gmb> Erk, PEBKAC on my part.
[15:41] <gmb> I've missed part of the diff here.
[15:42] <bigjools> so from a domain PoV it's fine, but I'm worried about the readability
[15:43] <bigjools> some comments in test_copy_archive_without_leak would not go amiss
[15:43] <gmb> Oh, nice.
[15:43] <gmb> StevenK: So, I agree with bigjools.
[15:44] <gmb> Also, the setUp() method for your first testcase.
[15:44] <gmb> Needs comments.
[15:44] <gmb> And I need to find out what made my browser refuse to show me the end of the page.
[15:44] <gmb> But that can wait.
[15:44] <bigjools> I don't know what leak means in that context either
[15:46] <StevenK> bigjools: So I add two builds to the primary archive, copy them to a .COPY archive, createMissingBuilds() and then verify that looking up getBuildRecords returns *one*, not two
[15:48] <bigjools> StevenK: so I would recommend changing the comment at the very top to explain that
[15:48] <bigjools> and then break the code up into sections with a comment at the top of each
[15:48] <StevenK> Okay
[15:49] <StevenK> gmb: So, please point out which bits you feel that needs more comments on the MP
[15:50] <gmb> StevenK: Will do. Sorry for the slack-arsed review. There's a lesson in this: don't ask me to do anything important on a Friday afternoon.
[15:50] <StevenK> gmb: I didn't, you offered :-)
[15:50] <gmb> StevenK: Then never let me offer to do anything.
[15:51] <StevenK> Haha
[16:00] <leonardr> sinzui, do you approve https://code.launchpad.net/~leonardr/launchpadlib/remove-xslt/+merge/46167 ? the mp is still waiting on your input
=== deryck is now known as deryck[lunch]
=== matsubara-lunch is now known as matsubara
[16:06] <sinzui> okay
[16:07] <leonardr> sinzui: while you're at it, maybe you can review this one-line change: https://code.launchpad.net/~leonardr/launchpadlib/fix-upload-tarball/+merge/46276
[16:08] <sinzui> leonardr, I am so sorry i did not update the MP. It is approved
[16:08] <leonardr> ok, cool
[16:09] <sinzui> leonardr, does this mean we have bad historic content-types in the db?
[16:09] <leonardr> sinzui: no, the bad content type is in the script
[16:09] <sinzui> okay.
[16:09] <leonardr> launchpad is ignoring the bad type and using text/html instead
[16:09] <sinzui> r=me
[16:10] <leonardr> our releases of lazr.restful etc. have the same problem, but nobody installs them using easy_install, so people only complain about beautiful soup
[16:10] <sinzui> even web forms are hard to use without working menus
[16:53] <benji> darn, the lack of reviewers for this time of day on Friday always catches me off guard
[17:00] <salgado> benji, how big is your branch?  maybe I can help
[17:01] <benji> salgado: here's the branch https://code.launchpad.net/~benji/launchpad/bug-636193 I haven't written a MP yet, but if you have time to look at it I'll write one up.
[17:03] <salgado> benji, it looks simple enough; I'll take it
[17:04] <StevenK> gmb: Still around?
[17:04] <salgado> benji, but there seems to be a conflict between your branch and mainline
[17:04] <benji> salgado: I'll take a look at that and then get you a MP; thanks
=== deryck[lunch] is now known as deryck
[17:07] <salgado> benji, wow, the diff is big. by looking at the bug's description I thought it'd be simple.  I don't think I'll be able to do it as I'm on a sprint right now, sorry
[17:07] <benji> salgado: no problem, I appreciate the attempt :)
=== benji is now known as benji-lunch
=== gary_poster is now known as gary-lunch
=== benji-lunch is now known as benji
=== gary-lunch is now known as gary_poster
=== matsubara is now known as matsubara-afk
[21:32] <EdwinGrubbs> sinzui: do you want to review my branch? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-663857-product-packages-timeout/+merge/46222
[21:37] <sinzui> kay
[21:37] <sinzui> okay
[21:38] <StevenK> sinzui: Has Unity given in yet?
[21:38] <sinzui> StevenK,  No, latest build failed; https://launchpad.net/ubuntu/+source/unity
[21:39] <StevenK> Yeah, I saw that.
[21:39] <StevenK> sinzui: Like I said before, I'm happy to bug people in Dallas to help you.
[21:39] <sinzui> I am sure they will notice
[21:39] <StevenK> sinzui: Well, are you sure the latest version will fix your problem?
[21:39] <sinzui> I have a computer behind me that lets me count the places in the menu I cannot see to use menus
[21:41] <sinzui> Since packages are arriving that lets me restore what went missing, I think upgrading is the solution. I have everything but Unity and some compiz package
[21:42] <sinzui> still the no-menu situation is very weird. I think it affects every instance of GtkMenu.
[21:42] <StevenK> It will, it sounds like a bug with dbusmenu
=== sinzui changed the topic of #launchpad-reviews to: On call: - || reviewing: Edwin || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
[21:43] <sinzui> gksu never comes to for foreground. I discovered I can resolve may lockups my typing my password
[21:47] <sinzui> see approving an MP has a dropdown menu that I cannot see.
[21:49] <sinzui> EdwinGrubbs, r=me
[21:49] <EdwinGrubbs> thanks
=== sinzui changed the topic of #launchpad-reviews to: On call: - || reviewing:  || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews
=== sinzui changed the topic of #launchpad-reviews to: On call: - || reviewing:  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews