[06:47] <ravibn> Hi!
[09:02] <nucc1> hi guys, i'm trying to fix a minor evolution bug, and i get this error when trying to build the package, what does it mean? http://pastie.org/1465981
[15:14] <micahg> nucc1: it means you don't have gnome-pkg-tools and cdbs installed
[15:15] <nucc1> micahg, had cdbs, didn't have gnome-pkg-tools and dh-autoreconf . someone at ubuntu-devel told me. thanks
[15:16] <micahg> nucc1: ah, ok, you can use apt-file to tell you what package something is in
[15:16] <nucc1> cool
[15:16] <nucc1> if you're trying to patch an ubuntu package, is there a shorter way to get to test it?
[15:16] <nucc1> currently, you have to build a .deb and install it
[15:18] <Amaranth> I don't see how it could get shorter, you have to actually compile the thing and test to make sure it works...
[15:19] <micahg> nucc1: no, that's the only way at least for a compiled program, for an interpreted program, you can copy the file on the system, but that's only a partial test
[15:19] <nucc1> Amaranth, yes, compile, but skip the build a deb and install part.
[15:19] <nucc1> micahg, thanks
[15:20] <Amaranth> nucc1: well if you run debuild binary it'll only do the full build once
[15:20] <Amaranth> nucc1: and further changes will only recompile the things you changed then make the package
[15:20] <Amaranth> once you think you've got it you should do a full regular build though
[15:21] <nucc1> Amaranth, i was following the instructions here: https://wiki.ubuntu.com/Bugs/HowToFix
[15:21] <nucc1> and that uses pbuilder-dist which seems to build the entire thing
[15:21] <Amaranth> Right, you'll want to do that once you've got a proper fix
[15:22] <nucc1> so what command do i run to do a quick build?
[15:22] <Amaranth> debuild binary
[15:22] <Amaranth> it won't be quick the first time, you of course still have to build everything
[15:22] <nucc1> ah, lol. my eyes saw "debbuild"
[15:23] <Amaranth> think of it like make but also building the package
[15:23] <nucc1> yea, it seems to require me to install all the dependencies
[15:23] <Amaranth> of course
[15:23] <Amaranth> you need to be able to compile it :)
[15:24] <nucc1> yes, pbuilder-dist seems to do that in some sort of way. anyway, if i actually install the dependencies, then i should be able to get away with the standard ./configure && make ?
[15:24] <Amaranth> nucc1: no, use debuild
[15:24] <Amaranth> pbuilder sets up a chroot and installs the dependencies there
[15:25] <Amaranth> but it installs them every time you run it, thus it takes quite a while
[15:25] <nucc1> yea
[15:25] <nucc1> running sudo apt-get build-dep now.
[15:25] <nucc1> anyway, the issue i was tracking seems to be out of my league :p
[15:25] <nucc1> a segfault in evolution
[15:26] <Amaranth> ah, do you have a stack trace?
[15:26] <nucc1> i got some stuff out of gdb yes, https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/703488
[15:26] <Amaranth> usually it's just a missing NULL check for forgetting to keep a reference to something
[15:26] <ubot2> Launchpad bug 703488 in evolution (Ubuntu) "Evolution crashes if you drag and drop a file on the message list (affects: 1) (heat: 6)" [Undecided,New]
[15:26] <nucc1> Amaranth, yes, but i couldn't find where to place the check :)
[15:27] <nucc1> I tried valgrind, it was reaallly slow on my machine and i didn't quite understand what it was telling me afterwards
[15:27] <Amaranth> nucc1: well, it tells you where the crash was (line 873 of em-utils.c)
[15:28] <nucc1> yes, that is not the source, cos i added a null check there but it still crashed
[15:28] <Amaranth> nucc1: in gdb run 'thread apply all bt full' when it crashes
[15:28] <nucc1> ok, lemme try that now
[15:28] <Amaranth> that'll give you the entire detailed backtrace for every thread running
[15:30] <nucc1> evolution is taking a while to quit... storing folder
[15:35] <nucc1> Amaranth, http://paste.ubuntu.com/554749/ i suspect i need to install more dbg symbols
[15:35] <Amaranth> nucc1: that crash doesn't look anything like the first one
[15:35] <nucc1> ah, seem to be many
[15:36] <Amaranth> nucc1: you did run it and wait for it to crash, right?
[15:36] <nucc1> yeap. i've found it. let me paste it
[15:37] <nucc1> Amaranth, http://paste.ubuntu.com/554750/
[15:38] <Amaranth> nucc1: well, there you go, uris is 0x0
[15:38] <Amaranth> Should uris be NULL at that point or is that your bug?
[15:40] <nucc1> uris should not be null, because it get's set when a file is dropped onto the window. however, NULL is a valid value, but there is no null check
[15:40] <nucc1> that sounds dense.
[15:41] <nucc1> Amaranth, see the snippet, with my added null check: http://pastie.org/1466913
[15:41] <nucc1> (the ubuntu pastebin is not so convenient for repeated use)
[15:42] <Amaranth> nucc1: line 3 is your addition?
[15:42] <nucc1> yes
[15:43] <Amaranth> odd, line 873 is actually in a different function...
[15:44] <nucc1> line 873 is the first line of the loop
[15:46] <Amaranth> nucc1: oh, are you using maverick?
[15:46] <nucc1> ah, yes :)
[15:46]  * Amaranth is looking at natty evolution
[15:46] <nucc1> lol
[15:46] <Amaranth> nucc1: in that case the first thing you should do is see if it still happens with natty's packages
[15:46] <nucc1> that means a VM...
[15:47] <Amaranth> or just installing them on top of your maverick install
[15:47] <Amaranth> nucc1: but it's a waste of time trying to fix a bug that may already be fixed
[15:47] <nucc1> that could pull in stuff that might make my machine unstable.
[15:48] <nucc1> true, i just figured it was still helpful to fix it on a stable release
[15:50] <nucc1> Amaranth, you could drag and drop a file onto evolution and see if it crashes :)
[15:50] <nucc1> the message list, that is
[15:50] <Amaranth> nucc1: I don't even have it installed :)
[15:50] <nucc1> lol
[15:50] <nucc1> ok, lemme download the ISO.
[15:51] <Amaranth> why would you drag a file on to the message list anyway?
[15:51] <nucc1> happened by mistake
[15:52] <nucc1> then it felt embarrassing that the default mail client crashes when you drop a file on it.
[15:52] <nucc1> so i figured, lemme have a go at it