=== godbyk_ is now known as godbyk-laptop [06:35] morning [06:44] night :) [06:48] :) [07:57] greetings everybody! [07:58] hello MacSlow [07:59] hey kvalo, kamstrup [08:11] good morning [08:18] kamstrup: morning. I'm sure you have missed my merge requests ;) so here's a new one: https://code.launchpad.net/~kvalo/indicator-network/libconnman-vala/+merge/47366 [08:19] kamstrup: this one was so strange, I didn't get it: http://bazaar.launchpad.net/~kvalo/indicator-network/libconnman-vala/revision/153 [08:28] kvalo: is it |just| the cheader_filename that you've changed in the .vapi? [08:29] kvalo: because in that case it could make sense to a 'sed' invocation in your Makefile.am to get the Connman-1.0.vapi to be purely autogenerated [08:36] kvalo: needs fixing [08:41] kamstrup: the regexp wouldn't be simple, because there are two different filenames [08:42] kvalo: ah, bugger [08:42] yeah, it really sucks [08:42] kvalo: although I guess you could fix that by making one super header that includes the two, no? [08:43] kamstrup: can you check if you have libreadline-dev installed? I'm guessing configure check doesn't fail if it's missing [08:43] kvalo: and generally I push for single header includes everywhere anyway. Including discrete headers is a path of pain for consumers and maintainers alike [08:44] kamstrup: so you are saying that I should have libconnman.h which will contain all classes? [08:44] ah, it will just include all the class .h files [08:44] makes a lot of sense [08:44] kvalo: a libconnman.h that just includes manager.h and service.h or whatever you need [08:44] kvalo: in fact for all my public [08:44] kvalo: (damn return key!) [08:45] kvalo: in fact for all my public libs i *force* this and raise a compile time error if you try to include one of the subheaders [08:46] kvalo: like http://bazaar.launchpad.net/~libzeitgeist-developers/libzeitgeist/trunk/view/head:/src/zeitgeist-monitor.h#L21 [08:46] kvalo: but of course this is not as important for an internal lib [08:47] I'll add it anyway [08:47] this gives absolute freedom for me to restructure the internal source layout, which is otherwise impossible [08:48] kamstrup: thanks for the tips [08:50] yeah, configure doesn't fail if readline is missing [08:50] * kvalo starts reading the autoconf bible [08:54] kvalo: meh, readline doesn't have pkg-config integration... [08:54] kvalo: you can just do: echo '#include ' | gcc -E - > /dev/null 2>&1 [08:55] kvalo: in configure.ac and check $? == "0" [08:55] kamstrup: I'm using AC_CHECK_LIB already, I was just missing the error case [08:55] kvalo: ah, ok [08:55] kamstrup: but yeah, readline is _old_. [08:55] kvalo: but it works :-) [08:56] sure does [09:03] kamstrup: just to keep merge requests simple, I will create a new branch for the automatic vapi generation [09:03] kamstrup: ok? [09:04] kvalo: suer [09:04] sure [09:32] njpatel: ! [09:32] kamstrup, ! [09:32] njpatel: I was thinking... [09:33] uh-oh [09:33] njpatel: why is the group_model per PlaceRendererInfo and not just shared globally across a PlaceInfo (like the sections_model already is)... [09:33] njpatel: considering https://wiki.ubuntu.com/Unity/Places [09:34] njpatel: sorry, the correct terminology would be RendererInfo and PlaceEntryInfo respectively in the above [09:34] kamstrup, I think it's because different renderers might have different groups, where sections would remain constant across the place entry [09:34] njpatel: at least it makes for some oddities in the place daemons [09:34] oh, wait, I se what you mean [09:35] kamstrup, I guess it could be global [09:35] njpatel: indeed, and you can still have different renderes even if you use the same label for the group, that would just be two entries in the group model with the same labeæ [09:35] right [09:36] njpatel: so I think it's a taad more consistent, and it's one less DeeSharedModel on startup (they are not entirely cheap) [09:36] ((because of the dbus interactions) [09:36] kamstrup, this isn't something we need to change, though, right? I mean I've just come out of doing this and if you make me go back to gdbus I might kill you [09:36] oh, you do want to change [09:36] * njpatel books tickets to Denmark [09:36] njpatel: i don't have to [09:37] njpatel: it's because I am sitting here adding the Control Center stuff to the apps place [09:37] kamstrup, I'd say leave it for now, we've got enough to do for A2. Maybe once the places stuff has settled down next week? [09:37] njpatel: and the current spec makes this rather ugly in my code [09:37] njpatel: ok, I'll put it in the gdoc of pending changes [09:37] thanks [09:42] kamstrup: I updated now https://code.launchpad.net/~kvalo/indicator-network/libconnman-vala/+merge/47366 [09:42] kvalo: ok, on it [09:44] kamstrup: thanks [09:52] dbarth_, a11y call now? [09:53] kvalo: approved, with a small request... [09:54] kamstrup: hey, I can't say no to you ;) [10:13] API, dbarth_: a11 weekly call now? [10:13] hey aruiz [10:13] hey rodrigo_ ! [10:13] :-) [10:25] API, hmm, about your last comment in my branch, the PanelViewAccessible has several children, not only 1 (the layout), as shown on accercizer [10:25] API, not sure what you mean? [10:27] rodrigo_, it has several because you are exposing layout content [10:27] API, right, and you'd prefer to just expose the layout as the only child? [10:27] no [10:27] please read again [10:27] my last review [10:28] your way to implement that could be also valid [10:28] but, there is any reason to do that? [10:28] I mean that the normal is the other way [10:28] expose the only child [10:28] becase after all [10:28] is the only child of the panel [10:28] your way is also valid [10:28] hmm, but what do we need the layout for? [10:28] but, imho, it should be a reason to do that in this way [10:29] and why repeat the code to expose the children of a layout? [10:29] we have that code on nuxlayoutaccessible [10:29] so it is valid for any layout used [10:29] hmm, ok [10:30] so, I just change it to return 1 child (the layout) then, right? [10:32] well, unless you find a good reason to do that in the other way ;) [10:32] yes, [10:32] you can take basewindow as reference [10:32] kamstrup: I want to create a uber test script/makefile target which would run all possible tests there are and print an "OK!" banner if there are no errors. would makefile target "allchecks" or similar be the best solution? [10:32] no, just didn't think we needed the full real hierarchy, but if that's how everything is done, I'll change it [10:32] so yeah, don't have a good argument to convince you :-D [10:33] kvalo: just stick this in your makefile for s in test_foo test_bar test_baz; do echo $s OK; done [10:34] kvalo: is everything using the gtester framework? [10:34] kamstrup: most are, but I want to also run distcheck [10:35] kvalo: check how I do it lp:libunity. You need a Makefile.decl copy pasted to your source root from there [10:35] kvalo: and then include it in your test makefiles [10:35] kamstrup: thanks, I'll check it [10:47] gord: could you file a bug saying that we need multimonitor support in the switcher and staticswitcher plugins so I don't forget :) [11:02] smspillaz, not right now, if i remember when i'm less busy though :) [11:03] :p [11:25] njpatel, a serializedstring gvariant would look like something like this no -> "(s)", "thing" [11:25] for the gsettings command line tool [11:29] ronoc, erm, no idea dude. kamstrup ? ^ [11:30] ronoc, njpatel: ehhh, probably? What does "serialized" mean here? [11:32] kamstrup, njpatel from the docs of the gsettings command line tool the set command takes key and then value, "The value is specified as a serialised GVariant " [11:33] ronoc: it probably refers to the format used by g_variant_print()/g_variant_parse() [11:33] ah yes [11:33] thx guys [11:39] ronoc: so what I see here is that a variant created with g_variant_new ("s", "Hello") prints as ('Hello',) [11:41] kamstrup, tried that already, doesn't like it [11:41] ronoc: he - then I'm at a loss [11:42] kamstrup, no worries - just trying to helpful on a bug report ... [11:43] ronoc: look at the format from a get command - the docs say it's the same [11:45] ronoc: gsettings get org.gnome.desktop.default-applications.terminal exec [11:45] ronoc: so it's a 'single quoted string' [11:46] kamstrup, the format of the value in my hash is an array of strings [11:46] so I have been trying gsettings set com.canonical.indicators.sound blacklisted-media-players @as ["rhythmbox"] [11:46] since get returns [11:47] @as [] [11:47] ronoc: ['foo', 'bar'] [11:48] hello [11:48] kamstrup: gsettings get com.canonical.Unity.Launcher favorites [11:48] kaleo: Where's the original Kaleo?! === kaleo is now known as Kaleo [11:48] :) [11:48] * Kaleo is me [11:48] Kaleo: oh, hi Kaleo, you here too? [11:48] ;-) [11:49] after a good night of rest yes [11:49] hehe [11:49] kamstrup, still not working, a key error is now the problem even though it has no problem fetching [11:49] weird [11:49] will come back to it later [11:50] ivanka, remember me? (last week xD) [11:51] kamstrup, got it [11:52] gsettings set com.canonical.indicators.sound blacklisted-media-players "['rhythmbox']" [11:52] ronoc: right, looks sane === MacSlow is now known as MacSlow|lunch [12:25] kamstrup: actually I can't generate the vapi automatically. I just remembered that I did other manual changes as well [12:26] kamstrup: I think I just leave as it is for now and revisit then the api is stable, and hopefully tools are more stable [12:26] kvalo: right, no worries [12:38] seb128: do you still have the issue with alt + mouseclick not dragging your window? [12:43] didrocks, still get it [12:43] you don't? [12:43] using alt-click-dnd doesn't move anything there [12:44] seb128: no, I never had it [12:44] seb128: can you try this (maybe it's a perf issue that some people have): ccsm -> move plugin -> opacity back to 100% [12:44] (and check that alt + button 1 is set as well) [12:45] didrocks, it's not happening in a guest session, just checked [12:45] so don't bother [12:45] seb128: ok, something weird again in the session :) [12:47] hate compiz, it's still crashing every second ccsm run [12:48] seb128: do you enable/disable pluginis? [12:48] no [12:48] plugins* even [12:48] just run ccsm [12:48] oh, weird, I didn't with that [12:48] every second run compiz crashes [12:48] ok [12:49] I can move the dialogs which are not focused [12:49] I have some random crashes though [12:49] that's weird [12:49] like if I've to dialogs on screen I can alt-click and dnd the one which is not focussed [12:49] but not the one which is focussed [12:49] seb128: maybe related to the new decorator? (just a stupid guess) [12:49] there is still the older one if you want to give it a try [12:50] didrocks, that fixes it [12:50] not that stupid then \o/ [12:51] in the guest session, which decorator is running? (should be the unity one still…) [12:52] or not [12:52] didrocks, it seems restarting the decorator just made it work once [12:52] didrocks, I will keep watching for it but don't bother with that for now [12:52] ok, that's weird :/ [12:52] it doesn't happen in my guest session so it's likely a profile thing [12:52] I will try to debug it later [12:52] seb128: ok, keep my in touch :) [12:52] but I've other tasks I want to get done before [12:52] k [12:52] session restart brb [12:52] thanks :) [13:08] Kaleo, so (finally) looking into the merge, do you think we could drop some of the depends in u-2d-d-s to recommends ? [13:08] the dependency list is quite long [13:10] ogra: hmmm, that's kind of a broad question [13:10] ogra: any specific depends you have in mind? [13:10] nautilus looks like a good candidate [13:11] metacity too (since you apparently can also use compiz) [13:11] ogra: metacity is a no go [13:11] why ? [13:11] ogra: we want to run by default on hardware without hw accelerated OpengGL [13:11] -g [13:11] well, there is custom patch in metacity like the decorator one [13:11] if i can use compiz instead there needs to be an option to uninstall metacity [13:12] ogra: and we do not QA on Compiz very much [13:12] Kaleo, by default the unity-2d package will pull in metacity [13:12] ogra: so for now it's experimental [13:12] ogra: which is normal [13:12] a [13:12] ah [13:12] we install recommends by default [13:12] right [13:12] its just about the optional removing [13:12] ogra: I see [13:13] and i can see people using it with pcmanfm or compiz [13:13] ogra: what do you set in the session file? [13:13] metacity ? [13:13] ogra: to back up a little here our package u-2d-d-s should depends/recommends most of the same things that Unity deps/recommends [13:13] didrocks: yes [13:13] probably even with xfce-session if there is nothing that hardcodes gnome-session functions [13:13] so, the session won't start if someone uninstall metacity [13:13] didrocks: good point [13:13] didrocks, no, but you can modify it manually [13:14] right, but I'm unsure about letting people shooting on their feet :) [13:14] * didrocks tries to think how to do that [13:14] well, we will get complaints if we have to hard deps [13:14] didrocks: ogra: what package should I look at that contains Unity's session? [13:14] Kaleo: gnome-session [13:14] didrocks: thanks [13:14] i'm fine going with what we have but try to think ahead [13:15] ogra: maybe gnomewm needs some tweaking === agateau_ is now known as agateau [13:15] so things that arent absolutely needed should be removable [13:15] Kaleo: you need to look at /usr/share/gnome-session/sessions/ubuntu.session [13:15] if we indeed have hardcoded bits that really depend on gnome stuff there is no way for recommends === MacSlow|lunch is now known as MacSlow [13:15] but i see for example ubuntu-wallpapers in the deps [13:16] ogra: strictely speaking, I can only see the decorator patch [13:16] and light-themes [13:16] these seem like recommends candidates [13:17] ogra: light-themes does not have to b there at all AFAIK [13:17] we often have people building custom images for unsupported arm HW ... [13:17] ogra: so, we have a long list of deps [13:17] ogra: it needs cleaning while keeping all existing functionalities [13:17] i just try to think of that guy who wants to run everything xfce and pcmanfm with custom themes [13:18] Kaleo, right, thats why i ask :) [13:18] ogra: and we should look into Unity's deps [13:18] ogra: and mimick what is done there [13:18] ugh [13:18] they are way bigger than ours :P [13:18] ogra: sure [13:18] ogra: but for example the indicator-* are recommends for them [13:18] http://packages.ubuntu.com/natty/unity [13:19] heh [13:19] yeah, because without the indicators… [13:19] and it's only recommends [13:19] the required bits are: [13:19] compiz of course [13:19] unity-common which is internal [13:20] libglib2.0-bin for the gsettings binary [13:20] the indiocators would have been the bits i wouldnt have made recommends :) [13:20] funny [13:20] python for some migration script and the unity binary [13:20] nux-tools for the detection bits [13:20] unity-asset-pool for the icons [13:20] ogra: well, if you install unity, you want to have a way to disconnect from your session for instance [13:21] or you maybe want the clock :) [13:21] right [13:21] ogra: http://ietherpad.com/2s0NezImPo [13:21] thats why i mean i wouldnt have made indicators a recommends [13:21] ogra: I started putting the plan there [13:21] ogra: oh, you mean a dep? [13:22] ogra: let's figure out the whole changes there, agree on it, and then push it [13:22] ogra: we have some people who wants to remove the appmenu [13:22] ugh [13:24] Kaleo, wallüpapers and themes should be recommends there [13:26] Kaleo, hmm we could drop wallpapers and themes and move them into the netbook/desktop seeds [13:26] (i think they are in there anyway) [13:27] apt-cache rdepends answers part of the question I suppose [13:27] ogra: they are [13:27] right, lets drop them [13:27] didrocks: http://ietherpad.com/2s0NezImPo contains the discussion in a more efficient format [13:27] ogra: can you leave them on the document please [13:27] oops [13:27] back [13:28] thanks [13:28] what about metacity ? [13:28] if its hardcoded in the session file we indeed need to keep it [13:29] how about gnome-session ? can we use other session managers without breaking ? [13:31] ogra: don't forget that this pacakge is meant to install the session in GDM [13:31] and what about the dep on unity ? that should be lowered to the bits we actually need i guess [13:31] ogra: that's its purpose [13:31] (unity-common/-asset-pool) [13:31] Kaleo, what if i want to use it with kdm ? [13:31] ogra: we don't depend on these [13:31] right, we need to clean up what's in -common [13:31] Kaleo, right [13:31] I'll have a look to ensure you have all you need [13:31] Kaleo, we depend on unity though [13:32] ogra: not in 2d-default-settings AFAIK [13:32] or am i misreading the doc ? [13:32] didrocks, so drop g-s-d and nautilus ? [13:32] unity-2d-launcher depends on unity-asset-pool [13:32] ogra: yes, you should IMHO [13:33] can you tag it DROP ? [13:33] sure [13:33] thanks [13:33] so only the pixbuf engine left [13:34] should be brought by something else IMHO [13:34] let me check [13:34] ogra: finally, you have more dep than unity has :) [13:34] well, can i install unity-2d and still have a working UI ? [13:34] with these deps [13:34] didrocks, could you look at #684275 (upload request for the ginn project)? [13:34] else we need to re-add recommends [13:35] ogra: that's the question, I don't really know for that one :) [13:35] bug #684275 [13:35] Launchpad bug 684275 in ginn "New source package: ginn" [Medium,New] https://launchpad.net/bugs/684275 [13:35] didrocks, can i do that with unity ? [13:35] bregma: excellent, will get to it that week, thanks :) [13:36] Kaleo, i agree with your comment in the doc [13:36] ogra: we don't use any theme engine [13:36] it should still be possible to just install unity-2d [13:36] without a toplevel metapackage [13:36] didrocks, thank, there are a few more multitouch upload requests pending I'll follow up on later [13:36] so things we need for functioning should be recommends [13:37] bregma: got it, do not hesitate! :) [13:37] ogra: you need rather a metapackage then, but we can have the same rationale with every apps… === klattimer1 is now known as klattimer [13:38] didrocks, we will have a unity-2d package, i need to migrate unity-2d-default-settings into something [13:38] in that case… :-) [13:39] at some point i would like to merge the other binary packages of the unity-2d source package into that too, but Kaleo wants them distinct for now for flexibility [13:39] ogra: what what [13:39] ogra: that's a very different problem [13:39] thats probably natty+1 [13:39] ogra: merging the binaries is an upstream thing [13:39] ogra: that will not happen [13:39] Kaleo, no, its a packaging thing [13:40] ogra: which is equivalent [13:40] you currently build four binary packages [13:40] while unity doesnt [13:40] ogra: we distribute separate binaries for reasons that make the binary package existence valid [13:40] with my merge we will have one meta and four binaries [13:40] ogra: Unity _cannot_ [13:40] ogra: Unity does not have multiple binaries [13:41] and it would make sense *at some point, i dont say _now_* to merge all binaries into the meta [13:41] ogra: I hint never :) [13:41] that doesnt make sense [13:41] ogra: we want to keep the flexibility for users [13:41] ogra: that means separate binaries and separate binary packages [13:41] why do you actually need these binary packages? do you expect anyone to use either of them standalone ? [13:42] ogra: yes [13:42] well, for instance, we have in the unity package the plugin and the unity panel service, but you can't use one without the other one [13:42] didrocks: that is actually going to change AFAIK [13:42] didrocks: because it's likely Unity 2d is going to depend on the unity panel service [13:42] Kaleo: if you are going to migrate to it, for sure [13:42] yeah, I'll make a separate bin package for it then [13:42] well, if the intention is to use the launcher standalone (and if it acrtually works without any of the other) then i agree indeed [13:42] didrocks: right [13:42] ogra: that is the intention [13:43] ogra: and it does work [13:43] ogra: in fact some people already use it athat way [13:43] yeah, tne i fully agree [13:43] -a [13:43] *then [13:43] Kaleo: just keep me in touch once all the seperating work done, so that we can work on the minimal package req. [13:43] :) [13:43] didrocks: sure, I will let you know when the time comes [13:43] i thought there were inter-dependencies between them [13:43] ogra: hopefully they will be resolved one day [13:43] ogra: oh, sorry [13:43] ogra: I misread you [13:43] ogra: there are no inter dependencies [13:43] ogra: or rather [13:44] right, sorry for assuming that :) [13:44] ogra: if they are they are going to be fixed soon [13:44] ogra: there is no runtime dependency that's for sure [13:44] ogra: you can run all four binaries on their own [13:44] k [13:44] ogra: there is some packaging dependenc for wrong reasons [13:45] ogra: and bug reports to fix them [13:45] +ies [13:45] so back to our cod [13:45] *doc [13:45] right [13:45] * ogra cant type today [13:45] pixbuf engine [13:45] so, I don't know for that one [13:45] what about that ? [13:45] let me bzr qlog [13:45] i cant imagine any qt binary using it [13:46] so it would only be pulled in as a meta dep [13:46] which makes it a recommend [13:48] https://bugs.launchpad.net/watuppa/+bug/645977 [13:48] ogra: we use a bit of GTK internally [13:49] ok [13:49] heh, not allowed ... but i belive you :) [13:49] so keep it as dep [13:49] ogra: no [13:49] ogra: that's not the reason [13:49] ogra: we depend on libgtk2.0-0 in unity-2d-launcher already [13:50] ogra: looking at the bug report I think that it could be made a recommends [13:50] k [13:51] ogra: so [13:51] ogra: what is the difference between [13:51] ubuntu-wallpapers and nautilus [13:51] for example [13:51] why DROP one and make the other a RECOMMEND [13:51] +s [13:52] you can run completely without wallpapers, but you should have some filemanager to be functional ? [13:53] and recommends allows you to replace nautilus with something else [13:53] ogra: I get it [13:53] so i would keep g-p-m, gnome-session, polkit and nautilus as recommends [13:53] ogra: didrocks: everybody happy with the final list? [13:54] * ogra is [13:56] ogra: thanks for bringing this up [13:56] Kaleo, well, it blocked me :) [13:56] ogra, Kaleo: looks good to me. Still ensure about g-s-d and other stuff, but we'll see if you need a separate metapackage or not :) [13:56] i'll create the unity-2d package now and show you a diff for review [13:57] great [13:58] none of the gtk+ menus work for me in natty anymore since today [13:58] anyone knows what might be the problem and how do I best debug them? [14:00] ogra: do you want to take care of this too? https://bugs.launchpad.net/ubuntu/+source/unity-2d/+bug/703170 [14:02] Kaleo, heh, yeah [14:04] danilos: stacking issue, try to right click on the wallpaper [14:10] Hi all! Is it a known bug that maximized windows don't blend in unity-panel if I use unity2d + compiz ? [14:11] (at least in maverick) [14:12] lucazade1: yes [14:12] lucazade1: and let me give you a tip [14:12] ohai. I wonder if there is anything like a PPA we (the ubuntu one team) can start using to look at the launcher progress bars API. Or are they in Natty proper already? [14:13] Kaleo: ok [14:13] lucazade1: set the gconf key /apps/compiz/plugins/decoration/allscreens/options/decoration_match [14:13] lucazade1: to !(state=maxvert) [14:14] njpatel: ^ (sorry yours is the only irc nick I know :D ) [14:14] Kaleo: great, it works! [14:16] lucazade1: fantastic [14:24] cando__: jamalta: hey guys I'm working on the unity report, anything you'd like to add for this week? [14:27] didrocks, ping [14:27] boulabiar: hey [14:27] I want to ask you about putting a package in universe [14:27] bug #684275 [14:27] Launchpad bug 684275 in ginn "New source package: ginn" [Medium,New] https://launchpad.net/bugs/684275 [14:28] boulabiar: I was already pong by bregma some minutes ago ) [14:28] ahh, haven't seen that [14:28] boulabiar: so, will do a first review before EOW is the summarry :) [14:29] thanks [14:29] yw [14:33] ivanka, remember me? [14:37] jcastro, nope..nothing new..:( [14:58] Kaleo: did you see my note about CacheEffect on your MR ? [15:03] nerochiaro: yes still waiting for more input from you [15:03] Kaleo: what do you need ? [15:04] "Florian, please hold on on this merge for a bit." [15:04] I suppose that "a bit" means you are going to investigate [15:04] and come back to me with "please merge" [15:05] or "don't merge" [15:05] Kaleo: well, it was actually meant in the sense of "it seems broken in this case, so please don't merge before first figuring it out (or merge and go ahead if you don't care that i don't use it in my code for now)" [15:05] Kaleo: guess it wasn't clear. sorry about that [15:06] nerochiaro: it was very clear [15:06] nerochiaro: but in the wrong sense [15:06] nerochiaro: so, you have the code that is broken with it [15:06] Kaleo: ok. so if you want i can spend time and investigate it. i just know nothing about CacheEffect [15:06] nerochiaro: please investigate [15:06] Kaleo: sure [15:11] nerochiaro: do you have the link to your todo list? [15:12] Kaleo: http://ietherpad.com/eVgMjsVwiF [15:12] nerochiaro: thank you [15:13] any gmail users in here? [15:13] * spikeb [15:14] spikeb, may I pm u? [15:14] sure [15:19] Kaleo: i don't really understand why the cache effect actually caches. some explanatory comment would actually help in the class file. all i see is that it takes the sourcePixmap and paints it. doesn't the same thing happen normally when there's no effect at all ? [15:22] nerochiaro: you need to look at how an effect works [15:24] Kaleo: well, the effects sit between the source element and the destination (i.e. the viewport in our case) and basically do their own custom painting by reimplementing the draw function [15:25] Kaleo: " If effects are disabled, the source is rendered directly." which looks like pretty much what happens in your cache effect: you take the source and render it straight on the destination [15:25] i'm surely missing something [15:26] nerochiaro: yes you are mising reading the code of Qt [15:26] nerochiaro: let me fetch the file [15:26] Kaleo: so you're basically saying that the documentation sucks and one should not rely on it ;) [15:27] nerochiaro: src/gui/effects/qgraphicseffect.cpp [15:27] nerochiaro: no, I am saying you are interpreting the documentation [15:27] Kaleo: and anyway, if one has to go read the QT source to now how your code works, you surely need comments, in my opinion [15:27] nerochiaro: that's true [15:27] nerochiaro: probably [15:27] reading that source [15:27] nerochiaro: someone who wrote effects before would not need that documentation [15:28] Kaleo: no, but someone trying to figure out why the effect wrote by something else screws up his otherwise working code does [15:29] nerochiaro: sure [15:30] nerochiaro: you are frustrated because your work is broken and there is no explanation in CacheEffect [15:30] nerochiaro: take the time you need to read src/gui/effects/qgraphicseffect.cpp and then we can talk [15:31] Kaleo: doing that right now [15:33] (#ayatana, if you are cool with compiling compiz from source, then there is a fix for stacking http://smspillaz.ucc.asn.au/0001-Fix-stacking-madness.patch - I need testers :) ) [15:50] Kaleo: so basically the source internally uses a global cache, so whatever comes out of sourcePixmap is cached and you just draw it. right ? [15:53] nerochiaro: irhgt [15:53] nerochiaro: orrather whatever you draw is cached [15:53] Kaleo: but isn't that what happens with declarative images anyway ? [15:53] Kaleo, http://paste.ubuntu.com/558148/ [15:53] nerochiaro: not necessarily [15:53] nerochiaro: besides we are not dealing with an image here [15:54] i'm waiting for persia to return to cross check the transition for me [15:54] Kaleo: isn't the background an image ? [15:54] but thats essentially what i plan to put into natty-release [15:54] ogra: is that the merge into unity-2d? [15:54] right [15:54] ogra: can you submit a merge request instead? [15:54] nerochiaro: look at the code [15:54] Kaleo: ok, i take that back, it's the entire Item [15:54] Kaleo, into my own branch ? [15:54] :) [15:54] k [15:54] ogra: into trunk [15:55] Kaleo, does trunk already have all bits from natty-release ? [15:55] ogra: I don't know I was not aware of natty-release until a few days ago [15:56] ogra: I have not synced anything yet [15:56] Kaleo: so what's wrong there is that the effect doesn't take into account correctly the fact that the Item is being scaled [15:56] probably [15:56] i think natty-release is a bit ahead atm [15:56] at least chanbgelog wise [15:56] upstream should be identical [15:56] *changelog [15:56] ogra: you see why I dislike having 2 branches [15:57] Kaleo, totally [15:57] ogra: because we end up having that conversation :) [15:57] yeah, but its there now [15:57] yep [15:57] trying a merge [15:57] :/ [15:58] ogra: I merged natty-release into trunk [15:58] ogra: can't you just do the work on trunk? [15:58] no conflicts ? [15:58] ogra: none [15:59] Kaleo, well, then i need to change all the Vcs-Bzr entries again [15:59] ogra: that's a small price to pay :) [15:59] i just adjusted all of them for the natty-release branches [15:59] yes that's what I just merged [15:59] right [15:59] but unless NCommander comes in screaming [15:59] there was also a .bzrconfig setup i added [15:59] I say let's drop them [15:59] ogra: which is great for trunk [16:00] to get bzr builddeb working [16:00] ogra: we like .bzrconfig [16:00] right, did that get in as well ? [16:00] ogra: yes [16:00] great [16:00] ogra: bzr did its job :) [16:00] just wanted to be sudre [16:00] :) [16:01] lets discuss the natty-release branches once NCommander is awake, i dont want to rule that above his head [16:01] i fully agree with you though [16:09] ivanka1, you there? [16:10] multiplatinum: hi - I am in meetings all afternoon. We will have to talk another day. Sorry! [16:10] Np, cya [16:35] Kaleo: ping me whenever you want to pick up where we left [16:54] nerochiaro: back [16:58] Kaleo: ok. so basically i was say that probably what's wrong there is that the effect doesn't take into account correctly the fact that the source Item is being scaled [17:06] nerochiaro: hmmm, interesting idea [17:07] Kaleo: well, that's what i am imagining from seeing the visual issue and peeking at the code, and the fact that you only used it with backgrounds whose scale is not animated [17:07] Kaleo: so you probably didn't test if it worked in case the source changed [17:07] nerochiaro: the source changed? what? [17:08] nerochiaro: you mean in case the scale changes [17:08] Kaleo: for example, yes [17:08] nerochiaro: what do you mean for example? isn't it the entire problem here (supposedly) [17:09] Kaleo: well, in my case yes. but i guess it will have the same problem if the source is rotated or transformed in any other way. i guess you need to reimplement QGraphicsEffect::sourceChanged to be notified about any changes [17:10] nerochiaro: so you see here the issue is [17:10] nerochiaro: that the cacheeffect purpose is to prevent redraws when this happens [17:11] nerochiaro: when it's being moved or transformed [17:11] nerochiaro: and it's important if you want to get smooth animations [17:12] nerochiaro: I need to see the issue visually, can I pull your branch? [17:12] Kaleo: certainly. you only have to comment the cacheeffect in the gnomebackground [17:13] Kaleo: i mean, un-comment [17:13] Kaleo: then trigger the workspace switcher, and un-zoom a workspace and zoom another [17:13] (that's the nastiest case) [17:14] nerochiaro: is there a workspace switcher button? [17:15] Kaleo: not yet. it's down in the list [17:15] Kaleo: just activate it as you did the original spread [17:15] ok [17:15] I see [17:16] Kaleo: same as last time you tried it [17:16] * Kaleo is going to make some pasta [17:16] (and think) [17:16] Kaleo: damn, you're making me hungry now [17:17] nerochiaro: the way I see it it sounds like a bug in Qt [17:19] Kaleo: I can't honestly say i understand enough of the whole effect framework from my quick look today to be able to tell. I just don't see where you take scale into account in the effect code though [17:19] Kaleo: i mean, the cacheeffect code [17:19] nerochiaro: you don't have to [17:21] nerochiaro: http://bugreports.qt.nokia.com/browse/QTBUG-5918 [17:22] nerochiaro: not the same thing but interesting [17:25] Kaleo: that's rotating the destination, but i guess similar indeed [17:28] nerochiaro: http://bugreports.qt.nokia.com/browse/QTBUG-9543 [17:28] nerochiaro: this is probably the one === ogra is now known as Guest34014 [17:31] Kaleo: looks like that one is fixed in 4.7 though === Guest34014 is now known as ogra_ [18:16] dbarth_, njpatel who is going to that x meeting / what time is gmt? [18:16] lamalex, what x meeting? http://www.google.co.uk/search?sourceid=chrome&client=ubuntu&channel=cs&ie=UTF-8&q=time+in+gmt [18:17] njpatel, im sorry i meant to ping jay- but he's not here [18:17] so i guess me === m_conley_away is now known as m_conley === ivanka is now known as ivanka-train