/srv/irclogs.ubuntu.com/2011/02/03/#bzr.txt

Noldorinbob2, thanks00:02
* spiv blinks00:54
spiv$ bzr st00:55
spivmodified:00:55
spiv  doc/en/_templates/index.html00:55
spivignored:00:55
spiv  doc/en/_templates/index.html00:55
lifeless\o/00:55
AfCRemind me not to use the version spiv is running...00:56
spivBug 712209 filed.01:00
ubot5Launchpad bug 712209 in Bazaar "bzr status reports a file as both modified and ignored" [High,Confirmed] https://launchpad.net/bugs/71220901:00
spivAfC: tip of lp:bzr, of course :)01:00
spivAfC: but it appears to affect 2.2 too.  2.1 seems ok.01:01
pooliehullo spiv01:11
fullermdspiv: bug 58750601:14
ubot5Launchpad bug 587506 in Bazaar "Mentioning of ignored named files is overzealous" [Medium,Confirmed] https://launchpad.net/bugs/58750601:14
spivfullermd: thanks!01:20
fullermd(it also, AIR, shows up in the commit template; not sure if there's an extant bug about that.  But I presume it's all the same code causing it everywhere anyway)01:22
spivfullermd: I'd expect so01:24
poolie"ian.clatworthy@internode.on.net has been removed from bazaar-commits." :-(01:49
spiv:(01:50
spivI noticed earlier today he has four branches on https://code.launchpad.net/bzr/+merges?field.status=WORK_IN_PROGRESS01:50
spivI'm going to take a look and try to either abandon them or do something with them.01:51
pooliethat'd be good01:51
pooliespiv i guess the things that most need review are actually yours02:01
spivpoolie: yeah02:02
spivAs it's the start of a cycle I wonder if I should land them, especially given they've already had some review.02:04
lifelessspiv: does your haproxy thing for codehosting also make it wait to shutdown for things to finish ?03:58
lifelessspiv: if so, what method of shutdown were you expecting?03:58
spivlifeless: yes, and SIGTERM or SIGINT04:01
spiv(which are the default signal handlers twisted installs)04:01
lifelessspiv: could you join #launchpad-ops for a bit ?04:05
spivSure04:07
lifelessthanks04:08
* maxb hugs mod_wsgi04:45
maxbOne quick installation of bzr smart server + loggerhead, no extra daemons beyond the apache, 70 lines of config total :-)04:47
maxband that only because I decided I wanted a custom logging arrangement any ended up copypasting part of bzrlib.trace04:48
poolienice04:49
maxbhmm04:49
pooliemaxb, if you have notes on how to do it i'd like to add that to the docs or the blog04:49
pooliethough, pehraps 70 lines could be improved upon04:49
maxbwell, that's including a full apache <VirtualHost> block and two wsgi hooks, each with ~7 lines of imports04:53
maxbhah, nice04:54
maxbNow I've mounted the loggerhead and the smart server sharing the same URLs04:55
maxbI have to have two urls, one for read-only and one for read-write, though04:56
maxbNow, if the smart server could map 'read only transport' errors into 401 http responses, that would be awesome, because then I could do anonymous-read/authenticated-write on a single URL04:57
lifelessfile a bug04:58
maxbugh, it's 5am, I should stop playing with wsgi :-)04:59
spivmaxb: ...and start drinking whiskey instead? :)05:06
maxbNah, I've already had some port tonight05:08
peitschieyou mean last night :P05:10
maxbor possibly both05:18
peitschiemaxb: whoah... snapps!05:30
peitschieor is it schnapps =D05:30
vilahi all !07:47
=== Ursinha-bbl is now known as Ursinha
jelmermoin08:59
vilajelmer: hey !09:30
jelmervila: did you see Charlie's comment on the NoWhoAmi bug ?10:02
vilayes10:02
jelmervila: When is 2.3 scheduled exactly?10:03
vilafreeze today10:03
vila2.3.010:03
jelmerhmm, ok. so if we want to get it in it should be done today?10:04
vilabut I may freeze 2.2.4 first10:04
viladone and approved... which seems a bit of a hurry :)10:04
jelmerIt'd be nice to get that one fixed so launchpad can deploy 2.310:04
vilaI smell controversy and regressions around this topic :-/10:05
vilabasically there are two class of users competing for one default value/behaviour for opposite reasons,10:05
vilanewbies that don't understand the implications and admins who don't care about these implications10:06
jelmervila: I think the use of mailname is reasonable, and we could still warn if we end up using the mailname10:06
jelmerI'm sure we can find a better middle ground than we have at the moment :)10:06
vilaI seem to remember that the warning lead has been explored at one point but it seems to be the most reasonable one to try now ;)10:07
vila. o O (daggyfix for features should tell us this kind of thing instantly...)10:08
jelmervila: Did we really have a warning at some point? I remember somebody saying that in Dallas as well, but I don't remember it.10:09
vilajelmer: still, deploying on lp is only part of the issue, I'm pretty sure they want on lucid...10:09
vilajelmer: I don't remember discussing the subject in Dallas, so that should have been someone else ?10:09
vilajelmer: it may have been discussed in the mp and never landed10:10
jelmervila: yeah, I don't think that was with you10:10
=== MTecknology is now known as ngx_mteck
vilaI think the issue with the warning is that explorer/GUI users may not get it10:10
vilaon the other hand, GUIs *should* guide the users on this particular issue10:11
jelmervila: Yeah, agreed10:11
vilaso let's do the warning and put the burden on GUI devs :D10:12
jelmerI think it's very clear how a GUI should deal with this - just prompt the user and suggest a username.10:12
=== ngx_mteck is now known as MTecknology
jelmervila: I also think we should bring back the functionality to guess a username, so it can be used by the GUIs as a suggestion, and so it can be used when we need a username for e.g. a lock or "bzr blame"10:13
vilajelmer: good point, but it's a separate issue10:15
vilahaa, what I meant is:10:15
vila- yes, valuable work has been invested in guessing, let's share it with GUIs10:15
vila- don't mix the warning stuff with the guessing stuff10:16
vilaor may be I'm wrong and instead the warning stuff *is* (or should) be based on the guessing (I don't remember the code in detail)10:17
jelmervila: I agree, they're related but separate issues10:18
vilaright, the pain point today is for admins, let's do the warning first and *then* let's address the guessing,10:19
vilathe former may be targeted  at 2.1 (unless it's too hard) while the later can be done in trunk10:20
vilathis way the admins can get their cake on lucid10:21
vilapending sru for 2.1 yada yada10:21
vilamaxb: your fix for bug 707075 is required for 2.2 whatever launchpadlib version is used right ?10:23
ubot5Launchpad bug 707075 in Bazaar 2.4 "lp-propose fails with a 404 error" [High,Fix released] https://launchpad.net/bugs/70707510:23
vilamaxb: (trying to see if it can be backported in the packaging branch for 2.2.3 or if we really need a 2.2.4 for other distros)10:24
Takwhich subproject is launchpad "bugs" ?11:02
mgzmalone.11:05
maxbvila: Correct, it is required for any launchpadlib >= 1.5.511:43
vilabusted (I didn't hope much ;)11:44
=== oubiwann_ is now known as oubiwann
vilajelmer: tracking a test failure in bzr-builddeb I end up with a test failure in bzr-svn: http://paste.ubuntu.com/561900/12:38
vilajelmer: do I need svn itself installed ? (I have bzr-svn/1.1 python-subvertpy from bzr/ppa (0.7.5))12:40
jelmervila: no, that's actually a known failure at the moment12:41
jelmerthere's an open bug about it12:41
vilaha, ok, thanks12:41
vilajelmer: some builddeb test require bzr-svn or fail (they should check the plugin is there instead, I'll fix), but I know have a failure due to a late change in revno 3510 AttributeError: 'Revision' object has no attribute 'mapping'12:51
vilas/know/now/12:51
jelmervila: as far as I know none of them really require bzr-svn, because I don't have bzr-svn installed in the environment I run the tests.12:58
vilajelmer: even the one that includes 'svn in their name in test_merge_upstream ?13:00
vilas/one/ones/13:00
vilacirca line 8013:00
vilajelmer: introduced ~08/2008 ;)13:01
vilajelmer: http://paste.ubuntu.com/561919/ , so the issue is that the test fakes a Revision object but not a ForeignRevision one :-/13:12
jelmervila: ah, hmm13:13
jelmervila: yeah, bzr-svn recently started looking at rev.mapping13:13
vilayeah, no worries, it's a test bug I'd say13:13
vilahow do I create this attribute to mean it comes from svn ? (value)13:14
=== Ursinha is now known as Ursinha-lunch
jelmervila: you'd need to get it from the bzr-svn mapping registry13:16
viladarn, complex object ?13:16
jelmervila: well, I guess you could mock one if you wanted to13:17
vilahmm, they are compared for equality so mocking...13:17
jelmerthe mapping object isn't compared, but the .vcs one is13:18
jelmerthe .vcs bit you should be able to get from bzrlib.foreign.foreign_vcs_registry.get("svn")13:18
vilajelmer: did the trick, thanks13:28
vilajelmer: yet, it's weird you don't see the failure when svn is not installed, are you sure you don't get it from somewhere unexpected ?13:30
jelmervila: hmm, actually.. I might have it but just an older version13:35
jelmervila: are you fixing this bug, or should I have a look?13:36
=== oubiwann is now known as oubiwann_
vilajelmer: now I'm fixing a bug in bzrlib.tests.ModuleAvailableFeature :-/13:50
vilashudder... no way I could force a dependency on bzr.dev to bzr-builddeb isn't it ?13:51
jelmervila: ideally not13:52
jelmervila: it makes backporting a pain13:52
jelmerother than that I don't really think it's a big deal13:53
vilaI will find a way to split the fixes13:53
fax8hi guys, I do have my sources updated to the latest revision14:37
fax8how do I get them as in a previous one14:37
fax8?14:37
jelmerfax8: hi14:43
jelmerfax8: I'm not sure I understand the question - you'd like to see the contents of a previous revision?14:43
jelmervila: fwiw there's already a MP open for the zipfile issue14:57
vilajelmer: trying to run selftest will all plugins I get >100 failures, if disable svn I get 014:58
vilajelmer: ha, rats14:58
jelmer(~jelmer/bzr-builddeb/712180-zipfile-python2.6)14:58
jelmervila: all foreign branch plugins trigger errors unfortunately14:58
vilaok, np, just making sure you knew about it14:59
jelmerit's on my list of things to work on (testsuite improvements for foreign plugins in general), but I haven't gotten to it yet14:59
vilajelmer: your patch for zip if far more complex than mine :D15:00
jelmerwell, it actually makes the zip file a proper file :)15:00
vilamine doesn't ?15:00
jelmerI thought it just added some bytes into the file?15:01
fax8jelmer: yeah.. I do have all the files updated to reversion X ... I want that all becames as in reversion X-Y.. how can I do so?15:01
vilajelmer: writestr accepts zinfo_or_arcname, you went for zinfo, I went for arcname (AFAUI)15:02
jelmervila: ah, ok15:02
vilafax8: there are various ways to achieve that, it depends on what you want to do *after(15:02
jelmervila: I guess we should take the smaller version of it then (but still close the bug #)15:03
vilajelmer: yup, I'm trying to check that using arcname is not a recent addition15:03
fax8vila: I don't wanna commit anything.. just see how the were (can't use bzr cat)15:03
vilafax8: why not create a new branch then: from <current> (where you are) : 'cd .. ; bzr branch current -r-2 new'15:05
vilabut generally you look at the diff: 'bzr diff -r-2'15:05
vilaor the status: 'bzr st -r-2'15:05
vilaso you don't touch your working tree and its uncommitted changes15:06
vilajelmer: I checked zipfile.writestr for python2.[456], three different versions all accepting the simpler one proposed above but varying slightly implementing yours.15:10
jelmervila: I'm not particularly tied to my solution, happy to go with yours.15:10
vilaok, I'll steal the bug then ;)15:11
vilajelmer: hmm, there is a debian dir there, how is the changelog handled ? Should I add an entry (or are tests not worth it) ?15:12
jelmervila: actually, since this is a regression that's never been in a release I'm not sure if a changelog entry is worth it15:13
vilaok15:13
fax8vila: thanks.. I did know about the branch solution.. I just wanted to switch to an older snapshot.. not needed to create a branch15:16
vilabzr pull -r2 then15:17
vilabzr pull -r-2 then15:17
jelmermore specifically, "bzr pull -r-2 --overwrite ."15:18
fax8that did it .. thank you15:19
vilajelmer: I start the freeze, no mp for the whoami warning ?15:27
jelmervila: nope, sorry15:27
jelmerwe can probably cherry pick it after its landed though15:28
vilanp15:28
vilawe ?15:28
vilaas in lp ?15:28
jelmeryeah15:29
vilak15:30
jelmerI'm keen to see a newer bzr deployed on lp, as it'll help with recipe builds (being able to use stacking, for example)15:30
vilaI'd prefer merging up from 2.1 if you target that, but since I won't be the one doing it, you're the judge ;)15:30
mgzexec vila? really? why not just check sys.modules first?15:31
vilaand they need a proper whoami there ?15:31
jelmervila: there among other places15:31
vilamgz: I was wondering who will mention that first, spiv, jam or you ;)15:31
mgz:D15:31
vilajelmer: ok15:31
jelmermgz: exec is what we use to load plugins, too15:31
jelmerso it doesn't seem that bad to use it here as well15:32
vilahonestly, I thought about checking sys.modules *after* submitting and then wondered if some edge cases would be covered...15:33
mgzyeah, it's not really that evil as it's just tests, but I get heebies about running some interpolated string15:33
vilamgz: nothing with running interpolated strings.... as long as you understand what they contain :D15:34
mgzwell, we can trust test authors not to write ModuleAvailableFeature("sys; something_evil")15:35
vilaright, worth mentioning in the mp, checking sys.modules should be enough here anyway plus I forgot to add tests15:37
vilas/mp/review/15:37
mgzI will add a little note.15:38
mgzdone, typed in some (untested) code that might work.15:44
mgz...and has at least two errors, which just makes life more fun.15:45
vilamgz: :)15:51
mgzjam gets one prize.16:07
jelmer'morning jam16:09
maxbjelmer: Hi, I have a question about bzrlib.plugins.launchpad - You recently added qastaging support - I was intending to refactor it to rely on launchpadlib for all its list-of-launchpad-instances support, but the versions of launchpadlib currently in ubuntu don't include qastaging. How would you feel about me addressing this by conditionally monkeypatching launchpadlib.uris ?16:12
jelmermaxb: hi16:12
jelmermaxb: what's the issue with the current way of retrieving the URLs?16:13
maxbThat we currently maintain two separate lists of launchpad instances within bzrlib.plugins.launchpad, and, except for the addition of qastaging, launchpadlib has all the data we need in the launchpadlib.uris module16:14
jelmercan't we just keep a single list in bzrlib.plugins.launchpad ?16:15
maxbI'm aiming to reduce the amount of launchpadlib functionality duplicated within bzrlib.plugins.launchpad.16:15
maxbSo, I was thinking of something along the lines of:   if 'qastaging' not in launchpadlib.uris.service_roots: launchpadlib.uris.service_roots['qastaging'] = 'https://api.qastaging.launchpad.net/'16:16
jelmermaxb: monkey patching is duplicating code as well16:16
maxbYes it is, but in the net reduction in duplication should be pleasing16:17
maxbYes it is, but in *this case* the net reduction in duplication should be pleasing16:17
maxbThe monkeypatching will be confined to four lines, and will allow all the rest of the code to use public launchpadlib apis for the rest of the URL manipulation16:20
jelmerit's about the same amount of code to cope with it sometimes being missing at the moment16:27
jelmerperhaps I'm missing something here :)16:27
=== beuno is now known as beuno-lunch
=== beuno-lunch is now known as beuno
jelmerabentley: hi17:43
abentleyjelmer, hi.17:43
jelmerabentley: I'm looking for a way to walk over the ancestors of a revision but processing them in increasing distance from my current tip17:44
jelmerabentley: is there anything in graph that allows me to do that?17:44
abentleyI don't think we have that specifically.  We have a breadth-first traversal.17:46
abentleyjelmer, does Graph._make_breadth_first_searcher do what you need?17:47
jelmerabentley: it seems to, but it's also private17:48
jelmerfind_descendants sort of seems to do what I need, except in the wrong order17:49
abentleyjelmer, I don't understand how it can be the wrong order if it uses make_breadth_first_searcher and make_breadth_first_searcher works for you.17:51
abentleyjelmer, nm.17:53
abentleyjelmer, what about iter_ancestry?17:53
jelmerabentley: I need to exclude a particular key and its ancestry17:54
vilajelmer: log needs that for --exclude-common-ancestry17:56
vilajelmer: see branch.iter_merge_sorted_revisions17:57
=== vila changed the topic of #bzr to: Bazaar version control | try https://answers.launchpad.net/bzr for more help | http://irclogs.ubuntu.com/ | Patch pilot: spiv | 2.3.0 is frozen. Release plugins ! Build installers ! (rm vila)
jelmer\o/18:00
vilajelmer: what's the landing policy for bzr-builddeb ? push when mp is approved ? 2 votes ? something else ?18:13
jelmervila: merge revision for branch when there is approval18:14
vilajelmer: locally, and push to trunk ?18:14
jelmervila: yeah18:15
* vila slaps fingers for working in trunk18:15
* jelmer wished there was a "bzr merge --into" command18:15
jelmerto say merge my branch into that one, with a particular message, rather than merging that one into mine18:16
vilabut... you need a working tree (if only for the conflicts)18:17
vilamerge is a serious operation you know, you can't just drop it on some random branch !18:18
vila;)18:18
jelmerthat's fine, I don't mind using the current one18:18
vilaoh, you mean --swap-parents ?18:18
jelmeryeah, that's all I care about really :)18:18
vila(don't search, it doesn't exist but has been mentioned several times)18:18
jelmerI did search :)18:18
vilasry :-/18:19
vilajelmer: test failures fix pushed18:20
jelmervila: \o/18:23
vilajelmer: and for bug status, committed and the RM mark them fix released ?18:23
jelmervila: yep18:25
jelmerat least that's what I've been doing, hopefully james_w can correct me if I'm wrong :)18:25
vilanah, looks fix-released when landed, but... https://launchpad.net/bzr-builddeb/+series isn't super clear 8-)18:25
vilaor fixreleased when mentioned in changelog ?18:27
vila:D18:27
vilaanyway, landed, marked fixed :)18:27
james_wI always used to do "commited" and then "released" on release, but it's kind of shaky given that it's a native package that I have sometimes uploaded to Ubuntu directly18:30
vilajames_w: ack18:35
vilahmm, code import failures mail flood, that reminds me about adding a host monitor for the package importer (lp is done, debian is unreachable, etc) to avoid this kind of issue18:48
vilas/done/down/ hee, that wasn't a joke ! Why did the tyop gnome keep jumping on my fingers !18:49
=== tremolux_ is now known as tremolux
james_woh hey, Debian release due. That's going to require some co-ordination with the importer and Launchpad20:26
=== jaypipes is now known as jaypipes-afk
pooliegood morning21:18
* jelmer waves21:22
pooliehi jelmer; what are you up to now?21:29
james_wpoolie, drowning me in merge proposals :-)21:35
james_wbut I imagine that jelmer sustains 12 other activities while doing that21:35
poolie:)21:51
jelmerpoolie: I swear, the VCS imports emails are not my fault :)22:07
poolie:)22:15
poolievila, still awake? we should consider doing a new 2.2.x soon i think, to get the sru going22:15
vilapoolie: yup, the question is: for what value of soon, I thought about it and whether it should be before 2.3.0 but decided that the later was more important22:17
vilapoolie: now, the second question is: ;)22:17
vilapoolie: should I freeze tomorrow or leave a bit of time to packagers,22:17
vilapoolie: but since we use pindependant branches and ppa, there is not a huge incentive to delay22:18
vilapoolie: so I probably freeze 2.2.4 tomorrow unless someone objects22:18
vilajelmer: ha ! not your fault ! Who else can generate such amounts ?22:20
vila:-p22:20
vilaOMG ! 23:20 local time ! The jetlag fairy is after me again or what ?  Back to the bed ! Back to the bed !22:22
* jelmer grins22:22
jelmervila: g'night :)22:23
maxbspeaking of independent ppas - do we really? normally I would start constructing 2.3.0 in proposed now, which would preclude 2.2.4 in PPA22:23
fullermdBed?  The sun isn't even up yet!22:23
vilamaxb: ouch, on the other hand, 2.3 will become the new stable, so all is really needed for 2.2.4 is bzr itself which you could upload directly (or blame the one who fixed the only bug there ;)22:28
vilamaxb, vila (note to self): may be worth documenting22:30
poolievila, also, i'd like to choose a good release name with you22:30
=== jaypipes-afk is now known as jaypipes
pooliesomething fun, exciting, and meaningful22:31
pooliehi jaypipes22:31
vilahehe22:31
jaypipespoolie: heyo :)22:31
vilapoolie: for 2.2.4 or 2.3.0 ? And could we do that tomorrow (argh, admin required for family bug :-/)22:32
jaypipespoolie: ty for your quick response on those bugs/questions22:32
poolieyou're welcome22:32
poolievila, 2.3.0 tomorrow sounds' ok; let's not miss the natty boat22:32
fullermd'natty boat'?  What an odd release name   :p22:34
mgzthat's a natty boat you're paddling fullermd.22:50
mgzwhat's happening with 2.3 and the no whoami case? I thought I read rumblings of wanting to change the behaviour there again.22:51
pooliehello mgz22:53
pooliei'd like to change it to use /etc/mailname if it's present22:53
pooliei guess this missed 2.3.0 but it could make 2.3.1 in natty, possibly22:53
poolieit seems to be quite a pain point for people doing automatic commits or using bzr to record /etc22:53
mgzthat sounds fine.22:54
mgzjust want to keep coverage where there's really no id, running as www-data and such like already has a few oddities.22:58
fullermdNo update to bookmarks plugin for 2.3   :(23:27

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!