/srv/irclogs.ubuntu.com/2011/02/06/#launchpad-dev.txt

cjohnstonas I said, im not very familiar with this part.. thats why I invited Ronnie and I've invited mhall119 here as well00:00
Ronnieim not familiar with the lp code too, it was created before i started hacking, but i think i know where too look00:01
cjohnstonif mhall119 makes it, hes the most familiar i believe00:01
mhall119hola00:01
cjohnstonhey00:01
cjohnstonmhall119: < lifeless> whats the api call you make to find out about the members of the team?00:02
cjohnston< lifeless> cjohnston: do you verify their lp uids?00:02
mhall119no, we assume that the openid response 'nickname' matches the launchpad username00:03
cjohnstonlifeless: see... i told you he would know the answers00:03
wgrantThat's not ideal. Is there a reason you can't check the OpenID identifier?00:03
cjohnstonhowdy wgrant00:04
mhall119wgrant: what do you mean?00:04
wgrantmhall119: LP usernames are mutable.00:04
mhall119http://paste.ubuntu.com/563231/ is what we do00:05
mhall119wgrant: I know, I have a merge proposal in to django-openid-auth that'll update the username on our end when the user logs in00:06
mhall119can we look it up based on the identity url?00:06
wgrantmhall119: Probably not at the moment. But that can be fixed easily enough.00:06
mhall119we're using the launchpadlib00:06
mhall119wgrant: we have the openid identity url, we can change our lookups to use that instead of username if/when that interface is available00:07
mhall119lp.people[ld_user.username] is doing a lookup on the People collection exposed by the webservice API to launchpadlib00:08
wgrantRight.00:08
wgrantWe can easily expose a method on lp.people to get a person by an OpenID identifier.00:08
mhall119our other problem, and I'm not sure if you can help us with that, is that SSO sometimes returns a response without a 'nickname' field, even when the user has a launchpad profile00:09
wgrantFor particular users?00:10
mhall119I suppose once we can do lookups based on the identity url, we can change our code to get nickname for that00:10
mhall119wgrant: let me see if I can find the name00:10
wgrantSSO has a bug like that for some users at the moment. It's fixed, but not yet rolled out.00:10
wgrantI investigated it with one particular LD user a couple of weeks ago.00:11
mhall119wgrant: that might have been for us00:11
Ronniei thought (but am not sure) that it was for users with unicode characters in the name00:11
wgrantSo, known SSO issue, fixed in trunk a month or so ago, but awaiting deployment.00:11
james_wwgrant, lookup based on identity url would be spiffy00:11
wgrantSadly it'll be a few days, because we are frozen for the release.00:12
mhall119well we've been dealing with this for months, another few days isn't going to kill us00:13
Ronniemhall119: cant we check if the username has changed each login?00:13
mhall119Ronnie: we can, yes, infact I have a code change to that pending with django-openid-auth00:13
mhall119but we don't want to wait on them to log in to LD, after changing their username in LP, for us to get their profile information again00:14
Ronnieif so, we can do checkups with the username instead of identity, right/00:14
mhall119in theory, but again we'd have to wait for them to log in00:14
lifelesswgrant: I think there is a bug already requesting openid lookups00:14
wgrantlifeless: I tried to find it.00:14
wgrantBut couldn't.00:14
mhall119if we can do lookups based on identity url, we can get updated during our nightly refresh00:14
wgrantOh.00:15
wgrantPossibly bug #65556500:15
_mup_Bug #655565: Immutable reference to users in API <api> <lp-foundations> <lp-registry> <Launchpad itself:Triaged> < https://launchpad.net/bugs/655565 >00:15
lifelessyes00:15
lifelessmhall119: so separately I'd like to get away from polling for updates00:15
lifelessmhall119: would pubsubhubbub work for you, if we implemented it ?00:15
mhall119is it strange that every time I see a number that starts with '655' I automatically think "oh no, integer overflow!"00:16
lifelessah, a 16 bitter00:16
mhall119pubsubhubbub?00:16
wgrantlifeless: Thinking of future plans, is there any reason not to expose a collection of OpenID identifiers, and a method to get a person by one?00:16
* mhall119 has actually barely ever written C code00:16
lifelessmhall119: http://code.google.com/p/pubsubhubbub/00:16
lifelesswgrant: collection - yes, person - no00:16
lifelesswgrant: but perhaps I'm being paranoid in objecting to such a collection00:17
wgrantOnce we support non-SSO authentication we may want to grant people the ability to make identifiers private, but I don't see much reason to not expose all the releated SSO ones now.00:17
lifelesswgrant: it just seems a little too like iterating /etc/passwd00:17
mhall119lifeless: are they talking real multicast?00:17
wgrantlifeless: I mean something like lp.person['wgrant'].openid_identifiers00:18
lifelesswgrant: that would be fine with me; might want to check if stuartm has any reservations00:18
wgrantWe already expose the primary one in the HTML.00:18
lifelesswgrant: I thought you meant lp.openid_identifiers00:18
wgrantAh, no, that would be pointless.00:18
mhall119yeah, I can already get a person's identifier if I have their username00:19
lifelessmhall119: its point to point but with hubs that multiplex00:19
mhall119lifeless: I'm sure we could implement whatever needs implementing on our end to achieve that00:19
lifelessok00:20
lifelessI suspect we can nuked 20 or 30 % load if we do this.00:20
lifelessBut someone is going to need to do some hard core log analysis to confirm that00:20
Ronnieback to our mugshot. what is exactly the problem?00:21
lifelessok00:23
lifelessso the LD page includes a reference to an api attribute which is the mugshot object; this acts like a symlink - it gets resolved and then does a 30200:23
lifelessif the object isn't there, you end up with a redirect to the containing object AFAICT - the user page.00:24
lifelessthere are several problems with just embedding the LP API url00:25
lifelessfirstly, its slow for users: you make them do 2 new https lookups00:25
wgrantlifeless: The bug seems to say that OpenID identifiers are not sufficient to fix it. But I think they are reasonable for this use case, so I'll open a separate bug.00:25
lifelessone to LP, which does a webapp request, then issues a 302, then a new https connection to th e librarian, which finally shows the content00:26
lifelessif you're on http you don't even actually want https but you have no choice as lp won't answer on http00:26
lifelesswgrant: is it right?00:26
lifelesswgrant: https://bugs.launchpad.net/launchpad/+bug/655565/comments/3 ?00:27
_mup_Bug #655565: Immutable reference to users in API <api> <lp-foundations> <lp-registry> <Launchpad itself:Triaged> < https://launchpad.net/bugs/655565 >00:27
lifelessRonnie: secondly, LP doesn't expose a magic object - one that transparently fills in the default mugshot if none is set00:28
wgrantlifeless: In this case I don't think they're really tracking LP users. They're tracking SSO users, getting extra info on them from LP.00:28
wgrantThe LD case, that is.00:28
lifelessRonnie: and arguably it shouldn't, because that would make it harder for actual API clients (rather than img dereferences) to use; it would be very special case.00:29
mhall119lifeless: LD checks if the user's logo_link starts like a URL, and sets a default if it doesn't00:29
lifelessRonnie: LP doesn't want such a magic attribute itself, because it would be heinously slow00:29
lifelessmhall119: http://loco.ubuntu.com/events/team/666/detail/ - broken images here00:29
mhall119yeah, I'm not sure sure why00:30
mhall119http://paste.ubuntu.com/563231/ shows the code we use set the mugshot url00:30
lifelessalso, you guys know not to use edge, right ?00:30
mhall119yes, cjohnston already submitted a fix to that00:30
lifelesshttp://blog.launchpad.net/general/edge-is-deprecated00:30
lifelesscool00:30
mhall119nigelb pointed it out earlier today00:30
lifelessgreat00:30
lifelessjust ensuring the message is out there :)00:31
lifelessedge has our oldest servers00:31
lifelessso moving off it will help you00:31
mhall119yeah, we've been migrating off00:31
mhall119just a few things we overlooked00:31
Ronniecjohnston: your lp login still uses edge: def lp_login(lp_instance=EDGE_SERVICE_ROOT):00:31
mhall119Ronnie: I think it only uses that for local setups00:32
lifelessstill should be changed00:32
mhall119or not00:32
lifelesslaunchpad has dropped the EDGE_SERVICE_ROOT constant00:32
mhall119lifeless: we had some issue with using openid from behind a firewall, I think is why we used different servers00:33
wgrantAlso, you should probably be using the devel API.00:34
wgrantRather than beta.00:34
lifelessor 1.000:34
wgrantI like to consider 1.0 a deprecated mistake :)00:34
lifelessif the software is packaged, 1.0, if its just a live website you update a lot devel is fine.00:34
mhall119what's the url for the devel api?00:35
wgrantmhall119: Which version of launchpadlib are you using? Lucid's?00:35
lifelessversion='devel' in the login call to launchpadliv00:35
wallyworld_henninge: ping00:36
mhall119wgrant: yeah, lucid00:36
wgrantmhall119: lifeless' suggestion will work, then.00:36
mhall119that'll work with login_anonymously too?00:37
lifelessyes00:38
wgrantUse something like Launchpad.login_anonymously('Loco Directory', 'production', version='devel')00:38
mhall119got it https://bugs.launchpad.net/loco-directory/+bug/71386800:39
_mup_Bug #713868: Use Launchpad devel API  <loco-directory:Confirmed> < https://launchpad.net/bugs/713868 >00:39
mhall119thanks00:39
lifelessok00:39
lifelessour logo_link and mugshot_links are crack.00:39
wgrantAre they?00:39
mhall119good crack or bad crack?00:40
lifelessbad00:40
mhall119is there something better we can be using?00:40
wgrantlifeless: Because they always link to the same URL?00:40
lifelesswe need to fix them00:40
wgrantWhich then redirects to the librarian?00:40
lifelesswgrant: because they link to appserver code00:40
lifelessbut for a public person (all people atm) we should just emit the librarian reference immediately.00:41
lifelessthe whole LFA->LFC chain will complicate the performance of this slightly00:41
lifelessbut we don't have a use case for 'can query the person and not their logo'00:42
wgrantOh, Squeeze has happened.00:45
lifelesswgrant: feel like eyeballing  apartial patch adding a new package - lp.testing as a webservice entity - and see if I've massively missed anything?00:46
wgrantlifeless: Sure.00:46
lifelesshttp://pastebin.com/CaTTajjy00:47
wgrantlifeless: Uh, lp.testing is probably not what you are looking for...00:48
lifelesswgrant: well, I thought that might be contentious ;)00:48
lifelesswgrant: OTOH, there is a certain logic to i.00:49
lifelessit.00:49
wgrantThere is, but this does not work.00:49
wgrantWe need to move one or the other.00:49
wgrantlifeless: Why are we storing subunit streams in LP, anyway?00:50
lifelesswgrant: so we can get them back out again00:50
wgrantlifeless: I don't really see why this is in scope for LP.00:50
lifelessmhall119: cjohnston: https://bugs.launchpad.net/launchpad/+bug/71387300:50
_mup_Bug #713873: Person.logo_link is hard to use and performs poorly <Launchpad itself:Triaged> < https://launchpad.net/bugs/713873 >00:51
wgrantUgh.00:54
wgrantDo we have a branching-debian process that we need to run for squeeze->wheezy branches?00:55
wgrantI guess the Ubuntu script will work just as well.00:56
lifelesswell00:57
lifelessthis is why the 'lets make sid the dev focus'00:57
wgrantI'm not sure the script will work too well in that case.00:58
wgrantBut yes.00:58
henningewallyworld_: Hi! in a rush ...00:59
henningewallyworld_: but thanks for the approval! I'll see to it first thing on Monday.01:00
wgrant:( They've created wheezy already.01:00
lifelessman, I don't understand why we get 170 updates to lucid :<01:01
wgrantI hope the package importer is using 'squeeze', not 'testing', like gina was last time.01:01
lifelessit was discussed on the caonical bazaar list, james_w seemed unconcerned about the basic correctness aspects01:02
wgrantIs ~canonical-bazaar going to handle the branches side of the new series?01:03
wgrantIncluding running branch-distro.py.01:03
lifelesswgrant: so you think using lp.testing as is will be too confusing ?01:04
wgrantlifeless: Yes. Using it for something other than internal testing utilities is crack.01:04
wgrantWell, more precisely, using it for both is crack.01:04
lifelesswgrant: its probably too late for the script; the new branches will be populating right now01:04
lifelessthey'll all stack01:04
wgrantNo they won't.01:05
lifelesshas the development focus changed already?01:05
wgrantThe new series doesn't exist yet.01:05
lifelessthen they won't be created01:05
wgrantHowever, the new series will be created and imported package-wise on Monday, unless the branch importer means I can't ask for that.01:08
lifelessIt would be best to stop it, then create, run the branch script, then start it.01:08
lifeless*or*01:08
lifelessstop it, create, make sure sid is the development focus, run the branch script, then start it.,01:09
james_wI've stopped the importer01:09
lifeless(and that way we never have this again)01:09
wgrantOK, so. Tomorrow I will convince a LOSA to make lenny supported, squeeze current, sid development, and create a future wheezy.01:10
lifelessyes01:10
wgrantThen we can fix gina crontabs, run branch-distro, and the package importer can be restarted at our leisure.01:10
wgrantit would also be nice to restack the rest of the branches on sid, but that's a bit hard.01:11
lifelessthe branch script moves the current ones to the new dev01:11
lifelessthen branches *back*01:11
wgrantRight.01:11
lifelessoh you mean -2 etc01:11
lifelessmeh01:11
wgrantAh, and in this case we probably don't have lenny branches.01:11
lifelessyes, in principle.01:11
lifelesswgrant: were there any other things about the patch;01:13
wgrantlifeless: Your security is crack.01:13
wgrantIt should inherit it from the branch.01:13
lifelesswgrant: how does one do that - I knew thats what I wanted, but not the mechanism to do so01:14
wgrantlifeless: See things like CodeReviewCommentView01:14
wgrantYou do the delegation manually.01:15
wgrantOr you write a base class which automates it :)01:15
lifelessanything else?01:15
wgrantlifeless: Your security ZCML doesn't use your security adapter.01:16
wgrantYou need to require launchpad.View01:17
wgrantNot allow.01:17
lifelesswgrant: sure, but thats tied to the other bit; thanks for being complete though.01:17
wgrantI also wonder how linkStream will function if the UUID doesn't exist.01:18
wgrantApart from that it looks good.01:18
wallyworld_henninge: no problem. thanks01:18
lifelesswgrant: it will blow up, which is ok01:18
wgrantlifeless: It will probably OOPS, which is not OK.01:18
lifelesswell01:18
lifelessindeed, I guess.01:19
lifelesshowever, I'm willing to land and iterate01:19
wgrantIt's probably another three lines to fix this and avoid a Critical bug.01:19
lifelessif its that simple, cool.01:20
lifelessI can has patch?01:20
lifelessI'll be shelving this until next weekend I suspect01:22
wgrantlifeless: Check if TSM.fetch returns None, if so raise some webservice-annotated exception.01:23
wgrantIf there is no appropriate webservice-annotated exception, three lines create a new one.01:23
lifelesswhats the one for 40401:26
wgrantIs a 404 appropriate here? Possibly, I guess.01:27
lifelessif the uuid is absent01:27
lifelessthe spec is ambivalent :)01:27
wgrantThere's lp.app.errors.NotFoundError.01:27
wgrantI am not entirely sure if that's annotated.01:27
wgrantjames_w: So can we go ahead and run branch-distro.py on Monday?01:30
james_wI don't see why not01:30
wgrantIt worked fine for Natty, so it seems safe enough.01:30
wgrantD:01:34
lifelesswgrant: hey, you were looking at bug 3246401:56
_mup_Bug #32464: guess_bugtask() fails on distribution tasks without a source package <lp-bugs> <oops> <Launchpad itself:Fix Released> < https://launchpad.net/bugs/32464 >01:56
lifelesswgrant: I thought you found the bug still existed?01:56
lifelesshmm02:02
lifelesswe really need a profile for where the python time in oopses like OOPS-1862C166902:02
lifeless33.879035msSQL-launchpad-main-slave02:03
lifelessSELECT ValidPersonCache.id02:03
lifelessFROM ValidPersonCache02:03
lifelessFROM ValidPersonCache02:03
lifelessWHERE ValidPersonCache.id = %sLIMIT 102:03
lifeless3 seconds between those trivial queries02:03
lifelessflacoste: OOPS-1862C1669 - these are the things making me think we're running into GIL overload quite a bit atm. I think we're going to need to escalate single threaded to the top rather than waiting for RFWTAD02:08
lifelessflacoste: same situation we had with the xmlrpc; same symtoms, and it was totally fixed when we gave it more resources.02:08
wgrantlifeless: It doesn't fail. It just does insane things, but the whole method is insane, so that's OK.02:11
lifelessok02:11
lifelesscool, thanks.02:11
wgrantYes, I was a bit surprised when he closed it too.02:11
lifelesswgrant: do you know where jon is at with bug 421901 ?02:12
_mup_Bug #421901: Person:+bugs timeouts <lp-bugs> <timeout> <Launchpad itself:In Progress by jcsackett> < https://launchpad.net/bugs/421901 >02:12
wgrantlifeless: Still actively working on it.02:14
wgrantWas going to talk to deryck about a couple of things, IIRC.02:14
lifeless15 second query02:19
lifelesswgrant: ok, I'm going to do some analysis, on the basis that he seems stalled, and that sucks,02:25
wgrantUhoh, they are going to enable testing migrations again tomorrow.02:29
wgrantA few days earlier than I expected :(02:29
lifeless?02:29
wgrantwheezy isn't going to be static for long.02:30
lifelessahha02:31
lifelessits 'commented on'02:31
lifelessthat is terribad02:31
wgrantOf course.02:32
lifelesswell02:32
lifelessits poorly constructed02:32
lifelessno particular reason it should be bad02:32
lifeless-wow- minutes of runtime on qas02:33
lifelesshahahaha02:33
lifeless8.4 fallout02:33
lifelessthe inner correlated join is the problem I think02:34
lifeless178 seconds cold02:34
wgrantOuch.02:35
lifeless20 hot02:35
lifelessheh02:58
lifelessapport has commented on more bugs than anyone else02:58
lifelessseb128 a close second02:58
wgrantHeh.02:59
lifelessok, wrapped in a bow and ready to cod03:03
lifelesse03:03
lifelesswgrant: is there anything you were needing extra inspiration on?03:06
=== Ursinha is now known as Ursinha-zzz
StevenKlifeless: Re your bugs about mugshot and logo -- there is precendent for that -- build records have a build_log_url property that is None if there none or a librarian URL if there is one04:40
lifelesscool04:41
wgrantWhy is OpenIDRPSummary still in the LP tree? :/04:47
wgrantAh, it's still used to warn about account renames.04:50
wgrantBut it seems to no longer be used.04:50
wgrantmawson's latest record is from April.04:50
wgrantPerhaps we should make profile delegation optional, and warn on rename if it's delegated at all.04:52
wgrantI wonder what SF.net does.04:53
wgrantThey have relatively unawful OpenID support.04:53
wgrantAh, indeed. Delegation is optional, and you can select the identifier that you wish to delegate to.04:54
=== Ursinha-zzz is now known as Ursinha-afk
* maxb is surprised to be able to wget https://api.launchpad.net/1.0/branches?ws.op=getByUrl&url=lp:bzr without any oauth fiddling17:00
maxbWhen did that happen?17:00
lifelessmorning17:54
lifelessmaxb: 6 july last year17:54
lifelessallenap: around per chance ?18:53
lifelessah18:55
lifelessactually brad18:55
lifelessbac: ping18:55
wallyworld_thumper: morning. did we need a call this morning?21:02
thumperwallyworld_: hi21:03
thumperwallyworld_: I'm trying to leave the office to get coffee and a warrent for the car21:03
thumperbut got suck clearing through emails21:03
wallyworld_thumper: np. ping me later if required21:04
wallyworld_i've had my coffee :-)21:04
thumperphew21:05
thumperjust done with the email21:05
thumperwallyworld_:  how's your recipe work going?21:05
wallyworld_thumper: ok. didn't get much else done with those forms. been doing rm stuff - just landing r-c db-devel branch for julian now. gotta get that done asap21:07
thumperok21:07
thumpergah21:58
thumperfound out that it was "self..." that was screwing up my js tests, should be "this.foo"21:58
lifelessheh22:01
lifelesshttps://code.launchpad.net/~lifeless/launchpad/bug-661988/+merge/4874022:15
huwshimiHas anyone hit this problem when using rocketfuel-branch today? Error: Couldn't find a distribution for 'windmill==1.5pre-deryck'22:39
lifelessupdate your download cache22:40
huwshimilifeless: How do I do that. There were instructions on the wiki, but they got removed :(22:42
lifelessthey did?22:42
lifelessI cd to the download cache and run bzr update22:43
huwshimiwell they were on the canonical wiki22:43
StevenK  Set up canonical.testing.layers.DatabaseLayer in 10.542 seconds.22:44
StevenK  Set up canonical.testing.layers.LibrarianLayer in 16.152 seconds.22:44
* StevenK peers at his machine22:44
wallyworld_StevenK: hot last night? meant to be the hottest on record22:45
StevenKwallyworld_: Last night? No, last night was fine, it was the night before that22:46
wallyworld_ah ok.22:46
StevenK41degC during the day, and it only dropped to 36 inside or so when Sarah and I went to bed.22:47
* wgrant wonders how to QA r12321.22:48
huwshimi lifeless: Thanks that's fixed it. Just so I can understand, what does that download-cache do?22:50
lifelessits where we have buildout configured to 'download' from22:51
lifelessrather than grabing untrusted stuff off of the net22:51
wallyworld_wgrant: not sure but thanks for looking. btw i'm doing r12315 as soon as i get a feature flag enabled22:52
wgrantwallyworld_: I just did that. It's not behind FF, though -- it's just plain disabled.22:52
wgrantSo there is no change, as long as existing subscriptions work.22:52
huwshimilifeless: Right. Thanks.22:52
wgrantWhich they do.22:52
wallyworld_wgrant: i the advanced fields alluded to in the bug report and qa notes are hidden behind a feature flag i thought?22:53
wallyworld_or maybe i missed something22:53
wgrantuse_advanced_subscriptions is hardcoded to false for now.22:53
wgrantIt *should* be behind FF. But it isn't.22:53
wallyworld_so how did you test then if advanced_sub is false?22:54
wgrantI tested that the JS around it still works. It's impossible to QA the stuff inside the change, but I know it didn't break anything that is not disabled.22:54
wgrantAnd that is what matters.22:54
wallyworld_sure, but the bug also talks about updating the bug notification level field22:55
wallyworld_and that can be tested if the advanced subscriptions were enabled22:55
wallyworld_s/bug/mp22:56
wgrantAhem, a couple of Unity crashes later...22:59
StevenKne22:59
* StevenK glares at Do22:59
wgrantI didn't realise you were looking at that bit, sorry. https://bugs.dogfood.launchpad.net/ubuntu/+bug/1234/+subscribe is where I QA'd that, since I can add FFs there.22:59
_mup_Bug #1234: Gina is an unmaintainable mess of command line options, environment variables and shell scripts <lp-foundations> <Launchpad itself:Fix Released by debonzi> < https://launchpad.net/bugs/1234 >22:59
wgrantwallyworld_: ^^22:59
* wallyworld_ looks23:02
wgrantUm, it seems to not have come back up properly after I pulled the debversion stuff.23:04
wgrantHrmm.23:05
wallyworld_wgrant: that page on dogfood errors for me.23:05
thumper:-(23:06
thumpercar needs two new tires23:06
thumperI'm home to collect charger and usb cable so I can continue to work from town while care is getting fixed23:06
thumperat least #launchpad is quiet on Mondays23:07
wallyworld_thumper: i think you meant to say "tyres" :-P23:07
thumperwallyworld_:  what ever....23:08
thumperstupid english language23:08
wallyworld_no, the english language is fine. it's "american english" that is broken :-)23:08
* thumper afk again23:08
wgrantwallyworld_: It's back now, but that restart destroyed the cache, so Launchpad bug heat updates time out like on qas... however it still works fine on smaller projects like https://bugs.dogfood.launchpad.net/ivle/+bug/647286/+subscribe23:14
_mup_Bug #647286: Ability to import/export exercises and worksheets <exercises> <worksheets> <IVLE:Triaged> < https://launchpad.net/bugs/647286 >23:14
wallyworld_wgrant: thanks23:14
wallyworld_wgrant: the rev on dogfood is too old to qa 1231523:19
wgrantlaunchpad@mawson:/srv/launchpad.net/codelines/current$ bzr revno23:19
wgrant1018023:19
wgrantNot sure what updates the footer.23:20
wgrantBut it clearly hasn't happened in a while :/23:20
wallyworld_yup :-)23:20
* wgrant goes Makefile diving.23:20
pooliehi all23:25
wgrantwallyworld_: The footer no longer lies.23:26
wallyworld_cool23:26
wgrantBut we have a LOSA now anyway.23:27
StevenKwgrant: Did you fix it to actually update when the branch does?23:27
wgrantStevenK: No. make clean does, that but it seems to be all :/23:29
poolieguys, should i have another go at removing the oauth.py duplication, or just leave it?23:35
lifelesspoolie: I thought it was fixed23:35
lifelessI saw a new python-openid in the download cache23:36
wgrantlifeless: != oauth23:36
pooliei think that's different23:36
pooliethe last mail i have is just talking about reverting the attempted removal23:36
lifelessI'd roll a fixed egg23:37
lifelessbetter than having this thing hiding in contrib that noone knows to look for23:37
poolieyou'd prefer an updated egg to using the ubuntu package?23:37
wgrantYup.23:37
poolielaunchpadlib currently uses the ubuntu package23:38
pooliewgrant: yup to what?23:38
wgrantpoolie: To lifeless "I'd roll a fixed egg"23:38
wgrantpoolie: We don't use the launchpadlib package.23:38
wgrantWe use an egg.23:38
pooliefor the sake of my education, why is this better than using the distro package?23:38
wgrantBecause someone said so.23:38
pooliebecause it's easier to make our own changes later?23:38
wgrantI disagree.23:38
lifelessuhm23:38
lifelessmy understanding is that the distro package in lucid is too old.23:39
wgrantIt makes it easier to do upgrades.23:39
lifelessis that wrong ?23:39
wgrantlifeless: We have PPAs for that.23:39
pooliewgrant, no, i know the server doesn't use launchpadlib, but istm there is some benefit from having both the client and the server use the same thing23:39
poolielifeless, no, it's been fixed in ubuntu since... karmic, at least23:39
wgrantYou would think.23:39
pooliei think also since hardy23:39
lifelessso, if its fixed in lucid packages, we can use that23:40
poolie'rmadison python-oauth' shows it's actually unchanged since karmic23:40
lifelessthe more complex the package, the less likely we can use it in production deployments23:40
lifelessbecause of the 'only one can be installed' nature of python packaging; I've posted to debian-python a few times, and been talking to allison, barry etc about this23:41
poolieright23:41
pooliein this case it is just two py files, and also slowly moving (maybe dead) upstream23:42
lifelessthe big thing here is that the api isn't changing23:42
poolieright, it's highly unlikely to get anything more than just bug fixes23:42
wgrantwallyworld_: FWIW the translations change seems to be good. But it's hard to be sure, since I don't really know translations.23:42
poolieso, the right way to proceed is:23:42
poolieupdate launchpad-dependencies to pull it in23:42
pooliesomehow get that rolled out23:42
pooliedelete the egg23:43
poolieand ditto get that updated by everyone23:43
lifelesswhich is why we can switch to using the package; add it to launchpad-*-dependencies, build that, remove from download cache, let the losas know the package is needed (they generally port the dependencies package to address this)23:43
wgrantWhy do the translations DB tables hardcode 'ubuntu' in some column names? :/23:43
pooliethen resubmit the deletion of the copy in contrib?23:43
lifelesspoolie: was it rolled back ?23:44
wallyworld_wgrant: i don't know translations either.23:44
poolieyes, it caused a buildbot failure friday night my time23:44
lifelesspoolie: anyhow yes; but after the release.23:44
pooliesorry23:44
lifelessthis coming friday.23:44
pooliesure23:44
lifelesswallyworld_: wgrant: a pragmatic denormalisation23:44
poolieis there documentation somewhere of how to update the dependencies package etc?23:45
lifelesswallyworld_: wgrant: possibly unneeded, possibly needed.23:45
lifelesspoolie: pretty sure its on the dev wiki23:45
wgrantlifeless: But definitely bad :)23:45
poolieok, i'll shelve it until next week and maybe try then23:45
lifelesswgrant: I live in a world with greys23:45
wgrantwallyworld_: Note that staging will take a while to update with the debversion change.23:45
wgrantwallyworld_: The patch itself could take half an hour to run.23:45
lifelesspoolie: sure; sorry you're having such trouble landing it successfully.23:45
* thumper is connected again23:45
thumpermore coffee on its way23:46
poolieit's ok23:46
poolieit's been interesting23:46
pooliei'm more just sorry to have caused a buildbot failure for something with no immediate concrete benefit23:46
wgrantbuildbot failures happen.23:46
pooliehowever, i guess if you tolerate duplication because it's hard to remove, things get worse and worse23:47
poolieit's possible there are other fixes in the newer package too23:47
lifelesspoolie: this is because we have too many ways to do dependencies.23:47
poolieright23:47
poolierigh23:47
lifelessI'd like to have one - the python upstream way (there isn't one), and have the packaging system back us up (but it can't yet)23:47
poolie:)23:47
wallyworld_wgrant: yeah, i know that patch will take some time to apply. just trying to communicate that rev 10178 doesn't have to be qa'ed right this second, but sometime soonish would be good :-)23:48
pooliewhen you say the rollout's this coming friday23:50
pooliei thought it was thursday a/nz time23:50
lifelesspoolie: it is, I'm saying try landing on friday23:51
poolieoh i see, ok23:52

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!