[09:42] ivanka: ping [09:57] Goeie dag, mense! === zyga_ is now known as zyga [11:18] Can someone please remind me how to clear my SSO credentials so that I need to sign in again? [11:21] mpt: ou have to remove the keys from the keyring, do you know how to do that? [11:21] mandel, ah, never mind, I just closed Ubuntu Software Center and reopened it [11:21] ok [11:21] ivanka: ping [12:12] good morning everyone! [12:12] time to code. [12:13] wish everybody a fruitful day of work === teknico is now known as teknico_away [13:20] hello all! [13:20] alecu: hola [13:21] hello mandel! how are you feeling today? [13:21] alecu: fine, i'm getting quite good at typing like ths :P [13:22] alecu: also quite happy about the pipeline plugin for bzr, is bloody awesome, have u tired it? [13:22] mandel, never tried it... looking. [13:23] alecu: is certainly useful for whenever you have huge changes to make [13:24] mandel, oh, that's really interesting. I could have really used it a few days ago :P [13:24] alecu: well,better late than never ;) [13:25] u already know it for the next time [13:25] yes! I'm going to learn it before next time :-) [13:44] it's also on my list [13:45] looks like it would really help with branches that depend on one another [13:45] thisfred: I can tell you, if switch to use it in the widnwos port and i cannot be happier :) [13:45] alecu: there was a mail to warthogs or canonical-tech a week or two ago with a video demonstrating pipelines [13:47] sorry for my typing, the hand is tired :P [13:54] * alecu needs to catch up with warthogs... === yofel_ is now known as yofel [13:58] hello eveyrone! [13:58] everyone* as well [14:00] hi [14:00] me [14:00] me [14:00] me [14:01] me [14:02] ralsina? [14:02] me [14:02] thisfred ? [14:03] me [14:03] sry [14:03] DONE: proposed branch for bug #714583 (need reviews!). Conversations re: bug #709496. Talk with chicharra team re bug #715776 [14:03] TODO: work on #715776 [14:03] BLOCKED: nopes [14:03] NEXT: mandel [14:04] Launchpad bug 714583 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "Support share subscription in Folders tab (affects: 1) (heat: 3426)" [High,Triaged] https://launchpad.net/bugs/714583 [14:04] Launchpad bug 709496 in canonical-identity-provider "Need a way to set the 'displayname' property for newly created accounts using REST API (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/709496 [14:04] Launchpad bug 715776 in ubuntuone-client "Shares dir name may not be unique (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/715776 [14:04] DONE: Update the man for u1trial to fix bug #715195. Fixed merging issue of os_helper branch for sd. Slipted branch that adds file system notification for easy review. [14:04] TODO: propose merges for filesystem notifications. Rearrange meeting with ralsina and ivanka. Get ralsina to tests changes on windows. Slip ipc brach for windows. [14:04] alecu, please [14:04] DONE: worked on pending UI branch to update unity launcher icon progressbar (bug #702116). started looking into tomboy oopses, found little robots and 503 couch timeouts [14:04] Launchpad bug 715195 in ubuntuone-dev-tools "u1trial man is not updated (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/715195 [14:04] TODO: find out root oops cause, finish progress branch above [14:04] BLOCKED: no [14:04] NEXT: dobey [14:04] uh blocked: no [14:04] Launchpad bug 702116 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to show and update a progressbar in the Ubuntu One launcher for pending operations (affects: 1) (heat: 166)" [Medium,Triaged] https://launchpad.net/bugs/702116 [14:04] λ DONE: more shotwell research, more pth fixing, bug 715450, bug 715488, [14:04] λ TODO: shotwell plug-in research, finish bug 673012, evaluate SRUs for maverick [14:04] Launchpad bug 715450 in ubuntuone-client "[r847] ubuntuone-client crashes with ImportError from ubuntuone.platform.linux.api.restclient import RestClient (no api.restclient in ubuntuone.platform.linux) (affects: 1) (heat: 6)" [Critical,Fix committed] https://launchpad.net/bugs/715450 [14:04] λ BLCK: None. [14:04] Launchpad bug 715488 in ubuntuone-client "[r847] ubuntuone.credentials moved to ubuntuone.platform.linux. Syncdaemon ImportErrors (affects: 1) (heat: 8)" [Critical,Fix committed] https://launchpad.net/bugs/715488 [14:04] Launchpad bug 673012 in desktopcouch (Ubuntu) (and 1 other project) "Async monitoring of _changes (affects: 1) (heat: 43)" [Undecided,Confirmed] https://launchpad.net/bugs/673012 [14:04] ralsina: [14:04] DONE: reviews (on windows, too), many many calls, canonicaladmin [14:04] TODO: reviews, management stuff, sprint planning, triage another 8 tons of bugs [14:04] someday actual coding ;-) [14:04] BLOCKED: no [14:04] thisfred? [14:04] DONE: bug #702055, bug #702075, bug #702138, bug #702144 [14:05] o/ [14:05] Launchpad bug 702055 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to send a notification when a new UDF is available for subscription (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702055 [14:05] Launchpad bug 702075 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to add an entry to the messaging menu when a new UDF is available for subscription (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702075 [14:05] Launchpad bug 702138 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to send a notification when a new share offer comes in (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702138 [14:05] Launchpad bug 702144 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to add an entry to the messaging menu when a new share offer comes in (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702144 [14:05] TODO: the other 3 | API [14:05] and frack it's cold. [14:05] Blocked: no [14:05] dobey: amen to that [14:05] comments anyone? [14:06] how did it go from 50F to 25F overnight :( [14:06] ralsina: so, we got the official approve for the sprint? :-) [14:06] at least next week's forecast is pretty much all in the 60s [14:06] nessita: waiting on Chipaca's word on it [14:06] dobey: 21 here [14:07] dobey: same here, only celsius :-) [14:07] grr [14:07] I found one flight that leaves at 6am on the 3rd that would work, but otherwise yeah [14:07] ok, comments? [14:07] none here [14:07] just one [14:08] I need reviews for: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/share-subs/+merge/48955 and https://code.launchpad.net/~nataliabidart/ubuntuone-client/get-sharesdir/+merge/48954 [14:08] DING DONG THE WITCH IS ALMOST DEAD [14:08] where by witch, i mean u1sync [14:08] I also need reviews https://code.launchpad.net/~thisfred/ubuntuone-client/lp-702055/+merge/48987 [14:08] * ralsina will do them all [14:08] first mandel, then nessita, then thisfred, then nessita2 [14:09] First come, first server basis. [14:09] on review to bring them, and one to bind them? [14:09] s/ver/ved/g [14:09] i think that should be our policy [14:09] nessita: that second branch I can probably do, unless my computer makes it impossible again [14:09] dobey: don't do the full nerd. Yo never do the full nerd :-) [14:09] thisfred: let me know :-) [14:09] I'm on it [14:11] eom? [14:11] eom! [14:12] ralsina: ready for reviews then :) [14:12] mandel: cool. [14:12] mandel: so I will re-merge that branch and test it in 2' [14:12] ralsina: perfect, plus that one there are other 3 that you need to run on windows [14:13] my internet is flaking out. [14:13] so let me know if ou can do them [14:13] mandel: sure I can [14:13] what's the windows equivalent of rm -rf ? [14:13] deltree \ ? [14:13] alecu: that's DOS :-) [14:14] i though del works.... [14:14] deltree \ -Y :) [14:14] mandel: del /s /q leaves the folders [14:14] windows is dos [14:15] if you mean windows windows, it is "select the folder in explorer and press shift+del on keyboard" [14:15] ralsina, rmdir /q /s [14:15] http://bash.org/?50070 [14:15] dobey: I meant a command inside cmd [14:15] alecu: cool, thx [14:15] haha [14:16] dobey: and it's not DOS if you don't have command.com :-) [14:16] sure it is [14:17] the real question is, do you have gorilla.bas? [14:17] dobey: no I don't :-( [14:18] OOH [14:18] * karni loads batteries with lunch [14:19] http://inventwithpython.com/extra/gorilla.py [14:19] this needs packaging. [14:20] mandel: no module named pywintypes, what am I missing? [14:20] i'm missing pygame x] [14:20] ralsina: this http://starship.python.net/~skippy/win32/Downloads.html [14:20] mandel: getting [14:21] mandel: that page says that page is obsolete [14:21] ralsina: we access the win32 calls from there to fix some issues with the rights of a file etc.. [14:21] ralsina: yes, but you can follow pointer :) [14:21] mandel: ok [14:21] ralsina: is the one i know heheh [14:22] mandell fetching & installing [14:22] dobey, that's an awful display of bad pygame. [14:24] mandel: successful tests!!!!! [14:24] alecu: yes, it crashed when i pressed arrow :P [14:24] anyways [14:24] ralsina: yes, and more are to come :) [14:24] mandel: and it only runs the path I asked [14:24] So +1 it is [14:25] ralsina: ok, hre is the next: https://code.launchpad.net/~mandel/ubuntuone-client/windows_reuse_pyinotify/+merge/49062 [14:25] mandel: but just to be sure, what's the goal you are aiming for in this first branch? [14:25] ralsina: i've reused pyinotify as max as possible so that most of the logic in the current code con stay the same way [14:25] I meant in the os_helper [14:25] dobey: what happened with the release? [14:26] ralsina: there are os calls on linux python that do not exist on windows or that throw diff error etc... [14:26] nessita: will make it today. some stuff broke when mandel's branch landed and the fix just landed this morning [14:27] mandel: yes, but what am I supposed to test to say "this works?" all the platform tests? [14:27] dobey, nessita UPS SORRY [14:27] ralsina: yes, all the platform tests should run [14:27] ok, they don't:-( [14:27] self.monitor = FilesystemMonitor(self, fs, ignore_config) [14:27] exceptions.TypeError: object.__new__() takes no parameters [14:27] dobey: we need https://code.launchpad.net/~verterok/ubuntuone-client/fix-712056/+merge/48826 landed as well [14:28] ralsina: all the os_helper tests :) [14:28] ralsina: not everything atm [14:28] mandel: ok, let me check the output then [14:28] so you can do python u1trial tests/platform/test_os_helper [14:28] nessita: ok, i'd also like to get the branch i'm going to propose shortly, in as well [14:29] * karni is back after lunch. [14:29] mandel: in os_platform there are a couple of NotImplementeds [14:29] and python u1trial tests/platform/windows/test_os_helper [14:29] os_helper I meant [14:29] ein? [14:30] ralsina: can you pastebin it [14:30] mandel: on it [14:30] damn, windows terminal history is TINY [14:31] is there something like tee for windows? [14:31] mndel: give me 1' and I'll re-run and pastebin it [14:32] ralsina: use cygwin, is the best thing to do for us [14:32] ActionQueueCommandTestCase object has no attribute action_queue [14:32] ralsina: ok, i'll be out for 2 min i need to microwave my food :) [14:32] That makes a bunch fail [14:32] ralsina: heh, I'm at that very place, but porting to Java [14:32] ralsina: you have to run python u1tiral tests/platform/test_os_helper [14:32] oh, wait, it's running the wrong tests! [14:32] python is so freaking smart it's not making it easy sometimes. [14:33] ralsina: and python u1trial tests/platfrom/windows/test_os_helper [14:33] mandel: with FORWARD slashes? [14:33] ralsina: no, with back, but I cannot type very well :P [14:33] Then that's what I did :-( [14:34] ralsina: pastebin please :) [14:34] and include the command you used and from where [14:35] mandel: I am getting cygwin, I just can't get a useful copy from the cmd window [14:39] mandel: I used that command. It starts with the right tests but doesn't stop, and starts running other tests [14:39] argh, my mistake of course [14:40] I was using run-tests.bat instead of u1trial [14:40] It's perfect. +1 [14:44] ralsina: cool :) [14:44] ralsina: shall we move to the next [14:44] ? [14:44] yes please [14:45] ralsina: https://code.launchpad.net/~mandel/ubuntuone-client/windows_reuse_pyinotify/+merge/49062 [14:45] Ok, I am now starting with that one [14:45] that is part of a huge merge, it get the code i can reuse from pyinotify [14:46] which later i reuse for the file notifications so that we cna reuse as much logic as posible [14:46] ralsina: is a copy paste, so running the tests on windows and get the fail is the expected result :P [14:46] mandel: ok, that should be achievable ;-) [14:46] otherwhise the merge was of 3000 lines or more [14:47] mandel: bzr is again whining about limbo and permissions. That means I have to whack the whole repo here to unstuck it. Will take a minute or two. [14:48] ralsina: ok, i"ll get a coffee then :) [14:53] * ralsina is starting to hate bzr, windows and life [14:54] tea, hot, with hints of brand new kettle [14:55] ralsina: so do i deserve a pay raise? :) [14:56] mandel: or sainthood :-) [14:56] ralsina: i had to try :) [14:58] nessita: ping [14:59] mandel: pong [14:59] whoot whoot [14:59] nessita: can you give me a read review on windows branch? [15:00] mandel: sure! shoot [15:00] nessita: thx! [15:00] there you go: https://code.launchpad.net/~mandel/ubuntuone-client/implement_windows_os_helper/+merge/46630 [15:01] dobey: a couple of branches have been approved for u1client, so let me know before you make the release so I can confirm they are landed [15:01] * ralsina is paddling in a river jello. And not the nice jello, ugly green jello. Guacamole flavored jello. [15:03] mandel: ok, finally slapped bzr into giving me a merged branch [15:03] https://code.launchpad.net/~dobey/ubuntuone-client/remove-u1sync/+merge/49070 [15:03] mandel: runnint tests [15:03] mandel: why this file tests/platform/linux/test_os_helper.py appears as added? [15:04] and https://code.launchpad.net/~dobey/u1sync/move-u1sync-here/+merge/49072 [15:04] mandel: they fail as you predicted. That means approve? :-) [15:04] nessita: because on linux we are testing certain things that are specific to it, the idea is that the linux one stays and the more general one too, it may appear the test the smae thing, but there are small differences to take intoaccount [15:04] ralsina: yes hehe [15:05] ralsina: you can read the code, but it is a copy paste from pyinotify [15:05] mande: are you checking that these are not breaking anything on Linux?> [15:05] mandel: right, but I wonder is why that file, that has as author only verterok, is added as a new file [15:05] ralsina: yes, and i'm also asking people to do linux reviews to make sure [15:05] mandel: ok [15:06] nessita: no idea, maybe i used the cp command instead of bzr move [15:06] mandel: +1 applied [15:06] ralsina: ok, in the next we use that code, ready? [15:06] mandel: can you please revert that change and use bzr move? otherwise the bzr history will be screwed up [15:07] yes, shoot [15:07] ralsina: take a look at this: https://code.launchpad.net/~mandel/ubuntuone-client/windows_pyinotify_missing_parts/+merge/49061 [15:08] ralsina: the new tests to run are python u1trial tests/platfrom/windows/test_fylesystem_notifications [15:08] mandel: copy/paste? is pyinotify GPLv3? [15:09] mandel: ok, merging [15:09] dobey: is MIT [15:09] dobey: is that a problem [15:09] ?? [15:09] mandel: the original (C) notice must be preserved [15:09] mandel: tests pass now. cool. [15:09] nessita: it would be kind of hard to do since i have other branches based on that one…. [15:10] cut+paste code is not fun [15:10] dobey: it is there... [15:10] * mandel checks [15:10] mandel: but this is not good, we lose all the bzr history on that branchy [15:10] on that file, sorry [15:10] mandel: also, it is not 2009 any more [15:11] dobey: if it says (c) 2009 it's because 2009 was the last time the file was edited by that author, regardless of what year it is ;-) [15:11] * alecu__ hates bad internet days [15:11] ralsina: look at line 8 of the diff [15:11] 8+# Copyright 2009 Canonical Ltd. [15:11] in a newly added file :P [15:11] hi alecu__, look what rye found: http://ubuntuone.com/p/cIS/ [15:12] dobey: uh, which diff? [15:12] mandel: you can fix this branch and then merge the branch again on the depending branches [15:12] nessita, yeah. I knew that would bite us... but not in such an ugly way. [15:12] mandel: https://code.launchpad.net/~mandel/ubuntuone-client/windows_pyinotify_missing_parts/+merge/49061 [15:12] nessita, that's because I'm considering the amount of pending operations towards the % [15:12] but allowing this just because is too much work to fix something that was made not properly the first time... I don't know, I don't feel comfortable [15:13] mandel: ^ [15:13] alecu__: which makes sense. But why the total does not count that? [15:14] nessita, the 52/52 is the number of UploadCommands that were done. The 95% counts the total number of operations... [15:14] nessita: well, is not that much work, but taking into account that: 1 I can just yype with my left ahdn, 2: is a test file, 3: I need to get this wokring for the release, well it is a PITA for what i get back [15:14] nessita, so I'm open to finding out a better way of counting that. [15:14] dobey: I must have copy the header from somehwere [15:15] * mandel fixed that [15:15] mandel: where the file come from? there is no file deleted in your branch [15:15] hmmm u1trial ran the tests successfully, and then locked up the terminal session. [15:15] nessita, the thing is that if I count the "other" operations towards the count of uploads it will be misleading. [15:16] ralsina: u1trial did, or run-tests did? [15:16] dobey: u1trial [15:16] nessita, because each "upload" may be a MakefileCommand followed by an UploadCommand. [15:16] alecu: count only the uploads for the %? [15:16] alecu__: this is why at the beginning I said we should count the MakeFIle as operations [15:17] in the sense that one upload is 2 operations pending [15:17] ralsina: i blame twisted [15:17] ralsina, if I only count uploads for the %, my "all completed!" message would be misleading as well. (but perhaps it would work) [15:18] nessita: tests/plafrom/test_os_helper was modified adding the general changiges, the linux one is ne, i really donot see an issue here [15:18] alecu__: it would be misleading in that there will be some operations pending, but the files will be uploaded anyway [15:18] nessita, I'm counting MakeFile as operations, yes. But I can't say "2 files uploaded" just because I have two operations if only one file is being uploaded. [15:19] nessita: there one new added and one modified? what is the issue you see? [15:19] mandel: I'm not following you. IN the diff, the file is a whole new file tests/platform/linux/test_os_helper.py. If you created it from scratch, you should be the author. If you didn't, and you took it from somewhere in the repo, I'm asking from where, and in that case, it should not be in the diff as 'completely new' [15:19] ralsina, yes. So... in that case, would we still be showing the progressbar, or will be consider everything as "done" ? [15:19] lI say done [15:20] yes, I like that. [15:20] It's lying, but the important part is really done. [15:20] alecu__: I agree. I would suggest then changing the wording a bit, for example: [15:20] ralsina, we should find out what other types of operations those can be, and if they can be "dangerous" at all. [15:20] In the case of dangerous operations, count them in too. [15:21] alecu__: '52 of 52 files uploaded. Still 5% operations to be in sync.' [15:21] nessita: that's just soooo nerdy :-) [15:21] nerdy? [15:21] 52/52 is nerdy :-) [15:21] 52/52 == 1 is nerdy :-D [15:22] 42 is nerdy [15:22] 52 is just a bit over the top [15:22] what's a user supposed to figure out from "all my files are uploaded but it still has to do things, it seems. 5% of things :-)" [15:22] nessita: cp tests/platform/test_os_helper.py tests/platform/linux/test_os_helper.py, vim tests/platfrom/test_os_helper.py :wq bzr add tests/platfrom/linux/test_os_helper.py bzr status added tests/platfrom/linux/test/os_helper.py modififed tests/platfrom/linux/tests_os_helper.py [15:22] Or, lie harder: put the "other ops" at the beginning. [15:23] ie: until all ops are done, say there is one file left to sync. [15:23] mandel: there, the error is using cp. You should bzr move tests/platform/test_os_helper.py tests/platform/linux/test_os_helper.py [15:23] nessita: well, the modified should be the platfrom one, i misstyped that [15:23] mandel: and the file will not appeared as new [15:23] rye, that's a lovely screenshot: http://ubuntuone.com/p/cIS/ Would you mind opening a bug for it? [15:23] mandel: is important to maintain the bzr history in the file [15:23] nessita: but tests/platfrom/test_os_helper.py would [15:24] mandel: but tests/platform/linux/test_os_helper.py should not be new [15:24] ralsina, "until all ops are done, say there is one file left to sync" <- this is butt ugly, but I think it could work out. [15:24] it already existed [15:24] alecu__: or spread them. [15:24] nessita: no, it never existed [15:24] cheezaz fck. yield is a PITA. [15:24] alecu__: suppose you have 3 files and 10 non-upload ops, then count one file every 4.3 ops or so :-) [15:25] verterok: any hints on blocking the deferred in Java like yield does in Python? [15:25] ralsina, right :-) [15:25] mandel: you moved one file from one place to another. That have to be done with bzr move, to move the history as well. [15:25] verterok: the run method of ActionQueueCommand is pretty fck twisted :< [15:25] mandel: all this time arguing is enough to do the fix ;-) [15:25] nessita: i added a new file, and modified a second one, look at trunk [15:26] nessita: that is what the diff says, i added a new one, and modified a second one, if i do a bzr move, from platfrom to linux, what happens with the platfrom code i want to keep [15:26] karni: no, that's a python specific stuff [15:26] mandel: maybe I misunderstood. What file you added as new? [15:26] verterok: uh :< [15:27] nessita: the new is the linux one, but verterok wrote it [15:27] karni: it's juts syntactic sugar [15:27] mandel: where was that file located before your branch? [15:27] mandel: if you didn't create it, is existed. So you moved it from somewhere, right? [15:27] who has REAL unity working? Alecu? [15:28] verterok: that's true. I'm thinking how to reorganize -- the python code calls 'continue;' of a while loop, which using the Deferred.callbacks can't be ported 1:1 just like that. [15:28] verterok: thanks, I'll handle it :) [15:28] wtf! internet! [15:28] karni: are you writing syncdaemon in java? [15:28] alecu__: do you still have unity-3d? [15:28] verterok: yes I am. does that sound crazy? [15:29] karni: depends :) [15:29] verterok: I'm quite far actually [15:29] ralsina, I do. But it keeps crashing on startup. [15:29] nessita: the linux tests never existed, i modified the platfrom ones to be more generic, and added the linux tests based on code written by verterok, the diff states clearly, modified in platfrom, added in linux. if you go to trunk, you will see , no file in linux, therefore is new, and present in platfrom [15:29] Do you think you could take a screenshot? [15:30] alecu_: oh, on startup. I guess not :-( [15:30] verterok: certainly I can't do 100% work of 4+ programmers, but I like the logic of things you guys implemented. [15:30] ralsina, so I have a launcher on the desktop to start up gnome-panel and metacity. [15:30] ralsina, what kind of screenshot do you need? [15:30] nessita: the platfrom code needed to be changed, the linux one had to be added and there is not bzr cp [15:30] "a screenshot of the control panel showing off the tab for selecting folders to sync" for joshuahoover [15:30] mandel: so you copied a filed into linux dir? and now we have 2 pretty much the same files in 2 directories? [15:30] alecu_: on unity to make it all pretty [15:30] nessita: yes, we have [15:30] ralsina, I'll try starting it all up under xephyr [15:30] ralsina: did the tests work? [15:31] mandel: yes! [15:31] mandel: what for? let's avoid duplication! [15:31] karni: :) [15:31] verterok: it's pretty crazy anyway ;D [15:31] nessita: your branch failed make test [15:31] "xoo - graphical wrapper around Xnest/Xephyr" [15:32] mandel: what is tests/platform/linux/test_os_helper.py testing than tests/platform/test_os_helper.py is not testing? [15:32] dobey: checking [15:32] nessita: because they are similar yet not the same, because the assertions test different things and the platfrom one are there simply to ensure that both implementations are following the same interface [15:32] nessita: let me get and example [15:33] mandel: so, linux spoecific tests should inherit from general tests and customize the specific bits [15:33] mandel: we should not duplicate the whole file [15:35] bah, xoo is ugly. [15:38] nessita: they cannot inherit, on window the handle has to be managed in a different way because you cannot rename/remove a file used by a process while you can on linux. If you do not take care of that you will have failing tests on windows, yet not on linux. The linux tests assert that a unix behaviour is done, iheritance will not work, i;ll have to use composition, create a class tha later is accessed by the two diff tests to be able to t [15:40] mandel: and why you did do that? :-D [15:41] dobey: I forgot a push from yesterday! pushing now [15:41] ok [15:42] nessita: why i did the extra test, ot why i did not do that? [15:42] nessita: i did not understand the question [15:42] mandel: why you didn't do the composite stuff. My main concern is: [15:42] alecu_, https://bugs.launchpad.net/ubuntuone-client/+bug/715842 [15:42] Launchpad bug 715842 in ubuntuone-client "Percentage in notification is a bit off: Uploaded 52/52 field, 95% completed (affects: 1) (heat: 6)" [Medium,Confirmed] [15:42] ralsina: so i do not get the +1 in the last branch you tested? [15:42] rye, thanks! [15:43] mandel: gack [15:43] mandel: give me 1' [15:43] mandel: let's suppose we find a problem with how we're handling something on os_helper. We want to add a test for that, in order to solve. We will have to edit 3 files to do so? [15:43] field [15:43] ? [15:43] rye, that bit is really interesting: "This happens because sd is still "processing" stock Move()s but all uploads and downlads are complete." [15:43] ralsina, nessita ^^^ [15:43] nessita: i did not do it because I'm just one on this with a tight schedule and I have to prioritice my efforts [15:44] nessita: in which platform did it fail? [15:44] nessita, would it be fine if we showed "all done" but some moves were still pending? [15:44] nessita, what would happen if the user closes the laptop in that case? [15:44] alecu_: from my POV, nopes. I think we need to show all done only when SD is IDLE [15:44] alecu_, facundobatista said there's a bug there [15:44] nessita: if it was in all, then in platform, if it was on windows, then on windows, if it was on mac os, the … and so on [15:44] alecu_: anyways, you can have all your uploads done but you can have pending downloads, right? [15:45] mandel: if it was in all, we need to edit only one file? [15:45] that will cover all two? [15:45] nessita, right. But downloads and uploads are handled right now (as different lines in the bubble) [15:45] nessita, it's those Moves (and other operations) that may be pending. [15:45] alecu_: right, but I mean that a user can have 10/10 uploads done and be 55% completed [15:45] nessita: yes, the platfrom one, that is why is there [15:46] platfrom is ran i all platfroms [15:46]