/srv/irclogs.ubuntu.com/2011/02/11/#launchpad-dev.txt

=== Ursinha is now known as Ursinha-afk
lifelesssinzui: I think you should just self-review https://code.launchpad.net/~sinzui/launchpad/bad-malone-0/+merge/4932500:28
huwshimiAny ideas where the package input widget being referred to in this comment is? https://bugs.launchpad.net/launchpad/+bug/591274/comments/100:28
_mup_Bug #591274: tags field is too small <lp-bugs> <trivial> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/591274 >00:28
wgranthuwshimi: On an Ubuntu bug page, click the drop down arrow on the left of a row on the task table.00:29
wgranteg. https://bugs.launchpad.net/ubuntu/+source/wxmaxima/+bug/4315000:29
_mup_Bug #43150: [SRU] maxima frontends fail to connect <wxmaxima (Ubuntu):Fix Released> <gcl (Ubuntu Dapper):Fix Released by wgrant> <maxima (Ubuntu Dapper):Fix Released> < https://launchpad.net/bugs/43150 >00:29
huwshimiwgrant: Cheers mate00:30
wgrantI wish the death-to-ZConfig policy had been seen through to completion.00:31
thumperlifeless: ping00:46
thumpermwhudson: ping00:48
lifelessthumper: hi00:49
thumperlifeless: I've got windmill hung here locally, and I want to debug where it is with gd b00:49
thumperlifeless: can you help?00:49
lifelesssure00:49
lifelessfirst thing to try is strace00:49
lifelessit can often be surprisingly informative00:49
thumperlifeless: assume I'm a dumb code monkey00:50
thumperstrace how?00:50
lifelessok00:50
lifelessfirst thing is ps :)00:50
lifelessfind out what processes you have00:50
lifelessidentify the ones we care about:00:50
lifeless - the python driver00:50
thumperlooking for the one running the windmill test00:51
lifeless - the ff slave00:51
thumpertim      18086  1943  4 13:43 pts/1    00:00:19 /usr/bin/python2.6 -S ./bin/test --layer=Windmill -vvt TestRecipeSetDaily00:52
thumperthat should be the driver00:52
lifelessthat tells it the layer to continue from00:52
lifelessit might be a child of this00:52
lifelesspstree will show00:52
thumpercan I get pstree to show me pids00:53
thumper?00:53
lifelesspstree --show-pids00:53
thumperor -p00:53
lifelessso if this has not spawned another bin/test runner00:55
lifelessthen yes, its the one that is hung00:55
lifelesswhat version of gdb do you have installed ?00:55
thumper7.2-ubuntu00:58
lifelessapt-get install python2.6-dbg00:59
thumperalready got it00:59
lifelessgdb /usr/bin/python2.6 1808601:00
lifelessthread apply all py-list01:00
lifelessand threat apply all py-bt01:01
thumperCould not attach to process.  If your uid matches the uid of the target01:01
thumperprocess, check the setting of /proc/sys/kernel/yama/ptrace_scope, or try01:01
thumperagain as the root user.  For more details, see /etc/sysctl.d/10-ptrace.conf01:01
thumperptrace: Operation not permitted.01:01
thumperbut the uid matches01:01
lifelesscat /proc/sys/kernel/yama/ptrace_scope01:01
thumper101:02
wgrantthumper: >= Maverick have security settings to prevent processes from ptraceing each other.01:02
wgrantsudo it.01:02
thumperack01:02
lifelessor push 0 into /proc/sys/kernel/yama/ptrace_scope01:02
thumperlifeless: ok, I've got gdb running and did the thread apply thingies01:03
lifelesspastebin01:03
thumperhttps://pastebin.canonical.com/43168/01:04
lifelessmight be slightly useful to get a thread apply all bt01:06
lifelessmight be slightly useful to get a thread apply all list01:06
lifelessbecause we're getting the usual noise around python traces :(01:06
wgrantsinzui: Still around?01:07
thumperhttps://pastebin.canonical.com/43169/01:09
lifelessthumper: ok, so the higher frames are new01:09
lifelessopposite to pdb01:09
lifelessthread one is trying to read from a socket01:10
thumperok, so how do you look for value in this?01:10
lifelessthread x to switch to a thread01:11
lifelessframe x to go to a frame01:12
lifelesspy-locals for the python locals01:12
lifelessinfo locals for the C locals01:12
lifelessthread 2 is doing a 0.25 second sleep.01:13
lifelesswhich is zomg bad programming01:13
cody-somervillelol, yea I was just looking at that.01:13
lifelessthats in _wsgi_jsorpc01:13
lifelesswindmill runs up a server of its own for ff to talk to01:13
lifelessthread 3 is doing nonblocking IO01:15
lifelessinside a socketserver01:15
lifelesswhich is a little odd.01:15
lifelessat best01:15
lifelessnot entirely sure what its about01:16
lifelessbut01:16
lifelessperhaps its trying to read the entire request01:16
lifelessand stuck getting it01:16
lifelesswe should get the sockets it has open01:16
lifelessthread 4 looks like its the smtp server test harness thingy01:17
lifelessso threads 2 and 3 are candidates for the hang01:18
thumperI don't suppose we can break a pdb into it?01:19
thumperI'd like to be able to inspect the python itself01:19
mwhudsonthumper: pong01:20
thumpermwhudson: I've got lifeless "helping" me with gdb01:20
lifelessyou can tell the process to evaluate some python code01:20
lifelessbut its a little hacky01:20
thumperalthough I don't feel like I understand much how gdb works01:20
thumpernever been much for command line debugging01:21
mwhudsonthumper: https://code.launchpad.net/~pygdb-hackers/pygdb/trunk ?01:21
thumpermwhudson: what does that give me?01:22
mwhudsonthumper: a back trace01:22
lifelessmwhudson: have those ;)01:22
lifelessmwhudson: live session01:22
thumperI may have that already01:22
lifelesshttps://pastebin.canonical.com/43168/01:22
lifelesshttps://pastebin.canonical.com/43169/01:22
mwhudsonoh yeah, gdb gives you the python code these days01:23
mwhudson(unreadably)01:23
cody-somervillelifeless, Why isn't thread 1 a candidate for the hang? recv is blocking, isn't it?01:24
mwhudsonthumper: what is fd 20 for this process?01:29
mwhudson(lsof -p $windmill_pid i think)01:29
thumperlocalhost.localdomain:53395->localhost.localdomain:4444 (ESTABLISHED)01:30
mwhudsonnetstat -tp and look for those ports?01:32
cody-somerville4444 is the http server01:32
mwhudsonis it talking to itself, i wonder01:32
cody-somerville53395... looks like thats from Thread 201:32
thumpertcp        0      0 localhost.localdo:53395 localhost.localdom:4444 ESTABLISHED 18086/test --layer=01:33
thumperand there is one with the other order too01:33
cody-somervilleugh... no line wrap makes navigating this output disorientating, lol01:33
mwhudsonah yeah indeed01:34
mwhudsonso thread 2 is serving http, thread 1 is trying to read part of the headers from thread 2 and not getting anything?01:34
mwhudsonpotentially01:34
thumperok, I'm going to kill everything and get some more work done now01:35
cody-somervilleawwww01:35
* cody-somerville is having fun. :-(01:36
cody-somervilleand I think we're close to debugging it01:36
thumpercody-somerville: well, it isn't gone yet01:37
thumpercody-somerville: if you want more fun01:37
maxbWould someone be able to point me in the direction of the code which determines whether or not a recipe daily build is needed on a given day?01:38
cody-somervillemwhudson, I think thread 3 is serving and thread 2 is either the request or the request handler01:38
cody-somervillethumper, did you ever manage to get a strace?01:38
LPCIBotYippie, build fixed!01:38
LPCIBotProject devel build (433): FIXED in 5 hr 40 min: https://hudson.wedontsleep.org/job/devel/433/01:38
mwhudsoncody-somerville: oh right yes01:39
mwhudsonprobably right there01:39
thumperOperation not permitted01:39
cody-somervillethumper, sudo su and then try01:39
thumpersudo strace doesn't work, do I need a root shell?01:40
wgrantthumper: sudo strace does work :(01:40
thumpergetting the same as root01:40
cody-somervillethats odd. you're on maverick?01:40
thumperyep01:40
cody-somervillesudo strace -p <pid> works fine for me01:41
wgrantMe too.01:41
wgrantOn maverick and natty.01:41
wgrantHmmm.01:41
wgrantSurely not.01:41
thumpercould it be that gdb is connected?01:41
wgrantCould it be because launchpadlib loads keyring loads gnome-keyring which might forbid ptraceing?01:41
wgrantNo.01:44
wgrantIt could be that gdb is connected, I suppose.01:44
wgrantAn odd errno for that, though.01:44
mwhudsononly one process can ptrace a process at a time, i think01:45
mwhudsonso yeah, having gdb attached would break it01:45
thumperso... most likely a race condition in windmill01:46
mwhudsonman ptrace says it returns EPERM in this case01:46
thumpernothing I'm likely to fix today01:46
wgrantmwhudson: That's a bit opaque.01:46
wgrantI would have expected EBUSY.01:47
mwhudsonwgrant: i guess ptrace comes with a big "we hope you know what you are doing" sticker01:47
wgrantOr something like that.01:47
thumperdetached gdb, strace said: recvfrom(20, ^C <unfinished ...>01:47
mwhudsoni don't know how threads and ptrace interact01:47
cody-somervilleIf a system call is being executed and meanwhile another one is being called from a different  thread/process  then01:48
cody-somerville       strace will try to preserve the order of those events and mark the ongoing call as being unfinished.  When the call01:48
cody-somerville       returns it will be marked as resumed.01:48
mwhudsonah yes01:48
mwhudsonso if there's no output, then it really is totally hung01:48
cody-somervilleor aren't making any syscalls at least ;)01:49
mwhudsonyeah, but all threads in the gdb trace were in syscalls, no?01:50
mwhudsonand if it's talking to itself and one thread is calling recv and nothing is calling write... it could be waiting a while01:51
* mwhudson wonders how easy it is to write a website that accesses the launchpad api over js01:54
thumperhttps://code.launchpad.net/~thumper/launchpad/daily-ajax/+merge/49295 anyone?01:54
cody-somervilleThread 1 is the first thread and is blocked waiting for data - it looks like its waiting for the response to a json-rpc call it made01:55
cody-somervillelooks like its the.... dragDropElemToAbs test its hung onn?01:56
cody-somervilleoh wait01:56
cody-somervillemaybe thats the action its asking to have performed or something01:56
cody-somervilleso, its actually the test_inline_recipe_daily_build test that its hung on01:57
cody-somervillewhich happens to be the test thumper is adding in his MP, lol01:59
lifelesscody-somerville: thread 1 is the thing making an http request02:12
lifelesscody-somerville: its trying to read the response02:12
lifelessanother way of thinking about this is 'blocking w/o timeout is bad'02:12
* cody-somerville nods.02:13
cody-somervilleah02:19
cody-somerville        while not resolution_suite.resolved.get(uuid):02:23
cody-somerville            sleep(.25)02:23
cody-somerville^^ that doesn't look so great.02:23
lifelesscody-somerville: so thread 1 might be the cause of the hang02:26
lifelesswe should make that call have a timeout02:26
lifelesswhich wouldn't fix the test02:26
lifelessbut it would stop a complete hang02:26
huwshimiPeople who review things: if I want to fix several (fairly minor) bugs relating to a particular thing in launchpad but are unrelated themselves, is it better for you if I use different branches?02:34
sinzuihuwshimi: I think the answer is really about the cover letter and the diff02:35
wgrantIt's common to stick a few small changes in one branch.02:36
wgrantBut if they're intertwined I prefer to split them.02:36
sinzuihuwshimi: we often want one branch per change so that both are clear. Several small changes can be in a branch and have a clear diff02:36
wgrantsinzui: Three years ago you added althostnames of 'launchpad' and 'www.launchpad.net' to most non-appserver configs. Do you recall why? Is there a good reason not to just inherit launchpad.net from the global lpnet config?02:38
wgrantEr.02:38
wgrants/'launchpad'/'localhost'/02:38
sinzuihi wgrant. Sorry was was away. I did not mean to be, My daughter killed pulseaudio I could not hear02:38
wgrantHaha.02:38
lifelesshi02:38
lifelessspeaking of hostname02:39
lifelessAFAICT the machine hostname isn't needed in launchpad.conf02:39
lifelessam I wrong?02:39
wgrantNot even for nagios checks?02:39
wgrantThat's my presumption for why they are there.02:39
sinzuiwgrant: I really do not recall why I did that. I cannot think of a reason why www in in there02:39
wgrant(the production configs pissed me off for the last time this morning, so I am purging cruft... I will gladly remove the althostnames from the appservers as well as non-appservers)02:40
cody-somervillelifeless, it sort of looks like it already does02:40
cody-somervillelifeless, would thread 2 stuck in a loop prevent the timeout from occurring in thread 1?02:41
wgrantsinzui: Non-appservers need *a* hostname. But they get that from lpnet-lazr. It seems pointless to have the others (perhaps they were automatically added?)02:41
lifelesscody-somerville: rarely, it *is* possible though to have a thread spinlock prevent other threads executing in python02:41
lifelesswgrant: sysadmins don't know why they are there02:42
lifelesswgrant: nagios can be told what hostname to use, i'm pretty sure02:42
wgrantlifeless: Probably.02:42
wgrantWe should check the nagios config and try cowboying it out on one server, perhaps.02:42
sinzuiwgrant: that is certainly possible. The configs were partially built (and separated) by scripts I wrote02:42
wgrantsinzui: That's what I gathered from the somewhat massive and partially insane diff.02:42
sinzuiutilities/lsconf is all that renames of those scripts02:43
sinzuiremains02:43
wgrantHrrngh.02:47
wgrant(that's a "why do the production configs inherit production-specific domains from the config schema?" sort of hrrngh, FWIW)02:48
cody-somervilleit looks like thread 2 has added something to a queue to be executed and is now waiting for it be executed... but whats processing that queue?02:48
* cody-somerville realizes that its now almost 10 and so puts the windmill hang problem away for another day.02:52
lifelessdie ec2, die in a fire03:21
wgrantWho has it killed this time?03:21
lifelessno freaking way did I hit ctrl-C after 5 hours of tests03:21
wgrantlifeless: You saw a KeyboardInterrupt around a windmill test?03:22
lifelessmailed the output to you03:25
lifelessI saw no other tests and this was a tobesuretobesure so I'm just landing directly now.03:25
lifelessplease don't hate me when this turns out to be a bad idea03:25
wgrantRight.03:25
wgrantI just land directly in that case.03:25
wgrantWindmill tests hang in a subprocess, root process notices lack of activity, root process sigints child.03:26
* thumper looks up03:28
thumperAARRGGHHHHH!!!!!!03:34
thumper:((03:38
thumperthe lazr.restful 0.16 egg isn't 0.1603:42
* thumper is confused03:42
thumperclucking bell03:42
* thumper looks for someone to smack around03:43
pooliethumper, yeah, this was my thing with oauth too: 1.0 != 1.003:43
thumperit seems that the 0.16 tarball was created from a branch of lazr.restful that wasn't trunk03:44
thumperis there any way to introspect the egg to see what it was created with?03:44
thumperok... so how do I make these egg things03:46
thumpersdist?03:46
wgrantsdist for most things.03:46
wgrantExcept bzr.03:46
wgrantAnd meliae.03:47
wgrantAnd some other stuff.03:47
wgrantTry sdist. Then diff it with the old one.03:47
thumperwgrant: it will create a different result, I know that03:48
thumperwgrant: as it is missing at least two revisions of data03:48
thumperwgrant: is there a way to add a suffix?03:48
wgrantthumper: I extract the two and diff the trees to make sure they have the same files.03:48
wgrantthumper: Hmmm.03:48
thumperwgrant: they won't have the same files03:48
thumperthat is the problem I'm trying to fix03:48
thumpertrunk has r171 tagged with 0.16.003:48
wgrantI mean more that the tree is roughly the right shape.03:48
thumperwhich isn't the revision that made the 0.16.0 egg in our download cache03:49
thumperoh03:49
wgrantIs it the revision on https://launchpad.net/lazr.restful/+download?03:49
lifelesssinzui: ping03:51
lifelesssinzui: or are you gone?03:51
thumperwgrant: I don't suppose there is an MD5 hash of it somwhere03:54
thumperduh03:54
thumperI see it03:54
thumper:(03:55
thumperlp has: 925128c13ada9e7cbb50ae86538c6812 lazr.restful-0.16.0.tar.gz03:56
thumperdownload cache has: 9469c4b0081ab0bd8796dc52ee1c2353 lazr.restful-0.16.0.tar.gz03:56
thumperand my new one is: 7daed9cea664e564386381da320b3519 lazr.restful-0.16.0.tar.gz03:56
wgrantAwesome.03:56
wgrantDiff the trees.03:56
* thumper sighs...03:56
wgrantHopefully the first and last are identical, and you can wipe your new tarball from existence.03:56
lifeless3 tars... fark03:57
wgrantWhatever you do, do not let a third file with that name leave your system :)03:58
wgrantOr people from Ubuntu will hunt you down.03:58
thumperok, my one from trunk matches the launchpad one04:00
thumperso at least that is good04:01
thumperthe download cache one is wrong04:01
thumperso...04:02
* thumper updates download-cache04:02
thumperok, so I've update the download cache to have the correct lazr.restful04:06
thumperlifeless: do you know how that'll impact rolling out?04:06
wgrantDid you give it the same name?04:07
thumperit is the correct 0.1604:08
wgrantYes.04:08
wgrantDon't do that.04:08
thumperso yes04:08
wgrantIt confuses things.04:08
wgrantUncommit, give it a new version number, recommit.04:08
wgrant(dev systems won't ever see the changes in the new, because they have already built 0.16.0)04:08
thumper:(04:08
* thumper uncommits04:09
wgrantJust like Debian archives: do not ever use the same version twice, and if you see someone lying about version numbers, slap them.04:09
thumperdo the tarball names need to match the folders on the inside?04:09
wgrantNo.04:09
thumperok04:09
wgrantYou probably need to change the version number in setup.py.04:10
lifelessthumper: it won't impact anything right now04:10
lifelessbecause we've already cut the tree to deploy.04:10
lifelessbut it will impact the nodowntime.04:10
wgrantI think nodowntime will see the new tarball.04:10
wgrantas will qastaging and staging.04:10
wgrantBut dev/ec2/buildbot won't.04:11
* thumper nods04:11
thumperI've fixed the download04:12
wgrantHopefully nobody saw the bad rev except me.04:12
thumperlifeless: if you want to review my daily-ajax, I'll fix the versions.conf in that04:12
mwhudsoni wonder if we can set a hook on the download-cache branch to reject commits that change an existing file04:15
thumperGetting distribution for 'lazr.restful==0.16.0-r171'.04:16
thumperInstalling lazr.restful 0.16.0-r17104:16
thumperCaused installation of a distribution:04:16
thumperlazr.restful 0.16.004:16
thumperwith a different version.04:16
thumperGot None.04:16
thumperwith make build04:16
wgrantthumper: Did you change setup.py?04:16
thumperarse04:16
thumperno... you didn't say to!04:17
wgrant15:10:19 < wgrant> You probably need to change the version number in setup.py.04:17
thumper:(04:17
mwhudsoner04:17
mwhudsonversions.cfg surely04:17
mwhudsonnot setup.py04:17
wgrantThe tarball is called 0.16.0-r171, but internally versioned 0.16.004:17
thumperI changed versions.cfg, but it seems that it is expecting a differnt directory on the inside04:17
thumperyes04:17
mwhudsonoh04:17
* thumper uncommits again04:18
* thumper read the scrollback for deryck's magic incantation04:22
thumperpython setup.py egg_info -b-r171 sdist FTW!04:22
thumperhmm...04:24
thumperperhaps I'll just submit the right lazr-restful branch directly04:24
thumperas in, with a self review04:24
wgrantSounds reasonable.04:25
* thumper is doing so right now04:25
wgrantlifeless: Can you see any reason not to drop the hostname-based althostnames?04:28
wgrantnagios doesn't use them.04:29
wgrantNormal requests don't.04:29
wgrantI guess haproxy might?04:29
thumperwgrant: want to review a branch of mine?04:29
wgrantthumper: Sure.04:29
thumperhttps://code.launchpad.net/~thumper/launchpad/daily-ajax/+merge/4929504:30
wgrantaaaaaaa04:30
wgrantBut OK.04:30
thumperwgrant: whazzup?04:31
wgrantthumper: JS!04:31
thumper:)04:31
thumperthere isn't that much actual JS04:31
* thumper is EODing, but will be back later04:33
lifelesswgrant: we'll stage a test in a bit04:48
lifelesswgrant: I'll remove them using make-appserver.py04:48
wgrantlifeless: They also need to be removed from the non-appserver configs.04:53
lifelesssure04:54
huwshimiDoes anyone know what I'm supposed to do when making changes to lazr-js stuff for launchpad? Do I need to make a branch of lazr-js directly and wait for the changes to be merged back into LP?04:59
wgrantthumper did that recently.05:00
wgrantBut yes, fix lazr-js, then upgrade or get someone to upgrade the Launchpad version of it.05:00
huwshimiwgrant: ok thanks.05:01
lifelesspoolie: its pretty consistently 50/5005:08
lifelesspoolie: its achieving that at the overcommit level - 4 threads, 4 backlogged requests05:08
huwshimiCouple of reviews for someone who is kind enough to do them: https://code.launchpad.net/~huwshimi/launchpad/tag-field-length-591274/+merge/49341 and https://code.launchpad.net/~huwshimi/launchpad/tag-field-space-394342/+merge/4934205:09
poolienice05:10
poolielifeless, good to see we're not wasting mark's money having hardware sit around idle ;-)05:10
pooliehuwshimi, can has screenshots?05:11
huwshimipoolie: Of both?05:11
poolieyeah05:11
huwshimipoolie: coming up05:11
pooliei have this not-well-substantiated theory that attaching screenshots will be a cheap way to get better ui oversight05:11
poolie(or more bikeshedding :-)05:12
huwshimipoolie: Well the tag field length one is not really going to show much :)05:12
huwshimipoolie: Also fixed bug #580404 but need to figure out how to get that review in lazr-js first.05:12
_mup_Bug #580404: pressing enter in tags field doesn't save them <ajax> <javascript> <lp-bugs> <Launchpad itself:Triaged> < https://launchpad.net/bugs/580404 >05:12
pooliesorry05:13
lifelesspoolie: https://lpstats.canonical.com/graphs/SoybeanCPU/ https://lpstats.canonical.com/graphs/WampeeCPU/ https://lpstats.canonical.com/graphs/PalladiumCPU/ https://lpstats.canonical.com/graphs/PotassiumCPU/ https://lpstats.canonical.com/graphs/GandwanaCPU/05:13
pooliei thought that was a different bug05:13
pooliethe length will but the stray space won't, right?05:13
huwshimipoolie: Yes it's a different bug... I was mostly telling you cause you reported it.05:14
poolieoh, 580404 is my bug!05:14
pooliethanks, that always annoys me05:15
poolieand one other person apparently05:15
lifelesspoolie: ^ the two that are idle will be getting 'fixed' soon.05:15
poolietwo idle cores?05:16
lifeless4 per box05:16
lifelessthey are 8 core machines05:16
lifelessnot enough memory on one atm05:16
lifelessthe other we have the memory, haven't had cycles to do the reconfig05:16
pooliehuwshimi, so what i should have said is that i think a screenshot on https://code.launchpad.net/~huwshimi/launchpad/tag-field-length-591274/+merge/49341 would exemplify a good practice05:16
poolieeven if it is probably pretty obvious how it would turn out05:17
huwshimipoolie: I can't attach an image directly can I?05:17
huwshimipoolie: Or am I missing something05:17
poolieunfortunately you need to attach it to the bug05:18
huwshimipoolie: Ok05:18
huwshimipoolie: https://bugs.launchpad.net/launchpad/+bug/591274/comments/205:21
_mup_Bug #591274: tags field is too small <lp-bugs> <trivial> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/591274 >05:21
pooliesorry, this is probably the worst ui change to ask for this on since it's so simple05:21
huwshimipoolie: Nah all good.05:22
pooliethat misaligned help button looks a bit naff05:22
wgrantRIP facets.05:23
poolienot your fault though05:23
huwshimipoolie: I know. I need to think about a plan for how fix our sprite generator so that it doesn't make everything look so ugly05:23
huwshimipoolie: The screenshots are probably a good idea so the reviewer can make sure they get the same thing as the commiter05:24
huwshimiwgrant: Did you just pull my changes or something?05:25
wgranthuwshimi: I saw the commit fly past.05:25
huwshimiwgrant: Ah right05:25
pooliehuwshimi, unofficial +1s from me05:27
pooliewith tweaks on the space thing05:27
huwshimipoolie: Oh right05:29
* huwshimi facepalms05:29
huwshimipoolie: Fixed if you want to take another look05:37
pooliei forget, semicolons before } are optional in js, aren't they?05:39
poolie+1 now05:39
pooliebut i'm not an official reviewer05:39
huwshimipoolie: semicolons are completely optional in js. In that case I just forgot to add it.05:40
poolieso optional in the syntax but required by convention?05:52
pooliei guess you can treat this as an optionally reviewed patch05:54
huwshimipoolie: Yeah, few people code javascript without semicolons.05:57
huwshimipoolie: I'm not sure I follow about the optional review05:58
pooliei can't give you an official approval but if you wanted you could treat this as being optionally reviewed and land it anyhow06:00
poolieup to you; it depends how confident you are06:00
poolieor maybe wgrant's still here06:00
wgrantI am still here. But I am but a code*.06:02
wgrantWhich MP?06:02
wgranttag-field-length-591274?06:02
lifelesswgrant isn't a full reviewer yet either, but if he reviews, I'll mentor06:03
poolieand https://code.launchpad.net/~huwshimi/launchpad/tag-field-space-394342/+merge/4934206:03
poolieyou could mentor me too, if you don't mind06:03
* wgrant does them.06:03
wgrantlifeless: Could you also mentor https://code.launchpad.net/~thumper/launchpad/daily-ajax/+merge/49295?06:03
lifelesssure, I'll cook dinner first06:03
=== almaisan-away is now known as al-maisan
lifelesspoolie: you should let bac know you want to be a reviewer; I'm happy to be your mentor06:04
huwshimiDoes anyone know who can review lazr-js stuff?06:04
wgrantI think it's the normal LP reviewers.06:05
huwshimiwgrant: Ah right thanks.06:05
huwshimiCan someone review this then: https://code.launchpad.net/~huwshimi/lazr-js/autocomplete-enter-580404/+merge/4935106:05
lifelesshuwshimi: everything listed on https://launchpad.net/launchpad-project/ is reviewable by LP reviewers.06:05
huwshimiMany thanks06:05
lifelesshuwshimi: some have additional reviewers on top of that06:05
huwshimilifeless: Ah right.06:06
wgranthuwshimi: Both reviewed.06:09
huwshimiwgrant: Cheers mate, thanks a lot06:09
huwshimiwgrant: Are you changing the status or should I do that?06:10
wgranthuwshimi: lifeless needs to mentor my review first.06:11
huwshimiwgrant: ok right06:11
wgrant2x ui* == ui, but 2x code* < code06:12
=== al-maisan is now known as almaisan-away
lifelessstub: btw06:16
lifelessstub: you might find bug 716760 an interesting one for your when-coding time06:17
_mup_Bug #716760: no measurement of in-datacentre queue timings <Launchpad itself:Triaged> < https://launchpad.net/bugs/716760 >06:17
pooliehuwshimi, i don't totally understand your fix to bug 580404 yet06:24
_mup_Bug #580404: pressing enter in tags field doesn't save them <ajax> <javascript> <lp-bugs> <Launchpad itself:Triaged> < https://launchpad.net/bugs/580404 >06:24
huwshimipoolie: So the change is that instead of checking that there is a query (i.e. someone has typed in a string) we check if there are results for the string (which includes a check for the string) otherwise the autocomplete will always capture the enter event even when we're typing in a tag that doesn't exist.06:28
huwshimipoolie: Does that shed any light or am I just confusing things?06:29
huwshimipoolie: Oh and another spelling mistake :(06:29
pooliethat makes sense06:29
huwshimipoolie: My comment in the code was slightly wrong as well as the grammar mistakes (of which there were few)06:32
huwshimipoolie: Just pushed those changes06:33
huwshimiOK, heading off. Have a good one people.06:38
pooliecheerio huw06:39
lifelessspm: could you please set qastaging cron.hourly to run, well, every hour ?06:39
spmcrazy talk06:40
lifelessI know we've load issues06:40
lifelessbut we have a db patch in the pipeline that needs db migration completed06:40
lifelessotherwise Bad Things will happen06:40
lifeless(you know the one)06:41
spmbtw. what cron.hourly? cronscripts/? and where?06:42
wgrantWhich patch?06:43
lifelesswgrant: bugmessage.index06:48
lifelessspm: qastaging garbo-hourly is what I meant06:48
spmah. righto.06:48
wgrantlifeless: Oh, missed the 'qastaging' bit. Sorry.06:49
lifelessit has the migration job for bugmessage.index, and we can't do the db constraint for bugmessage.index NOT NULL until that migration is complete.06:49
lifelesswgrant: no, it is a db patch06:49
wgrantlifeless: I know. But I knew it was nowhere near prod.06:49
lifelesswgrant: the ui will tolerate (enough, given its qastaging) nulls being present.06:49
lifelesswgrant: next week we can use the column06:50
wgrantWe could, alternatively, restore qastaging from today's DB dump.06:50
wgrantWhich already has the data.06:50
lifelesswe should do that too, but there is still at least one run needed06:51
lifeless+ the patch to ensure it needs to be live06:51
wgrantRight.06:51
wgrantBut it has no chance of catching up without the restore.06:51
spmlifeless: enabled. 13 past the hour. same as prod.06:51
lifelessspm: thanks06:51
=== mthaddon changed the topic of #launchpad-dev to: Launchpad down/read-only from 09:00-10:30 UTC for a code update | https://dev.launchpad.net/ | firefighting: - | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews
poolielifeless, just so you know, i'm still getting rejection messages regarding reviews of bzr08:11
pooliebzr!08:12
lifelesspoolie: thats very unexpected08:12
=== almaisan-away is now known as al-maisan
lifelesspoolie: is loggerhead-team perhaps in one of the bzr teams?08:13
pooliesorry08:14
pooliei'm confused/tired08:14
poolieit's a different problem08:14
adeuringgood morning08:43
=== al-maisan is now known as almaisan-away
mrevellHello09:18
pooliehi mrevell09:19
=== jtv-afk is now known as jtv
=== adeuring changed the topic of #launchpad-dev to: Launchpad down/read-only from 09:00-10:30 UTC for a code update | https://dev.launchpad.net/ | firefighting: - | On call reviewer: adeuring | https://code.launchpad.net/launchpad-project/+activereviews
=== almaisan-away is now known as al-maisan
thumper:(((09:46
bigjoolswhy so sad thumper09:47
thumpermy simple branch to fix the lazr.restful version to be 0.16 proper failed a bunch of tests09:48
thumperdue to a change that I did in lazr.restful09:48
thumperto be more sensible about adding tracebacks to errors09:48
thumperI'm not going to fix it tonight09:48
thumperit can wait until Monday09:48
wgrantthumper: The update_preview_diffs MP job still uses the update_preview_diffs config for errors, not the merge_proposal_jobs config that everything else uses. Do you know of a reason for that?09:49
wgrantIt's all that uses that config now.09:49
thumperwgrant: no idea09:49
* wgrant removes the config override.09:50
lifelessthumper: you did leave the prior tarball in place right ?09:51
thumperyes09:51
bigjoolswgrant: did you look at that php-uploadprogress build with the bad dependencies that's generating 24 oopses a day?09:53
wgrantbigjools: I saw it in the OOPS reports.09:54
wgrantDidn't look at the build.09:54
bigjoolsok09:54
wgrantIt's going to be at the top tomorrow :)09:54
bigjoolsyeah09:54
bigjoolsI need to work out what caused the bad dependencies09:54
bigjoolswhether it's a dodgy package or bad sbuild09:55
bigjoolstalking of which, did you get the newer sbuild working? :)09:55
wgrantI haven't looked at that lately. The lp-buildd branch is on LP, but the (fairly tiny) sbuild changes are not.10:01
=== mthaddon changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: adeuring | https://code.launchpad.net/launchpad-project/+activereviews
lifelesspoolie: do you get the render times too ?10:28
Ursinhamorning10:37
jtvhi wgrant!10:47
wgrantHi jtv.10:47
wgrantYour change looks good.10:47
wgrantI tried it on a couple of pockets on mawson.10:47
wgrantBut gave up waiting for it to finish on the release pocket.10:47
jtvwgrant: thanks!  Sorry to trouble you—someone thought that archive publication was something to take extra care with, pah10:47
wgrantI've already broken it once this evening :)10:48
jtvAhem. :)10:48
jtvJulian tried it too, thought it felt quicker, but wasn't sure whether all binary files were published.10:48
wgrantIt only affects the dists tree, and that looked identical except timestamps.10:49
wgrantWe might want to try it over some larger pockets just in case.10:49
wgrantBut that takes forever, and I needed mawson for other things.10:49
jtvThen I'm marking it as qa-ok.10:50
bigjoolswgrant: I pocket copied stuff from release to proposed and it published everything ok10:50
bigjools4 arches10:50
wgrantbigjools: Great.10:51
wgrantI published lucid-updates and diffed the dists tree.10:51
wgrantAll fine.10:51
bigjoolsbut a second pair of eyes is never wasteD on the publisher10:51
bigjoolsnice10:51
jtvLet's hope the other optimization comes through as nicely.10:52
=== al-maisan is now known as almaisan-away
=== jtv is now known as jtv-eat
poolielifeless, i do get them11:18
gmbIs anyone else having trouble pulling branches from LP?11:19
gmblosa ping11:19
henningegmb: yes, and pushing does not work at all for me atm.11:20
wgrantgmb: We're just reverting the codehosting change.11:20
wgrantShould be back in just a moment.11:20
gmbwgrant: Ah, okay, cool.11:20
gmbThanks.11:20
henningethanks11:20
=== matsubara-afk is now known as matsubara
bigjoolsadeuring: can I poke this in your direction please: https://code.launchpad.net/~julian-edwards/launchpad/builder-history-timeout-bug-631206/+merge/4937411:37
adeuringbigjools: sure, I'll look11:39
bigjoolsthank you11:39
adeuringbigjools: the branch looks good, I think, just a minor remark: you need inner_privacy_query only for non-admin users, i.e., in the "else" parts of the "if user is None: ... elif is user_is_admin: ... else: ...". What about moving the definition of inner_privacy_query into this "else:" block?12:02
bigjoolsadeuring: I put it there to get more width on the screen as it's less indented :)12:03
adeuringbigjools: ah, right, makes sense for this monster ;)12:03
bigjoolsindeed12:03
bigjoolsalthough it would only affect one line12:04
=== jtv-eat is now known as jtv
bigjoolsstorm syntax is ....12:04
bigjoolsthanks for looking at it adeuring12:04
henningeHi jtv!12:04
jtvhi henninge!  Saw your email about the bug.12:04
jtvI'm about to start on the XPI problem.12:05
henningeAh yes, thanks for the comment.12:05
adeuringbigjools: and one question, more out of curiosity: There is no privacy check if packagebuild.id is None. What does this mean?12:05
henningejtv: can you re-review my branch first, please?12:05
jtvoh, OK12:05
bigjoolsadeuring: only package builds are private12:05
henningehttps://code.launchpad.net/~henninge/launchpad/devel-710591-importer/+merge/4868212:05
bigjoolss/are/can be/12:05
adeuringbigjools: Ah, ok, thanks.12:06
adeuringr=me12:06
henningejtv: I am not sure if I should re-submit it. I have added quite a few changes.12:06
bigjoolscheers12:06
jtvhenninge: I'm surprised :)12:06
henningejtv: Let me add a comment to explain the changes.12:06
jtvThanks, that'd help.12:06
bigjoolsadeuring: can you mark the MP reviewed please12:10
adeuringbigjools: sure, sorry...12:10
jtvhenninge, an unfortunate complication: when you steal a flag, you also need to set a flush order.12:10
henningejtv: you mean, whenever I change flags?12:11
jtvhenninge: only when you clear one TM's flag in order to set the same flag on another.12:11
henningejtv: yes, what I meant. ;-)12:12
jtvhenninge: this should have been a separate branch and a separate MP… you're adding a whole new script!12:16
henningejtv: yes, it was its own branch at first.12:16
henningeright now I cannot really remember why I merged it ...12:17
henningethe script, I mean12:17
henningemy bzr-foo was insufficient to sort things out correctly ...12:18
jtvhenninge: better resubmit then.  The MP's documentation trail *and votes* have very little to do with the branch now.12:19
henningejtv: yeah, what I thought. I will have to do that after lunch, though. Thanks for looking into this.12:20
jtvok12:20
* henninge feels slightly dizzy, time to add some calories ...12:20
=== henninge is now known as henninge-lunch
gmbadeuring: Do you have time to review the addition of a vestigial page? https://code.launchpad.net/~gmb/launchpad/add-+subscriptions-page-bug-715802/+merge/4938512:44
adeuringgmb: sure12:50
gmbThanks12:50
=== henninge-lunch is now known as henninge
adeuringgmb: r=me13:09
gmbadeuring: Thanks.13:10
=== almaisan-away is now known as al-maisan
=== benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: adeuring, benji | https://code.launchpad.net/launchpad-project/+activereviews
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: adeuring,bac | https://code.launchpad.net/launchpad-project/+activereviews
benjiheh, topic race13:14
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: adeuring, benji*, bac | https://code.launchpad.net/launchpad-project/+activereviews
bacyou won but i got the last word!13:14
benji:)13:14
bacgood morning adeuring13:14
bacbenji: the review backlog doesn't look too intimidating.  you want to work through the MPs and i'll mentor them?  (as opposed to me taking some branches myself.)13:24
benjisounds good13:24
bachuw's looks interesting...13:24
adeuringhi bac13:26
bigjoolsbenji: hello - can I talk about keyrings widya13:28
benjibigjools: sure, on a call at the moment, I'll ping you when I get done13:30
bigjoolsnae prob13:30
=== al-maisan is now known as almaisan-away
=== almaisan-away is now known as al-maisan
wallyworld_bigjools: don't forget to mention that your keyring issue appears very similar to the one i had, may be a pattern there13:48
=== henninge_ is now known as henninge
bigjoolswallyworld_: you bet.  Did you see it end up with a password of [0] ?13:50
wallyworld_perhaps. could be. not sure13:50
bigjoolswallyworld_: have you got gnome desktop installed as well?  or bits of it13:51
wallyworld_bigjools: yes. i need the gnome keyring for ubuntu one sso in particular13:52
wallyworld_wish ubuntu one supported kde :-(13:52
bigjoolswallyworld_: that's a bit annoying that it has to use that :/13:52
bigjoolssomeone in the community did a port13:52
wallyworld_there was an attempt, but i think it was aborted13:52
wallyworld_the port was aborted13:52
bigjools:(13:53
wallyworld_yeah :-(13:53
persiaYou could pick it up again ...13:53
wallyworld_persia: thought about it. need some spare time though13:54
jtvhenninge, did you resubmit?14:25
henningejtv: almost14:25
jtvlosa ping14:25
mthaddonjtv: hi14:26
jtvwhoops, wrong channel14:26
=== al-maisan is now known as almaisan-away
benjibigjools: what's up with keyring?14:40
bigjoolsbenji: yo14:40
bigjoolsso, I had the same problem as wallyworld_ apparently14:40
benji"had" or "still having"?14:41
bigjoolsusing ec2 land, it was picking up the Gnome keyring instead of kwallet and then throwing a weird error14:41
bigjoolsstill having - it's mutated :)14:41
bigjoolsthe original error is: ConfigParser.NoOptionError: No option 'consumer_key' in section: '1'14:41
benjithat's familiar14:42
bigjoolswhich seems to be because the password itself is [1]14:42
bigjoolswhich is somewhat odd!14:42
bigjoolsI deleted the password from the keyring, re-authed with launchpadlib and it puts the same thing back, which breaks next time14:42
bigjoolsI've made a keyringrc.conf to force kwallet and I now get a different error14:42
bigjoolshere's the conf: http://pastebin.ubuntu.com/565888/14:43
bigjoolsand the error: http://pastebin.ubuntu.com/565889/14:43
benjiok, I have a diagnostic script I asked Ian to run, but he had already (accidentally) fixed his problem by that time, I'll dig it up and see what it tells us14:44
benjioh, and what does "dpkg -l gnome-keyring" report?14:45
bigjools2.92.92.is.2.31.91-0ubuntu4.114:46
benjihere's the script: http://pastebin.ubuntu.com/565891/14:46
bigjoolsI see someone cocked up the versioning :)14:46
benjiit sure is an odd version string14:47
bigjoolsbenji: last output is:14:47
bigjools[{'item_id': 18L, 'domain': 'service', 'password': '[1]\nfoo\nbar', 'keyring': 'default', 'user': 'username'}]14:47
bigjoolsoh arse14:48
bigjoolsI am still configured for kwallet, let me remove that, one sec14:48
=== almaisan-away is now known as al-maisan
bigjoolsbenji: so now I get:14:49
bigjools[{'item_id': 18L, 'domain': 'service', 'password': '[1]\nfoo\nbar', 'keyring': 'default', 'user': 'username'}]14:49
bigjoolslooks the same :)14:49
benjiman, that is really odd; I expected this to be a problem with older versions of gnome-keyring and newlines in the stored value, but apparently not14:49
benjiand the first line of output is something like <GnomeKeyring instance>?14:50
bigjoolsyes14:50
bigjools<keyring.backend.GnomeKeyring object at 0x2479a10>14:50
bigjoolsI'll get you a full backtrace14:50
bigjoolsaaand now it decides to start working14:52
benjipfft14:52
bigjoolst14:53
benjiyou could try removing the dummy data the diagnostic script added to your gnome keyring; if it starts failing again then that's at least something14:53
bigjoolsanyway, I still have the wallet problem14:54
bigjoolsthe backend is found ok, it doesn't seem to initialise it14:54
=== matsubara is now known as matsubara-lunch
benjilet me look at the code for that bit...14:56
henningejtv: resubmitted. Thanks for your patience.15:01
jtvok15:01
jtvhenninge: URL?15:01
henningecheck your mail! ;-)15:01
henningehttps://code.launchpad.net/~henninge/launchpad/devel-710591-importer/+merge/4939915:01
benjibigjools: using the same Python you're running keyring under, run this import and see if it succeeds: from PyKDE4.kdeui import KWallet15:04
bigjoolsbenji: I'm not sure which python it's using - it's the ec2 script so I guess 2.615:06
bigjoolsbenji: that gives an error about kdeui not existing15:07
benjiI thought so.  The keyring package is taking your word that kwallet will work, when in fact it can't import the library.15:08
benjiThat's a bug (I'll file one).15:08
bigjoolsbenji: aha15:09
benjithe KDE bits are apparently not installed15:09
bigjoolsbenji: mmm they should be15:09
benjiand I should be king of the world15:09
bigjoolsbenji: I have a /usr/lib/pyshared/python2.6/PyKDE4/kdeui.so15:10
bigjoolsand a /usr/lib/pymodules/python2.6/PyKDE4/kdeui.so it seems15:10
benjiyou can peek at the shebang of the ec2 script and see if you're using the same python as it15:10
bigjoolsyeah I copied it15:10
benjimaybe a python path problem then?15:11
bigjoolsmost likely15:11
bigjoolshmm15:11
bigjoolsit works on my other box.... (which I can't start right now because of a power cut, sorry)15:12
=== Ursinha is now known as Ursinha-lunch
=== al-maisan is now known as almaisan-away
bigjoolsgrar netsplit15:16
jml*sigh*15:21
jcsackettbad day?15:21
jmlI'm running Launchpad locally for the first time in a couple of months.15:22
jcsackettaaah.15:22
jmlAnd of course, it's not working straight away.15:22
=== NCommander is now known as Guest28688
=== almaisan-away is now known as al-maisan
jcsackettwhat's the hangup? I just had to rebuild an lp dev environment.15:24
jmljcsackett: well, it was a js build problem. have just run 'make clean' and am running 'make schema' now in stable so I can debug fo' realz.15:24
jcsackettdig.15:25
bigjoolsyou can make -j2 for a good speedup now15:27
jmlbigjools: ooh, that's good to know.15:29
bigjoolshigher numbers are slower for some reason, but thank jtv15:30
jmlhttp://paste.ubuntu.com/565909/15:30
jmljust got this.15:30
bigjoolsrun rocketfuel-setup lately?15:30
jmland this in the logs: http://paste.ubuntu.com/565911/15:31
jmlbigjools: no, should I?15:31
=== bac` is now known as bac
bigjoolsI think it added some extra hosts15:32
jmlhmm.15:32
bigjoolsthe openid hosts15:32
jmlI have testopenid.dev. Will look at rf-setup and see if it has anything new.15:33
jmllots new, apparently.15:34
jmlI bet lots of these are cruft.15:34
jmlI wonder how I could tell.15:34
bigjoolsdivination15:34
jmlThere must be a better way.15:38
jmlgrep, perhaps.15:38
jmljam: your edit on the IR implies that there's a bug in Twisted wrt ReactorNotRunning. Is there a ticket for that?15:41
=== al-maisan is now known as almaisan-away
jamjml: not that I know of15:43
jamjml:  I did file https://bugs.launchpad.net/launchpad/+bug/71720515:43
jamlosa ping, I'm trying to dig out the log file for the bzr-forking-server running on production.15:43
jamthe qastaging one is at: /srv/launchpad.net-logs/code/tellurium/qastaging-codehosting/codehosting/bzr-lp-forking-service.log15:44
jamBut I don't see a similar file in15:44
jam /srv/launchpad.net-logs/code/tellurium/codehosting/codehosting/bzr-lp-forking-service.log15:44
jmljam: can I share that bug with other Twisted developers? (Can I make it public?)15:45
jamah, I see a crowberry/codehosting/log15:45
jamjml: I didn't think I made it security private15:45
jamno problem with me to make it public15:45
jamI must have checked something I didn't mean to15:45
mbarnettjam: yeah, that log will be from crowberry.15:45
jammbarnett: I think I was just confused by tellurium also having a "codehosting" rather than just "qastaging-codehosting"15:46
jammbarnett: is that staging- files, then?15:46
jam(just not marked as such)15:46
mbarnettyeah, that's staging.15:47
jmljcsackett: seen this one http://paste.ubuntu.com/565920/ ?15:48
henningejtv: any questions about the mp?15:49
jtvhenninge: not at the moment, no15:49
jcsackettjml: i saw something go wrong with min on a rocketfuel-get this morning, but a make clean && make got around it.15:50
jmlI'll try that again, I guess.15:50
jcsackettwell, if you just did it and are still in an error state...15:51
jcsackettone sec, i'm rolling my devel directory back and getting again; i'll see if i get the error and then can poke it with a stick.15:52
jcsackettjml: i assume you do have the file in question?15:52
jmljcsackett: I did make clean; make; bzr merge ../stable; make. Trying make clean & make again.15:52
jcsackettjml: dig.15:53
jtvhenninge: here's one question now—when determining whether upstream has templates, shouldn't we ignore deactivated ones?15:53
henningehm, probably15:53
henningejtv: I'll file a bug to add that later.15:53
henningeIt is not very important for the current bug because we are looking at upstream projects that never had any translation activity.15:54
jtvI see.15:55
henningebug 71722015:57
_mup_Bug #717220: Translation sharing info should ignore deactivated templates. <upstream-translations-sharing> <Launchpad itself:Triaged> < https://launchpad.net/bugs/717220 >15:57
jtvOK15:57
henningejtv: please email any further comments. I have to leave now. Sorry.16:00
jtvok16:00
=== matsubara-lunch is now known as matsubara
=== beuno is now known as beuno-lunch
=== Ursinha-lunch is now known as Ursinha
bigjoolsgrrrrr hanging ec2 from windmill ....16:49
jmlbigjools: I haven't seen that hanging recently (although I haven't done many runs recently), and I don't know much about windmill. The way to diagnose is probably to shell in and start using unix tools16:57
jmlsince the email you get when that happens should contain everything that the ec2 test tools know about what's going on.16:57
bigjoolsjml: the instance is down after the email though16:58
jmlbigjools: yeah. you'd have to try again.16:58
bigjoolsok thanks16:59
jmlnp. sorry I can't really help more.17:01
benjibac: I finished the review of https://code.launchpad.net/~huwshimi/lazr-js/autocomplete-enter-580404/+merge/4935117:06
abentleyjkakar, I'm using a ClassAlias in Storm, with no apparent effect.  Is this a bug? http://pastebin.ubuntu.com/565962/17:15
* jkakar looks17:18
=== beuno-lunch is now known as beuno
=== jelmer_ is now known as jelmer
jmlg'night all18:13
deryckso apparently running for i in `seq 10`; do my windmill test; done was not a good idea.18:26
benjibac: another review for your review: https://code.launchpad.net/~jameinel/loggerhead/pygment-annotate-fail/+merge/49312 (there's a yo dawg joke in there somewhere)18:31
bacbenji: thanks18:31
bacbenji: would you add me as a 'code' reviewer to the ones you need me to do?18:31
benjisure thing18:31
benjibac: is there a way to change a reviewer type after choosing another reviewer?  I didn't type anything and now I can't even remove you to try again.18:33
bacit is pretty hinky18:33
benjibac: nevermind, if I add you again it overwrites the old one18:33
bacas long as i'm added it doesn't matter.18:33
bacgreat18:33
benjibac: I've looked over the other reviews and they seem to be mid review with another reviewer, so I'll skip those18:37
bacbenji: ok18:37
abentleyjkakar, how's it look?18:47
gary_posterbenji, https://code.launchpad.net/~gary/launchpad/refactoractivitylog/+merge/49444 is ready when you are18:48
benjigary_poster: cool18:49
gary_posterthanks18:49
=== deryck is now known as deryck[lunch]
benjibac: I manually applied the patch to lazr-js/build/autocomplete/autocomplete.js and ran make to rebuild icing19:01
benjibac: I also talked to you in the wrong channel, that helps too19:01
benjigary_poster: reviewed, only one small comment19:10
gary_posterack benji, thank you.  For single and double quotes, I generally prefer single except when I need to use double.  I needed to use double for "attribute" because there is a single in the string acting as an apostrophe.  I'll leave that as it is.  I can adjust the spacing, sure.19:13
benjigary_poster: I missed that, thanks.19:13
=== almaisan-away is now known as al-maisan
sinzuibenji: bac. can either of you review https://code.launchpad.net/~sinzui/launchpad/prf-connection-0/+merge/4945620:19
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: benji*, bac | https://code.launchpad.net/launchpad-project/+activereviews
benjisinzui: ooh ooh, Mr. Kotter, Mr. Kotter20:19
sinzuiyes horshack20:20
lifelessderyck: bugs question for you20:20
derycklifeless, sure.  sup?20:21
lifelessderyck: the portlet, why does it show 'new' bugs but not 'untriaged' (e.g. those in new|confirmed|undecided-importance)20:21
lifelessderyck: if its oversight, do you see any issue in adding an 'untriaged' link (or even just replacing new with untriaged) ?20:21
lifelessactually (new|confirmed|undecided-importance|incomplete-with-reply)20:22
=== Ursinha is now known as Ursinha-afk
deryckI seem to be having connection issues.... lifeless, am I still here? :)20:26
lifelessderyck: no20:27
deryckheh20:27
deryckok, so untriaged....20:27
derycknew has always been equated to untriaged.20:27
deryckthat's why the current portlet setup20:27
lifelessderyck: status=new is a subset of untriaged, for Ubuntu and for us - for most of our users I suspect.20:28
derycklifeless, how are you defining untriaged?20:28
deryckconfirmed and/or undecided importance ?20:29
lifelessnew|confirmed|undecided-importance|incomplete-with-reply20:29
deryckwould you drop anything from the portlet, or just add those?20:30
lifelesswell20:30
lifelessI dunno20:30
lifelessto me, 'new' is uninteresting20:30
lifelessI'd be interested in s/new/untriaged/ and put that criteria behind it20:30
deryckso replace "new" with "untriaged" and have the untriaged link go to a list of bugs that includes the list:  new|confirmed|undecided-importance|incomplete-with-reply20:31
deryck?20:31
lifelessyes20:31
* deryck is thinking20:31
lifelessor add a row, but that seems less interesting, because its really that 'new' isn't inclusive enough20:32
lifelessI'll discuss this in a wider forum when you and I are in agreement20:32
lifelessbasically I want to replace the two searches on https://dev.launchpad.net/BugTriage20:32
lifelessthere are equivalent searches in the Ubuntu docs20:33
deryckfor our use and I imagine Ubuntu's, this makes sense.  I'd like wider discussion to decide the fate of new.  Some folks may really like new all on its own.20:33
deryckso I'm +1 on an "untriaged" link.  Whether or not it replaces "new" or sites alonside it, we need more input, I think.20:34
lifelessI propose to put a blog post up and a thread on lp-users20:34
lifelesshttps://wiki.ubuntu.com/Bugs/HowToTriage#Untriaged%20bugs20:34
benjisinzui: mentored approval, bac will review my review for final approval20:35
derycklifeless, sure.  I think it would be worth pinging a couple larger users of lp beyond us and ubuntu for feedback, too.20:35
deryckif reaction is limited in those two places20:35
lifelessdo we have a canned list of such users ?20:35
deryckno, not really20:37
deryckmrevell would be a good resource there20:37
lifelessk20:37
lifelessthanks20:37
derycknp20:37
=== al-maisan is now known as almaisan-away
derycklater on.  enjoy the weekend everyone!21:03
=== Ursinha-afk is now known as Ursinha
jamlifeless: it looks like whatever is generating https://lpstats.canonical.com/graphs/CodehostingCrowberryConnections/20110210/20110212/21:40
jamdoesn't see the bzr processes that are spawned by the forking server21:40
jamand we don't have a graph similar to that for qastaging21:40
jamIt is a bit hard to see21:40
jambut at 10:00 and 10:30 there are no green dots in that graph21:41
jamI would guess it is doing some sort of "ps" grepping, and the signature changed21:41
lifelessthats possible21:42
lifelessyou can tell by checking the lp tuolumne branch, I think.21:42
jamlifeless: more info would be good there21:43
jamThat is supposed to be the script that generates the graphs?21:43
lifelesstuolumne is what runs lpstats21:44
lifelesswe have a branch of it that adds data gatherers21:44
lifelesstalk to a losa for the raw info21:44
jamweird, the project itself isn't marked as private, but all branches for it are21:45
jamonly branch on lp is trunk21:45
lifelesslp does not support private projects yet21:45
lifelessanyhow, I'm fuzzy on this21:47
lifelessI think you need to talk to a losa, or flacoste, to get more info21:47
jamhttps://wiki.canonical.com/Launchpad/PolicyandProcess/AddLPStatsGraph21:51
jamis part of the code21:51
jamwhich talks about getting db items tracked21:51
jambut lp:tuluomne-lp-configs doesn't seem to have anything like "bzr ping" stats21:52
jam"There are any number of other data gathering processes that work in  different ways. All they need to do is dump data into a file in the "name:value@timestamp" format in the /srv/lpstats.canonical.com/data  directory. "21:55
jambut it certainly looks like all of that isn't versioned with everything else21:55
lifelessjam: like I say, /talk/ to a losa21:56
lifelessI have to afk for a while [tis saturday]21:56
jamlifeless: sure, but you've mentioned them about 4 times now, and you're the only one still talking here21:56
jamhave a good weekend21:56
lifelessjam: will do, you to. They don't highlight losa in public channels or something21:57
lifelessneeds an explicit ping in -ops.21:57
=== benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: bac | https://code.launchpad.net/launchpad-project/+activereviews
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: - | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews
=== Ursinha is now known as Ursinha-afk
=== matsubara is now known as matsubara-afk
jcsacketthow does one push branches and test mp diffs on lp.dev?22:48
james_wjcsackett, https://dev.launchpad.net/Code/HowToUseCodehostingLocally22:49
jcsackettjames_w: thanks. clearly my search-fu is weak this evening.22:49
james_wdon't know if that covers mp diffs though22:49
james_wit will get you the branch, then you can propose the merge, and then run the script by hand I assume22:50

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!