danilos | gmb, hi :) | 09:58 |
---|---|---|
gmb | Morning danilos :) | 10:08 |
danilos | gmb, how's it going? :) | 10:08 |
gmb | Oh, you know, doing mockups whilst outside it rains, that kind of thing. | 10:09 |
gmb | danilos: How was your week off? | 10:09 |
danilos | gmb, it was pretty good, passed one exam, failed the other one which was the next day (didn't really expect to pass that one :) | 10:11 |
danilos | gmb, btw, I just got to gary's email suggestion what I can do today, and one of the things is helping you if we can come up with a way for that | 10:15 |
gmb | danilos: Okay. I need to get through a few tasks this morning so it's prbably best if we try to work something out with gary at the standup. | 10:16 |
danilos | gmb, sure thing, I'll go back to churning email then :) | 10:16 |
gmb | Cool. | 10:16 |
* danilos -> food | 11:58 | |
gary_poster | Oops! | 13:32 |
gary_poster | Sorry | 13:32 |
gary_poster | bac benji danilos gmb, mumble/kanban in 1 (i.e., enough time for me to get my act together :-P ) | 13:33 |
bac | sorry, my sound was off | 13:37 |
gmb | I'm going to disconnect from the 'net for a while so that I can get stuff done - too many distractions today. Anything urgent, call me on +44 7725 525916 | 14:30 |
=== _starbuck is now known as _starbuck-lunch | ||
gmb | You know, this whole "not being connected to the web and getting work done" thing has its advantages. | 15:44 |
gmb | Of course, it makes inbox zero harder. | 15:44 |
gary_poster | :-) | 15:49 |
danilos | gmb, if you stay disconnected, it makes inbox zero easier :) at least from your non-connected perspective | 15:53 |
gmb | True | 15:53 |
=== _starbuck-lunch is now known as _starbuck | ||
benji | gary_poster: I need a judgement call. Testing this one line change is monstrous. Either I spend a day or two more on this or I try to push it through as a one line, untested change. | 16:25 |
gary_poster | ack, benji. one sec, lemme store state... | 16:25 |
benji | :) | 16:25 |
gary_poster | ok, benji. So, this is the template change that produces a link. I forget why there are two templates, but there are two, and one of them does what we want, and the other does not. Questions that do not necessarily lead to a conclusion follow. :-P Is the one template that does what we want tested? Have you done an implementation call with someone like Graham to doublecheck your assumptions? | 16:28 |
gary_poster | (your assumptons of what is necessary to write a test) | 16:29 |
benji | the template that includes the unsubscribe link is not tested (that I can find, but I'll looked very hard) | 16:29 |
gary_poster | gotcha. So bugnotification-sending.txt is not pertinent? | 16:30 |
benji | I've not talked to Graham or anyone else about it. | 16:30 |
* gmb reads scrollback | 16:31 | |
gary_poster | benji, here's my take. Tell me what you think. 1) take a look at bugnotification-sending.txt and make sure it doesn't help you somehow, if you have not already. 2) if that's not a help, try Graham. 3) If he agrees with your understanding, go for the one line | 16:31 |
* gary_poster was trying to use "Graham" so as not to bother gmb unnecessarily (yet ;-) ) | 16:32 | |
benji | bugnotification-sending.txt is pertenent, but off limits because of it's doctestness (that's my understanding) | 16:32 |
gmb | Hah, I have overeager highlights. | 16:32 |
gary_poster | :-) | 16:32 |
gary_poster | benji, IMO if you can quickly figure out how to use bugnotification-sending.txt to test what you need, I think it is OK. Alternatively, I'm writing a unit test version of some of the stuff in that file right now; I'm hopeful it will work, and if so, you can use it when I'm done. | 16:33 |
benji | I'll take a second look at bugnotification-sending.txt. | 16:34 |
gary_poster | benji, if you want to wait for my unit testy bits, you can put this aside and tackle something quick. bug 718809 might be *too* quick. Or you could investigate the next steps for your next job (the webservice bits). That's a bit risky, but... | 16:35 |
_mup_ | Bug #718809: New users should default to not receiving email for their own actions <story-better-bug-notification> <Launchpad itself:Triaged by yellow> < https://launchpad.net/bugs/718809 > | 16:35 |
gary_poster | ok cool | 16:35 |
* benji lunches | 16:47 | |
* gmb -> going afk for a while to make dinner; will check back later | 17:18 | |
gary_poster | thanks, bye | 17:20 |
gary_poster | bac, ping? | 19:51 |
bac | gary_poster: hi | 19:51 |
gary_poster | hey bac. quick mumble? | 19:51 |
bac | ok | 19:52 |
* gary_poster is forced to go out and work on the porch because it is so lovely outside | 20:02 | |
* gary_poster revels in how nice it is. | 20:05 | |
* gary_poster goes back to work. | 20:05 | |
* bac -> optometrist | 20:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!