[00:00] in 'beta', a @mutator_for method is a mutator but it's also published as a named operation [00:00] so you can set bug.status or you can invoke transitionToStatus [00:00] post-'beta', a @mutator_for method is only a mutator [00:01] there was no way to describe this behavior with annotations, so i had to add a new feature to lazr.restful [00:01] ok [00:02] i don't know how it might be happening but i have a suspicion that feature is interfering with what we're doing here [00:02] is that because annotations are per export ? [00:02] annotations can make something not be a mutator anymore, but they can't change what it means to *be* a mutator [00:08] ok [00:08] * leonardr does what he should have done in the first place and looks at lazr.restful unit tests [00:14] thumper: the second @operation_for_version is not necessary. @operation_removed_in_version("1.0") automatically bumps the version counter up to 1.0 [00:20] by taking that out i can get setRecipeText to show up in 1.0, but if i make it a mutator in devel it disappears from 1.0 [00:20] so i think there is a lazr.restful bug [00:22] let me try to duplicate within lazr.restful where it's more convenient [00:23] leonardr, i may well be wrong but i thought i saw lp:kanban give me an edge url to create a token [00:23] even though i updated it to request not to use edge [00:23] it may be something weird here [00:23] poolie: i'm happy to take a look, but i'm long past eod already [00:23] and i have this other problem to look into [00:23] np just letting you know [00:23] k [00:23] if i can reproduce it i'll file a bug [00:23] i may well have just had an out of date tree or something [00:23] sounds good [00:33] anyone want to claim a code review? https://code.launchpad.net/~wallyworld/launchpad/request-build-popup/+merge/48864 [00:40] wgrant: 4 seconds spent doing portlet calculations AFAICT [00:41] wgrant: I think I'm going to disable ilike temporarily, announce that, and then work on the portlet after I finish bugtask:+index landing [00:46] wallyworld_, weak +1 on that [00:47] poolie: ? [00:49] your mp looks good to me but i'm not very familar with what you're changing [00:49] wallyworld_: Why are you moving from .builds to builds_for_recipe()? That change looks spurious to me. [00:51] StevenK: it's needed because there's now 2 places (soon to be 3) that need to call that. and so moving it off SourcePackageRecipeView to a helper method that can be called elsewhere supports that [00:51] leonardr, if you're reading scrollback, it was in fact another reference to edge from kanban [00:52] poolie: you mean you reproduced the problem? [00:52] StevenK: SourcePackageRecipeView and SourcePackageRecipeRequestBuildsAjaxView use it [00:52] i did, and it's a bug in kanban not lplib [00:53] wallyworld_: Why can't they just use self.context.builds ? [00:54] StevenK: self.context is a recipe and the builds() logic is in the view [00:54] Project devel build (445): STILL FAILING in 6 hr 26 min: https://hudson.wedontsleep.org/job/devel/445/ [00:55] wallyworld_: .builds for a recipe should still DTRT? [00:57] StevenK: different requirements. recipe has getBuilds() and getPendingBuilds(). the view builds() calls these in order to show all the pending builds and 1-5 recent builds [00:57] wallyworld_: Hmmmm [00:59] StevenK: the logic to construct the contents of the builds table was already there before my mp. i'm just using it to implement a view that returns just the builds table separately instead of the entire recipe index page [00:59] StevenK: so that an ajax call can do stuff and then refresh the builds table with the latest info without needing a page refresh [01:01] thumper: i'm fairly sure there is a lazr.restful bug but i can't reproduce it within lazr.restful [01:02] i can come back to this in the morning if that's all right [01:24] leonardr: sure [01:29] thumper: the request daily build stuff all working but requires js. do we want to just not show the link if js is disabled? [01:30] wallyworld_: it should be quite possible to have it working without js too [01:31] wallyworld_: pretty trivially even [01:31] thumper: ok. [01:32] thumper: also, where did you want the link? currently i've put it just below the build schedule field (just below where it says "daily build") [01:33] wallyworld_: got a pic? [01:33] * wallyworld_ fires up ksnapshot [01:36] thumper: http://people.canonical.com/~ianb/request-daily-build.png (I don't like the + icon) [01:37] Can I suggest s/daily/manual/? [01:37] wallyworld_: why do you have a + icon? [01:37] Requesting a daily build doesn't make a huge amount of sense. [01:37] wallyworld_: how about (build now) [01:37] how about 'immediate' [01:37] or now [01:37] yeah. [01:37] That. [01:38] thumper: i wanted to put an icon there but am unsure which one is best. perhaps we don't need an icon at all. i think it looks plain without one. but that's just me [01:38] thumper: the + icon is a placeholder [01:38] It needs an icon. But I don't know of an appropriate one. [01:38] what build icons do we have? [01:38] ugh [01:38] wgrant: while i have your attention - want to be release manager for 11.03? :-) [01:38] The milestone icon is almost right, maybe. [01:38] * wallyworld_ looks [01:39] wgrant: the clock? [01:39] thumper: Yes. [01:39] Clicking 'Find...' next to 'Assign to:' field when filing a bug takes you to https://bugs.launchpad.net/people/ - making you loose your bug report. [01:39] seems reasonable [01:39] cody-somerville: I filed that a year or so ago. [01:40] wallyworld_: can you try with the clock icon, and the text: Build now [01:40] wallyworld_: then lets look at the picture [01:41] * cody-somerville just had a funny image of flacoste using a spinner from twister to randomly select teams to assign to bugs. [01:41] thumper: i can't see the clock icon in lib/canonical/launchpad/images??? have i missed seeing it or am i looking in the wrong place? [01:41] wallyworld_: milestone.png [01:41] * wallyworld_ nods [01:42] It is not optimal to overload the icon's meaning. It's mostly used for milestones and series at the moment. But it's the most appropriate thing we have. [01:44] Although for a lot of daily builds the flame icon might be appropriate... [01:44] heh [01:45] wgrant: there is the "building" icon [01:45] the animated one [01:46] thumper: But it's animated :( [01:46] and I don't really like it much. [01:50] hmmm. icon='milestone' in the Link() constructor doesn't work. still get the + icon [01:50] What's the HTML? [01:53] wallyworld_: it should end up being an anchor with the class="sprite milestone" [01:54] thumper: yeah, still has "sprite add" though. so Link('+request-daily-build', 'Build now', icon='milestone') doesn't seem sufficient [01:55] * wallyworld_ tries a make clean [01:56] wallyworld_: you need to restart to see view changes [01:56] thumper: already tried that :-) [01:58] * thumper goes to collect the girls [01:58] OOPS-1872BZR108821 [01:58] That is a lot of OOPSes. [01:58] And a strange OOPS. [02:00] wgrant: is that from a smart server process? [02:01] * StevenK blinks at the oops report for Soyuz [02:05] mwhudson: I presume so. [02:05] StevenK: Hmm, that's a bit concerning. [02:05] dpkg accepted the version... [02:05] Pity it doesn't contain any more information. [02:06] I will find the upload. [02:07] 2011-02-15 19:40:56 DEBUG Verifying source file vdr-plugin-xinemediaplayer_.11-1easyVDR1.tar.gz [02:07] Neat [02:07] I'm surprised dpkg-source accepted that. [02:07] Same. [02:07] At the very least, that also warrants a dpkg bug. [02:07] Although maybe not. [02:08] Why should dpkg-source check the version string? [02:08] On extraction, that is. [02:08] On building, maybe. [02:08] * wgrant tries. [02:09] The source package builds fine. [02:09] I wonder if binaries do. [02:10] Yup, and dpkg installs them. [02:10] Baaaaaaah [02:10] The upstream_version may contain only alphanumerics[33] and the characters . + - : ~ (full stop, plus, hyphen, colon, tilde) and should start with a digit. [02:10] "should" [02:12] StevenK: I guess valid_version may want to be fixed. Although we could decide that we don't want to support that, since it's apparently never been done before... [02:12] What do you think? [02:13] Interesting. [02:13] .1 > 1 [02:14] In fact it seems to be greater than just about anything. [02:14] So it's probably a good idea to reject it. [02:24] 41 ProtocolError: [02:24] Awesome. [02:27] erm wtf [02:28] thumper: http://people.canonical.com/~ianb/request-daily-build.png [02:29] i don't like the green text with that icon [02:29] blue would be better imho [02:30] Once we have pervasive JS that might be good. [02:30] But we'd need to change globally. [02:30] wallyworld_: hmm... [02:30] I don't like that icon [02:31] what about the copy icon? [02:31] wallyworld_: try "yes" [02:31] which is the copy icon? [02:32] do we have any gear icons? [02:33] thumper: The copy icon is the edit icon. [02:33] It sucks. [02:33] no, that blows [02:33] sucks and blows at the same time [02:33] We have a gear icon. But it flashes. [02:33] thumper: hit refresh [02:33] build-success-publishing.gif [02:33] wallyworld_: that's a maybe [02:34] wgrant: which is that? [02:34] It's used on Archive:+packages to indicate builds that have finished but are not yet published. [02:36] grr flakey code [02:39] * thumper was looking for that page that shows all the images [02:41] thumper: +graphics [02:41] Possibly for the sole purpose of making it ungreppable. [02:41] thanks [02:42] yay for race condition bugs [02:42] goes to show, don't make things faster. [02:42] lifeless: A race on BugTask:+index? [02:42] wgrant: bug message [02:42] Ah. [02:43] see bugcomment.py - group_comments_with_activity [02:43] wallyworld_: what about just using the source-package-recipe icon? [02:43] if you have two bug comments in the same datetime - and the test can generate 7 in the same datetime sometimes - then the sort order depends on sorted() being stable [02:43] but its not guaranteed stable [02:43] Hah. [02:43] That code was changed recently. [02:43] The window was just added. [02:44] orly? [02:44] * wallyworld_ looks [02:44] Previously it only grouped things at the same second. [02:45] wgrant: I think you misunderstand [02:45] wgrant: bug comments ordering is the question [02:46] Yippie, build fixed! [02:46] Project db-devel build (369): FIXED in 6 hr 28 min: https://hudson.wedontsleep.org/job/db-devel/369/ [02:46] wgrant: same datetime - doesn't matter if its per second or per day or per ms grouping [02:46] wgrant: race still exists, need to disambiguate by message.index [02:46] (though of course, thats *wrong* if we don't fix the bugimporter to use the date of import not the date on the remote tracker. [02:47] but I'll leave that for the next person that comes in and goes wtf. [02:49] anyhow, Iwas getting that one time in 3, but I think I've fixed it [02:49] the race that is [02:51] * wallyworld_ needs to add source-package-recipe entry to style-3-0.css.in [02:53] lp:~lifeless/launchpad/bug-607935 seems to be passing all tests, fingers crossed. [03:06] * lifeless waits for diff to update [03:07] * thumper shelves current work to wait for LP.client.cache updates [03:12] I can has review? https://code.launchpad.net/~lifeless/launchpad/bug-607935/+merge/49915 [03:16] lifeless: https://bugs.launchpad.net/bugs/7217/+watch/68410 [03:16] <_mup_> Bug #7217: epiphany-browser: epiphany crashes trying to print

< https://launchpad.net/bugs/7217 > [03:16] We record errors along with their message and the relevant OOPS. [03:17] I think I will clarify the message and drop the OOPS for most known failures. [03:17] Perhaps "clarify" is not the correct term for expanding on "Unknown" [03:20] Except that most of the exceptions appear at the bugtracker level, not the bugwatch level. [03:20] Argh. [03:27] wgrant: cool [03:27] No, not cool. [03:27] wgrant: easy answer - show the bugtracker health against the bugwatch [03:27] lifeless: Against all 20000 bugwatches? [03:28] wgrant: when rendering in a bug [03:28] they are related, no? [03:28] Well, sure. But I was hoping for a solution that didn't require DB changes :) [03:28] But I need new enum values for bugwatch warnings anyway. [03:28] So we might as well just do this properly. [03:29] tis always a tradeoff [03:29] you could squelch the oops, log at info or whatever so there is a record, and file a bug for future improvements. [03:29] right now users are equally badly off in this proposal. [03:29] We need a new BugTrackerActivity table and BugWatchActivityStatus.WARNING [03:30] Once we have those we can notify users adequately. [03:30] what would the table store ? [03:30] It would store bugtracker-wide errors. [03:31] Because of the batch update mechanism, most of the exceptions don't have an associated bugwatch. [03:33] Has the description textarea on +filebug shrunk, or is it just me? [03:34] wgrant: do we know the bugwatch(es) that we're /trying/ to update? [03:34] wgrant: anyhow, such a schema change sounds reasonable [03:34] wgrant: I only suggest a lower key thing to keep in the spirit of maintenance vs features [03:35] lifeless: We don't. [03:36] wgrant: so the api just triggers 'changes since date' or some such? [03:36] wallyworld_: how's that image going? [03:36] Something like that. I forget the details. [03:36] thumper: &^!@^!@! make was failing [03:37] seems to me we know then - that case would be 'all bugs' [03:37] [for that tracker] [03:37] lifeless: That is a lot of bugwatchactivities. [03:37] thumper: turn out you have to make sprite_image separately or else it all falls in a heap [03:37] wallyworld_: The sourcepackagerecipe icon wasn't already a sprite? [03:37] Wait, what is the sourcepackagerecipe icon? [03:37] Oh, right. Package with a branch. [03:38] wgrant: no. not a sprite already [03:38] but why isn't the sprite_image target invoked for a make clean build or even a make build????? [03:38] if i commit this change, then others will have the same issue, no? [03:39] The sprite image is committed to the tree. [03:39] Because it changes once in a fairly long time. [03:39] oh ok [03:40] i didn't realise that. surely though commiting binary blobs that are generate from source is bad :-( [03:40] Plus the location calculation is not entirely deterministic. [03:40] Yes, it is. [03:40] Rather bad. [03:40] it's not as if sprite_image takes more than asecond or so to run either [03:40] But people don't seem to mind including large trees of other people's code in our tree. [03:41] So what's a small blob? :) [03:41] so why the fark don't we just run it as part of make [03:41] i just wasted a looong time figuring this out :-( [03:41] wgrant: one small blob is a blob too many :-( [03:43] thumper: http://people.canonical.com/~ianb/request-daily-build.png [03:44] thumper: can we/i fix the !!@%@!^& makefile? [03:44] wallyworld_: You may want to check with a LOSA. [03:44] Also make the positioning stuff deterministic. [03:44] or do you agree with commtting the sprite image blob? [03:44] hrm? [03:44] When I rebuilt it Monday a couple of things changed order. [03:45] wgrant: so what did you do to account for the ordering change [03:45] spm: Where is 'make build' done on production? [03:45] wallyworld_: Nothing, because I didn't end up committing my changes. [03:45] on each prod server [03:45] spm: we are committing a binary blob (the sprite image file) when imho it should be built [03:45] wallyworld_: We need to be careful that we don't end up with different files across the frontends, I think. [03:46] Or caching may get a bit odd. [03:46] wgrant: so how did you know things changed order? [03:46] wallyworld_: by sprite - this is a picture? [03:46] wallyworld_: icon-sprites.positioning changed. [03:47] spm: yeah, it's a binary blob of all our little icons that are displayed next to links etc - a combination of the individual png files if you like [03:47] wgrant: so in that case both files would need to be committed and it should just work [03:47] so why do you want to build that on each server? it'd be pretty static - build and control it yourself? [03:48] wallyworld_: Which files? [03:48] esp aiui, this'd only need building on 2 servers - can you get the granularity down such that it *only* builds on 2 of the 30 odd? [03:48] spm: committing blobs which are built from source artifacts is imho fundamentally wrong and bad practice [03:49] building on 30 servers, something needed on 2, is also ... wrong. :-) [03:49] spm: make build should do it [03:49] it only takes a second [03:49] spm: the makefile targets should only build what's required [03:50] for each deployment target [03:50] yesssss. so does every other little build. which is why a nodowntime rollout takes from 60-90 minutes. [03:50] s/target/environment [03:50] spm: it could be done before rollout though - part of creating the rollout directory image [03:51] oh, you said nodowntime [03:51] actually - step back a bit here - *what* builds this? what tools are needed? [03:51] spm: make sprite_image builds it [03:52] does that need imagemagik or something? [03:52] I guess - how often do these change? [03:52] its a tool in the bin directory which also does other sprite related stuff (css file generation etc) [03:52] It uses PIL. [03:52] So it should be fine. [03:53] spm: they don't change often [03:53] just checking we don't suddenly introduce a bunch of crackful deps to add to prod. :-) [03:53] it's more a philosophical thing, plus i just wasted shitloads of time cause i expected make to build what it needed [03:53] heh [03:54] by philosophical, we are talking about what consistutes best practice etc [03:54] ha. don't make me pull out the page on argument fallacies. ;-) [03:54] I guess in the overall scheme of things, go for it. add it to the makefile. [03:55] spm: i likely won't change the makefile, once i build a bridge and get over my frustration [03:55] spm: clearly oeple smarter than me did it that way for a reason :-) [03:56] rules are there so you think about breaking them. not to be followed blindly. :-) [03:56] :-) [03:57] try telling that to my wife [03:57] wives are an exception to all rules, except their own. QED. [03:57] you are a wise man [03:57] hi spm [03:57] heya poolie [03:59] wallyworld_: my 2c for something like this: that doesn't change often and all, denormalise - commit the binary blob and wear the overhead there - to get a bigger saving in prod/deploy/build. but each case has exceptions. [03:59] spm: fair enough [04:00] +1 for naked juggling [04:00] poolie: ha de ha ha [04:00] if it had funky deps on code changes and such? then you make build on each server per normal; but if it's largely standalone. shrug. [04:00] poolie: i don't think you really would want to see that [04:00] * spm afks to fetch lad from school [04:03] thumper: you around? [04:18] Daily builds for this recipe will not occur. [04:18] There is no PPA. [04:18] That sounds a little dramatic. [04:19] wallyworld_: Do you know much about the daily build archive widget? [04:19] wgrant: depends on what you want to know :-) [04:20] wallyworld_: The picker popup needs spinners. [04:20] The list takes a while to load, leaving the popup empty for a couple of seconds. [04:20] wgrant: because it takes time to load them up? [04:20] Then when you move to another page the number changes immediately, but the contents take a couple of seconds. [04:20] In both cases I think the contents should be replaced with a spinner. [04:20] Or something like that. [04:20] wgrant: yeah, i just wrote a popup form and added a "Loading..." spinner for the same reason [04:21] Also there is a vast amount of padding at the bottom of the popup. [04:21] Ah, because there is an unused footer slot. [04:21] Deleting that makes things marginally more sensible. [04:22] It seems to be a general picker issue. [04:22] is that lazr-js? [04:22] wgrant: i think the best thing is to file a bug so it's in the system [04:22] wallyworld_: Sure, I'm just wondering where to file it. [04:22] Is it LP, is it Code, is it lazr-js? [04:22] wgrant: yeah, the base picker.js is in kazr-js from memory [04:23] Otherwise the AJAXyness of SourcePackageRecipe:+index is pretty awesome. [04:23] wgrant: i'd file against launchpad since the issue manifests itself in the recipe area. that's imho [04:24] wgrant: once my mp lands it will have even more ajax [04:24] the request builds link uses a popup form with a no-pageload refresh of the current builds table [04:24] wallyworld_: Ah, other pickers have a search widget where the search icon turns into a spinner. [04:25] The daily builds ones do not. [04:25] I will file against launchpad. [04:25] wgrant: that was my thinking - that the root cuase lay in how the picker was being used, hence a lp issue [04:40] wallyworld_: bug #719785, bug #719788, bug #719795 [04:40] <_mup_> Bug #719785: Recipe owner and archive pickers need spinners < https://launchpad.net/bugs/719785 > [04:40] <_mup_> Bug #719788: Recipe archive picker has an empty footer < https://launchpad.net/bugs/719788 > [04:40] <_mup_> Bug #719795: Recipe archive picker items are twice the required height < https://launchpad.net/bugs/719795 > [04:40] wgrant: thanks. thumper will be ecstatic :-) [04:41] Heh. [04:43] I also have some suggestions for the builds table, but I think they might cause thumper to leap over the Tasman and strangle me. [05:10] hmm.... [05:11] wgrant: I'm open to suggestions [05:11] wgrant: do the pickers not have any spinners? [05:11] thumper: They don't :( [05:11] wgrant: that's a problem === rockstar` is now known as rockstar [05:12] thumper: I'd prefer the builds table to be more like Archive:+packages. A single row per source, only showing binaries if they are not yet built or have failed. [05:13] wgrant: Hm, do you know off-hand if the sampledata has another account enabled except admin@c.c? [05:13] Archive:+packages' implementation is rather flawed. But you have the opportunity to experiment and improve upon that. [05:13] wgrant: not really [05:13] wgrant: we are moving off recipes into maintenance shortly [05:14] * thumper goes to make dinner [05:14] StevenK: no-priv@canonical.com, carlos@canonical.com, test@canonical.com, cprov@ubuntu.com [05:14] thumper: :( [05:15] wgrant: Thanks [05:15] Not allowed here reproduced for recipes with a disabled archive. [05:15] Which is a little O.o [05:16] Oh, let me guess. The security proxy is such that if the archive is disabled, only the owner can see it? [05:16] That's right. [05:16] * StevenK grumbles [05:17] I'll fiddle the browser code to give us 'Disabled archive' rather than unathorized [05:21] wgrant: are you talking the +dailybuilds thing, or the per-user recipes list? [05:21] lifeless: SourcePackageRecipe:+index [05:26] thumper: will the daily builds page we spoke about get fixed before you rotate off? [05:27] Can I search through OOPSes for a particular exception without grepping through $lots? [05:27] not yet [05:32] Oh, I can see lp:oops-tools now. That is handy. [05:33] Ahhhh [05:34] Most of these OOPSes used to be in a warnings subsection of the checkwatches OOPS report. [05:34] still covered by zop [05:35] Should they be? [05:35] Remember we have UFD and go. [05:35] *co [05:36] OffsiteFormPostError, UnexpectedFormData, InvalidBatchSizeError all OOPS but are in a separate section of the report. [05:36] Still, some of these checkwatches OOPSes record no information beyond what is put in the DB, so they can go. [05:37] unless we're going to take action on it, they shouldn't be logged. [05:37] We have significan space issues with oops [05:37] Oh, do we? [05:37] yes [05:37] :( [05:37] plus rsync overhead, processing on devpad etc [05:38] True. [05:38] oops should be things /we/ need to take action on [05:43] ^^ this! :-) [05:49] lifeless: Caps!@ [05:50] Also, bug #28506 is probably not the one you are looking for... [05:50] <_mup_> Bug #28506: It should be possible to install xchat instead of xchat-gnome < https://launchpad.net/bugs/28506 > [05:51] wgrant: context? [05:51] do you mean 268508 ? [05:53] lifeless: Your blog post says 28506 [05:53] grah [05:53] edit-fail [05:53] the right link is earlier [05:54] fixed [05:55] wgrant: thanks [05:55] lifeless: I'd also retitle it something like "Bug searches no longer match target names", I think. [05:55] But perhaps not. [05:56] thats more accurate and less relevant or understandable IMO - I did consider it [05:56] but something like 99.9% of multi context searches will be package related [05:56] s/target/source package/, then. [05:56] that would be a lie [05:56] But caps and short is important. [05:59] Thanks. [05:59] If it didn't show up on https://launchpad.net/ I would not be so pedantic. [06:02] wgrant, i agree [06:02] 'read the blog' is bad style too [06:36] 'read the blog'? [06:38]