| danilos | gmb, hey-hey, how was your week off? | 10:43 |
|---|---|---|
| gmb | danilos: Restful, thanks :). Also, full of email, judging by the state of my inbox. | 10:44 |
| gmb | Marking the bug mail as read has helped somewhat, though. | 10:44 |
| danilos | gmb, heh, I know what you mean | 10:44 |
| danilos | in the last month or so I stopped getting launchpad-dev email (trying to figure that out now), so it's been pretty relaxing for me as well :) | 10:45 |
| gmb | Heh. | 10:45 |
| gmb | I've stopped getting Warthogs and AllHands emails, strangely. I see that as a feature, though. | 10:45 |
| danilos | heh, so true :) | 10:51 |
| danilos | allhands has become a bit worse with all the job postings going on | 10:51 |
| gary_poster | hey gmb. welcome back! Am I right in assuming/hoping that catching up on email and the like was a sufficient task for this morning, and that you were non blocked? I'm hoping that you will work with bac on the widget he's been working on. I'll give more background later, but the sum is that this week is critical for us getting some usable version of the widget ready working (i.e., everything but a full test suit | 13:04 |
| gary_poster | bac can give you background on what needs to be done, and if there have been any replies on his requests for help | 13:04 |
| gmb | gary_poster: Yep, I've been fine this morning. Also have a fix for bug 722450 in review with Henning. | 13:06 |
| _mup_ | Bug #722450: bug subscription form is loaded even if not needed <Launchpad itself:In Progress by gmb> < https://launchpad.net/bugs/722450 > | 13:06 |
| gary_poster | yay gmb, thank you! | 13:06 |
| gary_poster | last week was not as productive--particularly for me, but for others as well--as previous recent ones. Hopefully I get my tasks done this week again. :-/ | 13:08 |
| gary_poster | ack on the email to Huw, benji. Thanks | 13:09 |
| benji | yep | 13:09 |
| bac | gary_poster: will do | 13:16 |
| gary_poster | thanks | 13:17 |
| bac | gmb: can we just mumble after our standup? | 13:22 |
| gmb | bac: Sure, that works for me. | 13:22 |
| gary_poster | bac benji danilos gmb mumble/kanban in 2 | 13:28 |
| gmb | benji: You sounded like you were mumbling from your underwater lair, there. | 13:29 |
| benji | heh | 13:29 |
| gary_poster | http://pastebin.ubuntu.com/573453/ | 13:46 |
| gary_poster | http://pastebin.ubuntu.com/573455/ | 13:48 |
| gmb | bac: Ah, what I was recalling from 2008 was that slide_in() must be used to collapse the collapsibles as it does all the setting up of stuff. | 14:03 |
| gmb | But you'd already used that. | 14:03 |
| gmb | Hmm. | 14:03 |
| gmb | Square 1, then. | 14:03 |
| gary_poster | danilos: "You receive emails about this bug because" | 14:07 |
| danilos | benji, hi, I'll be doing the top part of the page you are doing (fyi) | 14:20 |
| danilos | benji, also, I wonder what existing page is that (so I don't end up creating a new one)? | 14:21 |
| danilos | benji, (and "top part" = explanation and direct subscription actions) | 14:21 |
| danilos | gary_poster, oh, btw, I've just figured out that I can do some work on feature 3 as well: I can go on with adding subscription filters to the email, even though they are not auto-created (that's the card below the green card in feature 3), since we already have the new linking table landed | 14:35 |
| gary_poster | danilos, awesome | 14:41 |
| bac | gmb: i've pushed a new branch to lp:/~yellow/launchpad/accordionoverlay | 14:42 |
| danilos | gary_poster, so, I'll pick that up instead, and only if I finish that too quickly will I take on bug (un)subscription page :) | 14:45 |
| gary_poster | :-) ok cool danilos makes sense | 14:45 |
| gmb | bac: Thanks, I'll grab that now. | 14:57 |
| gmb | bac: So, how do I get the accordion overlay to show up on a given page? | 15:14 |
| bac | gmb: ah, yes. login as mark and visit http://launchpad.dev/firefox | 15:15 |
| gmb | Righto. | 15:15 |
| gmb | bac: What's mark's .dev login again? | 15:16 |
| bac | mark@example.com / test | 15:16 |
| gmb | Ta | 15:17 |
| gmb | bac: Hmm. I'm still not seeing a Subscribe link like that shown in your screenshot. | 15:21 |
| bac | gmb: let me re run with that version and verify it works here | 15:22 |
| gmb | ok | 15:22 |
| bac | gmb: if you merged into an existing branch you may need to run buildout again | 15:23 |
| bac | and then do a make clean build | 15:23 |
| gmb | bac: I just branched from the ~yellow branch. But I'll do that anyway. | 15:23 |
| gmb | benji: Are you OCRing today? | 15:30 |
| benji | gmb: yep | 15:30 |
| gmb | benji: Ah cool. Can I toss a branch your way then; no rush but Henning apparently forgot about it: https://code.launchpad.net/~gmb/launchpad/fix-subscribe-form-preloading-bug-722450/+merge/51510 | 15:31 |
| benji | gmb: sure | 15:31 |
| bac | gmb: i see there is a problem with the structural-subscription javascript after i merged. i'll fix it and let you know. | 15:31 |
| gmb | benji: Thanks. | 15:31 |
| gmb | bac: Thanks. | 15:31 |
| bac | gmb: it looks like devel r 12478 changed the way LP.client works. it seems 'LP.client.*' should now be referenced as 'LP.*' | 15:49 |
| bac | i don't see any message to the list informing of the change | 15:50 |
| bac | and if true, all of our JS is broken | 15:50 |
| gmb | bac: Hmm. Neither did I, though I've been skimming. Was that thumper's change? He alluded to something LP.client-y earlier. | 15:50 |
| bac | yes | 15:51 |
| gmb | bac: I think he did some work to avoid breakages, but I could be wrong (and if it *did* break things our JS tests should have caught it). | 15:52 |
| bac | you'd think/hope | 15:52 |
| bac | i'm examing the LP object and it has no client attribute | 15:52 |
| gmb | Well, it's more hope than expectation, to be honest. | 15:53 |
| gmb | Hrm. | 15:53 |
| gmb | bac: So, I think our existing JS has been updated to take account of the LP.client change, since the advanced subscriptions overlay relies on that and still works in the accordion-overlay branch. | 15:59 |
| bac | right. | 15:59 |
| bac | do you know what that update might've been? | 15:59 |
| bac | ah, i see | 16:00 |
| bac | the client.js moved and i need to fix the page template | 16:00 |
| benji | gmb: I'm reviewing your branch and have a question: since we're doing a possibly slow AJAX request as the result of a user clicking on an element, should we be displaying a spinner? | 16:02 |
| gmb | benji: It's probably the lesser of two evils, thinking about it. I'm utterly ambivalent about it, so I'll happily add it if you like. | 16:03 |
| benji | gmb: I don't have strong feelings but do have an intuition that users would have a slightly better experience if we hypnotize them with a spinner so they don't notice the passage of time | 16:05 |
| gmb | benji: Right. I'll do that. | 16:05 |
| benji | gmb: I'll add that comment to the MP and otherwise approve | 16:06 |
| gmb | benji: Thanks. | 16:06 |
| bac | gmb: here's the main difference: | 16:15 |
| bac | - lp_client = new LP.client.Launchpad(); | 16:15 |
| bac | + lp_client = new Y.lp.client.Launchpad(); | 16:15 |
| gmb | Ah, right. | 16:15 |
| bac | gmb: new working version pushed | 16:18 |
| gmb | bac: Thanks. Grabbing it now. | 16:18 |
| * gmb waits for the branch mirror puller thinger to do its work | 16:20 | |
| * gmb -> out for a run | 16:39 | |
| * benji lunches. | 17:29 | |
| gmb | bac: Where did you push that updated branch? I keep getting "no revisions to pull" for the ~yellow/launchpad/accordionoverlay branch. | 17:59 |
| bac | hmm | 17:59 |
| * bac looks | 17:59 | |
| bac | sorry, it went to ~bac. i'm pushing to ~yellow now | 18:00 |
| gmb | Cool, tahnks. | 18:00 |
| === gary_poster is now known as gary-lunch | ||
| gmb | bac: I'm technically EoD'ing now (though I may pop back later if there's time). Can you send me an email with a summary of how far you've got when you hit EoD so that I can pick things up tomorrow AM my time? | 18:14 |
| bac | gmb: ok. right now i'm trying to create a stand-alone example of the failure | 18:15 |
| gmb | ok. | 18:15 |
| bac | gmb: have a good evening | 18:16 |
| gmb | Thanks. | 18:16 |
| * gmb -> exeunt, in pursuit of dinner. | 18:16 | |
| * bac mourns the deletion of BRANCH.TODO | 18:47 | |
| === gary-lunch is now known as gary_poster | ||
| === Ursinha is now known as Ursinha-lunch | ||
| benji | bac, gary_poster: is it OK if I freshen bzr+ssh://bazaar.launchpad.net/~yellow/launchpad/accordionoverlay/ from devel? (I need some of the devel bits for my work.) | 20:27 |
| bac | benji: it should be pretty fresh | 20:27 |
| gary_poster | benji, fine with me | 20:27 |
| bac | i merged with trunk this morning | 20:27 |
| bac | and pushed it up | 20:27 |
| benji | bac: cool, maybe I just need to pull | 20:28 |
| bac | unless you need *really* new stuff | 20:28 |
| bac | benji: did you see the discussion about LP.client going away? | 20:28 |
| benji | bac: umm, no; where was that? | 20:28 |
| bac | here | 20:28 |
| * benji looks at the logs. | 20:29 | |
| bac | basically, s/LP.client/LP/ | 20:29 |
| bac | and the constructor moved | 20:29 |
| benji | ok, that's not too painful | 20:29 |
| bac | the code is right now, so just follow the existing pattern, not the one in your head | 20:29 |
| * gary_poster ponders "the code is right now"... | 20:29 | |
| bac | gary_poster: for a very specific problem domain | 20:30 |
| gary_poster | ah ok, I think :-) . It sounded like it was veering in to the philosophical :-) | 20:30 |
| bac | it's still fubar but works wrt the new changes | 20:30 |
| gary_poster | ah ok | 20:30 |
| === Ursinha-lunch is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!