=== Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [13:29] bac benji danilos gmb mumble kanban real soon now [13:29] ack [13:29] Yup [13:30] ok [13:43] gmb, I'll paste you the question I had [13:44] gary_poster: a small note, I'm going to take lunch a little early today (11ish), we have a realtor coming over; we're thinking about selling the house [13:44] benji, wow! [13:44] gmb, so, there is a BugNotificationRecipientReason in lp.bugs.mail.bugnotificationrecipients that kind of duplicates the functionality of BugNotificationRecipients reason construction [13:45] benji, cool. good luck. [13:45] benji, if realtor you are trying doesn't work out, we had good luck in F'burg with Mike Burleigh. [13:46] Can get you number if interested [13:46] *Reason stuff seems to be newer code, and seems to have decent unit tests, but doesn't seem to be used anywhere [13:46] gmb, do you have any idea what we should do with it? [13:48] danilos: ISTR looking at that in the last six months or so; let me take another look to refresh my memory. [13:52] gmb, heh, yeah, according to bzr log, you should know something about it :) https://bugs.launchpad.net/launchpad/+bug/594211 [13:52] <_mup_> Bug #594211: Add a RecipientReason class to bugnotificationrecipients.py

< https://launchpad.net/bugs/594211 > [13:53] Ha. [13:56] gmb, anyway, it seems it's not tied in yet and is a dead code; do you know if it has been kept up to date regarding everything else or might it be stale regarding all the stuff that has happened in the meantime? [13:56] danilos: If it's not used, dump it. [13:56] danilos: It was added because we wanted to refactor l/c/l/mailnotification.py into something more sane [13:56] But that turned out to be a nest of vipers, so we gave up and I never removed the code I'd added. [13:56] gmb, but it has much nicer tests than anything else I've touched recently in bugs code :) [13:57] :-) [13:57] gmb, heh, ok, I'll add a card to get rid of it then [13:57] :) [13:57] danilos: Cool, thanks. [13:57] gary_poster, "big picture" backlog or JFDI? :) [13:58] JFDI danilos :-) [14:17] gmb, can I nudge you to give your blessing for https://code.launchpad.net/~danilo/launchpad/drop-dead-dead-code/+merge/51899 :) [14:18] danilos: Sure. [14:19] danilos: r=me [14:19] gmb, thanks :) [14:27] gmb: ugh, bad news. your change exhibits the *exact* same bad behavior as the accordion. branch pushed to new location: lp:~yellow/launchpad/accordion-overlay-2 [14:27] BUGGER [14:27] bac: OTOH, maybe this means it's *not* the accordion then. [14:27] But something more insidious. [14:28] gmb: therve responded on canonical-js [14:28] * gmb looks [14:30] hm, that sounds promising [14:30] Indeed. [14:30] yay for small reproducible bits [14:30] and helpful colleagues [14:32] gmb: i'm still digesting his suggestion [14:32] "But something more insidious" makes me want to hear some Jules Verne and/or Cthulu inspired cause for the JS issues. [14:33] squids need to be involved one way or another, I think. [14:33] I once wrote an easter-egg for a webapp that made an ascii-art Cthulhu appear after a certain sequence of mouse-clicks. Wonder if I could reuse it in the accordion... [14:33] lol [14:33] that would be awesome [14:41] gmb: i incorporated therve's suggestion in the minimal example: bzr+ssh://bazaar.launchpad.net/~bac/%2Bjunk/accordion_test/ [14:41] it seems to work with the accordion! [14:41] bac, fwiw I sent a note to Francis asking him to check up on Dav [14:41] \0/ [14:41] and, YAY [14:41] gmb: please sanity check [14:41] bac: Pulling now. [14:42] gmb: we'll have to make the corresponding change to lazr-js.effects, no? [14:42] challenges with working in a distributed environment: we can't all dance around in a jig in the same room [14:42] though maybe that's another advantage... [14:43] bac: Yes, I think that's the case (sadface). [14:44] * gary_poster not happy with lazr-js being a stumbling block [14:45] gary_poster: but on the upside, once there the animation will just DTRT and no one else using it will have to suffer this problem [14:45] gary_poster: It's a PITA, to be sure. But working together bac and I should be able to get this incorporated therin, reviewed and landed today. [14:45] I'm pretty darn happy with both of those :-) [14:45] (me waves hands vaguely about timescales) [14:45] :-) [14:46] a day, in the biblical creation story sense? [14:46] Hah. [14:46] * bac wonders if his original email was really that muddled... [14:46] original+1, actually [14:57] bac, I'd guess that it was your second, smaller and self-contained code example that got attention, but who knows for sure. [14:58] gary_poster: right, but thomas commented even that was terribly confusing. it got an answer so i'm not fretting. [14:58] I see. ok, cool [15:08] gmb: so at a minimum, it seems you need to set visibility to 'none' before trying to get the true height and then set height to 'auto' after animating to 0 [15:08] bac: Right. That sounds deceptively simple... is it? [15:09] simple and obvious [15:09] *of course* making something invisible would force him to not lie about his size [15:10] Heh [15:10] :-) [15:21] gmb: i'm working on lazr-js now [15:21] bac: Okay. I'll be happy to review it for you. [15:21] it's been a while since i've made changes there so i'm trying to remember the steps [15:21] Ah. [15:21] bac: I think deryck's your man if you have questions; I can't quite remember the steps either. [15:33] * gmb -> heading out for a run; back in ~45 [16:15] * gmb returns [16:33] bac: Is there anything I can be doing right now to help you out? [16:39] bac, gmb, maybe "wire up widgets to back end data store" that benji started? [16:39] wait, no [16:39] I think that's done... [16:39] gary_poster: I can take bug 721400 as a job to take me to EoD. [16:39] and we need to have a card for adding the internal widgets to each part of the accordion? [16:40] <_mup_> Bug #721400: Bug:+subscribe can't cope with existing BugSubscriptions with a bug_notification_level of NOTHING < https://launchpad.net/bugs/721400 > [16:40] (And I'll happily review bac's lazr-js work when it's ready) [16:40] gmb, how much work are those three mute button bugs, in your wavy-handed estimation? [16:41] I still suspect that the mute table might be a better approach, but if we can whip out those bug fixes, I'm +1 on moving ahead with the existing plan [16:42] gary_poster: I think I could have those done by EoW. [16:42] gmb, ok fire away [16:42] thanks [16:42] gary_poster: Cool; np. [16:42] ideally we would have a feature lane free but you can use quick jobs for now [16:44] bac, lemme know if you could use some help, or if gmb continuing as occasional consultant is the right approach. [16:57] gary_poster: ok [16:57] gmb has been more than that recently and i appreciate it [17:21] gmb: i've pushed a new version back to the old spot: bzr+ssh://bazaar.launchpad.net/~yellow/launchpad/accordionoverlay [17:22] it incorporates thomas' suggestions but inside our js, not lazr-js [17:22] figured it was easier to get it working there [17:22] bac: I like your thinking. I'll pull it and take a look. [17:22] it is better and shows promise but has obvious problems still [17:22] my brain is mush so i'm going to go to lunch, despite my pledge earlier today [17:23] let me know if you make any progress and i'll pick up later [18:28] bac: I'm somewhat disturbed to find that setting the node's height to 0 when the slide_in ends appears to just work. I'm not sure that that's right or that I'm not actually going to cause other problems though. [18:28] I've pushed my changes (including indentation fixes - sorry for the diff noise; vim corrects it for me automagically) to the ~yellow branch. [19:05] gmb: so things seem to work now, despite it being hacky? [19:06] bac: Yeah. I think so, anyway. I also stripped out the collapsible classes since it might have caused the existing collapsible code to fight with it. [19:06] ok [19:07] bac: But you may know of more little oddities than I know to look for. [20:17] so, bac, where is JS then? the discussion here seems to imply that everything is copacetic. Is that true? [20:17] where is our JS, I should say [20:22] hi gary_poster [20:22] hey [20:22] what we've been working on is in lib/lp/registry/javascript/structural_subscription.js [20:23] the stuff gmb and i did today eventually needs to find its way into lazr-js [20:23] makes sense [20:23] i'm still getting his branch to see what it looks like [20:23] (fwiw, Python structural subscription stuff has moved to lp/bugs, but don't worry about that now) [20:24] oh, ok [20:24] good to know and easy to fix [20:24] cool [20:24] it really doesn't fit in either place, does it? [20:24] IMO there's nothing to do really with registry, and it is entirely about bug subscriptions [20:25] so, while it touches many parts of LP, it's essentially about bugs--if we didn't have a bug tracker but had everything else, these things would go away. [20:26] make sense === Ursinha is now known as Ursinha-food [20:42] gary_poster: Style consultation: does http://i.imgur.com/tJmhm.png look enough like https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/SubsListRound1/Slide1 to not worry about any further? [20:47] benji, good. Two things. 1) ask Huw for CSS/changes for the pretty text-over-the-border look. 2) find the edit icon on LP and include it too. I think it is some funky sprite thing [20:47] gary_poster: sounds good [20:47] gary_poster: i'm exercising gmb's latest branch and it looks great [20:47] i can't make it fail [20:48] bac, yay! yay! [20:48] * bac happy [20:48] So what's left...we need tests of some sort still I assume, and we need to populate the accordion with the proper widgets? [21:06] bac ^^ [21:06] benji--sorry for the delayed followup, but there's a delete icon to use too. Let's include that too. I think it is in some of the other mockups, and it seems like a standard visual thing we do. [21:06] gary_poster: yeah, all of that [21:06] it needs polish [21:06] ok, but things we know how to do, mostly, yeah, bac? [21:06] and hooking up [21:06] gary_poster: sounds good [21:06] famous last words, but yeah, i think so [21:06] cool benji [21:07] bac, understood :-) [21:07] gary_poster: i will do some clean up this afternoon and hand it off to gmb with a list of next things. if that's what you want. [21:09] bac, sounds good to me. gmb was in the middle of a bug, so I'd be happy for him to get to complete it, but I think it's close if not done already [21:09] ok [21:11] gary_poster: I copied you on the email to Huw, I don't know if that's something you generally want or not, so you'll have to tell me to stop ;) [21:12] benji, I like it, please continue. :-) [21:12] k [21:23] gary_poster: we still have the outstanding design issue of the twisty arrow placement [21:24] bac, yes. AIUI benji and Huw are working on that. My hope is that the resolution won't be too far from the checkboxy thing [21:24] (So significant work will not have to be redone) [21:24] ok [21:24] I'm just being optimistic, I guess, bac. :-/ [21:26] by way of status update: I got an email from Huw yesterday morning asking some clarifying questions which I replied to immediately; nothing more yet. [21:39] right benji, thanks === Ursinha-food is now known as Ursinha [21:55] interesting, closing the overlay causes some of the items to be left behind, imprinted on the underlying web page. oops. [22:00] :-/ [22:03] * gary_poster is out. ttyl