[13:29] <gary_poster> bac benji danilos gmb mumble kanban real soon now
[13:29] <danilos> ack
[13:29] <gmb> Yup
[13:30] <bac> ok
[13:43] <danilos> gmb, I'll paste you the question I had
[13:44] <benji> gary_poster: a small note, I'm going to take lunch a little early today (11ish), we have a realtor coming over; we're thinking about selling the house
[13:44] <gary_poster> benji, wow!
[13:44] <danilos> gmb, so, there is a BugNotificationRecipientReason in lp.bugs.mail.bugnotificationrecipients that kind of duplicates the functionality of BugNotificationRecipients reason construction
[13:45] <gary_poster> benji, cool.  good luck.
[13:45] <gary_poster> benji, if realtor you are trying doesn't work out, we had good luck in F'burg with Mike Burleigh.
[13:46] <gary_poster> Can get you number if interested
[13:46] <danilos> *Reason stuff seems to be newer code, and seems to have decent unit tests, but doesn't seem to be used anywhere
[13:46] <danilos> gmb, do you have any idea what we should do with it?
[13:48] <gmb> danilos: ISTR looking at that in the last six months or so; let me take another look to refresh my memory.
[13:52] <danilos> gmb, heh, yeah, according to bzr log, you should know something about it :) https://bugs.launchpad.net/launchpad/+bug/594211
[13:52] <_mup_> Bug #594211: Add a RecipientReason class to bugnotificationrecipients.py <lp-bugs> <qa-ok> <story-better-bug-notification> <story-refactor-bugnotifications> <Launchpad itself:Fix Released by gmb> < https://launchpad.net/bugs/594211 >
[13:53] <gmb> Ha.
[13:56] <danilos> gmb, anyway, it seems it's not tied in yet and is a dead code; do you know if it has been kept up to date regarding everything else or might it be stale regarding all the stuff that has happened in the meantime?
[13:56] <gmb> danilos: If it's not used, dump it.
[13:56] <gmb> danilos: It was added because we wanted to refactor l/c/l/mailnotification.py into something more sane
[13:56] <gmb> But that turned out to be a nest of vipers, so we gave up and I never removed the code I'd added.
[13:56] <danilos> gmb, but it has much nicer tests than anything else I've touched recently in bugs code :)
[13:57] <gary_poster> :-)
[13:57] <danilos> gmb, heh, ok, I'll add a card to get rid of it then
[13:57] <gmb> :)
[13:57] <gmb> danilos: Cool, thanks.
[13:57] <danilos> gary_poster, "big picture" backlog or JFDI? :)
[13:58] <gary_poster> JFDI danilos :-)
[14:17] <danilos> gmb, can I nudge you to give your blessing for https://code.launchpad.net/~danilo/launchpad/drop-dead-dead-code/+merge/51899 :)
[14:18] <gmb> danilos: Sure.
[14:19] <gmb> danilos: r=me
[14:19] <danilos> gmb, thanks :)
[14:27] <bac> gmb: ugh, bad news.  your change exhibits the *exact* same bad behavior as the accordion.  branch pushed to new location: lp:~yellow/launchpad/accordion-overlay-2
[14:27] <gmb> BUGGER
[14:27] <gmb> bac: OTOH, maybe this means it's *not* the accordion then.
[14:27] <gmb> But something more insidious.
[14:28] <bac> gmb: therve responded on canonical-js
[14:28]  * gmb looks
[14:30] <gary_poster> hm, that sounds promising
[14:30] <gmb> Indeed.
[14:30] <gary_poster> yay for small reproducible bits
[14:30] <gary_poster> and helpful colleagues
[14:32] <bac> gmb: i'm still digesting his suggestion
[14:32] <gary_poster> "But something more insidious" makes me want to hear some Jules Verne and/or Cthulu inspired cause for the JS issues.
[14:33] <gary_poster> squids need to be involved one way or another, I think.
[14:33] <gmb> I once wrote an easter-egg for a webapp that made an ascii-art Cthulhu appear after a certain sequence of mouse-clicks. Wonder if I could reuse it in the accordion...
[14:33] <gary_poster> lol
[14:33] <gary_poster> that would be awesome
[14:41] <bac> gmb: i incorporated therve's suggestion in the minimal example: bzr+ssh://bazaar.launchpad.net/~bac/%2Bjunk/accordion_test/
[14:41] <bac> it seems to work with the accordion!
[14:41] <gary_poster> bac, fwiw I sent a note to Francis asking him to check up on Dav
[14:41] <gmb> \0/
[14:41] <gary_poster> and, YAY
[14:41] <bac> gmb: please sanity check
[14:41] <gmb> bac: Pulling now.
[14:42] <bac> gmb: we'll have to make the corresponding change to lazr-js.effects, no?
[14:42] <gary_poster> challenges with working in a distributed environment: we can't all dance around in a jig in the same room
[14:42] <gary_poster> though maybe that's another advantage...
[14:43] <gmb> bac: Yes, I think that's the case (sadface).
[14:44]  * gary_poster not happy with lazr-js being a stumbling block
[14:45] <bac> gary_poster: but on the upside, once there the animation will just DTRT and no one else using it will have to suffer this problem
[14:45] <gmb> gary_poster: It's a PITA, to be sure. But working together bac and I should be able to get this incorporated therin, reviewed and landed today.
[14:45] <gary_poster> I'm pretty darn happy with both of those :-)
[14:45] <gmb> (me waves hands vaguely about timescales)
[14:45] <gary_poster> :-)
[14:46] <gary_poster> a day, in the biblical creation story sense?
[14:46] <gmb> Hah.
[14:46]  * bac wonders if his original email was really that muddled...
[14:46] <bac> original+1, actually
[14:57] <gary_poster> bac, I'd guess that it was your second, smaller and self-contained code example that got attention, but who knows for sure.
[14:58] <bac> gary_poster: right, but thomas commented even that was terribly confusing.  it got an answer so i'm not fretting.
[14:58] <gary_poster> I see.  ok, cool
[15:08] <bac> gmb: so at a minimum, it seems you need to set visibility to 'none' before trying to get the true height and then set height to 'auto' after animating to 0
[15:08] <gmb> bac: Right. That sounds deceptively simple... is it?
[15:09] <bac> simple and obvious
[15:09] <bac> *of course* making something invisible would force him to not lie about his size
[15:10] <gmb> Heh
[15:10] <gary_poster> :-)
[15:21] <bac> gmb: i'm working on lazr-js now
[15:21] <gmb> bac: Okay. I'll be happy to review it for you.
[15:21] <bac> it's been a while since i've made changes there so i'm trying to remember the steps
[15:21] <gmb> Ah.
[15:21] <gmb> bac: I think deryck's your man if you have questions; I can't quite remember the steps either.
[15:33]  * gmb -> heading out for a run; back in ~45
[16:15]  * gmb returns
[16:33] <gmb> bac: Is there anything I can be doing right now to help you out?
[16:39] <gary_poster> bac, gmb, maybe "wire up widgets to back end data store" that benji started?
[16:39] <gary_poster> wait, no
[16:39] <gary_poster> I think that's done...
[16:39] <gmb> gary_poster: I can take bug 721400 as a job to take me to EoD.
[16:39] <gary_poster> and we need to have a card for adding the internal widgets to each part of the accordion?
[16:40] <_mup_> Bug #721400: Bug:+subscribe can't cope with existing BugSubscriptions with a bug_notification_level of NOTHING <story-better-bug-notification> <Launchpad itself:Triaged> < https://launchpad.net/bugs/721400 >
[16:40] <gmb> (And I'll happily review bac's lazr-js work when it's ready)
[16:40] <gary_poster> gmb, how much work are those three mute button bugs, in your wavy-handed estimation?
[16:41] <gary_poster> I still suspect that the mute table might be a better approach, but if we can whip out those bug fixes, I'm +1 on moving ahead with the existing plan
[16:42] <gmb> gary_poster: I think I could have those done by EoW.
[16:42] <gary_poster> gmb, ok fire away
[16:42] <gary_poster> thanks
[16:42] <gmb> gary_poster: Cool; np.
[16:42] <gary_poster> ideally we would have a feature lane free but you can use quick jobs for now
[16:44] <gary_poster> bac, lemme know if you could use some help, or if gmb continuing as occasional consultant is the right approach.
[16:57] <bac> gary_poster: ok
[16:57] <bac> gmb has been more than that recently and i appreciate it
[17:21] <bac> gmb: i've pushed a new version back to the old spot:  bzr+ssh://bazaar.launchpad.net/~yellow/launchpad/accordionoverlay
[17:22] <bac> it incorporates thomas' suggestions but inside our js, not lazr-js
[17:22] <bac> figured it was easier to get it working there
[17:22] <gmb> bac: I like your thinking. I'll pull it and take a look.
[17:22] <bac> it is better and shows promise but has obvious problems still
[17:22] <bac> my brain is mush so i'm going to go to lunch, despite my pledge earlier today
[17:23] <bac> let me know if you make any progress and i'll pick up later
[18:28] <gmb> bac: I'm somewhat disturbed to find that setting the node's height to 0 when the slide_in ends appears to just work. I'm not sure that that's right or that I'm not actually going to cause other problems though.
[18:28] <gmb> I've pushed my changes (including indentation fixes - sorry for the diff noise; vim corrects it for me automagically) to the ~yellow branch.
[19:05] <bac> gmb: so things seem to work now, despite it being hacky?
[19:06] <gmb> bac: Yeah. I think so, anyway. I also stripped out the collapsible classes since it might have caused the existing collapsible code to fight with it.
[19:06] <bac> ok
[19:07] <gmb> bac: But you may know of more little oddities than I know to look for.
[20:17] <gary_poster> so, bac, where is JS then?  the discussion here seems to imply that everything is copacetic.  Is that true?
[20:17] <gary_poster> where is our JS, I should say
[20:22] <bac> hi gary_poster
[20:22] <gary_poster> hey
[20:22] <bac> what we've been working on is in lib/lp/registry/javascript/structural_subscription.js
[20:23] <bac> the stuff gmb and i did today eventually needs to find its way into lazr-js
[20:23] <gary_poster> makes sense
[20:23] <bac> i'm still getting his branch to see what it looks like
[20:23] <gary_poster> (fwiw, Python structural subscription stuff has moved to lp/bugs, but don't worry about that now)
[20:24] <bac> oh, ok
[20:24] <bac> good to know and easy to fix
[20:24] <gary_poster> cool
[20:24] <bac> it really doesn't fit in either place, does it?
[20:24] <gary_poster> IMO there's nothing to do really with registry, and it is entirely about bug subscriptions
[20:25] <gary_poster> so, while it touches many parts of LP, it's essentially about bugs--if we didn't have a bug tracker but had everything else, these things would go away.
[20:26] <bac> make sense
[20:42] <benji> gary_poster: Style consultation: does http://i.imgur.com/tJmhm.png look enough like https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/SubsListRound1/Slide1 to not worry about any further?
[20:47] <gary_poster> benji, good.  Two things.  1) ask Huw for CSS/changes for the pretty text-over-the-border look. 2) find the edit icon on LP and include it too.  I think it is some funky sprite thing
[20:47] <benji> gary_poster: sounds good
[20:47] <bac> gary_poster: i'm exercising gmb's latest branch and it looks great
[20:47] <bac> i can't make it fail
[20:48] <gary_poster> bac, yay!  yay!
[20:48]  * bac happy
[20:48] <gary_poster> So what's left...we need tests of some sort still I assume, and we need to populate the accordion with the proper widgets?
[21:06] <gary_poster> bac ^^
[21:06] <gary_poster> benji--sorry for the delayed followup, but there's a delete icon to use too.  Let's include that too.  I think it is in some of the other mockups, and it seems like a standard visual thing we do.
[21:06] <bac> gary_poster: yeah, all of that
[21:06] <bac> it needs polish
[21:06] <gary_poster> ok, but things we know how to do, mostly, yeah, bac?
[21:06] <bac> and hooking up
[21:06] <benji> gary_poster: sounds good
[21:06] <bac> famous last words, but yeah, i think so
[21:06] <gary_poster> cool benji
[21:07] <gary_poster> bac, understood :-)
[21:07] <bac> gary_poster: i will do some clean up this afternoon and hand it off to gmb with a list of next things.  if that's what you want.
[21:09] <gary_poster> bac, sounds good to me.  gmb was in the middle of a bug, so I'd be happy for him to get to complete it, but I think it's close if not done already
[21:09] <bac> ok
[21:11] <benji> gary_poster: I copied you on the email to Huw, I don't know if that's something you generally want or not, so you'll have to tell me to stop ;)
[21:12] <gary_poster> benji, I like it, please continue. :-)
[21:12] <benji> k
[21:23] <bac> gary_poster: we still have the outstanding design issue of the twisty arrow placement
[21:24] <gary_poster> bac, yes.  AIUI benji and Huw are working on that.  My hope is that the resolution won't be too far from the checkboxy thing
[21:24] <gary_poster> (So significant work will not have to be redone)
[21:24] <bac> ok
[21:24] <gary_poster> I'm just being optimistic, I guess, bac. :-/
[21:26] <benji> by way of status update: I got an email from Huw yesterday morning asking some clarifying questions which I replied to immediately; nothing more yet.
[21:39] <gary_poster> right benji, thanks
[21:55] <bac> interesting, closing the overlay causes some of the items to be left behind, imprinted on the underlying web page.  oops.
[22:00] <gary_poster> :-/
[22:03]  * gary_poster is out.  ttyl