=== palhmbs_ is now known as palhmbs [10:03] Good morning, everyone. :) [10:22] o/ [11:59] hola gente === teknico is now known as teknico_away [12:31] nessita: ping [12:31] mandel: pong [12:32] nessita: heelo, I was wondering if you could give me a hand with sso client, I'm getting gconf issues when running the tests [12:32] it seems that the dbus seession is not working (I'm testing on M) [12:32] mandel: what kind of issues? [12:32] nessita: let me patebin it [12:32] mandel: sure [12:33] * mandel reruns tests [12:34] can I have a second review for https://code.launchpad.net/~evfool/ubuntuone-control-panel/tooltips/+merge/51838 ? (is trivial) === teknico_away is now known as teknico [12:38] good morning! [12:39] nessita: I got it! [12:39] thanks [12:40] nessita: this is mainly what i get paste.ubuntu.com/574422 [12:41] mandel: ah, that's ok, we've always had that [12:41] I thought you were having crashes [12:42] nessita: oh, really? heh I worried for nothing then [12:42] :-) === teknico is now known as teknico_away [12:59] nessita: how are you feeling about adding a platform module in ubuntu_sso? [12:59] mandel: if it'll work as is working in syncdaemon, pretty bad :-) is very annoying the way it is. What modules do you need to replace? [13:00] nessita: so far, keyring and networkstatus at least [13:00] nessita: why it it bad in sd? [13:02] mandel: from my point of view, is very annoying an confusing to have to code some things inside platform and some other inside the regular syncdaemon dir. It breaks any grouping we can make about related components [13:02] O_o [13:03] mandel: to explain what I've said, imagine you want to use some automatic drawing tool to draw the module depenencies [13:04] mandel: by how it's right now, you will get a diagram that does not reflect the truth (at design level I mean). You'll end up with separated modules that are separated just becasue the platform stuff [13:06] mandel: does that make sense? we can try to think alternatives [13:06] mandel: for instance, if we already have a module graph like: [13:09] mandel: http://pastebin.ubuntu.com/574435/ [13:10] mandel: I think we need to maintain that same graph structure when migrating code to be multiplatform [13:12] mandel: let me know when you're here [13:13] nessita: I'm here, I'm just thinking :) [13:16] mandel: so, what about something like: [13:17] mandel: if you need the keyring moduke to have different implementations, I would: [13:17] * mkdir keyring === alecu_ is now known as alecu [13:17] * bzr move keyring.py keyring/linux.py [13:18] nessita: I have no issue for the garph since for me both are correct, I do have issues in the way that patching has been implemented [13:18] * create a keyring/windwos.py [13:18] nessita: I have done that atm, that's why I know that it complicates the testing alot [13:18] * create a keyring/__init__.py that import stuff from linux or windows properly [13:19] nessita, that does not scale [13:19] nessita, you would need the code to import from linux or windows for each platform dependent module. [13:19] mandel: if it complicates testing let's resolve that, but let's no break our "module design graph" just because testing is harder [13:19] alecu: I'm not follwoing you [13:20] nessita: when testing is hard, something smells [13:20] mandel: yes. Most likely testing is being done the wrong way [13:20] and also, that needs each module to have a different python package, and only one platform dependent module. [13:21] alecu: really, I don't see how what you've say apply to what I've said :-) [13:21] nessita, I mean that you would need the __init__ that selects from linux or windows for each platform python package. [13:22] alecu: you will need the __init__ for each *python module* that you need to have 2 (or more) implementations [13:22] no python package [13:23] nessita, in keyring/__init__.py, "keyring" is a package. [13:23] mandel: can you please give me an example of a testing problem with that structure? [13:24] alecu: yes, but I was saying that you only need to transform each (currently being) module that needs more than on impl [13:24] alecu: and usually, and specially using python, those will be very little [13:24] nessita: sure, one sec [13:26] alecu: I think that providing multiplatform solutions for ussoc (in particular) should not change the current module dependency diagram (module as in UML lexic) [13:26] nessita, also: if we do things one way in syncdaemon, I think it is more harder to learn/maintain if we do it totally differently in other parts. [13:27] alecu: I agree for projects inside U1 client, and I thought about that. This is ussoc which is a separated, independent project from u1client [13:27] alecu: I honestly think that having the new platform package breaks good design and under stability of the implementation [13:27] nessita: line 164 in test_keyring, when you patch the secrets object [13:28] I meant understability, if such word exists :-) [13:28] understandability [13:28] :-) [13:28] mandel: looking in one sec [13:28] alecu: do you know wich error is raise when the secrets dbus api is not present? [13:28] alecu: what happens if dbus starts working on windows? [13:28] Well for practical purposes, it's maintained by the same set of people! :-) [13:29] alecu: you will need to break apis because you no longer will have from ubuntuone.platform.bla [13:29] nessita, afaik it already does for some kde apps. [13:29] (kde apps on windows) [13:29] alecu: or you don't break APIs and leave the same implementation in the platform module which is missleading [13:30] nessita, ubuntuone.platform.bla are not APIs, they are internal modules [13:30] only our code is supposed to be using that. [13:30] nessita: it would be from ubuntuone.platform import [13:30] alecu: no, is API [13:30] using ubuntuone.platform.linux should be not done [13:30] nessita, in what cases it's API? [13:30] mandel: I never said linux ;-) [13:31] alecu: using the dbus interface constants, for instance [13:31] nessita, what 3rd party software uses those APIs? [13:31] alecu: our control panel broke [13:31] alecu: rye's indicator surely uses the dbus module [13:31] magicicada [13:31] nessita: control panel was using a function that started with _ [13:32] and the dbus api was kept and not touched [13:32] nessita, if those are DBus constants, they don't belong in a python file. [13:32] mandel: that was a test. I'm talking about real functions [13:32] alecu: dbus constants and more [13:32] nessita: example? [13:33] nessita, the only way to define DBus constants is in a documentation file, because other programming languages using DBus won't be able to access constants in python files. [13:33] nessita, what more? [13:33] mandel: don't have one handy. But anyways, I fell pretty strong about not changing the module dep graph, so let's sort your testing issue out [13:34] alecu: we were using the dbus module itself. We were using the tools module, to use SyncdaemonTool which is meant to be use as a helper [13:34] alecu, mandel: I already said this with u1client, let's keep the approach that os.path use [13:34] that's clean and usable [13:35] it makes no sense to do: from os.platform.path import mkdir [13:35] the fact that we need 2 implementations for path should be hidden from APIs [13:36] mandel: browsing your code now [13:36] nessita, if the problem is the tools module, then you should have had an empty tools module importing that linux module. [13:36] nessita: which code? [13:36] nessita, and also you don't do "from os.platform.path import mkdir" [13:37] I mean [13:37] alecu: exactly, you don't [13:37] alecu: in syncdaemon you have to do that [13:37] you don't do "from ubuntuone.platform.linux import module" [13:37] nessita, you do "from ubuntuone.platform import module" [13:37] alecu: no, you do: "from ubuntuone.platform import module" [13:37] nessita: the example is in trunk, when you patch secrets [13:37] exactly! [13:37] from my POV, no "platform" word should be needed [13:38] so, the platform dependent stuff is hidden. [13:38] alecu: is not. You are exposing the fact that, for now, dbus is platform dependatn [13:38] alecu: what happens when dbus is not platform dependant? [13:38] nessita: never is going to happen [13:38] mandel: is an example [13:38] dbus will not be in windows, as the keyring [13:39] mandel: you can't ensure that :-) [13:39] mandel: what's the problem with patching the SecretService? [13:39] anyway: I don't like building for something that's not there yet. [13:39] nessita, ^ [13:39] alecu: if we're starting fresh, let's do it properly [13:39] nessita, let's build what's needed right now. And let's do it in a predictable way. [13:40] alecu: I agree. [13:40] what's needed right now is 2 implementations for the keyring and for NMstate [13:40] making those modules be packages with 2 implementations is easy and clean [13:40] and no API at all will be broken [13:41] nessita: when you patch, you are patching the imported module by the keyring, but that could not be right once you mov the code to linux [13:41] mandel: right, but those tests are the linux tests :-) [13:41] mandel: since you just said that keyring will have 2 implementations, there will be 2 sets of tests [13:41] mandel, read in twitter you've been fixing the python keyring module, right? [13:42] mandel, did you know that that module is horribly broken on linux? [13:42] alecu: yes, delete is present, we are also looking at using secrets on linux to fix some issues [13:42] AlanBell: funny enough the mantainer is from canonical hehe [13:43] nessita: I'll look at fixing those tests.. [13:43] mandel, also, that module is not complete.... some functions are only async, some are only sync... [13:43] mandel, how do you plan on doing the keyring access on windows? sync or async? [13:44] sup? [13:44] * alecu supposes his lastname changed to Bell recently. [13:44] AlanBell, I think mandel meant me. [13:44] alecu: atm is sync, but I'm planning of do both, since the encription could be slow on windows [13:44] ah [13:45] * AlanBell goes back to sleep [13:45] AlanBell: hehe stupid tab completion, sorry [13:45] mandel, assume all keyring operations are slow, because the user may always need to enter a password to unblock it. [13:45] alecu, mandel: I'm open to explore other solutions to implement the multiplatform stuff, but creating a new package platform is, from my POV, a not clean nor clear way of doing it. So maybe my solution is not the proper one, but I would say we should mimic what python itself does with, for example, os.path [13:46] ok, water is about to biol, brb [13:46] mandel, even deletes or simple keyring queries. [13:46] * alecu returns to eclipse [13:47] alecu: yes, why not, lets be consistent :) [13:50] standup in 10' [13:52] * nessita is back with mate [13:52] mandel: so, I'm lost. How are we approaching multiplatform stuff in ussoc then? [13:53] nessita: as you say, I have no problem, I'm atm fixing the tests and adding the -i to the runtest script [13:54] mandel: ok, I'll be happy to help (at least with reviews, my time is a bit tight this week) [13:55] nessita: cool, I'll ping you if needed [13:56] mandel: sure [13:58] dobey: ping [13:58] yes? [14:00] me [14:00] dobey: hey, question. What projects should I assign this bug to? bug #726871 [14:00] me [14:00] Launchpad bug 726871 in ubuntuone-control-panel (Ubuntu) "Ubuntu One Music Store syncing not on by default (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/726871 [14:00] me [14:00] me [14:01] ralsina, dobey, say me please! :-) [14:01] me [14:01] thisfred: would you please? [14:01] DONE: Worked on Bug #702183, Bug #702176, Bug #702172 [14:01] TODO: Finish on Bug #702183, Bug #702176, Bug #702172 [14:01] BLOCKED: no [14:01] LOVED: http://tinysong.com/3qpb The Antlers - Bear [14:01] NEXT: nessita [14:01] DONE: bug #706034, bug #720650. Chat with cparrino re: control panel UI. A lot of bug status update in u1cp, finally got every single bug reviewed and tagged. [14:01] TODO: meeting with ralsina and cparrino for u1cp UI and string review. Kill more u1cp UI bugs! talk about multiplatform issues in ussoc. [14:01] BLOCKED: nopes [14:01] NEXT: alecu [14:02] DONE: getting OAuth tokens from SSO (with hardcoded username/password), and storing in Droid pref storage (bug #725290). [14:02] TODO: UI to ask for user/pass, same bug [14:02] BLOK: not [14:02] HATE: went thru OAuth hell to finally find out that http requests cannot be signed twice by signpost. Found a workaround, got back. [14:02] LOVE: los tostados del Beltrán [14:02] NOTE: working across the river today, so will be out during my afternoon for bank issues, and will be online later after getting back home. [14:02] NEXT: mandel [14:02] Launchpad bug 702176 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to add an entry to the messaging menu when a folder shared to the user exceeds the owning user's quota (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702176 [14:02] Launchpad bug 702172 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to send a notification when a folder shared to the user exceeds the owning user's quota (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702172 [14:02] Launchpad bug 702183 in ubuntuone-client (Ubuntu) (and 1 other project) "Syncdaemon needs to open the control panel in the background and change the launcher icon to urgent when the user exceeds their quota (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/702183 [14:02] Launchpad bug 706034 in ubuntuone-control-panel (Ubuntu) (and 2 other projects) "Get a better icon for the folder owner in the Cloud Storage panel (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/706034 [14:02] Launchpad bug 720650 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "Folder for music I've purchased from the U1 store is not shown cleanly (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/720650 [14:02] Launchpad bug 725290 in droidcouch "Get valid OAuth tokens for the logged in user (affects: 1) (heat: 7)" [High,In progress] https://launchpad.net/bugs/725290 [14:02] DONE: bug triagging, bug #684967, bug #684978, bug #727680. Ptched python keyring to allow the removal of passwords. [14:02] TODO: sort out ubuntu-sso-client tests. Move to next sso erro on windows [14:02] BLOCKED: no [14:02] ralsina, go [14:02] Launchpad bug 684967 in ubuntu-sso-client "SSO does not provide a way to use a keyring according to the platform (affects: 1) (heat: 2)" [Medium,In progress] https://launchpad.net/bugs/684967 [14:02] Launchpad bug 684978 in ubuntu-sso-client "There is no Windows keyring implementation (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/684978 [14:02] Launchpad bug 727680 in ubuntu-sso-client "There is no network status implementation on Windows (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/727680 [14:03] DONE: 5 calls (4 hours total), few reviews, hotel hunting, taxes, canonicaladmin, etc [14:03] me [14:03] gah [14:03] TODO: 2 or 3 calls, reviews, bugfixing, scheduling [14:03] BLOCKED: no, tired [14:03] don't ask me a question and then tell everyone to post their standup status [14:03] dobey [14:03] λ DONE: flights booked, music store testing, [14:03] λ TODO: bug #727556, bug #727558, mp3 install in banshee [14:03] λ BLCK: None. [14:03] Launchpad bug 727556 in libubuntuone "u1ms: links don't open unless store already loaded (affects: 1) (heat: 6)" [High,Confirmed] https://launchpad.net/bugs/727556 [14:03] Launchpad bug 727558 in ubuntuone-music-store (and 1 other project) "Need to notify user when Purchased Music folder is not subscribed (affects: 1) (heat: 6)" [Medium,Confirmed] https://launchpad.net/bugs/727558 [14:03] thisfred: hey! you will be able to bug several bombillas while in buenos aires! [14:03] buy* [14:03] or bug :) [14:03] hehehe [14:04] ralsina: no comments on this side, meeting with cparrino in 5 [14:04] thisfred: bugs you don; t buy, you catch :-) [14:04] I want a pet chicharra [14:05] thisfred: not chicharra season :-) [14:05] a dead pet chicharra? :) [14:05] That can be arranged :-) [14:05] I wonder if they're bigger than the crazy bugs we have here in the park [14:05] probably [14:05] about the size of your thumb (ok, of my thumb) [14:06] ah same then. Maybe it's the same insect too [14:06] a chicharra is a cicada, I think they are all the same [14:06] right [14:06] more or less [14:06] well the european ones are tiny [14:06] ok eom? [14:06] and not nearly as loud [14:06] eom [14:07] oh, the ones here are loud alright :-) [14:07] eom! [14:08] ralsina: do we have hotel yet? (pure curiosity) [14:08] it's the ones in egypt that you really have to watch out for [14:08] nessita: not decided, but surely there will be a hotel ;-) [14:09] dobey: so, any ideas about the bug I mentioned? [14:09] dobey: shall I assign it to ubuntuone-music? [14:09] nessita: i moved it and marked duplicate [14:09] dobey: thanks! [14:09] dobey: next question: would you know how to make a LinkBUtton 'look' like a regular button but keep functioning like a linkbutton? [14:10] in GTK, of course [14:10] Hey, word from Marianna, it's probably going to be http://www.hoteldelcasco.com.ar [14:10] a link button? [14:10] thisfred: has a great artisans fair across the street [14:10] oooh nice [14:10] thisfred: so you can buy bombillas ;-) [14:11] I checked the link before, looks like a very nice hotel [14:11] nessita: why not use a regular button? [14:11] thisfred: it is really nice. [14:11] And the area is really nice in general. One block from a cathedral, there'sa restaurant zone 2 blocks away, and really peaceful except on sundays [14:11] ralsina: I hate you for providing a link to a webpage that starts playing a song when I open it [14:12] specially elevator music [14:12] mandel: come on, Gershwin is not elevator music [14:12] mandel: http://html5zombo.com [14:13] dobey: I hate you tooo [14:13] that extra o is how much extra hate i have [14:13] ralsina: when you visited that hotel, was there Sinatra playing constantly? [14:13] dobey: I could, yes, but I was hoping to actually use a linkbutton since that's the functionality I need [14:14] mandel: WELCOME! to zombocom [14:14] the infinite is possible at zombocom [14:14] nessita: it's more code to use a link button and make it look like a normal button, than it is to use a normal button and make it open a link [14:15] dobey: right, thanks. I wanted to confirm exactly that. [14:15] (maybe I was missing something) [14:16] nessita: just do button.connect_swapped ("activate", gtk_show_uri, uri_string) [14:16] weird, got notification about my nick mentioned but can't find who/when :-/ [14:17] nessita: and it should do what you want [14:17] rye: 08:31 < nessita> alecu: rye's indicator surely uses the dbus module [14:17] aha, dobey, thanks! [14:17] alecu, nessita, what about dbus module? [14:18] yeah, /lastlog is win :) [14:18] rye: nothing important [14:18] dobey, oooh, shiny! [14:19] thisfred: can you please join #ubuntu-desktop? [14:19] suret thing [14:23] nessita: eh, why? :) [14:23] thisfred: oh, did seb not contact you? :-/ [14:24] nope === teknico_away is now known as teknico === zyga is now known as zyga-food [14:59] ralsina: would you please file me a bug in u1cp to improve the services tab installation workflow? [15:00] ralsina: https://bugs.launchpad.net/ubuntuone-control-panel/+filebug :-) [15:00] nessita: on it! [15:00] yey! [15:00] ralsina: FYI, that will be done after UI freeze (probably during the sprint) since is not an UI bug (but a workflow bug) [15:00] nessita: cool [15:01] ralsina: actually, there is a bug for it already bug #726865 [15:01] Launchpad bug 726865 in ubuntuone-control-panel (Ubuntu) "Installed desktopcouch to enables services: confusing error and no functionality (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/726865 [15:01] (I just saw jono's bug) [15:01] I'll affect u1cp project [15:01] so let's use that [15:01] yes [15:02] ralsina: can you please add a comment stating the change of the workflow? :-D [15:02] * nessita is pedigüeña today [15:06] es, hoy [15:09] dobey: está, hoy ;-) [15:13] Ok, I just broke my home's lock [15:13] be back after I find a locksmith [15:17] Argh, how do I deduplicate a bug? [15:17] can you just leave the field blank and hit ok? [15:18] Oh, found it, thanks [15:27] hey, unity-2d has the progressbar too now :-) [15:32] ralsina, cool. [15:32] ralsina, is syncdaemon updating it as well? [15:37] alecu: yes [15:37] alecu: noticed it when syncing a folder [15:37] I want that! [15:37] dobey: any news on having icons without the -gnome package installed? [15:38] nessita: install unity-2d then :-) [15:38] ralsina: I don't have the U1 icon in the launcher, that's my problem :-) [15:39] add it! [15:39] nessita: not yet [15:39] ralsina: is added! I have the entry but iconless, so I have a big question mark for it [15:39] so no progress bar for me [15:39] weird [15:40] OTOH I was running controlpanel, so maybe that's why I had the icon [15:40] ralsina: no no. To understand my point, uninstall ubunutone-client-gnome. You'll get the U1 entry in the launcher iconless [15:41] :-) [15:41] nessita: oh, that [15:41] dobey: FYI, setting 'border-relief' to 'half' gives me a linkbutton that looks like a regular button [15:41] I am triaging bugs in -client-gnome so no ;-) [15:41] hehe [15:41] ok [15:42] nessita: well setting the relief to 'normal' it would look more like a regular button that it does by default, but it still doesn't look right [15:42] dobey: having relief in normal looked exactly like relief in None [15:42] only half will show the button border at all times [15:43] nessita: either way it is better to use a normal button i think [15:43] dobey: why? [15:43] (real interest here) [15:43] because the underline and coloring of the link button look out of place [15:44] i don't know why linkbutton was even put into gtk+ as it is. it makes no sense to me to have it there === zyga-food is now known as zyga [16:24] lunch time [16:42] nessita: this is the scrollbar thing I mentioned in the call: http://ubuntuone.com/p/fmd/ [16:44] ralsina: yeah, I saw it. Can you please file a bug for u1cp, attaching the screenshot? I'm about to have lunch and I don't want to drop that package :-) [17:01] lunchtime! === beuno is now known as beuno-lunch [17:11] nessita: alecu: so for the quota notifications/messages/popups: we need to know when a volume that is exceeding quota is a share *from* another user. What is the best way to determine whether it is, do you guys know? [17:14] I have a dictionary like this: {'name': '', 'subscribed': '', 'generation': '', 'other_username': '', 'other_visible_name': '', 'access_level': u'View', 'node_id': '', 'volume_id': u'fake share id', 'free_bytes': '0', 'path': '', 'accepted': '', 'type': u'Share'} (but then with more values filled in presumably ;) [17:15] Or does Share mean it's *always* from another user? [17:15] I guess so huh [17:16] anything I share would just be a folder in my root or a UDF [17:16] as you were ;) [17:16] * thisfred loves these socratic monologues we have [17:21] thisfred, yes, Shares are always from another user [17:21] coolness that eliminates a lot of logic :) [17:21] thisfred, ShareD are from you to another user, but they won't push that event. [17:22] I guess only the Root folder may push the event anyway. [17:25] right, I was wondering about root, but that should be easy to distinguish right? By node_id or something? [17:25] anyway, steaming on [17:31] thisfred: yes, sorry I was having linch [17:31] lunch* [17:32] Yeah better if the technical lead doesn't actually lynch people ;) [17:33] :-D [17:36] ok, I need to reboot after updates [17:36] brb [17:46] alecu: last question: you mentioned that we probably want to throttle the frequency of quota messages/notifications/popunders to once a day. That [17:47] s not happening elsewhere already or is it? [17:47] I mean for other statuses [17:48] thisfred, I believe it's already happening for the out-of-quota dialogs that are shown from gsd-plugin. [17:48] thisfred, the throttling to 1/day. [17:48] ah ok, I'll look there. In which package do they live? [17:49] thisfred, beware: that's a gnome-settings-daemon plugin, made with C... it's in u1-client/gsd-plugin [17:49] alecu: I'll probably be fine if I just read the code. If I'm not back in two days, send an exorcist ;) [17:50] jejejee [17:54] ok, the reboot was painful :-( [17:54] thisfred, probably you'll want to set up a status.aggregator.Timer instance, and not show the message again if the timer is still active. [17:58] thisfred, and to see if the timer is still active, create a new method "is_active" in Timer that calls self.delay_call.active() [17:58] alecu: cool, thx [17:58] np! [17:59] well, it looks like I need to catch a boat... [17:59] sea you later, alligators! === beuno-lunch is now known as beuno === zyga is now known as zyga-afk === karni_ is now known as karni [18:41] sorry, I had irc-lag, let me repeat the question [18:41] beuno: I see quite a few handshake timeouts in your log. Should increase the timeout from 30 seconds? One question - was this log submitted from the last link I gave you? I didn't bump the version number, and I don't see the Storage Management piece I was interested in :( I also used your log to detect 2 idle-timeout bugs, so I'm happy we caught that. [18:42] karni, I'm not sure what I'm running anymore :) [18:42] beuno: would this be a problem if I gave you a new apk to run? [18:42] I'd like to see those numbers to fix the 'total space' bug that you have [18:42] as I recall [18:43] karni, not at all [18:43] I'll bump the version number correctly this time. [18:43] karni, just email it to me, it's easier to install that way [18:43] beuno: sure, thanks! === ivanka is now known as ivanka-train [19:00] beuno: sent apk via e-mail [19:09] thanks karni [19:11] can I have reviews please? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/regular-buttons/+merge/51941 [19:11] (trivial) [19:11] nessita: lo tengo [19:11] ok, I'll restart on classic desktop now [19:18] ok, this should be better now [19:18] ralsina: button design was given. I don t like it as well [19:19] ralsina: was also approved by cparrino [19:19] did you mention the alignment? [19:19] ralsina: I can't align the label only to the left, but only making the whole button small and align that to the ledt [19:19] left* [19:20] hmmm... I meant that if it'sgoing to be large, it should align with the label and the other buttons. Or the labels with your name should not be indented [19:21] ralsina: the name is supposed to be inside the personal details [19:21] ralsina: can you please check the account.png and account2.png in the email Daniel sent? [19:21] sure [19:21] ralsina: subject is: [19:21] U1, front screen [19:22] Ok, so it did came from design. [19:22] yes [19:22] Ok, let's accept they know what they are doing in taste matters, so +1 === zyga-afk is now known as zyga [19:22] ralsina: I will change the name, I just noticed it should read 'Edit account details' [19:23] Ok, I'll hold the approve [19:23] Also, Daniel's image doesn't have the text underlined. That looks kinda weird in a "normal" button. [19:24] ralsina: but is a linkbutton! it will take you to a browser [19:24] Yes, I know. [19:25] ralsina: a completely regular button is not supposed to take you to a browser [19:25] That's why I don't ask you to change it :-) [19:25]