| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| gary_poster | bac benji danilos gmb mumble/kanban in 2 followed by weekly deliverable review | 13:29 |
|---|---|---|
| gary_poster | well, in 1 now | 13:29 |
| bac | ok | 13:29 |
| danilos | ack | 13:29 |
| gmb | ack | 13:29 |
| gary_poster | benji yoohoo | 13:30 |
| benji | gary_poster: you asked about the sprites, here's the latest iteration of the page: http://i.imgur.com/vM6bn.png | 14:09 |
| gary_poster | benji, beautimus. Only suggestion: make "Edit this subscription" and "Unsubscribe" on the same line, as it is in the mockup. | 14:21 |
| benji | gary_poster: I'm back | 14:27 |
| benji | it took me a minute to figure out what you were talking about, I thought you were having a stroke or something | 14:28 |
| gary_poster | heh | 14:28 |
| gary_poster | benji, I prefer the side-by-side for a number of non-defensible reasons. The only mildly defensible one is that it is what the approved mockup did, but I don't regard those as gospel. So, I'm +1 on side-by-side, but won't throw my weight around because I don't feel I have the expertise or the arguments to do so. | 14:30 |
| benji | I'm cool with that. One line it is. | 14:31 |
| bac | gmb: do you know of a js module that is nicely tested i could look at? | 14:32 |
| gary_poster | cool | 14:33 |
| gmb | bac: lib/lp/bugs/javascript/tests/test_bug_subscription_widget.js is pretty comprehensive. | 14:33 |
| gary_poster | The bac, he is gone | 14:34 |
| gmb | Yep. | 14:34 |
| * gary_poster was so bothered by the itch on his memory that he had to look up the fact that his brain was alluding to "Mistah Kurtz, he dead" from Apocalypse Now. Ah, the weirdnesses of brains. Or mine, at least. | 14:50 | |
| gary_poster | or maybe it was the book | 14:50 |
| gary_poster | Heart of Darkness | 14:50 |
| gary_poster | anywayyyyyyy | 14:51 |
| gary_poster | hey danilos, lemme know the bug number for the "make jsbuild" problem when you file it so I can put it in notes please | 15:15 |
| benji | http://en.wikipedia.org/wiki/Heart_of_Darkness#Motifs | 15:16 |
| gary_poster | The horror! The horror! | 15:17 |
| gary_poster | Good book | 15:17 |
| danilos | gary_poster, will do | 15:32 |
| gary_poster | thank you | 15:32 |
| gmb | gary_poster: Indeed. Been quite some time since I read that; I think it's on my list-of-books-to-get-a-kindle-version-of | 15:32 |
| gmb | gary_poster: Separately, I've just submitted a holiday request for 2011-03-25. | 15:32 |
| gary_poster | been awhile for me too. | 15:32 |
| gary_poster | thanks for heads up; will go approve | 15:33 |
| gmb | Ta | 15:33 |
| gary_poster | (bac not here), gmb, danilos, benji, I meant to check on the call if the schedule for the daily meeting and weekly meeting was still working out OK for everyone. I particularly was thinking of gmb and danilos because of their lunch, but all of us are having the call at somewhat unusual times. S'alright? | 15:33 |
| gmb | gary_poster: It works fine for me; I have lunch 12 - 1 anyway :) | 15:33 |
| danilos | gary_poster, yeah, it's good, and the time I'd like wouldn't really work for anyone else :) | 15:33 |
| benji | I like it. | 15:33 |
| gary_poster | :-) k | 15:33 |
| gary_poster | cool. (me too) | 15:33 |
| gary_poster | heh, danilos. ok cool guys, thanks | 15:34 |
| gary_poster | approved gmb | 15:34 |
| gmb | Thanks. I've added it to the LP team calendar. | 15:34 |
| gary_poster | great | 15:34 |
| * gmb -> run | 16:35 | |
| gmb | ] | 16:35 |
| danilos | gary_poster, hey, do you think you can review https://code.launchpad.net/~danilo/launchpad/bug-720826-links/+merge/52226? | 17:18 |
| gary_poster | looking danilos | 17:18 |
| danilos | gary_poster, it's measly 131 lines of diff :) | 17:19 |
| gary_poster | danilos, :-) I'll do it, looking | 17:19 |
| danilos | gary_poster, cheers :) | 17:19 |
| gary_poster | danilos, not done, but I'd like to see a test showing the fact that multiple filters carry over | 17:22 |
| danilos | gary_poster, there are unit tests for that in other branches | 17:23 |
| danilos | gary_poster, let me find them :) | 17:23 |
| gary_poster | :-) k | 17:23 |
| gary_poster | danilos, very happy that the structuralsubscription.py could be that small. That's what I was hoping for. | 17:24 |
| danilos | gary_poster, "-t test_header_multiple" | 17:24 |
| danilos | gary_poster, I am unsure about the distinct, perhaps I can remove it now? | 17:24 |
| danilos | gary_poster, tests pass either way, but simply because python code checks for duplication anyway | 17:24 |
| gary_poster | danilos, agree, remove the distict=True. It made sense without the filters, but not so much now | 17:25 |
| gary_poster | danilos, approved. Yay! | 17:30 |
| gary_poster | I didn't chage the status--figured you could do that after you removed distinct=True | 17:31 |
| gary_poster | I hope this does not add a performance hit--adding a record for every filter | 17:32 |
| gary_poster | a noticeable performance hit, I mean, of course | 17:32 |
| gary_poster | we'll see :-) | 17:32 |
| danilos | gary_poster, thanks, and done :) | 17:32 |
| gary_poster | aesome | 17:32 |
| gary_poster | w | 17:32 |
| danilos | gary_poster, yeah, we'll have to check that, but it's mostly going to be serialization cost, and my experience is that that is not too bad | 17:33 |
| gary_poster | ok cool | 17:33 |
| === Ursinha` is now known as Ursinha | ||
| === Ursinha is now known as Ursinha` | ||
| bac | hi benji -- can i ask you a question about gnome keyring and lplib? | 19:07 |
| benji | bac: sure | 19:07 |
| bac | i think i have an old key for launchpad.dev lplib access | 19:07 |
| bac | but in seahorse i don't see anything to do with lplib | 19:07 |
| bac | should i be looking elsewhere? | 19:07 |
| bac | i need to find the old key and delete it so i can recreate a new one | 19:08 |
| bac | hmm, perhaps i am wrong | 19:09 |
| benji | bac: look in ~/.launchpadlib/api.launchpad.dev/credentials | 19:09 |
| bac | benji: yeah, i just did. i thought those had moved to gnome keyring | 19:09 |
| bac | anyway, i found it there and deleted. problem solved. | 19:10 |
| benji | new credentials use the keyring lib, but the old ones are still honored | 19:10 |
| benji | cool | 19:10 |
| bac | i just recreated and it was put into .launchpadlib not the keyring | 19:12 |
| bac | bbiab | 19:55 |
| gary_poster | thank you bac | 19:56 |
| gary_poster | bac, btw, did you see that gmb replied about good js tests this morning when you were offline? If not can dig it up for you or it is in the logs | 19:57 |
| === benji___ is now known as benji | ||
| bac | gary_poster: i did not see his reply | 20:31 |
| bac | i can look at the log. thanks for letting me know | 20:31 |
| bac | btw, i've made good progress adding more wiring to the work benji had done | 20:31 |
| gary_poster | np bac. it was "lib/lp/bugs/javascript/tests/test_bug_subscription_widget.js is pretty comprehensive." fwiw. more wiring: great | 20:32 |
| === Ursinha` is now known as Jorjao | ||
| === Jorjao is now known as Ursinha` | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
