| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| bac | hi gmb | 12:44 |
|---|---|---|
| gmb | Hi bac | 12:44 |
| bac | gmb: do we prefer Y.Event.simulate over the other ways to do mouse-y type things in yahoo.utils.actionblah? | 12:45 |
| gmb | bac: As far as I know, yes. That's what I've used in the past. | 12:46 |
| bac | ok, i was about to head down the other path when i looked and saw no uses of it. made me wonder if simulate was new-and-improved | 12:46 |
| gmb | bac: IDK; It's fairly straightforward to use though, IIRC. | 12:47 |
| gmb | bac: Also, sorry I didn't ping you again last night; I got sidetracked with home stuff so I didn't get a chance to carry on with the overlay investigation. | 12:47 |
| bac | np. any chance you can make some progress today? | 12:47 |
| gmb | bac: I'll take a look at it again after standup; I'm working on mute button cleanup atm and don't want to switch just yet. | 12:47 |
| bac | understood | 12:48 |
| bac | gmb, sorry to bother you again but i remembered the blocker i had at EOD | 12:48 |
| bac | in tearDown, how do i clean up stuff that i've inserted into the DOM? | 12:49 |
| bac | i want to ensure i start with a clean slate but subsequent tests already have the accordion in them | 12:49 |
| bac | i tried 'delete this.content_node' where c_n is as you'd expect, but it didn't do anything | 12:49 |
| gmb | bac: That's a tricky one, IIRC. You could do something like: | 12:50 |
| gmb | this.content_node.get('parentNode').removeChild(content_node); | 12:51 |
| bac | ah, good one | 12:51 |
| bac | i'll give it a try | 12:51 |
| gmb | Cool. | 12:51 |
| gary_poster | halloo | 13:28 |
| gary_poster | bac benji gmb mumble/kanban in 2 | 13:28 |
| gmb | Yup | 13:28 |
| bac | rt | 13:28 |
| bac | gmb, the messages from Y.log() that arrive in my browser console seem to be all jumbled. should it be expected that they appear out of order? | 14:44 |
| gmb | bac: Only if they're part of functions that are being called asynchronously. | 14:44 |
| gmb | Are they consistently in the same wrong order? | 14:44 |
| bac | yeah | 14:44 |
| bac | and it looks like tearDown is being called before the method i'm trying to test completes | 14:45 |
| gmb | ! | 14:45 |
| bac | gmb: so i'm wondering if having the 'domready' in my JS is causing loads of problems | 14:45 |
| gmb | bac: Can you push your latest changes so I can take a look? I've had problems with asynchronicity in tests before now; usually you have to do some dancing around to fix it. | 14:46 |
| bac | gmb: sure | 14:46 |
| bac | it is riddled with Y.log statements | 14:46 |
| gmb | Sounds like one of my tests. | 14:47 |
| bac | gmb: pushed to lp:~bac/launchpad/yellow-accordionoverlay | 14:48 |
| gmb | Okay. Grabbing it now. | 14:48 |
| bac | gmb: have you seen these? http://www.bhphotovideo.com/c/product/752638-REG/Canon_Mugs_NK3212_Nikon_70_200mm_Vacuum_Insulated.html | 14:49 |
| bac | makes me wish i had a need for one | 14:49 |
| * bac eagerly awaiting the UPS man today... | 14:49 | |
| gmb | :) | 14:49 |
| gmb | bac: Can you give me an example of a test where the .log() messages are jumbled and what you expect them to look like? | 15:16 |
| bac | gmb: test_logged_in_user fails, then the tearDown is called, then you get "yoohoo" my message from within setup | 15:17 |
| * gmb looks | 15:17 | |
| bac | so tearDown is removing the DOM elements before setup gets a chance to work on them | 15:19 |
| gmb | bac: Right. Your problem is that you've got that on('domready' ...) bit, which is asynchronous, so your test completes before the domready event fires. | 15:24 |
| gmb | Ah, race conditions. Love 'me. | 15:24 |
| gmb | *'em | 15:24 |
| gmb | bac: I'm not sure how to work around this one, though, unless you extract the stuff that's in on('domready') from setup(), make it into a function on its own and call that instead of setup(). | 15:25 |
| bac | gmb: so even if domready is true, that bit will be pushed into a separate thread | 15:25 |
| bac | gmb: i was already thinking of testing the innards separately as you describe | 15:25 |
| gmb | bac: Yes. I think that if you register a handler after an event has taken place YUI has basically got to go and check that the event has actually fired. I'm honestly not sure how nesting handlers of the same event will behave. | 15:26 |
| bac | gmb: can i remove the domready and just make it a requirement on the caller? | 15:26 |
| gmb | (Well, badly, obviously, but htat's not the point) | 15:26 |
| gmb | bac: That would work, yes. | 15:26 |
| gmb | *should | 15:26 |
| gmb | :) | 15:26 |
| bac | ok. i *thought* i was doing the right thing... | 15:26 |
| gary_poster | gmb, can you confirm off-hand that bug.owner is the reporter? The interface says, less than helpfully, "The owner's IPerson" | 15:44 |
| gary_poster | Thank you Very Much | 15:44 |
| gary_poster | :-) | 15:44 |
| gmb | gary_poster: Yes, owner is synonymous with reporter | 15:44 |
| gary_poster | awesome thank you | 15:44 |
| benji | ok, I managed to sort out a merge from ~yellow/launchpad/accordionoverlay (I need to merge more often) and am about to push it back up | 16:27 |
| bac | gmb: YUI unit test hygiene tip: if there is anything but "Test complete" in the main browser area after the test finishes then you haven't cleaned up the dom properly. | 16:57 |
| gmb | bac: Duly noted. | 16:58 |
| gmb | (Might be worth adding that to a wiki page, if there is one for this stuff) | 16:58 |
| bac | gmb: that was mainly for my benefit... | 16:58 |
| bac | finally, i am now ready to start the interaction testing. my sloppy dom had prevented it until now. | 16:58 |
| bac | but first, pastrami | 16:59 |
| * gary_poster is lunching too | 16:59 | |
| gmb | bac: AHA! Behold! http://pastebin.ubuntu.com/578450/ | 17:49 |
| gmb | lp:~gmb/launchpad/yellow-accordionoverlay | 17:49 |
| gmb | U jbwq | 17:49 |
| gmb | Er | 17:49 |
| gmb | I knew there had to be an event *somewhere* that we could hook into. I was just looking a level too low. | 17:50 |
| gmb | bac: That handles clicking off the overlay and also hitting ESC. | 17:50 |
| gary_poster | yay :) | 17:51 |
| gmb | It doesn't handle the form cancel button, interestingly, because FormOverlay doesn't fire the cancel event when you click 'cancel'; it just hides the overlay directly. | 17:51 |
| gmb | Which is a bug. | 17:51 |
| gary_poster | huh | 17:51 |
| gary_poster | does it handle the submit button? | 17:51 |
| gmb | gary_poster: Only insofar as it hides the overlay. | 17:52 |
| gmb | There's a degree of inheriting-but-not-quite going on between Overlay and FormOverlay. | 17:52 |
| gary_poster | sure--I guess I meant did it make the line above your change in the pastebin superfluous | 17:52 |
| gmb | gary_poster: Ah, no. | 17:58 |
| gmb | I hoped it would, but the event is 'cancel', not 'hide' (which is what I was originally looking for). | 17:58 |
| gary_poster | OIC | 17:58 |
| gmb | gary_poster, bac: I'm going afk for a while now; if you've any questions please email them to me. | 18:05 |
| gary_poster | ack, gmb, thanks | 18:05 |
| gary_poster | have a nice evening | 18:05 |
| gmb | Thanks. | 18:05 |
| gary_poster | bac, no rush, ready when you are | 19:31 |
| bac | gary_poster: ok, just a sec | 19:32 |
| gary_poster | cool | 19:33 |
| gary_poster | http://pastebin.ubuntu.com/578450/ | 19:37 |
| gary_poster | benji ready when you are | 21:00 |
| benji | k | 21:00 |
| gary_poster | (but no rush) | 21:00 |
| bac` | gary_poster, anything in the TL meeting about thunderdome locale? | 21:44 |
| === bac` is now known as bac | ||
| gary_poster | nope bac :-/ | 22:00 |
| gary_poster | at least not that I remember | 22:00 |
| bac | not in minutes | 22:00 |
| bac | damn. people got vacations to plan! | 22:00 |
| gary_poster | :-) sorry | 22:01 |
| gary_poster | bac--your "add structural subscription" menu would also include "edit structural subscriptions" (however it is spelled) yeah? Going to to try and add that tomorrow | 22:04 |
| gary_poster | the rough version of the edit-per-target page | 22:04 |
| gary_poster | that is | 22:04 |
| bac | gary_poster: sorry, i didn't see your question. Yes, if a person has existing structural subscriptions they will get another link in the global-actions portlet for editing those subscriptions | 22:22 |
| gary_poster | cool thanks | 22:22 |
| gary_poster | a link to a page we still need to create, AFAIK, yeah? | 22:22 |
| gary_poster | bug 674422, on the backlog | 22:23 |
| gary_poster | _mup_ is sleeping | 22:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!