[12:10] * gmb lunches [12:32] hi danilos [12:32] bac, hi [12:32] danilos: you'd already left, but i read your comments about me stepping on the shared branch. i'm unsure how that happened as i just merged and pushed, definitely no --overwrite. [12:35] bac, oh, interesting, something weird is going on then, because both gmb and myself have committed stuff to the branch yesterday morning; no big deal, especially if you are doing the right thing [12:36] bac, (we committed and I couldn't see it in the log after your commits, so I assumed this was what has happened; didn't want to blame you for anything, just wanted to stress that we should not --overwrite stuff :) [12:36] danilos: yeah, i agree. [12:37] bac, it's quite likely that I got confused and nothing happened [12:37] we need to work together smartly but i assumed bzr was DTRT [12:37] ok, i'll carry on then and hope we don't get into trouble [12:37] bac, yeah, perhaps it did, which is why it hasn't complained :) [12:38] excellent [12:47] bac, btw, do you know if accordion widget was supposed to generate form data itself and pass it over to the handler, or not? [12:50] danilos: i'm not sure. we hooked it up through the overlay submit callback. [12:51] benji, delete functionality works on my branch. I need to get kids to school then will figure out how I want to get it landed. I also added code that does not show edit buttons if the subscriber is a team for which you are not an admin. That probably should be visually improved. [12:52] I'll try to land that separately. [13:05] bac, ok, it does work, not sure why it hasn't initially shown the data [13:27] * gmb gets ready to mumble [13:28] * gary_poster appreciates reminder [13:28] bac benji danilos gmb mumble/kanban in 2 [13:28] ack [13:29] mm, I will have to let someone into the house; I might be a minute late [14:25] hey danilos, I'm confused about something and I'm hoping you can help. :-) In bugsubscriptionfilter.delete, I've changed the code as we discussed. Now, if there are no more filters, I call delete on the parent structural subscription. As before, if there *are* more filters, I just call Store.of(self).remove(self) . [14:26] The structural subscription delete says [14:26] self.bug_filters.remove() [14:26] I assumed that this would be equivalent to calling remove(filter) for each filter [14:26] However, the test seems to indicate that this is not the case [14:27] because Store.of(self.subscription) is None but [14:27] Store.of(bug_subscription_filter) is the store [14:27] Do I misunderstand the semantics of self.bug_filters.remove() ? [14:28] Should that code iterate over the filters and call remove for each one? [14:28] I guess I could step though self.bug_filters.remove() :-P [14:28] I'll do that next [14:28] until you provide illuminaton :-) [14:31] ah-ha [14:32] .remove() does it in SQL [14:32] so the associated Python objects are not updated [14:32] that looks suspiciously like the cause [14:36] IStore(bug_subscription_filter).find(BugSubscriptionFilter, BugSubscriptionFilter.id==bug_subscription_filter.id).one() [14:36] returns None [14:36] which seems like the proof I am after. [14:36] I'll change the test to do that. [14:38] gary_poster, no, you should be able to delete SS to get all SSs deleted, but you should use the API, not Store.of(..).remove(self) [14:38] danilos, this is within the API :-) [14:38] unless I misunderstand you? [14:39] gary_poster, the only thing is that removing final BSF doesn't really remove it [14:39] it does after my change, danilos [14:39] gary_poster, ah, right, then it should be fine :) [14:39] danilos, one sec, will get a pastebin to make sure we are on the same page [14:41] danilos, lines 77ff of http://pastebin.ubuntu.com/580589/ [14:44] benji, I have tests of the serverside changes I made. I do not have tests of the JS. Go ahead and land on ~yellow, for you or someone to establish tests for it as a later punchlist item? [14:44] gary_poster: sounds good to me [14:44] ok benji [14:46] leonardr just described muting as "an anti-subscription." I think we shall use that word henceforth. [14:46] heh [14:48] gary_poster, right, looks good [14:48] cool, danilos, thank you for looking [14:49] gary_poster, I believe individual filters are referenced with "ON DELETE CASCADE" in SQL, which is why you don't have to manually remove all the BSFImportance, BSFStatus and similar rows [14:49] gary_poster, actually, I am wrong, these are removed with the setter [14:49] ok cool [14:50] I'll leave as is then [14:58] To Whom It May Concern, such as benji: ~yellow's branch is updated now. [14:59] bac, benji, I'm an hour early (because I decided to postpone landing on devel till later). Who has a good high priority punchlist item for me? I have about 3 hours to work on it left today. [14:59] * bac looks [15:00] * bac does! [15:00] gary_poster: I have "refresh the subscription listing when a subscription is edited", which would be "...when a subscription is deleted" for your case [15:00] benji, btw, do you have the initial flickering of the accordion down as a punchlist item? [15:00] gary_poster: could you look at the REQUIRED punch down and take the first item -- selectively disable the team selector if the user administers no teams -or- do whatever is smart [15:01] gary_poster: nope, I figured bac would have it, but the fix should be easy either way [15:01] gary_poster: or go with benji's since it is work you've done anyway [15:02] bac I'll look at yours [15:02] added initial accordion flicker to my REQ card [15:02] gary_poster: do you want to decompose that card and create a new one for the subtask? [15:03] bac prolly so. on call, then will fiddle with stuff and ask you questions as I have them [15:04] ok [15:08] bac, you have all four cards in Feature Work 3: Coding in progress right now? [15:08] sorry, 2 [15:09] gary_poster: i think three of them are "done" but i'm not sure how to transition them [15:10] the work is all a big blob now [15:10] bac, I was just wondering about that myself. I decided moving them to Archive:Done was reasonably apt [15:10] (via right click) [15:10] skipping review, etc [15:10] yeah [15:10] ok [15:11] done [15:11] the board looks more sane now [15:11] cool. I'll add a microcard now, yeah [15:12] bac, I don't understand the diff between [15:12] * Selectively enable team drop down. [15:12] * Handle case for no adminstered teams. [15:12] which makes me suspect I don't understand something important [15:12] could you explain? [15:12] combine them please [15:12] oh ok [15:13] because if you have no administered teams, the drop down should not be there...and anything else changes, or is that it? [15:13] gary_poster: oh, i remember -- at one point i thought i saw an exception from the view when a person had no teams. i could not reproduce it, though. [15:14] that would've been the 'handle case' task [15:14] ah ok. combine for now then [15:14] yes. you may want to double check that nothing weird happens with anon and no-priv users [15:15] ack. do you want me to push to yellow with the change before I start working on it, or is the kanban card sufficient for your workflow? [15:32] gary_poster: i just saw you question about pushing and i don't understand it [15:33] bac, I just meant pushing the change to TODO. I didn't think it was necessary so I have not yet done it. I do have another question you might be able to help me with faster than I can help myself though [15:33] gary_poster: nah, overkill [15:33] cool [15:33] Do you call setup_overlay every time someone clicks an add link, or is the html reused? [15:34] I know I can figure that out eventually, but I'm getting a bit lost in twisty paths [15:37] bac, does this mean that we do not support internet explorer at all? [15:37] if (Y.UA.ie) { [15:37] return; [15:37] } [15:37] line 803 of structural-subscription.js [15:37] gary_poster: i think it does. it is all over our JS [15:38] wow [15:38] you mean LP, not just this project, right bac? [15:38] yes, all over LP javascript [15:38] wow [15:38] of course, most of LP has