[00:13] console-setup: cjwatson * r394 ubuntu/debian/ (changelog keyboard-configuration.postinst): [00:13] console-setup: Tolerate absence of setupcon in keyboard-configuration.postinst [00:13] console-setup: (LP: #733497). [01:29] main-menu: cjwatson * r563 ubuntu/ (6 files in 3 dirs): merge from Debian 1.35 [01:34] Ok, now in the menu at startup when I select boot it says: "Could not find kernel image: /casper/vmlinuz" [01:36] main-menu: cjwatson * r564 ubuntu/debian/changelog: releasing version 1.35ubuntu1 === max is now known as Guest6587 [05:18] Ok, I'm booting off the live CD but after the initial boot menu and some startup text the screen is completely blank - the backlight is even turning off. I'm shure it's staring up, it makes the 'welcome' sound after a few seconds [12:28] ubiquity: cjwatson * r4576 trunk/ (debian/changelog ubiquity/i18n.py): [12:28] ubiquity: Drop code related to debian-installer/fallbacklocale, since that [12:28] ubiquity: template no longer exists (LP: #736060). [12:34] ubiquity: cjwatson * r4577 trunk/debian/imported-po/Makefile: tidy output [12:38] ubiquity: cjwatson * r4578 trunk/debian/ (70 files in 2 dirs): [12:38] ubiquity: Update imported translations from gtk+2.0 2.24.3-0ubuntu2 and [12:38] ubiquity: gnome-panel 1:2.32.1-0ubuntu6. [12:42] hmph, still something wrong with the autopartitioner [12:42] partman-auto/init_automatically_partition is set to the empty string [12:43] still privilege problems ... [13:12] ubiquity: cjwatson * r4579 trunk/ (4 files in 3 dirs): punctuation [13:14] ugh [13:14] resuming investigation, something killed my laptop [13:15] unless you want to take over in which case feel free - it's easily reproducible with a blank disk in kvm, assuming you apply r4576 on the fly [13:19] but I figure pycon is too busy to make it practical for you to investigate [13:27] actually, it's a bit quiet this morning and I'm waiting on reviews for some patches to cpython, so I'll have a look [13:28] I think I see it actually [13:29] okay [13:29] GET_MAX_PRIMARY doesn't always return an int - it can return the empty string if there's nothing on the disk [13:29] the permissions error I saw was a knock-on effect [13:29] though I think it might be worth fixing it while we have a scenario that reproduces it [13:30] basically we need to take care that PartedServer's destructor runs with raised privileges [13:30] I wonder if I can do that concisely with a context manager ... [13:30] it'd be annoying to have to reindent all that code [13:33] PartedServer.__del__? Wouldn't a @raised_privileges decorator work fine there? [13:34] hmm, fair point I suppose [13:34] I was sort of thinking of forcing it to go out of scope earlier [13:35] it seems a bit concerning that it can accidentally hang around open until the gc gets round to running [13:35] iyswim [13:39] hm [13:40] something vaguely like http://paste.ubuntu.com/581099/ [13:40] and then 'with parted_server.context():' [13:41] er, 'with parted_server.context() as parted:' [13:44] looks good [13:44] indeed [13:44] nice [13:46] though we do have to do some try/finallys anyway [13:46] I'm thinking of something like http://paste.ubuntu.com/581106/ ? [13:46] what do you think? [13:46] the context manager is really then mostly for conciseness [13:49] * ev reads [13:50] Xubuntu 64bit in VBox, ubiquity crashes immediately on starting today [13:50] bug 736117 [13:50] charlie-tca: Error: Could not parse data returned by Launchpad: list index out of range (https://launchpad.net/bugs/736117) [13:51] seems to be the best option, and looks good [13:51] charlie-tca: already fixed, am working on some other fatal problems [13:51] Thank you [13:54] hm, apart from a circular import problem [13:54] that's possible? I thought double imports were a nop? [13:54] oh, I misread === ogra_ is now known as ogra [13:55] * cjwatson repairs [13:59] hmm, that doesn't help, maybe I should drop the context manager idea [13:59] and just use a small number of try/finallys [14:01] ubiquity: cjwatson * r4580 trunk/ubiquity/misc.py: defend against circular imports in case ubiquity.parted_server needs to import ubiquity.misc in future [14:04] yeah, that's better [14:06] ubiquity: cjwatson * r4581 trunk/ (3 files in 3 dirs): [14:06] ubiquity: Ensure that PartedServer dialogs are always properly closed on [14:06] ubiquity: exceptional paths. [14:12] looks good [14:14] ubiquity: cjwatson * r4582 trunk/ (debian/changelog ubiquity/plugins/ubi-partman.py): [14:14] ubiquity: Fix partition-table-full check to cope with disks without a partition [14:14] ubiquity: table. [14:14] and that was the actual problem [14:35] I really need to make more of a habit for testing that scenario [14:42] ubiquity: cjwatson * r4583 trunk/debian/changelog: releasing version 2.5.27 === michael_e_brown_ is now known as mebrown [19:41] ev: your last full day? [19:41] at pycon, yeah [19:41] aah [22:10] * cody-somerville was wondering about that comment too, lol.