[12:01] hiya. getting breakfast for kids. bac, got your message. I'll be in touch in a few to touch base on what you might want me to work on today. On your list I was thinking about looking at the flicker, though I might not be able to pull it off quickly. [12:07] gary_poster: ok [12:42] https://dev.launchpad.net/TestingJavaScript [12:43] https://dev.launchpad.net/Windmill [12:43] https://dev.launchpad.net/JavascriptUnitTesting [13:29] hi gmb and benji. I see you in mumble already. I'll be ready in a min. [13:58] gary_poster: a slightly expanded version of my comment from the call: do you know if the representation for subscribing to all (e.g.) statuses is different than just enumerating all the (current) statuses? If so we should be sure to use it instead of just including all the statuses in the list. [14:04] benji, ah! [14:04] so, an empty list of statuses/importances means matching all importances [14:04] that's what my card is about [14:04] (matching all status/importances respectively, I should have said) [14:05] IMO this is what we should do: [14:06] 1) on the server side, if we are told that we are supposed to subscribe to all statuses/importances, we convert that to an absence of statuses/importances in order to keep database records low [14:06] (each status/importance checkmark per filter == a row in a table) [14:07] 2) in our JS for the form overlay, convert an absence of checkmarks to all checkmarks; I think we might do that already, not sure [14:08] 3) in our JS for summarizing, I think the changes above will make the display "just work" but we should make sure that the summaries do not list all importances/statuses--if they are all selected, then that means there is no filtering on them. [14:08] (done) [14:11] I don't think 2 is neccesary, if they haven't checked anything then they'll get an empty list which means everything (right?) [14:12] 3) it does list every one if they are all present at the moment, but if we do 1 then that won't happen [14:12] I think it is much clearer to the end user that all checkboxes means that they get all statuses/importances [14:13] That's the way it was mocked up for user testing, and that's the way it works in our cyrrent add form [14:13] oh, you meant in the UI for 2, yeah, that makes sense; I was talking about the API [14:13] 3: right, that's what I was thinking [14:13] 2: oh, cool, we're on the same page then [14:13] i.e., if you check all of them in the UI the API call should include none (meaning all) [14:14] 1) may be a challenge, I don't know if there's a place we can add that logic [14:15] 2: I don't care about us sending "the right thing" over the API actually, because 1) should make it work the way we want anyway. That's good because we want people other than ourselves to not create unnecessary records too. [14:16] #1 can go in the model logic. It's all already done with properties so it should be pretty straightforward. [14:16] cool [14:30] gary_poster: I'm ready whenever you are. [14:56] gmb, setting duration to 0 appears to set it to some default speed, rather than "immediate" :-/ [14:57] Boo. [14:57] agreed [15:00] ok, I'm off to "lunch" (helping out wife with stuff out in the car). Back in a bit. [15:16] I keep getting: WindmillTestClientException: {u'suite_name': u'RegistryYUIUnitTests', u'result': False, u'starttime': u'2011-2-17T20:44:18.244Z... [15:16] I've seen it before but rerunning the tests made it go away. I've gotten it three times in a row now. [15:21] * gmb -> errands; bbiab === Ursinha is now known as Ursinha-lunch [18:31] bac, ready for call when you are. When there, I have this question for you (for reminding myself): can you explain what node.set(SRC, EXPANDER_COLLAPSED); does? [18:31] ok. 1 minute, let me beverage-up [18:32] cool [19:10] bac: do the windmill tests currently pass for you? [19:11] benji: i haven't tried in a while. OTP but will try later [19:11] thanks; they consistently fail for me, but I think I'm homing in on the problem [19:33] https://bugs.launchpad.dev/firefox/+subscriptions [19:33] https://bugs.launchpad.dev/firefox/+bug/1/+subscriptions [19:33] <_mup_> Bug #1: Microsoft has a majority market share hi gary_poster [20:42] hey bac. otp [20:42] gary_poster: ok. can you ping me when you're off? i'd like a quick chat [20:42] sure [20:42] gary_poster: any idea how long? [20:42] bac, 5? [20:42] great [20:43] er, 5:00pm or 5 minutes? [20:43] minutes [20:54] bac, mumble, skype, ...? [20:54] mumble [21:30] gary_poster: I'm almost ready to land the test fixes. It will have one odd bit, I removed one set of tests that the branch I'll land later replaces. I tried to fix them for the time being but it took too long to warrent putting into tests I was going to rework anyway. [21:52] gary_poster: ok, finally pushed [22:28] awesome, thanks benji. I'll try finish getting the help pages sorted out, and then try to merge, test, & push.