mhall119 | French team just likes to be different I think | 00:26 |
---|---|---|
mhall119 | paultag: awesome news | 00:26 |
paultag | mhall119: what's up | 00:28 |
mhall119 | paultag: just read about ~locoteams being a delegated team, so loco teams can go back to being open | 00:28 |
paultag | oh dur, right | 00:29 |
paultag | mhall119: yeah, I'm stoked | 00:29 |
dscassel | Woo! I got our Natty Narwhal design artwork back from an artist friend. | 01:17 |
dscassel | 01:17 | |
dscassel | 01:17 | |
dscassel | 01:17 | |
dscassel | http://ubuntuone.com/p/ie0/ | 01:17 |
dscassel | Now to design CDs. :D | 01:17 |
nigelb | good morning | 02:51 |
YoBoY | good morning | 06:30 |
aakshay | YoBoY: good morning | 06:34 |
YoBoY | mhall119: french team is old. When I look at my community and how many ubuntu events we have in march, I think being different is good ;) | 06:47 |
YoBoY | hi aakshay | 06:47 |
aakshay | hi yoboy :) | 06:48 |
aakshay | YoBoY: where all the files for css are stores in loco_directory? i need to access them.. | 07:02 |
YoBoY | aakshay: most of them come from the ubuntu-website project | 07:04 |
YoBoY | aakshay: but try in media directory | 07:05 |
aakshay | YoBoY: media directory in ubuntu-website folder? | 07:05 |
YoBoY | this one, and the other one | 07:06 |
aakshay | ok. thanks.. :) | 07:06 |
YoBoY | you can't directly modify files in ubuntu-website, this files have to be modified in the ubuntu-website project | 07:06 |
aakshay | YoBoY: ok.. and i would like to ask one more thing that | 07:07 |
aakshay | how can i access the comment id from the database? | 07:07 |
aakshay | or what is the primary key they use to uniquely identify wach comment? | 07:08 |
YoBoY | don't know ^^" | 07:09 |
YoBoY | You have to wait and ask to one of the LD devs | 07:09 |
aakshay | its ok.. thanks :) | 07:10 |
dholbach | good morning | 08:16 |
daker | good morning | 09:52 |
dholbach | hey daker | 09:53 |
daker | mhall119, Ronnie file a bug and assigned to me | 09:53 |
Ronnie | morning | 09:58 |
Ronnie | hey aakshay, back again | 10:00 |
Ronnie | how can i access the comment id from the database? | 10:02 |
Ronnie | Comment.objects.get(pk=commentId) | 10:02 |
Ronnie | aakshay: ^ | 10:02 |
Tm_T | K'day all | 10:03 |
aakshay | Ronnie: hey... :) | 10:03 |
aakshay | Ronnie: yes.. i am facing the problem doing this.. | 10:04 |
Ronnie | if you need to edit CSS, think first is the changes should go to the whole ubuntu-theme, or just loco specific. If the latter, then you can add css to the newstyle.css in /media/css otherwise you have to change the ubuntu_website/media/css/default.css and merge it into ubutnu_website first | 10:04 |
Ronnie | Hi Tm_T | 10:04 |
Ronnie | aakshay: what bug are you trying to solve? | 10:05 |
aakshay | Ronnie: 616383Needs ability to directly link to a comment | 10:05 |
aakshay | the above bug | 10:05 |
Ronnie | oke | 10:06 |
aakshay | in this, i need to print the complete comment on the new web page. but i am not getting how to access the required comment from the database? | 10:06 |
Ronnie | there are 2 ways to do that. make a separate page with only that comment or work with hashes (name="myname" and url#myname) | 10:07 |
Ronnie | which of the two ways do you want to make | 10:07 |
aakshay | Ronnie: i am planning to make a new page | 10:07 |
aakshay | Ronnie: but then i need to declare "url" and many more things which i am confused in | 10:08 |
aakshay | :( | 10:08 |
Ronnie | the disadventage i usualy have, it that the context and latter comments are not visible | 10:08 |
Ronnie | i will lead you trough the process, but first we need to have to same "plan" | 10:09 |
aakshay | yes.. | 10:09 |
aakshay | i have spent all these days deciding the plan only.. :D | 10:09 |
aakshay | can we start by today itself?.. :) | 10:09 |
Ronnie | so whats your plan? | 10:11 |
aakshay | Ronnie: my plan is to add a "view" label instead of "#1" as in "https://bugs.launchpad.net/ubuntu/+bug/1/comments/1" in the grey portion on the right most side | 10:12 |
ubot4` | Launchpad bug 1 in tilix (and 20 other projects) "Microsoft has a majority market share (affects: 621) (dups: 1) (heat: 2890)" [High,New] | 10:12 |
aakshay | then link this "view" to the new designed page | 10:13 |
aakshay | Ronnie: Then on the new designed page, we will acess the required comment from the database and print as shown in the above demo web page. :) | 10:14 |
Ronnie | oke | 10:14 |
aakshay | Ronnie: thats my plan but i dont know whether its efficient or not.. :p | 10:14 |
Ronnie | not sure about it. i guess its more work that adding a #mylabel to an url | 10:15 |
aakshay | Ronnie: adding to which URL?.. :p | 10:15 |
Ronnie | and you dont have the ability to see other comments, thats why i dont like the LP comment style | 10:15 |
aakshay | Ronnie: yes it is... | 10:16 |
Ronnie | for example: http://loco.ubuntu.com/events/team/825/detail/#comment1 | 10:16 |
aakshay | Ronnie: but i dont get one thing that we need to display the above comment on the different web page as in demo or we can do as per our choice? | 10:17 |
aakshay | :) | 10:17 |
Ronnie | aakshay: its pretty easy. all comments we need to add a name= tag in the template, and make a link to the name= tag, thats all we need to do | 10:19 |
Ronnie | if we want to, we can highlight the comment with javascript | 10:19 |
aakshay | Ronnie: ok. its like making "href" on the same page.. :) | 10:19 |
Ronnie | aakshay: yes | 10:19 |
aakshay | Ronnie: ok.. that will be nice then | 10:20 |
Ronnie | if the url caontains a #, the browser will scroll down the page, till it meets the corresponding name= tag | 10:20 |
aakshay | then one more thing, do i need to change the look of the comment display pattern? mans adding some CSS to it?. | 10:21 |
Ronnie | you can add the 'highlight' part | 10:21 |
Ronnie | we need to add some jQuery for that i guess | 10:21 |
Ronnie | i will lead you trough that too | 10:21 |
aakshay | Ronnie: ok thanks beacause i dont know about jquery | 10:22 |
aakshay | :) | 10:22 |
Ronnie | first you need to find the template responsible for the comment part | 10:22 |
Ronnie | can you find these? | 10:22 |
aakshay | yes.. | 10:22 |
aakshay | its in event/team_eevnt_comment.html | 10:23 |
aakshay | Ronnie: and also in team_event_detail_comments.inc.html | 10:23 |
aakshay | *its in event/team_eevnt_comment_new.html | 10:24 |
Ronnie | yes, the team_event_comment_new is to create a new comment | 10:24 |
Ronnie | the team_event_detail_comments.inc.html is the include to view the comment | 10:24 |
aakshay | yes.. so i am editing the later one | 10:24 |
Ronnie | indeed | 10:24 |
aakshay | yes | 10:25 |
Ronnie | any idea how to start? | 10:25 |
aakshay | hmm.. i will add "view" label on the right side | 10:26 |
aakshay | with anchor tag with it | 10:26 |
Ronnie | yes, an anchor tag (thats the word i was looking for all the time) | 10:27 |
aakshay | is it fine? | 10:27 |
aakshay | :D | 10:27 |
aakshay | but the "name= " wil be tough to design | 10:27 |
aakshay | because in for loop we need to name it and need unique names for that | 10:28 |
aakshay | i hope u got me.. :D.. i am making it all a mess | 10:28 |
aakshay | :) | 10:28 |
Ronnie | i can still follow ;) | 10:29 |
aakshay | so need a comment id or so to append in name of every commenr | 10:29 |
Ronnie | right | 10:29 |
aakshay | *comment.. :) | 10:29 |
aakshay | this is the point where i am stucked.. :( | 10:30 |
Ronnie | do you know in which part of the HTML you need to add the id? | 10:30 |
aakshay | yes.. please wait for 1 minute.. let me tell you the exact line | 10:31 |
aakshay | Ronnie: after line 17 "{{comment.commenter_profile.realname}}</a>:</label></th>" | 10:33 |
aakshay | we cann add the required anchor tag with "view" label | 10:33 |
aakshay | *can | 10:33 |
aakshay | and there we add this unique id while defining the name | 10:33 |
Ronnie | the view-label should be after line 18 i think | 10:34 |
Ronnie | the unique name can be defined in line 16 | 10:34 |
aakshay | yes.. we can define "view" after 18 also | 10:35 |
Ronnie | ok, lets do that, | 10:35 |
Ronnie | we need to add another TD | 10:36 |
aakshay | yoo | 10:36 |
aakshay | :) | 10:36 |
aakshay | yes | 10:36 |
Ronnie | in that td we need an <a> | 10:36 |
aakshay | yes | 10:37 |
Ronnie | with a href to .... | 10:37 |
aakshay | i need to look the syntax. :p. i forgot it... :) let me see on W3C.. | 10:38 |
aakshay | :) | 10:38 |
aakshay | got it | 10:39 |
aakshay | :) | 10:39 |
* Ronnie loves w3schools | 10:39 | |
aakshay | lets first add the href to comment for its unique naming | 10:39 |
aakshay | :) | 10:39 |
aakshay | me too.. | 10:39 |
aakshay | :) | 10:39 |
aakshay | Ronnie: added name only yet :D ... new line 17 is "<th class="form-item-label" scope="row"><label><a href="https://launchpad.net/~{{comment.commenter_profile.user.username}}" name=""" | 10:42 |
aakshay | Ronnie: i worte "name=" | 10:43 |
Ronnie | <tr id="{{ comment.id }}"> <== line 16 | 10:43 |
aakshay | sry | 10:43 |
aakshay | *"name="#comment....." " | 10:43 |
aakshay | now what to add to these dots to make it unique? | 10:43 |
Ronnie | <a name> is perfectly valid in XHTML 1.0 Strict. id may normally be preferred, but name is not deprecated until HTML5. – bobince Jan 31 '10 at 10:50 | 10:44 |
Ronnie | ^ quote from http://stackoverflow.com/questions/2171237/how-to-create-named-anchors-in-django-for-getting-down-to-specific-parts-of-the-p | 10:44 |
Ronnie | i think we better use id instead of name | 10:45 |
aakshay | yes.. so where can i find the syntax? w3schools? | 10:45 |
Ronnie | good question, but somehow name= does not work here, so i want looking for a solution | 10:46 |
aakshay | Ronnie: we can use id as <a id="comment....">.. :D | 10:47 |
aakshay | let me aslo check | 10:47 |
Ronnie | we can do both, id= and name= | 10:49 |
aakshay | let me aslo check"http://www.w3.org/TR/html401/struct/links.html#h-12.2.3" | 10:49 |
aakshay | it may help us | 10:49 |
aakshay | sry | 10:49 |
aakshay | please check http://www.w3.org/TR/html401/struct/links.html#h-12.2.3" | 10:49 |
aakshay | http://www.w3.org/TR/html401/struct/links.html#h-12.2.3 | 10:50 |
aakshay | ok.. if we can do then its fine | 10:50 |
aakshay | :) | 10:50 |
Ronnie | When both attributes are used on a single element, their values must be identical. | 10:52 |
Ronnie | so were safe | 10:53 |
Ronnie | i think IE6 wont support id= but others will | 10:53 |
aakshay | yes.. | 10:53 |
aakshay | o/ | 10:53 |
aakshay | :) | 10:53 |
aakshay | Ronnie: we really need to think a lot before taking every step.. :P | 10:54 |
aakshay | so we can go with name attribute also | 10:54 |
aakshay | :) | 10:54 |
Ronnie | we do, but thats good | 10:54 |
Ronnie | so how does your line 16 looks like? | 10:54 |
aakshay | we are editing line 17 | 10:55 |
aakshay | i think so | 10:55 |
aakshay | and it is after editing " <th class="form-item-label" scope="row"><label><a href="https://launchpad.net/~{{comment.commenter_profile.user.username}}" name="#comment"" | 10:55 |
aakshay | now what to add to "#comment" to make it unique in every run of the loop? | 10:57 |
aakshay | :) | 10:57 |
Ronnie | ok | 10:57 |
Ronnie | line 15: {% for comment in comment_date.list %} | 10:57 |
aakshay | ok.. so we can use this date? :P | 10:57 |
Ronnie | this means we can use the variable "comment" now | 10:58 |
Ronnie | u can use variables {{ var_nane }} | 10:58 |
aakshay | then it wil become "name="#comment{{comment}}"" | 10:58 |
aakshay | ? | 10:58 |
Ronnie | almost | 10:59 |
Ronnie | with {{ comment }} | 10:59 |
Ronnie | we get the whole comment object | 10:59 |
Ronnie | we only needs it "id" | 10:59 |
aakshay | yes | 10:59 |
Ronnie | any suggestions? | 10:59 |
aakshay | we can move to database primary ker or so?? | 11:00 |
aakshay | :P | 11:00 |
aakshay | *key | 11:00 |
Ronnie | we need the pk (primary key) or id (identifier - which is the same as pk) | 11:00 |
Ronnie | of the comment object | 11:00 |
aakshay | like for the "comment" object we can access the database like comment.id | 11:01 |
aakshay | yes | 11:01 |
aakshay | the same | 11:01 |
aakshay | can it be possible? | 11:01 |
Ronnie | its that easy just use {{ comment.id }} | 11:01 |
aakshay | ok.. then its the solution.. :) | 11:02 |
aakshay | Ronnie: but i have doubt.. how "comment" is an object to access the database? | 11:03 |
aakshay | we have declared it | 11:03 |
aakshay | :P | 11:03 |
Ronnie | we have declared it in the models.py and views.py | 11:03 |
aakshay | okiez.. :) | 11:03 |
Ronnie | you not need to worry about that when doing templates | 11:04 |
aakshay | :) | 11:04 |
aakshay | Ronnie: so now line 17 is done | 11:04 |
aakshay | now its time for line 19 | 11:05 |
aakshay | (means added it pressing enter) | 11:05 |
aakshay | :) | 11:05 |
Ronnie | :D | 11:05 |
aakshay | Ronnie: new line 19 is "<td><a href="#comment{{comment.id}}">View</a>" | 11:07 |
Ronnie | </td> | 11:07 |
aakshay | ye. basically i wrote in line 20.. :D | 11:07 |
Ronnie | oh | 11:07 |
Ronnie | you can give the TD a class to have the same styling: "form-item-value" | 11:08 |
aakshay | in line 19? | 11:09 |
Ronnie | yes | 11:09 |
aakshay | ok. | 11:09 |
aakshay | :) | 11:09 |
aakshay | can u please check the new file once.. if it is working correctly or not? | 11:10 |
Ronnie | sure | 11:10 |
Ronnie | paste.ubuntu.com ? | 11:10 |
aakshay | Ronnie: thanks.. :) | 11:10 |
aakshay | ok.. let me paste it and send the URL | 11:11 |
Ronnie | oh, i got to eat in a minute | 11:11 |
Ronnie | this is what i got: http://paste.ubuntu.com/583279/ | 11:11 |
aakshay | :) | 11:12 |
Ronnie | http://paste.ubuntu.com/583283/ <== diff | 11:12 |
aakshay | its mine "http://pastebin.com/2BRxU9Ta" | 11:13 |
aakshay | i done many mistakes... :p | 11:13 |
Ronnie | not that much ;) | 11:14 |
Ronnie | its pretty good | 11:14 |
Ronnie | some minor differences | 11:14 |
Ronnie | i did put the name and id in the TR instead of th, because its easier to see in the short line | 11:15 |
aakshay | Ronnie: yes.. :) | 11:15 |
aakshay | so it will work now.. | 11:16 |
Ronnie | you need to add the id= too on your part | 11:16 |
aakshay | yes.. thats the error i found.. i thought only name will work.. :p | 11:17 |
Ronnie | the extra spaces before the View can be better with CSS styping | 11:17 |
Ronnie | and the View text need to be translateble | 11:17 |
Ronnie | therefore we use {% trans "translatable text" %} | 11:17 |
aakshay | sorry but what this translatable means? | 11:18 |
aakshay | :P | 11:18 |
Ronnie | so other loco's can translate "View" into their own language | 11:18 |
aakshay | okiez. language translation | 11:19 |
aakshay | so its done | 11:19 |
aakshay | :) | 11:19 |
Ronnie | i have to eat now | 11:20 |
aakshay | sure.. enjoy the food..i am also goin to have lunch | 11:21 |
aakshay | :) | 11:21 |
=== daker_ is now known as daker | ||
aakshay | Ronnie: are you back?.. :) | 12:10 |
Ronnie | bakc, but nedd to do other thing, am sorry | 12:11 |
Ronnie | see you later | 12:11 |
aakshay | its ok.. see you.. | 12:12 |
mhall119 | that Global Jam map sure is looking nice | 14:46 |
mhall119 | need to get some more in USA though | 14:48 |
aakshay | where can i find the code of CSS for the grey strip of global events under "upcoming events in " "http://loco.ubuntu.com/" | 14:54 |
aakshay | ? | 14:54 |
Ronnie | hey aakshay, im back (for a couple of minutes) | 14:58 |
Ronnie | i advisse you to install firebug addon for firefox | 14:58 |
aakshay | thanks Ronnie :).. | 14:58 |
aakshay | this will help in? | 14:58 |
Ronnie | there you can easily see what style is applied on what element, en where the stylesheet comes from | 14:59 |
aakshay | ok... thanks.. :) | 14:59 |
aakshay | one more thing, do i need to add any Css to the work we did? | 14:59 |
Ronnie | you need to add a margin to the left of the link | 15:00 |
Ronnie | margin-left: 8px should do just fine | 15:00 |
aakshay | link means "view" | 15:00 |
aakshay | ? | 15:00 |
Ronnie | yes | 15:00 |
aakshay | ok.. i will do it.. thanks.. :) | 15:00 |
Ronnie | maybe we need to change "view" to {{ comment.id }} too? | 15:01 |
aakshay | ya i will do like "#{{comment.id}}" eg. #64 | 15:01 |
Ronnie | yes, same like LP | 15:01 |
aakshay | yes.. but in that the counting will not start by "1".. it will start by some value from database | 15:02 |
aakshay | if it is fine then i will make it | 15:02 |
Ronnie | aakshay: rigth about that | 15:02 |
Ronnie | but its a bit harder to do i guess | 15:02 |
aakshay | yes | 15:02 |
Ronnie | altough.... | 15:02 |
Ronnie | not really | 15:02 |
aakshay | ok | 15:02 |
Ronnie | you can use {{ forloop.counter }} | 15:03 |
aakshay | okiez.. in plave of "view"? | 15:03 |
Ronnie | yes | 15:03 |
aakshay | *place | 15:03 |
aakshay | ok | 15:03 |
aakshay | i will do this also | 15:03 |
aakshay | :) | 15:03 |
Ronnie | you can even use the forloop.counter as the href=, id= and name= | 15:05 |
aakshay | ok.. this will serve the purpose.. :) | 15:07 |
Ronnie | im thinking how we could do an non-javascript highlight | 15:08 |
Ronnie | but nothing comes to mind | 15:08 |
aakshay | highlight? can you please elaborate little.. may be i can tell something | 15:09 |
aakshay | Ronnie: you can do CSS highlight | 15:10 |
Ronnie | give the comment which is 'selected' by the # and other background color or something, so its clear which comment is 'selected' | 15:10 |
aakshay | if you can get the number or id of selected comment | 15:14 |
Ronnie | i can only think of an javascript method | 15:15 |
Ronnie | but are there ppl who's not using javascript? | 15:15 |
aakshay | Ronnie, then we can add <tr style="background-color:grey"> | 15:16 |
aakshay | this is CSS | 15:16 |
aakshay | may help somehow.. :P | 15:16 |
Ronnie | yes, but how to get the number? | 15:16 |
Ronnie | i think ppl who dont use javascript should look at the number | 15:17 |
aakshay | yes they will | 15:17 |
aakshay | i am getting something very long way of getting number | 15:18 |
aakshay | Ronnie, you can use name attribute in anchor tag and then somehow append the name to the URL and extract from there | 15:19 |
aakshay | this will not use javaScript but may serve the purpose | 15:19 |
aakshay | :) | 15:19 |
Ronnie | how to extract from the url? | 15:20 |
aakshay | if the number can be appended to URL then append it like after "?" and extract it from URL by separating the previous string | 15:21 |
aakshay | before and with "?" | 15:21 |
Ronnie | have to go | 15:22 |
aakshay | ok.. :D | 15:23 |
aakshay | bye.. | 15:23 |
Ronnie | aakshay: back | 15:51 |
Ronnie | any ideas came up? | 15:51 |
aakshay | Ronnie, no :( | 15:51 |
Ronnie | then well do javascript | 15:52 |
aakshay | but what about the idea i told u? | 15:52 |
aakshay | ya.. that would be better n easier.. | 15:52 |
Ronnie | have you written javascript? | 15:53 |
aakshay | no.. :( | 15:53 |
aakshay | sorry | 15:53 |
Ronnie | we need to use location.hash to get the number | 15:54 |
aakshay | ok.. then you can use if(location.hash...) then style="background-color:grey | 15:55 |
Ronnie | $('[name=' + location.hash.slice(1) + ']').attr('background-color', '#f7f7f7'); | 15:56 |
Ronnie | or something | 15:56 |
Ronnie | or even easyier $(location.hash).attr.... | 15:57 |
aakshay | ya $(locatio.hash).attr.. | 15:57 |
aakshay | i suggest you to go with if() | 15:58 |
Ronnie | aakshay: try to add this http://paste.ubuntu.com/583360/ into team_event_detail.html | 16:05 |
Ronnie | after: {% block title %}{% trans team_event_object.name %} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %} | 16:05 |
Ronnie | without console.log() | 16:05 |
aakshay | ok | 16:05 |
aakshay | done | 16:08 |
Ronnie | does it work? | 16:09 |
aakshay | sorry but what to choose means what to select? :P | 16:10 |
Ronnie | aakshay: speak to you later | 16:11 |
aakshay | Ronnie, ok.. let me see this meanwhile | 16:11 |
Ronnie | i even improved it a bit: http://paste.ubuntu.com/583363/ | 16:11 |
Ronnie | and http://paste.ubuntu.com/583365/ | 16:12 |
Ronnie | good luck with it | 16:12 |
aakshay | :D.. thanx.... | 16:13 |
nigelb | YoBoY: pong | 16:44 |
nigelb | err ping | 16:44 |
nigelb | YoBoY: *ping | 16:44 |
YoBoY | pong :) | 16:44 |
nigelb | YoBoY: I'm guessing you guys have done several awesome global jams? | 16:44 |
nigelb | YoBoY: I was wondering if you want to help with a classroom event (a small one) about global jams and how to make it rocking | 16:45 |
YoBoY | when ? | 16:46 |
nigelb | how does 28th March sound to you? | 16:46 |
nigelb | Since the event itself is in planning stages, I can move it around a bit | 16:47 |
nigelb | we'll have about 3 to 4 sessions | 16:47 |
nigelb | one about the general planning (which I'm hoping youd do) | 16:47 |
YoBoY | monday ? it's good :) | 16:47 |
nigelb | awesome, what time is good for you? | 16:47 |
nigelb | does 1600 UTC sound okay? | 16:47 |
YoBoY | need to convert that ... wait :) | 16:48 |
Ronnie | YoBoY: = 17:00 GMT+1 | 16:48 |
YoBoY | yes ^^" | 16:49 |
Ronnie | aakshay: im back | 16:49 |
nigelb | YoBoY: awesome, I'll put you down for a session, thanks! | 16:49 |
YoBoY | nigelb: a bit later if it's possible | 16:49 |
nigelb | YoBoY: how much later? | 16:49 |
YoBoY | (my yes is for Ronnie :p) | 16:49 |
nigelb | ah | 16:49 |
YoBoY | 1800 UTC ? | 16:49 |
nigelb | sure :) | 16:50 |
nigelb | you're the first recruit, you get to pick :D | 16:50 |
aakshay | Ronnie, hey | 16:50 |
YoBoY | ^^ | 16:50 |
aakshay | i dint find anything good out of it | 16:50 |
Ronnie | aakshay: didn't it work? | 16:50 |
aakshay | if i selest any comment there is no change in color | 16:50 |
aakshay | no | 16:50 |
aakshay | :( | 16:50 |
aakshay | have you checked it once | 16:51 |
aakshay | ? | 16:51 |
YoBoY | nigelb: in #ubuntu-classroom ? | 16:51 |
nigelb | YoBoY: yup :) | 16:51 |
aakshay | Ronnie, WORKED!!!! | 16:52 |
Ronnie | aakshay: it did worj here | 16:53 |
aakshay | its changing the color | 16:53 |
aakshay | yes | 16:53 |
YoBoY | nigelb: subject ? | 16:53 |
nigelb | YoBoY: "General tips to having a rocking Jam" :) | 16:54 |
YoBoY | ok :) | 16:54 |
aakshay | Ronnie: but its just highlighting the first selection only | 16:54 |
aakshay | :P | 16:54 |
Ronnie | aakshay: did you use the new code, here it works | 16:54 |
YoBoY | ping me when you have the other topics before, to adapt my presentation :) | 16:55 |
aakshay | yes i used the new one | 16:55 |
aakshay | no problem it worked there.. then fine... :) | 16:56 |
Ronnie | aakshay: can i look into your code? | 16:56 |
aakshay | sure | 16:56 |
aakshay | 1 min | 16:56 |
aakshay | its here http://paste.ubuntu.com/583390/ | 16:57 |
YoBoY | Ronnie: btw it's monday 28 it's UTC +2 we change to the summer hour sunday 27 ;) (it's why I needed to look this) | 16:58 |
Ronnie | YoBoY: ah, forget. Yay summertime :D | 16:58 |
* Ronnie likes summertime | 16:59 | |
Ronnie | aakshay: line 39-47 should be in team_event_details_comment.inc.html | 17:01 |
aakshay | Ronnie: err.. that is what i was thinking.. :p | 17:02 |
aakshay | Ronnie: where to add in team_event_details_comment.inc.html? | 17:05 |
Ronnie | most of it should be there alraedy | 17:06 |
aakshay | Ronnie: yo.. worked... :) | 17:09 |
aakshay | o/ | 17:09 |
aakshay | :) | 17:09 |
aakshay | Ronnie: which bug is it? | 17:09 |
Ronnie | bug 616383 | 17:10 |
ubot4` | Launchpad bug 616383 in loco-directory "Needs ability to directly link to a comment (affects: 1) (heat: 5)" [Wishlist,Triaged] https://launchpad.net/bugs/616383 | 17:10 |
aakshay | ok.. its the same :D | 17:10 |
aakshay | so do i need to merge the changes we made in morning? | 17:11 |
Ronnie | you need to: | 17:11 |
Ronnie | bzr commit -m "message of the changes" | 17:11 |
Ronnie | bzr push lp:~yourusername/loco-directory/fixes-616383 | 17:12 |
aakshay | ok... i will do it later because i have not completed it yet.. :P | 17:12 |
Ronnie | and then on launchapd page you can create the merge request | 17:12 |
aakshay | ok.. then | 17:12 |
Ronnie | other developers will look at it and provide feedack of approve the code | 17:12 |
aakshay | ok and what about the coding u have done? | 17:13 |
aakshay | Ronnie: as it is also the same bug | 17:13 |
Ronnie | its totally yours ;) | 17:13 |
Ronnie | same bug | 17:13 |
Ronnie | i was just helping you | 17:13 |
aakshay | oh.... :)... its totally ours... :) | 17:14 |
aakshay | o/ | 17:14 |
=== dholbach_ is now known as dholbach | ||
aakshay | Ronnie: than which one should i commit? one we did in morning or this one? | 17:14 |
Ronnie | i think the latter one is the best | 17:15 |
aakshay | yes.. :) thanks for the help.. :) | 17:15 |
Ronnie | but you need the lines between <style></style> to put in the newstyle.css | 17:15 |
Ronnie | your welcome | 17:16 |
aakshay | :) | 17:16 |
Ronnie | were happy to see new loco directory developers | 17:16 |
aakshay | Ronnie: in which file ? | 17:16 |
Ronnie | /media/css/newstyle.css | 17:16 |
mhall119 | +1 Ronnie | 17:26 |
Ronnie | daker: there is already a bug report for it: https://bugs.launchpad.net/loco-directory/+bug/712440 | 17:37 |
ubot4` | Launchpad bug 712440 in loco-directory "twitter, picasaweb, flickr, pixie should be a separate .js file (affects: 1) (heat: 4)" [Low,Confirmed] | 17:37 |
daker | ah ok thanks Ronnie | 17:37 |
Ronnie | ill assinged it to you | 17:38 |
Ronnie | have you any experience in writing jquery plugins? | 17:38 |
daker | will try :) | 17:38 |
Ronnie | you can have a look at the twitter script, and twidenash script. | 17:39 |
daker | yes ok | 17:39 |
Ronnie | and im available for help too | 17:39 |
daker | i think twitter is done ? | 17:39 |
Ronnie | twitter is done | 17:39 |
Ronnie | and jslint is my friend too | 17:40 |
Ronnie | WARNING: JSLint will hurt your feelings. | 17:40 |
Ronnie | http://www.jslint.com/ | 17:40 |
nigelb | hehe | 17:40 |
Ronnie | when i think my code works good, jslint can find 20-50 errors in it ;) | 17:41 |
Ronnie | daker flickr does have a script too i guess | 17:42 |
daker | you mean a jquery plugin ? | 17:42 |
Ronnie | yes | 17:43 |
daker | ok | 17:43 |
aakshay | Ronnie: i have committed the change and pushed it. now what will the address to aceess the merge on launchpad? | 17:47 |
Ronnie | aakshay: this page is created: | 17:48 |
Ronnie | https://code.launchpad.net/~akshaytayal/loco-directory/fixes-616383 there is a link " craete merge propsal" | 17:49 |
Ronnie | uhm, "propose for merging" | 17:49 |
Ronnie | you can also link it to the bug report | 17:49 |
aakshay | ok.. how to link to bug report? | 17:50 |
nigelb | itnet7: ping | 18:03 |
Ronnie | aakshay: with the link "link to bugreport" | 18:05 |
aakshay | done.. :).. thanks a lot... :) | 18:10 |
aakshay | good night.. | 18:32 |
mhall119 | thank you aakshay | 18:51 |
mhall119 | gone, I know... | 18:51 |
mhall119 | Ronnie: you rock for walking him through the process | 18:51 |
Ronnie | thx mhall119, i did it eith pleasure | 18:52 |
itnet7 | nigelb: pong | 19:12 |
nigelb | itnet7: hey, I was looking for someone to take a session about ornaizing ugj. Youup for it | 19:15 |
nigelb | bah, spelling :( | 19:15 |
itnet7 | nigelb: When would this be? | 19:15 |
nigelb | inmonday 28th at either 1700 or 1900 utc | 19:16 |
nigelb | *on monday | 19:16 |
itnet7 | nigelb: Let me see if I can get off of work early on Monday, and if I can I will | 19:18 |
itnet7 | nigelb: pm? | 19:18 |
nigelb | itnet7: sure :) | 19:18 |
cjohnston | 5/45 | 19:21 |
cjohnston | uggh | 19:21 |
nigelb | cjohnston: 42 | 19:21 |
cjohnston | hush | 19:22 |
Ronnie | mhall119: any progress on the django openid auth bug? | 19:22 |
nigelb | cjohnston, mhall119: quick one line code review https://code.launchpad.net/~nigelbabu/summit/fix-735633/+merge/54258 | 19:46 |
nigelb | Daviey: you too ^^ | 19:48 |
Daviey | nigelb, I think it is safe, but are you sure it doesn't modify the db? | 19:54 |
nigelb | Daviey: yes, it only makes the form validation change. | 19:55 |
nigelb | oh wait, what's that coding uft8 thing | 19:56 |
* nigelb removes | 19:56 | |
nigelb | Only a few more days left for the applications to close, but you might want to get it live nevertheless | 19:58 |
nigelb | I guess I should just subscribe to summit bugs | 20:00 |
mhall119 | Ronnie: I finished my test cases and enhancements over the weekend, waiting for new reviews | 20:00 |
Ronnie | mhall119: do you have to link to the merge> | 20:00 |
mhall119 | https://code.launchpad.net/~mhall119/django-openid-auth/fixes-642132/+merge/54193 is for renamed users | 20:01 |
mhall119 | https://code.launchpad.net/~mhall119/django-openid-auth/strict-username-requirements/+merge/54065 is for enforcing that we get a launchpad username | 20:02 |
Ronnie | ill have a look tomorrow i guess | 20:02 |
mhall119 | Ronnie: thanks, I'll try and get one of the maintainers to look over it too | 20:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!