[12:00] gmb, hi, what do you think of https://devpad.canonical.com/~danilo/screencasts/inline-validation-error.ogv for inline error handling? [12:01] danilos: Sweeet. [12:01] Love it. [12:01] gmb, cool, thanks, then I'll run with it :) [12:01] Excellent. [12:37] oops, forgot to fire up my IRC client [12:44] * gmb grabs some lunch [13:22] ok, bac, I think I've worked through my mail backlog sufficiently. I think milestone is the last one to be done? [13:22] gary_poster: really? ok. are you offering? i'm still working on the distro abnormalities [13:22] bac, yes, I am offering [13:23] I'll start [13:23] excellent [13:24] danilos: your screencast is great! [13:24] bac, thanks :) [13:25] gary_poster, fwiw (since you joined right after I posted the URL), https://devpad.canonical.com/~danilo/screencasts/inline-validation-error.ogv [13:26] danilos, a thing of beauty :-) thank you [13:26] danilos: you need to up the volume for the soundtrack [13:26] bac, heh, did it record that as well? that was accidental :)) [13:26] "odistani" means stop or something? [13:27] yeah, it means "give up" [13:27] or "cancel" [13:27] lol [13:27] I like "give up" [13:27] I think we should change all of our "cancel" buttons in LP to "give up" or perhaps "surrender" [13:28] heh [13:28] heh [13:30] uhm, mumble time? [13:30] oh yeah, that [13:30] :) [13:30] bac benji danilos gmb munble/kanban [13:31] on a realted note, the green checkmark and red X buttons are far too small [13:31] you all are probably there already... [13:31] I think that's an LP issue, benji but could be wrong [13:31] yeah, they are bitmaps which don't really work well with our high resolution screens [13:31] yeah, I think it is too, they're used all over the place [13:32] I wouldn't mind nice big buttons with words and those images on the buttons [13:38] Mumble is too much fun. [13:38] gmb, don't play with the buttons :) [13:38] Hee hee. [13:39] * benji vows to cultivate the MP cover letter style of Dostoyevsky. [13:44] :-) [13:45] gary_poster, 1-on-1 calls today, right? [13:45] danilos, was going to say that, yeah [13:45] have a card on board for it [13:45] the only tricky bit will be gmb [13:45] gmb, after I write my cover letter and before you start review we can havee a quick call? [13:46] gary_poster: Sure, that works for me. [13:46] cool thanks [13:46] Warning for those who care: I intend to merge devel into ~yellow/launchpad/accordionoverlay before making my review branch [13:50] k [13:51] bac, combine-css.in from ~yellow's accordionoverlay has this conflict when I merge devel in: http://pastebin.ubuntu.com/584817/ . All three of the galley-accordion files exist in the tree. Do you have any suggestions on how to merge that? [13:53] gary_poster: you need both gallery-accordion css files and you need the new sprite file [13:53] bac, but what about the other gallery accordion file? [13:53] I was just about to see if it subsumes the other two [13:53] gary_poster: sorry. you need core and skin [13:54] so delete the third one? [13:54] yes, delete from that file [13:54] ack, thanks. [13:55] bac, and I'm also doing a corresponding "bzr rm ./lib/lp/contrib/javascript/yui3-gallery/gallery-accordion/assets/skins/sam/gallery-accordion.css" yeah? [13:56] sure, it is vestigial [13:56] cool thanks [14:21] gary_poster: i jotted some notes yesterday as i encountered some problems/suspicions. they are http://pastebin.ubuntu.com/584843/ [14:21] looking [14:28] thanks bac. +1 on making a card for the first two bullet points. [14:28] For the third, I hear what you are saying. I don't know of a more standard way of doing it (I looked), and I think I grew that from some code Danilo had done on another branch (but it was in progress, so he may have had something better in mind later). [14:29] Elsewhere I wrote this to cache the decision within a loop, so that if you kept encountering the same team at least that would be cheaper. In the current code path, the function will only be a problem if the user is a member of many teams. [14:29] You or Curtis would be our best hopes in discovering an existing standard way of doing that. Otherwise, we can either pre-emptively attack the code (possibly having to make another table to cache the decision? sounds expensive. Do you have another idea?) or wait and see if it is a problem. [14:29] Finally, for bullet point 4, I'd be +1 on making a nice-to-have card in our display backlog lane to add the action portlet if Huw or someone else representative seems to agree. [14:31] gary_poster, bac: I believe team.adminmembers expands the list of admins with the owner (if needed) in python, which is why you've got to use it or re-implement it; not sure that's the good solution though [14:33] It sounds like it is not particularly more efficient either. I wonder... [14:33] It seems like there might be a SQL way of using the team membership table and the adminmembers to ask if a person were a member of the admins, or of admin teams [14:34] that would probably be significantly better [14:34] that code would certainly benefit from being a Collection (in LP sense of Collections) allowing easy matching/joining and resulting in a single query; doing it directly with Storm is possible as well [14:35] gary_poster, probably best for the short term, so +1 on that, though I wouldn't dwell on it and would leave it as a separate task [14:36] danilo, agreed on separate task/card. which is your short term recommendation? Storm directly? [14:36] gary_poster, yeah [14:36] cool [14:36] bac, +1 on making a card for that too then [14:36] gary_poster, long-term would be rewriting all of Team model code to use Collections :) [14:37] :-) [14:37] I don't think I'll commission that just now ;-) [14:37] bac, I will make cards for you if you want, but not till I finish the MP, and have my scheduled calls [14:37] heh, are you absolutely sure??? [14:37] lol [14:37] gary_poster: ok. sorry i was making tea [14:37] anyway, gary_poster, when do we chat? (or do you want to get hold of gmb first) [14:37] np bac [14:38] danilos, in 52 min [14:38] gary_poster: i can just hear lifeless complaining about that method, though. [14:38] gary_poster, ah, google calendar DST fuckup, ok [14:38] right [14:38] to both of you ;-) [14:38] danilos: you can make all appts in google cal be UTC [14:39] well [14:39] I want these to follow along with my timezone usually [14:39] me too [14:39] that's problematic if everyone doesn't follow your same DST rules. :) [14:40] gary_poster, we probably need to create them in UTC, and everyone sets the local time zone as appropriate [14:40] i think canonical should be a dst-free zone [14:40] if everyone would simply follow along with the *American* legislature's silly DST laws, then things would be much simpler ;-) . or, yeah, we could do what the rest of the world does, but America is not too good at that sometimes. :-) [14:41] gary_poster: we're saner than many. last year argentina's president arrived from a long trip and cancelled DST that was to begin the next day. my iphone never recovered [14:41] danilos, feel free to change, though next week we should be re-aligned [14:41] heh, this time, I don't think America is much to blame, DST itself is simply insane and if it really is to save electricity, let's just get up earlier :) [14:41] lol bac [14:41] heh [14:41] gary_poster, yeah, leaving it as-is, to see how it'll look next week [14:41] cool [14:51] bac, benji, gmb: hi guys, I'll be adding you all as my peer reviewers -- don't feel obligated to fill it in, but if you've got any input you want to share with me, I'd be happy to hear it out in there as well :) [14:52] k [14:52] sure [14:52] (if allhands.c.c lets me, since it's a pleasure to use) [14:52] Fair enough. I keep forgetting I need to do that, so I'll likely do the same. [14:53] gary_poster: i'm confounded by bmurray's work with subscribe/bugtask/bugsupervisor. i'm not convinced it is doing what he thinks ATM. [14:53] weird === gary-lunch is now known as gary_poster [14:54] gmb, I believe email from Claire said the deadline for self-evaluation and requesting peer reviews is tomorrow [14:55] Blimey. Better get on with it then. [14:55] I appear to have come unsubscribed from warthogs and allhands, which hasn't helped. [14:55] huh [14:55] yeah, I would need to do that too then :-P [14:55] danilos: Thanks for the heads-up [14:56] likewise [14:57] gmb, I think I said this before, but it's not necessarily a bad thing to be unsubscribed from warthogs@ ;) [14:57] :) [14:57] heh, it collects mail for me [14:59] "flag \Seen" sieve rule FTW :) [14:59] bac, can you give a quick explanation as to why lib/lp/registry/templates/product-portlet-license-missing.pt went from tal:content to tal:replace [14:59] ? [15:01] gary_poster: replace is correct since it is using 'structure' the replacement value has an anchor in it. with 'content' there was an within an [15:01] perfect, thanks bac [15:01] it came up b/c i was doing so much work with the web inspector console open i discovered a lot of HTML errors, like the one i showed you yesterday [15:02] we should have an automated manner of finding those [15:02] * gary_poster wonders if tidy is better these days or what the alternatives are now [15:02] though that would have had a hard time ctahcing this [15:02] we kinda want something spidering the rendered site [15:03] and telling us about oopsies [15:04] bac, could you please scan over the MP draft http://pastebin.ubuntu.com/584864/plain/ and give me corrections/additions/ etc.? [15:04] it's pretty bare bones [15:04] ok [15:04] but I didn't have time for much else [15:05] eh, XXX should be replaced with the string "lib/lp/registry/javascript/tests/test_structural_subscription.js : Test code." [15:06] gary_poster: i'm pretty sure these are left-overs from an aborted first effort: [15:06] lib/lp/app/javascript/accordionoverlay.js : simple base class for adding an accordion within an overlay. [15:06] lib/lp/app/javascript/tests/test_accordionoverlay.js : test. [15:06] a quick grep should show they are not used [15:06] it is my fault for leaving them around [15:07] ok, will do, bac. Also, a lint shows a lot of tab characters in the JS. I don't know who introduced them, but to your knowledge they are not intentional, right? [15:07] gary_poster: my emacs was dumb wrt JS at the beginning. it has been emsmartened [15:07] :-) [15:07] k [15:07] I'll clean those up too [15:08] (of course it now strips tabs from makefiles, which is irritating) [15:08] heh [15:08] gary_poster: the remainder of the letter looks fine to me. it is quite concise. well done. [15:09] thanks bac [15:09] regarding windmill, i think we need something [15:10] for instance, the unit tests in test_subscription_links work happily even if the bits to invoke the JS setup are missing from the page template [15:10] yup [15:10] the JS is "well" tested [15:10] :-) [15:10] so i think we need windmill to just show the links are visible and have js-action class [15:11] sounds good. I'll add that as a note. [15:15] hi gmb, can you help me unravel some bugs infrastructure? [15:15] bac: I can try. What's up? [15:16] gmb: could you tell me where i'd see BugsTaskSearchListingMenu in use for an IDistribution? [15:16] would that be bugs.launchpad.dev/ubuntu ? [15:17] there is funky logic for when the subscribe link is shown but i'm unconvinced it works [15:18] Hmm [15:19] bac: Yes, I think bugs.l.n/ubuntu should work. [15:20] ok [15:20] thanks for the sanity check. bugs views aren't nearly as straightforward as others... [15:21] Nope. The joys of working on one of the oldest bits of the system I guess. [15:21] There are times I'd like to find Brad Bollenbach and ask "what were you thinking?" [15:29] Fixing line length lint in JS: not my idea of a good time. [15:39] gmb, ok, https://code.launchpad.net/~gary/launchpad/accordion-client-1/+merge/54715 is calculating a diff. Sorry it took so long, but I had to do a few cleanups. Oh, I should have added in the MP that lint is happy. Quick call?> [15:40] gary_poster: Sure. Let me get my mumble on. [15:40] cool [15:44] gary_poster, hi, ping me when you are done with gmb and/or ready for our own 1-on-1 :) [15:46] cool [15:50] danilos, ready when you are [16:05] gary_poster, LP_DEBUG_SQL [16:05] gary_poster, LP_DEBUG_SQL=1 === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [16:45] gary_poster, bac: On line 327 of the diff here https://code.launchpad.net/~gary/launchpad/accordion-client-1/+merge/54715, the feature flag that gets looked up is 'advanced-structural-subscriptions.enabled'. I thought this had been changed to 'malone.advanced...'; is that the case? If so, is this branch up-to-date? [16:47] gmb, it is not up to date [16:47] Ah. [16:47] that work is being done in a separate branch [16:47] Ok. Works for me. [16:47] cool === Ursinha is now known as Ursinha-lunch [16:54] bac, I'm going to go lunch. Should I start the milestone when I return? [16:54] I don't have a lot of time actually [16:55] But I might be able to get it done. [16:55] (before tomorrow I mean) [16:55] ...back in about an hour [18:07] * gmb -> afk for a while; about half way through the mega review and in need of a brain break === Ursinha-lunch is now known as Ursinha [18:31] gary_poster: chat? [18:32] bac, we have an emergency that we are on the hook for: bug emails are not going out. I'm trying to do a bit of investigation. will be ready in a few. s'ok [18:32] ? [18:33] gary_poster: np, ping me when ready [18:33] thanks will do [18:55] gary_poster: FYI, I just got some bug mail. [18:56] benji, cool, from how long ago? [18:58] gary_poster: it's hard to say, but Leonard just commented on the bug 5 minutes ago (but that comment wasn't incldued in the mail) [19:00] gary_poster: it seems that teh email was sent as a result of marking the bug fix released at 2011-03-24 18:50:04 [19:01] (which was about 10 minutes ago) [19:02] benji thanks [19:30] gary_poster: I figure you've seen these emails, but just in case: "The script 'send-bug-notifications' didn't run on 'loganberry' between 2011-03-24 18:07:04 and 2011-03-24 19:07:04 (last seen 2011-03-24 15:55:20.954998)" [19:30] yeah, thanks benji. the odd thing is that it did run then :-/ [19:30] according to the log [19:31] hmm [19:31] does "didn't run" mean ran but had a non-zero exit value? [19:31] not sure [19:36] hmm, maybe there is a watchdog process that has expectations about when scripts should run and it somehow tracks when they run (through log files?) [20:15] benji, call soon :-P [22:08] gary_poster: Around? [22:08] gmb, sadly, yes :-) [22:08] gary_poster: Heh. It's 22:08 local time, so I feel your pain. [22:09] yeah, you have it worse, def :-) [22:09] Anyway, the accordion client branch (1) is r=me but needs some work before it lands. I don't think any changes will be massive, but if they are someone else can easily add a review vote; I didn't want it to be blocked on me whilst I'm away. [22:11] gmb, sounds good, and reasonable [22:11] thank you gmb [22:11] np [22:11] have a good night and a nice few days [22:12] Thanks; I will. [22:12] * gmb leaves. [22:12] :-)