pooliejelmer, hi00:25
jelmerhello again :)00:25
pooliejelmer, so i think the lep is as far forward as makes sense for something that's just queued up00:26
poolieif we're going to actually start it, it should be made a bit tighter about requirements00:26
poolieprobably make sure all the issues people raised are addressed00:26
poolieand then break out some particular bugs00:26
poolieall with a tag00:26
jelmerpoolie: ah, ok00:27
jelmerpoolie: is it still waiting for anything, or should one or more of us just go over it to make sure all requirements are addressed?00:28
poolienothing else00:29
pooliethat would be great00:29
poolieif you'd like to start on it00:29
jelmermight as well00:30
LPCIBotProject windmill build #101: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill/101/00:36
jelmersleep first though, g'night!00:37
lifelesswgrant: how much work is sitting unreleased on lh trunk ?00:38
wgrantlifeless: 11 revs... start/stop-loggerhead are gone (deprecated long ago), a couple of logging changes that seem harmless.00:43
wgrantOtherwise just optimisations and UI tweaks.00:43
lifelesswgrant: feel like doing a 1.19 ?00:44
lifelesswgrant: my thinking is: we have radical stuff in the pipeline00:44
lifelessbe nice to get the incremental stuff 'out there'00:44
wgrantlifeless: i might talk to jam about that tonight.00:44
lifelessand you're already fiddling with all the policy etc etc00:44
wgrantlifeless: Oh, you mean "unreleased" as in everything since 1.18, not since our last rev?00:45
lifelesswgrant: yes00:45
lifelesswgrant: the stuff on trunk we should deploy, thats not done because of unfamiliarity with the mechanism for jam00:45
wgrantThere's only a few revs more. 1.18 was 421. There's the new theme, what look like bzr compat fixes, and the HEAD changes.00:46
wgrantAnd a favicon change.00:46
wgrantSo all releasable.00:46
wgrantIf we're going to start doing more radical stuff, we should indeed release.00:46
lifelesshistorydb is more radical00:46
wgrantRight, but I'm not sure how close that is.00:46
lifelessI think it would be nice to have a modern loggerhead equivalentish to our deploy before that tracks forward00:47
lifelesswgrant: not all that far off00:47
james_wwho did the new theme?00:47
wgrantlifeless: https://code.launchpad.net/~wgrant/launchpad/new-loggerhead/+merge/5480300:47
wgrantjames_w: huwshimi, I believe.00:47
james_wthanks huwshimi00:47
huwshimijames_w: Yeah you can blame me :)00:48
james_whuwshimi, far from it :-) it's a great and sorely needed improvement00:48
huwshimijames_w: Hopefully it'll be integrated with Launchpad further at some point, but it's a start00:49
james_whuwshimi, two questions, do we need all the duplication of the (i) icons? and can we have the commit message wrap if it's too long?00:50
james_we.g. http://bazaar.launchpad.net/~offspring-hackers/offspring/trunk/files00:50
james_w(for me at least with 1280px width)00:50
huwshimijames_w: Do you mean the icons for "view revision" and "view branch changes"?00:51
james_wthere's more on the file pages00:52
james_wthat's a lot of informative links00:52
huwshimijames_w: It's not great, but that's the way we do sub navigation elsewhere in Launchpad00:55
huwshimijames_w: Can you please file a bug about the commit message length?00:55
james_whuwshimi, fair enough00:56
huwshimijames_w: I will be address a lot of things like that soon00:56
james_whuwshimi, do you want a separate one for http://bazaar.launchpad.net/~offspring-hackers/offspring/trunk/changes00:56
james_wwhere if you expand the top revision it gets loooooong00:56
james_wand http://bazaar.launchpad.net/~offspring-hackers/offspring/trunk/revision/60 I guess, which is the worst yet :-)00:57
james_walso, bugs against loggerhead or launchpad? tags? subscribers?00:57
huwshimithey should be bugs against loggerhead00:57
huwshimijust tag them as ui and you can add me as a subscriber00:58
james_wok, thanks00:58
huwshimijames_w: Thank you for noticing (and caring)00:58
james_wit's great to have someone to raise these with again :-)00:59
huwshimijames_w: oh and with the lengths you can probably put it all in one bug but link to all those pages00:59
james_wbug 74217801:00
_mup_Bug #742178: doesn't handle long commit messages well <ui> <loggerhead:New> < https://launchpad.net/bugs/742178 >01:00
huwshimijames_w: Thanks heaps01:01
mwhudsonah it would be good to have someone who knows some css look at those01:16
lifelessI want a teddy bear01:29
lifelessto talk webservice collection offset tuning with01:29
lifelessto the sound of o/~ I need a hero01:29
spmnothing here but us crickets01:31
lifelesscrickets are good01:32
lifelessspm: hey, can you explain analyze a query on prod for me - looking for cold cache again01:32
_mup_Bug #736008: Product:+code-index timeouts <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/736008 >01:32
spmlifeless: https://pastebin.canonical.com/45213/01:34
lifelessspm: thanks01:36
lifelessspm: could you run the same query, not explained - the actual query - on another server?01:38
spmsure, one sec.01:38
spmlifeless: count: 168, Time: 125.128 ms lp_101:42
lifelessspm: woo,t hanks.01:46
lifelesshot shit query01:46
spmas opposed to warm?01:47
lifelessrun it again :)01:47
spmTime: 62.076 ms01:47
lifelessI have oopses with it at 700ms01:47
spm110; then 3 x 171's.01:47
lifelessthe older version01:47
lifelesslet me grab that01:47
spmis stabilising at 171ish.01:48
lifeless1521ms + 589ms01:49
lifelessis the original01:49
lifelesswhich is 4.6 seconds coldish on qas01:50
lifelessand 650 hot01:50
lifelessso yeah, I'm pretty happy with the improvment01:50
lifelessthe new plan is missing the sequential scan on branch :)01:51
mwhudsonthe tuple read rates that stub produced seem to indicate that something was sequential scanning branch about once a second01:53
mwhudsonlifeless: could you have found that?01:53
lifelesscode:+index is the page01:56
lifelessppr will tell us hits01:56
lifelessI would expect multiple causes01:56
mwhudsoni guess any branch filtering is similar queries01:56
lifelessthe double subqueries were either too complex or constrained for some corner case - I think the thing was that they were different01:57
* mwhudson wonders what fraction of branches are private... 01:57
lifelessso pgsql wasn't coalescing them01:57
lifelessmwhudson: 3 5ths of bugger all01:58
mwhudsonif they hit 10% of the table or whatever the threshold is i wildly speculate that we'd have the sequential scans back01:58
mwhudsonbut that's unlikely01:58
lifelessproblem for another day01:59
lifelessyou'd actually need 10% of the table for *one context*01:59
mwhudsonoh righ t:)01:59
lifelessmwhudson: I'm so glad you are here though, you can answer something flummoxing me01:59
lifelessmwhudson: why does the original (and the new one because i kept it) only constraint the source branch to the product01:59
mwhudsonlifeless: don't know02:00
mwhudsoni guess you can end up with the products being different if you move one of the branches after the mp is created02:00
lifelessright, but why does moving the target not hide the count; but moving the source does ?02:01
mwhudsonconstraining the target branch would seem a bit less wrong though ...02:01
lifeless*hige it from the count*02:01
mwhudsonlifeless: i bet that whoever wrote this (possibly named after a disney rabbit) assumed that source target and target target are always the same and 'optimized' it02:02
mwhudsonlifeless: just a guess though02:02
lifelesstactfully put02:02
lifelesssee the thing is02:02
lifelessif the target was constrained the original query is fine02:02
lifelessuhm, if 'source and target are constrained'02:03
mwhudsonheh heh heh02:03
lifelessDistributionSourcePackage:+code-index 54002:03
mwhudsonyes, my guess doesn't make much sense on that level does it?02:03
lifelessProduct:+code-index 496502:03
mwhudsonmore constraints -> faster query (generally)02:04
lifelessmwhudson: yes02:04
lifelessmwhudson: so, 5500 hits a day02:04
lifelessmwhudson: 2 runs of the query each hit02:04
lifeless11K query runs a day02:04
lifeless710983.85 is pretty high02:05
mwhudsonlifeless: it's one of these slightly horrible things, we /try/ fairly hard to enforce target target == source target, but i don't think we can completely02:05
lifelessmwhudson: we can choose to just not report the exceptions :>02:05
mwhudsonyeah, i think that would be fine02:05
mwhudsonlifeless: what is 710983.85 ?02:05
lifelessbranch tuples read per second02:05
mwhudsonah right02:06
mwhudsonyes it is02:06
lifeless> 3 * bugtask reads02:06
lifelessand bugs are much higher user activity than branches02:06
lifelessI remember one of the branch thoughts02:06
lifeless'url -> disk mapping'02:06
lifelessstill several OOM too high02:07
StevenKYou should not import patch_entry_explicit_version from canonical.launchpad.components.apihelpers:02:07
mwhudsoni'm pretty sure that doesn't seqscan...02:07
StevenKDid that change recently?02:07
lifelessStevenK: add it to __all__02:07
lifelessmwhudson: it doesn't02:07
mwhudsonor even read more than a handful of tuples, so yeah, like you said, an OOM out02:08
mwhudsonat least02:08
mwhudsoni wonder how much cpu 396125.47 tuples/sec uses, it must be more than 0.01% though, and 'rewrite' isn't a user on https://devpad.canonical.com/~lpqateam/dbr/last-15-mins.txt02:09
mwhudsonlifeless: the pillarname read count is demented too, but at least it's obviously a table that gets accessed an awful lot02:11
lifelessremember that foreign keys on updates take locks02:11
lifelesspossibly on reads too,but I'd need to double check that02:12
lifelesssinzui: ping02:20
lifelesssinzui: if you're around; how would you and jc feel about my stabbing at CVE:+index; its consitently 2nd or third on the oops report at the moment02:21
wgrantWhat is the scanner doing these last few days?02:26
wgrant1600 OOPSes...02:27
LPCIBotProject db-devel build #488: FAILURE in 4 hr 58 min: https://lpci.wedontsleep.org/job/db-devel/488/02:35
lifelesswgrant: bug is filed ;)02:37
sinzuilifeless: go ahead on the cve:+index jcsacket and I were to busy to work on it today02:56
huwshimilifeless: Just taking a look at the AJAX logging stuff. What's involved in getting the URL into the header?02:56
lifelesshuwshimi: one cheap hack would be to change the publisher to add an X-header unconditionally on every reponse with the url it got02:57
lifelesshuwshimi: e.g. probably not much02:57
huwshimilifeless: Is this going to be bad for us in any way?03:00
lifelesshuwshimi: slightly more response overhead03:01
lifelesshuwshimi: if someone sends a 4K request, they'll get 4K more back03:01
lifelesshuwshimi: (4K URL I mean)03:01
huwshimilifeless: Will it be enough of an impact for us not to do it?03:02
wgrantYou can't get at the request from the response?03:02
huwshimiwgrant: Well this is not really the response. It's an event that fires every time an AJAX even completes, with no other knowledge about the request except what is returned03:04
lifelesshuwshimi: I think we can do it, will just want a brief walk-by the usual suspects to look for gotchas03:05
wgranthuwshimi: :(03:06
huwshimilifeless: I may have just thought of a way to do it without the header, thanks to wgrant's question. I'll have a quick try03:07
lifelesshuwshimi: care to file a bug asking for an X-LP-URL header, and mail the -dev list for feedback.03:07
lifelesshuwshimi: if you can't get it, of course03:07
huwshimilifeless: Sure03:07
lifelessCollections may be great for adhoc assembly03:41
lifelessbut they are terrible for optimisation.03:41
* lifeless puts on the wet blanket hat03:41
* StevenK grumbles.03:47
StevenKI think python-debian has a bug in it's regex to parse valid versions03:48
wgrantStevenK: Is it meant to only parse valid versions?03:48
wgrantAlso, why is the solution to AJAX being too slow to limit it to only a few bugtasks? :(03:49
StevenKwgrant: It accepts : in the upstream version all the time, but that's only valid if there is a epoch.03:49
huwshimilifeless: OK I can't reliably get it this way. Is the code for managing the headers outside of Launchpad?03:49
StevenK(Pulling from my memory, so I could be wrong.)03:49
StevenKwgrant: It has a re_valid_version regex defined, so I doubt it. I think the regex is naive.03:50
wgrantStevenK: I don't think it's valuable for it to be terribly pedantic, really.03:50
lifelesshuwshimi: we'd put it in lib/canonical/launchpad/(publisher|publication).py I think.03:51
StevenKwgrant: In this case, the version that sorts the highest is invalid, and so we can't set it in the DB, due to integry rules.03:51
lifelesshuwshimi: there are some interactions with the api, but I'm 99% sure that starting there would get what we need easily enough03:51
StevenKwgrant: So I'd like to filter invalid versions from the ancestry sets.03:52
wgrantStevenK: Right.03:52
StevenKwgrant: And I'm having trouble convincing debian_support.BaseVersion that "a1:1.8.8-070403-1~priv1" really is invalid.03:53
StevenKDue to it accepting : in upstream version, it thinks epoch is None, and the upstream version is "a1:1.8.8-070403", which is just wrong.03:54
wgrantEr, thinks the epoch is None?03:54
wgrantThat's a bug.03:54
wgrantMissing epoch is 0.03:54
StevenKBut it isn't missing, it's invalid :-)03:55
StevenK% bin/py foo03:57
StevenKVersion: a1:1.8.8-070403-1~priv103:57
StevenKEpoch: None03:57
wgrantAh, true.03:57
StevenKIIRC, you can only have :'s in the upstream version iff there is an epoch.03:58
wgrantThat's right.03:58
wgrantOtherwise it's ambiguous.03:58
wgrant"This is a single (generally small) unsigned integer. It may be omitted, in which case zero is assumed. If it is omitted then the upstream_version may not contain any colons."03:58
StevenKwgrant: Have a look at python-debian in sourcecode, the re_valid_version is wrong, then.03:59
wgrantStevenK: I can't really fault it on that. Be conservative in what you do, be liberal in what you accept from others, and all that.04:00
StevenKwgrant: Suggestions on how to filter invalid versions out of ancestry, then?04:01
wgrantStevenK: I'm not sure what's best.04:02
wgrantlifeless: Oh?04:02
wgrantlifeless: What completely naïve and non-performant code have you found now?04:02
lifelesswgrant: GenericBranchCollection uses storm expresses to express constraints04:02
lifelesswgrant: so I have to unwind them to get the clause to regenerate it with class aliases.04:03
lifelessbecause it discards the original context04:03
lifelessin the adapter04:03
StevenKwgrant: I'm struggling to come up with *any* solution that doesn't involve hacking debian_support.BaseVersion04:03
lifelesswgrant: its Yet Another Compiler.04:03
lifelessI should suggest a code review rule : no more compilers.04:03
StevenKgcc 4 lyfe?04:04
lifelessStevenK: collections are compilers; wadl creation is a compiler, storm is a compiler.04:04
lifelessStevenK: BugTaskSet.searchTasks is a compiler04:04
lifelessStevenK: nearly everything that is easy to use and hard to make fast, is a compiler.04:05
StevenKI didn't need the explanation, I was trolling.04:05
poolielifeless, i'm glad you asked for a simple reproduction because i no longer seem to be able to hit it :)04:15
lifelesspoolie: heh04:16
pooliethis is actually astonishingly fast04:16
pooliei think something must be wrong04:16
pooliemm i wasn't measuring the hard part04:21
pooliedamn all software that tries to pretend the network is transparent04:21
pooliei wonder if i was just measuring some transient misbehaviour before04:21
poolieanyhow, the good thing is that if this works, it may make kanbans much faster04:22
poolielifeless, the numbers from that script are just astonishingly good04:30
poolie0.96s for some queries04:30
pooliei never saw sub-second calls from australia before04:31
poolie(i guess that's on a warm socket)04:31
spivHappiness is a warm socket.04:31
poolieyeah apparently so04:31
wgrantMaybe gandwana and potassium finally decided to die.04:31
pooliewhat would that mean, wgrant?04:32
wgrantpoolie: Well, it would speed up requests.04:32
wgrantSince those two are multithreaded, slow, and the source of most of our timeouts.04:32
pooliebecause they're slow appservers?04:33
wgrantSlow and misconfigured.04:33
StevenKwgrant: Didn't we port some version validator from somewhere in Soyuz?04:41
wgrantStevenK: You mean the one that's in the database?04:42
StevenKwgrant: That one feels a little heavyweight for validating versions04:43
StevenKwgrant: Dpkg::Version::version_check would be nice, but I can't use that04:45
LPCIBotProject windmill build #102: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill/102/04:51
wgrantwallyworld: Those two Windmill failures look like yours, I think.04:53
wallyworldwgrant: oh :-(04:53
wallyworldi'msure they passed locally :-(04:54
wallyworldwgrant: https://code.launchpad.net/~wallyworld/launchpad/recipe-text-xss/+merge/5463804:54
lifeless 1 file changed, 31 insertions(+), 35 deletions(-)04:54
* wallyworld has to go get kid from school04:54
lifelessdeleting code *and* making things faster04:54
huwshimilifeless: Any suggestions on how I can break an AJAX request so it returns an exception?04:57
huwshimilifeless: I mean returns an oops id04:57
lifelessbreak the server side code04:58
lifelessraise Exception('zomg')04:58
lifelessto the code path04:58
huwshimilifeless: ok04:58
poolielifeless, i think some other change must have fixed it04:58
lifelesshuwshimi: your demo was -really really shiny-04:59
pooliei'm running the same code i was then and i no longer see the effect04:59
lifelesspoolie: sure04:59
lifelesspoolie: I believe that you saw it04:59
lifelesspoolie: I *suspect* it was doing a full text search for '' or something equally daft04:59
lifeless(we repacked the fti index for bug recently)04:59
lifeless[amongst other fixes such as improving component fixes, related bugs yada yada yada]05:00
pooliei certainly wasn't asking for that05:00
poolieit's possible that lplib or the server did end up doing it05:00
lifelesspoolie: thats what I'm sketching05:00
lifelessits the only thing I can think of that might vary05:00
poolieanyhow, the bottom line on performance is actually quite interesting:05:00
lifelessbecause the collections are really just function calls to searchTasks05:00
pooliesingle calls are quite impressively fast05:00
pooliehowever, if you have to do 600 of them, not so much05:01
pooliethus my braindump05:01
lifelesspoolie: sure; that aspect has been heavily sketched out in the filter+expand API LEP05:01
huwshimilifeless: OK, I don't know enough about Launchpad's internals to break this request. Any clues about where to look?05:24
huwshimilifeless: Also are there any time recommendations that we have for AJAX requests? E.g. over 5 seconds is very bad under 2 seconds is good05:37
=== almaisan-away is now known as al-maisan
lifelesshuwshimi: ajax requests are no different than others05:48
lifelesshuwshimi: we're (long term) aiming at subsecond for 99% of requests and under 5 seconds for all05:48
lifelesshuwshimi: current timeout limit is 11 seconds05:48
lifelesshuwshimi: I think colouring anything > 1 second a vivid shade would be sensible ;)05:48
huwshimilifeless: OK, I'll do >1 second for now05:49
lifelessmost ajax things should be very targeted operations05:50
lifelessunlike e.g. a bug listing page05:50
lifelessat least for now05:50
micahghi lifeless05:51
=== al-maisan is now known as almaisan-away
micahglifeless: so, several years ago, I wrote some javascript code to output an HTML table that needed to be displayed multiple times on a page (i.e. output with document.write) and that sped up load time tremendously, could something like that work as a stop gap for the repetitive JS code until it can be refactored properly?05:55
=== almaisan-away is now known as al-maisan
lifelessmicahg: that sounds like it would be refactoring it properly05:56
huwshimilifeless: so, any clues on how API internals work. Like, where does the API code for bugs live?05:56
=== wallyworld changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | firefighting: | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews
=== wallyworld changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews
lifelesshuwshimi: lib/lp/bugs/model05:57
lifelesshuwshimi: whats the url you are calling ?05:57
micahglifeless: well, no this would just output the javascript inline as opposed to using a function w/params and have one copy of the JS code in the rendered page05:57
huwshimilifeless: But if I raise the exception there won't it be broken for the normal request as well?05:57
lifelesshuwshimi: yes05:57
lifelesshuwshimi: are you trying to check it works, or write an automated test ?05:57
huwshimilifeless: I'm trying to check it works05:58
lifelesshuwshimi: because, for the latter, its a bit complex: we don't want /any/ broken apis in the system, so you have to register a broken one temporarily, use it, then unregister in your test.05:58
wgrantlifeless: Are you sure your +needs-packaging change is OK?05:58
lifelesshuwshimi: right, so pick something - like mark as duplicate05:58
lifelesswgrant: if I marked it as such, I tested it on qastaging05:59
lifelesswgrant: why do you ask ?05:59
wgrantlifeless: It's not QA'd yet, but it's gone from timing out on lpnet to 0.2s on qas.05:59
wgrantSo I'm a bit suspicious.05:59
lifelesswgrant: sounds right05:59
wgrantThe results look fine.06:00
wgrantBut the time is not plausible.06:00
lifelessoh ye of little faith06:00
lifelesshttps://answers.qastaging.launchpad.net/ubuntu/karmic/+needs-packaging was 2.43 on qastaging06:02
* lifeless looks at a profile06:02
wgrantnatty's first batch is 0.20 to 0.25s.06:03
wgrant0.17 just now.06:03
lifeless00294-01256 SELECT COUNT(*) FROM SourcePackageName, (SELECT ...06:04
lifeless01259-02197@SQL-launchpad-main-slave SELECT DISTINCT ON (score ...06:04
lifelessit looks plausible to me06:04
lifelesswgrant: you do realise it has memcache in there06:04
lifelesswgrant: which I didn't touch06:04
wgrantIndeed. a more plausible 1.7s on the next batch..06:05
lifelesswgrant: 2.5 seconds cold, 0.2 in memcache06:05
lifelessI think its qa ok indeed06:05
lifelessmarked as such06:05
lifelesswgrant: I'll whip through and do all mine06:05
wgrantlifeless: Great. I'm doing the others'.06:06
micahglifeless: so, I commented on bug 735966, but almost instantly regretted it, is that the same bug?06:16
_mup_Bug #735966: Product:+bugs timeouts <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/735966 >06:16
micahgI hit the crash again, so I figured I'd confirm06:16
* StevenK nails wgrant to the channel06:19
wgrantThanks Optus.06:19
wgrantWe were throttled for almost 10 minutes.06:20
wgrantTo 28kbps.06:20
wgrantDespite being at 70% of our quota...06:20
huwshimilifeless: Gotta run in a minute, but this is where I'm leaving it for today: http://people.canonical.com/~huwshimi/ajax_time_log.ogv06:24
* huwshimi is gone06:29
lifelessmicahg: may be, may not be :P06:38
micahglifeless: should I file a new bug with my new oops code and you can dupe if appropriate?06:46
lifelessno need06:46
micahgok, do you want the oops?06:47
lifelessyou put it in the comment already06:47
micahglifeless: no, I got a new one today06:47
StevenKwgrant: http://pastebin.ubuntu.com/585234/ makes me sad.06:59
wgrantStevenK: Doesn't that forbid upstream versions with colons?07:01
StevenKwgrant: Probably.07:03
StevenKwgrant: I looked at the check_version sub in Dpkg::Version, and I didn't feel like porting it to Python so I can use it. But I suspect it's the better answer.07:04
wgrantStevenK: So python-debian doesn't have a useful checker? What about python-apt?07:05
StevenKwgrant: I couldn't see one in apt_pkg07:05
StevenKwgrant: python-debian's checker is too lax for our needs, since the DB's own checker is strict.07:05
StevenKDoing it in one regex is not the way07:06
wgrant:( qa-bad07:08
StevenKwgrant: Which rev? :-(07:08
wgrantStevenK: The Soyuz translations change.07:09
wgrantMissing DB perms.07:09
StevenKWhich points to missing tests, too.07:10
StevenKI think the qa-tagger needs to run more often07:14
lifelessmicahg: probably hasn't changed07:21
micahglifeless: ok07:21
wgrantHuh, translations sharing works.07:23
henningewgrant: Hi!07:24
wgranthenninge: Hi.07:24
henningewgrant: why did you mark bug 741571 bad?07:25
_mup_Bug #741571: Translation templates should always be uploaded from soyuz builds. <qa-bad> <regression> <upstream-translations-sharing> <Launchpad itself:Fix Committed by henninge> < https://launchpad.net/bugs/741571 >07:25
wgrantJust testing out the Soyuz translations changes on DF.07:25
wgranthenninge: I'm going to comment in a sec.07:25
wgrantBut there's a missing DB perm.07:25
wgrantqueued needs SELECT on packaging.07:25
wgrantApart from that it seems to be OK.07:25
wgrantI think I've just got an upstream template in place, so we'll see now if the POs are skipped...07:26
lifelesswgrant: is it for the jon thats not running et ?07:26
henningeyeah, it's actually a pretty simple change, so I'd have been surprised if it went wrong.07:26
wgrantlifeless: It's running.07:26
wgrantlifeless: But on germanium/cocoplum.07:26
wgrantSo we can nodowntime with a little process skipping.07:26
henningewgrant: thanks, I was about to try to find out how I could QA this best.07:26
wgranthenninge: Could you QA your other change? The big cleanup thing?07:27
henningewgrant: yes, I am doing that atm.07:27
wgrantbuildbot should finish shortly.07:28
henningealthough it's a lot of refactoring, so this is mostly "see that nothing broke".07:28
StevenKHow many revs will the buildbot-poller pull in?07:30
wgrantStevenK: 107:30
wgranthenninge: https://translations.dogfood.launchpad.net/ubuntu/maverick/+source/hello/+imports?field.filter_status=NEEDS_REVIEW&field.filter_extension=all07:30
wgrantNo POs.07:31
LPCIBotYippie, build fixed!07:36
LPCIBotProject db-devel build #489: FIXED in 5 hr 0 min: https://lpci.wedontsleep.org/job/db-devel/489/07:36
lifeless\o/ private branch query on lp with me is still only 500ms07:39
lifelesswe need to redo the privacy queries comprehensively, but this will do for now07:39
=== al-maisan is now known as almaisan-away
henningewgrant: cool, thanks!07:56
henningewgrant: so, we need a branch for the db permission?07:56
wgranthenninge: Yeah, ideally with tests.07:56
wgranthenninge: Can your squad handle that soonish?07:57
henningewgrant: yeah, sure07:57
wgranthenninge: Thanks.07:58
wgrantlifeless: Should we deploy even with the missing DB perm?07:59
wgrantwin 308:00
lifelesswgrant: will it break ?08:10
lifelesswgrant: can we avoid it breaking ?08:10
wgrantlifeless: It only affects cocoplum.08:11
wgrantWhich is way outside nodowntime.08:11
lifelesswgrant: +108:12
wgrantlifeless: Thanks.08:12
wgranthenninge: Should we just qa-untestable that refactor?08:31
henningewgrant: yeah, I was thinking about that too. I am busy now with the missing db permissions.08:32
wgranthenninge: Have you filed a bug?08:32
henningewgrant: do I need to? I was going to do it on the existing bug.08:33
henningeI can, np.08:33
wgranthenninge: We are going to deploy this broken code, so I'd like a Critical one targetted to 11.04 to make sure we fix it before it's deployed to the relevant machines.08:33
henningewgrant: makes sense. I'll file it.08:34
wgranthenninge: Thanks.08:35
henningewgrant: are both cocoplum and germanium production machines?08:38
wgranthenninge: Yes.08:38
wgranthenninge: cocoplum = ftpmaster, germanium = ppa08:38
wgrantNeither is nodowntime.08:38
henningewgrant: bug 74230908:39
_mup_Bug #742309: Missing db permissions for soyuz translation uploads. <upstream-translations-sharing> <Launchpad itself:In Progress by henninge> < https://launchpad.net/bugs/742309 >08:39
wgranthenninge: Thanks.08:39
lifelessright, works08:47
lifeless branchcollection.py |   85 +++++++++++++++++++++++-----------------------------08:47
lifeless 1 file changed, 39 insertions(+), 46 deletions(-)08:47
adeuringgood morning08:48
henningeHi adeuring!08:53
adeuringhi henninge08:54
henningeadeuring: bug 74230908:54
_mup_Bug #742309: Missing db permissions for soyuz translation uploads. <upstream-translations-sharing> <Launchpad itself:In Progress by henninge> < https://launchpad.net/bugs/742309 >08:54
lifelesscan has review? https://code.launchpad.net/~lifeless/launchpad/bug-736008/+merge/5482008:54
adeuringlifeless: sure08:54
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring | https://code.launchpad.net/launchpad-project/+activereviews
henningeadeuring: just so you know. ;)08:55
adeuringhenninge: ah, thanks, now i understand08:55
lifelessadeuring: https://bugs.launchpad.net/launchpad/+bug/736008 has all the experimentation for that branch, if you want the backstory09:03
_mup_Bug #736008: Product:+code-index timeouts <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/736008 >09:04
LPCIBotProject windmill build #103: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill/103/09:05
lifelessoh god09:09
lifelessno wonder jc had trouble on cve:+index. its bugtask:+index all over again09:09
=== almaisan-away is now known as al-maisan
henningewgrant, adeuring: https://code.launchpad.net/~henninge/launchpad/devel-741571-db-permissions/+merge/5482309:13
henningeIf either of you could be so kind.09:13
henningeI have to run an errand now but will be back later to land it.09:14
adeuringhenninge: i'll once I've finished robert's mp09:14
henningeI don't see how this branch would profit from a full test suite run.09:14
henningeadeuring: thanks09:14
wgranthenninge: As long as you've run the new test then lp-land it.09:14
henningeof course ;-)09:14
=== henninge is now known as henninge-afk
lifeless262 queries/external actions issued in 6.15 seconds09:29
lifelessoh, rotfl09:29
lifelessI crewated 200 or so tasks for it09:29
lifelessProduct-name903534, Product-name903544 etc09:30
wgrantI'm surprised shortlist didn't slap you.09:30
adeuringlifeless: r=me09:49
lifelessadeuring: thanks09:50
lifelesshttps://lp-oops.canonical.com/oops.py/?oopsid=1904QS73 query 30409:52
spivlifeless: at least it's quick!09:54
lifelessspiv: indeed09:55
adeuringhenninge-afk: r=me, 1 typo spotted09:56
lifelessstub: ping10:06
stublifeless: pong10:07
lifelessbug 61840610:07
_mup_Bug #618406: Distribution:+bugs-index time outs <lp-bugs> <pg83> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/618406 >10:07
lifelessstub: I'm wondering if a matching index is better than modifying the query10:07
lifelessbugheat__id__idx on (Bug.heat DESC, BugTask.id)10:08
stublifeless: You would have to denormalize the heat onto bugtask for that index.10:11
lifelessstub: bwah, of course10:12
lifelessI'm just tired and forgetting10:12
stubA (Bug.heat, Bug.id) might help though - join and order in one step10:13
stubAlthough we would likely need to change the ordering to (Bug.heat DESC, Bug.id DESC), and get rows ordered inconsistently if there happen to be more than one bug task being matched.10:15
lifelessstub: (bug.heat desc, bug.id) would work fine10:20
lifelessstub: the index can sort different columns differently afte rall10:20
stubThats new too10:20
lifelessnot sure when it was added, but definitely existed in 8.310:21
stubYou used to have to make the index match. 8.3 is new - This all used to run under 7.4 remember, and I started with PG 7.0 :)10:21
lifelessyou do need it to match10:22
lifelessyou have to tell the index that one column is up and one down10:22
stubok. we are on the same page :)10:22
stubI could rationalise that newer bugs are hotter, all else being equal10:23
lifelessor older bugs need fixing more ;)10:23
lifelesshttp://www.postgresql.org/docs/8.4/static/indexes-ordering.html is the docs10:24
lifelesswhy oh why do cve pages show bug editing controls.10:27
=== henninge-afk is now known as henninge
henningeadeuring: thanks10:38
henningewgrant: fix has been merged10:51
* henninge relocates.10:51
wgrantherb: Fantastic. Thanks.10:52
leonardrwallyworld_, i'm up if you want to talk (on irc, my wife is asleep)10:54
=== al-maisan is now known as almaisan-away
deryckMorning, all.11:00
=== jtv is now known as jtv-eat
mrevellShould debhelper be a dependency of bzr-builder?11:33
lifelessstub: will you add such an index?11:34
stublifeless: I will test later - doing my paperwork atm. I think it unlikely to help, but worth giving it a shot anyway.11:35
stub(This is the bug.head, bug.id index?)11:35
lifelessbug.heat, bug.id desc11:35
lifelesssorted by heat alone its a 3ms query11:35
lifelessor something rad like that11:36
lifelessstub: thanks11:39
stublifeless: I doubt we can improve on that. I guess the results might be more stable if we add more fields, but I think faster queries will be the preference.11:40
lifelessstub: right, the question is, is heat desc + id fast enough - if it is, its a trivial change, add the index, done.11:42
lifelessif its not, we have to see if we break the test suite etc etc11:43
lifelessmmm, I guess we may anyway with bug.id being needed11:43
stubHeat + Bug.id still can break tests - multiple bug tasks will be returned in arbitrary order11:43
lifelesson distro I guess11:43
lifelessshould probably only return one task for this search11:44
stubI think the only thing that really cares is the test suite, so it will be sucky to have worse performance just to keep it happy11:44
lifelessblah, we have to do a code change regardless11:44
lifelessI keep forgetting the cross table aspect11:44
leonardradeuring: a small branch, https://code.launchpad.net/~leonardr/lazr.restful/449561/+merge/5484911:56
adeuringleonardr: I'll look11:56
cjwatsonI have two approved branches to land, but I don't have direct landing access (AFAIK).  Can somebody help me with this?11:58
wgrantcjwatson: Sorry, forgot about those.11:58
wgrantI'll send them to ec2.11:58
cjwatsonno problem, the first one only just got the IS side done11:58
=== henninge is now known as henninge-lunch
wgrantcjwatson: Which IS side? Getting a new dpkg out?11:58
wgrantWe still probably can't land the first one, unless the new dpkg is also in our ec2 AMIs.11:59
wgrantAnd buildbot machines.11:59
wgrantIt's also needed on germanium and cesium.12:00
cjwatsonNew dpkg, yes.  Don't the buildbot machines use dpkg from chroots?12:00
wgrantbuildbot != buildd12:00
cjwatsonWe don't actually need the new dpkg to pass LP tests, do we?12:01
cjwatsonoh, maybe12:01
wgranttestXZDebUpload would test that, I hope.12:02
cjwatsonI guess we do, since bar_1.0-1_xz has 'dpkg-deb -Zxz -b debian/tmp ..'.12:02
cjwatsonso what's involved in getting a new dpkg into AMIs and buildbots?12:03
wgrantbuildbot needs the new dpkg in CAT, and a LOSA poke.12:03
wgrantec2test AMIs need the new dpkg in ppa:launchpad, and a Launchpad engineer poke.12:03
cjwatsonI've reopened the RT ticket asking for germanium and cesium to be upgraded.12:04
cjwatsonnew dpkg is already in CAT.12:04
=== matsubara-afk is now known as matsubara
cjwatsonwhat's the relevant distroseries for ppa:launchpad?12:05
cjwatsonand how should I ask for buildbot to be upgraded?  RT or IRC ping?12:06
wgrantI've already poked.12:06
wgrantDo you have a copy of the package handy? I'll upload it to the PPA.12:06
wgrantI guess I could grab it from cat.12:06
cjwatsonit's in my home directory on chinstrap too12:07
cjwatsondpkg_1.15.5.6ubuntu4.5.IS.PATCHED.10.04_source.changes (you may want to reversion, of course)12:07
wgrantCould you set a commit message for both?12:08
cjwatsondo I need any r= type runes in it?12:10
wgrantNo, ec2 land will add those.12:10
cjwatsonset for both, then12:10
adeuringleonardr: r=me12:12
wgrantcjwatson: dpkg_1.15.5.6ubuntu4.5.IS.PATCHED.10.04.tar.bz2 is 60012:15
cjwatsonhah, lamont clearly cheated12:16
dpmhi jml, did you have the chance to look at the AppDeveloperWeek LP session?12:22
jmldpm: busy right now, sorry.12:23
dpmjml, no worries. When you've got some time, if you could tell me if you or someone else would be up for it, I'd add it to the timetable. It would be great to have at least a LP session12:25
jmldpm: will do. trust me, it's not forgotten.12:26
dpmthanks jml :)12:29
=== henninge-lunch is now known as henninge
wgrantjam: Hi.12:31
=== jtv-eat is now known as jtv
jamhey wgrant12:31
jamthanks for your work on loggerhead12:32
wgrantjam: Bug #74239012:32
_mup_Bug #742390: page generation problem <codebrowse> <oops> <regression> <Launchpad itself:Triaged> <loggerhead:New> < https://launchpad.net/bugs/742390 >12:32
wgrantWondered if you had any ideas on that.12:32
jamwgrant: mismatch between version of bzrlib and loggerhead12:33
jamwgrant: that page must have a "tag" in it, that the other pages don't have12:33
jamwgrant: I'm checking when we introduced it in bzr now12:34
jamwgrant: looks like it was introduced in bzr 2.312:36
jamand I'm guessing LP is still using 2.2?12:36
jamwgrant: note that "bzr-2.2 selftest -s bp.loggerhead" would have caught this. Is there a reasonable way to integrate that into the LP test suite?12:37
jam(run the loggerhead test suite from the bzr that is going to be deployed?)12:37
wgrantjam: We can (and should) probably do that somehow.12:40
jamwgrant: I think part of the confusion is that loggerhead used to be standalone, and then became a bzr plugin12:40
wgrant(we use 2.2.3dev, apparently. not been updated lately)12:41
jamwgrant: the really easy fix is to just comment out that line12:41
jamwe don't *have* to sort the tags12:41
jamI did it to get stable results in the test suite12:41
jamsince otherwise it is 'random'12:41
jamI thought it would be nice to have a sort order for them anyway12:42
jamwgrant: https://bugs.launchpad.net/launchpad/+bug/742390/comments/512:44
_mup_Bug #742390: page generation problem <codebrowse> <oops> <regression> <Launchpad itself:Triaged> <loggerhead:New> < https://launchpad.net/bugs/742390 >12:44
jamPossible fix12:44
jamit will make codebrowse stop OOPSing12:44
jamthough it also fails the test suite12:44
jambecause, you know, it isn't natural sorting :)12:44
wgrantjam: It's just about midnight here. Can you fix trunk?12:47
=== almaisan-away is now known as al-maisan
jamwgrant: Pushing a change for review now12:49
jamwhat do we need to do to get it rolled out?12:49
wgrantA buildbot run started 2 minutes ago, so without a cowboy it will be 10 hours, at which point we have no LOSA.12:50
jamwgrant: buildbot takes 10 hours to run? yeouch12:50
wgrantjam: Only 4.5 or so.12:50
wgrantBut if we land it now then it will be waiting for the next one.12:51
jamwgrant: https://code.launchpad.net/~jameinel/loggerhead/sort-742390/+merge/5485512:51
jamI can land and propose an update to LP, or do we want to 'lp-land' the sourcecode update?12:51
jamwgrant: I confirmed that the test suite passes on bzr 2.2, 2.3, and dev with that patch12:52
=== gary-lunch is now known as gary_poster
jam(not that the loggerhead test suite is all that complete at this point, but it is getting better)12:52
wgrantI think we get this into LH trunk, land the sourcedeps.conf change to LP, pull the new LH rev onto guava, restart codebrowse.12:52
wgrantYeah, I noticed it's much better now.12:52
wgrantIs the LH review policy the same as the LP one?12:53
wgrantie. can I not approve it on my own?12:53
jamwgrant: it is probably closer to the bazaar one, but you certainly can approve it yourself12:53
wgrant(since I'm not a full reviewer yet)12:53
jamwgrant: you've got more experience in loggerhead than most of the rest of them :)12:54
wgrantjam: So, looks fine to lend as long as the tests pass with all three bzrs.12:54
jamwgrant: k, how do we get it landed in LP ,then?12:55
wgrantjam: Set the revno in utilities/sourcedeps.conf.12:56
jamsure, I know that12:56
jamthe *landing* is the part for me12:56
wgrantYou mean getting it onto prod right now?12:57
wgrantSince it's landed no differently than normal...12:58
jamwgrant: /me => not a lp dev, don't have the tools or authority for stuff like lp-land or ec2land12:59
jamI happen to play one on tv12:59
jamI *only* happen to play one on tv13:00
wgrantOh, I thought you would by now.13:00
wgrantSo, propose, get it reviewed by a full reviewer, poke them to land it if I'm already asleep.13:00
wgrantThe last tag on lp:loggerhead was on r421. My quick QA involved only the first page of results for that branch, which only went back to r423 :/13:03
wgrantSo close.13:03
=== mrevell is now known as mrevell-lunch
jamwgrant: so you would have noticed in QA if it had gone back another couple revs. That's life, I think, and why you want a nice stable automated test suite, rather than expecting human QA to find stuff13:04
jam(they are complimentary, as Human QA detects things that are hard to automate, but is really bad at repeatability and checking all edge cases)13:04
wgrantjam: Yeah, and the other branches I tested were lp:launchpad and one with crafted filenames, neither of which have any tags.13:05
wgrantAnyway, confirmed that fix works on a local instance.13:05
wgrant(of LP codebrowse)13:05
leonardrlifeless: quick question on bug 61531 if you're still around. does the behavior i describe fall within the "404-from-lp-action logic" you mention?13:06
_mup_Bug #61531: Forbidden error when trying to mark a bug as private <lp-bugs> <oops> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/61531 >13:06
jamwgrant: how *do* you qa loggerhead? Given that you can't actually connect to qastaging?13:07
jamI think you said something about firewall holes?13:07
wgrantjam: There are convenient firewall holes.13:07
jamadeuring: can you have a look at: https://code.launchpad.net/~jameinel/launchpad/loggerhead-oops-742390/+merge/5485813:16
jamwgrant: ^^13:16
jamwgrant: can you lp-land the fix then? Or you have to wait for a full reviewer?13:27
wgrantjam: My code* is worth nothing, sadly.13:28
wgrantNeeds a full reviewer.13:28
jamknow anyone who would be up at this time?13:28
jamjml: ^^13:28
wgrantHalf the team is up at this time :)13:28
jamwgrant: though apparently not reading IRC :)13:29
jcsackettjam: looking now.13:29
jamthanks jcsackett13:29
wallyworld_leonardr: the latest larz restful mp is showing conflicts but i'm not sure why. none on my system and if i run a merge --preview it's clean13:30
leonardrwallyworld, give me a url13:30
jcsackettjam: r=me. not sure about lp-landing instead of ec2ing it. i understand your rationale, but i am a timid man.13:31
wgrantlp-land is safe because of what allowed this to break (the test suite isn't run). But there's no time benefit at this time of week, so might as well ec2 it.13:31
wallyworld_leonardr: https://code.launchpad.net/~wallyworld/lazr.restful/propogate-notifications/+merge/5469013:32
jamjcsackett: up to you, but there are no tests being run for loggerhead at the moment13:32
jamhopefully will be fixed soon (by me)13:32
jambug #74244613:32
_mup_Bug #742446: Launchpad should include loggerhead's test suite <Launchpad itself:Triaged by jameinel> < https://launchpad.net/bugs/742446 >13:32
jamjcsackett: if it helps, it was just rolled out in production13:33
deryckwallyworld_: hi13:33
leonardrwallyworld: you're conflicting with a change i just landed. have you updated your copy of lazr.restful trunk?13:33
wallyworld_deryck: hi there13:33
jcsackettjam: huh. given that and what wgrant just said, i guess there's not much concern.13:33
wallyworld_leonardr: and merge into my branch and resolved conflicts and committed and pushed13:33
deryckwallyworld_: test_multicheckbox is failing in windmill test run....13:34
leonardrthat is weird13:34
deryckwallyworld_: I think I was horribly wrong about the disappearing console not mattering.13:34
jamjcsackett: anyway, if you can run ec2land or lpland for me, I would appreciate it.13:34
jamsince the fix is in production, you have all the time you want to do it either way13:34
jcsackettjam: ah, right, you need someone to land it for you. forgot that bit. i'll get it sent out.13:34
wallyworld_deryck: yeah :-( i haven't had time to look yet since my plate today has overflowed due to the bug notification incident etc13:34
wgrantWe won't have time this week to deploy, so it's not time-critical.13:35
deryckwallyworld_: no worries.  I'm debugging it a bit for you.  Looks like it's the activator's fault.  Probably that flash a custom node stuff.13:35
jamwgrant: I can confirm that http://bazaar.launchpad.net/~loggerhead-team/loggerhead/trunk-rich/revision/421 works13:35
wallyworld_deryck: i did have a quick look and couldn't figure out how to stop the disappearing stuff13:35
wgrantjam: I checked the URLs in the bug too.13:35
wgrantjam: All looks good.13:35
wgrantjam: Thanks for the very quick fix :)13:35
adeuring1jam: I'll look13:35
wallyworld_deryck: you're awesome for doing that. thanks13:35
jamadeuring1: we got it done, jcsackett handled it, thanks, though13:36
adeuring1ak, ok. sorry was out for lunch13:36
wallyworld_deryck: if it is the activator, i guess it's a bug or at least a test environment incompatibility that needs fixing13:36
deryckwallyworld_: yeah, I think it's a bug in handling custom supplied nodes.  This will fix the test:  http://pastebin.ubuntu.com/585380/13:37
* wallyworld_ looks13:37
deryckwallyworld_: but I'm not sure how to fix the real  issue yet.13:37
deryckah, interesting!  It's not the missing console causing the failure.13:38
=== adeuring1 is now known as adeuring
deryckI get real output now though....13:38
wallyworld_deryck: ah ok. remove those lines and i think it won't flash anymore :-)13:38
wallyworld_deryck: wonder why we haven't seen this before. maybe not enough js tests13:38
deryckwallyworld_: I think it's a misdirection.... getting a new paste now that I have a real error13:39
deryckwallyworld_: here's the real failure now:  http://pastebin.ubuntu.com/585384/.  I guess the console stuff was masking it.13:40
wallyworld_leonardr: i may just pull another branch and try again. but in the meantime you could look at my latest changes. it's late here now and we can talk in a few hours for our last standup13:40
* wallyworld_ looks at pastebin13:40
leonardrwill do13:41
wallyworld_deryck: thanks. i'll get it sorted and put up a mp. but not tonight. i'll try and get it done over the w/e13:43
leonardrwallyworld: i get the conflicts when i check out your branch and merge trunk. i'll resolve them and push for you13:43
jmlqastaging down?13:43
wgrantjml: It's updating.13:43
jmlwgrant: ok.13:43
wallyworld_leonardr: thanks, that's great. not sure why my local copy is clean.13:44
jmlderyck: I'm going to need to have a chat with you today to make further progress on this testing13:44
deryckwallyworld_: no worries, man.  I'll fix it for you.  It looks easy.13:44
deryckjml: ok, cool.  progress FTW!  Any particular time?13:44
jmlderyck: but not right now. should clear up a few things locally first.13:44
wallyworld_deryck: cool. i'll owe you a beer at uds or the next epic13:44
deryckjml: ok.  just ping when you're ready.13:44
jmlderyck: will do.13:45
deryckwallyworld_: don't worry about it.  but, of course, I'll not turn down free drink. ;)13:45
wgrantjml: It's back.13:45
leonardrwallyworld: lp:~leonardr/lazr.restful/propogate-notifications13:45
wallyworld_deryck: i am enjoying my forays into yui land etc. just wish there were better debugging tools. firebug is ok but...13:46
* wallyworld_ looks at leonards mp13:46
wallyworld_i mean branch13:46
deryckwallyworld_: yeah, debugging is hard.  rockstar was supposed to ask about pro debugging tips at the YUI conf he attended, but I never checked back about that.13:47
deryckrockstar: anything more than "use firebug" for that ^^ ?13:47
wgrantjcsackett, jam: I'll land the branch, since sleep is blocked on that.13:47
rockstarderyck, wallyworld_, generally I've just got used to all the common screw ups, and know what they mean.13:47
jamwgrant: thanks13:48
jcsackettwgrant: that would be good, as bzr is not working for me at the moment.13:48
* jcsackett prepares to stab his computer13:48
wgrantjcsackett: Fun.13:48
=== matsubara is now known as matsubara-lunch
deryckrockstar: yeah, me too.  I suspect what wallyworld_ means is better facility for working out what is wrong when you don't know.13:48
jcsackettwgrant: always. :-P13:48
wallyworld_rockstar: i rely  alot on Y.log(). takes be back 15 years ago before there were decent java ide's :-)13:49
wallyworld_deryck: rockstar: yeah, the ability to step through code and look at variables and evaluate expressions etc13:49
deryckrockstar, wallyworld_ -- I think filter debug is nice for log noise and working it out.  Liberal Y.log is your friend, etc.  I'm not sure what else to suggest.13:49
deryckwallyworld_: you can't step through with firebug?13:49
rockstarderyck, wallyworld_, that sounds unhelpful, I know.  However, I've had some, er, "fun" forays into the bowels of YUI trying to find out what's wrong, and that usually ends up showing me the problem is very simple.13:49
rockstarwallyworld_, do you know how to use the debugger?13:49
deryckyeah, I do step-wise debugging in firebug often.13:50
wallyworld_deryck: rockstar: clearly not :-)13:50
rockstarwallyworld_, through 'debugger;' it at the line where you want the breakpoint, and run the code.13:50
deryckwallyworld_: add a "debugger;" statement in any line and have fun :-)13:50
* wallyworld_ will have to RTFM13:50
rockstarFirebug will take care of the rest.13:50
rockstarwallyworld_, I also prefer chrome's tools to Firebug now, as Firebug's XUL-land code often confuses Firefox greatly.13:51
wallyworld_if only i had figured that out 1 month ago :-)13:51
rockstarLike, refreshing while still in the breakpoint causes madness.13:51
wallyworld_rockstar: cool. i try it. actually i have found firefox 4 to be a huuuuge memory hog :-(13:51
rockstarwallyworld_, with or without firebug?13:52
deryckI'm slowly coming over the Chromium, too.  Now that I'm learning the UI differences better, and changing muscle memory.13:52
wallyworld_rockstar: without. but of course its always just an F12 away13:52
wallyworld_so it must have stuff loaded all the time etc13:53
wgrantjam: Landed, thanks.13:53
wallyworld_deryck: yeah, muscle memory. that's why i can't use another ide besides PyCharm. too much time with Intellij for Java13:54
deryckheh, understood13:54
wgrantjam: I'm off to bed now.13:56
wgrantjam: Hopefully nothing will break!13:56
wallyworld_leonardr: thanks for fixing branch. talk again in 7 hours :-)13:56
jamwgrant: sleep well13:56
* wallyworld_ off to bed too but not same bed as wgrant13:57
rockstarwallyworld_, indeed it does.  That's a big reason I switched to Chrome for development.13:57
wallyworld_rockstar: i like chrome but last time i looked their adblocking sucked due to lack of content filtering api13:57
wgrantwallyworld_: Ad blocking is much better now13:58
wgrantIt used to really suck, though, yes.13:58
rockstarI just wish they'd block popunders.13:58
* wallyworld_ really going away now :-)13:58
=== mrevell-lunch is now known as mrevell
* jcsackett holds breath to see if irc client has stopped misbehaving14:13
* jcsackett exhales, slowly14:14
leonardradeuring: https://code.launchpad.net/~leonardr/launchpad/520412-from-thekorn/+merge/5486814:19
adeuringleonardr: I'll look14:26
deryckadeuring, abentley, and henninge -- I forgot... we're all on DST next week, right?  Which should put standup back at 1300 UTC?14:34
adeuringderyck: yes14:35
abentleyderyck: I believe so, and yes.14:35
jamadeuring: any chance you could look at the follow up patch: https://code.launchpad.net/~jameinel/launchpad/loggerhead-test-suite-742446/+merge/5487014:40
adeuringjam; sure14:40
adeuringleonardr: r=me14:41
henningederyck: since it won't change the time for us here, I am all for it.14:44
deryckok, cool.14:45
rvbasinzui: Hi ... if you have a few minutes, I'd be happy to have your opinion on the UI side of a branch I'm working on right now.14:54
sinzuirvba: I can talk in a few minutes14:55
rvbasinzui: https://pastebin.canonical.com/45240/14:55
jmlderyck: how's now?14:55
rvbasinzui: I'd be happy to talk about it yes ... just ping me when you're ready14:55
deryckjml: now's good.  mumble it?14:55
jmlderyck: yep14:55
danilosderyck, s/chromium inspector/webkit inspector/ (it works in epiphany as well)14:56
deryckjml: drag me where you like14:56
danilosderyck, btw, cool tip, I was setting a breakpoint from the inspector directly :)14:56
deryckdanilos: heh, ok :-)14:56
jmlderyck: http://paste.ubuntu.com/585427/14:57
deryckjml: https://translations.qastaging.launchpad.net/ubuntu/natty/+source/gnuhello15:01
deryckjml: https://translations.qastaging.launchpad.net/ubuntu/natty/+source/gnuhello/+sharing-details15:03
LPCIBotProject windmill build #104: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill/104/15:04
adeuringjam: r=me15:05
jamadeuring: can you 'ec2land' it for me?15:06
adeuringjam: sure15:06
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring, bac | https://code.launchpad.net/launchpad-project/+activereviews
=== deryck is now known as deryck[lunch]
sinzuirvba: why does 2_details.png show the expander arrow, but the computes replaces it with a cog? Cannot I not expand the entry anymore?15:27
rvbasinzui: the greyed arrow cannot actually be expanded ...15:28
sinzuiWhy are we telling users It can be expanded?15:29
sinzuiIs that arrow being used as a bullet?15:29
sinzuieasy fix15:29
sinzuiShould we have a grey cog instead?15:30
rvbait acts as a placeholder so that when it's replaced by real status icon (processing/failed) the text does not jump15:30
rvbaif there is a grey cog, it would be very nice ... I've reused existing icons15:32
sinzuiI think a cog with a questionmark emblem might convey we do not know the status yet15:32
rvbawhat's the process for creating new icons?15:33
jmlrvba: ask huwshimi15:33
rvbajml: ok15:34
sinzuiI have not noticed the cog before. The page title says source package, I think the data is actually a source package release. I do not want to confuse the users about out precise use of terms, BUT I think expect an icon that implies source package. cogs are used for binaries.15:34
rvbayes, the data is source packages15:35
rvba(even if there is a remaining 'binary' somewhere)15:35
rvbathe icons would be for packages diff more than source packages15:36
sinzuirvba: I think the interaction is very good. I think we need to note we want the icon developed for the interaction before the final release15:36
rvbait's the diff that can be a) not there / b) pending / c) failed15:36
cjwatsonwgrant: apparently the buildbots run hardy-cat, so I'll need to backport this all the way back to hardy15:37
sinzuirvba: understood. You might want to report a bug to record the requirements for the icons. You can then focus on functional side of your branch15:37
rvbasinzui: ok15:38
rvbajml: should I report a bug about the missing icons and assign that to huwshimi?15:38
cjwatsonwgrant: sorry, just the staging buildbot15:38
jmlrvba: sounds good.15:38
cjwatsonwgrant: I'm having a hard time seeing how 3.0 format support works in that case, though ...15:38
cjwatsonwgrant: wouldn't current LP tests fail without 3.0 support in dpkg?15:39
rvbasinzui: ok, thanks for your time.15:39
=== al-maisan is now known as almaisan-away
sinzuibac: do you have time to review https://code.launchpad.net/~sinzui/launchpad/person-merge-job-2/+merge/54873 today?15:49
bacsinzui: yes15:50
cjwatsonwgrant: never mind; as far as I can tell, if the staging buildbot is running hardy (and doesn't have a lucid chroot or whatever), then AFAICT it can't be testing LP15:50
sinzuijcsackett: do you have a few minutes to mumble? We can pretend it is our daily talk15:52
=== matsubara-lunch is now known as matsubara
jcsackettsinzui: sure, one second.15:53
jcsackettsinzui: i'm on mumble.15:54
bacsinzui: i made a super-trimmed down test to demonstrate the problem i'm having. it can be run, and fails, in trunk.  would you have a look and see if you spot anything obviously wrong when you have time?  http://pastebin.ubuntu.com/585455/15:57
sinzuibac: OTP, will look in a few minutes15:57
cjwatsonleonardr: hmm, can I suggest that maybe https://help.launchpad.net/API/Examples shouldn't recommend connecting to edge? :-)16:11
leonardrcjwatson: yeah, i'll change it16:12
bachi sinzui, your code says membership in a merged team is not transferable.  really?16:22
danilosjml, hi, did you by any chance change the summary of https://bugs.launchpad.net/bugs/742490 and then change it back? (because if you did, we've got a bug; if you didn't, I am just having trouble reading the differences in the email :)16:24
_mup_Bug #742490: HTML is constructed using string concatenation in the structural subscription JS. <story-better-bug-notification> <Launchpad itself:New for yellow> < https://launchpad.net/bugs/742490 >16:24
jmldanilos: no, just a spelling correction16:24
jmlconcatination => concatenation16:24
danilosjml, ah, right, concatInation16:24
danilosjml, it was hard to spot, and I was worried our "do not email about reverted changes" didn't catch it16:25
danilosjml, sorry for interruption, cheers :)16:25
allenapadeuring, bac: Do you guys fancy any branches to review? :) I have a small one, a medium one, and a large one to choose from.16:27
bacallenap: i'll be happy to look at them after my lunch16:27
adeuringallenap: I'll start with the small one :)16:28
allenapbac: Thank you. I hope you have a delicious lunch that leaves you in an pleasantly accommodating mood :)16:28
allenapadeuring: Cheers! https://code.launchpad.net/~allenap/launchpad/dd-initseries-bug-727105-feature-flag/+merge/5488416:29
bacme too16:29
sinzuihi bac16:30
sinzuido you want to mumble?16:30
bacsinzui: ok16:30
sinzuibac: http://pastebin.ubuntu.com/585467/16:34
adeuringallenap: there is a merge conflict16:35
cjwatsonwgrant: germanium, cesium, and the buildbots other than staging should all have the new dpkg now, according to lamont16:38
allenapadeuring: Gah! I'll fix it now.16:39
adeuringallenap: thanks.16:40
allenapadeuring: I think it's confused. The correct diff - http://paste.ubuntu.com/585475/ - is actually shorter, and has no conflicts. Mmm :-/16:44
adeuringallenap: ok, thanks. allenap: r=me.  just one suggestion: I don't like generic names like is_featrue_enabled very much, What about is_derived_series_feature_enabled?16:45
allenapadeuring: Okay, makes sense. Thank you :)16:45
adeuringallenap: next mp? (the mid-size one, please. Since my EOD is relatively close, I'd like to pass the big  MP to bac)16:47
allenapadeuring: https://code.launchpad.net/~allenap/launchpad/dd-initseries-bug-727105-copy-options/+merge/54667 though I'll check the diff on that one now.16:47
bacbac: +1 adeuring16:49
* bac -> lunch16:49
=== deryck[lunch] is now known as deryck
allenapadeuring: It seems to be sane.17:01
adeuringallenap: right17:01
jcsackettleonardr: sorry to bug you about this on your last day, but is there a way to mark a field readonly on the api that's not read only otherwise?17:04
leonardrjcsackett: sure, pass readonly=True into export()17:05
jcsackettleonardr: someday i'm going to learn this all easier than i expect. :-)17:09
leonardrit's not _that_ tough17:09
jcsackettleonardr: indeed. i conflate webservice stuff with dealing with the wadl, i think. which as i recall was a major pain.17:10
jcsackettobviously such conflation is silly.17:10
leonardrjcsackett, can you elaborate on the pain?17:10
jcsackettleonardr: remember the issues you, sinzui, and to some extent i had when you were modifying it?17:11
jcsackettreally, i mean that was xsl issues. not wadl per se.17:11
jcsackettbut it set the tone in my head. :-P17:11
leonardroh, xsl is the problem there :)17:11
* jcsackett nods.17:12
jcsackettxsl is always a problem. :-)17:12
jkakarleonardr: Just noticed "last day" above.  I hope you have fun wherever you end up. :)17:16
leonardrjkakar: thank you!17:18
adeuringallenap: r=me17:34
allenapadeuring: Thanks!17:37
bacsinzui: i've tested and create_view is setting the BugsLayer properly based on rootsite17:48
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | https://code.launchpad.net/launchpad-project/+activereviews
sinzuibac: okay. I am starting my adventures with distros, adaption, and menus18:06
baccool, sinzui18:07
sinzuibac: I see that the menu cannot get the facet, so cannot actually select a menu. We expect  bugs as was set by the rootsite.. facet should be layer, but Lp does not do this right. I think the setup is wrong. I see that path is missing, so I suspect we got another request object.18:40
bacsinzui: so i need to manually set facet?18:41
bacand path?18:42
sinzuiThat is not really possible, Menu gets it via adaption18:43
=== Ursinha is now known as Ursinha-lunch
sinzuifacet is moneypatched into the view by our ZCML hacks.18:44
bacsinzui: my battery is dying so i need to relocate.  i'll ping you in 15 minutes.18:48
jmlg'night all. have a great weekend.19:04
bacsinzui: i am resettled and recharging19:18
LPCIBotProject db-devel build #491: FAILURE in 5 hr 20 min: https://lpci.wedontsleep.org/job/db-devel/491/19:20
lifelessleonardr: hi19:27
sinzuibac: create_initialized_view uses getMultiAdapter directly. It bypasses the publisher. The publisher is what monkeypatches the facet into the view. So we will not have a facet...19:27
bacsinzui: ah.  boo.19:28
sinzuibac: we are working with an model object of course, but the failover method cannot get a facet...19:28
lifelessleonardr: I'm not sure what you're asking19:28
lifelessoh, I think I've figured it out19:28
sinzuibac: for expediency you might want to use test browser to for the test or...19:29
leonardrlifeless: you triaged the bug as critical because of a situation in which a 404 caused an oops19:29
leonardri'm wondering if the situation i described falls into that category19:29
lifelessI think so, I just commented on the bug19:29
sinzuibac: we could finally fix the bug facet/layer bug. eg, Use the layer when we do not get a facet19:29
lifelessleonardr: the rules for 404 oopsing are:19:29
lifeless - its a 404 (duh)19:30
lifeless - and the referrer is a launchpad vhost or one of a select number of canonical/ubuntu sites19:30
sinzuibac: this is the hack I did to fix the test: http://pastebin.ubuntu.com/585562/19:30
cody-somervillehey. have you guys ever had any problems with chromium thinking lp is TSLv1 intolerant and falling back to SSLv3 or erroring out with non-descriptive SSL error?19:31
sinzui^ the comment exposed in the diff mean we really wanted to use layer19:31
lifelessleonardr: I suspect you have oopses in /var/tmp/lperr/$day19:31
bacsinzui: but your hack won't work on other layers, right?19:31
lifelesscody-somerville: other than tls being a little bit broken ;)19:31
lifelesscody-somerville: anyhow, I saw someone mentioning a tls error with something yesterday in #is19:32
sinzuiNo, but I think in your case, the menu is not associated with a layer. I think the menu you are testing is on the default layer overview19:33
sinzuioh hell, I need to get children19:33
lifelesscody-somerville: see -ops right now in fact19:34
sinzuibac: I was going to walk through pdb next to see how to get the correct layer and map it to the selectedfacetname so that we have a final fix19:34
bacsinzui: the portlet i'm looking for only appears on the bugs page19:34
bacsinzui: ok, go get your kids19:34
sinzuibac: I do not think get_current_browser_request does the right thing in this kind of test. I am certain layer is set by create_initialized_view, but it do not set when we work with the menu. I think the menus are getting another request object20:43
bacsinzui: for now i think i'm going to take your advice and rewrite the test to use a browser20:44
sinzuiI think will continue my distraction to learn what is wrong with some small hope that we will get one step closer to killing facet.20:45
=== Ursinha-lunch is now known as Ursinha
bacgreat, sinzui20:47
benjisee ya, leonardr21:02
leonardrbye, benji21:03
leonardrwallyworld_, i'm here sporadically, let me know when you're ready for standup21:07
wallyworld_leonardr: hi. i'm here now21:15
leonardrwallyworld_: ok, getting on mumble21:18
=== herb__ is now known as herb
leonardrwallyworld_: http://pastebin.ubuntu.com/585604/21:21
leonardrok, i'm out of here. thanks, everybody. it's been great working with you21:29
bacsinzui: i have discovered a problem with my test construction21:46
sinzuicurrent_request=True ?21:46
bacsinzui: simpler.  for rootsite='bugs' i was using '+index'.  that page renders as the main project page21:46
baci should use '+bugs-index'21:47
sinzuibac: I discovered that the request we pass/make in create_view is not setup for the interaction be default. We need to set current_request=True to ensure the menu gets what is setup21:48
sinzuiI am making a helper function that gets the facet name form the layer21:48
bacsinzui: i had variously tried setting current_request=True21:52
bacsinzui: i have to run but feel confident correcting my simple mistake will help greatly21:53
sinzuifab. I hope to have a spike to remove facets in a hour21:53
=== matsubara is now known as matsubara-afk
wgrantcjwatson: I'm confused. What staging buildbot?22:53
wgrantcjwatson: There are staging buildds, but no staging buildbot that i know of.22:54
cjwatsonwgrant: lamont said the machine name was marambio23:09
cjwatson16:00 <lamont> drwxr-xr-x 3 importd importd 20480 2011-03-25 00:01 staging-logs23:09
cjwatson16:00 <lamont> OTOH, /srv/importd.staging.launchpad.net/staging/launchpad has nothing newer than 60 days ago23:09
cjwatson16:00 <lamont> so the cronjobs are running, but no one is home23:09
cjwatsonso I think it can reasonably safely be declared irrelevant for the moment anyway23:09
cjwatsonwhatever it is23:09
wgrant... oh. That's a code importd. I guess they did run buildbot in like 2006, but I meant the lpbuildbot.canonical.com buildbots.23:10
wgrantcjwatson: I've sent your branch back to ec2.23:33
cjwatsonah, right.  thanks23:34

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!