[06:23] morning all [06:52] duanedesign: morning. :) [06:54] hello nhaines [07:15] morning all [08:11] morning! [08:13] o/ [08:14] good morning #ubuntuone! [08:15] morning mandel duanedesign and karni [08:16] mandel: I know what im doing for the day so its cool no need for input [08:16] hi fagan ! hello duanedesign [08:16] :) [08:16] fagan, karni, duanedesign: morning [08:16] morning mandel :) [08:23] * fagan checks out something on #ayatana [08:26] multi monitors suck [08:31] is it wrong that I am working really well to physical from olivia newton john :) [08:31] not at all [08:34] I woke up and said im going to listen to only 80s songs today so got the "top 100" out and is having fun [08:37] fagan: can I get some of your time to do a couple of reviews on windows? [08:37] mandel: sure [08:37] link and ill go looking [08:38] mandel: actually just about finished on the first screen anyway [08:40] fagan: give me a sec, I'm going to fix a typo that nessita found and will pate the link here [08:40] mandel: I do still have that issue with it spreading out the checkboxes [08:43] mandel: screw it ill leave the little weird issues with that screen for you since its blocking me a little [08:44] fagan: sure, I'll take a look, I'll branch now your code and will fix it so that you can continue [08:44] mandel: kk [08:46] fagan: in the mean time, can you review the following: https://code.launchpad.net/~mandel/ubuntu-sso-client/implement_windows_main_4 [08:47] fagan: all tests should pass except those related with oauth and 200 is not equal to None, which are the ones you had yesterday [08:48] mandel: So ill just give it a run over to see if there is anything else wrong [08:50] fagan: yes, check that the tests do not give any problems and that the code is ok, more or less like yesterday [08:54] mandel: passed the test other than that 1 failure and the changes that were proposed are done now [08:54] fagan: have you pushed the changes you have done so far to the ui to the branch? [08:54] so I can give that one the +1 [08:55] nope [08:55] 10 secs and ill do it [08:55] fagan: cool, thx for both (review and pushing) [08:55] fagan: can I give you two very small reviews more? [08:55] mandel: oh do I need to recomment the merge? [08:55] mandel: sure [08:56] fagan: after doing a bzr merge, yes you have to commit it, since is an extra revision [08:56] I meant comment it [08:57] yes, you have to [08:57] fagan: this is one of the other two reviews: https://code.launchpad.net/~mandel/ubuntu-sso-client/fix_732057/+merge/54722 [08:57] ok cool [08:57] it should fix one of the broken tests [08:57] oh you linked me to that one last week when I was setting up I think [09:00] mandel: ok pushed and commented [09:00] looking at the merge now [09:01] fagan: ok, cool, I'll grab your code, the issue you have is making the services screen look like the proposed wireframe, right? [09:01] mandel: its the bandwidith screen still its just the checkboxes are spreading out a little and it looks ugly [09:01] the rest of the screen should be just about ok [09:02] apart from moving the pixels around a little more which should be done after the text is added [09:02] fagan: ok, so it is the badwidth one, on it [09:02] yep [09:03] mandel: I already approved that one you linked? [09:03] have you changed it since? [09:04] oh that was the one I just did [09:04] whats the other one mandel [09:04] fagan: this is the one I meant, sorry https://code.launchpad.net/~mandel/ubuntu-sso-client/fix_732057/+merge/54722 [09:04] hehe [09:04] its cool [09:05] mandel: still the same one [09:05] :) [09:06] fagan: hs, stupid me, here you go https://code.launchpad.net/~mandel/ubuntu-sso-client/fix_732112/+merge/52741 [09:07] mandel: so I understand what this is doing already and it is fairly straightforward can I just approve it or is there a special review type i should use for that? [09:08] nessita tagged it as trivial so should I just copy that I mean [09:09] * fagan is just wondering [09:09] +1 anyway [09:09] yes, but in this case, run the tests since she could no do so on linux [09:09] mandel: so I should run it on linux too? [09:09] that extra / will mean that tests should pass on windows in that branch [09:09] fagan: no, windows [09:09] oh lol [09:10] my bad early in the morning sometimes lose my brain for spells of time [09:10] I was just about to run the test anyway was just grabbing the branch just in case [09:13] mandel: pass [09:14] cool, so we have all green lights on windows? [09:14] mandel: yep [09:15] everything says gogogo [09:16] cool, we oficially have the sso backend ported to windows :) [09:16] well you not me :) [09:16] next step, start proposing the merges for the ui which is already done, by today we should have a buggy ui added :) [09:16] but go team go :P [09:16] hehe [09:17] mandel: thats fine by me I got right back to fiddling with qt desinger already [09:18] fagan: I'm done with the screen you had problems with, let me push it [09:18] cool [09:18] ill merge it in [09:20] fagan: I just pushed it, merge it and let me know if that is ok with you? [09:20] that ? is extra :P [09:20] mandel: sure ill tell you if it fixes my problem [09:22] fagan: I've just noticed a small isssue with the spinbox aligments, let me fix it [09:22] will be a min [09:22] ok cool [09:25] morning clarita I saw the changes already shouldnt be too hard to change the screens [09:26] oh and you didnt add the progress thingy [09:26] morning! great - yes progress thingy still to do as well as some amends to the folder selection...watch that space! [09:26] kk cool [09:29] fagan: you can merge with the new version, I added a long label to test that the stretching works correctly, feel free to remove it [09:30] mandel: oh and we could do the done installing screen and the installing screen together right with just disabling the next button or something? [09:30] mandel: Cool will do [09:31] fagan: yes, we can, anything that has an extra button can be the same, just create it with the button, and we can programatically disable it when needed [09:32] mandel: the push button should be more right and where did the other two buttons go? [09:32] the cancel and the back buttons were needed right? [09:33] fagan: in the doc, there are not two buttons, and the apply this settings is centered [09:33] oh that must have changed since I looked at it [09:34] it looks kinda out of place centered [09:34] fagan: there is an issue with the alignment of the button and the checkboxes, you have to add spaces around the checkboxes group that expand so that the button and the checkboxes are aligned [09:35] clarita: ping [09:35] mandel: so grouping them fixes the issue with them being out of place [09:35] mandel: oh and the cancel button is there its just moved to the right hand corner [09:35] * fagan re-adds it [09:35] fagan: dont re-add it [09:36] mandel: oh ok [09:36] fagan: hat is part of the QWizard and not the QWizardPage, the wizard page should not take care of back, cancel, help buttons [09:36] oh ok [09:36] those buttons follow the logic of the QWizard, pages dont care, they are just displayed [09:37] the QWizard will render the buttons according to the nextId result of the page, in you case since we have just a cancel and a back button, we will be chaning the buttons logic in the QWizard, not the pages [09:38] mandel: ah ok so you can style it to go to the other side then [09:38] I didnt know that [09:40] yes, take a look at the Qt documentation of QWizard and QWizardPage, it explains the usage of the two diff widgets, the logic is the following, all navigation is done by QWizard, all input and display by the page [09:40] the back button logic, cancel, finishe etc.. is a QWizard things to take care of, so we dont have to worry much [09:41] * fagan checks it out [09:42] hello mandel [09:42] clarita: good mrning! como estas? [09:42] muy bien gracias, y tu? [09:43] clarita: bueno es viernes, asi que muy bien :) [09:43] claro ;-) [09:43] aunque amo mi trabajo :-) [09:43] clarita: your english you should say something more like "mandel make me some tea" [09:43] * clarita chuckles [09:44] mandel fagan if I can help with your layout discussions above it might help to see where you've got :-) - I'm in a meeting in 15 mins for a couple of hours fyi [09:45] clarita: small remark in the installer doc, 4th page starting from the end has some extra buttons that are not needed (I suppose they were forgotten there) [09:45] clarita: layout is not something that worries me, when done I'll package what we have for you (I'm a little behind on that) and will do a doc similar to the one I sent of sso, that way you now how the widgets flow [09:46] okey dokey [09:47] clarita: other remark is the use of borders in the frames, 1 to 2c use a border, the rest done, is that on purpose? [09:48] same with 5b, has a box, rest do not, we need to know tat so that we can use a widget that can be styled to have the border or not [09:48] is not much of a change, but the sooner we use the correct one the better [09:49] mandel: sure - this really depends on the work lisette is doing - borders were originally used for grouping text and image on the same page - so please don't make efforts to include until the visual design has progressed [09:50] clarita: ok, so 'til other news, all screen should be 'border less' [09:50] fagan: got that ^ [09:50] mandel: kk [09:50] * fagan did that originally [09:50] mandel: correctamundo [09:51] clarita: what language is that? [09:51] :P [09:51] Oh, hi everyone! :D [09:51] fagan just keeping you on your toes! [09:51] aloha [09:51] hey JamesTait [09:51] nice day [09:52] clarita: I have to teach you how to use sms spanish ;) [09:52] mandel: I have to teach you some Irish too [09:52] mandel: por favor [09:52] :D [09:52] we can all speak Spanglish or Spirish [09:52] yeah I cant [09:53] * fagan needs to learn a bit [09:53] (well the curses are always fun to learn) [09:55] Lovely day again, yes. Apparently the temperature is set to dip for the weekend though, and be warm again on Monday. [09:56] JamesTait: well heres hoping it stays nice enough for the weekend [09:56] hi JamesTait :) [09:56] fagan: Indeed. I gots plans. :) [09:56] Morning karni. :) [09:57] JamesTait: I can just picture with a map behind you saying that, and a short skirt hehe [09:57] mandel: hehe I worry about your mind when I hear lines like that :P [09:57] mandel: What kind of girl^Wguy do you think I am?!? :D [09:57] JamesTait: a very well weather informed one :P [09:58] fagan: I'm strange, you'll get used to it :) [09:58] mandel: ha im kinda strange too in a charming way [10:01] mandel: Ok I fixed the start screen [10:01] ish [10:01] mandel: so should I remove the install button that I placed before? [10:02] since qwizard already has a next we can custom [10:05] fagan: which screen? [10:05] Start.ui [10:05] I had a button there for cancel and one for starting the install [10:06] fagan: is that 2a in the current design? [10:06] mandel: yep [10:08] mandel: so what im wondering about is the big button that I put on my window for the install to start can we style the qwizard page next to look like that [10:10] fagan: no, that would be way too much work for what we get, we use the on you added, and call the next action from the page.wizard() that returns the parent wizard [10:11] mandel: need a review on that merge proposal you just did? [10:11] mandel: cool [10:11] so, in code words QObject.connect(big_button, SIGNAL('clicked()'), self.wizard.next()) [10:11] mandel: cool [10:11] fagan: sure, let me first add some instructions on how to test the setup.py [10:13] mandel: does it add any big lot of code I can open the ui files in qt designer otherwise [10:13] ah it adds a little [10:13] * fagan grabs it [10:16] fagan: it adds code to the setup.py soothat you have to read, all the crazy xml you can open with the qt designer, but that is the initial version, so no need to worry about the ui just yet [10:16] I added the .ui so that I could test that the setup.py worked. [10:17] mandel: passes on linux anyway [10:17] after looking at the code ill go into windows and check there [10:18] ok, cool [10:18] fagan: later I'll change the setup.py so that the code can be used on kubuntu, but there are a number of changes to do there that I do not have yet [10:19] * mandel is happy he will added Qt code on sso for kubuntu [10:19] mandel: ah cool [10:20] mandel: line 1248 in the diff there is a type ugle->ugly [10:21] oh and w->we [10:23] he [10:23] ok [10:23] mandel: line 1308 in the diff case->cases [10:23] on it [10:23] fagan: can you type all the remarks in a needs fixing comment? [10:24] mandel: kk [10:24] almost finished anyway [10:30] mandel: ok other than checking out the .ui files the code review is done [10:31] cool, dd the needs fixing with the spelling issues [10:31] and running the tests too on windows [10:33] mandel: the qt is fine [10:33] so onto the test [10:38] mandel: passed [10:39] cool, I'll fix the issues asap [10:39] mandel: cool [10:47] CardinalFang: ping [11:16] mandel: maybe we should leave the subscribe screen till clarita finalizes the design or should I give it a try [11:17] at the moment it looks like the mockup but has no frames and all that [11:18] fagan: lets wait, no need to do work that will be thrown away [11:18] do you want me to review it? [11:18] mandel: well i only did 1 different screen [11:18] the start one [11:18] if you want to have a look you can give it a go [11:19] and could you do the last screen for me its an easy one but I think im missing something and its not sizing [11:20] I set the minimum size and all but they arent getting any bigger [11:25] fagan: so you want me to take a look at the last one, which is the name of the file? have you pushed the changes you did? [11:26] fagan: I've fised the windows_ui_1 typos, can you take a look when possible? [11:27] mandel: the file is Done.ui [11:27] and I just pushed again so pull before you do that [11:27] and look at start [11:28] Start.ui [11:28] I think I have it almost right [11:28] mandel: oh and ill look at that merge now [11:30] fagan: Start.ui which screen is it on the google doc? [11:31] mandel: 2a I think [11:31] the second one [11:31] * fagan hopes it hasnt been changed [11:32] it has [11:32] ill fix it [11:32] fagan: he, I was going to say :) [11:33] fagan: now that you are chaging it, add an horizontal spacer under the button, in the version I've seen you are trusting on the way the vertical spaces span, which is ugly [11:34] mandel: ok [11:34] sorry I switched vertical for horizontal [11:34] oh so vertical you mean ok [11:35] fagan: so, you are trusting the horizontal spacers around the button for the vertical streching, if you run the paged and make it aller you will see what i mean in the button [11:35] is aligns in a funny way [11:35] mandel: ok fixed on my machine ill push it [11:39] fagan: why are there 2 lables? Titles and subtitles are already present in the QWizardPage (setTitle and setSubTitle are the methods) we do not need to add labels for that [11:40] fagan: also, the button, still has a funny streching when we make the windows taller, since it has no spacer that pushes it to the label, you just have to add one under the button horizontal layout [11:42] do I make sense? [11:42] mandel: I was getting coffee sec just reading [11:42] oh and ill +1 that merge [11:43] fagan: sure, I'm made those changes locally, if you want I can push them [11:43] * mandel gets coffee and some other drugs too [11:43] mandel: cool ill look down though them [11:43] * fagan is happy with the coffee and some crisps [11:54] fagan: I'm back, so do you want me to push my changes? [11:54] yep [11:54] * mandel does it [11:55] * fagan really needs some more practice with qtdesigner [11:58] fagan: I've pushed the changes to my branch merge accordingly [11:59] mandel: kk so ill have a look and keep trying to get better at qtdesigner [11:59] ok, let me know if you need more help [11:59] sure [11:59] fagan: in the changes I added a big ass label to show how it stretches when moved around [12:00] mandel: ok ill have a look to see how you did it [12:02] mandel: the bottom part of the form doesnt scale any more [12:02] it scales horizontally but not vertically [12:04] ein? [12:04] what do you mean? [12:05] mandel: drag the bottom part and the button and text box stay at the top of the screen [12:05] and the bottom part scales without it [12:06] fagan: oh, you mean that the label is at the top, and the extr space goes to the bottom, that is the way you want it, the QWizrd frame will add some space for the title and before the label appears [12:07] mandel: no I mean if you make the window bigger the bottom button doesnt stay at the bottom of the window [12:07] it stays just under the label [12:08] fagan: the install button? yes that is how I understand the wireframe, that the extra xpace goes at the bottom [12:09] * fagan doesnt think he is getting his point across [12:09] sc [12:09] sec [12:12] mandel: http://ubuntuone.com/p/jOx/ [12:13] fagan: o the problem is that the button stays under the label and adds the space to the bottom, right? [12:14] mandel: yep [12:14] looks a little weird [12:16] fagan: I would add a small space between the label and the button, then we talk with clarita about the best way, if the button has to be as close as possible to the label, we set spacer at the bottom to expand and set the top as fixed, if not the other way around [12:16] so we have both options easily [12:17] yeah thats cool [12:17] hust add a spacer on top of the layout used by the button and set it to be fixed, take a look, or a screeshot, swap the streching, and send to clarita both images, let her choose [12:18] fagan mandel: what is the score with pop up info during Windows install....e.g. to avoid excessive text where explanations are necessary can we have a pop up on click? [12:19] clarita: is that a dialog, or a ballow kind of thing? [12:19] we could do a label thats hidden and show it when they click? [12:19] fagan: tool tip is a nicer thing to use [12:20] clarita: ballow (my own word) == tool tip [12:20] :P [12:21] mandel he he - tool tip [12:21] clarita: we can add click events to widget [12:21] mandel: muy bien [12:21] * fagan just suggested the label so we could do something fancy but tooltips are fine and easy [12:21] ouch, my english is shit today, I speak like and indian in a western movie [12:22] lol mandel [12:22] hello everyone! [12:22] hey nessita [12:22] karni, hi hi [12:22] mandel: did you see the trivial needs fixing in main_4? [12:23] hi fagan [12:23] nessita: yes, they are done [12:23] nessita: I reviewed and approved [12:23] awesome [12:24] CardinalFang: hi there! I came up with an answer, invalid ping ^^ [12:25] karni, ACK RST [12:26] nessita: so, I've been thinking about the current situation with the code having to be tested and wanting a cont integration thing going, the idea would be to have a builbot slave for each platform, add connect the admin to an irc channel #u1-windows-builds or something so that we get the reports [12:27] nessita: maybe have a xp and 7 slaves at least, and have none for ubuntu since tarmac will make sure that the linux version is ok [12:27] mandel: makes sense, I would generate emails instead of IRC messages [12:27] mandel: since IRC messages may not be seen [12:27] mandel: also, if we can set that up, we should add cont int for u1client [12:28] nessita: sure, that is logical, I'm sending and rt with what we need, so we have all multiplatform projects running [12:28] nessita: I will ask for t to be setup, but offer my help to do it on windows, although I try to dodge the bullet :) [12:29] mandel: that sound perfect. Thanks! [12:37] mandel: I added a spacer top and bottom and it looks a little better I think [12:38] fagan: bottom? we already had one at the bottom, didn't we? [12:38] I mean top and just above the button and they all scale now [12:39] may I see a pict? [12:41] http://ubuntuone.com/p/jPD/ [12:41] I dont know I like that the button moves a little bit with the size [12:42] I dont mind either way [12:42] clarita should look at both and see which one is better [12:42] (the button isnt the right size though) [12:43] I think it would look better with the bigger button [12:43] fagan: looks good to me, anyway don't get block by this, finish the rest of the screen and then I can do a bigger review, ok? [12:44] mandel: sure [12:44] going for a break soon but will do it after standup [12:46] ok, np [12:46] I need to walk the dog [12:46] * mandel walking beast [12:47] * fagan lunch [12:49] CardinalFang: I'm introducing some major changes to the FilesDatabase 1) cleanup and naming conventions refactor 2) more fields 3) the file_data column will be a URI (either file:// or content:// ), so it'll be my job to refactor your work once you're done. I don't want to bother you with those details. [13:08] mandel: apporoved [13:08] approved* [13:10] could someone please update bug 387308 - there is a comment (#42) from August that says proxy support for files is in 10.10 and desktop-couch should be in 11.04 [13:10] Launchpad bug 387308 in ubuntu (and 1 other project) "HTTPS Proxy Support for file sync (affects: 301) (dups: 29) (heat: 1182)" [Undecided,Invalid] https://launchpad.net/bugs/387308 [13:13] popey: the merge is marked as needing a field test, too bad my college moved their proxy to hide it or id test it [13:13] they put a server between the proxy and the students so its unseen [13:14] can you browse through the proxy? [13:15] popey: yeah its like a direct connection they just put the proxy on the outgoing server [13:15] can I test it? [13:16] popey: check here https://code.launchpad.net/~chipaca/ubuntuone-client/very-basic-proxy-support-for-stable-1-4/+merge/39910 [13:16] and id suggest talking to the guys about it [13:16] * fagan is just going from whats there [13:17] Chipaca_: ^ [13:17] Ok, I would like to test that, but don't know what's necessary to do that. [13:18] ideally I'd like a deb that I can install and test on my laptop (at work I am behind a proxy so this would be ideal) [13:18] popey: could you grab the bzr branch? [13:19] karni: ping [13:19] duanedesign: pong [13:19] karni: have a quick minute for a PM? [13:19] sure [13:19] * fagan should probably actually take his break :) [13:21] fagan: that would mean going backwards it seems [13:21] that patch is against 1.4, my natty machine has ubuntuone 1.5.8 [13:21] popey: yeah I dont think that branch is upto date [13:21] if chipaca was around he could probably fix it [13:21] :( [13:22] and its sat there for 4 months [13:22] looks like yet another ubuntu release goes by with no proxy support. [13:22] popey: I can chase it up for you if you'd like [13:22] I'd appreciate knowing what can be done to make proxy support work. [13:23] popey: well hopefully the patch can be adapted to the current release so you can test [13:24] its only a few lines [13:24] I could nearly look into it then if someone signs off on it [13:25] * fagan is supposed to be doing ui files for the windows client but this seems important and looks like it wouldnt take too much time [13:26] the patch applies to 1.5.8 in natty [13:26] proxy support doesn't work for everything [13:27] dobey: file sync would be a good start [13:28] popey: if that patch does work, it would be very basic, as the branch name suggests [13:28] define basic? [13:29] right now I dont mind if it doesn't work with authenticating proxies, or other oddness, just observing the http_proxy env var would be a good start :) [13:30] * popey is building it now [13:30] well it only supports HTTPS_PROXY env var, and to get that from the gnome settings, you'd have to run ubuntuone-syncdaemon manually [13:30] ugh [13:30] because dbus daemon is started before gnome-settings-daemon [13:31] so you cant get it from gconf? [13:31] well if someone wrote the code, it could i guess. but that branch doesn't do it [13:32] ok, so that would be a slightly-less-basic patch, if it could get https_proxy from gconf? [13:32] and would be reliable enough to get that on autostart? [13:33] if it talked to gconf/dconf directly, then yes, autostart would work ok. and it would probably not be basic at all [13:34] i guess then there is the issue that if someone changes the proxy settins you have to restart syncdaemon or logout/in to effect the change? [13:35] with that current branch, yes [13:36] would it make sense to check (in syncdaemon) if the proxy changes and trigger a restart itself > [13:36] ? [13:36] * karni @lunch [13:36] (assuming the necessary magic was there to get the proxy from gconf and use it) [13:37] popey: yes [13:38] or indeed would it make sense to do a callback whenever that key changes in gconf? [13:38] (I am not a programmer so if this sounds dumb, sorry) [13:41] * fagan plays call of duty while waiting for standup [13:43] popey: gconf is doable. os.env isn't going to change inside a running program, unless the program itself changes it, or something starts doing evil stuff that one isn't supposed to do [13:43] makes sense [13:44] if we were using gconf though, a restart wouldn't be necessary [13:44] i suppose we should use GSettings/dconf though, instead [13:45] as gconf is deprecated now and all [13:45] oh, didnt know that [13:45] dconf it is then :P [13:46] but i don't know what the state of all that is right now, and the gsettings migration tool was crashing every time i logged in on my laptop until yesterday or something [13:46] it's a touchy area since we are sticking to 2.32 in ubuntu 11.04 [13:49] * mandel back [13:50] dobey: so in theory if I made a patch which used gconf to discover proxy settings and used those, would it get thrown out? [13:50] (subject to usual quality control standards for patch submissions) [13:51] mandel, dobey, thisfred, fagan: stand up in 10' [13:51] 9, actually :-) [13:51] kk [13:52] yep [13:52] ok [13:53] dobey: im pretty sure gconf is still on the disk [13:53] popey: i don't know. [13:53] it just wont be for 11.10 id say [13:53] * fagan checks [13:53] fagan: yes, in 11.04 it is, because we ship 2.32 [13:53] ah ok [13:53] fagan: but writing code that we're going to throw out in 2 months seems like a waste of time to me :) [13:53] yeah thats right [13:54] and anyway we are on a normal release warts are expected :/ [13:55] eh, we haven't ever had proper proxy support in ubuntuone-syncdaemon :) [13:56] popey: also of note, is that even with that previously linked branch, there are a few operations which will not work, because they do not go through the twisted reactor connection, but instead use oauth signed HTTP requests via urllib, which really sucks at proxies [13:57] :( [14:00] me [14:01] ? [14:01] me [14:01]