| * gmb lunches | 12:27 | |
| gmb | Hi gary_poster. Can I just check that we're having the call in an hour or so? UK is now in UTC+1, and for some reason I'm finding +/- 1 to be really difficult maths today. | 13:25 |
|---|---|---|
| gary_poster | gmb, oh, I intended it to be in 5 minutes | 13:25 |
| gmb | gary_poster: That's cool too :) | 13:26 |
| gmb | I just didn't want to wander off to get a drink and find out that I'd missed the call. | 13:26 |
| gary_poster | that's back to the old local time for us, is it for you too? | 13:26 |
| gary_poster | :-) appreciated | 13:26 |
| gmb | gary_poster: Yes. | 13:26 |
| gary_poster | cool | 13:26 |
| gary_poster | bac benji danilo gmb, call in 3 (back to normal local time for US east coast | 13:27 |
| gary_poster | ) | 13:27 |
| benji | yay for time zones! | 13:27 |
| gary_poster | uh oh, /me wonders if danilo got the memo :-) | 13:30 |
| * gary_poster adds an s: danilos? | 13:30 | |
| danilos | gary_poster, no, upgraded this machine to natty so mumble got me through configuration screen again | 13:31 |
| danilos | gary_poster, "danilo" without "s" also pings me fwiw :) | 13:32 |
| gary_poster | :-) k | 13:32 |
| danilos | gary_poster, https://launchpad.dev/firefox/+subscriptions | 13:48 |
| benji | gary_poster: should I push my changes into lp:~gary/launchpad/accordion-client-1? | 13:59 |
| gary_poster | benji, I don't think you can...let me see if I can open it up to you. | 13:59 |
| gary_poster | benji, the branch is now https://code.launchpad.net/~yellow/launchpad/accordion-client-1 | 14:01 |
| gary_poster | and you should be able to push to it | 14:02 |
| benji | gary_poster: cool (I suppose we will have to re-MP it now that it's moved.(?)) | 14:02 |
| gary_poster | benji, the MP appears to have followed along for the ride, happily | 14:02 |
| benji | wow | 14:03 |
| * danilos -> lunch | 14:08 | |
| danilos | back | 14:31 |
| benji | gmb: ok, the lint (and test) fixes are in at https://code.edge.launchpad.net/~yellow/launchpad/accordion-client-1/+merge/54715 | 14:45 |
| gmb | benji: Cool. I'll look now | 14:45 |
| gmb | benji: r=me on the lint changes. | 14:57 |
| * gmb -> afk for a short while | 14:57 | |
| danilos | gary_poster, just to clarify the state of the things re our branches: ~yellow/lp/accordionoverlay is split into -server part (already landed) and -client-1 part (in review); for all our future/in progress branches, we should base them off -client-1, right? | 15:16 |
| gary_poster | danilos, I think that is safe. bac has a third branch, also in ~yellow, that will be a bit gigantic, but it is effectively based on -client-1, and shouldn't affect your work. | 15:17 |
| danilos | gary_poster, sounds very comforting ("gigantic", "won't affect your branch" :)) | 15:18 |
| gary_poster | heh | 15:18 |
| gary_poster | It's the branch that adds links to all of the bug target pages. | 15:19 |
| gary_poster | so it has a bunch of similar tests | 15:19 |
| gary_poster | and a bunch of similar template changes | 15:19 |
| gary_poster | It doesn't touch _subscriptions | 15:20 |
| gary_poster | + | 15:20 |
| danilos | gary_poster, since I also need to worry about this for my in-review branch, and since I already have an MP with "accordionoverlay" as the dep, is it ok to overwrite ~yellow/launchpad/accordionoverlay with accordion-client-1 just for the MP? :) | 15:47 |
| gary_poster | danilo, I think so. It's possible even that -client-1 has all changes from accordionoverlay, in which case the answer is "absolutely". | 15:48 |
| gary_poster | danilo, if you have to --force, then I'm more worried about it | 15:48 |
| gary_poster | but I won't actually worry until you tell me there's a reason to :-) | 15:49 |
| danilos | gary_poster, heh, there's one revision which conflicts (which says something like "Merge latest changes from client branch" | 15:49 |
| gary_poster | :-/ | 15:49 |
| gary_poster | uh, any ideas? | 15:49 |
| danilos | gary_poster, well, I guess it's probably best to just leave it as is, and I'll work it out with my reviewer that some changes are due to merge with the latest underlying work which has moved into a different branch | 15:50 |
| gary_poster | danilos, if you say so. if you merge -client-1 into accordionoverlay instead of pushingm does that result in different branches? | 15:51 |
| gary_poster | or are they then indentical? | 15:51 |
| gary_poster | I bet the conflict is because of conflict resolution I had to do or something | 15:52 |
| danilos | gary_poster, well, at least revision histories would be different, I am unsure about the "textual contents" | 15:52 |
| gary_poster | so merging -client-1 should hopefully result in the same textual contents | 15:52 |
| gary_poster | if that helps | 15:52 |
| gary_poster | then you could maybe even push without complaints | 15:53 |
| gary_poster | or you could push --overwrite with impunity :-) | 15:53 |
| danilos | gary_poster, yeah, I'll check that and try it out | 15:53 |
| gary_poster | cool | 15:53 |
| danilos | gary_poster, yeah, no differences, so I can just push it I hope | 15:53 |
| gary_poster | awesome | 15:53 |
| gary_poster | So far I think I have 13 reviews to give, not including my own. :-P | 16:06 |
| * danilos wraps for the day, cheers all | 18:16 | |
| gary_poster | bye :-) | 18:16 |
| bac | hi gary_poster | 19:32 |
| bac | i've got new subscriptions working on milestone overview pages for products, productseries, and distros. | 19:32 |
| bac | on to bugs pages now | 19:32 |
| gary_poster | fantastic, bac. bugs pages--we missed those? no...not sure what you mean actually | 19:35 |
| bac | gary_poster: i am putting subscribe links on the overview page and the bugs page | 19:35 |
| bac | so it appears on launchpad.net/firefox and bugs.launchpad.net/firefox | 19:35 |
| gary_poster | bac, got it, duh | 19:35 |
| bac | gary_poster: actually i was wrong, which means there is less work to do | 19:50 |
| bac | there is no such thing as a bugs facet for a productseries | 19:51 |
| gary_poster | even yay-er | 19:51 |
| bac | if you're looking at bugs.launchpad.net/firefox/1.0/1.0.0 (a product series) | 19:51 |
| bac | clicking on 'bugs' tab takes you to bugs.launchpad.net/firefox | 19:51 |
| bac | so i think i'm done | 19:52 |
| gary_poster | awesome! | 19:52 |
| gary_poster | so what's next, and should I help? | 19:53 |
| bac | i just confirmed the tests all pass | 19:56 |
| bac | next i need to merge in the latest, wherever that may be, and then deliver this somewhere | 19:56 |
| bac | gary_poster: you can help me figure out those two things. | 19:56 |
| bac | but right now i need to be afk for a bit. i'll ping you a little later if that's ok | 19:57 |
| gary_poster | I think that danilo merged -client-1 into ~yellow/lp/accordionoverlay | 19:57 |
| gary_poster | checking | 19:57 |
| gary_poster | if so, that's the thing to merge, I think. or -client-1. They are effectively identical, except in history. | 19:58 |
| gary_poster | "deliver this somewhere": I think that you are waiting for the -client-1 branch to land. benji, I saw Graham's review. Does that mean that you are ready to merge, or you still have other stuff to do? | 19:59 |
| benji | gary_poster: still working on the non-lint bits; just plug-and-chug left now | 20:00 |
| gary_poster | cool | 20:00 |
| gary_poster | bac: here's my suggestion: | 20:01 |
| gary_poster | 1) merge in lp:~yellow/launchpad/accordionoverlay | 20:01 |
| gary_poster | 2) push to LP | 20:01 |
| gary_poster | 3) make a mp depending on either lp:~yellow/launchpad/accordionoverlay or lp:~yellow/launchpad/accordion-client-1/ (identical) | 20:02 |
| gary_poster | 4) get it reviewed | 20:02 |
| gary_poster | 5) wait, if necessary, for lp:~yellow/launchpad/accordion-client-1 to be landed | 20:02 |
| gary_poster | (uh, 6, land it) | 20:03 |
| gary_poster | (7, go for a walk) | 20:03 |
| gary_poster | (etc.) | 20:03 |
| === Ursinha is now known as Ursinha-lunch | ||
| benji | gary_poster: all the fixes have been applied | 20:30 |
| gary_poster | great benji. Does that need another review from Graham, or is that good to go? | 20:31 |
| benji | gary_poster: he had already approved it and then approved of my lint changes, so -- assuming he doesn't object wildly to anything I did in this last round (and I wouldn't expect him to) -- we should be ready to go | 20:32 |
| gary_poster | so that means you can land? | 20:32 |
| benji | gary_poster: sure, I can do it | 20:33 |
| gary_poster | yay! | 20:33 |
| benji | it'll help me put off reviewing the two > 11K line MPs in the queue ;P | 20:33 |
| benji | wait, make that 1K :) | 20:33 |
| benji | (what's an order of magnitude between friends) | 20:34 |
| gary_poster | :-) | 20:34 |
| benji | gary_poster: will you set a preferred email address on ~yellow? ec2 land is barfing because it desn't have one | 21:04 |
| gary_poster | meh, sure | 21:04 |
| gary_poster | benji, (1) I made eveyone on team an administrator. (2) I set up a mailing list; I think that will become the contact email once it has approved. I'll ping when it is done and I have confirmed that it is the contact email. | 21:07 |
| benji | k | 21:07 |
| * benji is tempted to put Gary as the contact email in the meantime just to get this going. | 21:08 | |
| gary_poster | Can't--my email is already registered... | 21:09 |
| * benji is tempted to put benji+this-is-temporary@benjiyork.com instead. | 21:11 | |
| gary_poster | benji, ok, if you wanna :-) | 21:12 |
| benji | gary_poster: the temporary email address worked and the new list is now the contact address | 21:23 |
| gary_poster | benji, yeah I changed it too. :-) thank you | 21:24 |
| benji | :) | 21:24 |
| === Ursinha-lunch is now known as Ursinha | ||
| gary_poster | Performed urgent and essential task of updating team image for https://edge.launchpad.net/~yellow | 21:31 |
| benji | heh | 21:36 |
| bac | gary_poster: i just saw your suggested merging steps and will give them a go | 21:36 |
| gary_poster | cool bac. Note that benji has now sent -cleint-1 to ec2 test I think, so hopefully we're on our way there roo | 21:37 |
| gary_poster | too | 21:37 |
| gary_poster | kanga | 21:37 |
| bac | gary_poster: so why should i merge from accordion-overlay instead of client-1? | 21:38 |
| gary_poster | bac, it doesn't matter; they are identical. Do what makes sense for you. | 21:38 |
| gary_poster | they are identical because danilos was already using accordionoverlay as a MP predecessor | 21:38 |
| benji | now that we're all adminstrators we can periodically change the team image to random yellow things | 21:38 |
| gary_poster | and wanted the -client-1 stuff | 21:38 |
| gary_poster | +1 benji :-) | 21:38 |
| bac | gary_poster: and i should push it to something else like client-2? | 21:39 |
| gary_poster | bac, or whatever works for you, sure. | 21:39 |
| bac | gary_poster: what is the status of the 'edit' links for existing structural subscriptions? will that be done in a second pass, mimicing the work i just did/ | 21:40 |
| gary_poster | bac, yes | 21:40 |
| bac | ok | 21:40 |
| * gary_poster hopes/assumes it will be easier to follow in your footsteps now that you have blazed the trail | 21:41 | |
| bac | only 3 conflicts | 21:41 |
| gary_poster | hopefully good. | 21:41 |
| bac | benji: should i be using StructuralSubscriptionJSMixin everywhere i'm currently exposing data to JS? | 21:54 |
| benji | bac: hmm, I haven't heard of that guy, but suspect Gary refactored a the group of expose_* function calls into it | 21:55 |
| bac | ah, i figured you did it. | 21:56 |
| bac | it wants to make providing a 'subscriptions' property required, but with a bit of work i can make it so i can use it without providing that property | 21:57 |
| gary_poster | bac, yeah, that was a review request from Graham | 22:01 |
| gary_poster | and +1 on refactoring to make it easier to reuse | 22:02 |
| gary_poster | since that was the point | 22:02 |
| bac | gary_poster: it may not be easier to use but will allow me to defer providing that definition until it is needed | 22:03 |
| bac | which is easier, i guess | 22:03 |
| gary_poster | yeah, sounds like it :-) | 22:04 |
| bac | gary_poster: in browser/bugtarget.py | 22:08 |
| * gary_poster listens | 22:08 | |
| bac | ah, never mind | 22:08 |
| gary_poster | k :-) | 22:08 |
| bac | i expected to see a 'super' but you're calling the initialize from another class directly | 22:09 |
| gary_poster | looking... | 22:09 |
| bac | is that correct? how is the initialize from StructuralSubscriptionJSMixin called? | 22:09 |
| gary_poster | bac, yes, it is first in the inheritance list | 22:10 |
| gary_poster | so it's initialize is called | 22:10 |
| bac | which 'it'? | 22:10 |
| gary_poster | which then calls out to LaunchpadView in its own super | 22:10 |
| gary_poster | So in class TargetSubscriptionView(StructuralSubscriptionJSMixin, LaunchpadView): | 22:10 |
| gary_poster | TargetSubscriptionView does not define an initialize | 22:11 |
| gary_poster | so the first defined initialize in the subsclasses reading left to right is the class' initialize | 22:11 |
| gary_poster | StructuralSubscriptionJSMixin has an initialize | 22:11 |
| bac | ok, we're looking at different classes. | 22:11 |
| gary_poster | oh | 22:12 |
| bac | sorry, i got confused | 22:12 |
| bac | but look at BugTargetBugsView | 22:12 |
| bac | if i add the new JSMixin to the list of inherited classes | 22:12 |
| bac | must i call the initialize manually? | 22:12 |
| gary_poster | If the new JSMixing class is first, then you should be able make a super call | 22:13 |
| gary_poster | JSMixin | 22:13 |
| gary_poster | Or if BugTaskSearchListingView is first and it does the proper super dance then it should work fine too | 22:13 |
| bac | it already has a call to BugTaskSearchListingView.initialize() | 22:13 |
| gary_poster | right. That should no longer be necessary, because the JSMixin has a super call in it too | 22:14 |
| gary_poster | So if I were doing it | 22:14 |
| gary_poster | I'd try putting the JSMixin as the first inherited class | 22:15 |
| gary_poster | and then I would try changing BugTaskSearchListingView.initialize(self) | 22:15 |
| gary_poster | to | 22:15 |
| gary_poster | super(BugTargetBugsView, self).initialize() | 22:15 |
| gary_poster | as you'd expect | 22:15 |
| gary_poster | that should call to the JSMixin's initialize | 22:15 |
| gary_poster | which should then call the BugTaskSearchListingView's initialize | 22:15 |
| bac | even though BugTaskSearchListingView doesn't do the proper super dance? | 22:15 |
| gary_poster | yes, because I said that you should put the JSMixin first | 22:16 |
| gary_poster | and it *does* do the proper super dance | 22:16 |
| gary_poster | make sense? | 22:16 |
| bac | sort of | 22:16 |
| gary_poster | what part doesn't? I might be making a mistake | 22:17 |
| bac | i see that currently BugTaskSearchListingView.initialize does not call super | 22:17 |
| bac | instead it does some work then calls LPFormView.initialize() | 22:17 |
| bac | so, given that existing code, the approach you suggest will still work? | 22:18 |
| gary_poster | I believe it will yes | 22:18 |
| bac | ok, i'll give it a try then | 22:18 |
| bac | gary_poster: mumble real quick? | 22:22 |
| gary_poster | Sure bac | 22:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!