| kapil | g'morning | 16:39 |
|---|---|---|
| === deryck is now known as deryck[lunch] | ||
| _mup_ | ensemble/new-hook-semantics-departed r181 committed by jim.baker@canonical.com | 19:09 |
| _mup_ | Add -departed hook | 19:09 |
| kapil | bcsaller, jimbaker standup? | 19:23 |
| bcsaller | is there something we need to cover today? I'm finishing up stuff I didn't get to this weekend | 19:23 |
| kapil | bcsaller, nothing in particular.. i was just wanted to touch base and where we are on our tasks from last week, and what we're working on this week | 19:25 |
| bcsaller | almost done with this darn spec, but we can do a quick call to cover it | 19:26 |
| kapil | bcsaller, great | 19:28 |
| kapil | jimbaker, skype? | 19:28 |
| jimbaker | kapil, sounds good re skype | 19:32 |
| === deryck[lunch] is now known as deryck | ||
| kapil | jimbaker, just see your cell phone on skype | 19:33 |
| jimbaker | kapil, that's probably because i'm not logged in :) | 19:34 |
| jimbaker | hold on, super noisy here - i'm at coffee shop while car is being worked on | 19:34 |
| jimbaker | kapil, i see bcsaller on skype but not yet you. split brain? | 19:36 |
| kapil | jimbaker, cloud :-) | 19:37 |
| kapil | jimbaker, not seeing you on skype | 19:42 |
| kapil | jimbaker, or it fails constantly | 19:42 |
| kapil | jimbaker, you should just be able to just modify unit relation lifecycle _execute change hook | 19:43 |
| kapil | and switch the hook path based on change | 19:43 |
| jimbaker | kapil, back now | 19:53 |
| kapil | jimbaker, did you see my comments above about _execute_change_hook? | 19:53 |
| jimbaker | kapil, yes | 19:53 |
| kapil | cool, afaics that should be all that needs modification to support additional separate hooks for change, depart, join | 19:54 |
| jimbaker | that's actually where i made the change | 19:54 |
| jimbaker | so maybe i'm overanlyzing here then... i just want to ensure that niemeyer's plan of having the existing semantics co-exist with the new semantics can work | 19:55 |
| kapil | a change there should do that | 19:55 |
| kapil | and ditching the removal of the CHANGE env var | 19:56 |
| kapil | also within that method could be done the expansion of join to include modify | 19:56 |
| jimbaker | kapil, agreed on that | 19:56 |
| jimbaker | so basically we can simply execute an arbitrary number of hook executions (seen with yield self._executor(...)) | 19:57 |
| jimbaker | although in this case, arbitrary means up to two | 19:57 |
| kapil | jimbaker, generically.. yes. specifically we want two | 19:57 |
| kapil | jimbaker, sounds good | 19:57 |
| jimbaker | kapil, sounds good. i was getting worried this was getting too complicated. and i didn't want to change more unit tests than necessary for all the obvious reasons | 19:58 |
| jimbaker | thanks | 19:58 |
| kapil | jimbaker, np | 19:58 |
| kapil | i'm going to meander and see i can find some lunch | 19:58 |
| kapil | bbiab | 19:59 |
| kapil | hmm.. looks like nova is almost done adding lxc support | 20:10 |
| _mup_ | ensemble/new-hook-semantics-departed r182 committed by jim.baker@canonical.com | 20:23 |
| _mup_ | Keep existing semantics for departed; make it possible to invoke multiple hooks for one change | 20:23 |
| _mup_ | ensemble/new-hook-semantics-remove-ensemble-change-env-var r186 committed by jim.baker@canonical.com | 23:52 |
| _mup_ | Modified examples for new hook semantics | 23:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!