[00:53] due to heavy cough, my voice is so low I could work as a voice over man [01:22] good night everyone [02:18] How can I add my own music onto U1, to be available as purchased music is? [02:34] vadi2, to stream it? [02:35] Yeah [02:35] and sync between computers as well [02:35] vadi2, just make sure the folder where the music lives is being synced [02:36] I don't know where U1 put the purchased music though, I'd like to use the same one [02:40] vadi2, ~/.ubuntuone/Purchased from Ubuntu One/ [02:41] ty [07:55] morning all [07:56] mandel: im going to start an hour later to get more time with ralsina later [07:56] so ill be starting in an hour rather than now [08:17] fagan: sure, np [08:17] fagan: but remember that he wants you do seom exercises before he arrives [08:18] mandel: yeah loads of time id say [09:02] ok so mandel what is my task :) [09:03] fagan: give me a second and I'll find it for you, one sec [09:03] or min :P [09:03] sure its cool [09:05] * fagan makes tea [09:11] fagan: ther you go: http://paste.ubuntu.com/587264/ [09:16] mandel: ok [09:24] fagan: it would also be nice if you try to use a more advance editor than gedit to do it like vim/emacs [09:26] mandel: well I did orignally but then always settled on gedit [09:26] but ill give it a go [09:27] fagan: it takes time to get used to one of them, but ti is an advence tool, and once you get used to it, you will work a lot better [09:27] mandel: sure [09:28] fagan: I use vim and I can give you a hand setting it up, I have no clue about emacs, but I know thisfred and vds can help you to set ip up for python devel very quickly [09:28] you can even add a pylint/pyflakes plug in to help you with the pep8 things etc.. [09:29] fagan, hello! ping me if I can be of any help. [09:29] vds: you are great :) [09:29] vds: cool thanks [09:29] mandel: just installing [09:29] mandel, I'm just big... :P [09:30] vds: hehehe :) [09:30] * fagan was just scanning down synaptic for vim stuff to try out [09:40] Yeah I think I realised what I never got into using vim [09:40] :) [09:44] fagan: there is a nice tutorial tht you can run within vim to start using it, should be a good start [09:44] fagan: but do take a look at emacs too, some people find it hard to get their head around vim due to the way it works [09:45] mandel: yeah I remembered that I couldnt figure how to save a file back in the day when i tried first but I got it now [09:45] (esc+:w) [09:46] the esc bit was what I never did [09:47] mandel: oh there is only 1 think id like now and that is undo [09:47] u [09:47] mandel: :u ? [09:48] redo: ctrl+r [09:48] oh its just ctrl u [09:48] fagan: when you are not in edit mode [09:48] is just u [09:48] where edit mode is i [09:48] thats interesting because everywhere else its ctrl+z [09:48] in vim you want to be in edit mode as little as possible [09:49] so that you can use dw, dd, etc.. ithout having to do esc all the time [09:49] thats why I say, try also emacs, so that you see which one fits you better [09:49] ah ok [09:50] ill give vim a go today and give emacs tomorrow and see which I like [09:52] I'd say a week each [09:53] Chipaca: well I pick up on stuff pretty easy so a day would be good enough to get the flavor [09:53] But I could go a week and see anyway [09:53] also: if you have somebody close to you who uses one of them, use that -- having somebody point you at productivity tips kills anything the software might give you (in this case, i mean, where they're pretty much the same, if completely different) [09:55] I think we have people on both sides of the fence, so without starting yet another editor war, I think we have enough people to give you a hand :) [09:55] religious battle on!! [09:55] The winner gets me [09:59] mandel: I think I can do this task in the lowest amount of code [09:59] :) [10:00] fagan: cool, when done ping me if you want so I can take a look [10:00] if ralsina is not here, I think he wanted to do that [10:01] mandel: well its still early there [10:04] fagan: if he says he will be up early , generally he is [10:04] yeah I know [10:04] I presumed early would be like now or in an hour I suppose [10:04] I'd not be surprise if he is here in an hour or earlier :) [10:05] mandel: oh 1 more question whats the binding for pasting? [10:05] (ctrl+v in most other editors) [10:06] p [10:06] fagan: here is how it goes, there are diff ways to copy in vim [10:06] for example yw il copy the word you are on [10:06] and p will paste it [10:06] yy will copy the entire line [10:06] and p will paste it [10:07] ofcourse if you want to copy more than one word, for example 3 you can do: [10:07] 3yw [10:07] and if you want to paste something more than once you can do [10:07] 3p [10:07] :) [10:07] ahh [10:07] x is cut :) [10:08] d == delete [10:08] dw == delete word [10:08] dd == delete line [10:08] and ofcourse the use of number to repeat actions, 3dw, 3dd [10:08] etc... [10:09] I trigged code completion there accidently [10:09] :) [10:10] haha :) [10:10] ill get the hang of it [10:10] fagan: one thing I find very useful are the :split and :vsplit to have more than one buffer open in the same terminal [10:10] so :vsplit /pat/to/file will open a vertical bufffer with the new file [10:11] ctrl+w allows you to move around the buffers [10:11] Oh that sounds like it would be useful [10:11] all this in terminal vim, and dont know how it works in gvim :) [10:12] well I was presuming if I wanted to have more than 1 "window" id have to make some screens [10:17] \o/ I crashed the pep8 checker [10:19] really? [10:20] mandel: yep [10:20] hehe [10:32] mandel: do I have do handle decimal places in this example [10:35] fagan: what do you mean exactly? [10:35] mandel: 13.9% rate $1321.42 dollars [10:35] ...etc [10:36] yes [10:36] I dont exactly know how to do that [10:36] :) [10:38] The good news is im almost done [10:38] what do you mean you dont know? the formula is: [10:38] amount = principal * ((1 + (rate / 100.0)) ** years) [10:39] so, you just get the values from the ui, calculate and return it [10:39] mandel: I have it displaying the decimal places fine but for the spinboxes and stuff [10:39] do I need to have them allowing decimal places [10:40] did you look at the image http://twitpic.com/4ew55l? [10:40] yep [10:40] so it should but I dont know how to do it [10:43] fagan: I'm very tempted to give you the straight answer…. [10:43] ha [10:43] but instead, as I'm a bastard, I'll give you this: http://www.opendocs.net/pyqt/pyqt4/html/qspinbox.html [10:43] :) [10:44] is not directly the answer, but somewhere in there it tells you how to do it [10:44] hmmmmm [10:48] fagan: can you find it? [10:49] mandel: nope :) [10:50] well, if I were you and I was reading docs in a webbrowser and wantd to know that, I'd do a search for double or floating [10:50] right, since 2.3 is a double, but they are represented as a floating point :P [10:52] found it already? [10:52] so there is a double spin box [10:52] yes :) [10:56] Hmmm self.sender.objectName() doesnt work [10:58] why do you need self.sender.objectName() ? [10:58] Oh I can get around it [10:58] mandel: well I wanted to get the name so I knew what was sending the signal [10:58] and then use a bool to check what has been edited [10:58] But maybe I could have do that another way [10:59] fagan: I dont think you are doing the logic correctly, no matter which spinbox sends the signal, you have to recalculate the value, so the slot use for any of the signals is the same [11:00] QObject.connect(self.ui.spin1, SIGNAL('valueChanged(double)'), self.recalculate) [11:00] mandel: ah so I dont need to conditionally check if its been edited and then go do the work [11:01] mandel: i was handling that event anyway [11:01] fagan: if you get the signals, is that the value changed, right? [11:01] I mean, the signal is called valueChanged :) [11:02] mandel: well I was thinking that id have to check if all 3 were edited first [11:02] but that doesnt really make much sense I suppose [11:03] no, it does not, the formula uses the 3 of them, ergo one of the out od date == wrong value for the user [11:06] ok im almost done then [11:11] hi everyone [11:12] hey karni [11:12] * karni waves at fagan \o [11:21] DONE \o [11:22] and pushed [11:22] * fagan dances till ralsina comes to judge [11:23] hi fagan, stop that! ;-) [11:23] hah [11:23] good morning everyone [11:23] * fagan cleans the code up a bit anyway [11:24] ralsina: internet any better? [11:25] apparently [11:25] but I've only been using it 2 minutes ;-) [11:25] anyway, one small thing to consider: the value of loose coupling [11:25] I saw you wanted to check the sender of a signal. 99% of the time, don't do that. [11:26] Oh forgot I have to sort something with payroll real quick [11:26] Usually, requiring to know who triggered the callback is a sign of poor design, and means your callback does too much [11:26] ralsina: yeah I stopped that as soon as I realised that was bad [11:26] fagan: cool. It's a code smell when you are doing Qt [11:27] go ahead with payroll [11:27] ill push the code first [11:28] ralsina: lp:~shanepatrickfagan/+junk/compound_interest [11:31] morning [11:32] morning rye [11:33] fagan: wakeup son time, but I will be taking a look and get back to you in about... 75 minutes [11:33] ralsina: cool [11:34] it'll probably take me that long to email about payroll [11:36] morning all [11:36] fagan: I never cared much about payroll. You jumping around and talking about it makes me stressed I'm missing something ;d [11:36] hi duanedesign ! [11:37] karni: ha I have to submit an invoice to get paid so its takes a bit of effort the first time [11:37] hey duanedesign [11:37] fagan: ah! right, that's what I did once as well. [11:38] karni: so I have to find my bank details and then get all the info right [11:38] so its a bit of a pain since I dont have it at hand [11:38] fagan: yes, now I get it. I went through that as well. [11:38] I have called my bank back then for the details. [11:39] karni: well its in my sent mail for my email so its not that hard [11:39] so, people, is there anybody using maverick now? [11:39] * fagan participated in a pyramid scheme [11:39] fagan: i finally found a solution to running history command w/ python: subprocess.Popen(bash -i -c "history -r; history", shell=True, stdin=PIPE, stdout=PIPE, stderr=STDOUT) [11:40] rye: I have a vm, is that of any use [11:40] fagan: o_O you went for that? [11:40] Is there anybody whose gnome-settings-daemon crashes with the newest ubuntuone-client ? [11:40] rye: I havent been using maverick since alpha 1 [11:40] mandel, i also have a vm, but it is not crashing [11:40] :) [11:41] fagan, ah, no, it is in maverick-updates, something is bad with bug #744383 [11:41] Launchpad bug 744383 in ubuntuone-client (Ubuntu) (and 1 other project) "gnome-settings-daemon crashed with SIGSEGV in g_str_hash() (affects: 2) (dups: 1) (heat: 18)" [High,New] https://launchpad.net/bugs/744383 [11:41] crap [11:41] duanedesign: thats nice [11:43] fagan: a few quick observations. [11:43] ralsina: shoot [11:43] its just a first run through though [11:43] fagan: when you are doing a layout that is a column of "label:" widget things? Use a form layout [11:43] ralsina: ah ok [11:44] That makes it look "right" because each platform has different conventions about alignment and such [11:44] yeah thats ok [11:44] also, you are missing a label [11:44] I just did a qwidget I think [11:44] it doesn't matter if it's a qwidget or not [11:44] ralsina: which one? [11:44] QFormLayout is a form of layout, like a grid or a vertical layout or horizontal. [11:44] "Amount:" [11:44] ah ok [11:45] fagan: it started to become a challenge rather then a practical solution :P [11:45] duanedesign: yeah it sounded like a pain [11:45] fagan: since part of the exercise is "make it look like this", attention to detail and *making it look like that* are very important. Remember we are working with wireframes provided by designers. [11:45] fagan: so, iterate, and I'll take another look when I come back. [11:46] fagan: also note, I have not even looked at the code ;-) [11:46] yeah and the css isnt needed there at all I just left it from the old example [11:46] yes, remove the CSS [11:46] ralsina: yeah the code is ok ish but isnt up to standard in terms of style [11:46] oh, and if you use compiled resources, provide a way to create them, even if it's just a file with the commands written on it [11:47] fagan: I really have not looked, so fix all you want and I will not check the commit history ;) [11:47] ralsina: yeah I was going to create a setup.py to make it easier to test [11:47] fagan: that may be overkill for these exercises, but it's ok if you want [11:48] well it wouldnt be hard to make an sh then instead [11:48] basically "pyrcc4 whatever.rc -o whatever.py" and so on [11:49] also, check the IRC log, check what you have discussed with mandel, and try to follow his advice. If you decide not to, have an explanation handy. [11:49] ralsina: yeah im using vim now and all [11:49] and the other stuff I did too [11:50] fagan: cool ;) [11:53] fagan: you are going to think I am nitpicking your little example app to death. That is correct, because that's what doing UI work is, a constant series of nitpicks. Have fun ;) [11:53] ralsina: well thats the joys of an evolutionary approach to learning [11:53] :) [11:54] yep. Get cranking as soon as you are done with payroll [11:54] ralsina: email just sent [11:55] ralsina: the amount label is there ? [11:55] oh and i was wrong I made that as a mainwindow [11:55] fagan: check the image you were given, please. Put them both side by side. [11:56] But you are right, you do have an amount label ;) [11:56] oh I just renamed it [11:59] check the number of rows on both. [11:59] oh [11:59] whoops [11:59] and the number of columns on each row [12:00] so, no more feedback, iterate and come back with another version. [12:00] ralsina: just about to push a new version [12:01] take your time. This one was rushed. Check, run the tools I gave you, fix what they tell you to fix, I am not in a hurry. [12:02] cool [12:20] yay I went from a -214.23/10 to 7.08/10 on pylint [12:20] \o/ [12:33] * mandel walking dog [12:52] ralsina, have you by any chance chased the "tomboy is pointing to edge" thing? [13:02] * fagan lunch [13:14] Standup in the 45 yeah? [13:22] fagan: yes [13:22] beuno: nope [13:22] beuno: noone has touched anything in tomboy, why is it pointing to edge now? [13:23] fagan: feel free to push a branch whenever you have something to show me [13:28] ralsina: branch already pushed [13:28] fagan: cool, I'll take a look right now [13:34] ralsina, the api [13:34] is pointing to the edge servers [13:35] argh [13:35] beuno: ok, I'll take care of it [13:36] fagan: it doesn't seem to actually work [13:37] ralsina: whats the output? [13:37] nothing [13:37] ralsina: did you run python main.py or ./main.py [13:37] because: AttributeError: 'MainWindow' object has no attribute 'ui' [13:37] oh my bad [13:37] fagan: should be the same thing one way or the other [13:38] ill fix it after standup I was trying to pass pylint [13:38] there was some name issue [13:38] its something small [13:39] fagan: passing pylint is not useful if it doesn't work ;) [13:39] ralsina: yeah I know I just changed a name and thought I tested it [13:39] fagan: every branch you do here will have to pass reviews (2). If you don't check things carefully, you waste the time of 2 other developers. [13:39] yeah I know [13:40] fagan: ok, I'll wait for the next iteration then. [13:40] fagan: you may want to read about "new style" connects in PyQt. let me find that doc... [13:40] yeah its just a 1 minute fix [13:41] fagan: read this, it will make your code cleaner: http://pysnippet.blogspot.com/2010/01/new-style-pyqt-signals-and-slots.html [13:42] cool will look at it after break [13:42] ok [13:44] does anyone know if it's impossible/bad form to pass command line arguments to the executable when using dbus activation? [13:44] ralsina: actually im not doing anything at the moment anyway now so ill come off break now and fix it [13:45] fagan: no need, but feel free! [13:48] ralsina: working and pushed now [13:48] cool, will check [13:49] could you explain what the 2 errors pylint is outputting? [13:49] thisfred, perhaps there's some way to do it from the .service file. [13:49] thisfred, but I don't think that makes much sense. [13:49] ralsina: Ill go fix the style now too [13:49] alecu: When I google it, it seems that it's possible, but of course nowhere is it documented [13:50] alecu: yeah, then you [13:50] 're still locked into a single set of values [13:50] fagan: there must be something wrong with the formula because $100 at compound interest for 0 years should not give you $0, but that's neither here nor there [13:50] and you might as well make them the defaults [13:50] thisfred, right [13:51] alecu: maybe I need to split the service activation and the calling of the method, but I don't know how to do that without creating timing issues [13:52] * fagan googles compound interest [13:52] alecu: actually, it seems calling the method should just work, I don't know why it doesn't [13:53] oh I screwed a little bit of the logic up [13:53] * mandel back [13:54] thisfred, right. The only thing you do from the outside is calling the method; the activation happens automatically if the process is not running yet. [13:54] did I miss the stand up? [13:54] mandel, it's in 5' I believe. [13:54] yep [13:54] cool :) [13:54] alecu: yeah, so when I call the method, the service is started, but it looks like the method is not called, i.e. the panel does not switch [13:54] probably a bug somewhere still [13:55] ah [13:55] I know [13:55] the service file does not point to my branch. Doh [13:55] :-) [13:56] fagan: if you check the object inspector in designer, you will notice there is a problem with the layout [13:56] ralsina: will do [13:56] also, the names you give to the objects are instance names, so they should be like object_name, not ObjectName [13:57] ralsina: ok ill fix it. Thats me going back to my college's naming conventions [13:57] also, the app starts with the objects initialised wrong [13:58] as in, the "output" label is showing the wrong value. [13:58] And, last one: look in your IRC client log for QDoubleSpinBox [13:58] ralsina: the output label should be blank by default I thought? [13:58] fagan: why? [13:58] fagan: the inputs are not blank [13:59] the output should always match the expected result for theinputs [13:59] ralsina: Ok I didnt and I did have it as a QDoubleSpinBox but something dumb happend and I forgot to change it back [14:00] ill fix it now [14:00] don't rush it, compare it to what we asked for before pushing. [14:01] me [14:01] me [14:01] alecu dobey mandel thisfred remember the new standup schedule? Well, it's now ;-) [14:01] me [14:01] me [14:02] nessita is not here but I have her report, so "me as nessita" [14:02] so go? [14:02] me [14:03] go fagan go! [14:03] DONE [14:03] * Did more python/pyqt polishing: - Did a compound interest converter (which passes pep8 and almost passes pylint) [14:03] * Got payroll sorted [14:03] TODO [14:03] * More pyqt stuff [14:03] * harsh reviews from ralsina [14:03] * try out vim and emacs and choose which one I like better [14:03] BLOCKED [14:03] * nope [14:03] mandel: go [14:03] * ralsina is not harsh [14:03] hehe [14:03] * ralsina is a freaking teddy bear [14:04] ;) [14:04] DONE: Fixed branch issue in the windows code of sso which I requested to review to ralsina and nessita. Added extra test to the sso ui on windows so that if the .ui files change we can ensure that everything will work. Added root object to start the qt ui on windows with sso which means that everything is in place to use it on windows. [14:04] TODO: propose merges, package sso as a .exe to be executed at boot time. Talk with clarita about certain parts of the user journey in sso on windows. [14:04] BLOCKED: no [14:04] ralsina: go go go [14:04] * DONE get ubuntuone-couch into natty [3/3] [14:04] - [X] 0.2.0 https://code.launchpad.net/~thisfred/ubuntuone-couch/release-0.2.0/+merge/53317 [14:04] - [X] ubuntuone-couch FFE http://pad.lv/729117 [14:04] - [X] wait for the package to get through the upload queue [14:04] * DONE review https://code.launchpad.net/~pedronis/ubuntuone-servers/couchdb-migration-cleanup-retry-n-fixes/+merge/55520 [14:04] * INPROGRESS notifications/alerts of quota events http://pad.lv/702172 https://code.launchpad.net/~thisfred/ubuntuone-client/quota-notifications [14:04] NEXT: ralsinessita [14:04] oops [14:04] DONE: calls, reviews, sprint stuff, wrote a webforum over lunch [14:04] TODO: same things, but more, plus performance reviews [14:05] BLOCKED: no [14:05] ralsinessita! [14:05] DONE: bug #704434, bug #726867. Coded new branch for SRU+UIFE bug #742678, so the register_user API is restored to avoi API changes. While testing a branch, I files bug #744980 and I started to fix it. [14:05] TODO: finish bug #744980, fix bug #729301. If there is time left, fix bug #726612. [14:05] BLOCKED: nopes [14:05] Launchpad bug 704434 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "Stop the backend service when UI is done (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/704434 [14:05] Launchpad bug 726867 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "Devices tab shows nothing when syncdaemon is not responsive (affects: 2) (heat: 10)" [High,In progress] https://launchpad.net/bugs/726867 [14:05] Launchpad bug 742678 in ubuntu-sso-client (Ubuntu Maverick) (and 3 other projects) "[SRU] Registration should require user full name (affects: 1) (heat: 12)" [Undecided,New] https://launchpad.net/bugs/742678 [14:05] alecu? [14:05] Launchpad bug 744980 in ubuntuone-client (Ubuntu) (and 1 other project) "Disable/enable file sync is buggy (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/744980 [14:05] Launchpad bug 729301 in ubuntuone-control-panel (Ubuntu Natty) (and 2 other projects) "When disabling file sync from Servies tab, update FIleSyncStatus (affects: 1) (heat: 147)" [Medium,Triaged] https://launchpad.net/bugs/729301 [14:05] Launchpad bug 726612 in ubuntuone-control-panel (Ubuntu) (and 1 other project) "Value could not be retrieved: Need to validate OAuth tokens (affects: 1) (heat: 123)" [Medium,Triaged] https://launchpad.net/bugs/726612 [14:05] DONE: chased zeitgeist issue breaking client tests on maverick. Helped debug webclient non-timeouting on network disconnection. Started looking at client-server tests breaking up. Pre-reviewed the control panel activation branch for thisfred. [14:05] TODO: fix client-server tests [14:05] BLOCKED: no [14:07] ok, I need a volunteer to fix something on tomboy [14:07] comments? [14:07] it's pointing at edge and it shouldn't [14:07] * alecu watches everybody take a step back [14:07] ouch [14:08] * fagan hides [14:08] alecu: :-) [14:08] alecu: beuno has more details, but I don't think there's much more than that, really [14:09] alecu: do ping me to do reviews, I should be able to do some c# :) [14:09] dobey: when you come back, vds is going to do the server side for banshee, please point him to the related banshee client code so he knows what his input is [14:09] ralsina: I think I fixed the calculating problem [14:09] it gives a pretty big number now [14:09] fagan: cool, push the branch whenever you want, I'll take a look at it :-) [14:10] I could cast it though if its too big [14:10] ralsina: already pushed [14:10] fagan: don't worry about that, floats should cover us for all expected purposes [14:10] :) [14:13] fagan: layout still wrong (nested vertical and form layouts, you don't need the vertical one), empty label on startup, no QDoubleSpinBox, missing file to compile the .ui. Please fix that before pushing again. [14:13] ralsina: if you do have time, the merge proposal fro yesterday is now fixed: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_windows_startup_script/+merge/54888 [14:14] as I said, don't rush it [14:14] mandel: sure, on it [14:14] ralsina: I forgot to add the setup.sh file whoops. And the layout is vertical to expand the form layout since it doesnt want to normally [14:14] ill go fiddle since I think I might have done it wrong originally [14:15] fagan: it will if you use the form layout as the window's layout. Arrange the widgets, then right-click and "layout in a form layout" [14:17] * alecu will reboot after many upgrades [14:21] alecu, right, so it seems tomboy since Maverick? or before, has edge as its api url [14:21] we need to change that in trunk, and backport the fixes [14:21] beuno, ok, I'll look into it. === m_conley_away is now known as m_conley [14:30] ralsina: he, I just show something funny/stupid I did, look at line 74 of the diff [14:30] ralsina: actually i didn't remember. and this weather is killing me [14:30] but anyway [14:30] λ DONE: call about backports, aptdaemon confusion [14:30] λ TODO: peer evals, UIFE request, finish bug #733327, libu1 release [14:30] λ BLCK: aptdaemon is full of lies. [14:30] Launchpad bug 733327 in libubuntuone (Ubuntu) (and 1 other project) "Notify user of missing MP3 support (affects: 1) (heat: 208)" [Medium,Confirmed] https://launchpad.net/bugs/733327 [14:31] * mandel fixes it before rms kills him [14:32] loved the "aptdaemon is full of lies" line. hate what it means, though! [14:32] mandel: too late, the ninja robots are already on the way [14:33] hope they bring cookies! [14:33] the ninja robots always bring cookies. OF DEATH! [14:33] ralsina: hmmmmm im going mad now :) [14:33] fagan: ask anything you need :) [14:34] ralsina: the rates arent being properly calculated [14:34] I cant figure why [14:35] check the formula mandel gave you, and compare it to the one in your code [14:35] ralsina: yeah it should be right I was missing the math.exp thing [14:35] ralsina, beuno: tomboy trunk has no references to edge (nor to ubuntuone); it's in the packaging diffs that it points to edge. [14:35] fagan, paste your formula here [14:35] ok [14:36] ralsina, beuno: I can see it goes back to maverick, but not lucid, by looking here: https://launchpad.net/ubuntu/+source/tomboy [14:36] alecu: interesting, so we need a SRU [14:36] ralsina, so, it's a packaging issue, and I'll need some help of the package maintainer. [14:36] alecu: fun! [14:36] ralsina: http://paste.ubuntu.com/587363 [14:37] fagan: your formula is wrong. [14:37] fagan: use the formula you were given [14:37] kenvandine, ping [14:37] * fagan scrolls back to find it [14:37] fagan: while you are at it, read the help for math.exp [14:38] because you really, really, really don't want to use that ;) [14:38] ralsina: oh crap i used it wrong :) [14:38] yeah I know what went wrong there [14:38] fagan: having the problem description handy is useful: http://paste.ubuntu.com/587264/ [14:39] fagan: you are not using math.exp wrong, you are using the wrong thing. [14:39] I had it open but then lost the page [14:39] ah ok [14:39] alecu, pong [14:40] ralsina: thats better [14:40] hi kenvandine! it seems that tomboy is pointing at the edge server of ubuntuone notes syncronization. [14:41] kenvandine, I'm looking here, and it looks like this is happening since maverick: [14:41] ralsina: ok pushed a new version [14:41] https://launchpad.net/ubuntu/+source/tomboy [14:41] ok, do you have a new patch? or should i just s/edge.//g ? [14:41] fagan: check the review I gave you the last time. Did you check each and every one of those things? If you did, I will review. If you didn't, I'll pretend you didn't say anything ;) [14:42] ralsina: I think I got most of it. The ui stuff should be fine now [14:42] kenvandine, right, we just need to change "https://edge.one.ubuntu.com/notes/" to "https://one.ubuntu.com/notes/" [14:42] kenvandine, but I guess we'll need an SRU for the maverick one, right? [14:43] fagan: ok, checking [14:43] yes [14:43] alecu, i can do that [14:43] alecu, can you file a bug? [14:43] kenvandine, sure. I should fill it against the package, right? [14:43] yes [14:43] thx! [14:44] ralsina: oh I didnt do that connect thing yet [14:45] alecu, great, even easier to fix [14:45] fagan: let's go over my last review first [14:45] ralsina: the nested layout is gone [14:46] ralsina: the box has something in it [14:46] The QDoubleSpinBox? [14:46] oh crap [14:46] fixed now [14:47] fagan: That's you, rushing it. Don't. [14:48] ralsina: pushed [14:48] I see the formula is correct now [14:48] ralsina: I wasnt rushing it I just fixed it with a right click [14:48] kenvandine, Bug #745721 [14:48] Launchpad bug 745721 in tomboy (Ubuntu) "Ubuntu One sync points to the edge server (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/745721 [14:48] fagan: yes, you were rushing it because you pushed the previous one without checking the 4 things I told you were wrong. [14:49] beuno, ralsina ^^ [14:49] alecu: ack [14:49] alecu, thanks [14:49] ralsina: yeah I know I should have made a list and knocked them off as I fixed them [14:49] it would have helped [14:50] fagan: object names, use rate_box instead of RateBox [14:50] ralsina: kk fixing [14:50] With that, the UI is ok [14:50] push that then we'll get to the code [14:54] ralsina: done and tested [14:56] Found a bug [14:56] mandel: code looks good to me in your branch, want a windows review? [14:56] fagan: ok, push, I'll wait [14:56] ralsina: yes, if you can [14:56] mandel: sure [14:56] * ralsina is a not-lean reviewing machine [14:57] And wednesdays are my no-conference-call day (almost) [14:57] ralsina: would be running tests, all should pass, then set the python path to use the branched code, and run the script, a nice twisted service should ran :) [14:57] oh, ugly ugly gio [14:58] gio.File.trash [14:58] Returns : [14:58] True on successful trash, False otherwise. [14:58] "Not all file systems support trashing, so this call can return the gio.IO_ERROR_NOT_SUPPORTED error. " [14:58] gio was the name of ugly betty's sandwich-making boyfriend. He was not the ugly one. [14:58] and gio.ERROR_NOT_SUPPORTED bools to True :( [14:58] hahaha [14:58] that is a classic WTF [14:58] facundobatista: that SUCKS [14:58] ralsina, indeed [14:59] furthermore, who designs a library to return a code error in Python? :( it's easy to do wraps around C this way [15:00] well, gobject introspection creates libraries that feel like C with python syntax, mostly [15:01] So, you have to check if r and r != gio.IO_ERR... on each call? blech [15:01] ralsina, fuck introspection if you'll force me to do that ^ [15:02] facundobatista: agreed [15:03] And I am not the one forcing you, I am an innocent bystander ;) [15:03] ralsina, yes, I know :) [15:03] ralsina: done [15:04] and pushed [15:05] ralsina: when your reviewing could you check out the 2 pylint errors [15:05] fagan: sure [15:05] ralsina: its some naming thing that I cant really tell what it means [15:05] fagan: pep8 violation on line 31 [15:06] fagan: those are very easy to miss, but code can't land until it passes, so you need to check before every push [15:06] just make it a habit [15:06] ralsina: 35, 26 I got the one on 31 fixed [15:07] 35 and 36 I mean [15:07] app, window arent good names apparently :) [15:07] fagan: well it was ther eon rev 25, is not on rev 26, so it's fixed [15:07] fagan: well, pylint is a bit nitpicky, those are perfectly reasonable names. [15:08] You can disable those warnings for specific variables, so let's ignore them [15:08] ralsina: cool [15:08] 9.17/10 is a lot better than -200 anyway [15:09] haha [15:10] ralsina: I think it would be a nice exercise for fagan to disable does messages with inline comments since we have to do that very often [15:10] mandel: yes, indeed [15:11] fagan: the code is not bad, I just really really hate line 31 [15:11] It's better most of the time, to use string formatting instead of concatenations [15:11] ralsina: should be fixed and I did it a lot more if you look at the revisions [15:12] So, something like "$%02d"%ans [15:12] Which is a mouthful, but shows money correctly formatted :-) [15:12] * ralsina hopes he remembers his printf strings correctly [15:13] ralsina: I thought that runs extra slow on other versions of python [15:13] fagan: string concatenation is slow on all versions of python because strings are immutable [15:13] And this produces better formatting, that in this case is more important than speed [15:14] ralsina: cool [15:14] Now, read the stuff about new style connects, and try to apply it, and check the pylint manual to see ifyou can disable the warnings about app and window :-) [15:14] But it's much much better than what you had this morning! [15:15] fagan, you should worry when you are concatenating thousands of strings, but not just a few. [15:15] ralsina: yeah [15:16] anyway that way of string formatting is the same as printf ish so its easier I just did it the way it said in the python docs to do it [15:16] alecu fagan [15:16] alecu fagan: yes, in this case it was mostly to show it with two decimals ;-) [15:16] hehe [15:19] ralsina: its giving me a wrong type error when I try what you gave [15:19] :/ [15:21] ahhhh a cast fixes it [15:22] fagan: no, it'sthat the format string I gave you is crap ;-) [15:22] ralsina: haha [15:22] * fagan went and tried to use it [15:23] yeah it didnt actually fix it either anyway it just printed the entire lot [15:23] "$%.2f" [15:24] you don't need to cast it because ans is already a float and that's what we need. [15:24] ralsina: well python is thinking its a tuple [15:24] nope [15:24] hmmm I must be doing it wrong then [15:24] not in the revision I have at least ;-) [15:25] fagan: push it and let me see [15:25] ralsina: id prefer if you pastebined what you did :P [15:26] fagan: sure, but I know I have it working ;) [15:26] fagan: ok, I'll pastebin it [15:26] yay [15:27] http://pastebin.ubuntu.com/587378/ [15:27] ah I stuck in a , [15:27] cool [15:28] i was copying it from sight since im not developing on this computer [15:29] O_o [15:29] there is 1 thing I should fix [15:29] fagan: what are you doing with two machines? [15:29] the year box is getting focus [15:29] fix it, then do what I mentioned earlier (new style connects, pylint) and ping me when done. [15:30] mandel: unity's dual monitor support is broken [15:30] and id prefer not to irssi in the background [15:30] ralsina: cool [15:31] ah... [15:32] mandel +1 on the branch [15:32] ralsina: superb :D [15:33] argh, I forgot to take the kid's lunchbox to school! [15:33] ralsina: this is not the first time, is it? [15:33] 2nd [15:33] ralsina: hehe [15:33] ralsina: can you take a look at https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_1/+merge/54833 [15:34] it's because wednesdays he has swimming lessons at school, so he has to take two bags, and I am asleep when we go :-( [15:34] mainly the setup.py stuff, the ui in that branch is kinda bad and outdated [15:34] mandel: sure! [15:34] ralsina: well, he can ask one of his friends and have big tea [15:34] ok, just the setup.py stuff, looking at I am [15:34] cool, thx [15:35] mandel: there's a school cafeteria, but you have to tell them earlier so they have the food available [15:36] ralsina: hm, I dont know in argetina, but does places in spain tend to suck.. I've been feed terrible food in my school [15:36] every time I see a module import cgi just for cgi.escape I die a little in the inside [15:36] mandel: well, this one is ok, just plain food [15:37] as in, not hotdogs, but pasta with bolognese sauce and fruit. Nothing fancy, but nutritious. [15:37] ralsina: you can propose a fix :) [15:37] mandel: nah, the fix is importing something larger and worse [15:37] ralsina: h, well, in mine was vegs and this like that.. and bloody fish every friday, stupid nuns! [15:38] well, vegs and fish aregood for you ;-) In this school fridays is trash food day, so pizza [15:40] mandel: looks ok to me, and this doesn't affect the linux side, right? [15:41] ralsina: well, it does, the setup.py is shared, and there are no tests for it [15:41] so, I need a linux review :) [15:41] * mandel forgot to mention that [15:41] * mandel hid [15:41] ohhhhhh then get one of those from a linux guy ;) [15:42] ralsina: im getting native Qt signal not callable [15:42] :/ [15:42] ralsina: well, you said you were free [15:42] fagan, poaste here the line where you get that error [15:43] mandel: yes, but I am on windows :-) [15:43] mandel: for a couple more hours at least [15:43] oh, bullocks, let me find you a second one [15:44] ralsina: paste.ubuntu.com/587386 [15:44] whoops forgot to linkify it [15:44] http://paste.ubuntu.com/587386 [15:44] fagan: version of PyQt? [15:44] hola mundo! === ralsina is now known as mundo [15:45] hola nessita! === mundo is now known as ralsina [15:45] ralsina: 4.8.3-2 [15:45] fagan push it and let me look [15:46] hehe [15:46] nessita: can you check mandel's branch mentioned above? We don't want to break the untested setup.py AGAIN ;-) [15:47] ralsina: pushed [15:48] ralsina: yes! [15:48] mandel: link please! [15:48] * fagan needs to resend his payroll thing again :/ [15:48] fagan: will look at it in 1' [15:48] ralsina: take your time I need to do something for 5 mins anyway [15:48] nessita: https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_1/+merge/54833 [15:49] nessita: sure this is the one that touches setup.py https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_1/+merge/54833 [15:49] dammed! [15:49] too slow [15:49] nessita: also, this is the one I asked you to do yesterday and had conflicts: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_windows_startup_script/+merge/54888 [15:49] is fixed now [15:50] mandel: on it! [15:50] * nessita opens tons of links [15:52] alecu, i uploaded the tomboy fix for natty [15:52] great, thanks! [15:52] alecu, can you add a comment to the bug explaining how an existing user can test? [15:52] for the SRU [15:53] i assume clear existing sync settings and register again? [15:53] or do you just need to perform a sync? [15:54] kenvandine, don't know, I'll try it when the new package is ready and will update the bug. [15:54] ralsina: question, what do you prefer, a huge branch 2000+ with nice code, or a smaller diff with a branch that adds some crapy code? [15:54] alecu, ok, let me know [15:54] then i'll upload it for maverick [15:54] mandel: the 2000+ is all XML? [15:54] alecu, it might be tomorrow or friday before it lands in natty [15:54] ralsina: most of it yes [15:54] basically some time after the beta iso is final [15:55] then the large one [15:55] ralsina: ok [15:55] one sec [15:55] alecu, you can test it locally pretty easily [15:55] ralsina: ok payroll done ping me when you are looking at it [15:55] * ralsina would rather have a pony, but what the heck [15:55] alecu, apt-get build-dep tomboy; bzr branch lp:~ubuntu-desktop/tomboy/ubuntu tomboy-ubuntu; cd tomboy-ubuntu; bzr bd [15:56] ralsina: well, the code is quite clean, should be easy to understand :P [15:56] kenvandine, great, I'll try that. [15:56] mandel: it's ok, really, no problem. I'll assume the XML is ok and you have looked at it ;) [15:57] fagan: works here! [15:57] ralsina: your joking me [15:57] fagan: nope [15:57] ralsina: there you go, is a big as branch: https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_3/+merge/55561 [15:57] :/ [15:57] alecu, thx... ping me when you comment on the bug [15:57] so i can get it uploaded [15:57] fagan: give me 10' then we'll see what happened [15:58] * ralsina looks at branch... ok, fagan, make that 20' [15:58] ralsina: oh its working now [15:58] ralsina: the idea, is that the logic of the views is in the controllers module to allow the reuse of the ui on kde so that in the near buture controllers becomes a package that has a windows.py and a linux.py [15:58] I hope I make sense [15:58] fagan: well, it's better than the alternatives. [15:58] I suppose I needed to refresh the ui file [15:58] kenvandine, in the above cmdline, "bzr bd" needs some bzr extension? [15:59] mandel: gotcha [15:59] I still have the pylint thing to do so its cool [15:59] alecu, oh, yeah [15:59] sorry [15:59] bzr-builddeb ? [15:59] alecu, bzr-builddeb [15:59] yes [15:59] great, thanks [15:59] * kenvandine just assumes everyone has that :) [15:59] * alecu lacks any package building skill :-( [16:00] * alecu hopes to start changing that soon [16:00] :) [16:01] ralsina: mainly, the gui.py contains the views which just provide an interface for the controllers to use, so gui.py is a fairly boring module with some properties becaus eI did not want to do view.ui.email_edit etc.. [16:02] ralsina: done now [16:02] I think thats all of what you were asking [16:02] I did the pylint thing too [16:02] ralsina: although in spanish terms I might have had what is called 'una paja mental' [16:02] fagan: ok, will get to it in a bit. If all that's done, start reading chapter 4 of your book and slapping your forehead ;-) [16:03] * mandel evil laugh [16:04] mandel: ping [16:05] nessita: pong [16:05] SSOLoginClient.register_user should receive a param named displayname instead of name, right? to match the signature of the linux module [16:05] mandel: ^ [16:06] nessita: is there a diff? I mean, I can change that of course, but in windows the names of the params do not matter [16:06] but if you prefer, I change it in a blast!!! [16:06] mandel: I think is best to maintain consistency [16:07] mandel: in the add_windows_startup_script [16:07] mandel: yes, so we can have one set of docs (yeah right) [16:07] mandel: speaking of which, that branch has a lot more changes than the title [16:08] mandel: is that intentional or a prerequisite is missing? [16:08] nessita: the title of the branch? as in 'add_windows_startup_script' [16:08] is a result of running the tests and getting an error from the missing param [16:08] but all of the rest is for the startup script [16:09] mandel: it is? ok then [16:09] mandel: another issue: you sure this will not break for unicode-decode potential errors? self.pipe_name = NAMED_PIPE_URL % username [16:09] mandel: is NAMED_PIPE an unicode? is username an unicode? [16:10] nessita: let me a min to think abut the answer [16:10] mandel: since NAMED_PIPE is a constant, we should be robust regarding username [16:10] sure [16:10] * mandel goes back to his notes [16:13] nessita: according to my notes, the username wont be a problem because we call it using NameSamCompatible (http://msdn.microsoft.com/en-us/library/ms724268(v=vs.85).aspx) so the username should not have funny chars [16:13] off to get some lunch, bbiab [16:14] nessita: but to be 100% sure we could use NameUniqueId which returns the UUID that represents the account [16:15] mandel: that would be better if the functionality is good for you [16:17] nessita: I dont see any issue, specially since whenever we expose the API to the windows developers this detail will be hidden [16:17] Ok, I'm off to lunch. See you all in a while. [16:18] ralsina: kk ill probably be off when you are back so you can get back to me tomorrow [16:18] ok, will try to be early again [16:18] ralsina: its cool take your time mandel can give me another thingy to do [16:19] fagan: we did some real progress today, if we keep it up, we'll be doing real stuff next week [16:19] ralsina: cool [16:19] just in time for the sprint :) [16:19] nessita: can you write all this in your review? I'd like to have a record of this [16:19] mandel: yes [16:19] thx [16:20] mandel: if you need a windows review ping me im still clocked in for 40 mins [16:20] ill just be reading my notes [16:20] mandel: having the contractor for the month of may is useful? I am feeling it's too late :-( [16:21] fagan: dont worries, I prefer you to read your notes and get your head around what you did today [16:21] mandel: I think I have a good grasp of it which is good :) [16:21] ralsina: I've got the same feeling… 'til he is up to speed we will be loosing some precious time :( [16:22] ralsina: lets talk about it in a less public channel ;) [16:22] I'll check if he can be two weeks earlier [16:36] mandel: another question, may be windows specific [16:36] as many as you want [16:36] mandel: this code is not correct: logger.error('Error connecting to pipe: %s => '). 2 things to fix: use logger.exception instead so the traceback is logged, and the %s needs to match something [16:37] mandel: unles logger is a window specific thing? [16:37] nessita: nah, that looks like I fucked it up, let me check to confirm it [16:37] but looks to me that is my fault [16:38] mandel: heh, ok, in any case, replace with: logger.exception('Error connecting to pipe:') and the traceback will be logged automatically [16:41] nessita: let me know when you are done with the review and I'll fix the issues asap [16:41] almost done [16:44] mandel: done, all comments added to the merge proposal [16:44] nessita: superb, I'll do it right now [16:45] :) [16:53] mandel: regarding ui_1, why you added a bunch of files to bzrignore? [16:53] mandel: all of them inside ubuntu_sso/qt [16:54] nessita: the setup.py will compile the .ui files generated from QtDesigner into python modules, I dont want that generated code to be in the tree [16:54] it does not make sense to keep then under versioning since they depend on the .ui which already arr [16:54] mandel: ok, so is not every single file in ubuntu_sso/qt? [16:54] nessita: no, it is all of the *_ui.py files [16:55] ralsina, mandel: we need to talk about this branch. It adds a lot of code to a source project that is under feature and UI freeze. We should not be landing these branches in trunk until natty is released [16:55] ralsina, mandel: I think that we need to create a windows-port branch and land eveything there, and after natty, merge that against trunk [16:56] I'm talking about another development branch within launchpad [16:56] nessita: then we would have to merge there all the bugfixes too [16:57] ralsina: yes we would, thought there is no plan to add any (as per today) [16:57] ralsina: but we can land this in trunk where we may need to add a bug fix and release to natty [16:58] actually, we shouldn't have landing all those branches last week :-/ [16:58] I guess we can do the other way around: [16:58] oh, the beauty of multiplatform :P [16:58] I can tag a release until revno 684 where I did the last release [16:58] that is already on natty [16:59] nessita, ralsina: I'm ok with whatever you decide, just let me know what is the best option for everyone [16:59] mandel: right, I'm not completely sure, I will ask launchpad gurus [17:00] I'll let you all know [17:00] nessita: cool, thx [17:00] nessita: cool [17:12] ralsina, mandel: there, I created a https://launchpad.net/ubuntu-sso-client/stable-1-2 series. I would have to do another push + release to bump the verison there to 1.2, and we later will bump the version in trunk to 1.3 [17:12] makes sense? [17:13] nessita: so, 1.2 is the natty released version, and we work on trunk, right? [17:13] mandel: yes, that makes sense [17:14] nessita: wont that add you extra work by having to backport bug fixes that happen in trunk? [17:14] mandel: yes, but there shouldn't be many (even none) [17:15] nessita: cocky :P [17:15] nessita: I'm ok with that, if there is any extra work, ping me and I will always make time for it :) [17:15] mandel: otherwsie it would be more complicated for you, and you already have enough complications [17:16] and really, we're not expecting bug fixes for ussoc (except for new ones) [17:16] nessita: I'm happy with it, let em know if you ever need a review for that [17:16] mandel: for what? all is done [17:16] nessita: for whenever you need to do a back port [17:17] mandel: ah, yes, I will. Thanks! [17:17] nessita: english needs more determinants, line in spanish [17:25] mandel: ui_1 reviewed with needs fixings [17:26] nessita: cool, I have check if we could use the user Id but it seems that the use would need to do an extra step to link an security id with his username, which does not seem to be a reasonable thing to ask for [17:26] mandel: right [17:26] I'm looking at the docs to see if we will have ut8 issues [17:27] ack [17:29] nessita: I dont think it returns unicode because for that to happen I should be using GetUserNameExW as defined here http://msdn.microsoft.com/en-us/library/ms724435(v=vs.85).aspx (bottom of the docs) [17:29] COM api is sooo crap [17:30] * nessita looks with fear [17:30] mandel: and which one are you using now? [17:31] nessita: GetUserNameEx [17:31] it does not have the W at the end… === beuno is now known as beuno-lunch [17:32] hmm [17:34] kenvandine, the url fix seems to work just fine. I've updated bug #745721 with instructions to test. [17:34] Launchpad bug 745721 in tomboy (Ubuntu Natty) (and 2 other projects) "Ubuntu One sync points to the edge server (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/745721 [17:34] alecu, thx! [17:34] thank you :-) [17:35] Is the actual edge server still up? [17:35] * fagan is interested [17:35] I know they stopped that whole business but is there actually still a server taking requests [17:36] ralsina, beuno-lunch: the fix for tomboy means that the users affected will need to clean up the sync config from the tomboy preferences and set it again. [17:43] mandel: ok, honestly, I don't think I understand that page doc :-/ [17:44] mandel: in the worst case we'll have a bug report about a UnicodeDecodeError [17:44] (or not!) [17:44] mandel: so, go for it [17:45] nessita: msdn doc of this com crap is not clear at all to be honest [17:45] amen [17:45] mandel: anything else? I would have lunch otherwise [17:45] ok, I've pushed it with the other changes [17:45] nessita: nope, I need to walk the dog, I'll probably will be back later [17:46] mandel: you pushed changes for both branches? [17:46] nessita: no, just the one related to the startup script, I'll look at the second one once I'm back [17:46] but it might be too late for you, so we can pospone that 'til tom [17:47] mandel: too late for me? not at all [17:47] still 5 hours at least of work [17:48] nessita: looks like in the second one there was a merge issue, otherwhise I dont understand all those duplicated things... [17:48] I'll fix it asap [17:52] ack [17:52] * nessita -> lunch === beuno-lunch is now known as beuno [18:48] mandel: look! 2 branches for ussoc (trunk and stable-1-2 version, I'm just fixing this to bump the version later and release) [18:48] mandel: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/clean-captcha-error-1-2/+merge/55605 [18:48] mandel: https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/clean-captcha-error-trunk/+merge/55606 [18:51] alecu: nessita: https://code.launchpad.net/~thisfred/ubuntuone-control-panel/gui-service/+merge/55607 [18:51] thisfred: on it [18:51] cleaned up quite a bit from what you saw yesterday [18:52] thisfred: care to review (trivial) https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/clean-captcha-error-1-2/+merge/55605 and the trunk version of that, https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/clean-captcha-error-1-2/+merge/55605 ? [18:52] nessita: sure thing [18:52] thanks! [18:53] thisfred: the link for the trunk version is not correct, is https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/clean-captcha-error-trunk/+merge/55606 [18:58] nessita: stable-1-2? did you already branch that off trunk? [18:58] dobey: yes [18:58] from trunk revno 684. before all the latest windows mandness landed [19:00] these things need to be announced. did you change the version in trunk also? [19:00] nessita: ok, I'm on them [19:00] mandel: thanks! [19:01] dobey: announced where? and no, I'm about to [19:02] nessita: well i need to know about it. because i have to update tarmac config and nightlies, to deal with it [19:02] dobey: you're right, sorry for that. I completely forgot. [19:03] dobey: nightlies should need no change, right? [19:03] dobey: I checked that nightlies were building against trunk, and I thought that was correct [19:03] nessita: well the trunk version should be bumped, and nightlies should be bumped for that [19:03] ah, I see [19:04] dobey: well, as soon as I bump the version on trunk I'll let you know [19:04] ok [19:04] mandel: register_user does not have displayname as param, it still shows name [19:05] nessita: really? which line of the diff? [19:05] mandel: 159 and 166 [19:05] mandel: though I just notice those are method calls [19:06] mandel: but it helps to the reader to use the same name as the param names. Could you please change that? [19:06] sure, why not, takes 2 seconds [19:08] ralsina: so, complicated question. Do we have hotel in buenos aires? [19:11] nessita: changes have been pushed [19:12] mandel: yey! [19:14] nessita: marianna promised email, and didn't send it. But she told me you do have a hotel. [19:15] ralsina: ok :-D [19:23] ugh [19:23] i have no idea how to deal with this error condition appropriately [19:23] i guess just signal error and require the user to hit cancel for now :-/ [19:27] * mandel switching wifi bbiab [19:28] @ping [19:28] pong [19:29] pang! [19:30] mandel: approved [19:32] thisfred: can you please add IRL testing instructions to your branch? [19:32] nessita: ah yes will do [19:34] nessita: your branches are approved [19:34] nessita: I found the issue with the ui_1, there is a criss-cross situation, I'm fixing it atm [19:36] mandel: thanks [19:37] nessita: testing instructions added [19:38] Guys, I will probably be quiet because I have to read a bunch of stuff about planning and such, and it's not exactly fun, so I tend to drop it if I don't focus :-( [19:38] but ping me if you really need something [19:39] * mandel is planning a dos attack towards ralsina [19:40] thisfred: thanks! [19:41] mandel: we should reinstall his laptop with dos [19:42] s long as it is not the ms version, he should be fine [19:42] dobey: FreeDOS has a graphical browser arachne, if you can get the network packet drive working. ;) [19:42] * ralsina got a brand new DR-DOS 7.0 from novell once. [19:43] oh banshee, if it ain't one thing, it's another [19:45] thisfred: great work, approved! [19:45] dobey: new problems? [19:45] dobey: as per what you said, can I assume you were setuping/are going to setup tarmac for stable-1-2? [19:46] thx! [19:46] nessita: i will yes [19:47] ralsina: (Banshee:5755): Gtk-CRITICAL **: IA__gtk_widget_event: assertion `WIDGET_REALIZED_FOR_EVENT (widget, event)' failed [19:47] ralsina: but i don't know where it's coming from exactly, and doing G_DEBUG=fatal_criticals doesn't seem to work :-/ [19:47] dobey: awesome [19:48] dobey: awesome, would you let me know when is done? [19:48] dobey: I didn't even knew realize() could fail :-( [19:48] or rather, it looks like it's getting events before being realized? [19:49] and yes, it must be a bitch to debug [19:49] ralsina: i don't think it's failing to realize(), i think it's generating an event on an unrealized widget :) [19:49] yes, especially since i can't seem to make it happen at will :( [19:49] oh well [19:50] dobey: even attaching gdb and adding a breakpoint in the critical? At least you should get a semi-useful trace? [19:50] in the assert I mean [19:53] ralsina: gdb doesn't like mono so much [19:53] oh, right, well, you'd get a crappy backtrace, yes [19:53] * ralsina forgets banshee is mono [19:54] and since it fails in C, a mono debugger is not all that useful either. [19:57] anyone available for a second review of https://code.launchpad.net/~thisfred/ubuntuone-control-panel/gui-service/+merge/55607 ? [19:59] thisfred: I got it. And yes, that means I am procrastinating on the management stuff. [20:00] I won't tell if you don't ;) [20:04] thisfred: +1 [20:04] rocoso! [20:04] ralsina: i don't know if it's failing in my code or not [20:05] thisfred: that has to be the worst fake-argentinism yet :-) [20:05] ralsina: I know, I'm very proud of it :) [20:05] ralsina: though i suspect not, since it's not occurring all the time at the same place [20:05] nessita: the criss-cross of https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_1/+merge/54833 is fixed, give it a try when possible [20:06] ralsina: it seems more X expose event related, and given banshee's custom drawing nonsense, i suspect it may be in there somewhere. but i can't verify yet :-/ [20:06] dobey: well, good luck with that. You have my full moral support! ;) [20:07] dobey: I would love to give you *actual* support, but I would probably be just a hindrance in there [20:10] heh [20:14] nessita: tarmac is configured for stable-1-2 now [20:18] dobey: thanks [20:18] mandel: sure! === franxesk is now known as franxesk_afk [20:25] mandel: ui_1 has 2 typos with """Cleint that can perform calls to the remote SSOCredentials object.""" [20:26] mandel: man, I keep telling you this! :-) [20:26] nessita: ok, sorry I did not check that... [20:26] the criss-cross was a pain :( [20:26] on it [20:28] nessita: done, sorry for that, stupid Cleint :P [20:29] ack [20:30] dobey: any idea why manuel and eric are community here https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/clean-captcha-error-1-2/+merge/55605 ? [20:30] dobey: ah, I know, I have to set the reviewer to be hackers [20:31] And there I was thinking I was finally part of a community [20:31] thisfred: you are! [20:31] Admittedly one that would admit mandel... [20:32] thisfred: you are part of the freedom hating community [20:32] :) [20:32] thisfred: hum I just found out an issue with your (landed) branch [20:32] thisfred: I'll open a bug [20:32] ut oh [20:33] thisfred: bug #745987 [20:33] plz assign it to me, and I'll fix asap. If I know how :) [20:33] Launchpad bug 745987 in ubuntuone-control-panel "RuntimeError: called outside of a mainloop (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/745987 [20:34] thisfred: and the gtk.main loop is not terminated [20:34] so that is a problem [20:34] ah [20:35] thisfred: run_mainloop should use the gtk main loop, not the gobject [20:35] thisfred: and that exact loop should be quit when closing the window [20:36] nessita: ah ok. nessita how can I trigger this error? [20:38] thisfred: run your branch in a terminal and close the UI, I'm getting that in the console [20:38] weird, I never got any errors in the terminal [20:39] perhaps because I close the window differently [20:39] maybe... I'm doing alt+f4 with a regular window manager :-P [20:40] thisfred: yeap, every time [20:40] mandel: approved [20:41] nessita: so that's gtk.main() right? [20:41] thisfred: what is not being called is gtk.main_quit [20:41] thisfred: the loop you should be running is gtk.main() [20:41] right [20:44] nessita: superb, thx! [20:48] nessita: found and fixed, now fixing tests [20:53] thisfred: pushed in your branch? isn't that merged? [20:53] yeah [20:53] nessita: https://code.launchpad.net/~thisfred/ubuntuone-control-panel/lp-745987/+merge/55618 [20:53] ah, ok [20:53] yeah, new merge propose [20:54] d [20:54] perfect [20:54] * thisfred is learning to tell his mainloop from his elbow [20:57] alecu: ping [20:58] nessita, pong [20:58] alecu: how did it go fixing client tests in server code? [20:59] nessita, it's coming thru. I hope to have it finished by tonight. [20:59] great [20:59] thanks! [21:00] thisfred: approving! [21:00] thx! [21:02] EOD for me! [21:02] ok, 5' in case anyone needs something, but it's really EOD ;-) [21:12] ralsina: eh quick review? :D [21:12] https://code.launchpad.net/~thisfred/ubuntuone-control-panel/lp-745987/+merge/55618 very small [21:12] cures the common cold [21:12] doh, the nasa open source summit is in cali [21:12] in 5 exciting colors [21:14] thisfred: ooooook [21:22] thisfred +1 [21:22] thanks! [21:23] thisfred: but I'm so tired you may be passing the review just based on previous good behaviour and a good reference from nessita ;-) [21:24] works for me, until nessita finds the next bug ;) [21:24] :-) [21:24] works for me too [21:24] * ralsina just ran out of 1s [21:25] so bye bye! ;-) [21:25] bye ralsina! [21:46] dobey, nessita: when I have quota popups working, can I just remove the whole gsd-plugin directory in ubuntuone-client (and everything that references it in the make file etc.) or is it needed for something else? [21:46] no [21:46] it also adds the bookmark for the Ubuntu One folder [21:47] oh ok [21:50] alright, am off for now. later [21:50] later rodney [22:06] ok, got a lot finished today, so I'm also gonna call it an EOD [22:26] thisfred: you gone? [22:26] nope [22:27] thisfred: weas there any news regarding the DC failure with file_exists? [22:27] thisfred: I keep seeing more and more reports coming in [22:28] nessita: chad was gonna look at it, but I didn't hear back from him, probably he got sucked back into web and mobile work [22:29] thisfred: would you please ping him and/or do the follow up in that bug? is worrying me see so many reports [22:29] nessita: if all else fails, I will definitely tackle this at the sprint [22:29] thisfred: right. In the mean time, would you please answer the bug/s to show we're keeping track on that and we're planning to solve it? [22:29] nessita: these reports are all from natty users though, right [22:31] nessita: I can set the target to beta2 I guess. Other than that, I have no idea what to say, since I don't understand the code [22:31] ok, then let's try that chad adds something to the report, so we 3 understand :-D [22:31] I'd like to rip it all out, but I fear that may be too much for natty [22:31] nessita: yeah will ping him tomorrow [22:31] thanks! === m_conley is now known as m_conley_away [22:53] ok, I'm off [22:53] bye all! [23:01] hi [23:01] i teach in gymnasium and i have 18 computers i try use oneconf but it don't work in ubuntu 10.10 if this work just in 11.04? [23:03] wolfik: this isnt really a peak time to ask questions [23:03] didrocks is the one handling oneconf if I remember correctly and he isnt online [23:04] wolfik: try again during more european hours and you can catch someone who can help [23:04] :) [23:06] hmmm i have 12:00 pm :) [23:07] wolfik: try between 9 [23:07] 9am and 8pm [23:07] GMT+0 and you would have more luck [23:09] ok thx :) [23:22] rodrigo_, ping? [23:24] jono: I dont think he is around is it something I can help with while im here [23:24] fagan, do you know if the contact syncing bug in Evo has been fixed yet? [23:25] jono: in maverick or natty? [23:25] fagan, natty [23:25] I can test it and see give me a minute [23:26] jono: not working on mine so id presume its still broken but id bet its going to get fixed soonish [23:27] oh crap I forgot the machine im on is borked ill try on my other one [23:27] whoops [23:29] jono: nope broken on my other computer too [23:39] fagan, ok, I am sending a mail to ralsina [23:39] cheers [23:39] jono: cool [23:50] jono: it does sound like an important bug to get fixed [23:50] and it is getting late [23:51] Im doing the windows client so its not really my area so I dont know what the status of it is [23:51] fagan, np