=== gmb` is now known as gmb [13:22] bac benji danilos gmb, aloha. slight change to morning meeting call: please have kanban board up-to-date 5 min before call (3 min from now). I will review before call, and just ask questions about things I wonder about. Then I'll circle through everyone once and ask if they have anthing to add, then we're done. [13:22] ok [13:22] gmb, hey, how goes the db war? [13:23] oh, also, I'm going to use Skype [13:23] barring any objections [13:23] none from me [13:23] gary_poster: It turned out to be a one-line fix. I had to tell Person.merge() to ignore BugSubscriptionFilterMutes when merging. That wasn't obvious from the failures though. I went from having 30-odd test failures to 0 [13:23] cool === bac` is now known as bac [13:23] Skype works for me. [13:23] heh [13:23] ok cool [13:24] gmb, did you happen to merge db-devel or something similar (given the upcoming deploy, maybe devel already has db-devel stuff)? [13:25] * gary_poster can't qa the bits I need to 'cause qastaging is down. :-/ [13:25] gary_poster: No. I fixed the failures and pushed and ran. When's the DB deploy? Wednesday AM? [13:26] gmb, yeah, I think so. I saw that devel is in RC until qa is finished [13:26] my interest is in making an MP though [13:26] Ah. [13:26] gary_poster: I can merge db-devel and push now for you. [13:26] I have necessary changes both from your branch and from trunk-ish [13:26] awesome thank you [13:27] * gary_poster starting to stare an kanban board... [13:28] yay, my stuff is qa'd by wgrant! [13:30] danilos, benji, skype plz? [13:30] gary_poster, ack [13:30] thanks [13:30] gary_poster: lp:~gmb/launchpad/team-subscription-opt-out and lp:~gmb/launchpad/team-subscription-opt-out-apis now contain db-devel. [13:31] yay, thank you gmb [13:31] gary_poster: there now [13:31] AAAAH. [13:32] gary_poster: Please try again. [13:32] gary_poster, I am here [13:40] benji: skype? [13:40] bac: sure [13:41] benji: what is your skype id? [13:41] bac: um... let me see [13:41] bac: benji_york [13:41] benji_york [13:55] bac, benji, gary_poster, gmb: fwiw, my refactoring branch does change the structural_subscriptions.js quite a bit, at least for the setup code [13:55] danilos: ok. shouldn't affect my work [13:55] danilos, yeah I was afraid of that. :-) I have a branch thst changes JS [13:55] I'll figure out what to do about it in a few minutes [13:57] gary_poster, I did a lot of sanity refactoring and got rid of that context-passing-around hack that we had as well in the process [13:57] danilos, cool [13:57] gary_poster, I am hoping nobody gets affected too much though [13:57] :-) I'll see. it was good stuff to do anyway. [13:59] gary_poster: I just submitted AWS expenses for March. Can you sign them off when you get a chance? [13:59] will do gmb, thanks for heads up [14:00] np [14:00] Thanks [14:04] feature flag enabled for ~yellow on staging [14:06] gmb, approved expenses. https://code.launchpad.net/~gary/launchpad/muteteamsub-email/+merge/56154 is now ready when you are. [14:06] Ooo, a trade of web forms. [14:06] On it. [14:06] :-) thanks [14:07] gary_poster, oh, I've filed the amazon ec2 expense as well (just now so hoping it doesn't transfer into next month :) [14:07] :-) k looking [14:09] approved danilos. I'm thinking about what I should do to handle your changes. Maybe I should merge your refactor branch now? Or would you suggest I wait until later for some reason? [14:10] gary_poster, I'd be very happy if you branch now, I don't expect big changes there (and if I do, I'd do it as a separate branch) [14:10] gary_poster, what particular bits are you changing? [14:11] gary_poster, it's for muting/unmuting links on the subscriptions list? [14:11] right [14:11] I doubt that will be affected much but [14:11] I wonder if the tests might be [14:11] (which I started, and then stopped because I wondered if I might be stomping on you) [14:12] gary_poster, I didn't change any tests so far (they all pass, though), and I fully expect to have to pretty soon now since I did split it all up into smaller functions [14:13] gary_poster, iow, I only expect to be introducing new tests, and my changes are only from make_edit_handler and "below" [14:13] danilos. ack. One exciting bit is that there are no tests for the edit form rendering, as you probably know [14:13] right, cool [14:13] gary_poster, yeah, and I think my refactor should help with some of that when we get to it [14:14] ok, but since your changes are make_edit_handler and below... [14:14] then you won't be writing tests for edit stuff now? [14:14] So I can? [14:14] (without fear of duplicating work) [14:15] gary_poster, well, "only below" is probably not completely correct, but I am not doing any tests yet, no [14:15] ok [14:15] gary_poster, if you are planning to do tests, however, I strongly suggest you merge my branch first [14:15] then I'll start working on thos in just a few. I have other stuff I should get to first [14:15] ack [14:16] ok, danilos, will do. [14:40] gary_poster: Your branch is r=me. [14:41] cool, thanks gmb. I have something else for your attention in just 1 sec... [14:41] ok [14:47] gmb, please take a glance at https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/FeatureReviewNotes [14:47] You might be able to fill in a couple fo XXXs (or remove them as appropriate) [14:49] Ok, will do. [15:12] gary_poster: I've removed a couple of XXXs and left the rest (that I didn't know much about) alone. [15:13] gary_poster: Should I take a look at the Bug 1 muting timeout problem? [15:13] <_mup_> Bug #1: Microsoft has a majority market share

gmb, ...sure. [15:16] and thank you [15:16] np [15:19] danilos, just merged. 18 conflicts. ;-) will work on resolving in a few. [15:19] (18 all within the one js file) [15:19] most are very small [15:19] but some not so much :-P [15:20] danilos, nice yellow sub btw :-) [15:21] ...not clear on what triggered mup to get excited there... [15:23] gary_poster: Bug 1 was mentioned earlier. I wonder if the general heft of Bug 1 makes mup take a long time to do its thing. [15:23] <_mup_> Bug #1: Microsoft has a majority market share

Bug #1: Microsoft has a majority market share

I guess I can DOS mup by mentioning Bug 1 a lot. [15:23] <_mup_> Bug #1: Microsoft has a majority market share

ah true [15:24] heh [15:26] gary_poster, not sure what you mean with "yellow sub"? [15:30] danilos, I though you might be source of icon change in https://launchpad.net/~yellow ? [15:31] So, I should let jml and diogo get the new flag [15:31] I could add them to ~yellow [15:32] But I'm inclined to ask jml if he wants a particular team to be added to the flag [15:32] any opinions? [15:37] gary_poster: I'm doing QA for the structual susbscription JS and I noticed that for the "are added or changed in any way" radio button we use "(more options...)" and for "Bugs must match this filter" we use just "(...)". Is that intentional? [15:39] benji, yeah. I thought at that point it would be clear, and didn't want the clutter. [15:39] k [15:39] don't feel strongly about it, but OTOH would not be keen on a change unless we got people actually being confused or compaining about it [15:47] in case this affects anyone, here's a rough outline of my plans right now. I'm going to address the JS conflicts, since danilos is still around, in case I need to confer with him. [15:47] Then, because I kind of need to wait for either danilos' branch or gmb's API branch to land on db-devel for me to get a sane MP diff, I'm going to switch to small things such as my long-outstanding expenses. [15:47] Then I'll get back to the UI branch, and hopefully have an MP waiting for gmb in the morning with tests. [15:47] Finally, maybe worth noting is that I will be out tomorrow for a few hours after our call, and will continue to do that every Tuesday until the baby pops out. [16:11] gary_poster: here are my QA items for structual subscriptions: http://pastebin.ubuntu.com/589310/; how should I handle them? [16:13] benji, this is in regards to landing the client branch, right? [16:13] right [16:15] gary_poster: So, this timeout... as far as I can tell it's a query that takes too long, but there isn't much info available in the OOPS reports: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1914I723. Can you think of any way that I make useful headway here? I'm a bit stumped. [16:15] benji, ok. first, if this is blocking any card from being qa-ok, mark it as qa-ok. We are feature flagged. [16:18] gary_poster: these branches were landed with no-qa; so we're good there, these problems aren't big so I assume the two cards I have in the QA lane should be moved to deployable. [16:18] my main question is what should I do with this list of small things [16:19] benji, yes. List of small things: 1 sec. [16:19] no rush [16:22] gmb, I'd try to figure out where the sql is coming from. I'm guessing you agree. :-) Since you are asking, I'm guessing you are not sure what the source is. I'd try running mute locally with the "show my all the SQL environmental variable. If that gives you enough to figure it out, great. [16:22] If it does not, we might need to do a pdb *with the SQL env variable also*. I'd do it in zope.publisher.publish debug_call myself, since we have no freaking idea. Then you can dig around until you see the SQL being generated, and figure out the source that way. [16:23] gary_poster: Okay, that sounds like as good a way to go as any. Thanks. [16:23] * gmb refuels the tea tank before starting [16:23] :-) [16:24] benji, no activity animation: please look at the card in the design section of the backlog starting with ""Unsubscribe" on IBug:..." and make sure it encompasses your concern. [16:24] dialog hangs around oddly: I'm not clear on that one. [16:24] I don't knw what it means [16:24] Maybe make a new card? Maybe try to describe it for me first here? your call [16:25] tag text box: new card [16:25] status "Unknown": new card + I suggest an associated bug [16:25] overlay start out closer to top of page: new display card [16:25] gary_poster: sorry, I forgot that I started making those notes just for me; the dialog appears to get cought deconstructing (or maybe resetting) itself; I click the "do it" button and the dialog gets smaller but still has most of the form visible then it hangs there for a second and then disappears [16:26] huh [16:26] yeah, a card in "display tweaks" sounds appropriate. [16:26] k [16:26] For all of those, feel free to make a bug as well [16:26] k [16:26] but a card is my top priority [16:27] Thank you benji, those are good catches. [16:28] I'm good at being picky. [16:28] :-) [16:31] gmb, look for "parent_message" in Bug.index_message in lib/lp/bugs/model/bug.py. [16:31] looks like source [16:31] Aha. [16:31] Thanks. [16:32] np [17:08] * gary_poster was trying to figure out js test failures but then saw the MP [17:28] * gary_poster lunches [18:42] benji: what is the URL that the edit link should point to? [18:44] +subscriptions on the bug target bac. I *think* it is on bugs.* [18:45] gary_poster: ok, that's what i figured [18:45] actually it is on all [18:45] or at least https://bugs.launchpad.net/launchpad/+subscriptions and https://launchpad.net/launchpad/+subscriptions [18:47] cool [18:52] bac: sorry, was finishing up lunch... https://bugs.staging.launchpad.net/manuel/+subscriptions [18:52] benji: thanks [18:59] bac: I have a couple little things to do and then I'll be ready for some pillar divvying [19:01] benji: ok === Ursinha is now known as Ursinha-lunch [19:48] Be prepared for shock and awe: I actually filed my expenses! It's amazing. [20:01] bac: heh, cool [20:12] On kanban card, "Administrivia" cards are now "Miscellaneous" cards [21:36] benji: fwiw, the refactoring you suggested last week (create 'add_subscribe_link) made today's work much easier. [21:37] bac: cool [21:37] I guess I'm not entirely full of hot air. ;) [22:10] Reason #61 I like telecommuting: Even a home body like me can look forward to going outside on a nice spring day. === Ursinha-lunch is now known as Ursinha