because they were only hidden [13:21] gary_poster, when I fix a bug like that, how do I add a test that makes sure it never comes back? [13:21] classes don't hep answer that particular question, fwiw [13:21] I mean, we don't test CSS itself, but at least it'd be outside the code, and we'd know the code does what it's supposed to [13:21] help [13:22] gary_poster, imo they do, but I guess that's an argument we can have some other time :) [13:22] we disagree but I'm happy to defer on this :-) What do you think we should do about the bug? [13:23] I'd like us to solve it, but I'd also like us not to introduce mess into CSS; how about we add our own CSS file and establish a practice for that? (bin/combine_css has a simple names=[] variable where we can manually list it for now) [13:24] where "solve" try to use more of the CSS classes instead of setting style directly [13:24] "solve" == [13:24] Coming late to the party here I think that danilos suggestion is a good one. [13:25] gmb, you must be the sound of reason since at this point of the party, all the booze is gone :) [13:25] :) [13:25] s/sound/voice/ (see what partying does to a man? :)) [13:25] heh [13:26] that sounds good to me danilos. Do you mind that not being "high"? I'm happy to have it as a "fix it if you want to" card in the backlog though [13:27] bac benji (who is not here) danilos gmb: please make sure kanban is up to date now-ish [13:27] yup [13:27] gary_poster, yeah, non-high is just fine [13:27] cool [13:27] I'll up it to medium, and make a backlog card [13:30] gary_poster, thanks [13:30] bac, you on Skype? [13:31] oops [13:31] on now [13:34] sorry about that, new, better headset is on order :) [13:35] :-) === Ursinha-afk is now known as Ursinha [14:05] * danilos -> lunch [14:15] * gary_poster to car garage. back soon. [14:18] * benji is back from the dentist. [14:49] * gary_poster back too. [14:57] gary_poster: Any objection to me taking bug 424849? [14:57] <_mup_> Bug #424849: Launchpad should batch attachment notification emails

< https://launchpad.net/bugs/424849 > [14:57] (I think I know how to do it, so it seems the post obvious option) [14:57] gmb, ok, fire away [14:57] *most [14:57] Cool. [15:38] bac, benji, danilos, gmb, I want us to try and do a better job tracking what is released. I'll try to lead this. For now, I've made the following changes to the kanban board. [15:38] 1) I split up Deployment: Ready into three sub-lanes. [15:38] If you land something into db-devel put it into the db-deploy lane. If it is a normal devel landing, put it in no-downtime. [15:38] If you've landed something in db-devel inbetween a db-devel deploy code freeze and a db-devel deployment, like we did with the "mute team subscriptions" stuff recently, you can put it in "Next db-deploy". [15:38] 2) I moved all of our "ready" cards to "done-done" because of today's deploy. Please move cards back to "no-downtime" (or other) if you know they are not actually deployed. [15:38] that's it, thanks. [15:39] gary_poster: Righto. Makes sense; I admit it was a bit unclear how to handle the db-devel versus devel stuff. [15:39] cool [15:40] gary_poster: i'm unhappy with the way i've been working on cards with no bugs and having to use no-qa. i'd like to start filing more bugs for task tracking. you ok with that? [15:41] bac, absolutely. I sometimes make cards when I land, just for the qa. Do whatever works for you. The tension between kanban cards and bugs is not lost on me. :-/ [15:41] a bug seems like a too heavy artifact for a lot of things but without one we lose qa-ness [15:41] But I mostly need the kanban cards [15:41] right [15:41] bac, sorry, I meant "I sometimes make *bugs when I land, just for the qa." [15:43] gary_poster, ack [15:43] thanks [16:14] benji, I want to know how smart the code is that handles IJSONRequestCache(request).objects--in particular, if it reuses the same data structure in the JSON if the same object is used multiple times, via relying on some sort of JS post-processing. I doubt it, but it woud be silly to work around that if it were handled already. [16:14] So you know where I should look? [16:14] Do [16:15] * benji looks. [16:22] gary_poster: since you have to add objects by name, and the cache is a simple dictionary, duplicates aren't eliminated [16:22] (see src/lazr/restful/jsoncache.py) [16:22] got it, thanks benji [16:24] * gmb -> brain stall; increasing tea reserves [16:27] * gary_poster back to garage [17:18] * danilos off [17:33] You know that feeling when you've just spent half an hour on a really, really good test, only to suddenly realise it doesn't exercise the code you want it to? Yeah, that. [17:51] actually, my branch failed with some test failures, resubmitted with fixes, and pushing my merged-with-db-devel to lp:~danilo/launchpad/db-add-subscription-link (includes some devel revisions so I'll ec2 land that one as well) [18:01] gary_poster, actually, I can't land that easily without an MP, Gary, can you please confirm that all mute-related functionality works as expected and then ec2 land it on db-devel if so? [18:02] (I was supposed to be out over an hour ago, and I just wanted to get this finished, so db-devel doesn't hit a conflict that's hard to resolve) [18:02] gary_poster, I also didn't check any tests, I am sure some have broke [18:02] * danilos -> really off [18:08] danilos, ack, will do, thanks [18:22] The JS tests on danilos' branch pass... [18:27] * bac -> lunch [18:27] qa on his branch works... [18:40] WARNING: GIANT, MAN-EATING BIKESHEAD AHEAD [18:40] The subscription listing wording for the mute link seems quite odd: "Do not receive emails from this subscription". [18:41] suggestion: "Stop emails about this bug" [18:41] end-of-bikeshead [18:41] The problem is that your simplification is not true [18:41] We have a concept of muting bugs [18:41] well, emails about a bug [18:42] which is handled elsewhere [18:42] this is for the case in which you are in a team [18:42] which has a subscription to [something[ [18:42] oh, that's not muting [18:42] right [18:42] that's why I didn't call it muting in the interface [18:42] I'm sure coming up with good words for that was (is) hard, but I'm still complaining about them ;) [18:43] complaining is only mildly interesting without a compelling solution. :-) Alternatively, make a card for "ask Huw about wording" for that feature [18:44] last shed-swatch: "Stop emails from this subscription" [18:45] I'll make a card and shepherd it. [18:46] I'd be fine with that wording benji. That said, I'm not clear on it being a win, but that's not any kind of endorsement of or belief in the current wording. User testing is the proof of the pudding. [18:47] Feel free to just make the change. [18:48] gary_poster: ok, the "Stop..." wording assuages [that's a hard word to spell] my inner-shed [18:50] I feel kinda blech [18:50] Karyn is telling me to take a half day sick [18:50] I think I might do that [18:52] guys, I got permission for a sick day [18:52] danilos branch is in ec2 land [18:52] sick half-day I should say [18:52] Hopefully I'll feel better tomorry [18:52] TTYL [21:57] i like how the kanban favicon now looks like it was custom-made for the yellow squad === Ursinha is now known as Ursinha-afk