| === Ursula__ is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Guest38069 | ||
| gary_poster | bac benji danilos please make sue kanban is up to date; call RSN | 13:28 |
|---|---|---|
| bac | rt | 13:28 |
| benji | That'd be a very geeky comic: The Adventures of Sue Kanban | 13:29 |
| bac | wow, new kanbanism -- multiple assignees | 13:29 |
| gary_poster | oh I didn't see that, cool | 13:30 |
| benji | they also fixed several bugs | 13:30 |
| bac | we could have one "book dublin travel" card now, assigned to us all! | 13:30 |
| danilos | bac, not to me, I'd need a separate 'need visa for Eire' card :) | 13:31 |
| gary_poster | bac skype | 13:31 |
| bac | ugh | 13:31 |
| bac | on now | 13:32 |
| danilos | skype crashed, yay | 13:32 |
| danilos | gary_poster, clearProgressUI | 13:41 |
| benji | gary_poster: Robert was able to post some more details to the "I get lp bug mail even though 'on own actions' turned off" bug (739141). Is that another good one for today? | 13:45 |
| gary_poster | benji, oh yeah, I saw that. It still didn't seem like much, and I recall feeling confused when I read it, but yeah, that has potential | 13:45 |
| gary_poster | so, yeah, another good one | 13:45 |
| gary_poster | benji I did have one thought about that | 13:45 |
| benji | k, I'll see if it leads anywhere without going too deep into the thrash forrest | 13:46 |
| gary_poster | the code to send emails seems pretty simple and well tested--that is, if we know the recipient and the "actor" then we simply check if they are the same and don't send the email. It's pretty straightforward. The only place that seems like it could go wrong is if we misidentify the actor in LP itself | 13:47 |
| gary_poster | (outside of the sending code) | 13:47 |
| gary_poster | so I would investigate how those "actor" values are set; I also would check into the bug log and see if you can see any hints there for the particular actions Robert describes | 13:48 |
| gary_poster | another possibility is that bug 753000 is causing this... | 13:48 |
| _mup_ | Bug #753000: NotOneError caused by duplicate stuctural subscriptions <dba> <merge-deactivate> <oops> <story-better-bug-notification> <Launchpad itself:Triaged> < https://launchpad.net/bugs/753000 > | 13:49 |
| gary_poster | that is, our sending code might not handle the case in which two people subscribe at the same time | 13:49 |
| gary_poster | that reminds me, I should see if stub commented on that bug... | 13:49 |
| benji | "at the same time" as in race condition? | 13:49 |
| gary_poster | sorry, no, my mind went somewhere else and my communication went on dream-state autopilot :-P " our sending code might not handle the case in which one person is subscribed twice--we might only remove one of the messages to be sent out: | 13:51 |
| gary_poster | " | 13:51 |
| gary_poster | did that make more sense benji? | 13:51 |
| benji | yep makes sense | 13:55 |
| gary_poster | cool | 13:55 |
| danilos | gary_poster, hi, I am about to leave, but I need another clarification: direct team subscriptions (admin or not) are to be listed at the very top, or as part of the "rest" when there's a direct subscription? | 17:28 |
| gary_poster | danilos, the "rest" unless you argue against me :-) | 17:29 |
| danilos | gary_poster, nope, that's just fine :) | 17:29 |
| gary_poster | :-) cool | 17:29 |
| danilos | gary_poster, thanks, out now, and I'm making decent progress but the branch is already ~1100 lines :( | 17:31 |
| * danilos -> out | 17:32 | |
| gary_poster | bye | 17:35 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| gary_poster | benji, I want to write a unit test that tries to use the webservice to mute something. I'm interested in database activity of the request as a whole. Do you have a recommendation for an approach, or, even better, an example to follow? | 21:38 |
| benji | hmm, nothing off the top of my head, let me look real quick | 21:39 |
| gary_poster | thankee | 21:39 |
| benji | gary_poster: assuming you're fine with using launchpadlib, you can look at lines 32 through 54 of lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt | 21:41 |
| gary_poster | cool, sounds perfect, thanks benji | 21:41 |
| gary_poster | yeah, that's just what I was hoping for | 21:43 |
| benji | cool | 21:49 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!