| === poolie_ is now known as poolie | ||
| fagan | morning everybody | 09:16 |
|---|---|---|
| mandel | ralsina: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_views_tests/+merge/56314 | 09:36 |
| karni | morning! | 09:55 |
| czajkowski | Aloha | 10:21 |
| mandel | ralsina: there you go: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_windows_ui_root/+merge/56320 | 11:49 |
| ralsina | fagan: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_views_tests/+merge/56314 | 11:51 |
| mandel | fagan: may I have a review for this too: https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_4 | 12:14 |
| === rodrigo__ is now known as rodrigo_ | ||
| ralsina | alecu: when you can. take a look at bug #755185 | 12:29 |
| ubot4 | ralsina: Bug 755185 on http://launchpad.net/bugs/755185 is private | 12:29 |
| duanedesign | morning all | 12:35 |
| fagan | morning duanedesign | 12:37 |
| nessita | ralsina: ah, I have started working on that | 12:58 |
| nessita | (hi BTW) | 12:58 |
| nessita | alecu: when you can, please take a look to bug #734671 | 13:03 |
| ubot4 | Launchpad bug 734671 in ubuntu-sso-client (Ubuntu) (and 1 other project) "ubuntu-sso-login crashed with ValueError in getsecret_handler(): too many values to unpack (affects: 74) (dups: 9) (heat: 366)" [Medium,Confirmed] https://launchpad.net/bugs/734671 | 13:03 |
| nessita | ralsina: are you available for doing a review? | 13:03 |
| ralsina | nessita: not right now, sorry | 13:05 |
| nessita | ok, np | 13:05 |
| ralsina | nessita: I just noticed that the sso tests open acctual, visible windows. Is that known? (/me shakes head) | 13:06 |
| nessita | ralsina: all the UI tests open windows, we use xfvb to run them and have a separated X session | 13:06 |
| ralsina | nessita: not sso | 13:06 |
| nessita | ralsina: let me confirm before arguing :-) | 13:07 |
| nessita | ralsina: confirmed that sso in linux uses xfvb | 13:07 |
| nessita | 39 `which xvfb-run` u1trial "$MODULE" -i "test_windows.py" | 13:07 |
| nessita | ralsina: from the bash script run-tests | 13:08 |
| ralsina | nessita: mandel and I suck, we don't have xvfb-run | 13:08 |
| mandel | ralsina: can you recheck the branch with my stupid strength spelling | 13:45 |
| karni | hi duanedesign | 14:09 |
| === zyga is now known as zyga-food | ||
| karni | JamesTait: thanks for the log. I'll be replacing the core of SD very soon (moving to REST), this should fix quite a few pending issues :) | 14:12 |
| ralsina | mandel: on it! | 14:14 |
| alecu_ | nessita, I'm trying to debug the txsecrets bug you pasted earlier, but I'm getting "ImportError: No module named PyQt4.QtCore" | 14:15 |
| alecu_ | nessita, mandel: are new Qt packages needing dependencies? | 14:15 |
| nessita | alecu_: for develop, yes | 14:16 |
| ralsina | alecu_: did you see a bug # I posted earlier? | 14:16 |
| nessita | alecu_: we need to run qt tests as well | 14:16 |
| nessita | ralsina: I'm working on that one | 14:16 |
| alecu_ | ralsina, I saw it, but I also saw nessita saying she was working on it. | 14:17 |
| mandel | what? | 14:17 |
| mandel | que? | 14:17 |
| ralsina | alecu_: ok then | 14:17 |
| nessita | ralsina: would you trivial review https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/urgent/+merge/57318? (is the fix for the bug you linked) | 14:18 |
| ralsina | sure | 14:18 |
| alecu_ | nessita, no tests on that branch!!!! | 14:19 |
| alecu_ | nessita, you should do a test that does del on that attr | 14:19 |
| nessita | alecu_: I tried, tehre no way for the way the original test was coded | 14:19 |
| nessita | alecu_: I was getting exceptions.AttributeError: 'FakeLauncherEntryProps' object attribute 'urgent' is read-only | 14:20 |
| alecu_ | nessita, oh, I see where that code comes from. | 14:20 |
| alecu_ | nessita, don't worry then. | 14:20 |
| nessita | alecu_: I weighted the amount of change needed to add the test, it was too much | 14:20 |
| ralsina | nessita: +1 yikes | 14:22 |
| dobey | rye: ping. how do we do that apport bug thing to stop more incoming bugs? | 14:26 |
| JamesTait | Hey karni. :) You're welcome, I hope the report was useful. I'm not sure what happened, it just reported a crash when I came to browse my files. | 14:33 |
| karni | JamesTait: yeah, devil in details, it's the syncdaemon, but I'll have to improve the log reporting anyway. I do, however, believe that the need of reports will drastically decrease once we are 100% REST | 14:33 |
| dobey | grr, pylint | 14:36 |
| === zyga-food is now known as zyga | ||
| mandel | dobey: we have noticed that pylint is kinda of fuked up | 15:07 |
| mandel | is complaining about C++ types, and I know I tend to make mistakes, but this is way out of my hands :P | 15:08 |
| nessita | mandel: example? | 15:09 |
| dobey | uh? | 15:09 |
| ralsina | https://pastebin.canonical.com/45985/ | 15:10 |
| ralsina | nessita, dobey: ^ | 15:10 |
| dobey | hmm | 15:11 |
| nessita | seems like pylint and pyqt does not get along | 15:12 |
| mandel | dobey: form that error onwards pylint start given very stupid warnings that dont seem to make much sense... | 15:12 |
| mandel | better exaple: https://code.launchpad.net/~mandel/ubuntu-sso-client/windows_ui_4/+merge/56308 | 15:12 |
| nessita | ralsina, mandel, dobey: we could add all the pyqt files to the pylint ignore file list | 15:12 |
| mandel | look at the tarmac output | 15:12 |
| nessita | http://www.logilab.org/ticket/57299 | 15:12 |
| nessita | mandel: ^ | 15:12 |
| * mandel looks | 15:12 | |
| alecu_ | nessita, it seems like the secrets spec has changed, but they have not changed the spec number. | 15:13 |
| alecu_ | they added a new parameter to the "Secret" dbus struct | 15:13 |
| alecu_ | http://people.collabora.co.uk/~stefw/secret-service/ch14.html | 15:13 |
| alecu_ | it's the content_type value | 15:13 |
| nessita | mandel: this thread may be also interesting http://lists.logilab.org/pipermail/python-projects/2009-July/001982.html | 15:13 |
| nessita | alecu_: looking | 15:14 |
| alecu_ | (not a new parameter but a new struct member) | 15:14 |
| alecu_ | nessita, here's how it used to be like: | 15:14 |
| alecu_ | http://code.confuego.org/secrets-xdg-specs/ch13.html | 15:14 |
| mandel | nessita: in M I was able to run pylint and qt with no issues what so ever... | 15:14 |
| mandel | nessita: and is 0.21.1 | 15:14 |
| alecu_ | nessita, I'm making a small fix to account for this change, and I'll ask for your review soon. | 15:14 |
| mandel | nessita: on windows we are using 0.22.2 or something similar, I dont have the windows vm running atm | 15:15 |
| duanedesign | aquarius: did you ever get a chance to do any more work ondesktopcouch_gateway.py? | 15:15 |
| nessita | alecu_: thanks, Please note you shuold target (ie make branches) for both stable-1-2 and trunk | 15:16 |
| nessita | mandel: oh! | 15:16 |
| aquarius | duanedesign, I didn't :( | 15:16 |
| * mandel opens millbanks window to jump | 15:17 | |
| beuno | mandel, they've sealed them shut since the last developer did that | 15:18 |
| mandel | beuno: I'll ran as fast as I can against them | 15:18 |
| beuno | mandel, please make sure someone is filming that first | 15:19 |
| mandel | nessita: take a look at the merge proposal, pylint not only complains about the Qt modules, it also is saying some very stupid things regarding other modules that we did no touch in that merge | 15:20 |
| mandel | beuno: will do | 15:20 |
| duanedesign | aquarius: understandable, I am sure you got a full plate. I was just reminded of it today. Looks like a couch API change has broken it. Might be the switch of couch.client to couch.http | 15:21 |
| alecu_ | nessita, I'm getting a bunch of pylint issues on both branches (trunk and stable-1-2) | 15:22 |
| nessita | mandel: a ver. Do you have latest pylint from our PPA? | 15:22 |
| nessita | alecu_: same question | 15:22 |
| alecu_ | nessita, I've updated everything like an hour ago. | 15:23 |
| mandel | nessita: those errors are coming from tarmac, so it shoul dbe using the latests one, right dobey | 15:23 |
| mandel | ? | 15:23 |
| nessita | mandel, alecu_: what version does aptitude show python-logilab-common show for you? | 15:23 |
| * nessita checks | 15:23 | |
| alecu_ | nessita, 0.55.0-1ubuntu1~natty1 | 15:23 |
| alecu_ | OneUbuntuOne | 15:24 |
| ralsina | maybe we should roll tarmac back to 0.21.1 because 0.23.0 sucks rocks through a garden hose | 15:24 |
| nessita | alecu_: is control panel test suite running smoothly for you? | 15:24 |
| alecu_ | lemme check | 15:24 |
| alecu_ | tests seem to run fine... let's wait for stylecheck | 15:25 |
| nessita | mandel, alecu_: this is what I'm getting for ussoc https://pastebin.canonical.com/45986/ | 15:26 |
| nessita | alecu_: any chance you become alecu without _? :-) | 15:26 |
| alecu_ | nessita, control panel ran fine, no error | 15:27 |
| rye | dobey, bugpatterns, what bug to trace? | 15:27 |
| === alecu_ is now known as alecu | ||
| nessita | alecu: thanks :-). So, all the error I've got (except the TypeError: C++ type 'QWidget*' is not supported as type error) are valid and need to be fixed (doing that right now) | 15:29 |
| dobey | rye: there are a LOT of bugs about dbus Connection refused :( | 15:29 |
| dobey | rye: but the error message is translated, and coming from different scripts, so we're getting several sets of bugs/dups | 15:30 |
| mandel | nessita: which branch are you talking about? | 15:30 |
| rye | dobey, which to make the master report? | 15:30 |
| nessita | mandel: ussoc trunk | 15:30 |
| dobey | rye: i'm not sure | 15:30 |
| mandel | nessita: can you pastebin those warnings? | 15:30 |
| alecu | nessita, I'm getting the same issues on ussoc | 15:30 |
| nessita | mandel: I'm getting this E0611: 19: No name 'QtCore' in module 'PyQt4'. PAstebin was: | 15:30 |
| nessita | https://pastebin.canonical.com/45986/ | 15:30 |
| mandel | nessita: I get none when I ran it with 0.21 | 15:30 |
| rye | omg bug #420705 | 15:30 |
| ubot4 | rye: Bug 420705 on http://launchpad.net/bugs/420705 is private | 15:30 |
| nessita | mandel: right, all the Reimport errors are valid (and new) | 15:31 |
| mandel | nessita: in trunk? | 15:31 |
| mandel | nessita: really? | 15:31 |
| nessita | mandel: what I don't know how to fix is the | 15:31 |
| nessita | TypeError: C++ type 'QWidget*' is not supported as type | 15:31 |
| nessita | ************* Module ubuntu_sso.qt.controllers | 15:31 |
| nessita | E0611: 19: No name 'QtCore' in module 'PyQt4' | 15:31 |
| nessita | mandel: really what? I'm starting to get lost | 15:31 |
| mandel | nessita: all the reimport issues, are they correct? are they present in trunk? | 15:31 |
| nessita | mandel: yes | 15:31 |
| * mandel looks | 15:32 | |
| nessita | mandel: are correct and are present, it happened in the control panel, we fixed it last week. Pylint gor strictier | 15:32 |
| rye | wait.. bug #756806 is not the correct duplicate | 15:32 |
| rye | ah yes | 15:33 |
| alecu | nessita, https://code.launchpad.net/~alecu/ubuntu-sso-client/tx-unpack-toomany/+merge/57330 | 15:35 |
| alecu | and https://code.launchpad.net/~alecu/ubuntu-sso-client/tx-unpack-toomany-1-2/+merge/57331 | 15:35 |
| mandel | nessita: to be clear, you are fixing the reimport issues that are in trunk atm, right? | 15:35 |
| mandel | nessita: or do you want me to take a look into those? | 15:35 |
| nessita | mandel: yes, I am | 15:35 |
| alecu | I can surely use more reviews on those twin branches | 15:36 |
| mandel | nessita: superb! so, in theory once that is done, we will propose a branch in which the ignogred paths in pylint are updated not check ubuntu_sso/qt | 15:36 |
| mandel | which is a PITA.... | 15:37 |
| rye | how does apport finds out the duplicate based on traceback? The exception is completely different in some bug reports | 15:37 |
| nessita | mandel: does this make sense http://old.nabble.com/Error-in-calling-QSignalMapper.__bases__-td30162759.html ? | 15:37 |
| mandel | ralsina: ^ | 15:38 |
| mandel | nessita: looking into it, but I really cannot think of a plce where the QSignalMapper is used... | 15:39 |
| nessita | mandel: try gooling a bit, there may be something there to fix (maybe( | 15:39 |
| nessita | )) | 15:39 |
| dobey | hmm | 15:43 |
| dobey | mandel: i think you can ignore the TypeError: C++... bit | 15:44 |
| mandel | dobey: ralsina is taking a look at it, we do use QtGui but it is used after QtCore… if that works, we can move with that | 15:45 |
| nessita | mandel: I think these are valid and yours to fix: | 15:45 |
| nessita | ubuntu_sso/qt/gui.py: | 15:46 |
| nessita | 247: [E0602, SetupAccountPage.set_strenght_level] Undefined variable 'MEDIUM_COLOR' | 15:46 |
| nessita | 248: [E0602, SetupAccountPage.set_strenght_level] Undefined variable 'MEDIUM_COLOR' | 15:46 |
| dobey | mandel: i mean, it seems to be an internal traceback from pylint, but pylint continues to run and complains about other things | 15:46 |
| dobey | mandel: so i think you can ignore that TypeError and just fix the other complaints for now | 15:46 |
| nessita | mandel: in SetupAccountPage you're using MEDIUM_COLOR but is not defined not imported | 15:46 |
| rye | dobey, will trap all org.freedesktop.DBus.Error.NoServer and redirect to bug #420705 | 15:46 |
| ubot4 | Launchpad bug 420705 in ubuntuone-client (Ubuntu) "ubuntuone-syncdaemon crashed with DBusException in __new__() (affects: 45) (dups: 48) (heat: 388)" [High,Triaged] https://launchpad.net/bugs/420705 | 15:46 |
| mandel | nessita: yes, those I'll fix in a second, it seems that the branch gor screwed up in a merge conflict | 15:46 |
| mandel | dobey, nessita: ralsina tested it by chaging the order of the import and it works… so we will move on with that | 15:47 |
| nessita | mandel: ok, the other reimport error is not that fixable, so I would agree on adding the W0404 to the disable list | 15:47 |
| dobey | rye: hrmm, i don't think that's the same issue? | 15:47 |
| dobey | but ok | 15:48 |
| rye | dobey, it does not look like ubuntuone-client issue at all | 15:48 |
| nessita | mandel: so basically please also apply https://pastebin.canonical.com/45987/ | 15:48 |
| dobey | rye: i think something broke recently in dbus | 15:48 |
| rye | dobey, hmm | 15:48 |
| dobey | rye: but i have no idea how to figure out what :( | 15:48 |
| rye | dobey, there had been numerous reports in the past too | 15:48 |
| rye | dobey, well, in distant past | 15:48 |
| nessita | mandel: ack? | 15:49 |
| mandel | nessita: sounds good | 15:49 |
| rye | dobey, bugpattern is set up | 15:49 |
| mandel | nessita: will make sure that is applied and that the MEDIUM* is fixed | 15:49 |
| nessita | mandel: awesome | 15:49 |
| * fagan should be talking in the public channel | 15:55 | |
| dobey | rye: but none so many as this. they were more random i think. :( | 15:58 |
| rye | dobey, ok, i am adding some info to the bug report to help us find the issue | 15:58 |
| dobey | rye: ok, thanks | 15:58 |
| leonel | hello : I hope Ubuntuone does not has something like this : http://dereknewton.com/2011/04/dropbox-authentication-static-host-ids/ | 16:01 |
| Chipaca | leonel: Ubuntu One uses oauth | 16:02 |
| leonel | Yes I was reading that and it's great ... | 16:03 |
| dobey | we also store the token in the user's keyring, and not in a plain file somewhere | 16:03 |
| Chipaca | if somebody got hold of your keyring password (usually the same as your computer login password), then they'd get access to that token | 16:04 |
| Chipaca | which you can disable from the control panel and the website | 16:04 |
| dobey | ugh, lot of stuff in nightlies failing to build :( | 16:08 |
| beuno | clarita, I'm about 30 minutes away from lunch. Want to do that review now? | 16:14 |
| nessita | dobey: can you confirm the following: since we don't want to explicitly depend on unity, we don't need to add the Depends gir1.2-unity-3.0 (>= 3.8.4) to the control panel package. The control panel code already checks for the unity lib availability and do nothing if is not installed (the problem we had was that the lib was installed but outdated) | 16:14 |
| Chipaca | nessita: there is no chance that unity is installed without the gir? | 16:14 |
| nessita | Chipaca: we are checking with a try-except, so no | 16:15 |
| dobey | nessita: right. it should probably depend on ubuntuone-client (>= 1.6.0) though, which Recommends: gir1.2-unity-3.0 (>= 3.8.4) | 16:15 |
| Chipaca | nessita: I can uninstall gir1.2-unity-3.0 and still have unity :-/ | 16:15 |
| dobey | Chipaca: yes, but you won't have u1 integration with unity in that case | 16:15 |
| clarita | beuno: sounds good - shall we Mumble? | 16:15 |
| nessita | Chipaca: but then the control panel can't make use of the unity cool stuff | 16:15 |
| beuno | clarita, yes | 16:16 |
| Chipaca | ok, the Recommends works | 16:16 |
| dobey | Chipaca: our code uses the Unity API from gobject-introspection | 16:16 |
| dobey | Chipaca: and we recommend it, so people can remove unity and still use u1 | 16:16 |
| Chipaca | right, just wanted to be sure | 16:17 |
| clarita | beuno: which room? | 16:17 |
| beuno | clarita, I'm in web and mobile | 16:17 |
| clarita | beuno: ah yes - one moment | 16:17 |
| alecu | nessita, everybody: can I get reviews on this twin branches? https://code.launchpad.net/~alecu/ubuntu-sso-client/tx-unpack-toomany/+merge/57330 and https://code.launchpad.net/~alecu/ubuntu-sso-client/tx-unpack-toomany-1-2/+merge/57331 | 16:17 |
| nessita | alecu: I have the queued for after the release of u1cp, | 16:20 |
| alecu | ralsina, dobey? can I get your review on the braches above? | 16:20 |
| dobey | alecu: i wonder if that breaks on older versions of gnome-keyring? | 16:20 |
| alecu | dobey, versions with less than 3 values in that struct? | 16:21 |
| dobey | alecu: yeah, will it break on maverick for example? | 16:22 |
| alecu | dobey, I don't think there are any like that; the interesting one is value, so it must have been present for ever. | 16:22 |
| nessita | mandel: is your branch ready to land or landed? | 16:22 |
| ralsina | alecu: I can try but I can'tpromise | 16:22 |
| dobey | alecu: oh were we just throwing away the other 2 values then? | 16:22 |
| alecu | dobey, right | 16:22 |
| nessita | dobey: the former code (session, parameters, value = secret) is running in maverick now, with nightlies | 16:23 |
| mandel | nessita: close, I need to push a change | 16:23 |
| dobey | nessita: i now it is. i'm asking if the new code breaks on maverick | 16:23 |
| dobey | nessita: because it is not clear to me from the diff if it will or not :) | 16:23 |
| alecu | ralsina, it's a one line change (with a lot of tests) because there was a new value added to a dbus struct in gnome-keyring. | 16:24 |
| nessita | dobey: shouldn't break, since right now we're already accessing secret[2] when unpacking. The problem now is that there is an extra field | 16:24 |
| alecu | ralsina, so it should be easy to review. | 16:24 |
| ralsina | alecu: seen it. Looks good to me. | 16:24 |
| nessita | alecu: I think dobey and I got your reviews covered? | 16:24 |
| ralsina | It's ok, I have to wait for manuel anyway | 16:24 |
| === Chex_ is now known as Chex | ||
| ralsina | alecu: +1 on tx-unpack-toomany | 16:25 |
| dobey | ok | 16:25 |
| ralsina | alecu: +1 on the twin | 16:26 |
| alecu | ralsina, thanks. | 16:26 |
| alecu | nessita, you or dobey. ralsina has approved. | 16:27 |
| nessita | alecu: in a few minutes :-) | 16:27 |
| * alecu reboots | 16:28 | |
| mandel | nessita: the branch was merged, we are ignoring the import errors and fixed the color and the C++ issues | 16:36 |
| nessita | alecu: trunk approved | 16:36 |
| nessita | mandel: ack | 16:36 |
| alecu | thanks | 16:36 |
| mandel | nessita: at some point next week I'll write a wiki page that comments about possible issues due to all the multipltform work | 16:37 |
| nessita | mandel: such as? | 16:37 |
| dobey | lunch time, bbiab | 16:38 |
| nessita | alecu: you will need to add the new disable to the pylintrc file for stable-1-2 | 16:38 |
| nessita | alecu: as per https://pastebin.canonical.com/45987/ | 16:39 |
| alecu | ack | 16:39 |
| mandel | nessita: errors such as the C++ thing, missing pacakages etc… I need to think carefully about what to write | 16:39 |
| nessita | ack | 16:39 |
| * alecu likes the new dark tabs on gnome-terminal | 16:42 | |
| nessita | hey fagan, can you please clarify what you meant in bug #562625? if you mark a bug as Incomplete, there should be a clear question to the reporter, so s/he knows what we're expecting from her/him | 16:44 |
| ubot4 | Launchpad bug 562625 in ubuntuone-client "A folder should not be marked as synchronized if a subfolder inside it is out of sync (affects: 2) (heat: 10)" [Undecided,Incomplete] https://launchpad.net/bugs/562625 | 16:44 |
| * fagan looks | 16:45 | |
| fagan | nessita: oh whoops that was one I messed up on and asked ralsina about it and changed it twice ill comment on it and explain | 16:46 |
| ralsina | fagan, nessita: that one is tricky, you can mark it incomplete, invalid or fix-whatever depending on what you write :-) | 16:47 |
| ralsina | but for fix-released you need to know what branch fixed it. So ... | 16:47 |
| nessita | ralsina: right, but since last status was Incomplete, and I didn't see any quesiton for our reporter, I was wondering what fagan meant | 16:48 |
| ralsina | nessita: yeah | 16:49 |
| fagan | nessita: I knew it was fixed but I couldnt dig out the bug to mark it as a duplicate | 16:49 |
| fagan | so I was going to mark it as fix released or invalid but went to incomplete just to make sure | 16:50 |
| nessita | fagan: but you should consider if the user is reporting for maverick, or for natty, or for another version. And in that case, point out in which version the bug was fixed. | 16:50 |
| ralsina | In those cases a "I can't reproduce it with current blah, could you try again?" and mark as incomplete is what I usually do. | 16:50 |
| nessita | fagan: maybe the issue is resolved in natty and not in maverick, so we need to suggest to update to natty once released, or to point the reporter to our nightlies | 16:51 |
| mandel | ralsina: oan extra one: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_views_tests/+merge/56314 | 16:51 |
| fagan | nessita: yeah I know im making sure to read the bugs first rather than just blindly commenting asking for info | 16:52 |
| nessita | fagan: great, thanks! :-) | 16:52 |
| mandel | ralsina: would be: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_windows_ui_root/+merge/56320 | 16:53 |
| fagan | nessita: that one was just an interesting case since I knew it was fixed but not the specific version so I fumbled it :0 | 16:53 |
| nessita | fagan: and sorry to repeat this, but you should assign to yourself the bugs marked as Incomplete, otherwise if people responds we may miss the answer (such as bug #566469 and bug #565147) | 16:53 |
| ubot4 | Launchpad bug 566469 in ubuntuone-client "Ubuntu One crashes Lucid and other effects (affects: 1) (heat: 6)" [Undecided,Incomplete] https://launchpad.net/bugs/566469 | 16:53 |
| ubot4 | Launchpad bug 565147 in ubuntuone-client "Folders sync with web but files aren't downloaded (affects: 8) (heat: 36)" [Undecided,Incomplete] https://launchpad.net/bugs/565147 | 16:53 |
| nessita | alecu: stable approved | 16:54 |
| fagan | nessita: oh I didnt sub myself but im a bug contact because the team is the bug contact so I will get the mail | 16:54 |
| fagan | ill mark it for all of the bugs I missed though since I missed more than those 2 | 16:55 |
| nessita | fagan: thanks! | 16:55 |
| lool | Hey there; I'm on natty and syncdaemon is busy-looping with nothing in the logs; strace shows only: select(5, [4], NULL, NULL, NULL) = 1 (in [4]) | 16:58 |
| lool | in a loop | 16:58 |
| lool | This is the output of --status: http://paste.ubuntu.com/593177/ | 16:59 |
| * lool goes logging out and killing everything | 17:02 | |
| nessita | lool: hi there. What do you mean with busy looping? | 17:03 |
| lool | Using 100% CPU | 17:04 |
| lool | I just logged out and back in, and it doesn't happen anymore | 17:04 |
| lool | This happened after switching from Ubuntu Classic to Ubuntu in the sessions; not sure whether that relates | 17:04 |
| nessita | lool: where are you checking the CPU usage? | 17:04 |
| lool | (So I was running Ubuntu Classic, logged out, selected Ubuntu, logged back in, and got this busy loop) | 17:05 |
| lool | nessita: top | 17:05 |
| nessita | lool: and what's the name of the daemon using the cpu? | 17:05 |
| lool | the process was actually called "syndaemon" not syncdaemon | 17:05 |
| nessita | lool: right, that is not us :-) | 17:05 |
| lool | Oh wait that's not u1 :-) | 17:05 |
| lool | that's xserver-xorg-input-synaptics | 17:05 |
| nessita | lool: right :-) | 17:05 |
| lool | Since I turned on U1 recently and it sounded like U1, I thought it was eh | 17:05 |
| lool | Alright, thanks! | 17:06 |
| nessita | lool: we're ubuntuone-syncdaemon ;-) | 17:06 |
| lool | Ouch, there it is at 100% again | 17:06 |
| lool | badbad | 17:06 |
| * lool moves to #ubutnu-x | 17:06 | |
| Chipaca | lool: we had that ourselves recently :) | 17:09 |
| ralsina | mandel: lp:~ralsina/+junk/sso_fix_conflict_1 | 17:22 |
| === beuno is now known as beuno-lunch | ||
| mandel | ralsina: there you go: https://code.launchpad.net/~mandel/ubuntu-sso-client/choose_correct_ui_module/+merge/56321 | 17:51 |
| mandel | ralsina: it should be tested on both OS | 17:51 |
| mandel | fagan: can you review this guy in natty: https://code.launchpad.net/~mandel/ubuntu-sso-client/add_windows_ui_root | 17:52 |
| ralsina | mandel: got it | 17:53 |
| nessita | lunchtime! | 17:54 |
| === beuno-lunch is now known as beuno | ||
| karni | I'm starving, food time. | 18:32 |
| NET||abuse | i am possibly in trouble here, does anyone know if you can recover files from ubuntuone? | 20:24 |
| NET||abuse | the whole ubuntuOne directory was deleted in work ( i was leaving) and it seems to have replicated down to my home pc, i had config files and a cv in there | 20:24 |
| NET||abuse | I really need them back | 20:24 |
| alecu | NET||abuse, there is a way, let's ping someone who may help | 20:30 |
| NET||abuse | oh, great | 20:31 |
| alecu | rye, NET||abuse had some files erased from his account | 20:31 |
| alecu | rye, what's the current way to get files out of the u1 trashcan? | 20:31 |
| alecu | beuno, may know about that as well ^^^ | 20:31 |
| NET||abuse | any hints are most appreciated : ) virtual beer on me :) | 20:32 |
| beuno | alecu, I do, but rye is the best person to solve this | 20:32 |
| beuno | NET||abuse, you need all your files recovered? | 20:32 |
| * NET||abuse is really glad he wasn't keeping his ssh keys in there. | 20:32 | |
| NET||abuse | beuno, yup, if possible. | 20:32 |
| NET||abuse | or as many as possibel :) | 20:32 |
| alecu | NET||abuse, we'll try to help, but we'll be demanding real beer | 20:32 |
| beuno | NET||abuse, I just need an email address from you and I can recover them | 20:33 |
| NET||abuse | OK, can i priv msg it to you? | 20:33 |
| beuno | NET||abuse, of course | 20:33 |
| NET||abuse | thanks for the help beuno, you da nerd! | 20:42 |
| alecu | nessita, I'm looking at the bug #759084 you reported, and it looks more serious than it seems. | 20:42 |
| ubot4 | Launchpad bug 759084 in ubuntuone-client "AssertionError in aggregator (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/759084 | 20:42 |
| nessita | alecu: really? tell me more | 20:42 |
| alecu | nessita, it seems that eric added a timer to delay the queue_done (I can't recall exactly why) | 20:43 |
| alecu | nessita, and new SD commands show up after starting that delay | 20:43 |
| alecu | nessita, so the timer fires and resets the count of commands, which leaves the aggregator in a funny state | 20:44 |
| nessita | alecu: oh | 20:44 |
| nessita | ouch | 20:44 |
| nessita | alecu: any idea why the timer is there? | 20:44 |
| alecu | nessita, I found a way to fix it fast... I'm trying to understand how to fix it right. | 20:44 |
| nessita | thinking quickly, I don't see why we should use a timer | 20:45 |
| alecu | the fast fix would be to just return in case the total_counter is zero, instead of the assertion that fails | 20:45 |
| alecu | the problem with this is that the progressbar will start showing lies after syncdaemon is running for a while and this conditions happen. | 20:46 |
| alecu | I guess we were lucky I that assert was there, because it would be a hard thing to find out otherwise. | 20:47 |
| alecu | nessita, I'm pretty sure the timer is there for some reason, I recall chatting with him about that. | 20:47 |
| nessita | alecu: have logs? :-) | 20:47 |
| alecu | can't find anything interesting on the logs :/ | 21:02 |
| alecu | nessita, I found out why the timers are there and I think I found the problem as well. | 21:10 |
| nessita | alecu: shoot (I have a little lag since I'm debugging dc with CardinalFang) | 21:10 |
| alecu | nessita, we have that timer because there are times that downloads are not scheduled all together | 21:10 |
| alecu | nessita, for instance, you have 100 files to download, but only two are scheduled by sd, then when they complete a "queue done" happens and two more are queued for download | 21:11 |
| alecu | nessita, so that's why the timer is there. | 21:11 |
| alecu | the problem is that when a new download (or upload) arrives, if the timer is active it is reset (ie, it will still fire, but later), but it should be stopped instead till the new queue_done is done. | 21:12 |
| alecu | so I'm trying to do a testcase for this. | 21:13 |
| nessita | alecu: I m processing that info now | 21:13 |
| alecu | don't worry. | 21:13 |
| rye | dobey, testing why gsd does not create the bookmark, btw, I noticed it has its own timeout to start syncdaemon, why? | 21:42 |
| alecu | dobey, nessita: made a fix for the AssertionError that nessita found. Is it too late to review and land? https://code.launchpad.net/~alecu/ubuntuone-client/zero-steps/+merge/57392 | 21:45 |
| * nessita reviews | 21:45 | |
| rye | dobey, heh, the bookmark is not created because the signal credentials_found is never issued | 21:49 |
| rye | or if it is issued, it is doing that before gsd initializes its syncdaemon | 21:50 |
| rye | nessita, ping | 21:52 |
| nessita | rye: pong | 21:52 |
| rye | nessita, is CredentialsFound signal used now at all? | 21:52 |
| nessita | rye: heavily used, why? | 21:53 |
| rye | nessita, in syncdaemon, not SSO - I see it is supposed to emit CredentialsFound | 21:53 |
| nessita | alecu: looks clean and clear, running tests now | 21:53 |
| nessita | rye: syncdaemon uses CredentialsFound from the ubuntuone.credentials service | 21:53 |
| rye | nessita, ah, it listens to CredentialsFound and then runs its own method with the same name | 21:54 |
| nessita | yes | 21:54 |
| nessita | rye: it filters the event that may be for other apps | 21:54 |
| rye | nessita, ok, thanks, sorry for confusion | 21:54 |
| nessita | no problem :-) | 21:54 |
| nessita | alecu: I'm running tests, when done I'll approve, I need to close pidgin to test how syncdaemon handles something | 21:56 |
| alecu | nessita, thanks | 21:56 |
| * nessita is back | 22:00 | |
| === jdobrien is now known as webm0nk3y | ||
| alecu | rye, afaict the CredentialsFound DBus signal is sent by ubuntu-sso-client, and handled by the gsd-plugin. | 22:02 |
| alecu | rye, syncdaemon should be already started when this happens, in order for the credentials to be searched for, but syncdaemon takes no part in that. | 22:03 |
| alecu | (other than asking sso for the credentials) | 22:03 |
| alecu | nessita, are we doing another release of u1-client today? | 22:04 |
| rye | alecu, but sd starts after 30 seconds and gsd starts after 30 seconds | 22:04 |
| alecu | so I can try to get another review on that branch. | 22:04 |
| rye | alecu, to put it simply, the credentials_found is not called on current Natty, therefore no bookmark | 22:04 |
| alecu | rye, I'm looking into it further. Do we have a bug for this? | 22:05 |
| rye | alecu, filing one | 22:06 |
| rye | alecu, i just created a second account on my machine and added it to my ubuntuone | 22:06 |
| nessita | alecu: I don't know, we need dobey for that (may be a good idea) | 22:06 |
| mandel | cool, the sprint started | 22:08 |
| * alecu is taking a diaper break. It smells of biohazard around here. | 22:09 | |
| * mandel hopes that alecu is talking about a baby…. | 22:11 | |
| rye | alecu, bug #759197 | 22:11 |
| ubot4 | Launchpad bug 759197 in ubuntuone-client (Ubuntu) (and 1 other project) "[natty] Ubuntu One Folder bookmark is not created (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/759197 | 22:11 |
| nessita | dobey: ping | 22:15 |
| mandel | ralsina: ping | 22:18 |
| rye | nessita, i knwo what, we can drop the urgency for the icon when control panel is brought via a click on any of the shares :) if that is supported and I find out where it is I suppose I can make a patch | 22:18 |
| rye | ping: ping | 22:19 |
| * rye goes eod, and will do first baby steps in gtk early tomorrow | 22:21 | |
| nessita | rye: tomorrow ping me, I will try to walk you through | 22:24 |
| * nessita brbs | 22:24 | |
| alecu | mandel, still around? | 22:34 |
| alecu | mandel, ralsina: in case you are still around... can I beg you guys for a review? https://code.launchpad.net/~alecu/ubuntuone-client/zero-steps/+merge/57392 | 22:34 |
| alecu | oh, don't worry, it seems that I got the two reviews already :P | 22:34 |
| alecu | sorry | 22:37 |
| mandel | alecu: ok, no worries :) | 22:43 |
| mandel | alecu: how was santiago segura? | 22:43 |
| mandel | as dirty as usual? | 22:43 |
| alecu | mandel, it was genius | 22:48 |
| alecu | mandel, there were even a few fans that were a bit slow, and he made fun of them to the delight of us all :-) | 22:49 |
| mandel | hahaha | 22:50 |
| mandel | he is a bastard, I prefer him in person than on the torrente movies | 22:50 |
| dobey | nessita: what's up? | 23:32 |
| nessita | dobey: alecu was wondering if we could make another release for u1client | 23:35 |
| nessita | dobey: he fixed an important issue, and I also think that facundobatista fixed a Critical | 23:35 |
| nessita | dobey: and next question, is tarmac running for u1client? https://code.launchpad.net/~alecu/ubuntuone-client/zero-steps/+merge/57392 doesn't seem to land | 23:37 |
| dobey | yes it is | 23:38 |
| dobey | a failed test broke the tarmac tree because something leaves non-ascii files around | 23:38 |
| nessita | dobey: ah, I remember that :-/ | 23:39 |
| dobey | nessita: and i think the archive is frozen right now for making the CD | 23:39 |
| nessita | dobey: it is, but we can propose the release the same, I think, it will land when the repo is unfrozen (at least that is what seb said :-)) | 23:40 |
| * nessita goes to cook some dinner | 23:41 | |
| alecu | nessita, are you still around? | 23:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!