=== Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [13:13] benji and anyone else who cares, the link to the RSS feed for the kanban board is working again (from Options tab). [13:14] cool; do you know off hand if it includes comments? [13:16] it looks like the answer is no [13:16] AFAICT, no, benji :-/ [13:27] bac benji danilos, looking an kanban; call in 3 [13:29] gary_poster, ack, ready [13:29] bac, I assume you are "Investigate and fix LaunchpadTestRequest..."? [13:29] yes [13:30] cool, thx. face was not showing for some reason [13:38] https://bugs.launchpad.dev/firefox/+bug/1/+subscriptions# [13:38] <_mup_> Bug #1: Microsoft has a majority market share

https://devpad.canonical.com/~danilo/direct-subs.png [13:59] https://code.launchpad.net/~danilo/launchpad/bug728370-direct-subs/+merge/57464 is the latest MP [13:59] 1) claim review [14:00] 2) prettify [14:00] 3) set up pattern for actions [14:00] 4) make UI and actions for direct subscriptions [15:53] danilos: r=bac with one issue that may require some work regarding private bugs [15:54] i don't think it is accurate to say the only reason you get mail for a private bug is if you're the bug supervisor. i'll have to dig out the other cases [15:57] bac, well, the text will "may have been subscribed because you are a bug supervisor" (mostly to explain how did you get subscribed in the first place); my understanding was that we don't have enough data to show otherwise, at least we don't export it [15:58] bac, regarding the product owner but not the bug supervisor, that's handled separately already [15:58] bac, that one doesn't cause direct subscription to be created [15:58] danilos: ok [15:58] danilos: just wanted to raise it to ensure we weren't overlooking additional vectors [15:59] bac, sure thing [15:59] bug supervisor: bac, danilos, right. AFAIK, at this point we only know that the person is subscribed. It's possible that we might be able to dig out the info from some log or other, but...I don't think it's hanging around easy to get to. [16:00] bac, that's actually previous branch that puts all of these bits into a list of subscriptions like { reason: 'text with {bugs}', vars: { bugs: '#1' } } [16:00] bac, my goal was to easily extend that to be something like { reason: ..., vars: ..., supported_actions: [...] } [16:01] danilos: right [16:01] bac, then, it'd be up to the call-sites to just deal with all the supported_actions that are really supported [16:25] bac, do you think you've got an idea of how you can go about this or do you think we should have a call? [16:26] danilos, you are gone...in 30 min? [16:27] gary_poster, as soon as we are set for the following steps, actually (started at 8am this morning) [16:27] ack [16:28] I haven't actually looked at your branch yet. was geting mine in. Lemme look at it really fast and then see if I have any questions. That way at least one of me or bac can try to touch base with you a final time on this today. [16:28] you ec2 landing that branch danilos? [16:28] gary_poster, yep [16:28] awesome [16:33] danilos, I don't understand bac's para: "The elaborate substitution framework you've created looks to be very well thought out and tested. I hope that the usage of it justifies the work you've done...but I don't see the larger design here." [16:33] Is he referring to safely_render_description? [16:35] gary_poster, I suppose so, it's probably not obvious in the branch he reviewed what kind of substitution it does because strings with all the vars were in the branch you reviewed [16:35] yeah, maybe so :-) [16:36] hi [16:36] yes, i was just referring to all of the replacement infrastructure danilo put in place [16:36] as he said, from looking at that branch in isolation the utility of it is not completely obvious [16:36] gary_poster, also, I am not exactly sure what to do with {pillar_type}; I feel like just dropping it and saying "owner of {pillar}" instead [16:37] danilos, I take it that figuring out pillar type name is annoying, if so, sure. Seems pragmatic and reasonable [16:37] bac, gotcha [16:37] gary_poster, exactly :) [16:39] danilos, bac, ok, I understand where we are. So we need to figure out where we go so you can leave ASAP [16:39] danilos is "you" in that last sentence :-) [16:40] So, prettifying, easy enough--somebody nees to make some calls, maybe based on the mockups if they actually provide any input [16:40] they might, actually [16:40] for the inner boxes [16:40] next is doing the direct subscription widgets [16:40] That is sadly green field [16:41] but does not need any grand action infrastructure AFAIK, as I said earlier [16:41] gary_poster, right, prettifying is going well for me, I believe I'd be able to get it done before tomorrow's call [16:41] so someone can just take it [16:41] ok cool [16:41] then we have "making a an actions infrastucture" [16:41] gary_poster, I think the direct-subscription actions can be done entirely independently [16:41] gary_poster, that one is the trickiest one [16:41] yeah, good [16:41] right [16:42] I'm almost inclined to let someone just start adding actions and then refactor [16:42] except that you seem to have a vision [16:42] gary_poster, fwiw, I think the basis here is sound (basically, in the branch you reviewed: other than 'reason' and 'vars' we need to add supported actions, and if it's "unsubscribe-team", that action can go through vars.teams to offer individual team unsubscribe actions) [16:43] gary_poster, if folk find it too hard to follow "my vision", I am happy with the approach you suggest as well [16:43] I think it is a nice simple vision that I feel dumb for not understanding well ;-) [16:43] So you think that gather_nondirect_subscriptions should add "actions" [16:44] gary_poster, and my vision only concerns the side of "what actions are possible for this subscription box" [16:44] gary_poster, exactly [16:44] ok [16:44] have you thought about what to offer when it is teams, not a team? One action per team, I'm thinking [16:44] OK [16:45] I think I have enough to do this or watch someone else do this [16:45] danilos, thank you very much! [16:45] gary_poster, yeah, I think it should be one action per team, but do note that grouping is sometimes not even per team (i.e. each team will have a separate box) [16:45] ok [16:45] we'll run with what we have and see how it goes :-) [16:45] gary_poster, heh, excellent, I hope you find it easy to extend and test (those were my two main concerns) [16:45] cool danilos. bye :-) [16:45] bye :) [16:47] bac, benji, where are you all in terms of starting something else? I can do any of the following: [16:47] - talk with one or both of you all now to figure out what we are doing [16:47] - have lunch, and then talk with one or both of you to coordinate [16:47] - some combination of the above. [16:48] My plate is cleared, so I can start something or other. I'll probably have lunch before I start though. [16:48] i'm looking for a task but would like to lunch first [16:48] I have team lead call this afternoon...3PM I think [16:48] OK bac, ping me when you are back then? [16:48] ok [16:49] thx [16:49] benji, I suspect you are working on the end of bug 753152, so I won't worry about a task for you until you ping me. [16:49] <_mup_> Bug #753152: You should only be able to mute team subscriptions that are not delivered to you via a mailing list < https://launchpad.net/bugs/753152 > [16:49] * gary_poster goes to lunch [17:13] actually I was working on lunch ;) but yeah, before that I figured out why the help links weren't being created correctly so I should be able to knock it out now [17:14] :-) ok cool. [17:14] * gary_poster still kinda lunching [18:30] I am starting the "actions" task [18:31] Someone should claim the "direct personal subscription actions" task [18:31] That one has a mockup to use [18:31] Mine only kinda sorta [18:33] I'll point out mockups to the person who wants the task [18:36] gary_poster: my branch is failing in ec2 so i'd like to take a few minutes to figure out what happened and resubmit it. [18:36] of course [18:39] hmm, this looks fishy: NameAlreadyTaken: The name 'person-name859147' is already taken. [18:42] heh [18:43] it does [18:50] * gary_poster has team lead call in 10 minutes [18:51] you found out my secret identity [18:52] heh === Ursinha is now known as Ursinha-afk [19:20] gary_poster: now that the diff has updated, I'd like you to suggest any improvements you might have to the mute/unmute help text: https://code.edge.launchpad.net/~benji/launchpad/bug-753152/+merge/57553 [19:20] benji, ack, looking (and just got off team lead call!) [19:24] benji, I think you fixed a new and interestingly related bug to the one I was thinking of. :-) [19:24] So, your icon shows up on the main bug page, right? [19:24] not on our structural subscription edit thing? [19:25] right, main bug page [19:25] I think you may have gotten confused about structural subscriptions [19:25] quick Skype call might be fastest? [19:25] k [19:25] really slow Skype call might be slowest! [19:37] benji, I claimed review. I'll approve with notes we talked about. [19:37] k [19:42] done [19:50] gary_poster: I figured out that there was a problem with my email; I've fixed it now, but still didn't get your message :) [19:51] heh, benji, ok. :-) [19:51] do you want me to forward it to see if you get it now? [19:51] or send some other mail, whatever [19:58] gary_poster: i've noticed the (+) Subscribe link on a bug on production does not work. is that a known issue? [19:58] works for non-malone-alpha [19:59] it is not known, new bug bac :-( [19:59] gary_poster: ok, i'll file it [19:59] thanks. please put it on board too, or at least gimme number & I will [20:03] gary_poster: filed and on kanban as bug 760121 [20:03] <_mup_> Bug #760121: New feature-flagged JS (+) Subscribe link does not work < https://launchpad.net/bugs/760121 > [20:04] thank you [20:04] gary_poster: my branch landed so i needs more work [20:04] what shall i do? [20:04] awesome [20:04] OK I see three choices. May I Skype about them with you? [20:05] yes, please [20:05] let me launch [20:05] cool, tell me when you are ready [20:05] shot [20:05] shoot [20:06] shooted [20:08] https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/ [20:17] is there a faster way to make a branch of db-devl than bzr branch, utilities/link-external-sourcecode, and make? [20:41] benji: not that i know of [20:43] I've been contemplating getting an SSD for other reasons; it'd probably help there too. [21:10] with the announcement of the Teal squad we officially don't have the worst color any more ;P [21:10] heh === Ursinha-afk is now known as Ursinha [21:30] gary_poster: hmm, the list of actions is a little icon-heavy now, do you think it's acceptable?: http://i.imgur.com/Ki5ZQ.png [21:31] benji, that's what I was afraid of when I talked about it with Graham :-( [21:31] yes, it does seem icon-heavy [21:31] an idea: make the help button appear on hover over the enable/disable link [21:32] another compromise, yes [21:32] does it look any better if the actions are on new lines? [21:32] (although that will probably make for either wierd spacing or things jumping around) [21:32] as I think you had it initially [21:32] I would get rid of the "or" in that case [21:33] "or"s [21:33] the problem with putting them on their own lines now is that there are so many that they may be longer than the things to the left; I foresee a CSS-float-induced nightmare [21:37] gary_poster: how about something like this: http://i.imgur.com/5mIQM.png where the help link would appear on hover over the enable/disable link [21:38] benji I'm OK with that, especially if there's the same amount of space between edit and unsubscribe as there is now with the to-be-filled space between Disable and Edit. [21:39] gary_poster: it'll be slightly more space than is now (if we want all the spaces to be roughly even) [21:40] yeah, if I understand you, then agree