| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| gary_poster | bac benji danilos. call in 5, & I'll look at kanban in just a sec | 13:25 |
|---|---|---|
| gary_poster | benji may not be in for call; checking... | 13:29 |
| benji | gary_poster: I'm here | 13:29 |
| gary_poster | cool, I thought I knew what was happening different on Thursday but wanted to check :-) | 13:30 |
| gary_poster | bac, Skype | 13:31 |
| gary_poster | danilos: lp:~gary/launchpad/bug728370-direct-subs . I was thinking that we want args too, to pass to the functions. There's not much to it except for the new test/fix I sketched. | 13:45 |
| gary_poster | ok benji, calling on Skype | 13:45 |
| benji | gary_poster: https://code.edge.launchpad.net/~benji/launchpad/bug-753152-this-time-for-sure/+merge/57672 | 13:46 |
| gary_poster | benji: https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/EditingRound2 | 13:47 |
| benji | gary_poster: http://pastebin.ubuntu.com/593990/ | 13:47 |
| gary_poster | https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/EditingRound2/Slide1 | 13:48 |
| gary_poster | https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/EditingRound2/Slide3 | 13:48 |
| danilos | gary_poster, thanks, I am looking at it (yes, we do need args for the actions, but most of the times, stuff in vars should be usable because it contains teams/pillars/duplicate_bugs) | 13:53 |
| gary_poster | yeah, thought that but it is for a different purpose. Whatever, we can tweak that | 13:54 |
| gary_poster | on call with benji now | 13:54 |
| danilos | gary_poster, right | 13:56 |
| danilos | gary_poster, fwiw, I like what your approach looks like (the nitty-gritty details of parameter passing left to the side :) | 14:10 |
| gary_poster | great danilos | 14:10 |
| bac | gary_poster: i think the problem is related to muting and i am not seeing it locally b/c i didn't have that feature flag turned on | 14:17 |
| bac | will know in a bit if that is the case | 14:17 |
| gary_poster | ah! makes sense | 14:17 |
| bac | can't find 'mute_link' on the page i think | 14:18 |
| * danilos -> lunch | 14:19 | |
| gary_poster | danilos, cool, ping me when you are around. | 14:25 |
| gary_poster | mute_link: sounds promising | 14:25 |
| bac | gary_poster: i can replicate it locally now which means i can fix it | 14:28 |
| bac | gary_poster: i totally forgot about the *other* feature flag. | 14:28 |
| gary_poster | heh, great | 14:29 |
| danilos | gary_poster, hey, back | 14:36 |
| gary_poster | cool danilos, 1 sec, lemme fix a test :-P | 14:36 |
| danilos | gary_poster, okay, okay, I am letting you! :) | 14:37 |
| gary_poster | lol | 14:37 |
| gary_poster | ok only five failing now :-P | 14:37 |
| gary_poster | danilos, Skype? | 14:38 |
| danilos | gary_poster, yep | 14:38 |
| danilos | mumble has been crazy for me even with the new headset | 14:38 |
| benji | we should probably unify the feature flags; I guess if we remove them both soon that'll be unified enough | 14:50 |
| bac | gary_poster: got a sec for a quick call? | 15:50 |
| gary_poster | sure bac | 15:50 |
| gary_poster | bac, on skype and ready; call when you wanna | 15:51 |
| gary_poster | danilos, diff not there yet, but https://code.launchpad.net/~gary/launchpad/bug728370-direct-subs/+merge/57703 | 16:13 |
| danilos | gary_poster, cool, thanks | 16:14 |
| bac | gary_poster: in the subscribe overlay, that html is created via a zope Choice field with a vocabulary. the Choice is the one adding the colon. | 16:18 |
| gary_poster | bah, bac :-/ | 16:32 |
| danilos | gary_poster, r=me | 16:46 |
| gary_poster | cool thanks danilos. Do you know if JS tests are being run in buildbot again? | 16:47 |
| gary_poster | or in ec2 | 16:47 |
| danilos | gary_poster, I know windmill tests were enabled then disabled again few days ago | 16:48 |
| danilos | gary_poster, are these other tests run at all? | 16:48 |
| gary_poster | I thouht they were run in windmill, yeah | 16:48 |
| danilos | gary_poster, hum, I don't know about that, I was under the impression that they are not, it'd be great if they are | 16:49 |
| gary_poster | danilos: multiple variable defs in a single var: I thought that was a good thing? | 16:49 |
| gary_poster | I see the bad indent--can fix, but want to hear about the multiple vars in a var first :-) | 16:50 |
| gary_poster | (same bad indent copy and pasted several times) | 16:51 |
| danilos | gary_poster, well, multiple of us feel they are bad, I think bac reviewed one of my branches and commented on them when I moved them around; generally, with multiple vars, you can't reuse previous vars, and it's easy to mess up with commas, semicolons and such | 16:51 |
| gary_poster | hm | 16:52 |
| danilos | gary_poster, not a biggie though | 16:52 |
| gary_poster | the linter prefers them | 16:52 |
| danilos | gary_poster, it does? | 16:52 |
| gary_poster | can't reuse previous vars? | 16:52 |
| gary_poster | Crockford's | 16:52 |
| bac | danilos: i don't think that was me | 16:52 |
| danilos | gary_poster, well, you can't say "var a=4, b=a+5;" | 16:53 |
| gary_poster | huh...I did redefine a var in that branch | 16:53 |
| danilos | bac, sorry! but, what's your take on multiple vars in a var statement? :) | 16:53 |
| gary_poster | to fix a test failure | 16:53 |
| danilos | (I don't have a strong opinion *at all*) | 16:53 |
| bac | danilos: it seems to be a common JS idiom | 16:54 |
| gary_poster | (so, equivalent of var a=5, a=a+4) | 16:54 |
| bac | danilos: so i have not had a strong opinion either | 16:54 |
| gary_poster | danilos, I'll just fix indent for now. | 16:54 |
| danilos | gary_poster, sure thing | 16:55 |
| gary_poster | thank you again for review | 16:55 |
| danilos | gary_poster, not sure what you mean with "equivalent", doesn't look equivalent to me :) | 16:55 |
| gary_poster | danilos, I mean, I redefined a variable in terms of itself, as defined within that var, and the example is equivalent to what I described and what I did | 16:56 |
| danilos | gary_poster, ah, right | 16:56 |
| danilos | gary_poster, anyway, good to land, my prettyfication branch is landing as well, and I am off now :) | 16:58 |
| gary_poster | cool thanks danilos. ttyl | 16:58 |
| gary_poster | benji, if I run make lint is that supposed to run the js linter? | 16:58 |
| bac | hi gary_poster, AFAICT none of the direct subscription / mute JS functionality has tests. how do you want me to proceed? | 17:34 |
| bac | adding new tests would be great but time consuming. making this fix as-is, is not so great but no worse than we currently have. | 17:35 |
| bac | gary_poster: https://code.launchpad.net/~bac/launchpad/bug-760121/+merge/57726 with no tests | 17:51 |
| * bac -> lunch | 17:51 | |
| === Ursinha is now known as Ursinha-afk | ||
| benji | gary_poster: yep; make lint has run the js linter recently at least | 18:45 |
| gary_poster | ok, thanks benji | 18:46 |
| gary_poster | bac, approved with some relatively small caveats. | 18:52 |
| bac | gary_poster: thanks for the review. very reasonable. | 19:13 |
| gary_poster | cool bac, np | 19:13 |
| gary_poster | benji, did you already start with danilo's prettification branch (lp:~danilo/launchpad/bug728370-descriptions)? If not, I suggest merging it | 19:25 |
| benji | gary_poster: thanks, will do | 19:25 |
| bac | gary_poster: call? | 19:30 |
| gary_poster | benji, I can have a call anytime between now and 4-ish. I have to leave @ 4:05. I'll be back and working more later this evening, but not sure when. So anyway, if you want o have a call soon, that would be cool. | 19:52 |
| benji | gary_poster: k, how about at the top of the hour | 19:53 |
| gary_poster | sounds good, thanks | 19:53 |
| gary_poster | bac or benji, could you confirm at some point that https://launchpad.dev/firefox/+milestone/1.0 does not work for you, at least when you are logged in as celso.providelo@canonical.com:cprov? No rush, going to volunteering mtg and back later | 21:08 |
| gary_poster | sorry, I mean that the "Subscribe to bug mail" link shows up but does not do anything when you click on it | 21:08 |
| gary_poster | the handler does not appear to be installed, because you go to "#" | 21:09 |
| gary_poster | back soon-ish | 21:09 |
| benji | gary_poster: confirmed | 21:14 |
| benji | I wonder if it's intentional that if you visit https://bugs.launchpad.dev/tomcat/+bug/2/+subscriptions you're told the same reason three times. | 21:30 |
| gary_poster | Thanks benji. Another bug to add. Reason three times: I see three reasons, two of which are identical (Ubuntu Tomcat is different). I suspect the two identical ones are a display issue: if you look at the bug then you'll see Hoary and Woody are there--I bet they are the source. | 21:39 |
| benji | gary_poster: you're right, only two of the three are the same; do you want me to file a bug? | 21:40 |
| benji | (or perhaps just a card) | 21:40 |
| gary_poster | benji, thank you, but I'm already making a card for that one, since the project is in progress. I'll file a bug for the milestone thing and make a card for it also. | 21:41 |
| benji | k | 21:41 |
| benji | ok, I've had enough JS for today | 22:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!