| === Ursinha-afk is now known as Ursinha | ||
| benji | Yellow Slug Video of the Day: http://www.kqed.org/quest/television/science-on-the-spot-banana-slugs-unpeeled | 13:01 |
|---|---|---|
| danilos | benji, the URL itself kinda scares me | 13:17 |
| benji | heh | 13:17 |
| benji | for a nature segment it is a little violent sounding, but be comforted that no banana slugs were harmed during the filming | 13:18 |
| gary_poster | it has comforting guitar music | 13:19 |
| gary_poster | "the unsung hero of this forest comunity" | 13:19 |
| gary_poster | "eating fallen plants and even dead animals" | 13:20 |
| gary_poster | (more comforting guitar music | 13:20 |
| gary_poster | ) | 13:20 |
| bac | Yellow Squad -- we poop dirt | 13:20 |
| gary_poster | It's great contribution is that it enriches the soil (presumably be defecating) | 13:21 |
| bac | hey, and they are hung hermaphodites | 13:21 |
| gary_poster | mm, the largest male sex organ...but a hemaphrodite... | 13:21 |
| gary_poster | lol | 13:21 |
| bac | gary_poster: i think we hit play at the same time | 13:21 |
| gary_poster | I think so too :-) | 13:21 |
| gary_poster | mm, comforting music has switched to piano.strings | 13:22 |
| gary_poster | mm...slime... | 13:23 |
| bac | gary_poster: did you see bug 761257. :( | 13:23 |
| _mup_ | Bug #761257: Advanced subscription overlay does not handle unsubscribing teams <Launchpad itself:Triaged by yellow> < https://launchpad.net/bugs/761257 > | 13:23 |
| danilos | gary_poster, benji :) | 13:23 |
| gary_poster | I did not bac...this must be about direct subscriptions, yeah? | 13:24 |
| gary_poster | bac benji danilos, will look at kanban in a munite, call in 5-ish | 13:25 |
| gary_poster | minute | 13:25 |
| bac | gary_poster: yes. bug title updated. | 13:26 |
| gary_poster | thanks bac. I'll adda backlog defect card too | 13:27 |
| bac | gary_poster: i put a card in FW1 | 13:27 |
| gary_poster | oh ok cool | 13:27 |
| gary_poster | good enough | 13:27 |
| gary_poster | thanks | 13:27 |
| bac | https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/EditingRound2/Slide1 | 13:37 |
| danilos | anybody seen the south park episode about a "dream inside a dream within a dream"? :) | 13:46 |
| danilos | gary's mention reminded me of that | 13:46 |
| gary_poster | benji, my impression was that you thought you were comfortable without further discussion. If you do want to talk, just lemme know. | 14:15 |
| benji | gary_poster: a call would be good | 14:17 |
| gary_poster | benji, cool | 14:17 |
| gary_poster | benji, call me when you are ready | 14:17 |
| gary_poster | just encountered one of those integration errors we have been rightly worried about. I wrote a JS test for a change, and it failed, and then fixed the code, and all tests passed...and then actually tried using the thing for some QA and I had screwed up the server request we make. :-/ | 16:34 |
| gary_poster | ...it appears to be at least two bugs in one... | 17:20 |
| gary_poster | not related to my change :-/ | 17:20 |
| gary_poster | but I can't verify my fix via QA until they are fixed | 17:21 |
| gary_poster | apparently patching a team bug doesn't work in some cases that I don't understand yet | 17:21 |
| gary_poster | and apparently deleting a newly created filter doesn't work in some cases that I don't understand yet | 17:21 |
| gary_poster | patching a team filter I mean | 17:23 |
| benji | maybe a security problem? i.e., you have permission to create a team filter but not update/delete it? | 17:24 |
| gary_poster | yes, that's the first problem--Unauthorized--but pretty weird since we have been able to edit team filters on the other page. Have not found source of that one yet. The deleting a newly created filter I see and can fix, I think. Doing that now, and then will look at Unauthorized | 17:25 |
| gary_poster | ah, interesting. it is something specific to rosetta admins | 17:31 |
| gary_poster | danilo, what are you doing still here? :-) | 17:33 |
| danilos | gary_poster, heh, trying to get a few more tests done, got side-tracked with crashing desktop :( | 17:33 |
| gary_poster | danilos gotcha :-( | 17:33 |
| gary_poster | danilos don't work too late. | 17:34 |
| danilos | gary_poster, I won't, just a few more of these and I'll be handing off | 17:34 |
| gary_poster | ok cool | 17:34 |
| gary_poster | oh, weird | 17:37 |
| gary_poster | this person, Foo Bar, #1 is listed in the JS as an admin of Rosetta Administrators but that is not listed in https://launchpad.dev/~name16/+participation , and # 2 was able to create a filter for that team, but not delete or patch it. | 17:38 |
| gary_poster | oh, weirder | 17:39 |
| gary_poster | person is a member of the team that owns the team, but not an active member | 17:39 |
| gary_poster | that scenario sinks our battleship | 17:40 |
| gary_poster | and that's a valid scenario | 17:41 |
| gary_poster | if weird | 17:42 |
| gary_poster | so it looks like either the code we have that inserts teams-of-which-you-are-an-administrator needs to intersect with teams-of-which-you-are-a-member | 17:42 |
| gary_poster | or if you are an administrator then you should be able to patch and delete a subscription | 17:43 |
| gary_poster | I lean towards the second solution, though I wonder how it will pan out to implement | 17:43 |
| * gary_poster is going to take a break, though will be around | 17:47 | |
| danilos | gary_poster, oh, I've seen that with rosetta-admins, forgot to add a card; basically, it should not be listed in administratedTeams | 17:51 |
| gary_poster | danilos, you think? | 17:51 |
| gary_poster | I gave the two options above | 17:51 |
| gary_poster | you think not administrated is better than allowing them to patch/delete because they are owners? | 17:51 |
| danilos | gary_poster, well, all the web service calls fail, perhaps that | 17:51 |
| gary_poster | except they can create | 17:52 |
| danilos | gary_poster, I haven't thought closely about it, to be honest :) | 17:52 |
| gary_poster | :-) | 17:52 |
| gary_poster | it would probably be easier to not list them | 17:52 |
| gary_poster | so under the circumstances, maybe that's the right thing to do for right now | 17:52 |
| danilos | gary_poster, yeah, we can always file a bug to let someone else handle it later :)) | 17:53 |
| gary_poster | woo hoo! :-) | 17:54 |
| danilos | gary_poster, I am out, you've got email in your inbox, my branch is up at lp:~danilo/launchpad/bug728370-action-display and I left you with the hardest tests to write (those for on-click handler :)) | 18:50 |
| danilos | gary_poster, other than that particular test, I think it's pretty complete | 18:50 |
| gary_poster | danilos, lol, cool thanks | 18:50 |
| gary_poster | have a great weekend! | 18:50 |
| danilos | cheers, so do you! | 18:50 |
| gary_poster | bac, a branch when you have a moment: https://code.launchpad.net/~gary/launchpad/bug761798/+merge/57922 | 19:02 |
| bac | gary_poster: ok | 19:02 |
| gary_poster | thanks | 19:02 |
| bac | gary_poster: working on a large branch now but you're next | 19:03 |
| gary_poster | thanks bac, no rush | 19:03 |
| benji | gary_poster: what do you thing about this scaffolding for the direct actions? http://pastebin.ubuntu.com/594581/ | 19:34 |
| * gary_poster looks | 19:34 | |
| benji | I need to add tests and fill in the unmute action next or if someone's ready to contribute an action I can push this to a branch for them to work from. | 19:35 |
| gary_poster | danilos handed off to me, so I'm booked now; sounds like bac is also booked for awhile yet. Tests sound like the next thing to work on, yeah | 19:37 |
| * gary_poster still looking | 19:37 | |
| gary_poster | benji, still looking, but first thought worth sharing: there are two variations for unsubscribe in the mockups: unsubscribe, and unsubscribe with warning (because there are other subscriptions). That will need to be modeled somehow (and I don't think it is yet). | 19:40 |
| gary_poster | You could do that with another node... | 19:41 |
| gary_poster | kinda sorta | 19:41 |
| gary_poster | doesn't quite fit in with the current setup | 19:41 |
| benji | ah, I missed the with-warning flavor; I think I can add that without too much trouble | 19:42 |
| gary_poster | cool | 19:42 |
| gary_poster | benji, looks like a good start to me. Cool, yay, thanks! :-) | 19:43 |
| benji | very good | 19:43 |
| gary_poster | (by good start, I mean, good scaffolding, not good start on the scaffolding) ;-) | 19:43 |
| benji | (yep, I understood) | 19:48 |
| === Ursinha is now known as Ursinha-afk | ||
| bac | gary_poster: i'm a little confused by all of the indirection in your branch wrt clean_up. | 20:22 |
| bac | where is the actual fix to the early closing problem? | 20:22 |
| gary_poster | bac, maybe I should have tried harder to clean it up. er. The actual fix is that clean_up can't be called after it initially calls the handler. The handler has to call it on success, eventually. | 20:24 |
| gary_poster | The extra indirection is because sometimes success isn't true success unrtil after two web calls. | 20:24 |
| gary_poster | Let me look at it again and see if I see a way to simplify... | 20:24 |
| bac | ok, so line 114 of the diff is the good part | 20:25 |
| gary_poster | bac, well, we have to do it in two scenarios. So, yeah, 114, and also... | 20:26 |
| bac | gary_poster: i wasn't implying it was unnecessarily confusing...just that i was confused | 20:26 |
| gary_poster | also 60 | 20:26 |
| gary_poster | no, np bac, I kind of thought that it maybe could have been simplified but this worked and I wanted to get back to the other task. Actually, I think clean_up can be defined as a module-level function and not passed around | 20:27 |
| gary_poster | That would make things cleaner. | 20:27 |
| gary_poster | Let me try that. | 20:28 |
| bac | gary_poster: it would, as it seems to be a hot potato atm | 20:28 |
| gary_poster | yeah | 20:28 |
| gary_poster | bac, I did this: http://pastebin.ubuntu.com/594603/ . Pushed to public branch and waiting on diff change... | 20:35 |
| bac | gary_poster: i think that's much clearer | 20:36 |
| gary_poster | cool, thank you bac | 20:36 |
| gary_poster | bac, I considered your add_subscription_overlay approach but I felt it would have been more fragile: when code changed the local variable, it would have needed to be sure that it also changed the namespace version in order for the tests to be reliable. I felt that always getting the overlay from the namespace was a cheap cost for that reduction in fragility. Therefore, fwiw, I intend to leave it as it is. | 20:42 |
| gary_poster | thank you for the review! | 20:43 |
| bac | gary_poster: not to belabor the point, but wouldn't the test break if the names were changed out from under it? | 20:47 |
| bac | it is a idiom we use in that module | 20:47 |
| gary_poster | bac, it depends on how that name were set, and even if it is cleaned up across test runs | 20:47 |
| gary_poster | it might very well work now | 20:47 |
| gary_poster | getting it from the namespace also simply didn't bother me in the slightest | 20:48 |
| gary_poster | I'm guessing you don't feel differently enough to make a point of it, since you didn't do so in the review. Had you, I would have complied, because even though I feel comfortable with what I did, I don't feel strongly about it either. | 20:49 |
| bac | gary_poster: i'm going to take the dog for a walk. will be back later. have a good weekend | 21:18 |
| gary_poster | you too bac. bye | 21:18 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!