/srv/irclogs.ubuntu.com/2011/04/19/#launchpad-yellow.txt

=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
gary_posterhey benji  sorry for the email dump last night13:09
gary_posteryou ok with that merge, and doing that review13:10
gary_poster?13:10
benjiheh, np; reviewing the branch now13:10
gary_postercool thank you13:10
gary_posterI have just over an hour to work this morning before heading out to the dr13:11
gary_posterthen back after lunch13:11
gary_posterbac, I wonder if get_node_for_unsubscribing in subscription.js might help you.  No worries if not, but if so, it does a lot of good stuff and is already well tested.13:21
bacgary_poster: thanks for the suggestion13:21
gary_posternp13:21
bacgary_poster: there is also stuff in bugtask_index_portlets.js that may be useful if i refactor13:22
gary_posterbac, true, though AFAICT that stuff is not tested at all13:22
gary_posterbut whatever works, of course13:23
bacurgh13:23
gary_posteryeah13:23
gary_posterbac benji, I'll look at kanban in a moment, and call in 413:27
gary_posteroops13:30
gary_posterbac benji you are not on Skype?  maybe bac is13:32
gary_posterhaving Skype UI issues13:32
benjiwell I thought I was13:32
baci is13:32
benjigary_poster: am now13:33
benjigrr; that's two days ina row13:33
benjibac: bzr+ssh://bazaar.launchpad.net/~gary/launchpad/direct-personal-subscription-actions/13:42
* gary_poster didn't give anyone opportunity to say stuff13:49
gary_postersorry13:49
benjinp13:49
baccan we standardize on  Y.Node.create('<div/>') vs  Y.Node.create('<div></div>') ?13:51
gary_posterbac, benji, +113:51
bacthe former actually renders a proper div, though you cannot have a self closing <div>13:51
benji+113:52
bacbut it is less typing13:52
bacso you may do it in JS but not in a page template13:52
benjiI was hoping that Y.Node.create('div') would do the right thing, but it doesn't.13:52
gary_posterI generally think benji's recent experiments are a great way forward.  One tweak I've wondered about is setStyles({...}) rather than setStyle setStyle setStyle13:53
gary_posterless typing and still readable I think13:53
benjiI figured that several single-line calls were better than the nesting required for the multiline call, but it's probably more a difference of taste.13:54
gary_posterhm, interesting13:54
gary_posterI haven't actuyally looked at the diff, just thought of it13:54
gary_posterand thought about typing less ;-)13:55
benjisince it's going to be the same number of lines either way13:55
benjitab completion, man ;)13:55
gary_posterheh13:55
gary_posterdoesn't help with quotes13:55
benjioh, if you use an editor with abbreviations: I bound "ync" to "Y.Node.create" which for some reason is hard for me to type quickly13:56
gary_posteryeah, it does go on forever13:56
benji"quotes"?  oh, the fact that uou don't have to put quotes around the mapping keys, yeah, that is a vote in the setStyles column13:56
gary_posteryeah, I set up abbreviations and then I don't use them :-/13:56
gary_poster(yeah, that's what I meant)13:57
benjiI only add one at a time (no matter how many I think I want) that way I only have one to learn at a time.13:57
gary_postergood idea13:58
benjiThat's the same rule I use for learning vim features, any more than that and your head explodes.13:58
gary_poster:-)13:58
benjigary_poster: I'm done with https://code.launchpad.net/~gary/launchpad/direct-personal-subscription-actions/+merge/58216; I included a patch to change the things I whined about14:16
gary_posterthank you benji!  I'll see if I can get that out before I go14:16
gary_posterbac, benji, the branch that we said we would base off of is now updated with the patch that benji provided in his review.  You might want to update.  I'm submitting it through ec2 land now.14:26
gary_posterAlso, I only got started on making a helper function14:26
gary_posterhttp://pastebin.ubuntu.com/596028/14:26
gary_postershows what I did14:26
gary_posterI focused on what I nbeed14:26
gary_posterneed14:26
bacok14:26
benjik14:27
=== Ursinha-afk is now known as Ursinha
gary_posterThe helper function that I mentioned for bac does not clean up properly; it's possible that we ought to make that function above generic...or maybe make a clean up/redraw function that we all use14:27
bacgary_poster: you mentioned on the call about using strings for the actions for all but unsubscribe.  what were you referring to?  i don't see it.14:27
gary_posterbac return make_action('remove-direct-subscription')14:27
gary_posterbut it is now fixed thatnks to benji's patch14:28
* bac looks14:28
* bac re-merges14:28
* gary_poster running14:28
gary_posterttyl14:28
benjibac: is lib/lp/contrib/javascript/yui3-gallery/gallery-accordion/gallery-accordion.js a straight vendor import or have we made changes to it?  I'm asking because I'm deciding whether or not to include it in my delinting.17:09
gary_posterbac, benji, where are we?  Should I continue with my patch, or has someone run with it while I was out?18:06
benjigary_poster: nope, I've not18:08
gary_posterok thanks.  bac is biking I guess.  I'll run with it a bit more18:08
gary_posterbenji, it's conceivable that, with the helper I've written, the implementation of the mute action becomes18:35
gary_poster        .appendChild(18:35
gary_poster            make_action_link(18:35
gary_poster                'mute all emails from this bug',18:35
gary_poster                 'no', 'mute', {}));18:35
gary_postersimilarly for unsubscribe, actually18:36
benji[coming back from llunch] sounds good; I'll be done with this in a minute and I'll start on one of the actions18:39
gary_posterok...I might have done all of the actions...18:39
benjiheh18:40
benjiI'll take the afternoon off then.18:40
benji:P18:40
gary_posterheh18:40
gary_posterlemme see if this works18:40
gary_posterbenji, do you have advice for building node text like at the bottom of https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/Testing/EditingRound2/Slide1 ?18:41
* benji looks18:41
gary_posterYou can also <link node>.  However...18:41
gary_posterIOW, how do you suggest dealing with the whitsepace-eating18:41
gary_posterI wonder if you or bac knows what the story is with the breadcrumbs in that mockup18:42
gary_posterI'd like to have a link to the bug18:42
benjigary_poster: I've used gratuitous <span>s in the past, which worked ok; I experimented with replaceing the leading and trailing spaces iwth &#32; but it was too ugly to live18:45
gary_poster qqheh18:45
gary_poster-qq18:45
benjigary: bad option -q18:46
gary_poster:-)18:46
gary_posterspan around whitespace?18:47
gary_poster.append('<span/>').set('text', ' ')?18:48
benjiI was doing it before I entered my tags-only-in-Y.Node.create period, so I was doing .append('<span> words </span>'), but I bet setting the text will work too18:49
gary_posterso .append('<span/>').set('text', ' words ')18:50
benjito clarify: span around the words and leading trailing whitespace18:50
benjiright18:50
gary_posterI can give it a try18:50
benjianother thing I'd like to settle on is whether or not we should use Y.Node.create when using the <tag/> approach18:51
=== Ursinha is now known as Ursinha-lunch
gary_posterwhy would we not?18:51
gary_postergrr, direct-personal-subscription-actions tests failed--and it looks like for reasons having nothing to do with my branch. :-/18:52
benji:(18:53
gary_posterbenji, so that's two crucial tasks, one of which you can take18:53
gary_posterwhen you are ready18:53
benjik18:53
gary_poster1) run with the branch I am working on now18:53
gary_poster2) figure out what is up with that failing branch18:53
gary_posterand fix18:53
benjik18:53
bacbenji: do not delint anything in lp/contrib18:58
benjibac: k, thanks18:58
bacgary_poster: i worked with your branch some and got a link for unsubscribe to render.  it isn't polished but POC18:59
bacgary_poster: btw, your branch was throwing an error b/c one of the reductions was null18:59
gary_posterbac, cool.  I think I may have a "one function to rule them all" kind of thing18:59
gary_posterbac, huh, I wonder why the tests didn't catch19:00
gary_posterok so all three of us are here19:00
gary_posterthese are the tasks I know of19:00
bacdunno.  i added a few subscriptions to bug/1.  to get it to work i had to get the node and check that it wasn't null so i could proceed with my work19:00
gary_poster1) try to figure out why the branch I tried to land had all kinds of unrelated errors (bad merge?  bad devel at the time I ran the test?)19:01
gary_posterand try to land it again19:01
gary_poster2) try to see if the "one function to rule them all" for the actions will work.  I'm at the "see if it will work" stage; it is sketched.  after it works, it will need tests19:02
gary_posteractually it also needs a story for transitions19:02
gary_poster(after you click something and it successfully changes state, redraw the pertinent parts of the page)19:02
gary_poster3) figure out the problem bac described and fix19:02
gary_poster4) lots of other cleanup & bugfix cards on the board19:03
bacgary_poster: so your #2 will make the little work i've done obsolete?  yippie if so19:03
gary_posterThen we have one more must-have green card on the board but I want us to have this card done before we look at it19:03
gary_posterbac, yes19:03
gary_posterand sorry...it's why I showed that function earlier, before I left19:04
gary_posterit's that functon with a few more variables19:04
gary_posterI needed it for unmute19:04
gary_posterwhich then looked pretty much the same as what we needed for everything else, AFAIK19:04
bacok19:04
gary_posterbac, I'm willing to hand off my current branch, but I'd like it to work so that I know I'm not handing off a POC myself19:05
gary_posterso I want to run with it a bit farther at least19:05
gary_postermeanwhile you could investigate #3?19:05
bacgary_poster: sounds good19:05
gary_posterok thanks19:05
bacgary_poster: will do19:06
gary_postercool19:06
bacgary_poster: just so you'll know where it was, this is one of the two changes i made:19:07
bac        direct_node.one('.reductions').removeClass('hidden');19:07
bac        for (i=0; i<direct_info.reductions.length; i++) {19:07
bacbut i'll look into it19:07
gary_posterI don't see the change19:08
gary_posterI mean, I see the code19:08
gary_posterwhere it is19:08
bacthe test for null19:08
bacotherwise it was dying with a null object19:08
gary_posterso what does the code look like after your change?19:09
bacdirect_node.one(...).removeClass()19:09
bacboom19:09
gary_posterhuh19:09
gary_posterthat reductions node should always be there19:09
gary_posterthat was my intent I mean19:09
bacok, at the time it was just in my way so i didn't investigate19:10
bacnow it is my task so i'll figure it out19:10
gary_posteryeah np19:10
gary_posterok, the basics all seem to work.  we need to redraw, and we need tests19:24
gary_posterand we need to tweak presentation19:24
benjigary_poster: ok, my lint branch is in the review queue; point me at my next victim19:25
gary_postergreat, benji.  your choice.  I have the branch I've been working on, which now works, and you can see the intent pretty easily, and has the three tasks I listed above; or you can investigate why the dependent branch from this morning did not land19:26
gary_posterI'm happy for you to take either of those19:26
benjiit seems that figuring out why the branch went south would be best19:26
gary_posterok benji.  Thank you.  I'll forward you the email19:26
gary_posterbenji, attachments make the email 21.9 MB.  Do you want me to send it to you, or send just the text and put the attachements for you on devpad later if you want them?19:28
benjisend it on, I can take it19:28
gary_posterthat's weird19:28
gary_posterok19:28
gary_posterthe body, not the attachments, might be the space hog.  I guess because, even though it has less info, it is uncompressed19:29
gary_posterbenji, the mail just made it through the pipes on my side. :-)19:31
benjithanks19:31
benjigary_poster if you or bac have a second, there's no OCR right now and I don't want my lint branch to rot: https://code.launchpad.net/~benji/launchpad/lint/+merge/5837119:32
gary_posterbac, are you ok with that task?19:32
bacbenji: i can do it19:32
gary_posterthank you19:32
benjithanks19:32
benjigary_poster: I got your email.  My laptop seems heavier.19:34
gary_posterheh19:34
bacbenji: just a question, but is there any compelling reason to prefer v === null vs Y.Lang.isNull(v)  and the same for isValue?19:36
baci've had reviewers push me towards the Y.Lang versions19:36
benjibac: not that I'm aware of; the fact that Y.Lang.isNull exist suggests that it's better19:36
bacyeah, you'd hope so19:37
gary_posterhee hee19:37
bacbenji: why the change at line 610 of the diff?19:41
benjibac: jslint doesn't like it when you use a symbol for the first time while in the definition of the symbol19:42
benjiit gives some message like "foo used before it is fully defined"19:43
bacoh, ok19:43
bacbenji: done19:46
benjicool, thanks19:46
benjiwell, gary: I can certainly reproduce the errors from the email.  Now to figure out why they're there.19:48
gary_posterack, benji.  I assume buildbot does not show any problems like that?  And are there differences in unexpected files if you diff with devel?19:55
benjigary_poster: nope, only lib/lp/bugs/javascript/subscription.js and lib/lp/bugs/javascript/tests/test_subscription.js are different relative to devel19:56
gary_posterwow19:57
gary_posterand devel is not failing similarly?19:57
benjiI'll know in a minute.20:00
benjigary_poster: oooh, devel failed in the same way20:01
gary_posterah :-/20:01
gary_posterand buildbot is happy??20:01
benjithat's hard to say20:02
benjithey're red, but I haven't found the actual test output yet to see if it's the same thing20:03
gary_posterbenji, https://lpbuildbot.canonical.com/builders/lucid_lp/builds/860/steps/shell_6/logs/summary20:03
gary_poster(it's the "summary" link in the waterfall)20:03
benjimy browser is giving me fits; grey screen of locky-upness20:03
gary_poster:-(20:03
gary_postersample looks familiar:20:04
gary_posterValueError: ('Undefined permission id', <Distribution 'Distribution601950' (distribution601950)>)20:04
gary_posterhenning thinks he has fixed it20:04
gary_posterthere is still an error :-(20:05
gary_posterat least one20:05
gary_posterComponentLookupError: (<lp.registry.model.distributionsourcepackage.DistributionSourcePackage object at 0x1632a190>, <InterfaceClass canonical.launchpad.webapp.interfaces.IAuthorization>, 'launchpad.Edit')20:05
benjiyep, I thought someone was working on that; it was fall-out from henninge refactoring something that wasn't tested20:05
gary_posterand he landed it without running all tests on ec2?20:05
gary_postermeh :-/20:05
gary_posterok, well, there goes your task ;-)20:06
benjihe said something about ec2 tricking him20:06
gary_posterheh20:06
* benji makes finger guns and says "pew! pew!"20:06
gary_posterlol20:07
* benji feels a little silly today, obviously.20:07
gary_posterbenji, I might have a way for us to collaborate later, but for now "Fix for 753152..." or...20:07
gary_posterbook Dublin travel :-P or...20:07
benjiactually, I think there is something I can do travel-wise, then I'll look at 75315220:07
gary_posterok cool20:08
=== Ursinha-lunch is now known as Ursinha
bacgary_poster: it looks like the changes i made to unsubscribe_action were causing the problem with reductions20:25
bacgary_poster: so #3 is probably a non-issue20:26
gary_posterok cool20:28
gary_posterbac, any other cleanup card calling your name on the board?  I can highlight some20:28
gary_posteractually, bac20:28
gary_posterwell, if you wanna or if benji wants to, there's the task of trying to make the boxes and stuff look prettier20:29
gary_posterfor the direct actions we are working on now20:29
gary_posteranothr very small task probably20:29
bacok.  i was admiring how ugly they are20:29
gary_posterlol20:29
bacgary_poster: how shall i deliver fixes?  give you a branch to merge?20:34
gary_posterbac, sure, I guess20:34
gary_posterbac, or just make a branch based on the other one20:35
bacyou mean yours?20:35
gary_posterwe won't be able to land until that branch is dealt with20:35
gary_posteryeah20:35
bacyes, i'll branch devel, merge from gary, and make my fixes20:35
gary_postercool sounds good20:35
gary_posterthanks20:35
gary_posterthen you can land after mine20:35
gary_posteror I can merge20:36
gary_posterwhatever20:36
bacbut i didn't figure they would be landable independently.20:36
bacrighto20:36
gary_posterbac, benji, lp:~gary/launchpad/direct-personal-subscription-actions-subscribe has all actions working, with a crude redraw after each successful change21:03
gary_posterI have a call with flacoste now21:03
benjicool!21:04
gary_posternext tasks: tests, make look pretty21:04
gary_postertests should probably be in this branch21:04
gary_posterpretty can be later21:04
gary_posterwe need to update state better after other subscriptions21:04
gary_posterbut we can do that in another card too21:04
gary_posterso anyway21:04
gary_posterbenji, if you want to claim the branch and run with it, cool.  if you want to leave it for me when I get back, cool21:05
benjik21:05
gary_posterbenji, did you run with it or should I continue?21:44
* gary_poster continuing21:45
benjigary_poster: right, you shoudl continue21:46
gary_postercool21:46
benjigary_poster: I'm doing something wrong on this "fix for 753152" thing; I can't repro in a db-devel checkout and I can't get qastaging to show me the link that has the help on it at all21:47
gary_posterbenji, qastaging won't have the db dif21:47
gary_posterbenji, only staging21:47
benjigrr; I still don't understand all those moving pieces21:48
gary_posterqastaging = stable, staging = db-stable21:48
gary_posterbut understood :-)21:48
benjiI'm writting that in my notes.21:49
gary_poster:-)21:49
benjigary_poster: ok, I can't repro in staging either; the link opens in the little help box just like it should21:49
benjiyou should see the same thing when you visit https://bugs.staging.launchpad.net/launchpad/+bug/708258/+subscriptions21:50
_mup_Bug #708258: Failed to parse comment sent via email <code-review> <email> <questions> <Launchpad itself:Triaged> < https://launchpad.net/bugs/708258 >21:50
gary_posterhuh, I don't see the help link at all on staging21:50
benjigary_poster: did you hover?21:51
gary_posterI appear to floating off the ground several feet!!21:51
gary_posterbe21:51
benjilol21:51
gary_posterbut yes, mouse went over link21:51
benjiFF3 I presume21:52
gary_posterChrome21:52
benjioh, let me try that21:52
gary_posterconfirm in works in FF421:53
gary_posterit21:53
benjiYay! It doesn't work in Chrome.21:54
gary_posterdoes not work in Safari either, somewhat unsurprisingly21:54
gary_posterheh21:54
gary_posterThat's a new, different bug than the one I saw before21:54
gary_posterbut if it's easy to fix, we can pretend that's the bug ;-)21:54
benjipfft; ok21:55
bacgary_poster: i'm not the best CSS person, but i'm at a loss why i can't separate the reason from the border box21:56
bacon the reason span i've added padding-bottom and margin-bottom but it doesn't move the box.21:56
gary_posterbac, try display:block?  or put it in a div instead?21:57
benjithat's probably it; spans don't have padding21:58
bacbenji: ah, thanks22:01
bachi gary_poster, is this what you wanted or something more drastic?22:21
bachttp://people.canonical.com/~bac/prettier.png22:21
gary_posterbac, good.  how does it lok when there are both boxes (increases & reductions() around?22:24
bacgary_poster: dunno yet22:25
bacneed to figure out how to get increases22:25
bacif i mute i get increases only22:26
gary_posterbac, try subscribing at a medium level22:26
bacah, it looks like turd22:27
gary_posterheh, I thought so22:27
bachold, please22:28
bacgary_poster: better: http://people.canonical.com/~bac/prettier.png22:31
gary_posterbac, yeah, yay22:34
gary_postermight want to also check unsubscribe with warning22:34
bacok22:34
gary_posterI would have expected that to be shown there22:34
gary_posterdid you turn things on manually, or is this indicative of a logic error somewhere?22:35
gary_posterbac, benji, lifeless says that our squad needs to investigate https://bugs.launchpad.net/launchpad/+bug/766561 , dropping everything.  My impression of people's knowledge of this part of the codebase is (1) Danilo and myself; (2) Graham and Benji; (3) Brad.  On the basis of that22:47
_mup_Bug #766561: person in team A which is a subteam of team B not getting bug email for bugs team B is subscribed to <regression> <story-better-bug-notification> <subscribers> <Launchpad itself:Triaged> < https://launchpad.net/bugs/766561 >22:47
gary_posterimpression, I'm inclined to toss my branch to one of you, and take a look at that myself.  However, I'm happy to let one of you claim the bug if you like.22:48
bacgary_poster: to your previous question, i did not turn things on manually so if unsubscribe with warning should be shown and isn't i'd guess it is a bug22:50
gary_posterdarn, bac :-/22:50
benjigary_poster: I'm willing to take either, but won't be available until after feeding children (I'm down one wife for the evening).22:52
bacbenji: how many does that leave?22:53
benji:)22:53
gary_posterbenji, it doesn't have to be till tomorrow, unless you have extra hours left over for the day22:54
bacgary_poster: i can pick up your branch22:54
benjiI've considered adding a hot-spare but interoperability is an issue.22:54
gary_posterheh22:54
gary_posterbac, ok thank you22:54
benjiI'm hour-free at the moment.22:54
bacgary_poster: but i'm unsure what your roadmap was22:54
gary_posterbenji, then talk to you tomorry22:54
benjiI like your new accent.22:55
gary_poster:-)22:55
gary_posterbac, all that was left was to get current tests to pass, and then add tests for the new stuff I added22:55
gary_posterThere's prettification to be done, and probably other stuff, but I think that can wait to a later branch22:55
bacgary_poster: oh, if that's all i'll be done before dinner22:55
gary_poster:-P22:55
gary_posterbac, were you hoping for a test roadmap?  I didn't have one yet.22:56
bacgary_poster: you want to stop, push your branch, and point me to the failing tests?22:56
bacgary_poster: well, it would be nice to know what needed to be done at a little better granularity.  but i can quiz you tomorrow22:56
gary_poster:-)22:57
gary_posterok bac, how much more time do you have before eod?22:57
bacgary_poster: not much but i'll poke at it after dinner22:58
gary_posterbac ok thanks.  I'll send you an email in just a few then22:59
gary_posterthank you22:59
baccool22:59
* bac dinners22:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!