| gary_poster | bac, wgrant fixed the emergency bug, yay! I'm going to try and qa the fix, and then I'll be available. | 13:10 |
|---|---|---|
| gary_poster | Maybe we can divide up some tests then. I saw your email--I'm glad it was easy to fix those | 13:12 |
| gary_poster | benji, what's the gmail trick for infinite email addresses? gary.poster-foobar@gmail.com, was it (a hyphen and an additional string)? | 13:16 |
| gary_poster | here we go http://landonsheely.com/post/751726222/google-mail-aliases | 13:16 |
| benji | gary_poster: plus instead of hyphen | 13:16 |
| benji | (qmail uses hyphen) | 13:16 |
| gary_poster | thank you | 13:17 |
| gary_poster | ! | 13:17 |
| benji | np | 13:17 |
| benji | now you too will being to hate sites that think they know how to validate email addresses and won't let you have a plus in the mailbox part | 13:17 |
| gary_poster | heh | 13:18 |
| gary_poster | bac, benji, looking at kanban now, call in 3 | 13:27 |
| gary_poster | being unable to subscribe anyone on qastaging because of timeouts puts a real cramp on my ability to do qa :-/ | 13:54 |
| bac | gary_poster: since you put the SSD in your MBP do you ever see it not recognized at boot? kind of disconcerting. | 13:56 |
| gary_poster | bac, no. Then again, this is my wife's MBP and she doesn't reboot much at all. | 13:56 |
| gary_poster | it's also a hybrid actually | 13:57 |
| gary_poster | the only true ssd we have is on my MBP, and is Apple-installed | 13:57 |
| gary_poster | (and I have not had any problems with it so far) | 13:58 |
| bac | ah, ok | 13:59 |
| bac | upon a second reboot it is recognized so it isn't a real problem just a mild shock every time it happens | 13:59 |
| benji | I've been considering an SSD, it sounds like you guys like yours. | 14:01 |
| bac | benji: yeah, i do | 14:07 |
| bac | benji: it's the kind of thing that you being to take for granted though. mostly notice how fast it boots, which isn't often, but everything else is just quicker | 14:08 |
| bac | s/being/begin | 14:08 |
| gary_poster | yeah, I really like the SSD | 14:08 |
| benji | bac: which drive do you have? I've been leaning toward the Intel line. | 14:08 |
| bac | i leaned towards intel but then bought the OWC | 14:22 |
| bac | it was highly rated at the time | 14:22 |
| bac | i got the 256G | 14:23 |
| gary_poster | bac, benji, devel now has the branches that we have been working from (~gary/launchpad/direct-personal-subscription-actions) so you should be able to update devel and merge and then no longer worry about that old branch as a dependency | 14:59 |
| benji | cool | 14:59 |
| bac | gary_poster: great | 14:59 |
| gary_poster | bac, ok, those tasks took longer than I expected, but unless I hear back about a problem, I'm ready to go. Should I take some of the test writing from you, or leave you alone and find something else to do? | 15:05 |
| bac | gary_poster: i'm working tests for make_action_link | 15:06 |
| gary_poster | cool, that's the biggie | 15:06 |
| bac | gary_poster: feel free to pick another | 15:06 |
| bac | gary_poster: you know better than me the other areas that need tests. | 15:06 |
| bac | so if i can concentrate on that one function and you can begin to provide coverage for the others that would be great | 15:07 |
| gary_poster | heh, ok. I'll branch lp:~bac/launchpad/me-talk-pretty ? | 15:07 |
| gary_poster | bac ^^ | 15:09 |
| bac | just a sec | 15:11 |
| bac | gary_poster: lp:~bac/launchpad/subscription-tests | 15:12 |
| bac | but not just yet, still pushing | 15:12 |
| gary_poster | oh ok cool thanks | 15:12 |
| bac | and, ready | 15:12 |
| gary_poster | got it, thank you | 15:15 |
| benji | why oh why does FF4 keep crashing with an "out of memory" error? | 15:28 |
| gary_poster | :-( | 15:30 |
| gary_poster | bac, I'm going to tackle the python bug.py "subscribe" test, fwiw | 15:31 |
| bac | gary_poster: ok | 15:31 |
| Ursinha | hi gary_poster | 15:33 |
| gary_poster | hey Ursinha | 15:34 |
| Ursinha | gary_poster, I know matt already answered your email, but I'll be around this week | 15:34 |
| Ursinha | and next :) | 15:34 |
| gary_poster | Ursinha, oh ok, cool. I thought you guys had some holidays. So having the doc ready for your Monday morning sounds good then? | 15:35 |
| Ursinha | I didn't know you are expecting a new family member :) congratulations in advance for that :D | 15:35 |
| Ursinha | gary_poster, yes, sounds perfect | 15:35 |
| gary_poster | thank you for the congratulations Ursinha :-) | 15:35 |
| Ursinha | :) | 15:35 |
| gary_poster | thanks for letting me know and ttyl | 15:35 |
| * gary_poster writing tests for reveal_direct_description_actions now, bac | 16:00 | |
| bac | gary_poster: ok | 16:11 |
| benji | I love bzr uncommit. | 16:22 |
| * gary_poster had forgotten about bzr uncommit, and wanted it | 16:26 | |
| bac | gary_poster: have you got test set up for reveal_direct_description_actions? | 16:33 |
| bac | if so, could you paste it so i can steal as i need it for testing make_action_link | 16:34 |
| gary_poster | bac, yes. I refactored it a bit though for easier and more contained testing, so it may not be what you are looking for. You might be more interested in test set up for get_direct_subscription_information()? | 16:35 |
| bac | m_a_l on success currently calls r_d_d_a | 16:35 |
| bac | my test fails b/c my LP isn't properly populated | 16:36 |
| bac | i thought if there was boiler plate values i'd steal them | 16:36 |
| bac | do i need to merge your refactoring? | 16:36 |
| gary_poster | bac, merge: yeah, eventually, but I think there will be at worst one small conflict. http://pastebin.ubuntu.com/596594/ is what I have right now fwiw but it is not yet passing or complete. LP not properly populated: ...looking | 16:38 |
| gary_poster | bac: LP not properly populated: try tests of show_subscription_description | 16:40 |
| gary_poster | that passes in LP stuff | 16:40 |
| gary_poster | but you might be able to run with a lot of that data | 16:40 |
| bac | thx | 16:40 |
| gary_poster | for what you need | 16:40 |
| gary_poster | np | 16:40 |
| bac | gary_poster: thanks for the pointer. progress made. | 16:46 |
| gary_poster | bac, awesome | 16:47 |
| benji | gary_poster: things are winding down on the Chrome help link bug fix and I'm looking at next tasks: the cleanup & bugfix cards look like the best candidates; do you have any other suggestions? | 16:54 |
| benji | the sample data update is high priority | 16:54 |
| gary_poster | yeah, it's also very easy. lemme look at board. | 16:54 |
| gary_poster | benji, yeah, I think cleanup and bugfix. We should be ready for subdivide 2's green card by tomorrow morning, I hope (i.e., done with unsubscribe in anger except for bugfixes), but not yet. sample data is a good initial choice. Let me see if I can get the instructions for you... | 16:56 |
| benji | cool | 16:57 |
| gary_poster | benji, here's the crux: https://pastebin.canonical.com/43604/ needs to be applied to all sample data databases. This is supposed to be the instructions (https://dev.launchpad.net/Hacking#Sample Data), but I'm finding them a bit lacking. You can take a look while I click around some more... | 17:00 |
| gary_poster | https://dev.launchpad.net/Hacking#Sample%20Data | 17:00 |
| gary_poster | benji, I am 80% sure that you need to apply that patch to launchpad_dev | 17:01 |
| gary_poster | and then run make newsampledata | 17:01 |
| benji | gary_poster: define "launchpad_dev" | 17:02 |
| gary_poster | benji, you may also want to apply it to launchpad_ftest_playground | 17:02 |
| gary_poster | benji, launchpad_dev is the name of the PG database, as viewable with psql | 17:03 |
| gary_poster | The page linked to from the Hacking page (https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess) is not exactly pertinent but seems more complete. In particular, | 17:03 |
| gary_poster | I think you want to move newsampledata.sql to current.sql and move newsampledata-dev.sql to current-dev.sql . The Hacking page only describes the first of those | 17:04 |
| benji | k, reading | 17:05 |
| gary_poster | benji, if this proves to be problematic/annoying at all, please shelve it until Danilo returns, because I know he's familiar with the ins and outs of this. Maybe bac knows too, and there are probably others, but Danilo has been the person I've turned to so far for this stuff. | 17:06 |
| benji | k, I won't bang my head too hard on it | 17:06 |
| gary_poster | cool | 17:07 |
| gary_poster | fwiw, my guess as to steps would be this: | 17:07 |
| gary_poster | psql launchpad_dev | 17:07 |
| gary_poster | within psql, paste the sql | 17:07 |
| gary_poster | commit | 17:07 |
| gary_poster | oops, step 0: run make schema | 17:07 |
| gary_poster | so you have a pristine state | 17:07 |
| gary_poster | then do psql launchpad_dev; paste the sql from danilo's pastebin; commit | 17:08 |
| gary_poster | leave psql | 17:08 |
| gary_poster | run make newsampledata | 17:08 |
| gary_poster | and see if the diffs between the pertinent files look promising (filters have been added) | 17:08 |
| gary_poster | stop. | 17:08 |
| gary_poster | benji ^^ | 17:08 |
| gary_poster | oh, well, not stop: commit the changes and make a branch and get a review and all that stuff :-P | 17:09 |
| benji | :) | 17:09 |
| gary_poster | bac, lp:~gary/launchpad/direct-personal-subscription-actions-subscribe has all my tests so far, if you want to merge (tests pass for me). I'm going to write really simple tests for the *_action functions. Then with your tests for make_action_link we'll be done | 18:14 |
| gary_poster | I'm trying to figure out what "really simple tests" are ATM :-P | 18:14 |
| gary_poster | bac, you did see LPClient and how we use it for tests, yeah? | 18:56 |
| bac | gary_poster: yes, i saw in the old tests. have not grabbed your new branch yet | 18:57 |
| gary_poster | bac, yeah I just meant in the old tests. The tests I just pushed don't use it | 18:57 |
| gary_poster | but I'm wondering if I need to use it for testing the *_action functions. | 18:58 |
| gary_poster | so I'm playing with it again | 18:58 |
| bac | gary_poster: i've merged your changed and pushed with my stuff back to lp:~bac/launchpad/subscription-tests | 19:11 |
| bac | pretty rudimentary m_a_l tests right now | 19:11 |
| gary_poster | great bac. on team lead call. | 19:11 |
| gary_poster | off team lead call. | 19:28 |
| gary_poster | bac, I just pushed another version. This has all of the tests for the *_action functions. lp:~gary/launchpad/direct-personal-subscription-actions-subscribe | 20:15 |
| bac | ok | 20:16 |
| gary_poster | In order to test the function names and arguments being passed to named_post I am testing a bit of your function by the way, but never directly. | 20:16 |
| bac | gary_poster: you have a sec to talk briefly? | 20:17 |
| gary_poster | sure bac | 20:17 |
| gary_poster | Skype me when you are ready | 20:17 |
| * gary_poster wonders how big this branch is now | 20:17 | |
| benji | gary_poster: I /think/ this is a good sampledata change: http://pastebin.ubuntu.com/596659/ but there are a few changes that I wouldn't expect | 20:17 |
| gary_poster | benji, heh, yeah, I think that's common with sampledata changes | 20:34 |
| benji | k; I'm running with it, so we'll see how it it fares in ec2 | 20:35 |
| gary_poster | +1 benji | 20:35 |
| gary_poster | I'm assuming that the other changes in there (registrant, for instance) are from db changes that didn't get sampledata updates, and didn't need them for some reason (quite possibly because the changes were effectively made on the fly in db patches for dev instances) | 20:36 |
| gary_poster | doesn't it feel backwards to be using a language in which you need help to do things like this the right way? http://wolfram.kriesing.de/blog/index.php/2008/javascript-remove-element-from-array | 20:39 |
| gary_poster | :-/ | 20:39 |
| benji | yeah, I remember being flabbergasted by the round-about approach you have to take when I first tried to remove an item from a list in JS | 20:40 |
| benji | splice feels like a perl operator that somehow jumped into javascript | 20:43 |
| bac | gary_poster: do the tests all pass in your branch? | 20:58 |
| gary_poster | bac, yes, though there are some complaints that I just noticed as I was about to move to something else | 20:59 |
| bac | gary_poster: these? | 21:00 |
| bac | Error: Programmer error: unknown bug notification level: undefined | 21:00 |
| gary_poster | bac, yes, going to fix those | 21:00 |
| gary_poster | tests still pass though | 21:00 |
| bac | great | 21:00 |
| benji | gary_poster: shall I start writing the feature delivery page or one of the cleanup cards? | 21:08 |
| gary_poster | bac, I just pushed a one-line fix | 21:09 |
| gary_poster | benji, good question. | 21:09 |
| gary_poster | lemme look at cards | 21:09 |
| gary_poster | benji, if you are up for writing feature delivery page, that would be great | 21:10 |
| gary_poster | the other options are some bugs | 21:10 |
| benji | the kanban boards needs a tarot theme to liven things up | 21:10 |
| gary_poster | bug 761257 | 21:10 |
| _mup_ | Bug #761257: Advanced subscription overlay for direct subscriptions does not handle unsubscribing teams <Launchpad itself:Triaged by yellow> < https://launchpad.net/bugs/761257 > | 21:10 |
| gary_poster | bug 753000 | 21:11 |
| _mup_ | Bug #753000: NotOneError caused by duplicate stuctural subscriptions <dba> <merge-deactivate> <oops> <story-better-bug-notification> <Launchpad itself:Triaged> < https://launchpad.net/bugs/753000 > | 21:11 |
| gary_poster | are high on my list | 21:11 |
| gary_poster | tarot theme: heh, that would be nice | 21:11 |
| gary_poster | customizable would be cool | 21:11 |
| gary_poster | we can change colors | 21:11 |
| gary_poster | now | 21:12 |
| benji | I'm up for the writing. It may end up being a group effort of course, but if it needs to be done by EOD tomorrow, then I'd like to start it now and at least get it started | 21:12 |
| gary_poster | make halloween shades of orange and black | 21:12 |
| gary_poster | benji, it needs to be done by EOD Friday. I wasn't quite sure how to indicate that | 21:12 |
| gary_poster | I guess Monday would be clearer | 21:12 |
| gary_poster | did you see the example page I pointed to, benji? | 21:13 |
| benji | I keep thinking today is Thursday for some reason. | 21:13 |
| gary_poster | heh | 21:13 |
| benji | yep | 21:13 |
| gary_poster | cool | 21:13 |
| gary_poster | yay for it not being Thursday...at least from this perspective :-) | 21:13 |
| gary_poster | benji, bug 424849 is done; it has a complicated state. I'll download it to you when you get there, or write it myself at some point in the future | 21:14 |
| _mup_ | Bug #424849: Launchpad should batch attachment notification emails <lp-bugs> <story-better-bug-notification> <story-better-notification-sending> <Launchpad itself:In Progress by gmb> <apport (Ubuntu):Invalid> < https://launchpad.net/bugs/424849 > | 21:14 |
| benji | k | 21:15 |
| * gary_poster didn't take much of a lunch, and is feeling the lack | 21:15 | |
| benji | gary_poster: do you know how much of the items that were more-or-less fully reviewable were fully reviewed last time? | 22:00 |
| benji | I've been marking each as either having been reviewed or not, but I've realized that I can only guess, and even if it was, they may want to re-review to get a wholistic view | 22:00 |
| gary_poster | benji, I don't. I'd include them in the list as is (or modified as needed, whatever) with a note at the beginning of each one that they were already presented. | 22:01 |
| benji | "presented" good word | 22:01 |
| gary_poster | if you change your word from "reviewed" to "delivered" or "presented" then maybe you will be fine? | 22:01 |
| gary_poster | cool | 22:01 |
| gary_poster | OK, I'm hot on the trail of my bug, but it's time to quit | 22:08 |
| gary_poster | bac, how goes the test writing? more concretetely, do you feel comfortable that we'll be able to get this branch in review tomorrow morning? | 22:08 |
| bac | gary_poster: pretty good. yes we'll be able to go into review then, unless i've missed something big | 22:09 |
| gary_poster | awesome bac. I expect you haven't. | 22:09 |
| gary_poster | OK, have a great night everyone | 22:09 |
| benji | l8r | 22:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!