[13:12] bac, last test failure: it's a teardown issue in the error code. I think I can come up with a quick workaround. [13:13] (the lp.app error overlay code, really) [13:24] bac, all tests pass now [13:24] Hopefully what I did to make it so is not too disgusting :-) [13:26] bac benji danilos, I'll look at kanban in a minute or two, and call in 4 [13:26] gary_poster, ack [13:27] bac, is there a reason why you use "Y.Event.simulate(Y.Node.getDOMNode(node), 'click');" or can I use "node.simulate('click');" if it works for me? [13:27] That's what I've been trying to standardize on [13:28] gary_poster: great, thanks! [13:28] :-) [13:28] thank you, bac [13:28] those are good tests [13:28] gary_poster: we should standardize. i asked a while back about which was preferred and got no clear leaning [13:28] bac, oh ok [13:29] gary_poster: they can be refactored i'm sure [13:29] I (now?) think .simulate('click') is nicer because it is shorter and less error-prone [13:29] yeh, trivial change [13:48] part of doing stuff is going to be food :) [13:59] I've found the truth: http://naturesoundsfor.me/gary-call-background [14:04] benji: a very realistic recreation [14:08] bac: my sonic background tomorrow: http://naturesoundsfor.me/sith-christmas-beach [14:25] gary_poster: the sample data change is in devel [14:26] benji, I like the gary-call-background :-) [14:26] :) [14:26] benji: sample data on devel: awesome [14:26] a lifetime of trivial knowlege coupled with unmarketable talents [14:34] heh [14:34] bac [14:34] uh [14:35] flacoste says: keep the direct subscribers [14:35] drop the also notified subscribers [14:35] that seems like it would address a lot of the concerns we talked about this morning [14:35] gary_poster: ok [14:35] thanks [14:35] much easier, too, i suspect [14:35] yeah, agreed [14:37] benji, there's a FF/Chrome subscription issue that flacoste is filing now (works in Chrome, breaks in FF 4). I am having trouble remembering what it is that you had to fix already like that. Could you remind me [14:37] gary_poster: the show-help-link-on-hover that didn't [14:37] ah right [14:37] thanks [14:37] it was the other way-round though; it worked on FF4, not on Chrome [14:37] the new bug is unrelated [14:37] bug 768336 [14:37] <_mup_> Bug #768336: Subscribing to a bug doesn't show display name on FF4 < https://launchpad.net/bugs/768336 > [14:53] ok gary, I left several TODO markers for you to look at: https://dev.launchpad.net/LEP/BetterBugSubscriptionsAndNotifications/FeatureReviewNotes-2011-04-25 [14:53] benji, ack. I'll have an MP for you in just a sec [14:54] k [14:54] * benji goes to pour a cup of coffee. [15:01] benji, is there a way to run js lint locally if make lint doesn't see any changed files (because of...something, not sure) [15:02] gary_poster: bin/lint.sh path/to/file [15:02] thanks [15:04] benji, https://code.launchpad.net/~gary/launchpad/direct-personal-subscription-actions-subscribe/+merge/58676 (but diff is coming) [15:04] I'm on it. [15:04] danilos, when you are done with your current task, if you still have some time before EoD I'd like to consult [15:04] thanks benji [15:05] gary_poster, sure thing, though we are supposed to have the weekly call as well? [15:05] gary_poster: I'm going to reasign the review page card to you, since it's on your plate now [15:05] danilos, oh, yeah, good point :-P [15:05] thanks [15:05] benji, ack thanks [15:05] gary_poster, ok, so talk to you in ~25 mins :) [15:05] cool [15:26] gary_poster, hum, should "mute email" show up when you'll receive email as a member of the team subscribed to the bug? [15:26] yes, I think so danilos [15:26] oh [15:27] then that changes the whole team's subscription, right? [15:27] * gary_poster wishes he could revisit that whole "muting is a kind of subscribing" decision :-( [15:27] gary_poster, hum, no, it just doesn't show up one the bug page (which is why I thought this was db-devel stuff as well) [15:28] gary_poster, I don't think it changes the whole team's subscription, but there is a bug or two I uncovered [15:29] danilos, talk about it on call in a moment? [15:30] I have a very small branch. I don't describe it very well though. :-P https://code.launchpad.net/~gary/launchpad/owner_administrator/+merge/58683 ... [15:30] I'll try to describe it better for one of the OCRs after calls [15:32] hi benji, i have a feature flag usage question. could you look at test_bugsubscription_views.py? [15:33] bac: sure, on devel? [15:33] sure. wherever, it hasn't changed [15:33] k, got it open [15:34] so in the first setUp, there is a with feature_flags and then a flag is set [15:34] q: does the flag remain set outside of the scope of the with contextmanager? [15:34] I wouldn't think so. [15:34] so, it seems pointless [15:35] but in later tests you see "with feature_flags()" with no feature flag set [15:35] it depends on what feature_flags returns, if it's a singleton (possibly a thread local), then it could have a nonlocal effect [15:35] * bac likes FeaturesFixture [15:35] (oh, the downsides of a non-purely-functional language) [15:36] benji: it installs a feature controller but then seems to revert when leaving the context [15:37] bac: yep, feature_flags is a context manager that swaps out one feature flag controller for another temporarily, so that code looks like it just burns CPU time [15:37] hmm [15:37] does removing those lines change the outcome of the tests? [15:37] well i'll remove it and see what catches fire. should've done that before bothering you [15:39] np [15:40] benji: yes, removing those lines causes all hell to break loose [15:40] * bac confused [15:41] heh [15:42] gary_poster: done with https://code.launchpad.net/~gary/launchpad/direct-personal-subscription-actions-subscribe/+merge/58676 [15:43] awesome benji. thank you. can you take my other teeny tiny branch too? :-P [15:43] sure [15:43] * benji actually likes doing reviews. [15:43] thank you [15:43] being nitpicky about other people's code isn't all that hard [15:52] gary_poster: done with https://code.launchpad.net/~gary/launchpad/owner_administrator/+merge/58683 [15:53] benji, awesome thanks again [15:53] el gusto es mio (I can't be bothered to figure out how to type that accented I again) [16:28] benji, I made all requested/suggested changes, except for removing "docstring" parameters (I did change them from {Object} to {String}. [16:28] I didn't add that text to the branch, but they are used elsewhere in the branch and elsewhere in our JS. [16:28] I'd argue that this should go in our list of JS discussion items that the LP team, or the squad if necessary, discuss and agree on at a later date. [16:28] For now, though, there's precedence for including these, especially for our more key APIs. [16:28] You ok with me leaving it for now? [16:29] yep, absolutely; I like the idea of discussing this at Dublin [16:30] the timing for having a JS-centric Thunderdome is really good [16:30] cool thank you [16:39] bac, do you agree that it is safe to delete the card that was over in subdivide 2 with your current feature card "Make sure users can easily see summarized information about *their* subscriptions on bug page and bug target page."? [16:40] I think that should have been a comment on the bug [16:40] I mean the card [16:40] not a separate card [16:41] * gary_poster is deleting it. we can recreate it if necessary later [16:41] benji, are you wondering what to do now? [16:42] (I don't see active card on board) [16:42] because I have ideeeeeeeaaaaas! [16:42] gary_poster: yep, in just about 30 seconds; I'm about to show bac a patch I have that he might want to use [16:42] cool [16:43] bac: I still don't understand why that "with..." is needed in the setup, but this patch makes the tests a little more understanable: http://pastebin.ubuntu.com/597011/ [16:44] gary_poster: whatcha got? [16:45] benji, ok, when I say "don't be scared" basically I'm saying that to myself, but take a look at https://bugs.edge.launchpad.net/launchpad-project/+bugs?field.tag=story-better-bug-notification [16:45] heh [16:45] we're on the hook for high and critical, at least in theory [16:46] oh, I've already looked into the face of death... er that page [16:46] a lot of the in progress are going to be fix released when we reveal the features we've been working on [16:46] :-) [16:46] so we need to start whittling those down [16:46] a lot of those are small [16:47] the first two should really be "In Progress", right? [16:47] oh, wait the second one is new [16:47] yeah [16:47] that would be a good one to work on [16:47] that would be a good easy one, but there are more... [16:47] yeah if you just want to take it [16:47] I'm trying to garden the list [16:47] after that just burn down the list from top to bottom? [16:47] well, more or less, yeah [16:48] for critical and high [17:32] thanks benji. i'd already changed it to use FeatureFixture [18:36] gary_poster: wrt to the card you deleted, that requirement needs no action, right? [18:37] bac, I think that including the direct subscribers and clarifying that the (replace with new text) Edit your subscriptions appears when you have them is what we are going to try to sell as the "implementation". [18:38] ok [18:38] confusing incorrect punctuation sorry [18:38] gary_poster: in that case the branch is ready for review [18:38] the fix was easy but getting the test setup correct was a pain [18:39] bac fantastic. I'm happy to do it, or OCR, or whoever. Would you like me to take a look? [18:39] gary_poster: sure [18:39] i'm creating a bug now for tracking porpoises [18:39] cool [18:47] gary_poster: MP sent. if you'd like to review it i'd appreciate it [18:47] i'll let you know when the MP materializes [18:47] cool bac, onit [18:47] ok cool thank you [18:53] I got it https://code.launchpad.net/~bac/launchpad/nix-subscriber-list/+merge/58723 [18:53] gary_poster: thanks [18:53] sure [18:56] bac, line 205 of diff, shouldn't "with FeatureFixture({self.feature_flag: flag}):" be "with FeatureFixture({self.feature_flag: ON}):"? [18:57] no [18:57] flag is a parameter [18:57] i show it on and off [18:59] oh of course bac. Is the comment on line 206 wrong? "# Subscribe someone to the target." It seems you already do that in setUp, and this just renders [19:00] yep, should be moved to setUp or just deleted [19:00] cool [19:00] fine with either [19:01] bac, last comment I think: calculating also_notified_subscribers is expensive, as I've heard. AFAICT We are still doing it, just not showing it? If it were easy-ish it would be really nice not to calculate it at all. Did you investigate that and reject it [19:01] ? [19:02] * bac looks [19:04] gary_poster: ah, you're right [19:04] cool [19:04] gary_poster: if i move the tal:define into the feature-flag protected section of the page template it will not be calculated [19:04] sounds great [19:05] bac, r=me with those. I'll follow up on the MP [19:06] thanks [19:07] done [19:08] * gary_poster is going to walk around for a sec. biab [19:30] bac, call? [19:31] yes, just trying to get this branch on its way [19:31] bac, no rush, ping me when you are ready...or just call me [19:58] gary_poster: I just realized that I might be wasting my time working on bug 768336 if bac is hiding/killing the subscribe list [19:58] <_mup_> Bug #768336: Subscribing to a bug doesn't show display name on FF4

< https://launchpad.net/bugs/768336 > [19:59] benji, I said that to flacoste first. short answer, you are not :-) [19:59] benji: i only hid the 'also notified' section [19:59] right [19:59] k [20:58] benji I'll be ready in just a few [20:58] k [20:59] gary_poster: could you glance at bug 702413 .. i think it is not an issue [20:59] <_mup_> Bug #702413: Update label for lifecycle option in subscription notification levels

< https://launchpad.net/bugs/702413 > [21:01] * gary_poster reading [21:01] bac, agreed [21:02] gary_poster: i'll s/the/this and land it [21:02] cool [21:09] benji, now ok? [21:09] gary_poster: yep [21:11] gary_poster: actually i think deryck was referring to the terminology used in gavin's work, which still exists in the code base but isn't used, i don't think [21:11] bac, ah I see that makes sense [21:11] gary_poster: see bug_notification_level_description_mapping if you're interested [22:22] gary i got two one-line-fix bugs done and sent off to ec2. not much but two fewer cards on the board [22:22] * bac is done [22:22] bac, cool :-) [22:22] ttyl [22:54] night all