[12:05]  * danilos -> lunch
[12:06] <gary_poster> hi
[12:06] <gary_poster> baby still inside womb, so still around
[12:18] <gary_poster> danilos, thank you for arranging no downtime deploy :-)
[12:18] <gary_poster> found new bug 770217
[12:19] <gary_poster> (for after your lunch) I think you still have bugs to file danilos?
[12:38] <gary_poster> _mup_ is temperamental
[12:50] <danilos> gary_poster, yeah, I still have bugs to file, will do so right now
[12:50] <gary_poster> cool thank you danilos.
[12:50] <danilos> gary_poster, qa took longer than I wanted (a bunch of unqa-d derived distro stuff)
[12:50] <gary_poster> danilos, gotcha. :-/
[12:50] <gary_poster> thank you again for doing that
[12:51] <danilos> you are welcome :)
[12:54] <bac> gary_poster: if the baby hangs on you think you can come to the release party on thursday?  :)
[12:55] <gary_poster> bac, heh, thanks for asking, but I doubt it.  I suspect I'll need to be providing moral support in that case.
[12:55] <gary_poster> btw, I'm writing an email to Huw about all remaining items for him in the backlog
[13:12] <gary_poster> bug 770248 is another new, high priority bug
[13:19] <danilos> fa
[13:19] <danilos> uhm, enter instead of backspace :)
[13:20] <danilos> gary_poster, bugs filed, I am working on the tests and cleanup already, and will probably continue to do so for the rest of the day
[13:21] <gary_poster> danilos, fantastic, thanks.  It will be great to have those addressed.
[13:27] <gary_poster> bac benji danilos kanban now, skype in 3
[13:28] <gary_poster> bac, I see no in-progress cards.  is that accurate?
[13:29] <bac> gary_poster: yes
[13:29] <bac> atm
[13:29] <gary_poster> ok bac
[13:30] <gary_poster> benji, I'm trying to book my travel today, so you will be all by your lonesome on that card soon I hope :-)
[13:31] <gary_poster> https://bugs.edge.launchpad.net/launchpad-project/+bugs?field.tag=story-better-bug-notification
[13:52] <gary_poster> bac, Huw did not get back to you about the title overrun problem in the overlay, did he?
[13:52] <bac> he did not
[13:54] <gary_poster> ack thanks
[14:06] <bac> gary_poster: my natty is now booting.  hurrah.
[14:07] <gary_poster> danilos, are you up for a pre-imp on bug 753000 (making fixes for dupe structural subscriptions and constraints to prevent them in the future) or do you want to put that off till tomorrow so you can get your current task done before EoD?  Either is fine
[14:07] <danilos> gary_poster, I'd prefer to leave it until tomorrow
[14:07] <gary_poster> danilos, understood, that lets me work on easier bugs so no problem here ;-)
[14:07] <gary_poster> thanks
[14:08] <danilos> hehe, a win-win situation
[14:48] <bac> gary_poster: in bug 770248 you list bug 240067 as an example where you cannot mute
[14:48] <gary_poster> bac, yes
[14:48] <bac> gary_poster: when i go to that bug i see the mute bug mail link
[14:48] <bac> i do not have a direct subscription
[14:48] <gary_poster> bac, do you have anything other than a structural subscription?
[14:49] <gary_poster> (according to _subscriptions)
[14:49] <gary_poster> +subscriptions
[14:50] <gary_poster> I can confirm that https://bugs.launchpad.net/launchpad/+bug/240067 does not show a Mute link for me
[14:50] <bac> gary_poster: two 1) via LP Bug Contacts and 2) a structural sub
[14:51] <bac> gary_poster: i believe you -- just trying to reproduce it.  what does your +subscriptions say?
[14:52] <gary_poster> bac, only the LP Bug contacts
[14:52] <gary_poster> (which is a structural subscription via the team)
[14:52] <bac> gary_poster: ok, i deleted my personal structural subscription and the mute link went away
[14:52] <gary_poster> huh, ok, cool that you could repro.
[14:54] <bac> gary_poster: btw, in case you face it, once i reverted my nvidia driver from [current] to 173 i was able to boot
[14:54] <bac> gary_poster: hmm, but you never boot to metal, do you?
[14:54] <gary_poster> bac, ok cool thanks for hint.  No, but I was considering it this very weekend. :-)
[14:55] <gary_poster> I think I need more disk space before I do that though
[14:56] <bac> gary_poster: so you see no mute link on bug 770248 either
[14:56] <bac> where the hell is mup?
[14:57] <gary_poster> bac, I do see a mute link, because I'm directly subscribed, because I filed the bug
[14:57] <bac> gotcah
[14:57] <gary_poster> If I unsubscribe myself then I don'yt
[15:06] <bac> gary_poster: so the problem seems to be "structural subscriptions via a team do not show mute link", no?
[15:06] <gary_poster> bac, yeah, that's what I would guess too
[16:25] <gary_poster> another bug bites the dust...and I file another one. :-P
[16:29] <bac> gary_poster: you're climbing a ladder in quick sand
[16:30] <gary_poster> yeah
[16:31] <gary_poster> bac, I'm somewhat frightened of this, but I should tackle it. :-) Do you have any pre-imp thoughts on https://bugs.edge.launchpad.net/launchpad/+bug/770287 ?  I expect I'll need to go look at menu items...somewhere?
[16:32] <gary_poster> (the menu items are what frighten me :-) )
[16:32] <bac> gary_poster: i'm surprised by that bug.  i thought i had squashed those links.
[16:33] <bac> gary_poster: the links should just have 'enabled=False' to suppress them
[16:33] <gary_poster> bac, my sampledata might be a little old but everything else is fresh
[16:34] <gary_poster> I assume that wouldn't affect it (?)
[16:34] <bac> gary_poster: i'm not questioning your vision
[16:34] <bac> gary_poster: i'm just surprised my fix was only partial
[16:34] <gary_poster> cool
[16:35] <gary_poster> So where do I start?  I'm afraid the whole menu machinery is a bit of a black box to me--and it shouldn't be, which is why I want to tackle this
[16:35] <bac> gary_poster: the links are constructed in bugs/browser/structuralsubscription.py
[16:35] <gary_poster> ok cool
[16:37] <gary_poster> I see, yeah, that seems to be doing the right thing
[16:37] <gary_poster> I'll pdb around I guess
[16:50] <gary_poster> bac, this is the problem:
[16:50] <gary_poster>  	        if sst.parent_subscription_target is not None:
[16:50] <gary_poster> 386  	            target = sst.parent_subscription_target
[16:51] <gary_poster> in dev, thunderbird has not set its bug_tracking_usage
[16:51] <gary_poster> (UNKNOWN)
[16:51] <gary_poster> but the parent, mozilla, has (LAUNCHPAD)
[16:51] <gary_poster> I don't really understand the intent of this code branch so I'm at a bit of a loss
[16:52]  * bac looks
[16:52] <gary_poster> obviously I could simply remove that conditional
[16:52] <gary_poster> but I assume it is there for a reason.
[16:52]  * gary_poster looks for pertinent tests...
[16:53] <gary_poster> nothing of the mixin by itself...
[16:56] <gary_poster> I remember there was one honking big file of tests...
[16:58] <bac> gary_poster: the parent is useful for milestone-project and distrosourcepackage-distro type relationships.  the code you see is correct for them.
[16:59] <bac> gary_poster: but it is not correct for product-projectgroup relations
[16:59] <bac> in fact, it is circular:  the projectgroup's usage of launchpad is determined by querying the sub-projects
[16:59] <bac> in the case of mozilla in our sample data, firefox uses LP, so mozilla reports it does even though thunderbird does not.
[17:00] <bac> gary_poster: so, it is kind of hacky, but in that test perhaps we include test that IProduct is not provided?
[17:00] <bac> by 'test' i mean conditional
[17:01] <gary_poster> bac, understood.  WFM.  Where are the tests for this again?
[17:01] <gary_poster> I mean real tests :-)
[17:03] <bac> gary_poster: there appear to be some in bugs/stories/xx-bug-statistics-portlet.txt
[17:03] <bac> gary_poster: i *wish* there were one in bugs/browser/tests
[17:03] <gary_poster> bac, oh, don't we have a big set of tests you did?
[17:05] <bac> gary_poster: ah, bugs/browser/tests/test_subscription_links.py ... of course
[17:05] <gary_poster> bac, yay, thanks.  I'll tackle that. Sorry you had to do all the work. :-P
[17:30] <Ursinha> I love the notifications changes
[17:31] <Ursinha> one of the first times I use launchpad and don't hate the ui
[17:45] <bac> gary_poster: it looks like Bug.personIsAlsoNotifiedSubscriber does not take team membership into account.  odd.
[17:45] <gary_poster> Ursinha, yay, thank you :-)
[17:45] <gary_poster> bac, that is odd :-/
[17:49] <bac> Ursinha: can we quote you on that?
[17:49] <Ursinha> bac, yes :)
[17:50] <bac> gary_poster: i also notice that when subscribing to a bug the mute link is not made available until the page is reloaded.  fix one, file one.
[17:50] <gary_poster> bac, I think mrevell might have just filed that other one...checking
[17:50] <bac> Ursinha: how is penelope?  growing?
[17:51] <Ursinha> bac, growing :) apparently she acquired taste for everything, from shoes to walls :P
[17:51] <gary_poster> bac, maybe not; just related
[17:52] <bac> Ursinha: put her in your handbag and bring her to dublin.  we need a mascot
[17:56] <Ursinha> gary_poster, I'm putting all results mrevell and I found here: https://dev.launchpad.net/QA/ExploratoryTesting/BetterBugSubscriptionsAndNotifications
[17:56] <Ursinha> bac, :)
[17:57] <gary_poster> Ursinha, great, thank you.  That puts some of the new bugs in clearer context too.
[17:57] <Ursinha> oops
[17:57] <Ursinha> cool
[17:58]  * bac lunches
[20:01] <gary_poster> I'll be doing just a bit of more work later, but for now I'm off to Karyn's appt.
[20:01] <gary_poster> bye