| Ursinha | I <3 X-Launchpad-Subscription | 03:21 |
|---|---|---|
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| bac | hi danilos | 13:12 |
| danilos | bac, hi, how's it going? | 13:12 |
| bac | i worked on bug 770245 yesterday but didn't really make much progress. what were your thoughts on how to solve the problem? | 13:12 |
| _mup_ | Bug #770245: Unsubscribing a team from a dupe doesn't work in advanced subscription overlay <story-better-bug-notification> <Launchpad itself:In Progress by bac> < https://launchpad.net/bugs/770245 > | 13:12 |
| danilos | bac, well, I was thinking of exporting on +subscribe form if a team-subscription is from a dupe somehow, and then using unsubscribeFromDupes webservice call; if that doesn't work, perhaps we can blindly call unsubscribeFromDupes call for *all* team subscriptions | 13:16 |
| danilos | bac, or, as the last resort, we can call both (and that might be necessary anyway if team is both directly subscribed and subscribed through dupe) | 13:17 |
| bac | danilos: that seems to be most sane b/c that's what you want to do, right? unsubcribe, whether through this bug or through a dupe | 13:18 |
| danilos | bac, also, sorry about the confusing bug (i.e. not noting that the UI seems to work yet unsubscribing fails) :/ | 13:18 |
| bac | np | 13:19 |
| danilos | bac, yeah, I am just wondering if unsubscribeFromDupes does that for you automatically | 13:19 |
| bac | trying to figure out how to test this change has been vexing too | 13:19 |
| bac | danilos: i'll check and make sure | 13:19 |
| danilos | bac, well, with the current code it's egregious, so I wouldn't mind if you don't test it at all, and I'll be providing tests as I go along | 13:20 |
| bac | i recalled you mentioned passing in more info but it wasn't clear to me where to embed it | 13:20 |
| bac | danilos: :/ | 13:20 |
| bac | ok, thanks for the nudge | 13:20 |
| danilos | bac, right, I would have done it probably using more hidden input fields in the form, but perhaps doing both is best | 13:21 |
| danilos | == doing both API calls is best | 13:21 |
| danilos | which reminds me, I was supposed to be OCR :/ | 13:22 |
| gary_poster | heh | 13:22 |
| gary_poster | bac benji gmb danilos, kanban now-ish, call in 5, baby watch continually. | 13:25 |
| gary_poster | gmb, could you put the card for your bug on the board? I'm sorry we have to maintain everything twice | 13:29 |
| gmb | gary_poster: I meant to ask you about that. What do you want me to do with the existing card for that bug that's in Done-Done (I assume it was to track the triaging of the problem) | 13:29 |
| * gmb adds a card without the bug number for now anyway | 13:30 | |
| gary_poster | gmb, just remove the number from the existing card | 13:30 |
| gary_poster | thank you | 13:30 |
| gmb | Done | 13:31 |
| Ursinha | good morning | 13:32 |
| gary_poster | morning Ursinha | 13:33 |
| gary_poster | danilos Skype? | 13:33 |
| danilos | gary_poster, yep, ready | 13:33 |
| danilos | gary_poster, didn't see the call invitation, sorry | 13:34 |
| gary_poster | np :-) | 13:36 |
| gary_poster | gmb, I've added some new unique indices for structural subscriptions, and IPersonSet.merge is complaining that we have not handled structuralsubscription.subscriber. Looking around, it doesn't appear that we merge structural subscriptions. Does that happen to ring a bell with any warnings, thoughts, or experiences, or should I just continue forging ahead blindly? | 13:47 |
| gmb | gary_poster: It rings a bell... I might have had to do something with it in the db patch branch that I did a few weeks back. | 13:50 |
| gmb | (i.e. I might have had to tell merge() to skip something) | 13:50 |
| gmb | Let me check... | 13:50 |
| gary_poster | gmb, I suspect that you told merge to skip.append(('bugsubscriptionfiltermute', 'person')) | 13:51 |
| gmb | gary_poster: Yes, that's it (just found it myself). | 13:51 |
| gary_poster | cool | 13:51 |
| gary_poster | but AFA you know, it is probably an oversight that we do not merge structural subscriptions, and I should do so? | 13:52 |
| gary_poster | Oh, and shouldn't we either delete or merge the bugsubscriptionfiltermute thing? | 13:52 |
| gmb | Well, AIUI, we shouldn't need to because the old Person becomes inactive after the merge, so it's just irrelevant data. | 13:53 |
| gmb | I don't know whether un-merging is possible, though - that's the only reason to keep such data around, really. | 13:53 |
| gmb | gary_poster: I don't know if not merging subscriptions is an oversight or whether it would cause horrible things to happen. TBH I'd try doing it and see what needs to be fixed to make it work. | 13:54 |
| gary_poster | gmb, fair enough, thanks | 13:54 |
| === benji is now known as Guest41434 | ||
| === benji____ is now known as benji | ||
| danilos | ok, I am off OCR, as soon as I put my name on, reviews have been coming in and I couldn't put a MP up myself :) | 15:15 |
| gmb | gary_poster: Can you remember whether, in the case of multiple filters, it's the most verbose or the least verbose that wins? | 15:34 |
| gary_poster | gmb, most always "wins"--it's a union of filters, so you can think of it as all of them "winning" | 15:35 |
| gmb | Hmm. | 15:35 |
| gary_poster | (that's the way we present it when we send emails with filter names--all matching names are included) | 15:35 |
| gmb | gary_poster: I'm just wondering, then, if maybe the bug isn't that we send out emails on creation to people who don't want them (e.g. Gavin), but that we tell them that the email matched a filter that it didn't actually match. | 15:36 |
| gmb | Because I can't reproduce Gavin's problem. | 15:36 |
| gmb | (I thought I could but that was due to db cruft; make schema fixed that) | 15:37 |
| gmb | I'll try writing a test for that instead... | 15:37 |
| gary_poster | gmb, maybe. did you dupe *that* problem? | 15:37 |
| gmb | Not yet. | 15:37 |
| gary_poster | ack | 15:37 |
| gmb | Well, I might have, but I wasn't looking for that problem. | 15:37 |
| * gmb goes back to the codeface | 15:38 | |
| gary_poster | :-) | 15:38 |
| bac | hi danilos -- this seems to be a fix that works: http://pastebin.ubuntu.com/599818/ | 15:55 |
| danilos | bac, right, so you are chaining them both after all? looks good, r=me if you want to land it :) | 16:14 |
| bac | danilos: cool. i'm submitting a MP now | 16:15 |
| danilos | bac, btw, what happens with the animation/progress UI? | 16:16 |
| bac | danilos: works as expected | 16:16 |
| bac | danilos: as far as i can tell | 16:17 |
| danilos | bac, right, just checking | 16:17 |
| bac | danilos: i was pleasantly surprised. :) | 16:17 |
| danilos | heh, so am I :) | 16:17 |
| danilos | gary_poster, btw, I've put up one branch for review, but no reviewer anymore: https://code.launchpad.net/~danilo/launchpad/advanced-bug-subscription-cleanup/+merge/59235 | 16:19 |
| danilos | bac, benji, gary_poster: if any of you can take a look at the above MP, I'd appreciate it, though I plan to leave in a bit | 16:19 |
| bac | danilos: i can | 16:20 |
| danilos | bac, cool, thanks | 16:20 |
| gary_poster | danilos, how soon before EoD? Already? I have a branch for review now too | 16:21 |
| gary_poster | and you would be a good fit, but not necessary | 16:21 |
| danilos | gary_poster, something like 5 minutes :) | 16:21 |
| gary_poster | danilos, sounds perfect! ;-) | 16:21 |
| danilos | gary_poster, heh, send it over then :) | 16:22 |
| gary_poster | danilos, heh, I was kidding, but you can take a look if you want. stub has already reviewed the DB parts (lines 1-364) and the rest are changes I did to make the tests pass | 16:23 |
| gary_poster | https://code.launchpad.net/~gary/launchpad/bug753000/+merge/59139 | 16:23 |
| gary_poster | danilos, take a glance and see if you want to review it, or even if you don't but you have some comments ;-) | 16:23 |
| gary_poster | oh, diff is not showing the permission changes yet,, | 16:24 |
| gary_poster | there they are | 16:24 |
| bac | danilos: can you look at https://code.launchpad.net/~bac/launchpad/bug-770245/+merge/59239 ? no surprises | 16:24 |
| danilos | bac, done | 16:25 |
| bac | great | 16:25 |
| bac | danilos: i'm not that fast. yours will take a little longer. | 16:25 |
| gary_poster | I like "Tests: Hmm." | 16:26 |
| bac | :( | 16:26 |
| danilos | bac, :( | 16:27 |
| danilos | gary_poster, your branch generally looks fine, but I think it needs to get a better look than 3 minutes I can spare :) | 16:28 |
| gary_poster | danilos, understood, thanks for the glance | 16:28 |
| gary_poster | have a great evening | 16:28 |
| danilos | gary_poster, especially because of the person-merging additions | 16:29 |
| gary_poster | yeah | 16:29 |
| danilos | thanks, enjoy the day everyone :) | 16:29 |
| gary_poster | bac benji or gmb, would any of you be willing and able to do a code review (db review already done by stub) of https://code.launchpad.net/~gary/launchpad/bug753000/+merge/59139 ? | 16:29 |
| gmb | gary_poster: Sure. | 16:30 |
| gary_poster | yay, thanks gmb. | 16:30 |
| gmb | gary_poster: I've had another thought about that there bug: https://bugs.launchpad.net/launchpad/+bug/720147/comments/4 | 16:35 |
| gary_poster | looking | 16:35 |
| gary_poster | ack gmb. I think that making the filter work on newly created bugs would be ideal, but if not, yeah, we can clarify the current behavior better. | 16:37 |
| gmb | Right. | 16:38 |
| gmb | gary_poster: Now that I know it's not a bug per se I might actually find life a bit less complicated. I'll let you know how it goes. | 16:39 |
| gary_poster | cool | 16:39 |
| gmb | gary_poster: You need to add some explanatory comments / docstrings to the tests you've added to test_person.py (or at least to the two assert*()s that you added). Other than that, r=me. | 16:41 |
| gary_poster | gmb, cool, makes sense. Thank you! | 16:41 |
| gmb | np | 16:41 |
| gary_poster | does anyone know if we can add a project group ourselves (on qastaging) or if we have to get a LOSA? | 16:54 |
| gary_poster | I don't know how to do it other than asking a LOSA and the links I found don't give me any different ideas | 16:55 |
| gmb | gary_poster: https://help.launchpad.net/ProjectGroups is the only thing I can find that's relevant. | 17:06 |
| gmb | I don't think staging's any different. | 17:06 |
| gmb | (Though obviously we can bypass the ask a question stage) | 17:07 |
| gary_poster | gmb, yeah, me too. thank you for looking. | 17:07 |
| gary_poster | benji, any news on your bug 739141? | 17:25 |
| _mup_ | Bug #739141: I get lp bug mail even though 'on own actions' turned off <story-better-bug-notification> <Launchpad itself:Triaged by benji> < https://launchpad.net/bugs/739141 > | 17:25 |
| benji | gary_poster: I'll be filing a merge proposal after lunch | 17:27 |
| gary_poster | benji, wow! | 17:27 |
| benji | :) | 17:27 |
| gary_poster | I'll be reading that one. I'm more than a little bit curious ;-) | 17:27 |
| benji | gary_poster: unfortunately it's a little mundane: https://code.edge.launchpad.net/~benji/launchpad/bug-739141/+merge/59260 | 18:29 |
| gary_poster | benji, well, the change description sounds like it is a part of the story I am unfamiliar with, so it sounds at least a bit interesting. :-) Want me to review it? | 18:31 |
| gary_poster | eh, it's so small, I will. :-) | 18:32 |
| benji | gary_poster: sure, review away | 18:33 |
| gary_poster | benji, r=me | 18:34 |
| benji | cool | 18:34 |
| gary_poster | bac or benji, I need a pre-imp for bug 770387. I expect it to be brief. Are either of you up for it? | 18:36 |
| _mup_ | Bug #770387: After changing the subscription option for my user, there's no notification about the change made <exploratory-testing> <story-better-bug-notification> <ui> <Launchpad itself:In Progress by gary> < https://launchpad.net/bugs/770387 > | 18:36 |
| benji | gary_poster: I'm available | 18:36 |
| gary_poster | cool thanks | 18:36 |
| gary_poster | benji, mumble or skype? | 18:37 |
| benji | skype | 18:37 |
| gary_poster | bac or benji, review of smallest branch evah, plz? https://code.launchpad.net/~gary/launchpad/bug770387/+merge/59269 | 19:49 |
| benji | gary_poster: I can | 19:49 |
| gary_poster | thank you | 19:49 |
| benji | gary_poster: approved | 19:50 |
| gary_poster | thanks benji :-) | 19:50 |
| benji | np | 19:50 |
| gary_poster | I know, it was a pretty ambitious branch | 19:50 |
| benji | gary_poster: would you object to me fixing bug 771335 by taking the bug name out of the form title? | 20:07 |
| _mup_ | Bug #771335: Title of add subscription widget can wrap if long. <story-better-bug-notification> <Launchpad itself:Triaged> < https://launchpad.net/bugs/771335 > | 20:08 |
| gary_poster | benji, I would this week. If we don't have a good answer from Huw by next week, I'm alright with various hacks (I Think bac proposed one too, a few weeks ago) | 20:09 |
| gary_poster | So, IOW, I'm OK with you doing that, say, Tues or Wed of next week if there's not a better aswer by then | 20:09 |
| bac | benji: huw said he is looking at it | 20:09 |
| gary_poster | right | 20:09 |
| gary_poster | and it is a generic LP problem | 20:09 |
| benji | ok, good | 20:10 |
| bac | i just forwarded his email | 20:10 |
| bac | gary_poster: one of your branches is one away from being the release blocker! | 20:17 |
| bac | quick! to the qastaging! | 20:17 |
| gary_poster | bac thanks for heads up... /me thought he had done everything | 20:19 |
| bac | gary_poster: yeah, i don't look at that page often enough | 20:20 |
| === gary_poster changed the topic of #launchpad-yellow to: https://dev.launchpad.net/yellow | http://launchpad.leankitkanban.com/Boards/Show/14028610 | http://irclogs.ubuntu.com/ | https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html | ||
| * gary_poster back in a bit | 20:35 | |
| benji | gary_poster: I may have duplicated some work, are you working on bug 771232? | 20:46 |
| _mup_ | Bug #771232: Edit structural subscription overlay is headed "Add a mail subscription for..." <exploratory-testing> <story-better-bug-notification> <Launchpad itself:In Progress by benji> < https://launchpad.net/bugs/771232 > | 20:46 |
| benji | oh, gary if AFK | 20:46 |
| benji | s/if/is/ | 20:47 |
| gary_poster | benji, yo. "a bit" turned out to be longer than I expected | 21:30 |
| benji | that's cool | 21:30 |
| gary_poster | benji, yeah I was just starting on that. If you've already fixed it then that's great :-) | 21:30 |
| gary_poster | it seemed like the problem was we were creating a new form overlay each time | 21:31 |
| gary_poster | without deleting the old one sufficiently | 21:31 |
| benji | I started, but have thrown it away, so it's all yours. | 21:31 |
| gary_poster | benji, so should you claim the bug, and I'll move on to another? | 21:31 |
| gary_poster | oh ok | 21:31 |
| bac | gary_poster: remind me how you do python-like string interpolation in YUI | 22:18 |
| gary_poster | bac, I think you mean Y.substitute | 22:19 |
| gary_poster | bac, subscription.js has an advanced usage | 22:20 |
| bac | yes, i think that is is | 22:20 |
| bac | is it | 22:20 |
| bac | thanks, i looked about but didn't see it | 22:20 |
| bac | gary_poster: would you think this is overkill? http://pastebin.ubuntu.com/600017/ | 22:21 |
| gary_poster | bac, I guess that's alright. outerHTML is the only thing that makes me even slightly unhappy, really, but I see why you did it. FWIW, you have a typo in that line. var header = Y.Node.create('<h2></h2'); You want to close the </h2> or use <h2/> like benji does. | 22:23 |
| bac | benji is just lazy. i like that. | 22:24 |
| gary_poster | :-) | 22:24 |
| bac | gary_poster: what would you do to get rid of the outerHTML? | 22:25 |
| gary_poster | bac I didn't suggest anything because I didn't have any immediate counter suggestions, but I'll think for a sec... | 22:26 |
| bac | gary_poster: i figured this was better than using Y.substitute...but not strongly | 22:26 |
| gary_poster | bac, did you try just passing it the node itself? Sometimes YUI is OK with stuff like that | 22:26 |
| gary_poster | That would be prettier | 22:27 |
| bac | i did not | 22:28 |
| gary_poster | I just looked through the code a bit | 22:28 |
| bac | indeed that works fine | 22:29 |
| bac | thanks | 22:29 |
| gary_poster | awesome | 22:29 |
| gary_poster | np | 22:29 |
| bac | i guess i'm shellshocked from seeing "YUI_3_object_br_549" rendered | 22:29 |
| gary_poster | heh | 22:29 |
| === Ursinha is now known as Ursinha-afk | ||
| bac | where does "heh" fit in with "ha" and "LOL"? | 22:31 |
| bac | is it at all related to "meh" | 22:31 |
| Ursinha-afk | I always ask myself the same question | 22:32 |
| gary_poster | For me, LOL is louder than heh | 23:04 |
| gary_poster | I never use ha, but if I did, it might be sarcastic | 23:04 |
| gary_poster | heh is a quieter laugh | 23:04 |
| gary_poster | bac, if you have a few more minutes, then https://code.launchpad.net/~gary/launchpad/bug771232/+merge/59302 could use a review; if not, no problem; we can do it tomorrow | 23:05 |
| * gary_poster departs for dinner and crying children, though will be back later | 23:06 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!