| === robins is now known as robinsmidsrod | ||
| wraiden | any core upstart developer here? | 14:32 |
|---|---|---|
| SpamapS | wraiden: you should just ask your question.. somebody smart enough to answer should be on sometime today. :) | 16:42 |
| wraiden | i'll write an email to the list and are allready up to implement the things i wanted to get opinions on... | 17:01 |
| wraiden | i need to set the signal that is uses to stop the exec job ... | 17:02 |
| wraiden | for slapd (openldap) | 17:02 |
| wraiden | it needs sigint and will eat the directory-database if it gets stopped by sigterm or sigkill... | 17:03 |
| wraiden | i'll implement a stopsignal stanza ... | 17:03 |
| wraiden | default value for it is term | 17:04 |
| wraiden | but can get be set int, usr1 or usr2 also | 17:05 |
| SpamapS | wraiden: right, in that case, pre-stop is needed | 17:05 |
| wraiden | pre-stop ? | 17:05 |
| SpamapS | no need for a new stanza | 17:05 |
| SpamapS | send your sigint in pre-stop | 17:06 |
| SpamapS | and wait for slapd to shutdown, then TERM will never be sent | 17:06 |
| wraiden | ah | 17:06 |
| wraiden | and upstart will supervise the slapd pid and will not respawn it? | 17:07 |
| SpamapS | There is an open bug against upstart to provide custom actions, so that reload could be changed from HUP to USR1 or something like that | 17:07 |
| wraiden | jepp | 17:07 |
| SpamapS | yes, at that point, the job's goal will be "stop" | 17:07 |
| SpamapS | so no respawn takes case | 17:07 |
| wraiden | i plan to implement that also | 17:07 |
| SpamapS | takes place | 17:07 |
| wraiden | but that needs a change in initctl to hand over the actual signal sending to the job to upstart itself | 17:08 |
| wraiden | initctl doesn't parse the job configs so there is no way to change the behavior without that... | 17:08 |
| SpamapS | I'm not sure the best way to spin and wait for it to die.. its not pretty but just watching status would work I *think* | 17:09 |
| wraiden | mhm | 17:09 |
| wraiden | i'll go and test that ... | 17:11 |
| wraiden | btw: the stopsignal stanza is a rally low hanging fruit | 17:11 |
| wraiden | *really | 17:12 |
| wraiden | ot: is the copyright / legal stuff still needed to contribute to upstart? | 17:12 |
| SpamapS | wraiden: not OT at all, but its not clear either. ;) | 17:32 |
| SpamapS | wraiden: stopsignal seems rather.. coarse. I'm thinking Keybuk will prefer something a bit more elegant. Like 'action stop signal INT' rather than 'stopsignal' | 17:33 |
| wraiden | i've implemented "oom score value" support (patch is on mailinglist) so thats no problem as im familar with the stanza parsing now ... :) | 17:37 |
| wraiden | an rfc mail for scott to read is also out to the mailinglist ... i'll wait until he has time to respond to it... | 17:39 |
| wraiden | *reguarding the stopsignal stuff | 17:39 |
| wraiden | anyway, time to go home for me now... bye | 17:40 |
| wraiden | and thanks for your hint with the pre-stop hack for slapd :) | 17:41 |
| wraiden | hello again... | 18:54 |
| Keybuk | wraiden: hi | 19:20 |
| JanC | wraiden: I think Keybuk doesn't require copyright/legal stuff since yesterday anymore, but best he answers that himself ;) | 19:31 |
| wraiden | @ keybuk: Mailinglist... | 19:31 |
| JanC | ah, you asked there too | 19:31 |
| Keybuk | wraiden: you have a question? | 19:32 |
| wraiden | in the mail ... | 19:32 |
| Keybuk | sorry, I don't have lots of this channel, so am missing context | 19:32 |
| * wraiden == Marc | 19:32 | |
| Keybuk | ah, hi! | 19:32 |
| * Keybuk = Scott | 19:32 | |
| wraiden | :) | 19:32 |
| Keybuk | I did just reply to your mail | 19:33 |
| Keybuk | wraiden: did you want to follow up on the copyright assignment bit? it seems there is a confusion there from JanC's comment | 19:34 |
| wraiden | mhm, if it's not needed anymore... | 19:38 |
| Keybuk | so let me clarify | 19:38 |
| wraiden | JanC was in the channel before i made my way back home from work and i asked it here ... | 19:38 |
| Keybuk | Canonical Ltd require Copyright Assignment for projects under their stewardship | 19:38 |
| wraiden | so i think JanC yust wanted to let me know | 19:39 |
| Keybuk | since I was employed by Canonical Ltd for the past seven years, that policy applied to Upstart too | 19:39 |
| Keybuk | however I left Canonical in January, and now work for Google Inc, who do not require copyright assignment | 19:40 |
| Keybuk | so the 1.0, 1.1 and 1.2 releases have contained patches for which copyright was not assigned by the authors | 19:40 |
| Keybuk | including myself, and google | 19:40 |
| wraiden | ah, ok, they allowed you to take the project with you?! | 19:40 |
| Keybuk | they released the project under the GPL | 19:40 |
| wraiden | german law is crazy about such things... | 19:40 |
| wraiden | jeah | 19:41 |
| wraiden | but the copyright... | 19:41 |
| Keybuk | they don't need to have "allowed" me | 19:41 |
| wraiden | ok | 19:41 |
| wraiden | the GPL is clear on that | 19:41 |
| wraiden | ok | 19:42 |
| Keybuk | so I continue to maintain Upstart | 19:42 |
| Keybuk | for the past six weeks, I was in discussions with Canonical about an appropriate way forward | 19:42 |
| Keybuk | but we had agreed a time limit (end of April) for those, and that was reached without an agreement | 19:43 |
| Keybuk | so things revert back to Upstart continues as a GPL project without any form of assignment | 19:43 |
| Keybuk | (one of the options was a relicense to Apache 2.0 so Canonical could continue to release private versions) | 19:43 |
| wraiden | good to hear that | 19:44 |
| Keybuk | so yeah, don't worry about it ;-) | 19:46 |
| wraiden | some of Lennarts FUD blogpost doesn't state the right information than... | 19:47 |
| Keybuk | *shock* | 19:47 |
| wraiden | pretty onesided function mentioning in his post as he doesn't looks out of his sandbox and just looks what of systemds functions were implemented in other inits... | 19:53 |
| wraiden | *writing kill signal code* | 19:55 |
| Keybuk | it's Lennart, I would expect nothing less | 19:56 |
| wraiden | yeah | 20:08 |
| wraiden | got that impression the day he introduced his audio stuff to gnome... | 20:08 |
| JanC | pulseaudio is mostly useful (now) ☺ | 20:19 |
| wraiden | yeah, now... | 20:27 |
| wraiden | first hack send to list now | 20:32 |
| wraiden | got rid of the signal == 0 then send sigkill as its clearer to just send SIGKILL as param in system_send_signal... | 20:33 |
| wraiden | *reading on xen-devel list* | 20:34 |
| wraiden | testsuite errors on my system on this: | 21:05 |
| wraiden | ...with error after modification of job | 21:05 |
| wraiden | BAD: wrong value for file, expected (nil) got 0xeb2a10 | 21:05 |
| wraiden | at tests/test_conf.c:709 (test_source_reload_job_dir). | 21:05 |
| wraiden | FAIL: test_conf | 21:05 |
| wraiden | expected? | 21:06 |
| wraiden | it's totaly unrelated to my changes as i tested an upstream version and get the error there also... | 21:07 |
| * wraiden goes and gets som sleep... | 22:50 | |
| wraiden | ... updated patch is out to the list now... | 22:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!