[09:04] <bac> good morning danilos
[09:11] <danilos> bac, oh, good morning
[09:11] <danilos> bac, how's UDS going so far?
[09:11] <bac> not used to people chatting here at this hour?  :)
[09:11] <bac> uds is good.  in a firefox translations session atm
[09:12] <bac> you can join at #ubuntu-uds-dery if you're interested
[09:13] <bac> danilos: ^^
[09:14] <danilos> bac, heh, right :)
[09:14] <danilos> bac, thanks, I'll join in, not sure I can participate heavily with all the other stuff I've got to do today
[09:15] <bac> danilos: np.  just thought i'd mention it.  certainly not required
[09:16] <danilos> bac, I can't hear anything, is something supposed to be happening atm?
[09:17] <bac> you should be able to hear
[09:17] <bac> others have said the audio was working
[09:17] <danilos> right, it might be my side then
[09:28] <bac> any audio now danilos ?
[09:28] <danilos> bac, nope
[09:28] <bac> i summoned elmo but he hasn't shown up yet
[09:28] <bac> now?
[09:29] <danilos> bac, I haven't used totem/vlc for playing these streams yet, so I can't be sure if it's not on my side (since I don't know if it ever worked)
[09:29] <danilos> bac, thus, I am not complaining loudly
[09:29] <bac> it isn't you
[09:55] <bac> sorry for the bad session, danilos.  did the audio ever work?  i had to leave early.
[09:55] <danilos> bac, yeah, 2 minutes before the end of it :)
[11:12] <danilos> gmb, hi, I see your fix for 772609 has landed, but even if I merge devel, I don't see the "mute link" show up when there is a direct team subscription on a bug
[11:14] <danilos> gmb, was that supposed to be fixed as well?
[11:21] <gmb> danilos: Hrm. Yes. Thanks for the heads-up.
[11:23] <danilos> gmb, np, I was hoping to wrap up bug 771204 fix, and noticed that mute link should show up even for team subscriptions; I'll take care of the JS side at least :)
[11:23] <_mup_> Bug #771204: mute link does not appear when a new direct subscription is made on a bug <story-better-bug-notification> <Launchpad itself:In Progress by danilo> < https://launchpad.net/bugs/771204 >
[11:42] <gmb> danilos: Ah, it got rolled back because it had the side effect of exposingd stuff for private bugs.
[11:43] <gmb> (Which caused OOPSes. William has filed a bug about it.)
[11:43] <danilos> gmb, oh... can we do something about it?
[11:44] <gmb> danilos: I think so. I need to check what the expected behaviour on private bugs actually is (William's bug suggests that getIndirectSubscribers() should always be empty in that case). Slightly odd that we don't have a test for that, but not wholly unsurprising :/
[11:46] <gmb> I'll have a proper dig around in a minute, just grabbing a drink first.
[11:47] <danilos> gmb, sure thing
[11:55] <danilos> gmb, also, I am a bit confused about the use of feature_flag_2 (advanced-STRUCTURAL-subscriptions flag) in test "test_mute_subscription_link_not_shown_for_non_subscribers" (regardless of your branch, because I am changing the link to always be in the DOM [but hidden] so JS can easily show it when needed)
[11:55] <gmb> Ok
[11:55] <gmb> danilos: Just pulling up that code now...
[11:56] <danilos> gmb, ack
[11:59] <gmb> danilos: Uhm. I'm not sure why that's there, actually. It's a change that bac made but I can't remember why it was done. It doesn't seem to serve any purposes, as far as I can tell.
[12:00] <gmb> danilos: I suspect that if you pull that with FeatureFixture line out the test will still pass.
[12:00] <danilos> gmb, yeah, it seems to be a bit silly test: asserts that link doesn't show up when feature_flag_1 is not on, which is a nice negative test, but a bit misnamed then
[12:00] <danilos> gmb, right
[12:02] <gmb> danilos: Yeah, it should set the flag to 'on', not None.
[12:02] <danilos> gmb, I'll clean up that test
[12:02] <gmb> Otherwise it's always going to pass.
[12:02] <danilos> gmb, it's the wrong flag as well, that's what made me wonder the most
[12:02] <gmb> Ah, yes, it is.
[12:02] <gmb> That tool.
[12:02] <gmb> Too*
[12:03] <gmb> (Not trying to say bac is a tool in any way, shape or form)
[12:03] <danilos> hahaha
[12:04] <danilos> ok then, I'll clean that test up to be only for "nothing shows up when the (right) flag is off"
[12:04] <danilos> and add a new one which tests all it needs to (along with the 'hidden' class which I am adding)
[12:04] <gmb> Right, cool.
[12:04] <gmb> Thanks :)
[12:05] <danilos> no, thank you for helping out :)
[13:35] <danilos> benji, gmb: shall we have a call?
[13:35] <benji> I'm fine either way.
[13:36] <gmb> I've nothing much to add to yesterday's to be honest.
[13:36] <gmb> OCR + rolled back branch is keeping me busy.
[13:36] <benji> pretty much the same here, finishing up one bug fix, about to do another
[13:38] <gary_poster> hi all
[13:38] <gary_poster> I'm just here for a sec
[13:39] <gary_poster> gmb, mockup ok?  you need my input for anything?
[13:39] <gary_poster> danilos, benji, everything ok with you all?
[13:39] <benji> gary_poster: things are peachy
[13:39] <gary_poster> yay :-)
[13:39] <gmb> gary_poster: I've only touched on them briefly this morning (so far so good); my branch from the weekend got rolled back as it caused some issues with private bugs, so I'm fixing that first.
[13:40] <gary_poster> gmb, ah, ok, makes sense
[13:40] <danilos> gary_poster, yeah, just fine, thanks :)
[13:40] <gary_poster> ok cool :-)
[13:40] <danilos> gary_poster, I am a bit late with the email, but it'll go out soon
[13:40] <gary_poster> cool
[13:40] <gary_poster> np
[13:40] <gary_poster> I'll run away then :-)
[13:40] <gary_poster> bye and have a great day!
[13:40] <danilos> cheers, tty tomorrow
[13:57] <bac> just saw the bug subscription notification window for the first time.  nice!
[15:11] <bac> the UDS session begins in five minutes.  follow along at #ubuntu-uds-krudy if you want.
[15:21] <gmb> benji, danilos: Can one of you review https://code.launchpad.net/~gmb/launchpad/bug-772609-again/+merge/60513 for me? It's my fix for the issue that caused wgrant to roll back last night's change; I've pasted the salient bits of the diff in a comment.
[15:22] <benji> gmb: sure
[15:22] <gmb> benji: Although I've pasted garbage, let me just update that...
[15:22] <benji> :)
[15:22] <gmb> Must've hit pageup before copying
[15:23] <gmb> benji: New comment has sensible diff.
[15:23] <benji> k
[15:25] <benji> gmb: done
[15:25] <gmb> benji: Ta
[17:25]  * danilos -> out