[09:04] good morning danilos [09:11] bac, oh, good morning [09:11] bac, how's UDS going so far? [09:11] not used to people chatting here at this hour? :) [09:11] uds is good. in a firefox translations session atm [09:12] you can join at #ubuntu-uds-dery if you're interested [09:13] danilos: ^^ [09:14] bac, heh, right :) [09:14] bac, thanks, I'll join in, not sure I can participate heavily with all the other stuff I've got to do today [09:15] danilos: np. just thought i'd mention it. certainly not required [09:16] bac, I can't hear anything, is something supposed to be happening atm? [09:17] you should be able to hear [09:17] others have said the audio was working [09:17] right, it might be my side then [09:28] any audio now danilos ? [09:28] bac, nope [09:28] i summoned elmo but he hasn't shown up yet [09:28] now? [09:29] bac, I haven't used totem/vlc for playing these streams yet, so I can't be sure if it's not on my side (since I don't know if it ever worked) [09:29] bac, thus, I am not complaining loudly [09:29] it isn't you [09:55] sorry for the bad session, danilos. did the audio ever work? i had to leave early. [09:55] bac, yeah, 2 minutes before the end of it :) [11:12] gmb, hi, I see your fix for 772609 has landed, but even if I merge devel, I don't see the "mute link" show up when there is a direct team subscription on a bug [11:14] gmb, was that supposed to be fixed as well? [11:21] danilos: Hrm. Yes. Thanks for the heads-up. [11:23] gmb, np, I was hoping to wrap up bug 771204 fix, and noticed that mute link should show up even for team subscriptions; I'll take care of the JS side at least :) [11:23] <_mup_> Bug #771204: mute link does not appear when a new direct subscription is made on a bug < https://launchpad.net/bugs/771204 > [11:42] danilos: Ah, it got rolled back because it had the side effect of exposingd stuff for private bugs. [11:43] (Which caused OOPSes. William has filed a bug about it.) [11:43] gmb, oh... can we do something about it? [11:44] danilos: I think so. I need to check what the expected behaviour on private bugs actually is (William's bug suggests that getIndirectSubscribers() should always be empty in that case). Slightly odd that we don't have a test for that, but not wholly unsurprising :/ [11:46] I'll have a proper dig around in a minute, just grabbing a drink first. [11:47] gmb, sure thing [11:55] gmb, also, I am a bit confused about the use of feature_flag_2 (advanced-STRUCTURAL-subscriptions flag) in test "test_mute_subscription_link_not_shown_for_non_subscribers" (regardless of your branch, because I am changing the link to always be in the DOM [but hidden] so JS can easily show it when needed) [11:55] Ok [11:55] danilos: Just pulling up that code now... [11:56] gmb, ack [11:59] danilos: Uhm. I'm not sure why that's there, actually. It's a change that bac made but I can't remember why it was done. It doesn't seem to serve any purposes, as far as I can tell. [12:00] danilos: I suspect that if you pull that with FeatureFixture line out the test will still pass. [12:00] gmb, yeah, it seems to be a bit silly test: asserts that link doesn't show up when feature_flag_1 is not on, which is a nice negative test, but a bit misnamed then [12:00] gmb, right [12:02] danilos: Yeah, it should set the flag to 'on', not None. [12:02] gmb, I'll clean up that test [12:02] Otherwise it's always going to pass. [12:02] gmb, it's the wrong flag as well, that's what made me wonder the most [12:02] Ah, yes, it is. [12:02] That tool. [12:02] Too* [12:03] (Not trying to say bac is a tool in any way, shape or form) [12:03] hahaha [12:04] ok then, I'll clean that test up to be only for "nothing shows up when the (right) flag is off" [12:04] and add a new one which tests all it needs to (along with the 'hidden' class which I am adding) [12:04] Right, cool. [12:04] Thanks :) [12:05] no, thank you for helping out :) [13:35] benji, gmb: shall we have a call? [13:35] I'm fine either way. [13:36] I've nothing much to add to yesterday's to be honest. [13:36] OCR + rolled back branch is keeping me busy. [13:36] pretty much the same here, finishing up one bug fix, about to do another [13:38] hi all [13:38] I'm just here for a sec [13:39] gmb, mockup ok? you need my input for anything? [13:39] danilos, benji, everything ok with you all? [13:39] gary_poster: things are peachy [13:39] yay :-) [13:39] gary_poster: I've only touched on them briefly this morning (so far so good); my branch from the weekend got rolled back as it caused some issues with private bugs, so I'm fixing that first. [13:40] gmb, ah, ok, makes sense [13:40] gary_poster, yeah, just fine, thanks :) [13:40] ok cool :-) [13:40] gary_poster, I am a bit late with the email, but it'll go out soon [13:40] cool [13:40] np [13:40] I'll run away then :-) [13:40] bye and have a great day! [13:40] cheers, tty tomorrow [13:57] just saw the bug subscription notification window for the first time. nice! [15:11] the UDS session begins in five minutes. follow along at #ubuntu-uds-krudy if you want. [15:21] benji, danilos: Can one of you review https://code.launchpad.net/~gmb/launchpad/bug-772609-again/+merge/60513 for me? It's my fix for the issue that caused wgrant to roll back last night's change; I've pasted the salient bits of the diff in a comment. [15:22] gmb: sure [15:22] benji: Although I've pasted garbage, let me just update that... [15:22] :) [15:22] Must've hit pageup before copying [15:23] benji: New comment has sensible diff. [15:23] k [15:25] gmb: done [15:25] benji: Ta [17:25] * danilos -> out === Ursinha-afk is now known as Ursinha