/srv/irclogs.ubuntu.com/2011/05/13/#launchpad-dev.txt

sinzuiwgrant: mumble?00:05
* sinzui wanders off to feed children00:08
wgrantsinzui: Sorry, here now.00:17
sinzuiHello wgrant. Do you have time to mumble?00:20
sinzuiwgrant: I also want a review of this script to remove projects without any license: http://pastebin.ubuntu.com/606665/00:21
jtvHas anyone else seen EC2 fail notfound-traversals.txt spuriously?   http://paste.ubuntu.com/606695/00:55
wgrantjtv: It was not spurious. I broke trunk for a few hours last night.00:56
wgrantjtv: How did the moldavian deletion go?01:10
wgrantAh, the question is gone. That is a good sign.01:10
wgrantThanks.01:10
LPCIBotProject db-devel build #544: STILL FAILING in 5 hr 30 min: https://lpci.wedontsleep.org/job/db-devel/544/01:14
lifeless-> airport to pick up family; bbiab01:18
jtvwgrant: broke trunk, eh?  well done!  I was getting nervous because my branch failed twice with different test failures.01:44
wgrantlifeless: rabbit failed lucid_db_lp01:50
LPCIBotProject windmill-db-devel build #273: STILL FAILING in 1 hr 10 min: https://lpci.wedontsleep.org/job/windmill-db-devel/273/01:54
LPCIBotProject devel build #713: STILL FAILING in 5 hr 34 min: https://lpci.wedontsleep.org/job/devel/713/01:56
LPCIBotProject windmill-devel build #75: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/75/02:23
jtvlifeless, back?02:49
wgrantHmm, only 541 timeouts yesterday?02:59
wgrantI guess UDS might be reducing it a bit... but 50%?03:00
jtvwgrant: how does it compare to previous UDSes?03:08
LPCIBotProject windmill-devel build #76: STILL FAILING in 45 min: https://lpci.wedontsleep.org/job/windmill-devel/76/03:09
jtvwgrant: I see you added a qa-untestable tag to my bug just around the time the tagger was supposed to add a qa-needstesting to it.03:16
jtvIt's actually qa-ok, but I wanted to avoid concurrency issues.03:17
wgrantjtv: Well, you removed the needstesting tag which upsets qa-tagger.03:17
wgrantYou can't remove QA tags until the revision is deployed.03:17
wgrantAlso, why was the tagger meant to add qa-needstesting?03:19
wgrantIt had already, but you removed it.03:19
wgrantAnd the next buildbot run won't finish for half an hour, and then an hour later it will tag the two involved bugs, neither of which are yours.03:20
wgrantSo, I am confuse!03:20
wgrantBut I am also hungry, so I shall lunch to resolve my confusion.03:20
wgrantOr at least defer it.03:20
jtvwgrant: the first branch was deployed, and the second was going to be deployed.03:21
jtvBoth on the same bug.03:21
lifelessjtv: yes03:25
jtvlifeless: didn't know how far a drive it was etc. :)  Trust all is well.03:25
jtvI wanted to ask for feed back03:26
lifelessyup03:26
jtv*feedback03:26
jtvabout the UI work I'm sketching out for async package syncs.03:26
lifelesssure, I'll be passing by the keybard for a bit, and once folk are settled, fully here.03:26
jtvOK, I'll start typing.  :)03:27
jtvWe have a Job for sync'ing packages into a derived distro.03:27
wgrantjtv: I still don't understand why the qa-needstesting tag was removed. But it seems all OK  now.03:27
jtvThere's a UI that shows differences between a derived distroseries and its parent(s).03:28
jtvThat's where you can request that some of these differences be synchronized, in various ways.03:28
jtvSome or all of these requests will be asynchronous.03:28
jtvAt first I tried to sketch out a way where the UI remembers "you requested async sync of packages [x, y, z]; these went into jobs {a: [x], b: [y, z]} (one job per source archive, but potentially multiple packages per job)03:29
jtv"03:29
jtvBut it's costly and awkward and ignores other pending requests.03:30
jtvIf you try to repeat a sync, you get an error.03:30
jtv(I'm not too enthusiastic about that notion, but there may be good reasons just outside my current field of view).03:30
jtvI want to break this down into stages that I/we can implement in realistic time: basics first, shiny later.03:31
jtvMy current plan: have the static page always (request or no request) show which of the visible distroseries differences have sync jobs pending.03:32
jtv(Polling and error reporting come later)03:32
jtvSince it makes no sense to repeat a pending sync request, I was thinking to _replace_ the checkbox next to a difference that's waiting to be synced away with a little watch as used elsewhere.03:33
wgrantIs that feasible in the current model?03:33
jtvI don't know.03:34
wgrant(it's the right thing to do, but I don't think it's efficiently doable without a separate jo)03:34
wgrant+b03:34
jtvI think you're talking about finding out which jobs are pending.  I'm talking about the UI.03:34
wgrantWe unfortunately already have a model to work within, and that needs to influence the UI decisions :(03:35
jtvYes yes yes I know.  But there is _some_ specificity to the search and I'm assured the queue won't be very large.03:35
wgrantIt will fairly often have thousands of packages.03:35
wgrantBut not terribly many jobs, perhaps.03:36
jtvPackages aren't where the cost is.03:36
jtvOther ways to find this out quickly lead to extra client/server interactions, which I expect to be much more costly.03:36
jtvWe know which jobs and which destination archive we're interested in when we render the page, and that helps; no need to send an API request from the client after rendering, listing the packages you're interested in.03:38
jtvIt may also be slightly jarring to have your view changed too long after the page has rendered, possibly with consequences for the placement of widgets you're about to click on.03:39
lifelessso03:40
lifelesswith queues, in general, we shouldn't assume we can tell whats in the queue03:40
lifelessthis is a rabbit limitation AIUI, and though we don't use rabbit today, I'm leery of depending on things we know it doesn't know03:40
jtvSensible, but I have a feeling that a lot will go overboard when we do that anyway.03:41
jtvMost of the wait, for one.03:42
lifelesswell03:42
lifelessthe latency is 60 seconds for a job runner03:42
lifelessnevertheless03:42
lifelesslets talk concurrency for a second03:42
lifelesstwo users may both submit a request to sync overlapping packages at the same time03:42
lifelessunless we are -very- careful in our model, we won't trigger unique constraints03:43
lifelessnot sanely03:43
lifelessI think if someone wants package version X synced from A to B03:43
lifelessand its queued twice03:43
lifelessshrug03:43
lifelesslet the second sync say 'noop, DONE'03:43
lifelessIMNSHO03:43
jtvSure, but...03:43
lifelessin other words, make syncing an idempotent operation03:44
jtvshrug03:44
jtvBeen over that for about as much as I feel we need to right now.03:44
wgrantIt's not quite that simple.03:44
lifelessjtv: ok03:44
wgrantBecause binaries are fun.03:44
jtvI'm saying it doesn't make much sense to request a repeated sync; not that I want to avoid it at all costs.03:44
jtvI was just thinking it might be a minimally invasive, yet effective way of expressing the situation: don't bother requesting a sync here, it's already pending.03:45
lifelessso, internet fail03:47
jtvThank you, Natty, for leaving a loophole that gives me access to the "reconnect" button on my chat client that you think I don't want to access ever.03:48
lifeless:>03:49
jtvTo repeat then:03:50
jtvIn the current pre-rabbit situation, this way of doing it has the advantage of making the first step in providing async visibility very easy to implement.03:50
jtvThe main questions for that are, I think: (1) does this display help the user at all?  (Actually I'd also want some kind of "sync pending" notice in there, obviously) and (2) does it form any kind of usable basis for the later steps (tracking progress, reporting errors) if we should decide to drop the jobs and use rabbit instead?03:52
jtvIf we later find that it becomes too difficult to mark pending syncs in the static page, we can always drop that bit.  But I would hope that unless and until that happens, the work will have helped us move closer to a "nice" UI.03:53
jtvTrying to do a "nice" UI right away would probably involve making the whole sync request Ajaxy to track the jobs it created (if any), which goes at the cost of getting the first bit of visibility into pending requests usable later than with this approach.03:55
lifelessI'm agnostic here03:56
lifelessI can see merits in both approachs03:56
lifelessI agree that they are to some degree at cross purposes03:56
lifelessI think from an adminny perspective we want to know about things stuck in the queue03:56
lifelessand to be able to fix (e.g. in the current code do a cancel) them03:56
jtvWell if a job fails, it fails.03:58
jtvIf it's stuck, the whole queue is stuck.03:59
jtv(Which should show up as oopses, I guess, though my UI would also show it as an increasing amount of pending differences in the display)03:59
jtvWe'd lose that advantage with rabbit I guess, but maybe at that point we'd just accept having to replace that visibility with something as a cost of moving ahead, and my current idea will have served its purpose as a stepping stone.04:00
jtvI hate being under the weather on a holiday.04:02
lifelessits a holiday?04:02
jtvWell my girlfriend says it is.04:02
jtvCan't find it online, but here you're never sure about those things.04:03
jtvWe do have something different next week, but my web searches put it at up to 3 different days this year, at a length of either 1 or 2 days.04:03
jtvNondeterministic calendars are a great job-security scheme for religious establishments.04:03
thumperI think Thailand has more holidays than any other place I know04:03
jtvI try not even to register the slightly iffy ones ("government holiday" etc.) but when you get right down to it, there's a vast sea of iffy holidays.04:04
jtvI believe in rare cases the official word comes down literally the day before.04:05
jtvNot to mention curfews and such.04:05
lifelessbah04:11
lifelesswhere is that bug about the 404 for pages depending on vhost04:11
jtvDamn, can't search for "404"!04:14
jtvbug 422960?04:14
_mup_Bug #422960: appear to be failing to record oops for all +translate HTTP 503 errors <canonical-losa-lp> <lp-foundations> <Launchpad itself:Triaged> < https://launchpad.net/bugs/422960 >04:14
jtvbug 626878?04:15
_mup_Bug #626878: pages only on subdomains cause user confusion (e.g. launchpad.net/project/+activereviews is a 404) <lp-foundations> <Launchpad itself:Triaged> < https://launchpad.net/bugs/626878 >04:15
jtvbug 574697?04:15
_mup_Bug #574697: Launchpad strips incoming TE header <lp-foundations> <Launchpad itself:Triaged> < https://launchpad.net/bugs/574697 >04:15
lifeless#626878:04:20
lifelessthanks04:20
_mup_Bug #626878: pages only on subdomains cause user confusion (e.g. launchpad.net/project/+activereviews is a 404) <lp-foundations> <Launchpad itself:Triaged> < https://launchpad.net/bugs/626878 >04:20
jtvUsed google with site:04:21
lifeless'None' is a subscriber to this bug apparently04:22
wgrantlifeless: I think your Chromium is bad :(04:23
lifelesswgrant: probably; how so?04:23
wgrantWell, BjornT is not None.04:24
lifelesswgrant: different bugs04:24
wgrantAnd the recipe owner picker works for everybody else.04:24
lifelessbug 73597204:24
_mup_Bug #735972: Person:+related-software timeouts <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/735972 >04:24
wgrant(can I close that picker bug now?)04:25
lifelesswgrant: give me a chance to dup04:25
lifelessit takes a while to reopen 70 or so tabs04:25
lifelessso I've been being productive in the meantime04:25
wgrantHeh04:26
lifelessopenid soooooo slow04:26
lifeless(well, our sso is)04:26
lifelessoh man +related-software has lots of room to improve04:30
lifelessughhhh04:42
lifelessI can't find this darn bug04:42
lifelessthe one about bzr push not being able to create a spn04:42
wgrantBug #38659604:43
_mup_Bug #386596: pushing to a packaging branch can't create a new package <codehosting-ssh> <lp-code> <package-branches> <Launchpad itself:Triaged> < https://launchpad.net/bugs/386596 >04:43
lifelesshth04:43
lifelessthanks04:43
wgrantFound using Launchpad's search, even.04:43
* wgrant stabs asuka.04:44
wgrantUpdate faster.04:44
lifelessthanks!04:44
* lifeless escalates04:44
lifelesswhats a sensible fs for an archive mirror?05:17
lifelessstub: so, yo06:25
stublifeless: yo06:26
lifelessshall we try skynet?06:26
stubI'm going to boot my laptop to try and narrow down issues - there is some other weirdness happening with that network card and natty.06:27
lifelessok06:27
=== stub1 is now known as stub
LPCIBotProject devel build #714: STILL FAILING in 5 hr 11 min: https://lpci.wedontsleep.org/job/devel/714/07:08
StevenKIs that more rabbit failure?07:14
StevenKWhy, yes, it is.07:14
wgrantStevenK: That happened on lucid_db_lp earlier.07:18
StevenKI've come to the conclusion that rabbit sucks, and I can't get it to start on the Jenkins build slaves. Not sure why that afflicts buildbot.07:20
wgrantlifeless: "Ubuntu currently has a problem with things that haven't built yet being unable to have bugs filed on them"07:22
wgrantHuh?07:22
wgrantIt's got nothing to do with builds.07:22
lifelessStevenK: https://bugs.launchpad.net/launchpad/+bug/655385/comments/1407:24
_mup_Bug #655385: Allow bug status change from Triaged only for bug supervisor <accesscontrol> <acl> <bugs> <lp-bugs> <Launchpad itself:Opinion> < https://launchpad.net/bugs/655385 >07:24
lifelessbah07:24
lifelessstub: https://bugs.launchpad.net/launchpad/+bug/655385/comments/1407:24
_mup_Bug #655385: Allow bug status change from Triaged only for bug supervisor <accesscontrol> <acl> <bugs> <lp-bugs> <Launchpad itself:Opinion> < https://launchpad.net/bugs/655385 >07:24
lifelesswgrant: orly?07:24
lifelesswgrant: whats it got to do with?07:24
wgrantlifeless: It's all source-based.07:24
wgrantDoesn't go near binaries.07:24
lifelesswgrant: source publication then ?07:24
wgrantYes.07:24
lifelessfine :>07:24
lifelesswgrant: so i didn't say builds in that bug07:29
wgrantUbuntu currently has a problem with things that haven't built yet being unable to have bugs filed on them07:29
lifelesswgrant: I said 'published packages', what was wrong with that ?07:29
wgrant"things that haven't built yet"07:30
lifelessah, fixorating07:30
lifelessthanks07:30
LPCIBotProject db-devel build #545: STILL FAILING in 5 hr 44 min: https://lpci.wedontsleep.org/job/db-devel/545/07:38
wgrantCurse you, lifeless! Escalating bugs :(08:14
wgrantStill, 215 criticals.08:14
wgrantWell, plus loggerhead, but we don't talk about him any more.08:15
jml24108:15
jmllaunchpad-project08:15
wgrantHm. I see 237.08:15
wgrantAre there private bugs I cannot see? :(08:15
wgrantlpstatus also sees 10-15 more than I can.08:15
jmlI see 234 now08:16
jmlyeah, lpstats counts by category08:16
wgrantStill 237 for me.08:16
wgrantAh, so if something is in more than one category it will show it twice?08:17
jmlhttp://paste.ubuntu.com/606803/08:17
jmlwgrant: exactly08:17
wgrant:(08:17
jml(space bar broken, slow typing)08:17
wgrantjml: Is that anonymous?08:17
wgrantI know of two private bugs, maybe there is a third.08:17
jmlwgrant: it's not anonymous08:18
LPCIBotProject windmill-db-devel build #274: STILL FAILING in 1 hr 10 min: https://lpci.wedontsleep.org/job/windmill-db-devel/274/08:19
wgrantThen why do I see 237 at https://bugs.launchpad.net/launchpad-project/+bugs?field.importance=Critical :(08:19
jmlhmm08:19
wgrantPossibly multi-task bugs.08:19
jmlI see that too08:19
jmland 234 on the portlet08:19
wgrantIndeed.08:19
wgrantPossibly 237 tasks, 234 bugs.08:20
jmlyeah, makes sense08:20
jmlhttp://pastebin.ubuntu.com/606805/08:21
wgrantAnyhow, minor progress.08:21
jmlthat's my script08:21
wgrantWe may finally be getting somewhere.08:21
wgrantThanks.08:21
jmlwgrant: -44 is awesome08:21
wgrantI also have four or five other fixes in review.08:21
wgrantSo we nearly made it to 50 for the week.08:21
jmlalso, for pie purposes, I'm not counting newly escalated bugs08:21
wgrantAh, excellent.08:21
wgrantThey always seemed a bit disenheartening.08:22
lifelesswgrant: sorry08:22
adeuringgood morning08:48
wgrantHmm, isn't hardy desktop EOL'd now?08:54
wgrantYes, yesterday.08:54
wgrantubuntu-mozilla-daily still builds for it :(08:54
wgrantAnd keeps lpia alive.08:54
wgrantDamn you lpia, damn you!08:54
StevenKIt was announced?08:55
wgrantA month ago.08:55
StevenKI think I have a little more hate for lpia than you :-P08:55
wgrantAt least I didn't mention Hildon.08:56
wgrantBecause that would just be mean.08:56
StevenKHULK SMASH08:56
mrevellHello09:00
StevenKallenap: Morning! Can you look at https://code.launchpad.net/~stevenk/launchpad/generic-overrides/+merge/60730 again?09:00
StevenKallenap: I think I've addressed your concerns, and have even written you a note.09:01
allenapMorning StevenK, sure I'll look at that now.09:07
wgrantBah.09:08
StevenKwgrant?09:08
wgrantallenap, jtv: Your packagecopyjob changes have conflicted in stable->db-devel.09:08
wgrantCould be a bit of a mess.09:08
jtvThanks for the notice.09:08
wgrantStevenK: I'm reasonably happy with your branch now.09:08
jtvWhat does tradition dictate?  Gloves or no gloves?09:09
allenapwgrant: Woohoo. Okay, I'll look in a minute, thanks for letting me know.09:09
jtvallenap: I'm checking it out right now09:10
allenapjtv: Awesome.09:10
StevenKWhich gives allenap more time to read my horrible diffs.09:10
wgrantBah, there's no functools.compose.09:11
wgrantHow stupid.09:11
jtvI haven't had to deal with this in the current devel/db-devel configuration... can I still branch off db-devel, merge in devel, resolve conflicts, and land into db-devel?09:11
wgrantjtv: Merge in *stable*.09:11
wgrantjtv: But yes.09:11
jtvahhh09:11
wgrantOtherwise you'll preempt buildbot.09:11
wgrantAnd make us all sad.09:11
jtvHmmm conflicts don't look very bad from here.09:11
wgrantThere is an apparent argument reordering.09:11
jtvOh that09:12
wgrantThe visible conflict is easily resolvable.09:12
wgrantBut there may be deeper things.09:12
wgrantThe change suggests that arguments have changed.09:12
wgrantOr that there may be additional IPackageCopyJobSource callsites.09:12
wgrantWhen it's now IPlainPackageCopyJobSource, and in a different module.09:12
jtvI switched two params around in the interface to make them match the implementation order.09:12
jtvShould have fairly minimal impact but oh, the trouble I had once with this kind of inconsistent parameter ordering between interface and model...09:13
wgrantStevenK: Hm, why do you eager load BPN and SPN?09:15
wgrantStevenK: Given that you get the IDs from the objects, you presumably have them already.09:16
StevenK"lol"09:16
StevenKI can just return the source object directly09:17
jtvOh blast I may lose connectivity.09:17
wgrantI also question the way you are given archtags and return DASes, but that may possibly be reasonable.09:17
StevenKwgrant: Because FromExistingOverridePolicy does it too09:18
wgrantBut you wrote that as well, so you can't reason against it :P09:18
StevenKOh, clearly09:18
StevenKSigh. Now calculateSourceOverrides() for UnknownOverridePolicy is 2 lines.09:20
wgrantWhy so many?09:21
wgrantOh, for default_component?09:21
StevenKYes09:21
wgrantcronscripts/foaf-update-karma-cache.py upsets me.09:22
StevenK+4, -16. I am an idiot09:23
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring | https://code.launchpad.net/launchpad-project/+activereviews
wgrantadeuring: Hi!09:23
adeuringhi wgrant!09:23
StevenKOh look, an OCR. *pounce*09:23
wgrantadeuring: https://code.launchpad.net/~wgrant/launchpad/bug-307269/+merge/60721 and https://code.launchpad.net/~wgrant/launchpad/bug-449561/+merge/60729 both need a review, if you could.09:23
adeuringwgrant: sure09:24
StevenKallenap: Are you blind yet? I have yet more changes, but I can hold off if you wish09:24
allenapStevenK: I've just approved it.09:24
=== almaisan-away is now known as al-maisan
StevenKallenap: Just glance at http://pastebin.ubuntu.com/606829/ then?09:25
allenapStevenK: Haha, oh yes :) +109:27
jtvallenap: few questions about the jobs!  I guess the version in source_packages would correspond to the parent_source_version in the DSD?09:27
* StevenK attempts to not swear about himself or wgrant in the commit message09:28
allenapjtv: Yes, I think so, but I'll check.09:28
wgrantStevenK: I didn't write those!09:28
wgrantMuch of the rest, sure...09:28
jtvallenap: it's also not always clear to me which lists of source-packages tuples are (name, version) and which have the third entry.09:28
StevenKwgrant: But you pointed it out, so pffft09:29
wgrantAh, I see.09:29
allenapjtv: Yes, I should probably land a branch to remove the ambiguity.09:29
jtvHeh... you may want to give my existing conflict branch time to settle.  :)09:30
jtvAny idea what time jools's demo is?09:30
allenapjtv: Yes, parent_source_version.09:30
jtvThanks.09:30
allenapNo, no idea.09:31
jtvMay be useful to be at the ready just prior & during.  ;-)09:31
jtvArgh!  Natty, stop switching my desktops around!09:31
StevenKjtv: I was planning on denying everything.09:32
jtvGood start.09:32
jtvBut you don't know how crafty he is.  He may lead with "Steve implemented this great feature here..."09:32
jtv<kaboom!>09:32
allenapwgrant: Btw, what would functools.compose do?09:33
wgrantallenap: functools.compose(f, g) would basically do lambda *args, **kwargs: f(g(*args, **kwargs))09:34
wgrantBut it was vetoed.09:34
wgrantBecause you can do it with a lambda.09:34
wgrantDespite the fact that you can do functools.partial even more cleanly with a lambda.09:35
allenapwgrant: Yes, odd decision.09:36
adeuringwgrant: one MPP approved.09:38
adeuringwgrant: your other MP looks good too. just one question: Bug 449561 says not only that anonymous users get the edit icon for the assignee, but also that anon users have the option to use "mark as duplicate". What about this problem? And did you check for other possible edit options presented to anon users, as mentioned in the bug report?09:58
_mup_Bug #449561: Bug task assignee picker shown to unauthenticated users <api> <lp-bugs> <oops> <Launchpad itself:In Progress by wgrant> < https://launchpad.net/bugs/449561 >09:58
wgrantadeuring: That was fixed at some indeterminable time in the past.09:59
wgrantadeuring: I can't see any other unguarded JS picker activations on the page.09:59
adeuringwgrant: ah. cool. so, r=me09:59
wgrantadeuring: Thanks!09:59
pooliefrancis just said he thought question comments were added to the api and curtis blogged about this10:44
pooliebut that doesn't seem to be true...10:44
jmlwhich bit?10:46
jmldid sinzui not blog?10:46
jmlor are they not in the API?10:46
poolieboth10:48
poolieneither seems to have happened10:49
pooliebut i might just be missing it10:49
wgrantjtv: How goes the conflict? My inbox is upset with it.10:51
wgrantI can have a look if you're busy/gone.10:51
stubI'm just looking at it10:55
stubwgrant: Or have you beat me?10:55
jtvI've had my fix reviewed.10:55
pooliejml, well, https://bugs.launchpad.net/launchpad/+bug/782093 it can be duped if appropriate10:56
_mup_Bug #782093: question/answer comments not available in api <api> <questions> <Launchpad itself:Triaged> < https://launchpad.net/bugs/782093 >10:56
lifelesspoolie: https://launchpad.net/+apidoc/devel.html#question10:57
stubjtv: The merge conflict or something else?10:57
jtvstub: the merge conflict.10:57
* stub uncommits and leaves it to jtv10:57
lifelesspoolie: ah, the questions collection isn't exposed.10:58
lifelessits controllable, but not exposed.10:58
lifelessquestions are exposed10:58
wgrantThe collection is exposed but not iterable.10:58
lifelessand the spam control knob is exposed10:58
lifelesswgrant: https://launchpad.net/+apidoc/devel.html#question has no comments_link10:59
lifelesswgrant: is that what you mean ?10:59
wgrantOh, you said questions collection.10:59
wgrantThe comments collection isn't, no.10:59
lifelessquestions comment collection, I meant10:59
wgrantRight.10:59
poolielifeless: right, the comments11:11
pooliei thought you closed a bug about this the other day11:11
pooliebut perhaps we were confused baout the comments vs the questions11:11
poolieanyhow, it would be nice for ISD but is not urgent11:11
wgrantWhat does ISD want them for?11:11
wgrantI thought they had other solutions for RnR.11:11
poolieapparently they get questions across a lot of projects and they want to summarize them11:12
wgrantAhh, so something more sensible this time :)11:12
wgrantThey shouldn't be too difficult to export.11:12
wgrantJust no point if nobody was going to use them.11:12
poolielifeless: in https://bugs.launchpad.net/launchpad/+bug/373078/comments/6 aaron says 'Needs fixing is meant to mean "This is approved but I'd like you to fix X"11:15
_mup_Bug #373078: code review merge status and docs need clarity, particularly for 'tweak' cases <code-review> <lp-code> <Launchpad itself:Triaged> < https://launchpad.net/bugs/373078 >11:15
poolieit's a shame launchpad's own use of them isn't consistent with that11:15
poolie</bignose>11:15
wgrantI thought Approve with comments meant that :/11:15
pooliebut perhaps that will get fixed11:15
poolieit seems quite ambiguous and inconsistent across projects11:15
poolieanyhow i shall try to remember that in future11:16
jtvDo I land conflict fixes with release-critical then?11:16
wgrantjtv: No.11:17
wgrantDoes it want it?11:17
wgrantI '[rs=wgrant][no-qa] Whatever'11:17
jtvSeems to, yes.11:17
wgrantI think you are probably misreading it.11:17
jtvCould well be.11:17
jtvI hate those messages.11:17
wgrantIt will probably accept release-critical=, but does not require it.11:17
wgrantWhat was your commit message?11:18
jtvAnd I also hate $#%@ unity hiding my windows from me.11:18
jtvHang on11:18
jtvManual submission notes: your submission message needs at least one of [r=...] [rs=...] or [release-critical=...] AND at least one of11:19
jtvAh, it was the other one that's missing.11:19
jtvno-qa.11:19
wgrantRight.11:19
jtvThe next attempt failed for yet other reasons.11:19
wgrantEven more confusingly, testfix is exempt from no-qa11:19
lifelesspoolie: the labels are a bit arbitrary11:19
lifelesspoolie: aside from that may /mean/, I think a label with 'needs' in it does not communicate 'should' or 'might'11:19
lifelesspoolie: thanks for trying to remember in future11:20
jtvWell, that seems to be in.11:21
pooliewell, i'm not an authoritative reviewer so semantically i can't say "must" anyhow11:22
pooliei guess it means "please consider this before merging"11:22
lifelessmmm, you're in the review team, so the ui shows you as authoritative11:23
lifelesseven if it showed you as community, it seems a courtesy not to send conflicting signals ;)11:23
lifelesspoolie: how has uds been?11:26
pooliesorry, i just set the status the way i would in bzr11:29
pooliejust wanted to save him needing to hmake a second submission11:29
pooliegood11:29
pooliesneezy11:29
poolieubuflu is in fine form11:29
lifelessheh, I'm very glad I'm not there then ;)11:31
poolieinteresting session right now about python versions11:33
pooliemm11:33
jtvI've been doing this work for too long.  My first reaction to the word "sneezy" was "oh they're planning Ubuntu releases up to S."11:33
poolieit seems like a lot of things are internal teem meetings11:33
lifelesspoolie: you got me curious, doc/developers/code-review.txt doesn't say how bzr uses votes11:34
lifelessand points at https://help.launchpad.net/Code/Review11:34
lifelessanyhow, enough of that11:34
lifeless10:30 on friday :)11:34
pooliethe informational or seminar type sessions are not clearly distinguished which means some of them turn out to be less interesting thatn you might think11:35
poolieup until wednesday the schedule churned a great deal11:35
poolieit was crazy11:35
poolieapparently the scheduler in a couple of cases thought it would be clever to schedule things into sessions that had already passed11:35
poolielook at all that wasted space last monday!11:35
pooliehave a good weekend11:36
LPCIBotProject windmill-devel build #77: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/77/12:53
LPCIBotProject db-devel build #546: STILL FAILING in 5 hr 17 min: https://lpci.wedontsleep.org/job/db-devel/546/12:56
gmbadeuring: Could you take a look at https://code.launchpad.net/~gmb/launchpad/bug-777783/+merge/60910 for me?13:26
adeuringgmb: sure13:32
gmbThanks13:32
wgrantgmb: Hi.13:33
gmbwgrant: Wotcher.13:33
wgrantgmb: I'm gardening our various queues, and noticed that you have two approved, unlanded branches from about 6 months ago.13:34
gmbOrly?13:34
gmbwgrant: I'll take a look, thanks for the heads-up13:34
wgrantFirst section of https://code.launchpad.net/launchpad/+activereviews13:34
gmbwgrant: I've marked them both merged (I think they were subsumed by other branches, IIRC). Thanks again.13:35
wgrantThanks!13:35
wgrantjelmer: https://code.launchpad.net/~jelmer/launchpad/publisher-use-debian-2/+merge/45011 appears to have been approved just days prior to your defection to bzr -- should I try to land it, or do you recall why it didn't?13:38
jelmerwgrant: feel free to land it13:43
jelmerwgrant, I didn't because I was worried I wasn't going to be able to deal with any fallout13:43
adeuringgmb: r=me13:48
wgrantjelmer: Ah, sure. I'll throw it at ec2.13:49
wgrantThanks.13:49
sinzuipoolie: jml: I have not made questions usable over the API yet. That is probably 2 branches away from being complete. jcsackett landed feature to hide question comments.13:50
wgrantsinzui: Hi. I was wondering if you could have a look at the tests in https://code.launchpad.net/~wgrant/launchpad/bug-449561/+merge/6072913:52
sinzuiokay13:53
sinzuiwgrant: I am a little apprehensive about the "client.waits.sleep(milliseconds=1000)" line. Is there an element that we could use "client.waits.forElement" instead?14:00
wgrantsinzui: That was my question.14:01
wgrantsinzui: I am checking for the absence of an element that is created asynchronously after page load.14:01
wgrantI don't know if there is some post-load event that I can hook into.14:01
LPCIBotProject windmill-db-devel build #275: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill-db-devel/275/14:02
wgrantsinzui: This is why I waited for you/deryck.14:02
wgrant'cause I don't really know how to avoid it.14:02
sinzuiwgrant: can't you use  forElement(HIDDEN_ASSIGN_BUTTON)? forElement is an assert14:04
wgrantsinzui: That14:04
wgrantThat's how the button is in the HTMl.14:04
wgrantThe JS hook changes it.14:04
wgrantI am asserting that it does not execute.14:05
sinzuiwgrant: We should at least use lp.testing.windmill.constants.SLEEP so that the test is consistent with other tests14:12
wgrantI had hoped to catch a deryck of some variety today, but that seems unlikely at this point :(14:14
gmbadeuring: Thanks for the review.14:14
sinzuiderycks now come in variety packs? I would like a green one please14:15
wgranthttps://lpbuildbot.canonical.com/builders/lucid_lp/builds/942/steps/shell_6/logs/summary is interesting.14:15
wgrantIs something pruning /tmp a bit aggressively?14:16
wgrantBoth rabbit and lp-serve complain about similar things.14:16
sinzuiwgrant: deryck is listed as on leave in canonicaladmin14:17
wgrantThis is unfortunate.14:18
wgrantI guess it will have to wait until next week.14:18
sinzuiHow can bac be off twice on the same day. If he is time traveling, I would advice not meeting himself. That always causes embarrassment.14:18
sinzuiwgrant: I don't think you need to wait given the large number of SLEEPs I see in windmill tests. Use the constant. That would be my only requirement to land.14:22
wgrantsinzui: Thanks. I know deryck hates it when people use sleep, but I don't see a clear way around it here.14:23
=== bigjools is now known as edbot
=== edbot is now known as bigjools
LPCIBotProject windmill-devel build #78: STILL FAILING in 46 min: https://lpci.wedontsleep.org/job/windmill-devel/78/14:48
bigjoolsman, LP is fast.14:55
LPCIBotProject devel build #715: STILL FAILING in 5 hr 30 min: https://lpci.wedontsleep.org/job/devel/715/14:59
StevenKbigjools: You're not being sarcastic14:59
StevenK?14:59
bigjoolsStevenK: a first for me, I know14:59
benjijcsackett: the new comment hide/unhide functionality is nice.  I wonder if we should make the hidden comments collapsed or something so they aren't quite so visible to those of us blessed with the ability to see them.15:15
wgrantI also think the "Mark as spam" button should probably turn into an icon somewhere near the comment number. But those are just tweaks -- I'm really glad I can remove my scripts now :)15:17
jcsackettbenji: that's a good idea.15:20
jcsackettwgrant: basically you mean move it from the footer to the header?15:21
wgrantjcsackett: And make it smaller.15:21
wgrantIt currently stands out a lot.15:21
wgrantPossibly it should be an edit icon next to the number that brings up the AJAX boolean picker.15:22
wgrantLike the one used for affects-me-too.15:22
jcsackettwgrant: not sure about the latter, i'm not a huge fan of multiclick steps for simple actions. but that's a personal preference.15:23
jcsackettyou may be right that it fits lp's flow better that way.15:23
wgrantYeah, fair point.15:23
wgrantIt may be OK to just move it to the header.15:23
wgrantBut it's a bit obtrusive at the momnet.15:23
jcsackettwgrant: yeah, it's a little on the big side now.15:23
* jcsackett makes note to file bugs on both those points.15:24
wgrantThanks for all your work on this.15:24
benjiIs the yellow background on "hidden" comments like the one on https://bugs.launchpad.net/launchpad/+bug/1234 common?  It kind of makes the spam stand out, which is ironic. :)15:24
_mup_Bug #1234: Gina is an unmaintainable mess of command line options, environment variables and shell scripts <lp-foundations> <Launchpad itself:Fix Released by debonzi> < https://launchpad.net/bugs/1234 >15:24
wgrantI'm not sure why a highlight was chosen :/15:24
jcsackettbenji, wgrant: i'm not sure about that either, but the hidden comment style was already established, and i didn't want to mess with css much at the time.15:27
benjisensible15:27
jcsacketti think it should be within a branch of work to turn the hidden comment style into a collapsible tho.15:27
jcsackettbac referred to the style as "eye-gouging" which isn't too far off the mark.:-P15:28
benjilol15:28
wgrantHeh15:28
wgrantMaybe it's there to convince us to stop the spam from arriving in the first place :)15:28
benjigood motivation indeed15:28
jcsacketti like that theory. it's not ugly, it's "motivational"15:28
jcsackett:-P15:28
* benji is good at creating "motivational" UI.15:29
* jcsackett laughs.15:29
benjiI guess that gives whole new meaning to "motivational speaker".15:30
jcsackettby this standard, that would be someone throwing things at you from the stage until you made something of yourself, right? :-P15:30
benjiI think it would be a very unattractive person speaking to you.  I might now qualify to be a motivational speaker.15:31
LPCIBotProject windmill-devel build #79: STILL FAILING in 47 min: https://lpci.wedontsleep.org/job/windmill-devel/79/15:35
pooliehi sinzui15:41
pooliei wasn't trying to rush you15:42
poolieit was just something that selene raised in a session here at UDS15:42
sinzuipoolie. Okay. I have not announced answers of the API because it is clearly not usable. When I can use it for my projects, and  I will blog about it15:47
jcsackettsinzui: are you, or do you know, a good person to grab for help on a blueprints question in #launchpad?15:49
sinzuiNo is a good person since no-one who wrote it or uses it works on Lp15:51
sinzuijcsackett: I will see if I can help15:51
pooliesinzui, i was misinformed and thought they were public15:54
poolieanyhow, she thanks you for adding them15:54
sinzuipoolie: I think many people misunderstood what was exported to allow admins to hide comments. It was a single method on question, not the actual objects15:55
poolieyes i misunderstood that16:01
pooliewell,16:01
pooliei think it's reasonable to want it regardless of your work16:03
poolieyou don't have to do it right now16:03
jcsackettwgrant, benji, poolie: just wanted to let you know the various feedback has been captured as filed bugs.16:29
benjigreat! thanks16:30
jcsackettpoolie: come to think of it, i *think* you provided feedback, i may have mixed up emails. :-P16:30
=== al-maisan is now known as almaisan-away
ToyKeeperpoolie: Thanks for getting that bug in the queue...16:38
=== Ursinha is now known as Ursinha-ohnomnom
ToyKeepersinzui: Not trying to rush you; I just mentioned it in a session today and poolie wanted to help.  :)16:40
ToyKeeper(I'm very happy that questions are being added and I don't have to do it myself!)16:41
sinzuiI am waiting the QA the change that allows me to add and remove my teams as answer contacts. I am starting the branch that lets you search for question in a couple hours16:42
ToyKeeperMy goal is to generate a list of open questions for a given team's projects, without having to check each one manually.16:43
ToyKeeper... just making it easier to do support for dozens of projects.16:44
sinzuiToyKeeper: then we are in  agreement. That is the actual test I am writing. When the test is complete, then I can blog that I have something useful16:44
ToyKeeperCool.  :)16:44
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews
=== Ursinha-ohnomnom is now known as Ursinha
=== matsubara is now known as matsubara-lunch
LPCIBotProject db-devel build #547: STILL FAILING in 5 hr 21 min: https://lpci.wedontsleep.org/job/db-devel/547/18:18
jcsackettsinzui: could you, if you get the time, look at https://code.launchpad.net/~jcsackett/launchpad/apocalyptic-messages-0/+merge/60953?18:24
jcsackettit's somewhat terrifying, but all mechanical, i believe, and you have a lot of experience with the apocalypse.18:24
sinzuijcsackett: I am reviewing it now18:42
sinzuijcsackett: 1. line 1008 shows the addition of the services.message package. I think that list is alphabetical.18:51
sinzuijcsackett: 2. You create a doc/ dir and moved tests there, but I do not see the test_doc.py that loads the the doctests. I was expecting something like lp.services.mail.tests.test_doc.py18:53
sinzuijcsackett: did you forget to commit test_doc?18:54
jcsackettsinzui: i think i may have.18:54
jcsackettone sec.18:54
jcsackettsinzui: yup, forgot the all important 'bzr add'.18:55
jcsackettit's pushed up now.18:55
* sinzui waits18:55
jcsackettsorry about that, sinzui.18:56
sinzuijcsackett: message.txt does not look special. It does not have a special setup, teardown or layer. Did you try the generic test_doc.py that is used in mail. I think it will work19:01
jcsackettsinzui: i don't think so, i just cribbed it from one of the services modules. i'll try out mail's version.19:01
sinzuialso, that test may play DatabaseFunctionalLayer. The layer it is using starts the librarian, which may not be needed19:02
* sinzui reads the test19:02
jcsackettsinzui: the layer is what it originally had in canonical; that said it may very well work with something else and i'm happy to change it.19:02
sinzuiAlmost everything in canonical.launchpad runs on the wrong layer. Always question why a test runs on the LaunchpadFunctionalLayer19:03
pooliethanks jcsackett, that's a good feature to have19:06
pooliei'm sure it will save time19:06
=== matsubara-lunch is now known as matsubara
jcsackettthanks, poolie.19:25
jcsackettsinzui: got it.19:25
sinzuifaboo19:25
jcsackettSickn3ss19:25
jcsackettfreaking unity lock up....19:26
LPCIBotProject windmill-devel build #80: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/80/19:27
jcsackettsinzui: the test needs the librarian; it's doing uploads on msgs. i changed the layer and get all sort of upload errors.19:33
sinzuiokay19:34
sinzuibut it does not need a special setup/teardown does it?19:34
jcsackettnope.19:34
jcsackettcribbing the test_doc in mail works fine but for the layer.19:35
sinzuigreat. r=me the land with that test19:37
jcsackettsinzui: cool, thanks.19:39
* jcsackett ssh's to reboot his dev machine. again.19:41
LPCIBotProject windmill-db-devel build #276: STILL FAILING in 49 min: https://lpci.wedontsleep.org/job/windmill-db-devel/276/20:17
LPCIBotProject devel build #716: STILL FAILING in 5 hr 27 min: https://lpci.wedontsleep.org/job/devel/716/20:26
LPCIBotProject windmill-devel build #81: STILL FAILING in 46 min: https://lpci.wedontsleep.org/job/windmill-devel/81/21:03
jcsackettsinzui: i have enabled thumb-click drag on ubuntu on my macbook.22:07
sinzui\o/22:07
jcsackettsinzui: follow the instructions here, even tho it is not for the 5-1 macbook.22:08
jcsacketthttps://help.ubuntu.com/community/MacBookPro7-1/Maverick#Touchpad22:08
* sinzui reads22:08
jcsackettyou will then need to muck about with sensitivity/acceleration some in the mouse settings.22:09
jcsackettb/c it becomes VERY speedy moving the cursor around.22:09
=== Ursinha is now known as Ursinha-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!