LPCIBot | Project db-devel build #548: STILL FAILING in 6 hr 21 min: https://lpci.wedontsleep.org/job/db-devel/548/ | 01:23 |
---|---|---|
LPCIBot | Project devel build #717: STILL FAILING in 5 hr 50 min: https://lpci.wedontsleep.org/job/devel/717/ | 02:17 |
=== Ursinha-afk is now known as Ursinha | ||
=== Ursinha is now known as Ursinha-afk | ||
=== almaisan-away is now known as al-maisan | ||
* al-maisan reads up on shape files, http://en.wikipedia.org/wiki/Shapefile | 05:05 | |
al-maisan | ECHAN | 05:05 |
al-maisan | sorry | 05:05 |
jtv | Any reviewers here to help out with a [testfix]? https://code.launchpad.net/~jtv/launchpad/testfix-post-conflict/+merge/60981 | 07:20 |
wgrant | jtv: Self-review it. | 07:24 |
wgrant | It's only changing tests. | 07:24 |
wgrant | And is pretty much trivial. | 07:24 |
wgrant | However, can't you leave makeDistroSeriesParent to create parent_series itself? | 07:25 |
jtv | wgrant: nothing is trivial when it comes to multi-parent. | 07:25 |
wgrant | Meaning you just have to add a self.factory.makeDistroSeriesParent(derived_series=series) line? | 07:25 |
wgrant | Heh | 07:25 |
jtv | This was that test where I elided makePerson to get under the 2-second bar. | 07:26 |
jtv | So I thought I might as well keep that. | 07:26 |
wgrant | Ah. | 07:26 |
wgrant | Anyway, you have my half-vote. | 07:27 |
jtv | Thanks. :) | 07:27 |
jtv | I suppose as a compromise, I could mentor your review. :) | 07:28 |
jtv | By the way, why don't you move to a country where you can legally start reviewing at 18? | 07:28 |
wgrant | Heh. | 07:28 |
jtv | I know, I know, technically it's the drinking that's not allowed. But one leads to the other. | 07:29 |
wgrant | AU isn't the US :) | 07:30 |
jtv | Good for you. But then why..? | 07:31 |
StevenK | That test can be made much simpler | 08:19 |
StevenK | dsp = self.factory.makeDistroSeriesParent() | 08:20 |
StevenK | And then use dsp.derived_series rather than derived_series | 08:20 |
LPCIBot | Project windmill-db-devel build #277: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-db-devel/277/ | 09:07 |
=== al-maisan is now known as almaisan-away | ||
LPCIBot | Project windmill-db-devel build #278: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-db-devel/278/ | 14:06 |
LPCIBot | Project db-devel build #549: STILL FAILING in 5 hr 37 min: https://lpci.wedontsleep.org/job/db-devel/549/ | 14:45 |
LPCIBot | Project windmill-devel build #82: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill-devel/82/ | 15:15 |
=== almaisan-away is now known as al-maisan | ||
=== al-maisan is now known as almaisan-away | ||
LPCIBot | Project devel build #718: STILL FAILING in 5 hr 30 min: https://lpci.wedontsleep.org/job/devel/718/ | 18:39 |
LPCIBot | Project windmill-db-devel build #279: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-db-devel/279/ | 19:49 |
LPCIBot | Project db-devel build #550: STILL FAILING in 5 hr 13 min: https://lpci.wedontsleep.org/job/db-devel/550/ | 19:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!