[00:33] <wgrant> lifeless: Successful builds don't send email.
[00:33] <wgrant> Except for recipes.
[00:33] <wgrant> But that's about to be fixed.
[00:34] <wgrant> maxb: I see the bug on +commentedbugs if I change the filter to not exclude closed bugs.
[00:37] <maxb> Whoops! I didn't even notice that there was a filter
[00:39] <wgrant> It's the same default one everywhere.
[00:40] <wgrant> There's probably a four-digit bug about that.
[00:43] <lifeless> wgrant: is https://bugs.launchpad.net/launchpad/+bug/570846 still in progress?
[00:43] <_mup_> Bug #570846: Archive freeze should not affect Partner <boobytrap> <lp-soyuz> <partner> <trivial> <Launchpad itself:In Progress by jelmer> < https://launchpad.net/bugs/570846 >
[01:06] <wgrant> lifeless: No.
[01:10] <wgrant> lifeless: You still can't repro the rabbit failure?
[01:10] <wgrant> It fails on both trunks here, but not lucid_lp, so it's something local.
[01:12] <wgrant> (I also had problems running this in U1, which is possibly relevant)
[01:25] <wgrant> it seems to start OK.
[01:25] <wgrant> erm
[01:28] <lifeless> wgrant: I can't repro
[01:29] <wgrant> It was /etc/hosts.
[01:29] <wgrant> 127.0.0.1 has to resolve to the hostname, not localhost.
[01:29] <wgrant> Which is not the default config.
[01:30] <wgrant> It starts fine on localhost, but then something tries to connect to the node @realhostname instead of @localhost, which fails.
[01:32] <wgrant> s/socket.gethostbyname()/localhost/ in fq_nodename works fine.
[01:32] <wgrant> But hmmm.
[01:33] <wgrant> We should talk to U1, I suppose.
[01:34] <wgrant> So, to unblock things let's get pilinut fixed?
[02:02] <StevenK> wgrant: I wonder if 127.0.1.1 <realhostname> works too
[02:04] <wgrant> No.
[02:04] <wgrant> That's there by default.
[02:06] <StevenK> Network-manager seems to add <IP> <hostname> to the top of /etc/hosts
[02:08] <wgrant> It does some evil stuff, but not that (at least for my wired desktop)
[02:11] <wallyworld_> wgrant: you know a bit about package build stuff, right?
[02:11] <wgrant> wallyworld_: Indeed.
[02:11] <wgrant> What's up?
[02:12] <wallyworld_> wgrant: bug 732343
[02:12] <_mup_> Bug #732343: Recipe source builds failing because of "Could not build because of missing dependencies" do not send notification email <recipe> <regression> <Launchpad itself:Triaged> < https://launchpad.net/bugs/732343 >
[02:12] <wgrant> aaaaaa
[02:12] <wallyworld_> wgrant: there's a unit test for notifications for dependency issues and i can't see why it would be failing
[02:12] <wallyworld_> by it, i mean the prod code
[02:12] <wallyworld_> i'm sure the test would pass
[02:13] <wgrant> wallyworld_: You're looking at a recipe build, not binary builds?
[02:14] <wallyworld_> wgrant: ah that may be it. i think i've got myself confused
[02:14] <StevenK> So, situation normal, then?
[02:14] <wgrant> This stuff has that effect on people.
[02:14] <wallyworld_> :-P
[02:15] <wallyworld_> so i need to find a sourcepackagebuild class analogous to the binarypackagebuild class?
[02:15] <wgrant> sourcepackagerecipebuild.
[02:16] <wallyworld_> right. i'm sad that extends a storm class and has all this business logic in it :-(
[02:17] <wgrant> That's how LP works :)
[02:17] <lifeless> wgrant: u1 or landscape
[02:18] <wallyworld_> wgrant: i think you meant to type :-(
[02:19] <wgrant> No, no, a forced smile of the "I cannot let myself realise how terrible this is or I will surely die" variety.
[02:20] <wgrant> zomg, armel is about to catch up.
[02:20] <wgrant> 272 builds left.
[02:20] <wallyworld_> wgrant: sort of like when your old aunty gives you a cardigan for xmas and you say "oh how lovely" through a forced smile
[02:21] <StevenK> I never had that problem -- it was usually my mother giving me clothes
[02:21] <wgrant> wallyworld_: Right.
[02:27] <lifeless> maxb: bug 5977
[02:27] <_mup_> Bug #5977: Person's Bugs pages do not show closed bug reports <lp-bugs> <Launchpad itself:Triaged> < https://launchpad.net/bugs/5977 >
[02:29] <wgrant> That's the one.
[02:29] <wgrant> lifeless: So, lucid_db_lp needs sorting out. Can you look at that?
[02:31] <StevenK> wgrant: rabbitmq likes neither 172.0.1.1 or the builder's IP <hostname> in /etc/hosts
[02:31] <StevenK> Er, 127.0.1.1
[02:32] <wgrant> StevenK: I had 127.0.0.1 localhost <hostname>. 127.0.0.1 <hostname> localhost unbreaks it.
[02:35] <StevenK> Hmm, that doesn't help.
[02:36] <wgrant> What's the error?
[02:37] <StevenK> FAILED - check /var/log/rabbitmq/startup_log, _err
[02:37] <wgrant> Need more than that.
[02:37] <wgrant> Erm, is this the system rabbit?
[02:37] <wgrant> Not the fixture?
[02:37] <lifeless> that looks like the system rabbit
[02:37] <StevenK> Tis
[02:37] <lifeless> which is going to be running shite wrapper scripts
[02:38] <wgrant> Yes.
[02:38] <StevenK> The fixture rabbit does not require the system rabbit to be running?
[02:38] <wgrant> No.
[02:38] <wgrant> It starts its own.
[02:38] <StevenK> Ah
[02:39] <lifeless> makes a homedir for it, unique nodename (by allocating a tmpdir in /tmp) etc
[02:39]  * StevenK branches devel on this builder so he can test
[03:20] <thumper> the dx channel is much quieter during my work day :-|
[03:21] <StevenK> thumper: That's what you get!
[03:21] <thumper> :)
[03:25]  * thumper moves away from coffee shop
[03:25] <lifeless> thumper: what are you hacking on atm?
[03:34] <cjohnston> Is 7 merge proposals for my very first day of looking at the launchpad code too much? ;-)
[03:37] <wgrant> Yes.
[03:37] <cjohnston> lol
[03:40] <lifeless> it shows great enthusiasm
[03:40] <lifeless> I hope that any stuff the reviews may need will be shallow
[03:40] <cjohnston> about half were pet peeves
[03:40] <cjohnston> and i learned at uds how to get into the code.. so that was a start
[03:48] <lifeless> can has review https://code.launchpad.net/~lifeless/launchpad/rabbit/+merge/61057
[03:48] <lifeless> lunch,then some analysis
[04:25] <wgrant> lifeless: Analysis of why the build is broken, I hope.
[04:27] <lifeless> regressions
[04:27] <lifeless> whats up with the build?
[04:28] <wgrant> lucid_db_lp is permanently broken by rabbit.
[04:28] <wgrant> Please fix it.
[04:30] <lifeless> hmm, otp not coming up
[05:05] <wgrant> wallyworld_: Any luck with the recipe notification thing?
[05:05] <wallyworld_> wgrant: https://code.launchpad.net/~wallyworld/launchpad/recipe-build-missing-dep-email/+merge/61058
[05:06] <lifeless> would windmill have caught bug 781460?
[05:06] <_mup_> Bug #781460: bugttask_index.js hide_assignee_team_selection handling broken <javascript> <qa-ok> <regression> <Launchpad itself:Fix Released by wgrant> < https://launchpad.net/bugs/781460 >
[05:06] <wgrant> lifeless: No.
[05:06] <wgrant> There was no test.
[05:06] <wgrant> But there is now.
[05:09] <wgrant> wallyworld_: So, that's not ideal.
[05:09] <wgrant> wallyworld_: Since it affects binary package builds too.
[05:09] <wgrant> wallyworld_: And they are automatically retried.
[05:09] <wallyworld_> wgrant: ok. i thought we wanted to send the email both times
[05:09] <wallyworld_> but i guess if they retry
[05:10] <wallyworld_> then no need for binary builds
[05:10] <wgrant> Right.
[05:10] <wallyworld_> ok. will fix. thanks
[05:10] <wgrant> Some have argued (eg. bug #218261) that depwait should notify after a time.
[05:10] <_mup_> Bug #218261: uploaders should get emails/notifications for packages in depwait mode <email> <lp-soyuz> <soyuz-build> <Launchpad itself:Triaged> < https://launchpad.net/bugs/218261 >
[05:10] <wgrant> But doing it every time would be bad.
[05:11] <wallyworld_> wow, that's an old bug
[05:11] <wgrant> Although we don't have common depwait loops any more, so it might be workable soon.
[05:11] <lifeless> wgrant: would that have ever worked ?
[05:11] <lifeless> wgrant: #781460: I mean
[05:11] <_mup_> Bug #781460: bugttask_index.js hide_assignee_team_selection handling broken <javascript> <qa-ok> <regression> <Launchpad itself:Fix Released by wgrant> < https://launchpad.net/bugs/781460 >
[05:11] <wgrant> lifeless: Yes, but it broke during a YUI upgrade.
[05:14] <wgrant> lifeless: Bug #728059
[05:14] <_mup_> Bug #728059: Manually editing the URL for a private branch allows user to access +new-recipe form <exploratory-testing> <recipe> <Launchpad itself:Triaged> < https://launchpad.net/bugs/728059 >
[05:14] <wgrant> You say it's critical because it exposes the existence of private branches.
[05:14] <wgrant> But we don't try to hide private branches.
[05:15] <lifeless> we do
[05:15] <lifeless> why do you say we don't?
[05:16] <wgrant> Because +index gives a 403, as most private objects do.
[05:16] <wgrant> In fact, that page 403s for normal users.
[05:16] <wgrant> Not critical.
[05:16] <wgrant> If you want private branches to 404, that's another bug.
[05:16] <lifeless> hmm
[05:17] <lifeless> I'll talk to flacoste I think
[05:43] <lifeless> wgrant: why was 714527 a regresion ?
[05:44] <wgrant> Bug #714527
[05:44] <_mup_> Bug #714527: owned widget structured strings render as bits of quoted html <qa-ok> <regression> <Launchpad itself:Fix Released by sinzui> < https://launchpad.net/bugs/714527 >
[05:44] <wgrant> lifeless: sinzui fixed some bug that I don't recall, which ended up breaking that.
[05:44] <wgrant> So, it was a regression.
[05:46] <wgrant> I think it was when he fixed the XSS in the item widgets that I reported in December.
[05:49] <lifeless> spiv: are you still working on 717094 ?
[05:49] <wgrant> Bug #717094
[05:49] <_mup_> Bug #717094: InvalidURL OOPS in translatePath because of URL containing non-ascii chars, again <oops> <regression> <Launchpad itself:Triaged by spiv> < https://launchpad.net/bugs/717094 >
[05:55] <lifeless> thumper: what made 721134 a regression ?
[05:59]  * wallyworld_ does the school pickup run
[06:27] <lifeless> wgrant: bug 732442 looks like fallout not a regression
[06:27] <_mup_> Bug #732442: disable_existing_builds compares series name to display name <recipe> <regression> <ui> <Launchpad itself:Fix Released> < https://launchpad.net/bugs/732442 >
[06:27] <lifeless> wgrant: I mean - was something actually broken, or was it just never correct?
[06:27] <wgrant> lifeless: It was actually broken.
[06:28] <wgrant> Note that a test failed.
[06:28] <lifeless> and windmill was disabled at the time ?
[06:29] <wgrant> yes.
[06:52] <wgrant> lifeless: Bug #728789 was a regression.
[06:52] <_mup_> Bug #728789: "Request build" dialog indicates builds are pending when they are not and doesn't allow new builds <qa-ok> <recipe> <Launchpad itself:Fix Released by wallyworld> < https://launchpad.net/bugs/728789 >
[06:52] <wgrant> People were unable to request builds that they could previously request.
[06:52] <wgrant> Because the new check was buggy.
[06:54] <lifeless> was there no previous check ?
[06:54] <wgrant> Correct.
[06:56] <lifeless> mmm
[06:56] <lifeless> so during dev of a beta feature
[06:56] <lifeless> I'm torn
[06:56] <wgrant> It was a Google beta.
[06:57] <lifeless> kindof
[06:57] <lifeless> lp-beta-users only
[06:57] <wgrant> It was in beta for 12 months.
[06:57] <wgrant> It was not a major user-affecting regression.
[06:57] <wgrant> But does that mean it wasn't a regression?
[06:59] <lifeless> thats not what I meant
[06:59] <lifeless> there was an arc of development
[06:59] <lifeless> during that arc things were tightened up to enforce new policies
[06:59] <lifeless> and some of those changes had bugs
[06:59] <wgrant> Yes.
[06:59] <wgrant> And they broke some functionality.
[06:59] <wgrant> => regression
[06:59] <lifeless> they broke two things
[07:00] <lifeless> one that unlimited builds in a day could be done manually
[07:00] <lifeless> and second that the logic for detecting that was flawed
[07:01] <lifeless> which is why I'm saying that I'm torn
[07:02] <wgrant> Erm, what's this about unlimited builds in a day?
[07:02] <wgrant> This is unrelated to the quota.
[07:03] <lifeless> maybe I'm misunderstanding the exact circumstances
[07:04] <wgrant> The check was to prevent people from requesting builds that were already queued.
[07:05] <wgrant> Unrelated to the silly 5-a-day quota.
[07:05] <wallyworld_> the request builds popup dialog was new and when deployed, there was a bug found, so not a regression
[07:05] <wallyworld_> it was a bug in a new feature
[07:05] <wgrant> wallyworld_: Hm? Users were unable to request builds manually where they could before.
[07:05] <wgrant> The AJAX form replaced the non-AJAX one, which worked fine.
[07:06] <wallyworld_> the request build popup was totally new - before that it was html without ajax
[07:06] <wgrant> Sure.
[07:06] <wgrant> It was a new UI,.
[07:06] <wgrant> Replacing an existing UI.
[07:06] <wgrant> And breaking part of that functionality.
[07:07] <wgrant> If I replace apt-ftparchive with NMAF, we lose a lot of functionaliaty. It's totally new, but still a regression.
[07:07] <wallyworld_> the old one was still available. but my view is that a bug in a new feature is not a regression
[07:07] <wgrant> There was an unobvious workaround, sure.
[07:07] <wgrant> (one which is itself a bug)
[07:07] <wallyworld_> i guess it depends on the definition of regression. imo, regression means a break in existing code
[07:08] <wgrant> Users don't care about code.
[07:08] <wgrant> They care about functionality.
[07:08] <wallyworld_> not all workj arounds are obvious, but htere was one
[07:08] <StevenK> Existing *functionality&
[07:08] <StevenK> s/&/*/
[07:08] <wgrant> Before the change: users could request a manual build by clicking the "Request builds" link.
[07:09] <wgrant> After the change: users were erroneously prevented from requesting a manual build by clicking the "Request builds" link.
[07:09] <wallyworld_> agreed. but it was a bug in totally new code. so i can see both sides :-)
[07:10] <wgrant> Users do not care about code!
[07:10] <wgrant> If I delete all of our code, it is not a bug in the code!
[07:10] <wgrant> But it is still a regression.'
[07:10] <wallyworld_> replace "new code" with "new functionality"
[07:10] <wallyworld_> it was new functionality
[07:10] <wallyworld_> in a sense
[07:10] <wgrant> It was a replacement interface for existing functionaliaty.
[07:11] <wallyworld_> for a feature that was still under development in beta
[07:11] <wgrant> Very late beta.
[07:11] <wallyworld_> but technically not officially released
[07:11] <wallyworld_> we should be down the pub having this discussion over a beer :-)
[07:12] <wallyworld_> i'm just stirring the pot a bit :-)
[07:12] <wgrant> Heh.
[07:12] <StevenK> wallyworld_: Just because the feature isn't released doesn't mean it isn't a regression.
[07:12] <wgrant> It is less important.
[07:12] <wgrant> But not not a regression.
[07:12] <wallyworld_> i'll go away now. in all honestly, i don't really care one way or the other. just going a bit stir crazy
[07:12]  * StevenK hits wgrant with the double-negative stick
[07:17] <lifeless> wgrant: why was 766874 a regression ?
[07:18] <wgrant> Bug #766874
[07:18] <_mup_> Bug #766874: Inline bug assignment for non-contributors broken in Firefox 3 <javascript> <qa-ok> <regression> <ui> <Launchpad itself:Fix Released by wgrant> < https://launchpad.net/bugs/766874 >
[07:19] <wgrant> lifeless: wallyworld had fixed another regression (I forget the number... the one about inline assignment to a non-contributor not giving a warning), and it was borked in Firefox 3.
[07:19] <wgrant> Windmill caught it.
[07:19] <wgrant> But was disabled at the time.
[07:20] <lifeless> what about bug 768336
[07:20] <_mup_> Bug #768336: Subscribing to a bug doesn't show display name on FF4 <qa-untestable> <regression> <story-better-bug-notification> <Launchpad itself:Fix Released by benji> < https://launchpad.net/bugs/768336 >
[07:20] <wgrant> I wasn't involved in that one. I don't know if it was related to the new subscription work.
[07:20] <lifeless> I really wish I could click on links after viewing the merge diff
[07:21] <wgrant> Hmmm, I saw that once locally.
[07:21] <wgrant> Last week.
[07:21] <wgrant> Thought it was a browser glitch.
[07:21] <wgrant> But I guess not.
[07:28] <lifeless> wgrant: what makes bug 780429 a regression (other than being a daft change)
[07:28] <_mup_> Bug #780429: CopyChecker.checkCopy uses check_permission badly <lp-soyuz> <regression> <Launchpad itself:Fix Released by wgrant> < https://launchpad.net/bugs/780429 >
[07:28] <lifeless> wgrant: was it functionally wrong, or just high risk / would break if we changed other assumptions?
[07:29] <wgrant> lifeless: The fact that it called check_permission was high risk.
[07:29] <wgrant> The fact that it always used the primary archive was a security vulnerability.
[07:29] <lifeless> ok
[07:34] <lifeless> https://dev.launchpad.net/Regressions2011#preview
[07:35] <wgrant> You win lots of points for doing that, but lose several for unreadability.
[07:35] <StevenK> That page is barely readable
[07:36] <lifeless> yes
[07:36] <lifeless> its a draft
[07:36] <StevenK> And 780429 should be badtest
[07:36] <wgrant> notest sideffect 777766 the list of subscribers for gtk bugs is empty
[07:36] <wgrant> badtest, surely.
[07:37] <lifeless> StevenK: there was a test for permissions on different archives?
[07:37] <StevenK> There certainly was a few testcases for rvb's work, I can't recall what they did
[07:37] <wgrant> A relevant test was added at the time of the change.
[07:38] <wgrant> But it had the same misunderstanding.
[07:39] <lifeless> so
[07:39] <lifeless> uhhm
[07:39] <lifeless> if you know better, please fix
[07:39] <lifeless> I intend badtest to be when the test intent would cover the thing that was faulty
[07:40] <wgrant> Ah.
[07:40] <lifeless> so a test whose intent was to check something funky
[07:40] <lifeless> and it successfully checked that
[07:40] <lifeless> is not a badtest
[07:40] <lifeless> the real problem had no test aiming to cover it
[07:40] <lifeless> and the tests have to exist before the change
[07:41] <lifeless> otherwise its notest
[07:41] <lifeless> I'll add some prose to that effect after dinner
[07:41] <wgrant> notest sideeffect 754089 launchpad only remembers alternate landing targets in merge proposal creation page for one day
[07:41] <wgrant>   [r=jcsackett,
[07:41] <wgrant>   	sinzui][ui=none][bug=541713] Skip targets from old proposals.
[07:41] <wgrant> Looks more deliberate than a sideeffect.
[07:42] <lifeless> it was meant to clean up after a while
[07:42] <lifeless> the knob is wrong
[07:42] <wgrant> Hm.
[07:42] <wgrant> That rev set it to 90 days.
[07:43] <wgrant> rofl
[07:43] <lifeless> could be badtest
[07:43] <wgrant> No, it *says* it set it to 90 days.
[07:43] <wgrant> But it set it to 1.
[07:44] <wgrant> The relevant line (with days=1) was last changed in r12165.1.2, with a commit message of "The widget for selecting merge targets ignores proposals older than 90 days"
[07:44] <wgrant> So, not a side-effect, nor really a badtest, because the relevant test was only added then.
[07:44] <wgrant> Perhaps reviewfail.
[07:50] <lifeless> well
[07:50] <lifeless> I think I'd argue badtest
[07:50] <lifeless> the test that the thing is preserved doesn't really keep the user story intact
[07:50] <lifeless> anyhow, please fix it up
[07:50] <lifeless> I put it on the wiki deliberately :)
[07:51] <wgrant> Yeah.
[07:51] <wgrant> Well.
[07:51] <wgrant> I'm fixing the bug instead :)
[07:52] <lifeless> as for the sideeffect
[07:52] <lifeless> there was a bug that they accumulated forever
[07:52] <lifeless> with no way to edit/fix
[07:52] <lifeless> this regression was added while fixing that bug
[07:53] <wgrant> That is cutting it very fine.
[07:53] <wgrant> But OK.
[07:59] <wgrant> lifeless: Bug #778847 broke notifications for everybody for any bug that had an affected subscriber.
[07:59] <_mup_> Bug #778847: Muting a bug subscription for a team with a contact address crashes getRecipientFilterData <oops> <story-better-bug-notification> <Launchpad itself:In Progress by yellow> < https://launchpad.net/bugs/778847 >
[08:00] <wgrant> It was probably the most critical regression we have had in months.
[08:00] <wgrant> It was only by very good luck that it didn't became a serious incident.
[08:00] <wgrant> If any regression this quarter needs analysis, it is that one.
[08:07] <wgrant> Ahh, that MP target test was flawed in a couple of other ways, too.
[08:08] <wgrant> killall launchbag
[08:33] <adeuring> good morning
[08:36] <jtv> hi adeuring
[08:36] <adeuring> hi jtv!
[08:43] <lifeless> wgrant: so, it could only affect muted teams, which could only happen to beta users
[08:43] <wgrant> lifeless: No.
[08:43] <lifeless> wgrant: no?
[08:43] <wgrant> lifeless: It affects all notifications to anyone from bugs which might have sent notifications to a muted team.
[08:44] <wgrant> The mute breaks recipient calculation for the whole bug.
[09:06] <LPCIBot> Yippie, build fixed!
[09:06] <LPCIBot> Project devel build #719: FIXED in 5 hr 30 min: https://lpci.wedontsleep.org/job/devel/719/
[09:06] <wgrant> !!!!!
[09:06] <wgrant> Well done StevenK.
[09:07]  * StevenK takes a bow.
[09:08] <lifeless> StevenK: cool
[09:08] <lifeless> StevenK: thanks!
[09:09] <lifeless> is bug 740584 a regression as well?
[09:09] <_mup_> Bug #740584: Build lacks a corresponding source publication <oops> <regression> <Launchpad itself:In Progress by wgrant> < https://launchpad.net/bugs/740584 >
[09:09] <lifeless> ah yes
[09:09] <lifeless> win
[09:10] <wgrant> Yes :(
[09:10] <StevenK> That bug makes me sad
[09:10] <lifeless> wgrant: could you add to https://dev.launchpad.net/Regressions2011#preview ?
[09:10] <wgrant> The rationale given for the assertion was false.
[09:10] <wgrant> Sure.
[09:11] <wgrant> Done.
[09:12]  * wgrant stabs bug heat.
[09:12] <wgrant> DIE
[09:17] <lifeless> wgrant: what triggered that outnyurst
[09:17] <StevenK> Clearly, bug heat did *something*.
[09:18] <wgrant> lifeless: Timing out on DF.
[09:18] <wgrant> In particular, selecting the maximum heat for a context.
[09:18] <wgrant> But it is horrible on qas as well.
[09:18] <wgrant> When updating.
[09:18] <mrevell> Hallo
[09:28] <lifeless> spiv: are you still working on bug 717094 ?
[09:28] <_mup_> Bug #717094: InvalidURL OOPS in translatePath because of URL containing non-ascii chars, again <oops> <regression> <Launchpad itself:Triaged by spiv> < https://launchpad.net/bugs/717094 >
[09:34] <spiv> lifeless: I don't think I ever started working on that, so no :/
[09:34] <lifeless> spiv: it is assigned to you
[09:34] <lifeless> spiv: by poolie
[09:34] <spiv> Yeah, I see the bug history
[09:34] <lifeless> :)
[09:43] <bigjools> wgrant: do you remember if there are bugs filed about the soyuz uploader oopses that are not oopses?
[09:49] <poolie> hi all
[09:56] <bigjools> lifeless: how much longer are you around?
[09:56] <lifeless> I'm not at all, but I can be if needed, if that makes sense.
[09:56] <bigjools> not urgent, I just wanted to fill your head with something I learned at UDS
[09:57] <bigjools> some nice architecture that the Landscape guys use, which I also want to use
[09:57] <lifeless> the notification server?
[09:57] <bigjools> yarp
[09:57] <lifeless> yeah
[09:57] <lifeless> I'm aware of that
[09:57] <bigjools> ahy coolio
[09:57] <lifeless> we have a few things we'd need heavy lifting on to start using it
[09:57] <lifeless>  - need to arrange open sourcing of it
[09:58] <bigjools> totally
[09:58] <lifeless>  - need a long-poll infrastructure w/rabbit
[09:58] <lifeless> bah
[09:58] <lifeless> s/rabbit/haproxy
[09:58] <bigjools> right
[09:58] <lifeless>  and need someone to put the effort in to get familiar with it and work out how it all hangs together.
[09:59] <lifeless> I'm totally supportive if you/your team want to do that; whether it should be a notification server or a subscription-with-callbacks server is an interesting question but not one that should impede adopting an improvement on what we have
[10:00] <bigjools> lifeless: well my first iteration is to make a job get initiated by rabbit instead of cron
[10:00] <lifeless> yah
[10:00] <lifeless> I think thats quite self contained
[10:00] <bigjools> since we're blocked on open sourcing that component ...
[10:00] <lifeless> signal after commit in the webserver
[10:00] <wgrant> bigjools: Yes.
[10:00] <wgrant> Finding...
[10:01] <lifeless> have the job be a daemon not a script
[10:01] <bigjools> wgrant: they are easy criticals :)
[10:01] <wgrant> bigjools: But there's only two of them.
[10:01] <lifeless> and the message just needs to be 'poll now dammit'
[10:01] <wgrant> But yes, I was going to look at them in my last week.
[10:01] <bigjools> lifeless: right.
[10:01] <lifeless> so if a message doesn't get through, the next message sent will trigger all the jobs anyway
[10:01] <wgrant> But that code is terrible :(
[10:01] <poolie> o/ wgrant, bigjools
[10:01] <wgrant> Evening poolie.
[10:01] <bigjools> hey poolie
[10:01] <lifeless> bigjools: at least, thats whats in my head
[10:02] <lifeless> bigjools: I'm sure there are other ways that would be equally fine
[10:02] <bigjools> lifeless: same as my head
[10:02] <bigjools> needs to be a daemon at the least, zopeless startup cost is stupid
[10:02] <bigjools> talking of which, I'd really like to split up the zcml so we don't need to load it all for simple scripts
[10:02] <wgrant> Oh, Landscape has a rabbit-based long-poll server?
[10:03] <bigjools> yes
[10:03] <wgrant> !!
[10:03] <lifeless> if it was zopeless it might not be so slow :P
[10:03] <wgrant> Mine, now.
[10:03] <bigjools> well, twisted + rabbit
[10:03] <lifeless> wgrant: hah :)
[10:03] <wgrant> I should try landscape at some point.
[10:03] <lifeless> I'm pretty sure they brought it up in one of hte first perf tuesday mails
[10:03] <bigjools> lifeless: yes "zopeless" is the worstest name evar
[10:03] <lifeless> I've known about it for a while
[10:03] <lifeless> bigjools: it was accurate, once.
[10:13] <wgrant> Hmm, only 107 bad builds.
[10:14] <poolie> wow, multiple new community patches
[10:14] <poolie> superb
[10:15] <wgrant> poolie: Yes!
[10:15] <wgrant> :( but 69 of them have binaries.
[10:15] <poolie> ?
[10:15] <poolie> i meant the lp mps from christjohnston
[10:15] <wgrant> The binary comment was about the 107 bad builds.
[10:16] <wgrant> The swarm of cjohnston MPs is undoubtedly a great thing :)
[10:16] <poolie> if only lp karma was correlated with actual moral karma
[10:16] <poolie> someone came up to me at uds and said "wow, you have so much karma"
[10:17] <wgrant> Heh.
[10:17] <bigjools> lifeless: have you had any ideas about better searching in LP?
[10:17] <bigjools> I need to improve the stuff we've done for derived distros
[10:17] <poolie> i wonder if i could get hi to fix the mp breadcrumbs so that they include the list of all mps
[10:19] <poolie> which is https://bugs.launchpad.net/launchpad/+bug/487893
[10:19] <_mup_> Bug #487893: mp breadcrumbs should link back to list of merge proposals <code-review> <lp-code> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/487893 >
[10:21] <wgrant> WTF
[10:22] <wgrant> bigjools: What sort of DB surgery history to ppa:ubuntu-security/ppa have?
[10:22] <wgrant> s/to/does/
[10:22] <poolie> jml: hi, you'd be welcome to drop by our sprint if you feel like it
[10:22] <lifeless> bigjools: lucene/lucandra
[10:23] <wgrant> Because there's some stuff here that I don't think could have occurred naturally.
[10:24] <bigjools> wgrant: what?
[10:25] <wgrant> bigjools: BPB 690398 (a kernel build from May 2010) has an armel build in ppa:ubuntu-security/ppa.
[10:25] <bigjools> lifeless: I need to add the capability to search for more different types of data.  I don't want a form like the advanced bugs search form and wondered if you'd got something we can implement this cycle?
[10:25] <wgrant> Sorry, BPB 1758733, SPR 690398
[10:25] <wgrant> But that SPR has no publications!
[10:25] <wgrant> Anywhere.
[10:25] <wgrant> I suspect someone hacked them out of the DB.
[10:25] <bigjools> wgrant: yes, they asked for a publication to be removed
[10:26] <bigjools> since they uploaded a bogus version
[10:26] <lifeless> bigjools: so the advanced bugs form is just fugly
[10:26] <wgrant> ಠ_ಠ
[10:26] <bigjools> lifeless: putting it lightly
[10:26] <lifeless> bigjools: uhm
[10:26] <lifeless> bigjools: so there are a few things that are pretty low hanging
[10:26] <lifeless> one is a search language
[10:26] <lifeless> like
[10:26] <lifeless> binaryname:foo
[10:26] <lifeless> package:bar
[10:26] <lifeless> etc
[10:27] <bigjools> so far so good, that's what we thought of
[10:27] <lifeless> this is pretty easy to do
[10:27] <lifeless> something that can make that discoverable is an advanced for which generates the search using that scheme
[10:28] <lifeless> this is what google's advanced search pages does, for instance.
[10:28] <lifeless> s/for/form/
[10:28] <wgrant> baaaah
[10:28] <lifeless> another possibility is to implement a small facet engine
[10:28] <wgrant> Partner import fail.
[10:28]  * wgrant kicks gina.
[10:29] <wgrant> Someone clearly didn't test it at all before running it :(
[10:29] <wgrant> It imported all the -commercial builds into the primary archive, while the sources correctly ended up in partner.
[10:30] <bigjools> ha
[10:30] <lifeless> bigjools: you're familiar with facets?
[10:30] <bigjools> lifeless: in what context?
[10:30] <lifeless> searching
[10:30] <bigjools> I know less than fuck all about searching
[10:30] <StevenK> wgrant: Should we remove the builds?
[10:31] <bigjools> I am here to be edumacated!
[10:31] <lifeless> http://www.google.com/search?sourceid=chrome&client=ubuntu&channel=cs&ie=UTF-8&q=facet+search
[10:31] <lifeless> first two hits look sane
[10:31] <bigjools> yeah
[10:31] <lifeless> bigjools: basically you divide up your data into a bunch of dimensions and then offer click/dropdown/checkbox selection for filters by each dimension
[10:31] <bigjools> oh one more thing
[10:32] <bigjools> (right)
[10:32] <bigjools> they want to search using substrings :/
[10:32] <lifeless> bigjools: so you start with some sort of default that makes sense, and folk can click filters off, or on.
[10:32] <lifeless> bigjools: when do you want to be finished?
[10:32] <bigjools> before Dublin
[10:33] <lifeless> bigjools: what size is the corpus?
[10:34] <bigjools> lifeless: I suspect a few thousand packages
[10:34] <lifeless> as long as we have the package names normalised we can do that tolerably fast:
[10:35] <lifeless> select * from sourcepackagename where name like '%foo%';
[10:35] <lifeless> Time: 23.916 ms
[10:35] <lifeless> the reason the bug one is fail is because its not normalised
[10:35] <bigjools> what do you mean by normalised, exactly?
[10:35] <lifeless> each unique string should be assessed only once
[10:36] <lifeless> there are substring capable engines for postgresql
[10:36] <lifeless> using trigrams and so forth
[10:36] <lifeless> but we don't have any in production yet
[10:36] <lifeless> I think its high risk to make your work contingent on getting that into prod
[10:36] <lifeless> IM BW
[10:37] <bigjools> I'll make it optional anyway, forcing substring has other issues
[10:38] <lifeless> is there a LEP about the search facilities needed?
[10:38] <bigjools> no, this is something that came up at UDS
[10:38] <lifeless> I could read up and then we could have a call to look for issues
[10:38] <bigjools> I need to add my writeup to the LEP
[10:39] <wgrant>    id   | sourcepackagename |   version    | upload_archive | count | count
[10:39] <wgrant> --------+-------------------+--------------+----------------+-------+-------
[10:39] <wgrant>  206708 |             41329 | 2.6.15-51.66 |              1 |    12 |    12
[10:39] <wgrant>  207390 |             41329 | 2.6.15-51.66 |              1 |     0 |     6
[10:39] <wgrant> Why are there two different sources with the same version, both with builds, one with two sets of builds, and the latter without any source publications? :(
[10:40] <lifeless> bigjools: drop me a note when its in there ?
[10:40] <bigjools> lifeless: yuuuuuup
[10:43] <bigjools> wgrant: nfi.  what is the exact problem here?
[10:46] <jml> poolie: thanks. I'll probably be in Wed & Fri
[10:50] <wgrant> bigjools: Someone reuploaded the same kernel version, and then the DB surgery to remove it was incomplete.
[10:50] <wgrant> There are 14 invalid builds from bad DB surgery.
[10:50] <wgrant> 55 from gina being crap.
[10:51] <bigjools> wgrant: let me re-phrase, what are the symptoms of the problem?
[10:51] <wgrant> bigjools: Bug #740584
[10:51] <_mup_> Bug #740584: Build lacks a corresponding source publication <oops> <regression> <Launchpad itself:In Progress by wgrant> < https://launchpad.net/bugs/740584 >
[10:51] <wgrant> BPB.current_component (quite reasonably) expects each build to have a corresponding source publication.
[10:52] <wgrant> The production data throws reasonable expectation out the window.
[10:52] <bigjools> ok
[10:52] <bigjools> the db surgery was only done in the PPA
[10:52] <bigjools> IIRC
[10:53] <wgrant> There are three or four PPAs and this one source in the primary archive.
[10:53] <wgrant> Same version accepted twice.
[10:53] <bigjools> :/
[10:53] <bigjools> that sounds like a deeper bug
[10:53] <wgrant> I'm hoping that the binaries were never published.
[10:53] <wgrant> This was years ago.
[10:53] <bigjools> ok
[10:53] <wgrant> If they were indeed never published, we can just blow the builds away.
[10:53] <wgrant> And the world will be happy again.
[10:54] <bigjools> wgrant: rather than the code change I'd prefer data was fixed
[10:55] <bigjools> we also need a script to nuke unwanted versions in case some PPA user *cough* comes crying again
[11:02] <wgrant> Yeah.
[11:02] <wgrant> It's going to be a non-trivial endeavour to repair it all, but I will try it tomorrow.
[11:02] <wgrant> The stuff imported from dak is going to be bad, though :/
[11:02] <wgrant> There were binaries without sources in the initial Ubuntu import.
[11:02] <wgrant> They might put an end to this attempt :(
[11:12] <jml> have I misread something, or has cjohnston submitted 7 bug fixes?
[11:17] <nigelb> i think he has
[11:21] <jml> excellent!
[11:49] <bigjools> mrevell: https://dev.launchpad.net/LEP/DerivativeDistributions#Round%202
[11:49]  * mrevell looks
[11:50] <mrevell> bigjools, I'd say that was most certainly a success.
[11:50] <bigjools> :)
[11:51]  * bigjools heads for pain killers and caffeine
[11:53] <cjohnston> mornin jml :-)
[11:53] <jml> cjohnston: good morning!
[11:54] <jml> cjohnston: thank you so much for those patches
[11:55] <cjohnston> np :-)
[11:55] <cjohnston> I'm fixing the issues with them right now
[11:58] <nigelb> jml: can we repharse your pie on face to 2-digit critical bugs? ;)
[11:58] <jml> nigelb: only if the first digit is zero.
[11:58] <jml> (guess what the second digit has to be)
[11:58] <nigelb> you mean 0200 is fine? :p
[11:59] <wgrant> cjohnston: If you set a commit message on your approved MPs I'm sure lots of us will gladly rush to land them for you.
[12:00] <danilos> lifeless, hi, you don't have a problem with me landing https://code.launchpad.net/~danilo/launchpad/proper-bug-muting/+merge/60615 as-is? (i.e. worrying about team mutes separately)
[12:01] <cjohnston> heres a discussion then.. imo, if a person doesn't add a commit message to the MP, then it should inheret the commit message from bzr commit when there is one
[12:01] <wgrant> cjohnston: Mmm, possibly. But in a lot of cases that will just be "Lint" or "Address review comments" or something like that.
[12:02] <cjohnston> gotcha...
[12:02] <danilos> lifeless, I am assuming you don't, and you have whatever time it takes ec2 to run tests through to complain before it hits pqm :)
[12:04] <jml> cjohnston: also, I have to ask, have you signed the contributor agreement?
[12:04] <wgrant> Ah, that too.
[12:04] <cjohnston> jml: I did.. waiting to be added
[12:04] <jml> cjohnston: cool. thanks :)
[12:04] <wgrant> Did you send it to flacoste?
[12:06] <cjohnston> yes
[12:06] <nigelb> shoulda just poked him at uds
[12:06] <nigelb> we both did talk to him at some point
[12:07] <nigelb> ("Are you a launchpad guy? Could you help us with something?")
[12:07] <wgrant> nigelb: I don't see any branches from you yet!
[12:07]  * wgrant cracks the whip.
[12:07] <nigelb> wgrant: I'm STILL at work!
[12:07] <cjohnston> lol yay!
[12:07] <cjohnston> I took vacation yesterday to submit launchpad patches!
[12:07] <wgrant> Excuses, excuses.
[12:08] <cjohnston> +1 wgrant
[12:08] <wgrant> that's the spirit.
[12:09] <nigelb> I can't just install launchpad to work laptop :\
[12:10] <wgrant> nigelb: Use a VM :)
[12:10] <wgrant> There are instructions on the dev wiki.
[12:10] <nigelb> wgrant: Every time I try to develop on launchpad, I get stuck at the setting up VM state
[12:10] <cjohnston> I think nigelb was the one who wanted the VM image
[12:11] <nigelb> Its happened thrice now
[12:11] <nigelb> yeah, it was me
[12:11] <cjohnston> in the LP session
[12:13] <StevenK> nigelb: If you get stuck, ask questions here?
[12:13] <nigelb> StevenK: no no, I get stuck at the VM stage
[12:13] <nigelb> I'm guessing my computer just stuck at VMs
[12:15] <StevenK> What are you using for the VM?
[12:16] <bigjools> lifeless: https://dev.launchpad.net/LEP/DerivativeDistributions#Round%202 - see bug 783423
[12:16] <_mup_> Bug #783423: Derived distros diffs pages need a more comprehensive search <Launchpad itself:New> < https://launchpad.net/bugs/783423 >
[12:19] <nigelb> StevenK: virtual box
[12:22] <poolie> henninge, or someone, could i have a review of my patch for bug 778437
[12:22] <_mup_> Bug #778437: Recipe build success sends emails, please stop doing that <email> <recipe> <Launchpad itself:In Progress by mbp> < https://launchpad.net/bugs/778437 >
[12:23] <poolie> despite there is probably some shallow twisted leakage
[12:26] <cjohnston> Just to be clear, does 'Resubmit' for review mean that someone has requested a resubmit, or that the code is being resubmitted?
[12:27] <StevenK> nigelb: And how does it fail?
[12:27] <henninge> poolie: I will look at it.
[12:28] <nigelb> StevenK: hrm, I don't remember, but it was mostly virtualbox thing instead of launchpad
[12:28] <henninge> Hi cjohnston! ;)
[12:28] <nigelb> like running out of space and being lazy
[12:28] <cjohnston> hey henninge.. I'm workin on them
[12:28] <cjohnston> henninge: https://code.launchpad.net/~chrisjohnston/launchpad/728192/+merge/61046
[12:28] <henninge> cjohnston: cool. I think there was one more I had not finished yet
[12:29] <cjohnston> ok
[12:30] <cjohnston> fwiw jml I also got the link to the contributor agreement on http://www.canonical.com/contributors fixed ;-)
[12:33] <jml> cjohnston: heh! thanks.
[12:33] <poolie> thanks
[12:33] <poolie> hi cjohnston
[12:33] <poolie> i think i filed a bug about that
[12:33] <poolie> or do you work on the canonical web site?
[12:34] <cjohnston> I know the people who work on the canonical website.. and where to file the bug. I dont get access to anything :-/
[12:36] <cjohnston> poolie: if you can find the bug you filed, I'll dupe it on mine since mines already fix released
[12:41] <poolie> it was https://bugs.launchpad.net/bugs/778334
[12:41] <_mup_> Bug #778334: broken link on contributor agreement page <Canonical Website:New> < https://launchpad.net/bugs/778334 >
[12:44] <cjohnston> ty
[12:46] <poolie> thank _you_
[12:48] <cjohnston> henninge: https://code.launchpad.net/~chrisjohnston/launchpad/197793/+merge/61053 I believe the first one is dor duplicate bug subscription, and the second one is if you are subscribed to the original bug
[12:50] <cjohnston> I need to make the kids food, and in an hour we are going to go outside and watch the shuttle, but I'll double check it
[12:50] <henninge> cjohnston: would that have influence on the wording, thouhg?
[12:50] <henninge> cjohnston: sure, lunch is close for me, too.
[12:50] <cjohnston> It is defining why you are described.. which is how it currently does it.
[12:51] <cjohnston> Which I personally like to know if I'm subscribed to the bug or to a duplicate... butt hat's me
[12:51] <wgrant> poolie: Ah, great to hear that you're looking at updating bzr.
[12:51] <wgrant> in LP.
[12:53] <jml> Running errands. Back soon.
[13:00] <benji> https://dev.launchpad.net/ | On call reviewer: henninge, benji | https://code.launchpad.net/launchpad-project/+activereviews
[13:00] <benji> heh
[13:00] <henninge> Hi benji:
[13:01] <benji> hi henninge, are all the reviews on +activereviews available for me to look at?
[13:01] <henninge> benji: yes but maybe you could take poolie's that I already claimed as I am off to lunch now.
[13:01] <henninge> https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
[13:02] <benji> sounds good
[13:02] <henninge> benji: cool, reassigned.
[13:02] <benji> enjoy your lunch
[13:02] <henninge-lunch> thanks
[13:05] <mrevell> Can anyone remind me of the page in Launchpad that lists of the graphical elements we use? It's something like launchpad.net/@@/icons
[13:06] <wgrant> +graphics?
[13:06] <wgrant> http://launchpad.net/+graphics
[13:07] <benji> poolie: is https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360 ready for review?  The last comment about the Twisted test error being persistent suggests that I should wait on reviewing it.
[13:08] <mrevell> Thanks wgrant
[13:34] <poolie> benji: i think the twisted fix will be shallow so i'd like a review on the other bits
[13:35] <benji> poolie: cool, thanks
[13:35] <poolie> wgrant i was just thinking the other day it would be nice if lp changed /people/+me to /~
[13:36] <wgrant> Hmmm.
[13:36] <wgrant> That might indeed be nice.
[13:36] <wgrant> And trivial.
[13:36] <poolie> i can never remember the current abbreviation
[13:37] <poolie> similarly whether it's /+bugs/ or /+bug etc
[13:37] <poolie> other people there commented on this at ud
[13:37] <poolie> *uds
[13:37] <poolie> benji thanks
[13:37] <benji> my pleasure
[13:38] <wgrant> poolie: It's both!
[13:40] <poolie> no, really?
[13:41] <poolie> anyhow pad.lv fixes that issue, but it's an istance of the general thing of some of these shortcuts being a bit too cryptic to be truly helpful
[13:41] <wgrant> We really need to sort out the whole domains and URLs thing.
[13:48] <bigjools> wgrant: can you remember if bug 243252 is actually fixed?
[13:48] <_mup_> Bug #243252: P-a-s (lists of forbidden architectures) should apply to rebuild archives <derivation> <lp-soyuz> <Launchpad itself:Triaged> < https://launchpad.net/bugs/243252 >
[13:49] <wgrant> I don't think so.
[13:49] <wgrant> But let me check.
[13:50] <wgrant>         for pubrec in sources_published:
[13:50] <wgrant> That would be a no.
[13:50] <wgrant>             builds = pubrec.createMissingBuilds(
[13:50] <wgrant>                 architectures_available=architectures)
[13:50] <wgrant> packagecloner doesn't provide a pas_verify.
[13:54] <lifeless> gary_poster: I'm halting() for the night, but I would -dearly love- that feedback during your day. I would like to start wider circulation later today.
[13:55] <gary_poster> lifeless, ack.  It will be done.
[13:55] <lifeless> gary_poster: thanks, I really appreciate it!
[13:55] <lifeless> night all
[13:55] <gary_poster> night
[13:56] <wgrant> Night lifeless.
[13:56] <wgrant> And thanks for all your work on that.
[14:02] <deryck> henninge-lunch, ping for standup
[14:28] <henninge> Hi deryck! Sorry for missing the call ...
[14:28] <deryck> henninge, it's ok
[15:05] <LPCIBot> Project windmill-devel build #83: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/83/
[15:19] <nigelb> \o/
[15:19] <nigelb> rocketful-setup running :)
[15:22] <jml> yay
[15:24] <nigelb> I just realized this is really a spare system
[15:24] <nigelb> I can brick this as much as I want :)
[15:33] <LPCIBot> Project windmill-db-devel build #280: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill-db-devel/280/
[15:40] <sinzui> deryck: I think your team will find project review easier. There is one page to see and drive to zero now
[15:40] <sinzui> https://launchpad.net/projects/+review-licenses
[15:40] <deryck> sinzui, ah, nice.  thanks
[15:41] <deryck> sinzui, yes, that is much better.
[15:41] <sinzui> There are tool tips that explain what I am thinking about for the sections of content
[15:41] <deryck> sinzui, also, I updated the wiki page here:  https://dev.launchpad.net/MaintenanceRotationSchedule but maybe you guys are off maintenance next week?
[15:42] <sinzui> Unless flacoste/jml say otherwise, Teal will be working on disclosure next week
[15:43] <jml> deryck: see also, https://dev.launchpad.net/Squads.
[15:43] <jml> sinzui: I'm unlikely to say otherwise.
[15:43] <jml> sinzui: btw, I do want to have a call this week, but won't have time to today.
[15:43] <deryck> jml, ah, nice page.  thanks.
[15:44] <sinzui> jml: fab
[15:44] <deryck> jml, sinzui -- so yellow is on maintenance next week then?
[15:44] <jml> deryck: starting 23rd.
[15:44] <deryck> jml, rockin' thanks!
[15:44] <jml> (so that's a yes. had to check a calendar)
[15:49] <benji> henninge: I'm taking https://code.launchpad.net/~wallyworld/launchpad/fix-test_inline_recipe_daily_build/+merge/61050
[15:54] <henninge> benji: that's fine
[16:03] <jcsackett> what determines which js files get compiled into launchpad.js?
[16:04] <nigelb> Its seems my branching of launchpad is sort of stuck. The size hasn't changed in a while
[16:04] <jml> nigelb: is there network access?
[16:05] <nigelb> yeah, I'm on IRC, so sure
[16:05] <nigelb> but there may have been a 1 sec break in between
[16:05] <jml> nigelb: I mean, does System Monitor show activity for network that's more than the usual for being on IRC
[16:06] <nigelb> ah
[16:06] <nigelb> fluctuating
[16:08] <jml> nigelb: also, you could try tailing ~/.bzr.log to see if anything is going on
[16:09] <jml> nigelb: it might just be bzr doing something CPU intensive and not networky
[16:10] <nigelb> so, its stuck at this point --> - 104595KB    23KB/s | Fetching revisions:Inserting stream
[16:10] <nigelb> tail shows me 17.881  fetch up to rev {launchpad@pqm.canonical.com-20110516135527-bdxtzfll8ydxwio2}
[16:12] <nigelb> is there a way I can tell bzr to start again without doing the whole rocketfuel again?
[16:13] <jml> nigelb: hmm.
[16:13] <abentley> henninge or benji: could you please review https://code.launchpad.net/~abentley/launchpad/branch-empty/+merge/61132 ?
[16:13] <benji> abentley: sure
[16:13] <jml> nigelb: if you really wanted to, you could stop rf-setup, bzr pull, hack rf-setup to skip the steps before bzr pull, then run it again.
[16:14] <nigelb> jml: 400-line shell script, I'm not so sure if I want to do that.  New job wanted me to write a set up script and I wrote a 200 liner, I know how shell can be hard sometimes
[16:21] <jml> nigelb: not sure if there's any other way.
[16:21] <nigelb> I figured. I just read through the script. I guess I can comment everything but assigning the variables bit
[16:22] <jml> yeah. that'd make sense.
[16:28] <nigelb> hrm, wait.
[16:28] <nigelb> The script is awesome. It does figureout if its being run the second time
[16:29] <benji> abentley: I'm done with https://code.launchpad.net/~abentley/launchpad/branch-empty/+merge/61132
[16:37] <henninge> benji: I just claimed https://code.launchpad.net/~wallyworld/launchpad/has_matches-opps-querystring/+merge/61095
[16:40] <henninge> That was easy.
[16:41] <henninge> benji: have you already picked another one?
[16:42] <LPCIBot> Project windmill-devel build #84: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill-devel/84/
[16:42] <henninge> benji: I am on https://code.launchpad.net/~wgrant/launchpad/bug-750607/+merge/61069
[16:48] <abentley> jml: How can I figure out where this exception is being raised? https://bugs.launchpad.net/launchpad/+bug/740674
[16:48] <_mup_> Bug #740674: ConnectionRefusedError from code puller <branch-puller> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/740674 >
[16:49] <jcsackett> sinzui: any notions what i should poke at if a js file isn't being included in launchpad.js on jsbuild?
[16:50] <sinzui> yes
[16:52] <sinzui> jcsackett: sorry, no, It was in lib/lp/app/templates/base-template-macros.pt It is not gone
[16:52]  * sinzui see Lp is still loading a google maps keys
[16:53] <sinzui> jcsackett: The compressor script used to read the js files in that template. I think we need to re-read the code that does the compression
[16:54] <jcsackett> sinzui: thanks. i'll start looking at that.
[16:54] <henninge> benji: next is https://code.launchpad.net/~wgrant/launchpad/expose-bpph-indep/+merge/61077
[16:56] <jml> abentley: I don't really know, except maybe by code inspection. PullerMaster.unexpectedError in scheduler.py looks a likely culprit
[16:56] <sinzui> jcsackett: I think the rules are in the Makefile now. I see JS_LP
[16:56] <jml> abentley: isn't tellurium a staging service?
[16:57] <abentley> jml: You may be right.
[16:57] <jml> hmm.
[16:58] <henninge> benji: ok, all the easy ones are done. Now I stop. ;-)
[16:58] <jml> actually, because it's a Twisted client connection error, it'll almost certainly be the XMLRPC service.
[16:58] <henninge> benji: sorry to have flooded you ...
[16:59] <benji> henninge: no problem, I'm eating lunch
[16:59] <henninge> benji: enjoy it ;)
[16:59] <abentley> jml: The XMLRPC used to implement the bzr transport?
[17:00] <jml> abentley: I was thinking of the XMLRPC used to tell the database what we're doing: mirrorFailed etc.
[17:00] <jml> calls to self.codehosting_endpoint.callRemote
[17:00] <abentley> jml: Ah.  Yes, could be that.
[17:00] <jml> abentley: Twisted won't be used for the bzr transport in this case
[17:02] <jml> maybe a sensible strategy is to check to see if the error is still happening, instrument a little more around the likely causes and then check the logs a little after it's rolled out
[17:04] <abentley> jml: I think the assessment that this should not be reported as an oops assumed that the ConnectionError was happening when attempting to retrieve the remote branch.
[17:04] <jml> abentley: agreed.
[17:04] <jml> abentley: we almost certainly want oopses if we fail to communicate to our local servers.
[17:05] <abentley> jml: I dunno, those XMLRPC servers do go down from time to time...
[17:07] <jml> abentley: hmm.
[17:08] <jml> abentley: but it's always OOPS-worthy if they become inaccessible while the puller is running, I think.
[17:09] <jml> there's always one appserver up during a nodowntime rollout, and I'm guessing we shut down the puller during a downtime rollout
[17:15]  * jml has to go
[17:22]  * nigelb cries
[17:23] <nigelb> lp branch keeps getting stuck, but at different points :
[17:23] <nigelb> :(
[17:30] <LPCIBot> Project windmill-devel build #85: STILL FAILING in 48 min: https://lpci.wedontsleep.org/job/windmill-devel/85/
[18:37] <poolie> benji, hi?
[18:37] <poolie> nigelb: tell me more?
[18:37] <benji> poolie: hi
[18:37] <poolie> hey
[18:37] <poolie> i'm just trying to debug the failing twisted tests with spiv
[18:37] <nigelb> poolie: well, I stopped it and restarted, seem to have better luck this time!
[18:38] <nigelb> poolie: Pulling pqm now, I guess that's a good sign
[18:38] <poolie> please put 'debug_flags = hpss, bytes' into your bazaar.conf
[18:39] <nigelb> if it fails again?
[18:40] <poolie> benji: i think those tests were essentially not running before
[18:41] <poolie> because of ignoring the defered result
[18:41] <poolie> nigelb: actually it's useful to add anyhow
[18:41] <poolie> but if it does fail again, it will give us some more data
[18:41] <nigelb> okay, doing so now
[18:43] <benji> poolie: sounds plausible
[18:46] <LPCIBot> Project windmill-db-devel build #281: STILL FAILING in 45 min: https://lpci.wedontsleep.org/job/windmill-db-devel/281/
[19:23] <timrc> I'm trying to setup a LP development environment.  I've just run ./rocketfuel-setup and it failed with a Permission Denied (https://pastebin.canonical.com/47500/)... Off hand this seems like a bug in the script? But maybe I'm just reading the output wrong
[19:23] <timrc> e.g. "It's okay if this errors"... it then errors, and the script execution terminates
[19:23] <jelmer> timrc, hi
[19:24] <jelmer> timrc, do you have a launchpad user set up with the matching ssh key in your home directory?
[19:24] <jcsackett> benji: could you look at https://code.launchpad.net/~jcsackett/launchpad/consolidate-spam-js/+merge/61151? it's near the 800 limit, but a lot of that is deletion.
[19:24] <timrc> jelmer, doh :) nice first question, this is a VM and now that I think about it, I did not setup with my ssh key
[19:26] <timrc> jelmer, that did the trick.  ty
[19:27] <poolie> benji: ok with a little help from my friends i think it's ok
[19:27] <poolie> https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
[19:27] <benji> poolie: cool, I'll take a look in a minute
[19:35] <LPCIBot> Project windmill-devel build #86: STILL FAILING in 48 min: https://lpci.wedontsleep.org/job/windmill-devel/86/
[19:35] <nigelb> YES!
[19:35] <nigelb> Finally, I rocketfuel is done :)
[19:35] <poolie> way to go!
[19:36] <poolie> now, to patch it!
[19:36] <benji> poolie: I'm done with https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
[19:43] <jcsackett> sinzui: feel like chatting? (now or later today)
[19:43] <sinzui> now is good
[19:44] <jcsackett> superb. :-)
[19:46] <poolie> thanks benji
[19:46] <LPCIBot> Yippie, build fixed!
[19:46] <LPCIBot> Project db-devel build #552: FIXED in 5 hr 38 min: https://lpci.wedontsleep.org/job/db-devel/552/
[19:46] <poolie> that was a bit of struggle
[19:46] <benji> my pleasure
[19:46] <poolie> i would appreciate your insights on https://code.launchpad.net/~mbp/launchpad/uniqueid-clue/+merge/61153 the follow on
[19:48] <poolie> and so good night
[19:52] <gary_poster> lifeless, fwiw, I've been working on the feedback, and will continue doing so.  I expect to be done in 30 min.
[19:52] <sinzui> jcsackett: bug 427397 only affects blueprints now. I think it is trivial
[19:52] <_mup_> Bug #427397: Search triggering error in tsearch query again <blueprints> <bugs> <oops> <search> <sprints> <Launchpad itself:Triaged> < https://launchpad.net/bugs/427397 >
[19:58] <nigelb> hrm, is the make schema bit supposed to take a lot of time?
[20:04] <sinzui> jcsackett: The dupe as an example: https://bugs.launchpad.net/launchpad/+bug/777357
[20:04] <_mup_> Bug #777357: Searches containing a percent sign generates an oops <Launchpad itself:Triaged> < https://launchpad.net/bugs/777357 >
[20:08] <sinzui> jcsackett: OOPS-1962AQ339 happend just a few hours ago
[20:14] <cjohnston> jml: my 7 MP on my first day wants to be the contributor that throws the pie. ;-)
[20:21] <LPCIBot> Project windmill-devel build #87: STILL FAILING in 45 min: https://lpci.wedontsleep.org/job/windmill-devel/87/
[20:22] <sinzui> jcsackett: I dedupped bug 777357 because it really is just about the %. There have been no tsquery oopses in 8 months
[20:22] <_mup_> Bug #777357: Searches containing a percent sign generates an oops <Launchpad itself:Triaged> < https://launchpad.net/bugs/777357 >
[20:22] <jcsackett> sinzui: dig.
[20:23] <jcsackett> and i see you marked the other bit fix released. was just about to ask about that.
[20:43] <nigelb> I found myself an easy bug to work on, bug 645825
[20:43] <_mup_> Bug #645825: "bzr push" examples in UI say to push to trunk <easy> <lp-code> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/645825 >
[20:43] <lifeless> gary_poster: thanks!
[20:44] <nigelb> should I be discussing this bug in -reviews before I start?
[20:44] <lifeless> nigelb: here is fine
[20:44] <nigelb> okay, so I think this is just going to be a one or two line fix
[20:45] <nigelb> apply the name of the series in where trunk is hardcoded currently
[20:56] <cjohnston> sinzui: ping
[20:57] <sinzui> did you get hate mail from the testrunner too?
[20:57] <cjohnston> ya
[20:57] <cjohnston> I'm not totally sure what it is wanting
[20:58] <sinzui> The issue is not your branch. I will merge it once I verify the build is not broken
[20:58] <lifeless> nigelb: that sounds fine in principle
[20:58] <lifeless> nigelb: I haven't [yet] looked at that bug
[20:58] <cjohnston> ok.. so I'm just getting hate mail for fun
[20:59] <nigelb> lifeless: just trying to figure out how to refer to the variable like things on zope, having fun with tracebacks :)
[21:01] <sinzui> cjohnston: Your branch is indeed fine. I expect to get a message shortly confirming your branch is merged
[21:01] <cjohnston> ok.. very cool
[21:05] <nigelb> yay tracebacks :)
[21:10] <sinzui> benji: do you have time to review https://code.launchpad.net/~sinzui/launchpad/product-release-traversal/+merge/61168 ?
[21:10] <benji> sure
[21:10] <lifeless> statik: hi, are we on today?
[21:11] <cjohnston> Could someone take a look at https://code.launchpad.net/~chrisjohnston/launchpad/197793/+merge/61053  to me, it is showing subscribed to a duplicate bug vs subscribed to the main bug.. but maybe im missing something in what Henning said.
[21:19] <sinzui> cjohnston: https://code.launchpad.net/~chrisjohnston/launchpad/255024/+merge/61038 is merged. I will QA it once it is deployed to qastaging.
[21:20] <cjohnston> sinzui: I'm not sure quite what that means... I was just getting ready to ask what the process is now that its merged
[21:21] <sinzui> cjohnston: Lp's devel and db-devel branch will be tested without your changes. When both pass, your work is deployed to https://qastaging.launchpad.net . The bug will be tagged qa-needstesting which will tell me it is ready for me to verify it
[21:22] <sinzui> cjohnston: I will change the tag to qa-ok, which will signal that the change can be deployed, which may be tomorrow
[21:23] <cjohnston> hmm.. interesting.. very different than anything I'm used to.. will it be deployed straight to lp.net for all or just beta first?
[21:25] <benji> sinzui: I'm done with https://code.launchpad.net/~sinzui/launchpad/product-release-traversal/+merge/61168
[21:27] <nigelb> okay, I just tried a while and I can't figure out how to get the tal:. thing for productseries name
[21:27] <nigelb> <tal:series replace="context/productseries/name" /> doesn't seem to work :\
[21:27] <sinzui> cjohnston: it will go directly to lp.net from qastaging. Beta is a mechanism mostly for features were to support multiple behaviours until we choose to end to to complete the release of the other
[21:27] <cjohnston> gotcha
[21:28] <sinzui> nigelb: that will show the lp Id of a product's series. is context a product, or do you want the displayname?
[21:29] <nigelb> sinzui: I'm trying to get name of a productseries
[21:29] <nigelb> in an attempt to fix bug 645825
[21:29] <_mup_> Bug #645825: "bzr push" examples in UI say to push to trunk <easy> <lp-code> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/645825 >
[21:30] <sinzui> nigelb: can you paste the traceback at pastebin.ubuntu.com ?
[21:32] <nigelb> sinzui: http://paste.ubuntu.com/608640/
[21:33] <sinzui> ah, that nasty LocationError. nigelb That error type is hiding the real error. I believe it is an Attribute/key error.
[21:33]  * sinzui reads impl
[21:33] <lifeless> cjohnston: once its merged it goes through a CI system (buildbot at the moment)
[21:34] <nigelb> sinzui: which means I'm calling the wrong attribute?
[21:34] <deryck> hi lifeless.  got a sec?
[21:34] <lifeless> cjohnston: then deploys to a staging area where sinzui will check its ok before changing that tag he mentioned
[21:34] <lifeless> cjohnston: and after that it goes live
[21:34] <lifeless> deryck: sure
[21:34] <cjohnston> sweet.. ty
[21:34] <deryck> lifeless, so I'm looking at bug 701246.
[21:34] <_mup_> Bug #701246: missing bug dereference generates OOPS <oops> <Launchpad itself:In Progress by deryck> < https://launchpad.net/bugs/701246 >
[21:34] <sinzui> nigelb: possibly, or the permissions are wrong. I think anyone can access the name attr
[21:35] <deryck> lifeless, and I cannot repro this.  using launchpadlib 1.9.7.  We raise KeyError now.
[21:35] <nigelb> yeah, that's what I felt too
[21:35] <lifeless> deryck: do you get an x-lazr-oopsid in the response?
[21:35] <deryck> lifeless, nope
[21:35] <nigelb> sinzui: How do I figure out if "context/productseries/name" is correct?
[21:35] <lifeless> deryck: or an oops written to disk ?
[21:36] <lifeless> (look under /var/tmp/lperr/ for a new file in todays dir)
[21:36] <deryck> ok, let me see to make sure....
[21:36] <sinzui> nigelb: I really think it is correct. The TB clearly shows the object is a ProductSeries and I know the name attribute is always public because it is in the URL
[21:37]  * sinzui looks at the template
[21:37] <jcsackett> deryck: are you trying to reproduce via test?
[21:37] <deryck> jcsackett, well test led me to question the issue, so I fired up a Python console against qastaging/staging.
[21:38] <deryck> jcsackett, lifeless -- so I'll run against dev server now and see if it generates an OOPS.
[21:38] <jcsackett> deryck: dig. i've found when using launchpadlib in unittests you can get keyerrors when you get other errors running the actual client against a server.
[21:38] <jcsackett> i've never dug into it, but it's tripped me up.
[21:38] <sinzui> nigelb: looking at the template in the my copy of the tree, context is not a product, it is a product series. Does context/name work?
[21:39] <nigelb> sinzui: ah, it does :)
[21:39] <deryck> jcsackett, yeah, I did get a KeyError in test, but I also get one with launchpadlib against staging.
[21:39] <nigelb> sinzui: how do I figure out the correct context in the future?
[21:39] <sinzui> nigelb: context is always ambiguous. It essentially is like "this" where "this" is the subject we started with
[21:39] <jcsackett> deryck: interesting. i wonder if my issue was just that the lplib used in tests was a more recent version than the one i was using when connecting manually...
[21:40] <nigelb> sinzui: oh boy
[21:40] <nigelb> sinzui: sounds like fun
[21:40] <nigelb> anyway, do I commit on my devel branch and propose merging or create a new branch with rf-setup?
[21:40] <sinzui> nigelb: In this case, the template and its view are only initialised with a ProductSeries, so you can be confident conext/name will give the the productseries.name
[21:41] <nigelb> aha
[21:41] <sinzui> nigelb:  I always branch my devel branch, make my changes, then push to lp
[21:41] <deryck> jcsackett, lifeless -- ah, so indeed it was still oopsing, even though the client behavior is different from the bug report.
[21:41] <sinzui> nigelb: let my collect my routing and paste it for you
[21:42] <nigelb> sinzui: yes, that'd be awesmoe
[21:44] <sinzui> nigelb: this is what I do every day http://paste.ubuntu.com/608652/
[21:46] <nigelb> sinzui: ah, so no need to use RF for the branch stuff
[21:46] <sinzui> nigelb: I can just type bzr info because my ~/.bazaar/locations.conf knows about my devel branch. I cannot remember if rocketfuel-setup does that for you
[21:46] <lifeless> deryck: thanks for being thorough
[21:46] <deryck> no worries.
[21:47] <sinzui> nigelb: you can use `bzr merge --committed ../devel` to copy any changes made in the devel branch to the branch you want to submit
[21:48] <nigelb> :-)
[21:50] <lifeless> or commit, push them over and pull --overwrite in devel to sync it up again [TMTOWTDI]
[21:58] <lifeless> flacoste: hi
[22:00] <flacoste> hey lifeless
[22:00] <cjohnston> hey flacoste!
[22:00] <flacoste> hey cjohnston!
[22:01] <flacoste> thanks for your typo fixing spree!
[22:01] <cjohnston> lol
[22:01] <cjohnston> :-)
[22:01] <flacoste> that's very much appreciated!
[22:01] <cjohnston> the blueprints one will help me alot!
[22:01] <lifeless> flacoste: we're up!
[22:01] <lifeless> flacoste: I need 2 minutes first though (oops :P)
[22:01] <flacoste> lifeless: we are, skype?
[22:05] <flacoste> lifeless: skype me when you are ready
[22:06] <lifeless> ok
[22:06] <nigelb> okay, proposed merge at https://code.edge.launchpad.net/~nigelbabu/launchpad/645825-ui-example/+merge/61175
[22:06] <nigelb> Is there something I need to know or do before it gets reviewed?
[22:06] <nigelb> I've already signed the contributor agreement
[22:19] <jml> nigelb: everything you need to know is on the "Submit a patch" page
[22:20] <jml> nigelb: keep making noise until someone reviews your branch. west coasters should be around now, and Aussies turn up in 2 hrs.
[22:20] <jml> g'night.
[22:20] <lifeless> night jml
[22:20] <nigelb> I need to head to bed too, 3 am
[22:22] <nigelb> g'night all. I shall prod someone in the am.
[22:31] <ajmitch> jml: nice incentive for people to fix lp bugs
[23:48] <huwshimi> Morning