[00:01] wgrant: mumble? [00:22] it is used to generate a new proposal with the same metadata [00:22] bah [00:22] cjohnston: ^ very-late-reply :P [00:26] erm. [00:26] PQM is broken. [00:26] star-merge succeeded at Mon May 16 21:21:35 2011 (0:00:33.523987) [00:26] "Exception processing merge: 'str' object has no attribute 'set_revision_history'" [00:26] And ever since it has kept trying to merge but said "nothing to do" [00:30] whhhhhhhe [00:31] You're it. [00:38] sinzui: hi [00:38] sinzui: are you still running a script that assigns milestones? [00:38] sinzui: if so, can you remove the milestoning from it ? [00:38] (inspired by the change on bug Bug 736011) [00:38] <_mup_> Bug #736011: ProductRelease:+rdf timeout < https://launchpad.net/bugs/736011 > [00:51] lifeless: Do you want to reassign with-without-datetime to ~launchpad-committers, or pull lp:~wgrant/storm/with-without-datetime? [00:51] (my DISTINCT ON changes are in trunk now) [00:52] wgrant: just push a fresh one to either ~launchpad-committers or your own namespace [00:52] k [00:58] Trying to setup a Launchpad development environment. I've been following the instructions at https://dev.launchpad.net/Running, and now when I try to access my instance I get the following? https://pastebin.canonical.com/47513/ [00:59] timrc: pastebin.ubuntu.com next time? :) [00:59] mwhudson, ah sorry force of habit [00:59] timrc: How are you trying to access it? [01:00] It looks like you're poking the XML-RPC server. [01:01] wgrant, the console log shows http://pastebin.ubuntu.com/608736/ [01:01] perhaps it's a hostname problem.. [01:02] No, that's fine. [01:02] Which URL are you using? [01:03] Locally, http://192.168.1.67:8085/ [01:03] ah [01:03] that won't work [01:03] don't do that :) [01:03] hostname based vhosting woo [01:03] lol [01:04] timrc: You're running it in a VM, then? [01:05] wgrant, Correct... [01:05] So I just need to make launchpad.dev point to the right place? [01:05] https://dev.launchpad.net/Running/VirtualMachine [01:05] What lifeless said. [01:05] And yes. [01:10] lifeless, wgrant: Thanks. Looking now [01:12] lifeless, hello [01:13] Ursinha: tudo bem! [01:13] hehe [01:13] lifeless, tudo [01:14] lifeless, why is bug 667390 still needed for you? did you see how the dashboard puts all fixed bugs in wiki format and in a single row? [01:14] <_mup_> Bug #667390: provide wiki syntax bug links in deployable revision reports for easy copying to the LPS report < https://launchpad.net/bugs/667390 > [01:14] Ursinha: folk deploy off of the report though [01:15] hm [01:15] how bad is it to check the dashboard instead of the report to do the deployment? [01:15] whats the dashboard url? [01:16] my browser has forgotten it :( [01:16] lifeless, http://lpqateam.canonical.com/ [01:17] Ursinha: way too little information [01:17] lifeless, what else do you need? [01:17] Ursinha: I would not be comfortable with myself or others deploying where they cannot see all the revisions being deployed. [01:17] because the system isn't perfect, seeing what will be deployed is a key piece of information [01:17] Ursinha: its things like seeing the commit message which has told be of the bugs in determining which bug links are found, for instance. [01:18] right. [01:18] I fixed that bug, btw, but I got your point [01:18] thank you [01:18] (for fixing the bug) [01:22] That is a very nice page. [01:23] :) [01:24] Ursinha: Is it easy enough to show the current state of devel/db-devel, so we can see how many revs are not yet in *stable? [01:25] wgrant, it's doable with not much effort, I believe [01:47] Project devel build #722: FAILURE in 5 hr 12 min: https://lpci.wedontsleep.org/job/devel/722/ [02:01] + spph data model is confusing (records exist where they were built, not where they have been copied to) [02:02] I am confuse. [02:02] The build records exist where they were built. [02:02] The SPPH is the copy. [02:02] oh, my misunderstanding [02:02] please correct it [02:02] what I intended was to say: [02:02] - the behaviour matches our model [02:02] - our model is confusing [02:02] - its low priority [02:03] - and not specific to oneiric or ppas === Ursinha is now known as Ursinha-afk [02:11] Project windmill-devel build #88: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/88/ [02:11] lifeless, thanks, https://dev.launchpad.net/Running/RemoteAccess got me through the rest :) [02:19] Question.. I got a buildbot thing, but am not allowed to access the details page.. Seems odd to me? [02:20] Yeah, that's a bit unfortunate. [02:20] now we don't do production branches thats fixable [02:20] It was a success, though, so you don't have to worry about it. [02:20] RT it [02:20] lifeless: Last I heard there was also an XSS. [02:21] But that was nearly two years ago. [02:21] oh freaking yay [02:21] was just curious wgrant since I got it.. heh [02:21] * lifeless vents [02:21] cjohnston: we did have good reasons for having it private. Some may still apply. [02:21] cjohnston: Yeah, I had to put up with it for 18 months, I know the annoyance :( [02:21] so lifeless, rt saying that I'm getting an email from buildbot but don't have access to view the details? [02:22] no [02:23] wgrant will have a fiddle at some point [02:23] if we can open it, we will [02:23] or we may finish obsoleting it in one of a few ways [02:23] ok.. so just bug wgrant .. lol kiddin [02:23] g [02:24] Do either of you have time to look at a review comment that was made and maybe explain it to me? [02:25] Sure. [02:25] https://code.launchpad.net/~chrisjohnston/launchpad/197793/+merge/61053 [02:26] I don't really understand his comments... One is for duplicates and one is for subscribing to the main bug.. And its diferentiating why a user is subscribed afaik [02:27] * cjohnston got a job today! [02:27] heh [02:27] or another job today.. or something [02:28] cjohnston: On line 24 of the diff, it doesn't say what they are a subscriber to. [02:28] so on line 24 add to the bug report? [02:28] "to the bug report" [02:28] This bug probably already existed, but the target of "is a direct subscriber" is a little more obvious than "is subscribed" [02:29] I'm not sure whether "bug" or "bug report" is better. [02:29] But yes. [02:29] Project windmill-db-devel build #282: STILL FAILING in 1 hr 14 min: https://lpci.wedontsleep.org/job/windmill-db-devel/282/ [02:29] seems from other bugs that people are wanting bug report since they are "reports of bugs" [02:29] and not actual bugs [02:34] Ok.. pushed that.. Hopefully that will be another one that can be closed [02:36] Since I don't seem to have access, can someone fix #7 in https://dev.launchpad.net/PatchSubmission please [02:40] cjohnston: Done. [02:40] ty StevenK [02:41] \o/ [02:41] wgrant: https://code.launchpad.net/~wgrant/launchpad/bug-740584/+merge/61060 - got a minute [02:58] lifeless: Hi. [02:58] What about it? [03:13] > They were, 5 years ago. They should all be unpublished and removed from the librarian by now. [03:13] Do they serve any purpose for us then? [03:13] wgrant: do they? [03:20] lifeless: Other than being a historical record, no. [03:20] But it's a historical record that has traditionally never been erased. [03:20] To erase it would be a change of policy. [03:23] but these were never built [03:23] they were imported from dak, you are saying [03:23] Right. [03:23] But to erase them would mean erasing part of Ubuntu's publication history. [03:23] so its not a historical record; its a historical fiction [03:23] For deleting the BPBs implies deleting the BPRs, and therefore their corresponding BPPHs. [03:24] thats true, but we don't know about bpph's before soyuz anyway [03:24] we know about these by happenstance, more or less. [03:25] Sure. [03:25] I think we should get some specifics [03:25] put it in context [03:25] and ask on u-d [03:25] It seems weird to have a data model axiom and then not enforce it [03:26] what do you think? [03:26] It would be a no-brainer to enforce it if it didn't require unprecedented history erasure. [03:27] Well, I'm framing it as precendented - the dak import already lost it [03:27] That is true. [03:27] However. [03:27] It is possible that some of these are still published in Dapper. [03:27] in which case its a gpl violation, no ? [03:28] Yes. [03:28] so, we should get the details regardless. [03:28] Sure. [03:28] I'm looking at cleanup for the easier ones first. [03:28] cool [03:28] should the mp be made wip / rejected? [03:28] pending the outcome of the data cleanup effort? [03:29] I will WIP it. [03:47] Project windmill-devel build #89: STILL FAILING in 1 hr 18 min: https://lpci.wedontsleep.org/job/windmill-devel/89/ [03:47] thanks [04:01] bombs away [04:02] Oh? [04:02] Ah. [04:04] yes indeed [04:31] cjohnston: Still around? [04:31] lifeless: Could you mentor https://code.launchpad.net/~wallyworld/launchpad/poppy-sftp-gpgconf/+merge/60454? [04:33] found an oversight ;) [04:38] Project windmill-db-devel build #283: STILL FAILING in 50 min: https://lpci.wedontsleep.org/job/windmill-db-devel/283/ [05:29] Project windmill-devel build #90: STILL FAILING in 50 min: https://lpci.wedontsleep.org/job/windmill-devel/90/ [05:30] wgrant: O hai, Mr. OCR. [05:31] So I am. [05:31] I can hardly review that. [05:31] But OK. [05:32] wgrant: Well, sure. I can prod lifeless until he squirms, if you prefer. [05:32] He'll be mentoring anyway, so I will do it. [05:34] Some of these DB surgery fix queries are a little long :( [06:05] hello! can someone review https://code.launchpad.net/~nigelbabu/launchpad/645825-ui-example/+merge/61175 for me? [06:07] nigelb: Done. [06:07] StevenK: yay, thanks :) [06:07] StevenK: oh, test changes and additions, hrm, could guide me through those or link me to some place that would guide me through those [06:08] nigelb: So you've changed the template -- there is likely to be a test (or a number of them) that create a view of that template. [06:09] windmill test? [06:09] I hope not. :-) [06:11] ah, the tests I find in lib/lp/registry/tests? [06:11] That is some of them [06:11] The view tests are more likely to be in lib/lp/registry/browser/tests [06:11] However, I'm having trouble finding a relevant test for ProductSeriesView [06:12] lib/lp/registry/browser/tests/productseries-views.txt that looks promising [06:13] I'm scrolling through that one already [06:13] nigelb: Can you run that test on your branch by 'bin/test -vvt productseries-views.txt' ? [06:14] okay, running [06:14] I'm failure sure I might have to write new ones because I don't find any checking this particular situation. [06:16] I've been thinking about that -- I doubt that the tests don't exist, but the only way to be sure is a fairly large hammer -- bin/test -vvm registry [06:16] Either that, or wgrant or lifeless could offer suggestions? [06:17] I'm running the productseries-views.txt one, I'll wait for more suggestions to fix it. [06:18] aha "Ran 2 tests with 0 failures and 0 errors in 13.684 seconds." [06:18] StevenK: Reviewed. [06:19] * StevenK watches for 'Needs Fixing' [06:19] Project windmill-devel build #91: STILL FAILING in 50 min: https://lpci.wedontsleep.org/job/windmill-devel/91/ [06:20] wgrant: No, but both the packagecopier and the overrides want Archive [06:23] wgrant: And since we're using UbuntuOverridePolicy(), a component will always be returned. === almaisan-away is now known as al-maisan [06:24] StevenK: Now that those 2 ran successfully, but may not be related to the code I touched, should I be trying to figure out how to write new tests? [06:24] StevenK: We are using UbuntuOverridePolicy at the moment. [06:24] StevenK: Nothing in the interface says a policy has to return a component. [06:24] Indeed, that doesn't make sense and is already violated by FromExistingOverridesPolicy [06:26] StevenK: I evisage that primary archives will use a chain of UnknownComponentOverridePolicy and FromExistingDestinationOverridesPolicy, while PPAs might use MainOnlyOverridePolicy and FromSourceOverridesPolicy, and copy archives might use FromSourceOverridesPolicy and FromExistingPrimaryOverridesPolicy [06:27] Er, last case is the wrong way around. FromExistingPrimaryOverridesPolicy and FromSourceOverridesPolicy [06:32] StevenK: Do you see what I'm aiming at here? [06:33] wgrant: I do [06:33] That my work is a jumping off point, and not the end result. [06:34] That's correct. This is a complex issue which you are taking nice initial bites out of. [06:34] wgrant: http://pastebin.ubuntu.com/608827/ is the uglyness that results from moving the circular import you commented on. [06:34] And it has to be somewhat complete before we can turn it on. [06:34] Because copies are used for security updates and moving from -proposed to -updates. [06:35] File "/home/steven/launchpad/lp-branches/copies-use-overrides/lib/lp/soyuz/model/queue.py", line 97, in [06:35] from lp.soyuz.scripts.packagecopier import update_files_privacy [06:35] Can you move that import into whatever uses it? [06:36] It's in a condemned code path anyway. [06:36] Yes, thank $DEITY. [06:38] wgrant: Round two: http://pastebin.ubuntu.com/608831/ [06:39] File "/home/steven/launchpad/lp-branches/copies-use-overrides/lib/lp/soyuz/model/archive.py", line 198, in [06:39] from lp.soyuz.scripts.packagecopier import do_copy [06:39] Move it into syncSource(s). [06:39] Hm. [06:39] In fact there's a single underlying method you can put it into. [06:39] I forget what it's called. [06:39] _copySource or something. [06:40] _copySources [06:40] Right [06:40] That is also condemned. [06:40] As copies are going async. [06:41] Success! [06:41] Also, refactor + behaviour change in a single commit == strangle [06:42] Ha [06:43] Yay, DISTINCT ON replacement branch worked. [06:43] \o/ [06:43] Does that replace all uses of it? [06:44] There are some fully string-based SELECTs that I haven't fixed. [06:44] But all those that use the hack ("DISTINCT ON (foo, bar) 0 as ignore") are gone. [06:44] \o/ [06:45] It's landed? [06:45] No. [06:45] Passed ec2 except for a typo. [06:45] Not reviewed yet. [06:45] Would you like one? [06:45] I've not written the description yet. [06:50] wgrant: That sound be quick. "Now that Storm supports DISTINCT ON, make use of it instead of a SQL() hack." [06:50] It was. [06:50] But then it took 3 minutes to generate a diff. [06:50] https://code.launchpad.net/~wgrant/launchpad/native-distinct-on/+merge/61199 [06:54] wgrant: Can the distinct_on in lib/lp/registry/model/distroseriesdifference.py be expressed only once? [06:54] wallyworld_: I'd be honoured. Just not today, because it's a holiday. :) [06:54] jtv: awesome. thanks! [06:54] (Also in a somewhat bad mood due to a combination of bugs costing me hours of work) [06:55] wgrant: And should bug 374777 be linked to the MP? [06:55] StevenK: It could be, but it doesn't seem terribly valuable as they are doing different things. [06:55] <_mup_> Bug #374777: DISTINCT ON queries < https://launchpad.net/bugs/374777 > [06:55] jtv: been there, done that :-( [06:55] Ah, I see. [06:55] StevenK: Not really. That's a Storm bug. [06:56] wallyworld_: that in its way is a small consolation, thanks [06:56] wgrant: Thank you for proving I can't read, again. r=me [06:56] Thankyou sir. [06:56] jtv: so what's the holiday? king's brother's cousin's birthday? [06:56] Haha [06:57] wallyworld_: sssshhh careful—joke about that and the police is obliged to investigate. We're talking 3—15 years in a hotel that Amnesty International has been giving consistently bad reviews. [06:57] This is merely one of the main religious holidays. [06:57] jtv: yeah i know. that's why i made sure i was all the way over here when i said it :-D [06:58] I _would_ have laughed out loud at this point but I'm not in a place where it's very safe to show too much independent thought. :) [06:58] * wallyworld_ wishes we had more religion here to get all their holidays [06:58] * jtv wishes Santa would finally hurry up and get that heatstroke while visiting Australia, ridding the rest of us of his nonsense. [06:59] FTR, his dying day (which is what you celebrate with saints; I'll refrain from commenting) is December 6, not 25. [06:59] Did I mention that bad mood I was having? [07:00] Ironic thought: I'm not just in a place where it's not safe to show independent thought; I'm in a place where I've been told so in urgent but hushed tones. And it happens to be right outside the most prestigious university. [07:10] Project windmill-devel build #92: STILL FAILING in 50 min: https://lpci.wedontsleep.org/job/windmill-devel/92/ [07:11] lifeless: loved the email pointing to the Services Analysis. Q about that document though: [07:12] It looks as the "It's relatively difficult to have cascading failures" (as a benefit of the existing design) is mostly making the opposite case. Is there anything positive under this header that we'd risk losing by changing to a different design? [07:14] wgrant: And thank you for the hint for of "use a tuple" -- I disliked the two loops over binaries anyway [07:16] StevenK: How are you going with the rest of the points. [07:16] They were, uh, a little extensive. [07:17] Apply question marks to taste. [07:19] wgrant: 1-3, 5, 6, 9-11 [07:19] Or so [07:47] Yippie, build fixed! [07:47] Project devel build #723: FIXED in 5 hr 35 min: https://lpci.wedontsleep.org/job/devel/723/ [07:49] Project windmill-db-devel build #284: STILL FAILING in 2 min 26 sec: https://lpci.wedontsleep.org/job/windmill-db-devel/284/ [07:50] Uhhh [07:59] Project windmill-devel build #93: STILL FAILING in 49 min: https://lpci.wedontsleep.org/job/windmill-devel/93/ [08:00] Project db-devel build #554: FAILURE in 6 hr 12 min: https://lpci.wedontsleep.org/job/db-devel/554/ === al-maisan is now known as almaisan-away [08:25] * StevenK smashes Zope. [08:25] Returning an override policy from IArchive seems to give me a proxy-wrapped object [08:27] StevenK: As it should. [08:28] override = policy.calculateSourceOverrides( [08:28] ForbiddenAttribute: ('calculateSourceOverrides', ) [08:28] :-( [08:28] Right, you'll need an interface and security declarations. [08:28] Bugger [08:29] StevenK: do you have anything more for me on https://code.launchpad.net/~nigelbabu/launchpad/645825-ui-example/+merge/61175 [08:29] nigelb: Sorry, I got distracted. [08:29] StevenK: np :) [08:30] Perhaps someone else knows which tests exercise the code you changed. [08:30] hrm, so basically, bug more people to look at it? :-) [08:32] wgrant: Doesn't the fact that the code is in adapters mean that an interface is not needed? [08:32] StevenK: No. [08:38] good morning [08:51] Project windmill-db-devel build #285: STILL FAILING in 51 min: https://lpci.wedontsleep.org/job/windmill-db-devel/285/ [09:02] Anyone's familiar with test cases that I could modify / write to make get this merge accepted? https://code.launchpad.net/~nigelbabu/launchpad/645825-ui-example/+merge/61175 [09:03] hi all [09:08] nigelb: you probably need to look for some tests in a 'browser' directory that touch the same page [09:08] hopefully you can adapt them [09:09] poolie: I'll be honest, I've very little experience with unit testing. I've written them, but not for an app this scale :) [09:09] lifeless: hi? [09:10] hi [09:11] i really liked your perf tuesday mail [09:11] also, congratulations on the content [09:12] that's quite a fabulous practice you've created there [09:18] How do? [09:23] mrevell: hi [09:23] poolie: practice? [09:23] mrevell: habit [09:23] bah [09:23] lifeless: "habit" or pattern or whatever [09:23] is good. [09:23] ah :) [09:23] stubbornness :P [09:24] well, celebrating progress [09:25] hows londinium [09:27] very good [09:37] lifeless: if you have any more cycles i'd like your opinion on https://code.launchpad.net/~mbp/launchpad/uniqueid-clue/+merge/61153 [09:39] Sometimes I think Launchpad suffers because it tries to have a one-size-fits-all solution... which means the obvious things that would for 98% of the projects and users can't be done because they don't work for 2% that are complex. [09:39] For example, the project home page is pretty hard to use... it's really hard to find things like the active reviews page, for example. Or whether or not the project has associated PPAs. [09:40] I wonder if we need to ditch the idea that we have a single view for all projects and instead have a perfect view that degrades (or mutates) as projects get more complex. [09:41] jkakar: Projects don't have associated PPAs :( [09:41] wgrant: I know. It's dumb. [09:41] wgrant: The team/project model in Launchpad is broken. [09:42] wgrant: I know it's uber flexible and makes all kinds of use cases possible... but it also makes the obvious ones very hard to achieve. [09:42] wgrant: I find myself consistently educating users about very basic aspects of Launchpad. [09:42] wgrant: It should be easier for people to figure out how it works and what it does. [09:43] wgrant: I hope there's some budget for UI improvements this year... Launchpad is slipping behind the competition and it's so much better in so many ways. [09:44] Anyway, I guess the burden created by technical debt is slowly being beaten down... it sounds like things have improved *a lot* in the last year, which is excellent. [09:44] Launchpad slipped behind the competition about 4 years ago. [09:44] jkakar: The maintenance squads are currently working solely on removing the pile of critical bugs. [09:44] In the last month we have made significant progress. [09:44] I expect it will be done in another 2 or 3 months. [09:45] Then Launchpad can improve, as there will be people dedicated to doing non-feature work like unbreaking the UI. [09:45] wgrant: Yep, it can definitely improve and the team is smart and capable. [09:46] wgrant: It also rocks today, despite it being hard for newcomers to realize that. [09:46] Functionality-wise it rocks. [09:46] wgrant: Yes, exactly. [09:46] UI-wise, it, uh.... [09:46] wgrant: Yeah. :) [09:46] i'm wondering about trying to spike a timeline view at the rally [09:46] poolie: DO IT! :) [09:47] poolie: Also, integrate lp:kanban while you're there. ;b [09:47] Speaking of which, I really want to find more time to work on it. [09:47] (kthxbye? :-) [09:47] me too [09:47] Hehe [09:48] poolie: I want to port it to Go... but I guess that wouldn't be as good a use of my time as landing some of the improvements we've discussed. [09:48] But I'm very excited about Go... I've been playing with it on and off and its really nice. [09:50] me too [09:50] jkakar: as nice as C++? [09:51] jml: C++ is not nice in any way. [09:51] jkakar: aww, you'll hurt its feelings [09:51] jml: It's much better than C++, from what I can tell so far. [09:51] jml: Good. :) [09:51] heh heh [09:52] jml: Actually, I love C++... the way you have to think... the weird crap that comes up that is completely unrelated to your problem... template metaprogramming... [09:52] jml: But I never ever ever want to maintain a real system written in C++ (I've done it, I know how much it sucks). [09:53] it is far smaller [09:54] at least one order of magnitude less complexit in the language, probably two [09:54] of course it is younger [09:54] lifeless: wgrant Hi, I've recently used the new (to me that is) "RECURSIVE WITH" SQL feature ... and I did this with store.execute(...) ... Is there a way to do this properly with Storm? (I saw only raw sql statements using RECURSIVE WITH in the existing code) [09:54] poolie: Yes, that's a nice way to put it. It is younger, but it already has a very nice set of libraries (both builtin and community contributed). [09:55] poolie: It's also cool that they're still evolving the language and not promising backwards compatibility... things are moving, it's not a dead language. [09:55] This is the branch in question FYI https://code.launchpad.net/~rvb/launchpad/distro-overlay2-bug-758908-dependencies/+merge/61110 [09:55] rvba: lib/lp/blueprints/model/specification.py [09:56] rvba: the WITH query still has to be raw SQL at the moment. [09:56] rvba: But the rest can be Storm. [09:56] jkakar: i'v been wondering what will bring erlang-like ideas to the mainstream [09:56] this may be it [09:57] wgrant: ok thanks. Since my query is only a RECURSIVE WITH query, it will stay the way it is now then. [09:57] wgrant: if it's not too late i'd appreciate your thoughts on https://code.launchpad.net/~mbp/launchpad/uniqueid-clue/+merge/61153 [09:57] i guess specifically if it's likely to overall help worth the trouble [09:57] poolie: Er, tests depend on the format? Ew. [09:58] doctests stab stab [09:58] How many? [09:58] becasue of course if you have [09:58] >>> thing.name [09:58] generic-.... [09:58] then you will get a decent error if it fails whereas [09:58] >>> thing.name == expected [09:58] True [09:59] then it says nothing useful [09:59] Ah, yes. [10:00] oh not that many [10:00] 7 failures, 5 errors [10:00] I think you should remove those contract violations and land it :) [10:00] poolie: Indeed. [10:01] thanks [10:02] in particular "if something unexpected happens just die" as a strong default makes so much sense [10:02] rvba: store.with_ [10:02]